mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-10 06:58:59 +02:00
Garry TanandClaude Fable 5
f349d7c894
The #2077 demotion of these four stochastic tests to 'periodic' was inert: E2E_TIERS declared periodic but the files self-gated on EVALS_TIER === 'gate', so they kept running in the blocking gate lane and never in the weekly lane. Flip the four self-gates to 'periodic' (headers/describe labels updated), add a free static tier-alignment invariant test (dep-list filename mapping; unmapped self-gated files are reported, never silently skipped), and name the two plan-mode test files in their own touchfiles dep lists so the invariant binds for them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
53 lines
2.2 KiB
TypeScript
53 lines
2.2 KiB
TypeScript
/**
|
|
* /plan-eng-review AskUserQuestion floor regression (periodic, paid, real-PTY).
|
|
*
|
|
* Catches the May 2026 transcript bug where /plan-eng-review wrote a
|
|
* multi-section review plan to ~/.claude/plans/ and called ExitPlanMode
|
|
* without firing any AskUserQuestion. See
|
|
* `.context/attachments/pasted_text_2026-05-06_10-25-23.txt`.
|
|
*
|
|
* Uses runPlanSkillFloorCheck — a minimal "did the agent fire ANY AUQ?"
|
|
* observer that exits early on the first non-permission numbered-option
|
|
* render. See claude-pty-runner.ts for why this is separate from the
|
|
* runPlanSkillCounting harness used by periodic finding-count tests.
|
|
*
|
|
* Tier: periodic. Budget: 10 min (early exit on success ~30-90s typical).
|
|
* Cost: ~$0.50-$1.50 per run depending on early-exit timing.
|
|
*/
|
|
|
|
import { describe, test } from 'bun:test';
|
|
import { runPlanSkillFloorCheck } from './helpers/claude-pty-runner';
|
|
import { FORCING_FLOOR_ENG } from './fixtures/forcing-finding-seeds';
|
|
|
|
const shouldRun = !!process.env.EVALS && process.env.EVALS_TIER === 'periodic';
|
|
const describeE2E = shouldRun ? describe : describe.skip;
|
|
|
|
describeE2E('/plan-eng-review AskUserQuestion floor (periodic)', () => {
|
|
test(
|
|
'seeded forcing finding causes the agent to fire at least one AskUserQuestion',
|
|
async () => {
|
|
const obs = await runPlanSkillFloorCheck({
|
|
skillName: 'plan-eng-review',
|
|
slashCommand: '/plan-eng-review',
|
|
followUpPrompt: FORCING_FLOOR_ENG,
|
|
cwd: process.cwd(),
|
|
timeoutMs: 600_000,
|
|
env: { QUESTION_TUNING: 'false', EXPLAIN_LEVEL: 'default' },
|
|
});
|
|
|
|
if (obs.outcome !== 'auq_observed') {
|
|
throw new Error(
|
|
`floor test FAILED: outcome=${obs.outcome} elapsed=${obs.elapsedMs}ms\n` +
|
|
`summary: ${obs.summary}\n` +
|
|
`If outcome is plan_ready or completion_summary, this is the transcript-bug ` +
|
|
`regression — agent reached terminal without firing AskUserQuestion. See ` +
|
|
`.context/attachments/pasted_text_2026-05-06_10-25-23.txt.\n` +
|
|
`If outcome is timeout, agent may just be slow — re-run or increase budget.\n` +
|
|
`--- evidence (last 3KB) ---\n${obs.evidence}`,
|
|
);
|
|
}
|
|
},
|
|
660_000,
|
|
);
|
|
});
|