mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-31 18:30:39 +02:00
Garry TanandClaude Fable 5
29d94a505d
The 9 make-pdf/test/e2e gate tests probe make-pdf/dist/pdf, browse/dist/browse, and the diagram-render bundle, then self-skip when absent. The required free-tests lane never built any of them, so the gates silently skipped on Linux for their entire life (verified: 9 of 14 skip, exit 0). make-pdf-gate.yml's justification for deleting its Linux leg claimed the free lane covered this — it didn't. - new build:gates script: exactly the three artifacts the gates probe (full bun run build compiles five binaries; ~60-90s tax on the only required check is not warranted) - free-tests.yml: build:gates step + poppler-utils + fonts-noto-color-emoji (fonts must precede the first browse daemon launch — Chromium snapshots fontconfig at startup; verified live: a warm daemon renders tofu, a fresh one embeds NotoColorEmoji) - make-pdf/test/e2e/ci-prereqs.test.ts: GSTACK_EXPECT_BINARIES=1 (set by the workflow) inverts the skip polarity in CI — dropping the build step or poppler fails the lane instead of re-opening the silent-skip hole Pre-flight: all 9 gates green on Linux locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
98 lines
3.3 KiB
YAML
98 lines
3.3 KiB
YAML
name: make-pdf copy-paste gate
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
paths:
|
|
- 'make-pdf/**'
|
|
- 'lib/diagram-render/**'
|
|
- 'test/diagram-render-drift.test.ts'
|
|
- 'browse/src/meta-commands.ts'
|
|
- 'browse/src/write-commands.ts'
|
|
- 'browse/src/commands.ts'
|
|
- 'browse/src/cli.ts'
|
|
- 'scripts/resolvers/make-pdf.ts'
|
|
- 'package.json'
|
|
- '.github/workflows/make-pdf-gate.yml'
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: make-pdf-gate-${{ github.head_ref || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
gate:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
# macOS only: the Linux leg is covered by the free-tests lane, which
|
|
# builds the gate binaries (build:gates) and runs make-pdf/test
|
|
# (incl. e2e/) on every PR via the canonical runner, with
|
|
# GSTACK_EXPECT_BINARIES=1 arming ci-prereqs.test.ts so the gates
|
|
# can never silently self-skip there again. This gate's remaining
|
|
# value is macOS rendering coverage on make-pdf-scoped changes.
|
|
os: [macos-latest]
|
|
# Windows is tolerant-mode — Xpdf / Poppler-Windows extraction
|
|
# differs enough from the Linux/macOS baseline that the strict
|
|
# exact-diff gate is unreliable. Enable once the normalized
|
|
# comparator proves tolerant enough (Codex round 2 #18).
|
|
#
|
|
# include:
|
|
# - os: windows-latest
|
|
# tolerant: true
|
|
|
|
runs-on: ${{ matrix.os }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- uses: oven-sh/setup-bun@v2
|
|
with:
|
|
bun-version: latest
|
|
|
|
- name: Install dependencies
|
|
run: bun install --frozen-lockfile
|
|
|
|
- name: Install poppler (macOS)
|
|
if: matrix.os == 'macos-latest'
|
|
run: brew install poppler
|
|
|
|
- name: Install poppler-utils (Ubuntu)
|
|
if: matrix.os == 'ubicloud-standard-8'
|
|
run: sudo apt-get update && sudo apt-get install -y poppler-utils
|
|
|
|
# Install a color-emoji font BEFORE Chromium launches so the emoji render
|
|
# gate has a fallback font. macOS ships Apple Color Emoji already.
|
|
- name: Install color-emoji font (Ubuntu)
|
|
if: matrix.os == 'ubicloud-standard-8'
|
|
run: |
|
|
sudo apt-get install -y fonts-noto-color-emoji
|
|
fc-cache -f || true
|
|
fc-match -f '%{family[0]}\t%{color}\n' ':lang=und-zsye:charset=1F600' || true
|
|
|
|
- name: Install Playwright Chromium
|
|
run: bunx playwright install chromium
|
|
|
|
- name: Build binaries
|
|
run: bun run build
|
|
|
|
- name: ad-hoc codesign (Apple Silicon)
|
|
if: matrix.os == 'macos-latest'
|
|
run: |
|
|
for bin in browse/dist/browse browse/dist/find-browse design/dist/design make-pdf/dist/pdf; do
|
|
codesign --remove-signature "$bin" 2>/dev/null || true
|
|
codesign -s - -f "$bin" || true
|
|
done
|
|
|
|
- name: Log toolchain versions
|
|
run: |
|
|
echo "OS: ${{ matrix.os }}"
|
|
bun --version
|
|
which pdftotext && pdftotext -v 2>&1 | head -1 || true
|
|
|
|
- name: Run make-pdf unit tests
|
|
run: bun test make-pdf/test/*.test.ts test/diagram-render-drift.test.ts
|
|
|
|
- name: Run E2E gates (combined-features copy-paste + emoji render)
|
|
env:
|
|
BROWSE_BIN: ${{ github.workspace }}/browse/dist/browse
|
|
run: bun test make-pdf/test/e2e/
|