mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 22:14:25 +01:00
* test(qa-callers): bind QA section names in the caller prompt instead of teaching helper forms (W3-4)
The caller session prompt taught full capture/checkpoint syntax but only
mentioned materialize, so two ship-exploratory-small-cli sessions (paid
gate runs 38973329985, 38993076767) skipped qa/sections/exploratory.md and
system-functional.md and guessed a bare materialize. The prompt now
declares only fixture bindings (DEADLINE_TOOL, EVIDENCE_TOOL, PROBE_DIR,
DEADLINE_FILE, --public approval, --timeout-ms 10000 for plan probes) and
points to the section for every form. The read requirement is unchanged;
both captured transcripts are kept as negative controls.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): run the state-machine detector in the scope block and check its exit status (W3-5)
Specialist 9 named gstack-state-matrix detect only in selection prose, and
small diffs keep only State Machines, so agents ran an undeclared command
(paid gate run 39002269281). The generated scope block now runs the
detector with its exit status checked: on failure it keeps the detector's
diagnostics and sets SCOPE_STATE_MACHINE=unknown, and selection dispatches
State Machines when the signal is true or unknown. The check step becomes a
declared heredoc block. The clarity test requires every non-diff-scope
signal to come from a detect helper the scope block runs; a free test runs
the block against a failing detector stub; the captured standalone call
stays outside the caller interface.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(third-party-actions): letter the absent-Aside consent options B/C/D (W3-7)
The contract fixed letters only when Aside is detected, so a tpa-absent-linux
agent numbered its consent question 1/2/3 (paid run 39011101113), which the
lettered-offer inspection cannot read. The absent branch now offers
B) gstack's own visible browser, C) manual instructions, D) defer and omits
A). The paid test's assertion is unchanged; the captured numbered answer is
a documented fail example in the unit test.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(plan-reality): say tier 1 rows are never n/a (W3-8)
The plan-review reality block offered pass|finding|n/a without saying tier 1
rows may never be n/a, so a plan-mode-no-op session wrote
`REALITY: deferred-asks n/a ...`, check returned repair, and the repair loop
ran past the 300 s capture (paid run 39004466422). The block now says tier
1 rows are never n/a and that with no linked issue deferred-asks is pass
with a receipt showing none. The captured line is pinned through check as
missing=deferred-asks verdict=repair.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): webhook fix runs re-verify the repaired invariant and rerun superseded captures (W3-6, W3-14)
W3-6: stage 2 of the fix-run prompt asked only for the original, happy,
cancel and dependency probes while verifyQANativeRegression reruns all
eight, so a status-only repair that left partial broken reached the verifier
(paid run 38986120559). The webhook fix prompt now states the capture budget
up front (at most 5 pre-repair captures, then the 7 post-repair scenarios:
duplicate, partial, concurrent-ab, concurrent-ba, happy, cancel, dependency;
12 in total; report incomplete if 5 cannot establish the defect). That list
feeds the capture nudge (GSTACK_QA_REQUIRED_PROBES);
QA_WEBHOOK_REQUIRED_SCENARIOS and the verdict are unchanged.
W3-14: the fix prompt now says to rerun every pre-repair capture the
verdict relies on after the final repair, and that a superseded row stays
open until its command reran on the repaired source (paid run 39053431488
labelled a pre-repair duplicate superseded and never reran it). The
detector and its negative test are unchanged; the captured shape joins them
as a negative control.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): tie the exploratory stop rule to per-rule input probes; fix runs close superseded captures (W3-9, W3-14)
W3-9: two qa-functional-cli-report sessions stopped at 5-7 of 12 probes
without probing a non-digit amount (paid runs 38983306684, 39001107574),
though system-functional.md requires one probe per documented input rule.
The single stop rule shared by both exploratory templates now says each
documented input rule needs its own probe breaking only that rule, and
rules left uncovered at a probe or time cap go in limits.
W3-14: for fix runs (not qa-only), every capture taken before a fix is
superseded even when its client prints no snapshot; before completion the
agent reruns each one its verdict relies on or reports it as an open
remainder. Production superseded/open semantics are unchanged.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): keep the captured webhook-report cat attempts as denied negative controls (Q3)
Paid run 39006896632 (qa-functional-webhook-report) attempted
`cat package.json probe.ts .gitignore` and `cat src/*.ts test/*.ts`; the
PreToolUse hook denied both. This is a model miss, not a detector defect, so
both commands are pinned as denied by the registered hook and outside
qaCommandAllowed. No detector change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docs-candidate): per-subcommand --help and a compare reject that names the fix (W3-2)
snapshot --help and compare --help print the usage and exit 0 before any side
effect; the docsync observer admits exactly those two forms. compare names the
record path, each missing or wrong field (schema_version, base, hashes) and
the snapshot command that writes a valid record, keeping exit 1. The captured
ship-docsync-stale-after commands from PR gate run 38990111230 replay inside
the interface; help with any other argument stays rejected.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docsync-fault): prepare writes the production candidate through the installed snapshot (W3-1)
The fault actor prepare wrote its own {base_sha, content_hashes, ...} record,
which the installed gstack-docs-candidate compare rejects, while
ship/sections/documentation.md requires running compare; 79 of 198 docsync
captures (and the red in PR gate run 38990111230) were pushed off the
documented path by it.
prepare now runs the installed snapshot under a 30 s timeout for the same
selection, returns its exact command as snapshot_command so the post-child
rerun is literal, publishes prompt and event only after a valid record
exists, and removes a record its own failed snapshot left. dispatch observes
the candidate with the same installed snapshot; inspect returns base, index
and per-file git blob ids in the record representation; the legacy re-audit
check reads selected/hashes. The fault prompt names snapshot_command and the
new field names.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(todos): file the qa-quick capture headroom follow-up (fix wave 3, T)
qa-quick timed out once at 300 s (paid run 38980005793) against passing
runs of 164-272 s. Trimming what the Quick tier loads is a product call, so
it is filed, not repaired; no budget change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(docsync): keep the two docsync model misses as negative controls (W3-3)
The Bash grep of ship-docsync-missing-asset (PR gate run 38983306684,
bash#13) and the composed cat; cat of ship-docsync-failure (38984977679,
bash#12) were correct rejections. They join the stored known_bad commands
(with a {home} placeholder for the fixture home); no detector change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(golden): refresh the ship goldens for the W3-5 scope block and W3-7 consent letters
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(third-party-actions): state the absent-Aside letters in fewer characters (W3-7)
Same contract (B), C), D) when Aside is not detected; the next sentence
already omits the Aside option), 67 fewer characters on the pinned
land-and-deploy and office-hours skills.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(skill-md-size): re-pin 31 over-limit skills grown by fix wave 3 prompt repairs (owner sign-off needed)
CREW rule 11: these skills were already over 100,000 characters and grow
by the minimum text each repair needs; none crosses the limit for the
first time.
- gstack-review on cursor, factory, kiro, opencode, slate (+657..+676):
W3-5 runs gstack-state-matrix detect inside the scope block with its exit
status checked and declares the check step as a heredoc block; the new
fence carries the env-var-host runtime prelude (about 360 characters).
- gstack-plan-eng-review on 12 hosts (+104): W3-8 says tier 1 reality rows
are never n/a (paid run 39004466422 looped on a rejected n/a row).
- gstack-land-and-deploy on 12 hosts and gstack-office-hours on 4 hosts
(+21): W3-7 letters the absent-Aside consent options B), C), D).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(skills): fit the W3-5, W3-7 and W3-8 prompt repairs inside the parity budgets
The parity suite left 2-42 bytes of headroom on ship, review,
plan-eng-review, plan-ceo-review and land-and-deploy, so each repair now
pays for itself in the same resolver:
- W3-5: the scope block runs `source <(gstack-state-matrix detect --base
<base> || echo SCOPE_STATE_MACHINE=unknown)` (a failed detector's
stdout is overridden by the later unknown assignment; its stderr still
shows), the check block uses a short heredoc, and DIFF_LINES comes from one
`git diff --numstat | awk` sum instead of two --stat greps (same count:
insertions plus deletions, binary files zero).
- W3-7: the absent branch reads "offer only options B), C) and D)."
- W3-8: "never n/a" joins the tier 1 parenthesis, the no-linked-issue rule
joins the receipt sentence, and the deep header says the same in fewer
words; the redundant "(it prints the PLAN_REALITY: line)" is dropped.
Size pins: land-and-deploy (12 hosts, -20), office-hours (4 hosts, -20)
and plan-eng-review (12 hosts, -10) are lowered to their new sizes;
gstack-review on cursor, factory, kiro, opencode and slate stays above its
main pin (+355..+374) because the declared check block is a new fence that
carries the env-var-host runtime prelude. Raising those five pins needs
owner sign-off.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(design-e2e): the shim-dom scan check resolves the command's literal _REPORT/_RUN (W3-10)
PR gate run 38980005793 went red because the agent ran the generated DOM
block, scanning "$_REPORT/dom/$_RUN" with _RUN="run1" assigned in the same
command, and the check looked for the literal dom/run1 anywhere in a command.
domScanOfRun substitutes that command's own literal _REPORT=/_RUN=
assignments and credits a scan only when one of its own arguments is the run
directory. scan --changed, another directory, quoted heredoc report text and
non-literal or conflicting assignments stay negative controls. All 15
captured shim-dom runs in the window pass the new check (14 passed the old).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(pty): keep the last non-blank viewport for failure dumps (W3-11)
autoplan-guard-pty (PR gate run 38976253774) stalled at 489 s and its screen
dump, the tail of visibleText(), was only spinner redraws. Live PTY sessions
now remember the last non-blank viewport a screen read returned
(session.lastScreen()) and the harness wait-timeout dumps append it.
Diagnostic only: visibleText(), matching and verdicts are unchanged.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(autoplan): explicit 30 s timeout for each answer-invalidation test (W3-12)
The eng-only override test ran 4.1-4.4 s on a 4-core machine against Bun's
5 s default (7.8-9.4 s per file). Each test now names a 30 s budget.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(review-army): size the nested bun test budgets for windows-latest (W3-15)
windows-free-tests run 39053431430 (shard 5): the nested bun test exited 1 in
5.58 s because Bun's default 5 s hook timeout fired on the real Red Team
beforeAll (8 git spawns plus skill-section copies). Both nested argvs pass
--timeout 30000, which raises only the nested default; the registrations
under test keep their explicit timeouts. Spawn timeouts move from 8 s to
40 s and outer test timeouts to 45 s, including the consensus test that had
none. With a 6 s beforeAll injected, the lifecycle still matches; the old
argv reproduces the Windows hook timeout.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(todos): close the createQAFunctionalFixture entry and file D6 (W3-13)
The git auto-maintenance entry was fixed by 0bf9d50 (#3190). D6: nested bun
test output pollutes free-runner failure attribution in
scripts/lib/shard-engine.ts (windows-free-tests 39053431430).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(free-fixtures): declare the W3-4 captured caller transcript as a free-only fixture
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(pty): strip cursor-visibility escapes and print the last screen on autoplan-guard-pty failure (W3-11)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): keep the state-machine detector's output only on exit 0 (W3-5 confirm round)
A failing gstack-state-matrix detect prints SCOPE_STATE_MACHINE=false before
exiting non-zero. The scope block now captures its output and sources it only
when the detector succeeds; otherwise it discards the output, sets
SCOPE_STATE_MACHINE=unknown (dispatching the State Machines specialist) and
leaves the detector's stderr visible. Free tests cover false-output/non-zero,
empty-output/non-zero and a late failure after printing true. The stack
comment is shortened so gstack-review stays 4 chars under its pin; the five
host pins are lowered to match.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): reserve webhook post-repair reruns first inside the unchanged 12-capture ceiling (W3-6/W3-14 confirm round)
The fix prompt now states precedence: post-repair reruns (the 7 stage-2
scenarios plus each distinct pre-repair command the verdict relies on, such as
a reject probe) are reserved first, pre-repair exploration gets what remains,
and reruns that cannot fit are reported as open. A free test fits a pre-repair
reject plus the reproduced defect and its replay within 12 (11 captures).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docs-candidate): the compare reject never sends an agent to re-snapshot after the child audit (W3-2)
A post-audit snapshot over the candidate replaces the before-audit baseline, so
the ownership check would compare current files with themselves. The fix line
now says the candidate must be the record the Prepare snapshot wrote, that the
Prepare snapshot is rerun only before dispatching the child audit, and that the
post-child snapshot uses a different --out (<audit-id>-post.json). The helper
test pins the text.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(docsync-fault): diagnosable prepare snapshot failures with one fresh-id retry (W3-1)
A failed installed snapshot now returns exit 25 with a stable reason code
(snapshot_exit, snapshot_timeout, snapshot_spawn_error, snapshot_invalid_record),
the helper's stderr tail redacted through lib/redact-engine with the fixture
root as <HOME> and bounded to 800 characters, and keeps the attempt's files: the
candidate the helper left, if any, and prepare-<audit-id>-failure.json. The
failure is a prepare-failed event, not a rejected interaction. One retry is
allowed under a fresh audit id; reusing the failed id, dispatching it or a third
prepare is rejected. Tested before and after candidate creation. The two
snapshot tests get an explicit 30 s timeout: the compare/inspect agreement
test runs 4.3-4.8 s alone and timed out at Bun's 5 s default under load.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa-evidence): count required post-repair probes only after the fixture-declared final source edit (W3-6/W3-14 confirm round)
GSTACK_QA_REQUIRED_PROBES reminders counted any complete capture, so a
pre-repair duplicate or partial capture looked like post-repair coverage. The
caller may now declare GSTACK_QA_REQUIRED_AFTER_EDIT with absolute paths and a
clean-fixture time: only captures started after the last edit under those
paths count, none count before the first edit, and a malformed declaration
counts none. Without the declaration every capture counts as before. The
webhook fix fixture declares its src/ directory. A free test covers
pre-repair-only coverage (nudges), complete post-repair coverage (no nudge)
and a second edit (nudges again).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(harness): bump HARNESS_VERSION to 5 for the W3-11 stripAnsi change
stripAnsi now removes cursor-visibility escapes (ESC[?25h/l). Every PTY case
matches patterns against its output, so a pattern spanning one of those escapes
can now match where it did not before: a verdict can change, so this is a
behavioral bump, not a non-behavioral entry. The launch.ts change (last
non-blank screen in failure messages) is diagnostic only.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): pass the state-machines output to check as a written file, not a heredoc placeholder (W3-5)
The generated-bash lint (env-host-fence-conformance INV-3) rejects free text in
a heredoc body: <its complete output> reached the shell. The agent now writes
the specialist's full output to .gstack/tmp/state-machines.md and the fence
runs gstack-state-matrix check on that file. Two stack-detection comments and
the parenthetical are trimmed to stay inside the review/ship parity ratios;
gstack-review shrinks by 33 on the five pinned hosts and their pins are
lowered to match.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(autoplan-guard-pty): the scripted actor ends its turn after a background CEO dispatch before reading the close packet
PR gate 39070276914 (dc739be) failed at the close-packet check while gate
39069171159 (b789898) passed with byte-identical autoplan inputs. The evidence
differs only in order: the failing actor read the close packet in the dispatch
turn, so the first tool call after the CEO notice was the publication. The
product guard allowed all four guarded calls in both runs. The fixture step 5
told the actor to end its turn only conditionally; step 5 now ends the turn as
soon as the result says the agent runs in the background, and step 6 reads the
close packet only after the reviewer finished. The close-packet check moves to
closePacketReadAfterNotice, replayed in a free test against both captured
orders; a second free test pins the actor's steps 5 and 6.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore(release): v1.91.127.0 fix wave 3 paid-gate reliability round 2
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): input-rule probes are per field, and a value breaking two rules covers neither (W3-9)
PR gate 39073934326 (93449bc) failed qa-functional-cli-report with no observed
unannounced defect, the same class as 38983306684 and 39001107574. The agent
read 'allowed characters' as the ID rule only, counted -5 as its sign probe
and never probed the amount's digits-only rule with an otherwise valid value,
so the seeded parseInt defect stayed hidden. The stop rule now says each
field's documented input rule needs a probe breaking only it, and that a
signed amount breaks sign and digits-only and covers neither; the functional
table row names input rules per field. The qa union stays inside its parity
ratio.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): state the input-rule principle instead of a worked example (W3-9)
The signed-amount example in 0fe616e was misread in the focused rerun as 'a
signed amount breaks only the digits-only rule', and the run again missed
the seeded non-digit defect. The stop rule now states the principle: each
field's documented input rule needs a probe that breaks only it and satisfies
every other rule.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(tpa): the Darwin pitch detector accepts the canonical phrase anywhere, short forms only at a sentence start
PR gate 39075977549 (d6d82fb) failed tpa-absent-darwin on a correct pitch:
'One-time note: you can download Aside (macOS 15+) at aside.com, then open it,
sign in, and re-run'. The contract is to deliver the pitch once; the
sentence-start anchor exists only so narration is not counted. The full
canonical phrase now counts anywhere unless a negation precedes it, and the
short forms (download it / download Aside at aside.com) keep the
sentence-start rule. The detector moves to test/helpers/third-party-actions.ts
with a count helper. Free tests replay the captured red (counts once), the
four captured passing Darwin pitches (once each), five Linux and five READY
narrations plus both recovery-public responses (zero), a mid-sentence short
form and negated phrases (zero), and a duplicated phrase (two).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-callers): only a required plan check may swap the deadline for --timeout-ms; reruns keep the deadline
PR gate 39077524802 (0f71a55) failed ship-exploratory-late-input: after the
late input change the actor reran captures 001 and 002 with --timeout-ms
10000, reading the fixture's 'explicit plan probes outside the smoke budget'
clause as covering revalidation reruns, and the verifier reported both as
smoke probes missing a trusted deadline run. The binding now says only an
explicit plan check this phase requires may use --timeout-ms, and every other
capture, including a rerun or revalidation, uses the deadline.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(third-party-actions): count the Darwin pitch only at a recommendation boundary
/review delta on 51f1e02 (Claude and GPT-6.1 Sol voices): the 0f71a55
detector accepted the canonical phrase anywhere unless the adjacent word was
a negation, so a Darwin refusal or a quoted policy mention ('I will not ask
you to download Aside ...', 'The Darwin policy says to "download Aside ..."',
'You cannot download ...') satisfied the paid case's positive match, and a
free assertion even expected "You don't need to download ..." to count.
The canonical phrase now counts only where a recommendation can start: a
sentence, clause (, : ; dash), bullet, line or bold start, optionally led by
then/please/just/so/first/now and you can/could/may/should/need to, with no
negation directly before it across a line break. Quoted, parenthesised,
reported and clause-negated mentions fall outside that boundary. Every probe
from both voices is a free test; the five captured Darwin pitches (including
the 39075977549 red) still count 1 each and the Linux/READY captures 0.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): write the state-machines output to a fresh private file from gstack-state-matrix outfile
/review delta on 51f1e02 (Claude F2): dc739be wrote the specialist output to
a fixed .gstack/tmp/state-machines.md with no exclude. On a second review
Claude Code's Write refuses an existing unread file, so check could validate
the previous run's output, and git add -A could commit it.
gstack-state-matrix outfile creates .gstack/tmp (0700) at the repo top,
adds /.gstack/tmp/ to info/exclude once, and prints a new empty 0600 file
per call; the selection prose has the agent Read that file, write the full
output there and check that path. The prose moved the check command inline,
so gstack-review shrinks and its pins are lowered (cursor 141010->140637,
factory 144792->144416, kiro 140816->140449, opencode 143258->142872,
slate 140913->140543).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-evidence): pin the post-repair edit's mtime to capture 002's completion
The GPT voice's /review run on 51f1e02 failed qa-evidence.test.ts:547 once:
capture 003 reported no required probe remaining, so capture 002 (started
before the edit) counted as post-edit. The test wrote the edit right after
002 returned, a gap of one child run (7-27 ms measured here; the voice's
machine ran this test in 59 ms against 183 ms here, so a few ms there),
while an ext4 mtime comes from the kernel's coarse clock and lags
Date.now() by up to a tick (0.5-4.5 ms measured here).
The edit's mtime is now set to 002's recorded completedAt, so 002 started
strictly before the boundary and 003 starts after it on any machine. The
product boundary is unchanged: tick-scale imprecision only matters when a
capture starts within milliseconds before an edit, and a stricter margin
would refuse a real edit && capture chain.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
390 lines
26 KiB
TypeScript
390 lines
26 KiB
TypeScript
/**
|
||
* Plan D1: reality rows in plan reviews. Pins the row ids, the `REALITY:` line
|
||
* grammar, the checker's missing/unreceipted/n/a branches, the bin's exit codes
|
||
* and `PLAN_REALITY:` line, the unattended `incomplete` verdict, and that the
|
||
* rendered plan-review skills and autoplan phase files carry the contract.
|
||
* Each tier 1 row has a positive fixture from this wave's own review record
|
||
* (test/fixtures/multi-agent-wave/reality-rows.json, receipts verified against
|
||
* the record) and a decoy that must not count. Prose is not pinned.
|
||
*/
|
||
import { describe, expect, test } from 'bun:test';
|
||
import { spawnSync } from 'node:child_process';
|
||
import * as fs from 'node:fs';
|
||
import * as os from 'node:os';
|
||
import * as path from 'node:path';
|
||
import { EXIT } from '../lib/headless-artifacts';
|
||
import { PLAN_REALITY_CHECKER, REALITY_ROWS, REALITY_SCOPES, TIER1_ROW_IDS, checkPlanReality, checkRealityRows, parseRealityLines, parseScopes, renderIncidentTable, renderRows, requiredRows, vaguePlanTerms } from '../lib/plan-reality';
|
||
import { extractHeading } from '../lib/autoplan-prompts';
|
||
import { RESULT_CODES } from '../lib/result-codes';
|
||
import { generatePlanRealityRows } from '../scripts/resolvers/plan-reality';
|
||
import type { TemplateContext } from '../scripts/resolvers/types';
|
||
|
||
const ROOT = path.resolve(import.meta.dir, '..');
|
||
const BIN = path.join(ROOT, 'bin', 'gstack-plan-reality');
|
||
const FIXTURE = JSON.parse(fs.readFileSync(path.join(ROOT, 'test', 'fixtures', 'multi-agent-wave', 'reality-rows.json'), 'utf8')) as {
|
||
rows: Record<string, { positive: string; source: { file: string; lines: [number, number]; contains: string }; decoy: string; decoy_kind: string; metric?: Record<string, string> }>;
|
||
};
|
||
const positives = Object.values(FIXTURE.rows).map(r => r.positive).join('\n');
|
||
|
||
function run(args: string[], input?: string, env: Record<string, string> = {}) {
|
||
const r = spawnSync('bun', [BIN, ...args], { cwd: ROOT, encoding: 'utf8', timeout: 30_000, input, env: { ...process.env, GSTACK_SESSION_KIND: '', ...env } });
|
||
return { code: r.status, out: r.stdout, err: r.stderr };
|
||
}
|
||
|
||
describe('reality row table', () => {
|
||
test('seven tier 1 rows, every row has a check and an incident, ids are unique and scopes known', () => {
|
||
expect(TIER1_ROW_IDS).toEqual(['premise-table', 'already-done', 'surface-check', 'binding-decisions', 'numbers', 'deferred-asks', 'pr-count']);
|
||
expect(REALITY_ROWS.filter(r => r.tier === 2).length).toBe(11);
|
||
expect(new Set(REALITY_ROWS.map(r => r.id)).size).toBe(REALITY_ROWS.length);
|
||
for (const r of REALITY_ROWS) {
|
||
expect(r.check.length).toBeGreaterThan(20);
|
||
expect(r.incident.length).toBeGreaterThan(20);
|
||
expect(REALITY_SCOPES).toContain(r.scope);
|
||
expect(r.tier === 1 ? 'always' : 'scoped').toBe(r.scope === 'always' ? 'always' : 'scoped');
|
||
}
|
||
});
|
||
test('required rows: tier 1 always, tier 2 only for a detected scope', () => {
|
||
expect(requiredRows([]).map(r => r.id)).toEqual([...TIER1_ROW_IDS]);
|
||
expect(requiredRows(['db']).map(r => r.id)).toContain('transaction-semantics');
|
||
expect(requiredRows(['db']).map(r => r.id)).not.toContain('recall');
|
||
expect(parseScopes('db, search,bogus')).toEqual({ scopes: ['db', 'search'], unknown: ['bogus'] });
|
||
});
|
||
});
|
||
|
||
describe('REALITY: line grammar', () => {
|
||
test('parses id, status, receipt (path:line, path:line-line, sha) and key=value metrics; tolerates list and table prefixes', () => {
|
||
const lines = parseRealityLines([
|
||
'REALITY: premise-table finding 27 checked unverified=3 docs/x/ceo-native.md:11-37',
|
||
'- REALITY: already-done pass 0 hits 91bbd9e',
|
||
'| REALITY: surface-check finding bun upgrade bin/gstack-capy-install:52 |',
|
||
'REALITY: numbers pass 7 PRs 48 min',
|
||
'REALITY: transaction-semantics n/a scope db absent',
|
||
'reality: not-a-row pass lower-case prefix is not the grammar',
|
||
].join('\n'));
|
||
expect(lines.map(l => [l.id, l.status, l.receipt])).toEqual([
|
||
['premise-table', 'finding', 'docs/x/ceo-native.md:11-37'],
|
||
['already-done', 'pass', '91bbd9e'],
|
||
['surface-check', 'finding', 'bin/gstack-capy-install:52'],
|
||
['numbers', 'pass', null],
|
||
['transaction-semantics', 'n/a', null],
|
||
]);
|
||
expect(lines[0]!.metrics.unverified).toBe('3');
|
||
});
|
||
});
|
||
|
||
describe('checkRealityRows', () => {
|
||
test('every tier 1 positive fixture from the review record passes and the premise metric is scored', () => {
|
||
const r = checkRealityRows(positives, { phase: 'ceo', sessionKind: 'unattended' });
|
||
expect(r.missing).toEqual([]);
|
||
expect(r.unreceipted).toEqual([]);
|
||
expect(r.verdict).toBe('complete');
|
||
expect(r.metrics).toEqual({ unverified: '3' });
|
||
expect(r.line).toBe('PLAN_REALITY: phase=ceo rows=7/7 missing=none unverified=3 verdict=complete');
|
||
});
|
||
test('each positive receipt points into the review record at the stated lines', () => {
|
||
for (const [id, row] of Object.entries(FIXTURE.rows)) {
|
||
const text = fs.readFileSync(path.join(ROOT, row.source.file), 'utf8').split('\n');
|
||
const [from, to] = row.source.lines;
|
||
const excerpt = text.slice(from - 1, to).join('\n');
|
||
expect(excerpt, `${id}: ${row.source.file}:${from}-${to}`).toContain(row.source.contains);
|
||
const parsed = parseRealityLines(row.positive)[0]!;
|
||
expect(parsed.id).toBe(id);
|
||
expect(parsed.receipt, `${id} carries a receipt`).not.toBeNull();
|
||
expect(row.positive).toContain(`${row.source.file}:${from}`);
|
||
}
|
||
});
|
||
test('each decoy fails for its own row while the other six positives stand (negative control per row)', () => {
|
||
for (const [id, row] of Object.entries(FIXTURE.rows)) {
|
||
const others = Object.entries(FIXTURE.rows).filter(([k]) => k !== id).map(([, r]) => r.positive);
|
||
const r = checkRealityRows([...others, row.decoy].join('\n'), { phase: 'eng' });
|
||
expect([...r.missing, ...r.unreceipted], `${id} decoy (${row.decoy_kind}) must not count`).toEqual([id]);
|
||
expect(r.verdict).toBe('repair');
|
||
}
|
||
});
|
||
test('a review that only talks about the rows in prose has every row missing', () => {
|
||
const prose = 'The premises were checked and already-done work was considered. Surface check done. Numbers estimated.';
|
||
const r = checkRealityRows(prose, { phase: 'ceo', sessionKind: 'unattended' });
|
||
expect(r.missing).toEqual([...TIER1_ROW_IDS]);
|
||
expect(r.verdict).toBe('incomplete');
|
||
expect(r.line).toContain('rows=0/7');
|
||
});
|
||
test('verdict word: unattended → incomplete, anything else → repair; complete needs no session kind', () => {
|
||
const partial = positives.split('\n').slice(0, 6).join('\n');
|
||
expect(checkRealityRows(partial, { phase: 'eng', sessionKind: 'unattended' }).verdict).toBe('incomplete');
|
||
expect(checkRealityRows(partial, { phase: 'eng', sessionKind: 'interactive' }).verdict).toBe('repair');
|
||
expect(checkRealityRows(partial, { phase: 'eng' }).verdict).toBe('repair');
|
||
expect(checkRealityRows(partial, { phase: 'eng' }).missing).toEqual(['pr-count']);
|
||
});
|
||
test('tier 2 rows: required only under their scope; n/a is accepted off-scope and a tier 1 n/a is missing', () => {
|
||
const withNa = `${positives}\nREALITY: transaction-semantics n/a no db change`;
|
||
expect(checkRealityRows(withNa, { phase: 'eng' }).missing).toEqual([]);
|
||
expect(checkRealityRows(withNa, { phase: 'eng', scopes: ['db'] }).missing).toEqual(['transaction-semantics']);
|
||
const dbRow = `${positives}\nREALITY: transaction-semantics pass idle, pooled and reserved traced lib/pool.ts:40-88`;
|
||
expect(checkRealityRows(dbRow, { phase: 'eng', scopes: ['db'] }).line).toContain('rows=8/8');
|
||
expect(checkRealityRows(positives.replace(/^REALITY: numbers finding/m, 'REALITY: numbers n/a'), { phase: 'eng' }).missing).toEqual(['numbers']);
|
||
});
|
||
test('a later real line outranks an earlier n/a for the same row; unknown row ids are reported, not counted', () => {
|
||
const r = checkRealityRows(`REALITY: already-done n/a\n${positives}\nREALITY: premises pass lookalike plan.md:1`, { phase: 'ceo' });
|
||
expect(r.missing).toEqual([]);
|
||
expect(r.unknownRows).toEqual(['premises']);
|
||
});
|
||
});
|
||
|
||
describe('gstack-plan-reality bin', () => {
|
||
test('--help prints the exit table and the line shape; no command is usage', () => {
|
||
const help = run(['--help']);
|
||
expect(help.code).toBe(EXIT.ok);
|
||
expect(help.out).toContain('Exit codes: 0 ok · 1 fail · 2 usage · 3 refused or needs a flag');
|
||
expect(help.out).toContain('REALITY: <row> pass|finding|n/a <summary> <file:line>');
|
||
expect(run([]).code).toBe(EXIT.usage);
|
||
expect(run(['rows']).code).toBe(EXIT.usage);
|
||
expect(run(['rows', '--phase', 'eng', '--scope', 'bogus']).code).toBe(EXIT.usage);
|
||
expect(run(['frob', '--phase', 'eng']).code).toBe(EXIT.usage);
|
||
});
|
||
test('rows prints the applicable rows; --scope adds tier 2; --json is JSON only', () => {
|
||
const plain = run(['rows', '--phase', 'eng']);
|
||
expect(plain.code).toBe(EXIT.ok);
|
||
for (const id of TIER1_ROW_IDS) expect(plain.out).toContain(`- ${id} (tier 1)`);
|
||
expect(plain.out).not.toContain('recall');
|
||
expect(run(['rows', '--phase', 'eng', '--scope', 'search']).out).toContain('- recall (tier 2, scope search)');
|
||
expect(run(['rows', '--phase', 'eng', '--deep']).out).toContain('Incident:');
|
||
const json = JSON.parse(run(['rows', '--phase', 'ceo', '--json']).out);
|
||
expect(json.rows.map((r: { id: string }) => r.id)).toEqual([...TIER1_ROW_IDS]);
|
||
});
|
||
test('check: complete exits 0; a miss exits 1 with REALITY_ROW_MISSING; unattended prints verdict=incomplete; stdin and --json', () => {
|
||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-plan-reality-'));
|
||
const file = path.join(tmp, 'review.md');
|
||
fs.writeFileSync(file, `prose\n${positives}\n`);
|
||
const ok = run(['check', '--phase', 'ceo', file]);
|
||
expect(ok.code).toBe(EXIT.ok);
|
||
expect(ok.out.trim()).toBe('PLAN_REALITY: phase=ceo rows=7/7 missing=none unverified=3 verdict=complete');
|
||
|
||
const partial = positives.split('\n').slice(1).join('\n');
|
||
const miss = run(['check', '--phase', 'eng', '-'], partial, { GSTACK_SESSION_KIND: 'unattended' });
|
||
expect(miss.code).toBe(EXIT.fail);
|
||
expect(miss.out).toContain('missing=premise-table verdict=incomplete');
|
||
expect(miss.err).toContain('(REALITY_ROW_MISSING)');
|
||
expect(miss.err).toContain('fix:');
|
||
|
||
const flag = run(['check', '--phase', 'eng', '-', '--session-kind', 'unattended'], partial);
|
||
expect(flag.out).toContain('verdict=incomplete');
|
||
const interactive = run(['check', '--phase', 'eng', '-'], partial);
|
||
expect(interactive.out).toContain('verdict=repair');
|
||
|
||
const unreceipted = run(['check', '--phase', 'ceo', '-', '--json'], `${partial}\n${FIXTURE.rows['premise-table']!.decoy}`);
|
||
expect(unreceipted.code).toBe(EXIT.fail);
|
||
const parsed = JSON.parse(unreceipted.out);
|
||
expect(parsed.unreceipted).toEqual(['premise-table']);
|
||
expect(unreceipted.err).toContain('(REALITY_RECEIPT_MISSING)');
|
||
const unreceiptedText = run(['check', '--phase', 'ceo', '-'], `${partial}\n${FIXTURE.rows['premise-table']!.decoy}`);
|
||
expect(unreceiptedText.out).toMatch(/^PLAN_REALITY: phase=ceo .*\bunreceipted=premise-table\b.* verdict=repair$/m);
|
||
expect(run(['check', '--phase', 'ceo', path.join(tmp, 'absent.md')]).code).toBe(EXIT.fail);
|
||
fs.rmSync(tmp, { recursive: true, force: true });
|
||
});
|
||
});
|
||
|
||
describe('captured tier 1 n/a (plan-mode-no-op, paid run 39004466422)', () => {
|
||
// The named-target plan-eng-review session marked deferred-asks n/a, check returned repair, and the repair loop ran
|
||
// past the 300 s capture before the first question.
|
||
const captured = 'REALITY: deferred-asks n/a no linked issue; the plan cites no request to compare against package.json:2';
|
||
test('check rejects the captured line as a missing row, and the skill text forbids it', () => {
|
||
const others = Object.entries(FIXTURE.rows).filter(([id]) => id !== 'deferred-asks').map(([, row]) => row.positive).join('\n');
|
||
const rejected = run(['check', '--phase', 'eng', '-'], `${others}\n${captured}\n`);
|
||
expect(rejected.code).toBe(EXIT.fail);
|
||
expect(rejected.out).toMatch(/^PLAN_REALITY: phase=eng rows=6\/7 missing=deferred-asks .*verdict=repair$/m);
|
||
expect(rejected.err).toContain('(REALITY_ROW_MISSING)');
|
||
const repaired = run(['check', '--phase', 'eng', '-'], `${others}\n${captured.replace(' n/a ', ' pass ')}\n`);
|
||
expect(repaired.out).toMatch(/^PLAN_REALITY: phase=eng rows=7\/7 missing=none .*verdict=complete$/m);
|
||
const rule = 'tier 1 always, never `n/a`: premise-table, already-done, surface-check, binding-decisions, numbers, deferred-asks, pr-count; tier 2 by detected scope, `--scope <csv>`). Every row cites a file:line receipt (with no linked issue, deferred-asks is `pass`)';
|
||
for (const phase of ['plan-eng-review', 'plan-ceo-review', 'plan-devex-review']) {
|
||
expect(generatePlanRealityRows({ skillName: phase, host: 'claude', paths: {} } as unknown as TemplateContext).replace(/\s+/g, ' ')).toContain(rule);
|
||
}
|
||
for (const rel of ['plan-eng-review/sections/review-sections.md', 'plan-ceo-review/SKILL.md']) {
|
||
expect(fs.readFileSync(path.join(ROOT, rel), 'utf8').replace(/\s+/g, ' ')).toContain(rule);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('rendered templates carry the contract', () => {
|
||
const read = (rel: string) => fs.readFileSync(path.join(ROOT, rel), 'utf8');
|
||
const ctx = (skillName: string) => ({ skillName, host: 'claude', paths: {} } as unknown as TemplateContext);
|
||
test('resolver variants name the bin, the tier 1 rows, the line shape and the unattended rule', () => {
|
||
const eng = generatePlanRealityRows(ctx('plan-eng-review'));
|
||
expect(eng).toContain('gstack-plan-reality rows --phase eng');
|
||
expect(eng).toContain('gstack-plan-reality check --phase eng');
|
||
for (const id of TIER1_ROW_IDS) expect(eng).toContain(id);
|
||
expect(eng).toContain('REALITY: <row> pass|finding|n/a <summary> <file:line>');
|
||
expect(generatePlanRealityRows(ctx('plan-ceo-review'))).toContain('--phase ceo');
|
||
expect(generatePlanRealityRows(ctx('plan-devex-review'))).toContain('--phase dx');
|
||
const deep = generatePlanRealityRows(ctx('plan-eng-review'), ['deep']);
|
||
for (const r of REALITY_ROWS) expect(deep).toContain(`| \`${r.id}\` | ${r.tier} | ${r.scope} |`);
|
||
expect(deep).toBe(deep.replace(/\n{3,}/g, '\n\n'));
|
||
expect(generatePlanRealityRows(ctx('autoplan'), ['autoplan', 'eng'])).toContain('check --phase eng');
|
||
expect(generatePlanRealityRows(ctx('autoplan'), ['pregate'])).toContain('`incomplete`');
|
||
expect(generatePlanRealityRows(ctx('plan-eng-review'), ['summary'])).toContain('PLAN_REALITY');
|
||
expect(renderIncidentTable(REALITY_ROWS).split('\n').length).toBe(REALITY_ROWS.length + 2);
|
||
expect(renderRows(requiredRows([]), { deep: false }).split('\n').length).toBe(TIER1_ROW_IDS.length);
|
||
});
|
||
test('plan-eng-review: Scope Challenge block, deep incident table and Completion summary line', () => {
|
||
const sections = read('plan-eng-review/sections/review-sections.md');
|
||
expect(sections).toContain('gstack-plan-reality rows --phase eng');
|
||
expect(sections).toContain('### Reality rows (why each exists)');
|
||
expect(sections).toContain('| `pr-count` | 1 | always |');
|
||
expect(sections).toContain('- Reality rows: ___/___ applicable rows emitted (`PLAN_REALITY` line), ___ unverified premises');
|
||
expect(read('plan-eng-review/sections/checklist.md')).toContain('| Reality rows (`REALITY:` lines, `PLAN_REALITY` check) | Reality rows (why each exists) | always |');
|
||
});
|
||
test('plan-ceo-review: 0A/0B block in the skeleton, Completion Summary row and checklist row', () => {
|
||
const skeleton = read('plan-ceo-review/SKILL.md');
|
||
const at = skeleton.indexOf('gstack-plan-reality rows --phase ceo');
|
||
expect(at).toBeGreaterThan(skeleton.indexOf('### 0B. Existing Code Leverage'));
|
||
expect(at).toBeLessThan(skeleton.indexOf('### 0C. Dream State Mapping'));
|
||
expect(read('plan-ceo-review/sections/review-sections.md')).toContain('| Reality rows | ___/___ rows (PLAN_REALITY), ___ unverified |');
|
||
expect(read('plan-ceo-review/sections/review-sections.md')).toContain('### Reality rows\n');
|
||
expect(read('plan-ceo-review/sections/checklist.md')).toContain('| Reality rows (`REALITY:` lines, `PLAN_REALITY` check) | Reality rows | always |');
|
||
});
|
||
test('autoplan: CEO and Eng phase files run the check; the Pre-Gate names incomplete for unattended misses', () => {
|
||
expect(read('autoplan/sections/ceo-phase.md')).toContain('gstack-plan-reality check --phase ceo');
|
||
expect(read('autoplan/sections/eng-phase.md')).toContain('gstack-plan-reality check --phase eng');
|
||
const skeleton = read('autoplan/SKILL.md');
|
||
const pregate = skeleton.slice(skeleton.indexOf('## Pre-Gate Verification'), skeleton.indexOf('## Phase 4: Final Approval Gate'));
|
||
expect(pregate).toContain('`REALITY:` lines');
|
||
expect(pregate).toContain('verdict=complete');
|
||
expect(pregate).toContain('`incomplete`');
|
||
});
|
||
test('the two result codes have troubleshooting anchors', () => {
|
||
const doc = read('docs/troubleshooting.md');
|
||
for (const code of ['REALITY_ROW_MISSING', 'REALITY_RECEIPT_MISSING'] as const) {
|
||
expect(doc).toContain(`<a id="${RESULT_CODES[code].anchor}"></a>`);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('field wave item 12: a receipt per measured number, the rule text for a rule claim', () => {
|
||
const others = (id: string) => Object.entries(FIXTURE.rows).filter(([k]) => k !== id).map(([, r]) => r.positive).join('\n');
|
||
const FIVE = 'REALITY: numbers pass p50 120ms, p95 340ms, 13% faster, 28k tokens, cost $41 [measured: test/bench.ts:10]';
|
||
|
||
test('five measured numbers sharing one receipt leave four unreceipted, each printed with its clause', () => {
|
||
const r = checkRealityRows(`${others('numbers')}\n${FIVE}`, { phase: 'eng', sessionKind: 'unattended' });
|
||
expect(r.missing).toEqual([]);
|
||
expect(r.unreceipted).toEqual([]);
|
||
expect(r.unreceipted_numbers).toEqual(['p50 120ms', 'p95 340ms', '13% faster', '28k tokens']);
|
||
expect(r.numberLines).toEqual(['NUMBER_UNRECEIPTED: p50 120ms', 'NUMBER_UNRECEIPTED: p95 340ms', 'NUMBER_UNRECEIPTED: 13% faster', 'NUMBER_UNRECEIPTED: 28k tokens']);
|
||
expect(r.verdict).toBe('incomplete');
|
||
expect(r.line).toContain(' unreceipted_numbers=4 ');
|
||
expect(checkRealityRows(`${others('numbers')}\n${FIVE}`, { phase: 'eng' }).verdict).toBe('repair');
|
||
});
|
||
|
||
test('each clause with its own receipt (file:line, script path or a command in backticks) passes; unmeasured counts, versions and ids need none', () => {
|
||
const own = 'REALITY: numbers pass p95 340ms lib/x.ts:4, 13% faster `bun run bench --json`, 28k tokens scripts/count-tokens.ts, recall 0.82 vs 0.79 on gstack 1.91.95.0 per F2 and #3160 [estimated]';
|
||
const r = checkRealityRows(`${others('numbers')}\n${own}`, { phase: 'eng' });
|
||
expect(r.unreceipted_numbers).toEqual([]);
|
||
expect(r.verdict).toBe('complete');
|
||
});
|
||
|
||
test('a rule claim without the rule text is unquoted; the quoted rule or a file:line link to it passes', () => {
|
||
const bare = 'REALITY: binding-decisions pass the decision rule was written first 91bbd9e';
|
||
const r = checkRealityRows(`${others('binding-decisions')}\n${bare}`, { phase: 'eng', sessionKind: 'unattended' });
|
||
expect(r.unreceipted).toEqual([]);
|
||
expect(r.unquoted).toEqual([bare]);
|
||
expect(r.line).toContain(' unquoted=1 ');
|
||
expect(r.verdict).toBe('incomplete');
|
||
const quoted = 'REALITY: binding-decisions pass the decision rule was written first: "stop if recall drops below the base on any bucket" 91bbd9e';
|
||
expect(checkRealityRows(`${others('binding-decisions')}\n${quoted}`, { phase: 'eng' }).verdict).toBe('complete');
|
||
const linked = 'REALITY: binding-decisions pass the decision rule was written first, see docs/plan.md:4';
|
||
expect(checkRealityRows(`${others('binding-decisions')}\n${linked}`, { phase: 'eng' }).unquoted).toEqual([]);
|
||
});
|
||
|
||
test('receipts on dot paths count; a sha receipt needs a hex letter or a commit/backtick context', () => {
|
||
expect(parseRealityLines('REALITY: pr-count pass one PR .gstack/ship-policy.json:1')[0]!.receipt).toBe('.gstack/ship-policy.json:1');
|
||
expect(parseRealityLines('REALITY: pr-count pass ci lane .github/workflows/ci.yml:12-20')[0]!.receipt).toBe('.github/workflows/ci.yml:12-20');
|
||
expect(parseRealityLines('REALITY: numbers pass run took 20261012 cycles')[0]!.receipt).toBeNull();
|
||
expect(parseRealityLines('REALITY: already-done pass base clean at commit 1234567')[0]!.receipt).toBe('commit 1234567');
|
||
expect(parseRealityLines('REALITY: already-done pass base clean at `7654321` today')[0]!.receipt).toBe('`7654321`');
|
||
});
|
||
|
||
test('bin: NUMBER_UNRECEIPTED lines follow the PLAN_REALITY line and the verdict exits 1 with a fix', () => {
|
||
const r = run(['check', '--phase', 'eng', '-', '--session-kind', 'unattended'], `${others('numbers')}\n${FIVE}`);
|
||
expect(r.code).toBe(EXIT.fail);
|
||
expect(r.out.split('\n').filter(Boolean)).toEqual([
|
||
expect.stringMatching(/^PLAN_REALITY: phase=eng rows=7\/7 missing=none unreceipted_numbers=4 .*verdict=incomplete$/),
|
||
'NUMBER_UNRECEIPTED: p50 120ms', 'NUMBER_UNRECEIPTED: p95 340ms', 'NUMBER_UNRECEIPTED: 13% faster', 'NUMBER_UNRECEIPTED: 28k tokens',
|
||
]);
|
||
expect(r.err).toContain('(REALITY_RECEIPT_MISSING)');
|
||
expect(r.err).toContain('fix:');
|
||
});
|
||
|
||
test('checkPlanReality(planText): plan prose gets the same number and rule checks, pure and session-kind mapped', () => {
|
||
const plan = 'Cold install measured 32.5 s; the warm rerun takes 13 s (bin/gstack-capy-install:91).\n```\nlatency 900 ms in a fenced example\n```\nThe decision rule was written first.\nThe preregistered rule is below.\n> stop when recall drops below the base\n';
|
||
const r = checkPlanReality(plan, { sessionKind: 'unattended' });
|
||
expect(r.unreceipted_numbers).toEqual(['Cold install measured 32.5 s']);
|
||
expect(r.unquoted).toEqual(['The decision rule was written first.']);
|
||
expect(r.verdict).toBe('incomplete');
|
||
expect(r.line).toBe('PLAN_REALITY: scope=plan unreceipted_numbers=1 unquoted=1 verdict=incomplete');
|
||
expect(r.numberLines).toEqual(['NUMBER_UNRECEIPTED: Cold install measured 32.5 s']);
|
||
expect(checkPlanReality('Add a retry with a 30 s cap (lib/worker.ts:12).\n').line).toBe('PLAN_REALITY: scope=plan unreceipted_numbers=0 unquoted=0 verdict=complete');
|
||
expect(checkPlanReality(plan).verdict).toBe('repair');
|
||
});
|
||
|
||
test('false-positive bound: the field-wave plan itself raises only a small, pinned count', () => {
|
||
const text = fs.readFileSync(path.join(ROOT, 'docs', 'designs', 'GSTACK_FIELD_WAVE_2026_10_12.md'), 'utf8');
|
||
const r = checkPlanReality(extractHeading(text, 'Implementation plan')!);
|
||
expect(r.unquoted).toEqual([]);
|
||
expect(r.unreceipted_numbers.length).toBeGreaterThan(0);
|
||
expect(r.unreceipted_numbers.length).toBeLessThanOrEqual(6);
|
||
});
|
||
});
|
||
|
||
describe('next wave B6/B10: PLAN_REALITY flags without false positives; plan quotes need no receipt', () => {
|
||
const others = (id: string) => Object.entries(FIXTURE.rows).filter(([k]) => k !== id).map(([, r]) => r.positive).join('\n');
|
||
|
||
test('B6: item and section references are not quantities; a phrase in backticks is named, not claimed (plan scope)', () => {
|
||
const plan = "B1. `rec`: one word takes every recommendation (item 5).\nB6. When the plan names `minimum effect`, `margin`, `decision rule` or a dollar cost, the gate flags it (items 10, 14–19; section 3).\n";
|
||
const r = checkPlanReality(plan);
|
||
expect(r.unreceipted_numbers).toEqual([]);
|
||
expect(r.unquoted).toEqual([]);
|
||
expect(checkPlanReality('Startup takes roughly 9 s on a cold machine.\n').unreceipted_numbers).toEqual(['Startup takes roughly 9 s on a cold machine.']);
|
||
expect(checkPlanReality('The decision rule was written first.\n').unquoted).toEqual(['The decision rule was written first.']);
|
||
expect(PLAN_REALITY_CHECKER).toBe('plan-reality/3');
|
||
});
|
||
|
||
test('B-f negative control: a measured number inside backticks in review scope stays flagged; a command in backticks still receipts', () => {
|
||
const quiet = 'REALITY: numbers pass the cold install took `86 s` on Capy';
|
||
expect(checkRealityRows(`${others('numbers')}\n${quiet}`, { phase: 'eng' }).unreceipted_numbers).toEqual(['the cold install took `86 s` on Capy']);
|
||
const cmd = 'REALITY: numbers pass the cold install took 86 s `bun run bench --json` on Capy';
|
||
expect(checkRealityRows(`${others('numbers')}\n${cmd}`, { phase: 'eng' }).unreceipted_numbers).toEqual([]);
|
||
});
|
||
|
||
test('B10: in reviewer scope a number quoted verbatim from the reviewed plan needs no receipt; a reworded or unknown quote does', () => {
|
||
const plan = 'Add exponential backoff: base 500 ms, factor 2, cap 30 s, jitter 10%.\n';
|
||
const quoted = 'REALITY: numbers pass the plan says "base 500 ms, factor 2, cap 30 s" and gives no reason for the cap (plan.md:1)';
|
||
expect(checkRealityRows(`${others('numbers')}\n${quoted}`, { phase: 'eng', planText: plan }).unreceipted_numbers).toEqual([]);
|
||
expect(checkRealityRows(`${others('numbers')}\n${quoted}`, { phase: 'eng' }).unreceipted_numbers.length).toBeGreaterThan(0);
|
||
const reworded = 'REALITY: numbers pass the plan says "a 45 s cap" and gives no reason';
|
||
expect(checkRealityRows(`${others('numbers')}\n${reworded}`, { phase: 'eng', planText: plan }).unreceipted_numbers.length).toBe(1);
|
||
const own = 'REALITY: numbers pass the plan says "cap 30 s"; retries took 900 ms in my run';
|
||
expect(checkRealityRows(`${others('numbers')}\n${own}`, { phase: 'eng', planText: plan }).unreceipted_numbers).toEqual(['retries took 900 ms in my run']);
|
||
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'plan-reality-quote-'));
|
||
fs.writeFileSync(path.join(dir, 'plan.md'), plan);
|
||
const bin = run(['check', '--phase', 'eng', '--plan', path.join(dir, 'plan.md'), '-'], `${others('numbers')}\n${quoted}`);
|
||
expect(bin.code, bin.err).toBe(EXIT.ok);
|
||
expect(run(['check', '--phase', 'eng', '-'], `${others('numbers')}\n${quoted}`).code).toBe(EXIT.fail);
|
||
fs.rmSync(dir, { recursive: true, force: true });
|
||
});
|
||
|
||
test('B6: vaguePlanTerms flags minimum effect, margin, decision rule and dollar cost only without a number, arm list or rule body', () => {
|
||
const plan = [
|
||
'Ship when the minimum effect is reached.',
|
||
'Keep a safety margin on the spend.',
|
||
'A margin of 15% over the pilot price.',
|
||
'The decision rule:',
|
||
'- arm A: keep the default',
|
||
'- arm B: switch',
|
||
'We price the dollar cost later (item 9).',
|
||
'The decision rule is "stop when recall drops below the base".',
|
||
'Name `minimum effect` in the template.',
|
||
'```', 'margin inside a fence', '```',
|
||
].join('\n');
|
||
expect(vaguePlanTerms(plan).map(v => [v.phrase, v.line])).toEqual([['minimum effect', 1], ['margin', 2], ['dollar cost', 7]]);
|
||
});
|
||
});
|