mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-02 15:04:37 +01:00
Follow-up to the review-loop convergence PR: Step 12 and the CHANGELOG step skip cleanly in a repository with no version source (receipt version "none"); the receipt records the docs audit outcome and the owner exception (DOCS_AUDIT_BLOCKED without one) and a policy may declare doc caps (gstack-ship-receipt docs-caps); docs/unattended.md names the READY evidence and the cross-family outside voice; the ship-frozen-scope-convergence behaviour case runs the generated Step 9.4 under review_scope frozen through the real binaries; carry probes git >= 2.39 (RECEIPT_GIT_TOO_OLD); defer passes the repository to gh repo view positionally and names its search limit; late defers count without being passes; reviewers diff from RANGE_BASE on pass 2+; the cap check runs before edits; --review-fanout batches specialists by free slots; read --check-prose compares quoted counters with the receipt (RECEIPT_PROSE_MISMATCH); checklist rule ids prereg-with-results and test-keyboard-count-loop; gstack-coauthor-trailers. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
73 lines
5.2 KiB
TypeScript
73 lines
5.2 KiB
TypeScript
/**
|
|
* ship-receipt-docs — the receipt's `docs` record (what /ship Step 14.5's
|
|
* documentation audit concluded, and the owner's exception when it stayed
|
|
* blocked) and the doc caps a repository declares in its ship policy
|
|
* (`docs.caps`, docs/ship-policy.md#ship-receipt). Kept beside
|
|
* lib/ship-receipt.ts so that module stays under the size ratchet.
|
|
*/
|
|
export const DOCS_STATUSES = ['updated', 'current', 'blocked'] as const;
|
|
export type DocsStatus = typeof DOCS_STATUSES[number];
|
|
/** Only the owner accepts a documentation risk; the record names who, when, where and why, and the PR body repeats it word for word. */
|
|
export interface DocsException { accepted_by: string; date: string; via: string; reason: string }
|
|
export interface ReceiptDocs { status: DocsStatus; scope: string; exception?: DocsException }
|
|
export type DocsParse = { ok: true; docs: ReceiptDocs } | { ok: false; code: 'RECEIPT_INVALID' | 'DOCS_AUDIT_BLOCKED'; message: string };
|
|
|
|
const EXCEPTION_KEYS = ['accepted_by', 'date', 'via', 'reason'] as const;
|
|
const text = (v: unknown): v is string => typeof v === 'string' && v.trim().length > 0 && !/[\x00-\x1f\x7f]/.test(v);
|
|
|
|
/**
|
|
* `write --docs` input: `{ status, scope, exception? }`. A blocked audit with
|
|
* no exception is DOCS_AUDIT_BLOCKED, not a receipt: /ship Step 14.5 ends
|
|
* blocked only when the owner has not accepted the named risk, and a receipt
|
|
* written then would publish an unaudited release as audited.
|
|
*/
|
|
export function parseReceiptDocs(value: unknown): DocsParse {
|
|
if (!value || typeof value !== 'object' || Array.isArray(value)) return { ok: false, code: 'RECEIPT_INVALID', message: '--docs needs a JSON object { status, scope[, exception] }' };
|
|
const v = value as Record<string, unknown>;
|
|
for (const key of Object.keys(v)) if (!['status', 'scope', 'exception'].includes(key)) return { ok: false, code: 'RECEIPT_INVALID', message: `--docs: unknown key ${JSON.stringify(key)}` };
|
|
if (!DOCS_STATUSES.includes(v.status as DocsStatus)) return { ok: false, code: 'RECEIPT_INVALID', message: `--docs status must be one of ${DOCS_STATUSES.join(' | ')}, got ${JSON.stringify(v.status)}` };
|
|
if (!text(v.scope)) return { ok: false, code: 'RECEIPT_INVALID', message: '--docs scope must be a non-empty one-line string (the docs roots the audit covered)' };
|
|
const docs: ReceiptDocs = { status: v.status as DocsStatus, scope: v.scope.trim() };
|
|
if (v.exception !== undefined) {
|
|
const e = v.exception as Record<string, unknown> | null;
|
|
if (!e || typeof e !== 'object' || Array.isArray(e)) return { ok: false, code: 'RECEIPT_INVALID', message: '--docs exception must be { accepted_by, date, via, reason }' };
|
|
for (const key of Object.keys(e)) if (!(EXCEPTION_KEYS as readonly string[]).includes(key)) return { ok: false, code: 'RECEIPT_INVALID', message: `--docs exception: unknown key ${JSON.stringify(key)}` };
|
|
for (const key of EXCEPTION_KEYS) if (!text(e[key])) return { ok: false, code: 'RECEIPT_INVALID', message: `--docs exception.${key} must be a non-empty one-line string` };
|
|
if (!/^\d{4}-\d{2}-\d{2}$/.test(e.date as string)) return { ok: false, code: 'RECEIPT_INVALID', message: '--docs exception.date must be YYYY-MM-DD' };
|
|
docs.exception = { accepted_by: (e.accepted_by as string).trim(), date: e.date as string, via: (e.via as string).trim(), reason: (e.reason as string).trim() };
|
|
}
|
|
if (docs.status === 'blocked' && !docs.exception) return { ok: false, code: 'DOCS_AUDIT_BLOCKED', message: `the documentation audit is blocked (${docs.scope}) and no owner exception is recorded; repair the audit, or record the owner's acceptance as exception: { accepted_by, date, via, reason }` };
|
|
return { ok: true, docs };
|
|
}
|
|
|
|
/** The line the PR body's `## Documentation` section must carry when an exception stands: the exception, word for word. */
|
|
export function docsExceptionLine(docs: ReceiptDocs): string | null {
|
|
if (!docs.exception) return null;
|
|
const e = docs.exception;
|
|
return `Documentation exception: accepted by ${e.accepted_by} ${e.date} via ${e.via}: ${e.reason}`;
|
|
}
|
|
|
|
/** The `docs` object a receipt carries, when it validates; receipts written before this record have none. */
|
|
export function receiptDocs(receipt: Record<string, unknown>): ReceiptDocs | undefined {
|
|
const parsed = parseReceiptDocs(receipt.docs);
|
|
return parsed.ok ? parsed.docs : undefined;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// doc caps: `docs.caps` in .gstack/ship-policy.json
|
|
// ---------------------------------------------------------------------------
|
|
export interface DocsCap { path: string; max_bytes: number }
|
|
export interface DocsCapResult { path: string; bytes: number | null; max: number; verdict: 'ok' | 'over' }
|
|
|
|
/** Every declared cap against the candidate tree; a path the tree lacks is `over` (a cap on nothing is a policy mistake, not a pass). */
|
|
export function checkDocsCaps(caps: readonly DocsCap[], sizeOf: (rel: string) => number | null): DocsCapResult[] {
|
|
return caps.map(cap => {
|
|
const bytes = sizeOf(cap.path);
|
|
return { path: cap.path, bytes, max: cap.max_bytes, verdict: bytes !== null && bytes <= cap.max_bytes ? 'ok' : 'over' };
|
|
});
|
|
}
|
|
|
|
export function docsCapLine(r: DocsCapResult): string {
|
|
return `DOCS_CAP: ${r.path} ${r.bytes === null ? 'absent' : r.bytes}/${r.max} ${r.verdict}`;
|
|
}
|