mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-18 19:02:18 +02:00
Garry TanandClaude Fable 5
2e25bfdefb
The windows-free-tests curated set is derived (POSIX-fragility regex scan + explicit deny list), and two of this wave's Windows regression files were auto-excluded on false-positive pattern hits: - browse/test/file-permissions.test.ts tripped the POSIX-mode-bitmask pattern, but every `mode & 0o777` assertion is platform-guarded — and the file carries the win32-only icacls-by-SID regression tests, which can only ever execute on windows-latest. - browse/test/terminal-agent-owner-watchdog.test.ts tripped the spawn(['bun','run',...]) pattern whose reason is the Playwright-bound browse server; it actually spawns terminal-agent.ts (fs/path/crypto + local helpers only, no Playwright at module scope), and the owner-PID orphan leak it pins was reported on Windows (#2019). Adds a KNOWN_WINDOWS_SAFE force-include list (mirror of KNOWN_WINDOWS_INCOMPATIBLE, each entry carrying its false-positive rationale) consulted before the pattern scan, and makes the owner-watchdog test's throwaway owner process Windows-portable (process.execPath instead of `sleep`, which a bare runner may not have). The wave's other new files need no wiring: process-liveness-windows and the bun-polyfill windowsHide/exited tests pass curation automatically; setup-runtime-lib-command self-skips on win32 by design (its Windows branch is exercised by simulating IS_WINDOWS=1 under bash), so force-including it would add a permanently-skipped file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
75 lines
2.4 KiB
TypeScript
75 lines
2.4 KiB
TypeScript
import { afterEach, describe, expect, test } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as os from 'os';
|
|
import * as path from 'path';
|
|
|
|
const AGENT_SCRIPT = path.join(import.meta.dir, '../src/terminal-agent.ts');
|
|
const spawned: any[] = [];
|
|
const tempDirs: string[] = [];
|
|
|
|
function isAlive(pid: number): boolean {
|
|
try {
|
|
process.kill(pid, 0);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
async function waitFor(predicate: () => boolean, timeoutMs = 5_000): Promise<boolean> {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (Date.now() < deadline) {
|
|
if (predicate()) return true;
|
|
await Bun.sleep(25);
|
|
}
|
|
return predicate();
|
|
}
|
|
|
|
afterEach(() => {
|
|
for (const proc of spawned.splice(0)) {
|
|
try { proc.kill?.('SIGKILL'); } catch {}
|
|
}
|
|
for (const dir of tempDirs.splice(0)) {
|
|
try { fs.rmSync(dir, { recursive: true, force: true }); } catch {}
|
|
}
|
|
});
|
|
|
|
describe('terminal-agent owner lifecycle', () => {
|
|
test('exits after its owning browse server process exits', async () => {
|
|
const stateDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-term-owner-'));
|
|
tempDirs.push(stateDir);
|
|
const stateFile = path.join(stateDir, 'browse.json');
|
|
fs.writeFileSync(stateFile, JSON.stringify({ token: 'test-token' }));
|
|
|
|
// process.execPath (the running bun) instead of `sleep`: coreutils are
|
|
// not guaranteed on a bare windows-latest runner, and this test is on the
|
|
// Windows CI curated list — the owner-orphan leak it pins is a Windows bug.
|
|
const owner = Bun.spawn(
|
|
[process.execPath, '-e', 'await Bun.sleep(30000)'],
|
|
{ stdio: ['ignore', 'ignore', 'ignore'] },
|
|
);
|
|
spawned.push(owner);
|
|
const agent = Bun.spawn(['bun', 'run', AGENT_SCRIPT], {
|
|
env: {
|
|
...process.env,
|
|
BROWSE_STATE_FILE: stateFile,
|
|
BROWSE_SERVER_PORT: '0',
|
|
BROWSE_OWNER_PID: String(owner.pid),
|
|
GSTACK_TERMINAL_OWNER_WATCHDOG_MS: '25',
|
|
},
|
|
stdio: ['ignore', 'ignore', 'ignore'],
|
|
});
|
|
spawned.push(agent);
|
|
|
|
expect(await waitFor(() => fs.existsSync(path.join(stateDir, 'terminal-agent-pid')))).toBe(true);
|
|
expect(isAlive(agent.pid)).toBe(true);
|
|
|
|
owner.kill('SIGTERM');
|
|
await owner.exited;
|
|
|
|
expect(await waitFor(() => !isAlive(agent.pid))).toBe(true);
|
|
expect(fs.existsSync(path.join(stateDir, 'terminal-agent-pid'))).toBe(false);
|
|
expect(fs.existsSync(path.join(stateDir, 'terminal-port'))).toBe(false);
|
|
});
|
|
});
|