mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-29 01:10:50 +02:00
* feat(gen): strip gen-time-only frontmatter keys from Claude renders
interactive + benefits-from are read from the .tmpl by buildContext at
generation time; no runtime, host, or test reader consumes them from the
generated SKILL.md (e2e-harness-audit reads .tmpl; benefits-from tests
assert rendered prose). gbrain: stays (bin/gstack-brain-context-load reads
it from the installed render); hooks: stays (Claude Code host wires
PreToolUse from it).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(gen): regenerate SKILL.md — dead frontmatter keys removed
Mechanical regen after hosts/claude.ts stripFields change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(test): context-budget ratchet — CI ceilings on always-on + eager token ledgers
New free test grades the two ledgers nothing else guards: the full-frontmatter
always-on catalog (aggregate) and per-skill eager tokens (SKILL.md +
forced-read refs), via checkBudget from lib/context-bill.ts. Ceilings live in
test/fixtures/context-budget.json with x1.05/x1.10 headroom; regenerate with
bun test/helpers/capture-context-budget.ts. New skills fail until consciously
budgeted; removed skills fail until the fixture is refreshed; reductions
ratchet the ceilings down so wins lock in.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(todos): file output-template carve wave + plan-ceo doctrine revisit; mark preamble-carve P3 in flight
Two follow-ups deferred from the approved token-reduction program (CEO review
'NOT in scope' list), filed with full context per TODOS format. The existing
P3 preamble-carve entry gets a status update pointing at the program that
supersedes it.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(test): review findings — Windows path normalization, full totals rebuild, ratchet coverage
Pre-landing review (5 specialists) found one critical: the ratchet test runs
in the curated Windows lane, where path.relative yields backslash skill names
that miss the test/ filter and mismatch every POSIX fixture key. Names are now
normalized once in buildRatchetBill (toPosixName) and the fixture filter is
tightened to test/fixtures/. All eight Bill.totals fields are rebuilt from the
filtered list (no fixture-polluted perInvocation/totalMd numbers for future
consumers). New coverage: Windows-separator normalization pins, a
captureContextBudget round-trip against tree-a (headroom math exact), a
stripFields regression pin (interactive/benefits-from absent from renders,
hooks/gbrain preserved), and the ceilings test no longer double-reports
stale-fixture entries.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(test): adversarial findings — stable root key, symlink-alias dedupe, fixture-shape guard
Adversarial review (Claude subagent) verified the fixture's root-skill key was
the capture machine's checkout dirname: any non-gstack-named clone (every
Conductor worktree) failed the free suite, and the documented re-run-the-capture
recovery baked the local dirname into the committed fixture — silent corruption
through the tool's own protocol. The root skill is now pinned to ROOT_SKILL_KEY
('gstack', its frontmatter name). Symlink aliases are realpath-deduped (census
precedent): connect-chrome no longer gets its own ceiling, so Windows checkouts
that materialize the symlink as a plain file can't fail the stale-ceiling
set-equality test. New guards: fixture-shape validation (a string alwaysOnTotal
can no longer silently disable the ceiling), a mutation pin that the filter
shrinks the always-on ledger vs the raw bill, an alwaysOnTotal violation test
(the branch was load-bearing with only under-budget coverage), and an atomic
temp+rename fixture write. Fixture regenerated: 59 ceilings, alwaysOnTotal 6344.
Deferred with a TODO: anchoring transformFrontmatter's denylist strip to the
frontmatter block (latent, zero live collisions, pre-existing path).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: bump version and changelog (v1.69.1.0)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: update project documentation for v1.69.1.0
CLAUDE.md: Token ceiling section documents the context-budget ratchet as
the third guard (test file, fixture, new-skill budgeting, capture command).
CONTRIBUTING.md: Tier 1 guard list gains a Context-budget ratchet bullet;
the Adding-a-new-skill checklist gains the budget-capture step.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: pin exact guard semantics for the context-budget ratchet in CLAUDE.md
Doc-review finding: "a third enforced ceiling" undercounted the guard
family (skill-size-budget floors and parity ratios also watch these
ledgers, relatively). Rephrased to match the ratchet test's own header:
absolute ceilings vs relative floors/ratios.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(changelog): heaviest-skill claim matches the fixture (land-and-deploy edges review by 0.2%)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(bin): gstack-skill-start + gstack-skill-end — the preamble runtime, consolidated
Absorbs the ~13KB of bash every tier-2+ SKILL.md inlined twice over (bootstrap
fence + artifacts-sync fence) and the skill-end telemetry/sync fences. Same
KEY: value STATUS-line contract the prose interprets, plus SKILL_START_PROTO
handshake (OV5), SESSION_ID/TEL_START echoes, GSTACK_HOME-normalized state
paths (EOV7), --parent-pid session identity (EOV5: $PPID inside the script is
the ephemeral tool-call shell), OV4 sanitization of passthrough output, and a
receipted daily artifacts pull (_receipted_git, brain-sync class, fail-closed).
Per-line || true error style throughout (F3) — a mid-script failure never drops
later STATUS lines.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(gen): preamble resolvers emit a script invocation fence instead of inline bash
generate-preamble-bash: ~6.3KB fence -> 4-line gstack-skill-start invocation
(quoted-tilde pitfall handled: leading ~ interpolates through $HOME; env-var
hosts keep $GSTACK_BIN) + degraded-mode prose (F1/EOV8: safe defaults, consent
gates deferred-never-lost; OV5: proto rule). generate-brain-sync-block: ~6.8KB
bash -> interpretation prose + the privacy stop-gate (stays inline until
Phase 2's gated emission). generate-completion-status: telemetry fence -> one
gstack-skill-end call with SESSION_ID/TEL_START handoff.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(gen): regenerate all skills + golden fixtures — inline preamble bash removed
Mechanical regen after the resolver change: −12,628 lines across 52 renders
(corpus 952K -> 806K render tokens; tier-2 skills −11-13KB each). Golden
per-host ship fixtures refreshed from the fresh claude/codex/factory renders.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: skill-start contract suite + preamble A/B eval + touchfiles registration
test/gstack-skill-start.test.ts (11 free tests): STATUS-key contract vs the
prose (F2), per-host fence resolution shapes (E1), proto-first, OV4 marker
sanitization, --parent-pid identity, headless suppression, skill-end duration
math + pending cleanup. test/skill-e2e-preamble-script-ab.test.ts (gate tier,
OV7): inline-bash render (pinned from 29785978) vs script render with the
fence redirected at the worktree bin (EOV2 — hermetic evals otherwise resolve
the operator install and silently exercise degraded mode). 21 touchfiles dep
lists gain the two bin scripts (EOV9) so future script edits select the
preamble evals; selection-count pin updated 23->24.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: repin ~70 assertions to the script contract — every literal gets a successor
Assertions that pinned inline-bash internals (update-check guard, _SESSIONS
reaping, telemetry start/end blocks, routing probe, repo-strip producer,
first-task gating, EXPLAIN_LEVEL/QUESTION_TUNING echoes, #2499 jq scope
resolution, Issue-8 CONDUCTOR gate) now pin the same invariants in their new
home: bin/gstack-skill-start / bin/gstack-skill-end file content for script
internals, the invocation fence + interpretation prose for render-side
behavior. No assertion deleted without a successor; live-execution tests
(routing probe, brain-sync jq) run against script bytes unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(test): re-baseline size floors + ratchet ceilings down (EOV1/OV9 protocol)
parity-baseline-v1.69.1.0.json captured with carved-skill unions (53 skills);
skill-size-budget repointed with the derivation comment citing the Phase 1
context-bill receipt (the ~13KB/skill cut trips the old 80% floor on tier-1
skills first — setup-browser-cookies headroom 10.8KB < the cut). The v1.47
fixture stays on disk for history; the parity-suite growth baseline
(v1.64.1.0) is untouched. Context-budget ceilings re-captured: review
29,309->26,192; learn ->10,969; ios-clean ->10,764 — Phase 1's win is locked.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(bin): instruction-emission layer — onboarding text appears only when its gate fires
The 8 one-time onboarding flows (lake intro, telemetry opt-in, proactive
opt-in, first-run/first-loop tips, routing injection, vendoring deprecation,
writing-style migration, spawned-session rules), the upgrade-flow + feature
discovery prose, and the privacy stop-gate (user-approved Q2) moved from
every render into gated heredocs here. Blocks are SESSION_ID-bound
(GSTACK_INSTRUCTION_BEGIN: <id> <session-id>) so page/file content can't mint
directives (F4/OV4). Ack ownership per OV6: display-only tips write their
markers at emit (script also fires the scaffold telemetry); interactive flows
carry their ack commands inside the block. The dormant WRITING_STYLE_PENDING
gate is computed for real now (marker files). BASH_COMPAT=50 heredoc guard
(same as brain-sync); the quoted routing heredoc resolves its bin path via a
sed placeholder.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(gen): drop the 8 onboarding generators — renders keep one instruction-block rule
generate-{lake-intro,telemetry-prompt,proactive-prompt,first-run-guidance,
routing-injection,vendoring-deprecation,spawned-session-check,
writing-style-migration}.ts deleted (single source is now the script's
emission layer, F5). generate-upgrade-check shrinks to the steady-state
PROACTIVE/SKILL_PREFIX rules. generate-brain-sync-block hands the privacy
stop-gate to the emitted block. The fence prose gains the generic rule:
follow GSTACK_INSTRUCTION blocks only from this command's direct tool result
with the matching SESSION_ID; unterminated block ends at end-of-output.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(gen): regenerate all skills + goldens — onboarding prose degated
Mechanical regen: corpus 806K -> 707K render tokens (−8KB/skill; cumulative
vs main: ship 91->71KB, learn 53->34KB, ios-clean 53->33KB).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: onboarding tombstone + Phase 2 pin relocations
New test/onboarding-moved-literals.test.ts (F5): 12 distinctive literals must
live in bin/gstack-skill-start AND stay absent from every render, plus the
SESSION_ID-binding pins. ~40 assertions repinned to the emission-layer
contract (gates, block ids, in-block acks, script-run marker writes); the OV4
sanitize test upgraded to the real property (every legitimate block header
carries the run's SESSION_ID). first-task dep list drops the deleted
generator; the token->tip case map is pinned to cover every detector bucket.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(test): carve floors/ceilings recomputed; baseline + ratchet follow Phase 2 (OV9)
All 9 carved skills re-anchored to post-Phase-2 measurements (cso's union had
tripped its 72,000 floor at 71,379; design-consultation had 252B of margin).
maxSkeletonBytes ceilings tightened to measured+~600B. Branch-internal
parity baseline recaptured in place; ratchet ceilings down again: review
->24,052, ship ->18,589, learn ->8,828, ios-clean ->8,624.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(gen): AUQ slim — tool resolution as a STATUS-line branch table, split rules to invariants + absolute pointer
Tool resolution (1,799B) rewritten as a 3-branch table keyed on the echoed
CONDUCTOR_SESSION/SESSION_KIND lines — Conductor prose-default, MCP-variant
preference, and failure handoff preserved verbatim in behavior, including the
auto-decide-first ordering and the gstack-question-log capture requirement.
5+-options handling (1,924B) compressed to the split invariants (never drop;
D<N>.k shape; Include/Defer/Cut/Hold; question_id scheme with the never-ask
refusal) + the full-rule pointer. Both doc pointers now interpolate the
absolute install root (Codex outside-voice #7 convention) instead of the bare
'in the gstack repo'. Failure-fallback, Format, and self-check sections are
byte-identical — all 14 MANDATORY always-loaded pins pass with zero test
edits.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(gen): regenerate all skills + goldens — AUQ slim
Mechanical regen: −1.3KB per tier-2+ skill (ship 69.9KB, learn 32.5KB).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(test): baseline + ratchet follow Phase 3 (OV9); OV8 evaluated — shrink floor stays
Branch-internal baseline recaptured; ratchet ceilings down again. OV8's
floor-retirement question, evaluated as planned after Phase 3: the 80% shrink
floor stays — it uniquely catches accidental body deletion in non-carved
skills BETWEEN ratchet recaptures, and the capture command has amortized the
fixture-refresh cost that motivated retiring it.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(review): carve adversarial, plan-completion, and review-army into sections
The three resolver macros ship already carves as siblings now load on demand
for /review too: skeleton 100.2KB -> 55.0KB (-45%), union 93.4KB. Resolvers
stay the single source of truth (sections wrap the macros). Step 0/1, scope
drift, critical pass, confidence calibration, and fix-first stay always-loaded.
Fixtures and pins follow the moved content (codex-hardening wrapped-sites,
review-army E2E fixture builds skeleton+sections with an empty-fixture guard).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(codex): carve the three mutually exclusive modes into sections
Review/Challenge/Consult mode bodies (34.7KB where at most one ever runs)
load on demand: skeleton 81.0KB -> 55.2KB, union 1.04x the monolith. The mode
dispatch, filesystem boundary, and a new always-loaded 'Synthesis
recommendation (REQUIRED) — all modes' block stay skeleton-side (the AUQ
per-skill pins pass unchanged); the plan-file report + exit gate render after
the last section pointer per the gateAfterStop pattern.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(land-and-deploy): carve first-run validation, readiness gate, and merge/deploy into sections
The once-per-repo dry-run validation, the pre-merge readiness gate, and the
merge + deploy-strategy steps (37.8KB) load on demand: skeleton 91.1KB ->
55.7KB. Step 1.5 keeps its detection bash as the dispatch; the first-run
section's fingerprint-save block gained {{SLUG_EVAL}} so it is self-contained.
Zero content lost (line-coverage checked against HEAD).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(ios): demote the four ios skills to preamble-tier 2 (Phase 5)
They never consume the tier-3 sections (repo-mode ownership, search-before-
building) but do fire AskUserQuestion, which tier >=2 provides — verified by
grep before the plan review. -2.2KB per skill. Render assertions pin the
demotion (tier-3 sections absent, AUQ format present).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(guards): register wave-1 carves; monolith invariants retire; baselines + ratchet follow
CARVE_GUARDS gains review/codex/land-and-deploy (12 carved skills total);
their MONOLITH_INVARIANTS entries retire (invariants now generate from the
registry, cso precedent). Touchfiles: carve-section-loading covers the three
new carves; the codex + land-and-deploy LLM-judge dep lists widen to their
sections. Regen + goldens + branch-internal baseline + ratchet ceilings
recaptured (review 24,052 -> skeleton-based ceiling; union floors hold).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(gen-skill-docs): review render pins read the carved union
The review carve's readSkillUnion conversions (same pattern its neighbor
carved-skill pins already use).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(autoplan): carve the four review phases + tasks aggregator into sections
Phase bodies (CEO/Design/Eng/DX consensus flows) and the Implementation Tasks
aggregator load on demand; Design and DX stay separate sections because each
is independently conditional on scope. Skeleton 83.7KB -> 58.7KB (-30%
always-loaded); the 6 decision principles, classification, sequencing, and
explicit skip-condition dispatch stay always-loaded. The chain E2E's
phase-complete markers now live only in sections, so its assertions double as
section-read proof (behavioral: external).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(spec): carve the post-confirmation gate-and-file tail into one section
Phases 1-4 are the turn-1 conversational spine — carving them would force the
Read on the first user message for zero real savings. The mechanical tail
(4.5/4.5a/4.5b redaction gates + Phase 5 filing + TTHW telemetry) fires only
after draft confirmation: a genuine lazy boundary, kept as ONE section so the
gh-issue-create bash can never load without the fail-closed redaction gate
that precedes it. Skeleton 65.4KB -> 50.7KB; all ~85 phase-structure
invariants migrated location-aware plus a new carve-shape suite (56 tests).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(setup-gbrain): carve the branch-exclusive install paths into sections
Brain-init (Paths 1/2/3/4 bodies), engine remediation, transcript gate, and
CLAUDE.md persist load on demand — at most one install route ever runs.
Skeleton 75.3KB -> 57.0KB; the Step 1 detect and Step 2 path dispatch stay
always-loaded. New buildSetupGbrainFixture helper gives the periodic E2Es
extract-don't-copy fixtures with a non-empty guard; the voyage-code-3 gate
counts scan the tmpl union (the third init site lives in engine-remediation).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(guards): register wave-2 carves (15 carved skills); autoplan monolith retires; baselines follow
CARVE_GUARDS gains autoplan (behavioral: external via the chain eval), spec,
and setup-gbrain; autoplan's MONOLITH_INVARIANTS entry retires. Touchfiles:
setup-gbrain periodic dep lists gain the section tmpls + fixture helper; the
stale-brain-refs scan covers setup-gbrain/sections. Regen + goldens + branch
baseline + ratchet recaptured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(qa): carve QA patterns + health rubric into on-demand sections (68→48KB skeleton)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(browse): carve full command list + snapshot flags into sections/command-list.md (39→27KB skeleton)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(retro): absorb inline git/awk metrics into bin/gstack-retro-metrics + carve report format
RETRO_METRICS_PROTO: 1 contract, local git reads only (fetch stays in the
skill prose), degraded path documented in the skeleton.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: register wave-3 carves (qa, browse, retro) — guards, touchfiles, pins, baselines
CARVE_GUARDS gains the three entries; qa's monolith invariant retires.
auq-format carve-safety now keys on the skeleton+sections union shipping
the AUQ block (first tier-1 carve: browse never renders it by design).
Baselines: parity v1.69.1.0 at 18 sectioned skills; ratchet recaptured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(test): drop stale generate-lake-intro import (generator deleted in the emission-layer move)
Sol scope discipline stays pinned via the model overlay + completeness
section; the lake intro is now a single script-emitted blurb.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(office-hours): carve Phase 2A/2B into mode-exclusive sections (81→67KB skeleton)
A session runs exactly one mode, so a builder session never loads the
13KB startup diagnostic. Mode mapping and the vibe-shift upgrade rule
stay in the skeleton.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(design): carve UX doctrine + Pretext patterns into read-on-demand sections
design-html 57→49KB, design-shotgun 53→50KB. Sections wrap
{{UX_PRINCIPLES}} so scripts/resolvers/design.ts stays the source of
truth; the pretext-patterns STOP sits at the top of Step 3 so the read
provably precedes the Write.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: register wave-4 carves (office-hours ext, design-html, design-shotgun) — 20 carved skills
Both design entries carry requiredReads + loading-eval scenarios (D3A
condition). office-hours phase sections are mode-exclusive, so only the
always-reached design/handoff section is a deterministic requiredRead.
Baselines and ratchet recaptured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: trim CLAUDE.md 66.4→44.9KB — verbatim moves to docs/, pointers stay inline
Moved: browser/sidebar/server internals, CHANGELOG release-summary format
spec, project tree, hermetic-E2E detail, slop-scan reference, OpenClaw
publishing. Kept inline: every hard behavioral rule (dist/ ban, redaction
scan-at-sink, egress receipts, bisect commits, eval detach, CHANGELOG
entry rules), the machine-managed GBrain block (byte-identical), and the
'## Deploying to the active skill' header with gbrain-refresh in range
(pinned by test/gbrain-refresh-install-render.test.ts). No voice rewrites.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(test): seed onboarding markers into the hermetic child GSTACK_HOME
EOV7 made bin/gstack-skill-start honor GSTACK_HOME, so the operator-HOME
seeding in e2e-helpers.ts no longer reaches hermetic children — the
emission layer fired lake-intro/telemetry prompts that burned turns and
stalled PTY tests waiting on an answer (observed: plan-mode-no-op derailed
by the telemetry question). Onboarding-specific tests pin their own
GSTACK_HOME per-test, which merges over this seed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: raise carve-section-loading wall clock to 480s SDK / 540s bun
The heavy full-workflow scenarios satisfy their required section reads
inside 60s but need 300-450s to finish the report on slower sandboxes;
the 300s default read as a loading failure when the carve invariant held
(traces: plan-eng-review read its section at 8s, office-hours all three
at 24s, design-html both at 50s — all timed out mid-report).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(security): harden the skill-start trust boundary — review-army findings
Session ID gains a urandom suffix (block binding unforgeable by reflected
content); _sanitize also neutralizes spoofed SESSION_ID: lines; branch
names are charset-clamped before JSON embedding (skill-start + skill-end);
.brain-last-push reads first line only with a charset clamp; the artifacts
URL echo routes through _sanitize; the privacy consent gate fires in
interactive sessions only (spawned auto-choose could accept consent no
human gave — emission order is not a safety property); the daily pull gets
non-interactive + slow-network git guards and stamps only when the
receipted path ran; ~/.claude.json gets a grep pre-filter before the jq
parse.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(resolvers): question-log session_id becomes a substitution placeholder + stale-comment sweep
The question-log block bound $_SESSION_ID, a shell variable the
consolidated fence never sets — hook-less hosts logged empty session_id,
breaking /plan-tune per-session grouping. It now uses the same
substitute-from-the-skill-start-echoes contract as the telemetry block.
Also: retired the pre-Phase-2 stop-gate docstring, repointed the
gbrain-local-status cross-reference at the script's inline jq, dropped an
orphaned section comment, documented retro-metrics' suffix-only census.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: regenerate renders for the question-log placeholder; goldens + baselines follow
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test: hermetic update-check, onboarding gate sequencing, seeding parity
The contract test's child did a live git ls-remote + curl to github.com on
every bun run test (update_check config now gates it off); the headless
test gets a fresh GSTACK_HOME so the suppression is actually exercised; a
new OV6 test drives the script three times to pin ack-at-emit and gate
sequencing; hermetic seeding covers the config-keyed privacy gate; the
EVALS_HERMETIC=0 debug seeding reaches marker parity.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(ci): demote the preamble A/B to periodic (OV7) and add it to the periodic matrix
Post-Phase-3 demotion per the plan; the eval needs fetch-depth 0 (it git
shows a pre-Phase-1 sha), which only the periodic workflow provides — and
a static matrix entry so it can't silently never run.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: bump version and changelog (v1.70.0.0)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: update project documentation for v1.70.0.0
ARCHITECTURE.md: the preamble section now describes the v1.70 runtime —
the rendered {{PREAMBLE}} block invokes bin/gstack-skill-start and reads
STATUS lines, gstack-skill-end logs telemetry, and one-time onboarding
text arrives as gated GSTACK_INSTRUCTION blocks instead of riding in
every render.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: doc-review fixes — repair moved-file links, drop unbacked session-count claim
docs/BROWSER_INTERNALS.md: the two ARCHITECTURE.md anchor links broke when
the section moved from repo-root CLAUDE.md into docs/ — now ../ARCHITECTURE.md.
ARCHITECTURE.md: the preamble's session-tracking item claimed an active-session
count and an "ELI16 mode" that no shipped code implements (the count
computation was deleted with the inline preamble); describe the real
touch-and-prune behavior instead.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(changelog): correct numeric claims against measured counts
50 of 62 installed skills dropped (fixture/alias entries have no preamble);
11 new carves + a deeper office-hours carve = 9→20; test counts match the
files (13 / 11 / 3 / 7).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: repoint the preamble-runtime version reference after the queue rebump (v1.71.0.0)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(e2e-design): widen the Aesthetic synonym set — vocabulary variance, not a regression
Both attempts in run 33090283032 produced judge-praised DESIGN.md files
phrased as 'design principles'/'design language' without any of the four
original literals; inputs were identical to the prior passing run
32899975845 (design-consultation untouched by the intervening merge).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(test): stage design-consultation's sections/ into the E2E fixture
The skill has been carved since v1.57.0.0 — the DESIGN.md structure
prescription (the AESTHETIC proposal template) lives in
sections/proposal-and-preview.md behind a STOP-read. The fixture only
copied SKILL.md, so the agent improvised structure from the skeleton and
the section-synonym check has been a coin flip since the carve (CI run
33090283032 trace shows 'no sections dir'; the local eval store has the
same failure on 2026-08-25 while that day's CI run passed on lucky
vocabulary).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
315 lines
12 KiB
TypeScript
315 lines
12 KiB
TypeScript
/**
|
|
* Contract + behavior tests for bin/gstack-retro-metrics (retro
|
|
* token-reduction wave — the inline git/awk pipelines from retro/SKILL.md
|
|
* Steps 0.5-9 and 11, consolidated into one script).
|
|
*
|
|
* Three layers:
|
|
* 1. CONTRACT — every labeled `KEY:` line the rendered retro prose
|
|
* interprets must be emitted (hermetic temp HOME + GSTACK_HOME, synthetic
|
|
* git repo fixture with pinned author AND committer dates).
|
|
* 2. BEHAVIOR — deterministic values on the fixture: commit/type/session
|
|
* counts, streak anchoring, window --until, local-branch fallback,
|
|
* AI-trailer vs human co-author split, VERSION range, aux-file presence.
|
|
* 3. EDGES — a 1-commit repo and a non-repo dir both survive (exit 0, no
|
|
* dropped lines); the skill fence shape stays pinned in the template.
|
|
*
|
|
* All hermetic: HOME + GSTACK_HOME point at throwaway temp dirs; the script
|
|
* runs from the live worktree bin/ (the subject under test).
|
|
*/
|
|
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
|
|
import { execFileSync, spawnSync } from 'child_process';
|
|
import * as fs from 'fs';
|
|
import * as os from 'os';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const SCRIPT = path.join(ROOT, 'bin', 'gstack-retro-metrics');
|
|
|
|
let tmpHome: string;
|
|
let tmpGstackHome: string;
|
|
let repoDir: string;
|
|
|
|
function hermeticEnv(): Record<string, string> {
|
|
return { PATH: process.env.PATH!, HOME: tmpHome, GSTACK_HOME: tmpGstackHome };
|
|
}
|
|
|
|
function runMetrics(args: string[], cwd: string = repoDir): string {
|
|
return execFileSync(SCRIPT, args, { encoding: 'utf-8', cwd, env: hermeticEnv() });
|
|
}
|
|
|
|
/** Commit with pinned author AND committer dates (guard + --until read %ci). */
|
|
function commit(dir: string, msg: string, date: string, author?: { name: string; email: string }): void {
|
|
const env: Record<string, string> = {
|
|
...hermeticEnv(),
|
|
GIT_COMMITTER_DATE: date,
|
|
...(author ? { GIT_AUTHOR_NAME: author.name, GIT_AUTHOR_EMAIL: author.email } : {}),
|
|
};
|
|
const r = spawnSync('git', ['commit', '-m', msg, '--date', date], {
|
|
cwd: dir, stdio: 'pipe', timeout: 10_000, env,
|
|
});
|
|
if (r.status !== 0) throw new Error(`fixture commit failed: ${r.stderr}`);
|
|
}
|
|
|
|
function git(dir: string, args: string[]): void {
|
|
const r = spawnSync('git', args, { cwd: dir, stdio: 'pipe', timeout: 10_000, env: hermeticEnv() });
|
|
if (r.status !== 0) throw new Error(`git ${args.join(' ')} failed: ${r.stderr}`);
|
|
}
|
|
|
|
function write(dir: string, file: string, content: string): void {
|
|
fs.writeFileSync(path.join(dir, file), content);
|
|
git(dir, ['add', file]);
|
|
}
|
|
|
|
beforeAll(() => {
|
|
tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-home-'));
|
|
tmpGstackHome = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-gh-'));
|
|
repoDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-repo-'));
|
|
|
|
git(repoDir, ['init', '-b', 'main']);
|
|
git(repoDir, ['config', 'user.email', 'dev@example.com']);
|
|
git(repoDir, ['config', 'user.name', 'Dev']);
|
|
|
|
// Day 1 — one 20-minute session (2 commits) + one solo commit later.
|
|
write(repoDir, 'app.ts', 'console.log("hello");\n');
|
|
commit(repoDir, 'feat: initial app', '2026-03-10T09:00:00');
|
|
write(repoDir, 'auth.ts', 'export function login() {}\n');
|
|
commit(repoDir, 'feat: add auth (#12)', '2026-03-10T09:20:00');
|
|
write(repoDir, 'foo.test.ts', 'test("login", () => {});\n');
|
|
commit(repoDir, 'test(qa): add regression test', '2026-03-10T11:00:00');
|
|
|
|
// Day 2 — 5-minute session; first commit carries an AI trailer AND a human
|
|
// co-author trailer.
|
|
write(repoDir, 'app.ts', '// wire auth\nimport "./auth";\nconsole.log("hello");\n');
|
|
commit(
|
|
repoDir,
|
|
'fix: wire auth\n\nCo-Authored-By: Claude Opus <noreply@anthropic.com>\nCo-Authored-By: Alice Smith <alice@example.com>',
|
|
'2026-03-11T10:00:00',
|
|
);
|
|
write(repoDir, 'VERSION', '1.0.0.0\n');
|
|
commit(repoDir, 'chore: add VERSION', '2026-03-11T10:05:00');
|
|
|
|
// Day 3 — a second author bumps VERSION (contributors=2, team streak=3).
|
|
write(repoDir, 'VERSION', '1.1.0.0\n');
|
|
commit(repoDir, 'chore: bump VERSION', '2026-03-12T09:30:00', { name: 'Bob', email: 'bob@example.com' });
|
|
});
|
|
|
|
afterAll(() => {
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
fs.rmSync(tmpGstackHome, { recursive: true, force: true });
|
|
fs.rmSync(repoDir, { recursive: true, force: true });
|
|
});
|
|
|
|
/** Labeled keys the rendered retro prose interprets (Steps 1-11). */
|
|
const REQUIRED_KEYS = [
|
|
'RETRO_METRICS_PROTO',
|
|
'GUARD_REMOTE',
|
|
'GUARD_HEAD',
|
|
'RETRO_REF',
|
|
'GUARD_LATEST_COMMIT',
|
|
'WINDOW_SINCE',
|
|
'WINDOW_UNTIL',
|
|
'USER_NAME',
|
|
'USER_EMAIL',
|
|
'COMMIT',
|
|
'COMMITS',
|
|
'MERGE_COMMITS',
|
|
'CONTRIBUTORS',
|
|
'INSERTIONS',
|
|
'DELETIONS',
|
|
'NET_LOC',
|
|
'TEST_INSERTIONS',
|
|
'TEST_RATIO',
|
|
'WEIGHTED_COMMITS',
|
|
'ACTIVE_DAYS',
|
|
'TEST_FILES_CHANGED',
|
|
'SESSIONS',
|
|
'DEEP_SESSIONS',
|
|
'MEDIUM_SESSIONS',
|
|
'MICRO_SESSIONS',
|
|
'TOTAL_ACTIVE_MINUTES',
|
|
'AVG_SESSION_MINUTES',
|
|
'LOC_PER_SESSION_HOUR',
|
|
'COMMIT_TYPES',
|
|
'FIX_RATIO',
|
|
'COMMIT_SIZE_BUCKETS',
|
|
'HOURS',
|
|
'PEAK_HOUR',
|
|
'FOCUS_SCORE',
|
|
'BIGGEST_COMMIT',
|
|
'HOTSPOT',
|
|
'AUTHOR',
|
|
'AUTHOR_BIGGEST',
|
|
'WEEK',
|
|
'COAUTHOR',
|
|
'AI_ASSISTED_COMMITS',
|
|
'LOGICAL_SLOC_ADDED',
|
|
'PRS_REFERENCED',
|
|
'PR_REFS',
|
|
'TEST_FILES_TOTAL',
|
|
'REGRESSION_TEST_COMMITS',
|
|
'REGRESSION_COMMIT',
|
|
'VERSION_RANGE',
|
|
'TEAM_STREAK',
|
|
'USER_STREAK',
|
|
'RETRO_CONTEXT',
|
|
'GREPTILE_HISTORY',
|
|
'TODOS_FILE',
|
|
'SKILL_USAGE_LOG',
|
|
'EUREKA_LOG',
|
|
'RETRO_METRICS_END',
|
|
] as const;
|
|
|
|
describe('gstack-retro-metrics contract', () => {
|
|
test('emits every labeled key the retro prose interprets', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
const missing = REQUIRED_KEYS.filter((k) => !new RegExp(`^${k}: `, 'm').test(out));
|
|
expect(missing, `Script stopped emitting: ${missing.join(', ')} — the prose contract broke`).toEqual([]);
|
|
});
|
|
|
|
test('proto handshake is the FIRST line', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out.split('\n')[0]).toBe('RETRO_METRICS_PROTO: 1');
|
|
});
|
|
|
|
test('the skill fence invokes the script with primary path + degraded fallback', () => {
|
|
const tmpl = fs.readFileSync(path.join(ROOT, 'retro', 'SKILL.md.tmpl'), 'utf-8');
|
|
expect(tmpl).toContain('$HOME/.claude/skills/gstack/bin/gstack-retro-metrics');
|
|
expect(tmpl).toContain('".claude/skills/gstack/bin/gstack-retro-metrics"');
|
|
expect(tmpl).toContain('--base "<default>" --since "<since>"');
|
|
expect(tmpl).toContain(
|
|
'RETRO_METRICS: unavailable — stale install (compute metrics manually from the steps below)',
|
|
);
|
|
// Degraded-mode prose keys off the proto handshake.
|
|
expect(tmpl).toContain('RETRO_METRICS_PROTO: 1');
|
|
});
|
|
|
|
test('script is executable', () => {
|
|
expect(fs.statSync(SCRIPT).mode & 0o111).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe('gstack-retro-metrics behavior', () => {
|
|
test('deterministic aggregates on the fixture', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out).toMatch(/^COMMITS: 6$/m);
|
|
expect(out).toMatch(/^CONTRIBUTORS: 2$/m);
|
|
expect(out).toMatch(/^ACTIVE_DAYS: 3$/m);
|
|
// No origin remote: guard discloses, ref falls back to the local branch.
|
|
expect(out).toMatch(/^GUARD_REMOTE: none$/m);
|
|
expect(out).toMatch(/^GUARD_HEAD: main$/m);
|
|
expect(out).toMatch(/^RETRO_REF: main$/m);
|
|
expect(out).toMatch(/^GUARD_LATEST_COMMIT: 2026-03-12$/m);
|
|
// Conventional-commit mix (feat 2, fix 1, test 1, chore 2).
|
|
const types = out.match(/^COMMIT_TYPES: (.*)$/m)![1];
|
|
expect(types).toContain('feat=2');
|
|
expect(types).toContain('fix=1');
|
|
expect(types).toContain('test=1');
|
|
expect(types).toContain('chore=2');
|
|
// Session detection: [09:00,09:20]=medium, [11:00]=micro, [10:00,10:05]=micro, [09:30]=micro.
|
|
expect(out).toMatch(/^SESSIONS: 4$/m);
|
|
expect(out).toMatch(/^MEDIUM_SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^MICRO_SESSIONS: 3$/m);
|
|
expect(out).toMatch(/^DEEP_SESSIONS: 0$/m);
|
|
expect(out).toMatch(/^TOTAL_ACTIVE_MINUTES: 25$/m);
|
|
// Test health.
|
|
expect(out).toMatch(/^TEST_FILES_TOTAL: 1$/m);
|
|
expect(out).toMatch(/^TEST_FILES_CHANGED: 1$/m);
|
|
expect(out).toMatch(/^REGRESSION_TEST_COMMITS: 1$/m);
|
|
expect(out).toMatch(/^REGRESSION_COMMIT: \w+ test\(qa\): add regression test$/m);
|
|
// PR refs from subjects.
|
|
expect(out).toMatch(/^PRS_REFERENCED: 1$/m);
|
|
expect(out).toMatch(/^PR_REFS: #12$/m);
|
|
// AI trailer counted separately from the human co-author credit.
|
|
expect(out).toMatch(/^AI_ASSISTED_COMMITS: 1$/m);
|
|
expect(out).toMatch(/^COAUTHOR: \w+\|Alice Smith <alice@example\.com>$/m);
|
|
expect(out).not.toMatch(/^COAUTHOR: .*anthropic\.com/m);
|
|
// VERSION range across the window.
|
|
expect(out).toMatch(/^VERSION_RANGE: v1\.0\.0\.0 → v1\.1\.0\.0$/m);
|
|
// Streaks anchored at the newest commit date, never the wall clock.
|
|
expect(out).toMatch(/^TEAM_STREAK: 3 days \(anchor 2026-03-12\)$/m);
|
|
expect(out).toMatch(/^USER_STREAK: 2 days \(anchor 2026-03-11\)$/m);
|
|
// Hour histogram carries the fixture's commit hours.
|
|
const hours = out.match(/^HOURS: (.*)$/m)![1];
|
|
expect(hours).toContain('09=');
|
|
expect(hours).toContain('10=');
|
|
});
|
|
|
|
test('--until bounds the window (compare mode prior window)', () => {
|
|
const out = runMetrics([
|
|
'--base', 'main',
|
|
'--since', '2026-03-09T00:00:00',
|
|
'--until', '2026-03-11T00:00:00',
|
|
]);
|
|
expect(out).toMatch(/^COMMITS: 3$/m);
|
|
expect(out).toMatch(/^ACTIVE_DAYS: 1$/m);
|
|
expect(out).toMatch(/^WINDOW_UNTIL: 2026-03-11T00:00:00$/m);
|
|
});
|
|
|
|
test('aux inputs report present when the files exist under GSTACK_HOME', () => {
|
|
fs.writeFileSync(path.join(tmpGstackHome, 'greptile-history.md'), '# history\n');
|
|
fs.mkdirSync(path.join(tmpGstackHome, 'analytics'), { recursive: true });
|
|
fs.writeFileSync(path.join(tmpGstackHome, 'analytics', 'skill-usage.jsonl'), '{}\n');
|
|
try {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out).toMatch(/^GREPTILE_HISTORY: present /m);
|
|
expect(out).toMatch(/^SKILL_USAGE_LOG: present /m);
|
|
expect(out).toMatch(/^RETRO_CONTEXT: absent$/m);
|
|
expect(out).toMatch(/^EUREKA_LOG: absent$/m);
|
|
} finally {
|
|
fs.rmSync(path.join(tmpGstackHome, 'greptile-history.md'), { force: true });
|
|
fs.rmSync(path.join(tmpGstackHome, 'analytics'), { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('zero-commit window still emits the full labeled surface', () => {
|
|
const out = runMetrics([
|
|
'--base', 'main',
|
|
'--since', '2020-01-01T00:00:00',
|
|
'--until', '2020-01-08T00:00:00',
|
|
]);
|
|
expect(out).toMatch(/^COMMITS: 0$/m);
|
|
expect(out).toMatch(/^SESSIONS: 0$/m);
|
|
expect(out).toMatch(/^RETRO_METRICS_END: ok$/m);
|
|
});
|
|
});
|
|
|
|
describe('gstack-retro-metrics edges', () => {
|
|
test('survives a repo with exactly 1 commit', () => {
|
|
const oneDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-one-'));
|
|
try {
|
|
git(oneDir, ['init', '-b', 'main']);
|
|
git(oneDir, ['config', 'user.email', 'solo@example.com']);
|
|
git(oneDir, ['config', 'user.name', 'Solo']);
|
|
write(oneDir, 'a.txt', 'hi\n');
|
|
commit(oneDir, 'feat: first', '2026-03-10T09:00:00');
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00'], oneDir);
|
|
expect(out).toMatch(/^COMMITS: 1$/m);
|
|
expect(out).toMatch(/^CONTRIBUTORS: 1$/m);
|
|
expect(out).toMatch(/^SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^MICRO_SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^TEAM_STREAK: 1 days \(anchor 2026-03-10\)$/m);
|
|
expect(out).toMatch(/^BIGGEST_COMMIT: \w+\|1\|Solo\|feat: first$/m);
|
|
expect(out).toMatch(/^RETRO_METRICS_END: ok$/m);
|
|
} finally {
|
|
fs.rmSync(oneDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('non-repo dir reports RETRO_METRICS_ERROR and exits 0', () => {
|
|
const emptyDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-empty-'));
|
|
try {
|
|
const out = runMetrics(['--since', '7 days ago'], emptyDir);
|
|
expect(out).toContain('RETRO_METRICS_PROTO: 1');
|
|
expect(out).toContain('RETRO_METRICS_ERROR: not inside a git repository');
|
|
} finally {
|
|
fs.rmSync(emptyDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('local reads only: no network git ops or curl anywhere in the script', () => {
|
|
const script = fs.readFileSync(SCRIPT, 'utf-8');
|
|
expect(script).not.toMatch(/(^|[;|&`($!]|\s)git(\s+-C\s+\S+)?\s+(push|pull|fetch|clone|ls-remote)\b/m);
|
|
expect(script).not.toMatch(/(^|[|&;(`]|\s|\$\()curl\s/);
|
|
});
|
|
});
|