mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-01 15:51:41 +02:00
66f3a180d3
* fix(gbrain-sync): --full produces an empty code index on first run of a new repo
`gbrain reindex-code` only RE-EMBEDS pages that already exist; it never walks
the filesystem. On a freshly-registered source (0 pages), a --full run that
called reindex-code alone found nothing ("No code pages to reindex"), finished
in ~1s, and left the code index permanently empty while still reporting OK.
Fix: --full now runs `sync --strategy code` FIRST to create pages via the file
walk, then runs `reindex-code` to honor the documented "full walk + reindex"
contract for both fresh and populated sources.
Contributed by @jetsetterfl via #1584.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(gbrain-local-status): classifier falsely reports broken-db inside repos with their own DATABASE_URL
The freshClassify probe ran `gbrain sources list --json` with the inherited
process env. When the probe ran from inside a repo with its own .env (an app
DATABASE_URL on a different port), Bun autoloaded the project's .env, gbrain
connected to the wrong database, and the classifier reported broken-db on
otherwise-healthy brains.
Fix: route the probe env through `buildGbrainEnv` from lib/gbrain-exec, the
same helper the sync orchestrator uses. DATABASE_URL is seeded from
~/.gbrain/config.json so the result is cwd-independent. The 60s cache can no
longer propagate a poisoned negative to clean directories.
Contributed by @jetsetterfl via #1583.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(retro): stale-base + bad-today-anchor pre-flight guard (#1624)
/retro silently produced confidently-wrong output when "today" drifted (model
session-context error) or when origin/<default> was materially behind the
actual remote — git log --since returned zero or near-zero commits and the
narrative was fabricated from nothing.
Adds Step 0.5 with four ordered pre-check branches before any window analysis:
A. No 'origin' remote → skip with "base freshness not verified" note
B. Detached HEAD → skip with "base freshness not verified" note
C. `git fetch origin <default>` fails (offline) → warn, proceed against
last-known origin/<default>
D. Fetch succeeded → compare today vs latest origin/<default> commit; if
gap > window-days, BLOCK with explicit citation of latest-commit date.
Skip paths still proceed to Step 1, but the disclosure is carried into the
retro narrative ("offline run, window not freshness-verified") so the output
is never silently confidently-wrong.
Atomic .tmpl + gen:skill-docs regen commit (T-Codex-3 pattern).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(retro): regression for #1624 stale-base pre-flight guard
13 static-invariant tests pinning the four ordered pre-check branches in
retro/SKILL.md.tmpl:Step 0.5:
A. no-remote skip — must check origin presence + set verdict
B. detached-HEAD skip — must gate behind prior verdict (ordering)
C. fetch-fail warn — must match `if !` or `||` shape, gate by verdict
D. stale-base BLOCK — must read latest-commit ISO date, cite remediation
Plus a disclosure-survives-to-narrative invariant: skip-path verdicts must be
named in prose so the retro output carries the cited reason rather than
silently misreporting.
Failing build if Step 0.5 is removed, branches re-ordered (no-remote no longer
wins), or the BLOCK message stops citing today/latest-commit/remediation
path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(gbrain-sync): configurable timeouts + resume from gbrain checkpoint (#1611)
The memory and code stages hardcoded a 35-min spawn timeout. On brains with
~2000+ staged files, /sync-gbrain --full reliably SIGTERM'd the child at
exactly 35 minutes with exit 143. gbrain left ~/.gbrain/import-checkpoint.json
pointing at the staging dir, but gstack-memory-ingest's SIGTERM handler
unconditionally cleaned the dir up — so the next run found a checkpoint
pointing at nothing and restaged from scratch, repeating the SIGTERM forever.
Three changes:
1. Configurable timeouts via env (bounds 60_000ms - 86_400_000ms, default
2_100_000ms = 35min unchanged):
GSTACK_SYNC_MEMORY_TIMEOUT_MS
GSTACK_SYNC_CODE_TIMEOUT_MS
Out-of-range or non-numeric values warn and fall back to the default.
2. SIGTERM in gstack-memory-ingest no longer always cleans up the staging
dir. If gbrain has written ~/.gbrain/import-checkpoint.json pointing at
the active staging dir, the dir is PRESERVED for next-run resume.
Otherwise (no checkpoint pointing here, crash before gbrain ever
touched it) it's cleaned up as before.
3. Next /sync-gbrain run detects gbrain's checkpoint via decideResume() in
gstack-gbrain-sync.ts:
- no checkpoint → fresh ingest pass
- checkpoint + staging ok → set GSTACK_INGEST_RESUME_DIR; child
reuses staging dir and skips
writeStaged; gbrain import resumes
from processedIndex+1
- checkpoint + staging gone → warn "previous checkpoint stale
(staging dir gone), restaging from
scratch" and proceed
Reuses gbrain's own checkpoint as the source of truth (D1 — no double-store
state). Detect-then-fallback semantics per C1.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(gbrain-sync): regression for #1611 timeouts + resume
19 tests across three surfaces:
- resolveStageTimeoutMs (10 tests): undefined/empty → default; non-numeric,
zero, negative, below-floor, above-ceiling → warn + default; at-floor,
at-ceiling, valid mid-range → accepted as-is.
- decideResume (6 tests): no checkpoint, corrupt JSON, checkpoint + staging
ok, checkpoint + staging missing, checkpoint with no dir, checkpoint with
empty dir.
- SIGTERM staging preservation (3 static invariants): memory-ingest signal
handler must check stagingDirIsCheckpointed BEFORE cleanup; preserve
branch must come before cleanup branch (ordering); orchestrator must
pass GSTACK_INGEST_RESUME_DIR to the grandchild on resume.
Also threads process.env.HOME through readGbrainCheckpoint and
stagingDirIsCheckpointed so tests can redirect home. os.homedir() caches
at process start and ignores later mutation, so the env override is the
only reliable test injection point.
Failing build if the timeout bounds are removed, the resume detection
short-circuits incorrectly, or the SIGTERM handler regresses to
unconditional cleanup.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(review): pre-emit verification gate kills Django-shape FP class (#1539)
External user filed 4/8 false positives on a /review run against a Django +
DRF + PostgreSQL repo (Sprint 2.5). Every FP class was the same shape:
"resolvable in <5 minutes by viewing the actual code or running a simple
grep" — fields that don't exist on the model, dict.get()-might-be-None on a
form that returns {}-initialized cleaned_data, standard ORM save behavior
called out as data loss.
Extends the Confidence Calibration resolver (consumed by review, cso,
plan-eng-review, ship) with a Pre-emit verification gate:
Every finding MUST quote the specific code line that motivates it
(file:line + verbatim text). If the reviewer cannot produce the quote,
the finding is unverified — its confidence is forced to 4-5 so the
existing "Suppress from main report" rule fires automatically. The
finding still goes to the appendix for calibration audit, but the user
does not see it in the critical-pass output.
Reuses the existing suppression mechanism — no new code path. The FP
classes the gate kills are enumerated in the resolver text so reviewers
see the named patterns.
Framework-meta nudge included for Django Meta, Rails associations,
SQLAlchemy relationships, TypeORM decorators, Sequelize init, Prisma
generated client — the reviewer must quote the meta-construct that
generates the symbol, not just grep for the literal name. Deeper
framework-aware ORM verification (model introspection, migration-history-
aware checks) is deliberately deferred to a future wave per T-Codex-2.
Atomic .tmpl-equivalent (resolver) edit + gen:skill-docs regen commit
per T-Codex-3.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(review): regression for #1539 pre-emit verification gate
12 tests pinning the gate behavior:
- Resolver emits the gate header + #1539 reference
- Gate requires quoting file:line + verbatim text
- Unverified findings forced to confidence 4-5 (auto-suppress via
existing <7-rule, no new mechanism)
- Framework-meta nudge names Django, Rails, SQLAlchemy, TypeORM,
Sequelize, Prisma
- Deferred design doc reference present (1539-framework-aware-review.md)
- Four named FP classes from #1539 enumerated:
* field doesn't exist on model
* dict.get() might be None
* save() might lose fields
* update_fields might miss X
- All four downstream SKILL.md consumers (review, cso, plan-eng-review,
ship) carry the gate text after gen:skill-docs
- Existing confidence 9-10 'Show normally' + 3-4 'Suppress' rows
unchanged (regression on existing behavior)
Failing build if the gate is removed, the suppression mechanism is
re-invented separately, the framework-meta nudge drops a framework, or
gen:skill-docs stops propagating the gate to consumers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(config): expose explain_level default
* fix(benchmark): parse positional prompt after flags
* fix(artifacts): reject malformed remote paths
* fix(learnings): preserve current entries in cross-project search
* fix(setup): register root gstack slash alias
* fix(memory): probe gitleaks without shell builtin
* fix(gbrain-lib): pin LC_ALL=C in varname validator (macOS locale guard)
In many macOS shells the default locale (e.g. en_US.UTF-8) makes bash
glob brackets like `[A-Z]` match lowercase letters too, so the existing
`case "$name" in [A-Z_][A-Z0-9_]*)` branch lets names like `lower-case`
through validation. The function then trips `printf -v "$varname"` and
`export "$varname"` with `not a valid identifier` errors that surface
mid-prompt, which is exactly what the validator was supposed to prevent.
Pinning `LC_ALL=C` inside the function gives ASCII-only bracket semantics
on both macOS and Linux, matching the documented `[A-Z_][A-Z0-9_]*`
contract. Declared `local` so it doesn't leak to the calling shell —
`gstack-gbrain-lib.sh` is documented as a sourced helper, so a bare
assignment would mutate the caller's locale for the rest of the process
(silently affecting downstream `sort`, `tr`, locale-aware globs in the
same shell, etc.).
The existing regression test
`test/gbrain-lib-verify.test.ts:'rejects invalid var names'`
already covers the macOS repro shape (passes `lower-case` and expects
the validator to reject + emit `invalid var name`). On Linux CI the
test silently passed because `LC_ALL=C` is the typical default; on
macOS dev boxes it fails.
Verified:
- `bun test test/gbrain-lib-verify.test.ts`: 22 pass, 0 fail (on macOS).
- `_gstack_gbrain_validate_varname lower-case; echo $?` → 2.
- `_gstack_gbrain_validate_varname FOO_BAR; echo $?` → 0.
- Caller's LC_ALL preserved across calls (confirmed via sourced bash).
* fix(land-and-deploy): detect merged PR after gh failure
After `gh pr merge` exits non-zero, the PR may already be MERGED server-side
(concurrent merge landed, or local cleanup phase failed AFTER the merge
succeeded). Calling `gh pr merge` a second time then errors with a confusing
"already merged" — and worse, the deploy workflow never runs because we
stopped on the first failure.
Adds a Post-failure PR-state check (§4a-postfail) that runs after ANY
non-zero exit from `gh pr merge`:
- state == MERGED → record MERGE_PATH=direct, OFFER (don't force)
stale-worktree cleanup on the base branch with
uncommitted-work guard, proceed to §4a CI watch
- state == OPEN → check autoMergeRequest; if non-null treat as
merge-queue wait; if null surface both errors and STOP
- state == CLOSED → STOP
Hard invariant: never retry `gh pr merge` after a non-zero exit. Server
state is authoritative.
Re-authored from PR #1620 into land-and-deploy/SKILL.md.tmpl (the source of
truth) instead of the generated SKILL.md, so the next gen:skill-docs run
preserves the change. Original diff by @davidfoy via #1620.
Related: cli/cli#3442, cli/cli#13380.
Contributed by @davidfoy via #1620.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: detect PgBouncer transaction-mode pooler and set GBRAIN_PREPARE=true (#1435)
When gbrain connects through a PgBouncer transaction-mode pooler (port
6543), it auto-disables prepared statements. This breaks `gbrain search`
silently — the /sync-gbrain capability check fails and the GBrain Search
Guidance block never gets written to CLAUDE.md.
Three-layer fix:
1. **lib/gbrain-exec.ts** — `buildGbrainEnv()` now detects port 6543 in
the effective DATABASE_URL and sets `GBRAIN_PREPARE=true` in the env
passed to every gbrain spawn. This is the single chokepoint — all
gstack gbrain invocations inherit the fix. Caller can opt out with
`GBRAIN_PREPARE=false`.
2. **sync-gbrain/SKILL.md{,.tmpl}** — capability check now exports
`GBRAIN_PREPARE=true` explicitly and retries search up to 3x with 1s
delay for async index propagation under connection pooling.
3. **bin/gstack-gbrain-detect** — surfaces `gbrain_pooler_mode` field
("transaction" | "session" | null) in the preamble probe JSON so
/setup-gbrain and /sync-gbrain can advise users about pooler state.
Closes #1435
Built with [ClosedLoop.AI](https://closedloop.ai) | [GitHub](https://github.com/closedloop-ai/claude-plugins)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(supabase-provision): rewrite transaction/6543 -> session/5432 for new projects
- Single-object pooler API responses default to transaction-mode at 6543,
but the shared pooler tenant on new projects only listens on session/5432
- Add a `pool_mode == transaction && db_port == 6543` rewrite + stderr note
- Escape hatch via `GSTACK_SUPABASE_TRUST_API_PORT=1` for forward-compat
- 5 new tests covering rewrite, no-op shapes, env opt-out, array path
Fixes #1301.
* fix(browse): GSTACK_CHROMIUM_NO_SANDBOX opt-out for Ubuntu/AppArmor (#1562)
Ubuntu/AppArmor configurations often block unprivileged Chromium sandboxing
for headless agent sessions even for normal users — /qa hangs without
--no-sandbox. The kernel policy denies the unprivileged user namespaces
Chromium needs.
Adds GSTACK_CHROMIUM_NO_SANDBOX=1 as an explicit user override that forces
the sandbox off without changing the default for everyone else. Re-authored
from PR #1562 onto v1.42.2.0's shouldEnableChromiumSandbox() helper —
purely additive, preserves the headed-launch sandbox-on-by-default behavior
that v1.42.2.0 shipped to kill the --no-sandbox yellow infobar.
Three new regression tests cover:
- linux + override=1 → false (the named use case)
- darwin + override=1 → false (env wins on any platform)
- override=0 → does NOT trigger (must be exactly "1")
Original diff by @techcenter68 via #1562.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(browse): mirror isCustomChromium() guard in headless launch()
When BROWSE_EXTENSIONS_DIR is set alongside GSTACK_CHROMIUM_PATH pointing
at a baked-extension build (GBrowser / GStack Browser), the headless launch()
path was unconditionally adding --disable-extensions-except / --load-extension.
This causes the same ServiceWorkerState::SetWorkerId DCHECK crash that
launchHeaded() already guards against via isCustomChromium().
Mirror the existing guard: skip --load-extension flags when isCustomChromium()
returns true; always push the off-screen window geometry args.
* fix(browse): daemonize macOS/Linux server via setsid()
`Bun.spawn().unref()` only releases the child from Bun's event loop —
it does NOT call setsid(). The spawned bun server inherits the spawning
shell's process session. When the CLI runs inside a session-managed shell
that exits shortly after the CLI returns (Claude Code's per-command Bash
sandbox, Conductor, OpenClaw, CI step runners), the session leader's exit
sends SIGHUP to every PID in the session — killing the bun server and
its Chromium grandchildren within seconds of a successful `connect`.
Setting `BROWSE_PARENT_PID=0` (already done by the `connect` command and
pair-agent) disables the parent-process watchdog but does NOT save the
server here: SIGHUP from session teardown still reaps it.
Replace the macOS/Linux `Bun.spawn().unref()` with Node's
`child_process.spawn({ detached: true })`, which calls setsid() and
gives the server its own session leader role (PPID=1, STAT=Ss). This
mirrors the Windows path's rationale (PR #191 by @fqueiro) — same root
cause, different OS surface.
Verified on macOS in Conductor: pre-fix the server dies ~10–15s after
connect across separate Bash invocations; post-fix the same PID stays
alive (PPID=1, SESS=0, STAT=Ss) and responds to `status`/`goto`/
`snapshot` across many separate shell calls.
The `proc?.stderr` startup-error branch is removed since both platforms
now spawn with `stdio: 'ignore'`; both fall through to the on-disk
`browse-startup-error.log` written by `server.ts`'s start().catch.
* fix(design): bump image-gen timeout to 240s + pin gpt-image-2
The design binary calls /v1/responses (gpt-4o + image_generation tool,
quality:high, 1536x1024) but aborted the request after a hardcoded 120s.
That class of request consistently takes ~140-160s end-to-end, so every
generate/variants/evolve/iterate call aborted before the image returned.
In /design-shotgun this cascades: Step 3c launches N parallel agents,
each calling `$D generate`, each aborts at 120s and retries, all fail,
the comparison board never opens — the skill appears to hang indefinitely.
Reproduced the exact API call with a longer budget: HTTP 200, valid
image, 143.5s. A real /design-shotgun run after the patch generated 3
variants in parallel at 150.0s / 161.0s / 152.1s, all exit 0 — note the
161s case, which a naive 150s bump would still have failed.
- Bump AbortController timeout 120_000 -> 240_000 in generate.ts,
variants.ts, evolve.ts, iterate.ts (both call sites)
- Pin the image_generation tool to model "gpt-image-2"
design/test/variants-retry-after.test.ts: 5 pass, 0 fail. The
feedback-roundtrip.test.ts failures are a pre-existing browse-module
breakage (session.clearLoadedHtml undefined), unrelated to this change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test: fill coverage gaps for PRs #1606, #1612, #1620
Three cherry-picked PRs in this wave landed without unit-test coverage for
the specific invariant they protect:
#1606 (@andrey-esipov) — LC_ALL=C pin in _gstack_gbrain_validate_varname
8 tests by sourcing bin/gstack-gbrain-lib.sh and calling the validator
directly. Asserts uppercase/digit/underscore accepted, lowercase
REJECTED (the macOS-locale regression case), mixed-case rejected,
LC_ALL=C scoping is local (doesn't leak to caller).
#1612 (@bharat2913) — setsid daemonize via Node child_process.spawn
4 static-invariant tests on browse/src/cli.ts. The actual setsid
syscall is hard to assert without a real spawn, so we pin the source
shape: nodeSpawn imported from child_process; non-Windows branch uses
nodeSpawn(...) with detached:true and .unref(); comment documents
setsid/SIGHUP root cause; Bun.spawn() is NOT used on macOS/Linux.
#1620 (@davidfoy, re-authored into .tmpl per A3) — §4a-postfail
12 static invariants on land-and-deploy/SKILL.md.tmpl + generated
SKILL.md. Pins all three state branches (MERGED/OPEN/CLOSED), the
authoritative state query, the merge-SHA capture, non-destructive
worktree cleanup with uncommitted-work guard, autoMergeRequest probe
on OPEN, hard "never retry gh pr merge" rule, and atomic regen
propagation.
Failing build if any of the three invariants regresses.
Note: gbrain-lib-validate-varname.test.ts also surfaces a pre-existing
glob-pattern overpermissiveness (hyphens + dots accepted) — not in
#1606's scope; documented inline as a separate cleanup target.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(learnings): align injection-prevention tests with PR #1619 tagged-line shape
PR #1619 (preserve current entries in cross-project search) refactored
gstack-learnings-search to tag rows inline (`current\t<json>` vs
`cross\t<json>`) instead of filtering inside the bun block via
process.env.GSTACK_SEARCH_SLUG. The bun block no longer reads SLUG or
CROSS env vars — it parses the per-line tag and sets a per-entry
_crossProject flag.
The pre-existing test/learnings-injection.test.ts still asserted on the
old SLUG + CROSS env var shape. Updates:
- Remove the SLUG env var assertion (no longer set on bash command line)
- Remove the bun-block CROSS env var assertion (block reads the tag now,
not the env)
- Add a new positive assertion that the bun block parses the tag
(sourceTag | tabIndex | crossProject)
- Keep the shell-interpolation safety assertion unchanged — that's
independent of the SLUG refactor
The CROSS env var is still SET on the bash command line (it controls
whether the cross-project find runs at all), but the bun child no longer
reads it. The existing "env vars set on bash command line" test continues
to pin that.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(fixtures): regenerate ship-SKILL.md golden baselines
ship/SKILL.md consumes the Confidence Calibration resolver via the
preamble pipeline. This wave's #1539 pre-emit verification gate extends
the resolver text, which propagated to ship/SKILL.md via gen:skill-docs.
The golden fixtures in test/fixtures/golden/ matched the pre-#1539 shape
and failed the host-config regression check.
Refreshes claude-ship-SKILL.md, codex-ship-SKILL.md, and factory-ship-SKILL.md
to match the current generated output. Matches the Daegu wave's bisect
commit 23 ("test(fixtures): regenerate ship-SKILL.md golden baselines").
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(gbrain-detect): include gbrain_pooler_mode in schema regression (PR #1591)
PR #1591 (PgBouncer transaction-mode detection, @mikeangstadt) added
gbrain_pooler_mode to the gstack-gbrain-detect JSON output but did not
update the schema regression check in
test/gstack-gbrain-detect-mcp-mode.test.ts. Adding the key in alphabetical
order matching the rest of the schema array. Downstream sync-gbrain ignores
unknown keys, so this is forward-compat.
Without this, the test fails with a diff:
+ "gbrain_pooler_mode"
because keys is the actual set returned and the expected array was
pre-#1591.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(release): v1.43.0.0 — post-Daegu paper-cut wave
Bumps VERSION 1.42.2.0 → 1.43.0.0 (MINOR per scale-aware bump rules: new
env-var surface GSTACK_SYNC_*_TIMEOUT_MS + GSTACK_CHROMIUM_NO_SANDBOX,
behavior expansion in browse/src/browser-manager.ts headless launch,
three skill-template prompt changes affecting /retro, /review,
/sync-gbrain).
CHANGELOG entry leads with what stopped happening: /retro stops
fabricating retros against stale bases, /sync-gbrain stops SIGTERM-looping
35-min restarts on big brains, /review stops shipping framework FPs the
reviewer never grep'd.
18 fixes total — 15 community PRs + 3 self-filed silent-failure issues
(#1624, #1611, #1539) — in one bundled PR with 26 bisect commits and 7
new regression test files. Every wave-touched test file passes in
isolation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(release): bump v1.43.0.0 → v1.43.2.0 for queue collision
CI check-version-stale flagged v1.43.0.0 already claimed by PR #1574
(garrytan/colombo-v3). PR #1639 (garrytan/muscat-v3) claims v1.43.1.0.
Next available MINOR slot is v1.43.2.0.
Bump VERSION + package.json + CHANGELOG entry header. No behavior
changes — purely re-versioning to clear the queue collision.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Jayesh Betala <jayesh.betala7@gmail.com>
Co-authored-by: Andrey Esipov <andrey.esipov@outlook.com>
Co-authored-by: David Foy <davidfoy@users.noreply.github.com>
Co-authored-by: mikeangstadt <mike.angstadt@closedloop.ai>
Co-authored-by: 0xDevNinja <manmit0x@gmail.com>
Co-authored-by: techcenter68 <techcenter68@users.noreply.github.com>
Co-authored-by: shohu <shohu33@gmail.com>
Co-authored-by: Bharat <bharat@theysaid.io>
Co-authored-by: Matteo Hertel <info@matteohertel.com>
1009 lines
48 KiB
Cheetah
1009 lines
48 KiB
Cheetah
---
|
|
name: land-and-deploy
|
|
preamble-tier: 4
|
|
version: 1.0.0
|
|
description: |
|
|
Land and deploy workflow. Merges the PR, waits for CI and deploy,
|
|
verifies production health via canary checks. Takes over after /ship
|
|
creates the PR. Use when: "merge", "land", "deploy", "merge and verify",
|
|
"land it", "ship it to production". (gstack)
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Write
|
|
- Glob
|
|
- AskUserQuestion
|
|
sensitive: true
|
|
triggers:
|
|
- merge and deploy
|
|
- land the pr
|
|
- ship to production
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
{{BROWSE_SETUP}}
|
|
|
|
{{BASE_BRANCH_DETECT}}
|
|
|
|
**If the platform detected above is GitLab or unknown:** STOP with: "GitLab support for /land-and-deploy is not yet implemented. Run `/ship` to create the MR, then merge manually via the GitLab web UI." Do not proceed.
|
|
|
|
# /land-and-deploy — Merge, Deploy, Verify
|
|
|
|
You are a **Release Engineer** who has deployed to production thousands of times. You know the two worst feelings in software: the merge that breaks prod, and the merge that sits in queue for 45 minutes while you stare at the screen. Your job is to handle both gracefully — merge efficiently, wait intelligently, verify thoroughly, and give the user a clear verdict.
|
|
|
|
This skill picks up where `/ship` left off. `/ship` creates the PR. You merge it, wait for deploy, and verify production.
|
|
|
|
## User-invocable
|
|
When the user types `/land-and-deploy`, run this skill.
|
|
|
|
## Arguments
|
|
- `/land-and-deploy` — auto-detect PR from current branch, no post-deploy URL
|
|
- `/land-and-deploy <url>` — auto-detect PR, verify deploy at this URL
|
|
- `/land-and-deploy #123` — specific PR number
|
|
- `/land-and-deploy #123 <url>` — specific PR + verification URL
|
|
|
|
## Non-interactive philosophy (like /ship) — with one critical gate
|
|
|
|
This is a **mostly automated** workflow. Do NOT ask for confirmation at any step except
|
|
the ones listed below. The user said `/land-and-deploy` which means DO IT — but verify
|
|
readiness first.
|
|
|
|
**Always stop for:**
|
|
- **First-run dry-run validation (Step 1.5)** — shows deploy infrastructure and confirms setup
|
|
- **Pre-merge readiness gate (Step 3.5)** — reviews, tests, docs check before merge
|
|
- GitHub CLI not authenticated
|
|
- No PR found for this branch
|
|
- CI failures or merge conflicts
|
|
- Permission denied on merge
|
|
- Deploy workflow failure (offer revert)
|
|
- Production health issues detected by canary (offer revert)
|
|
|
|
**Never stop for:**
|
|
- Choosing merge method (auto-detect from repo settings)
|
|
- Timeout warnings (warn and continue gracefully)
|
|
|
|
## Voice & Tone
|
|
|
|
Every message to the user should make them feel like they have a senior release engineer
|
|
sitting next to them. The tone is:
|
|
- **Narrate what's happening now.** "Checking your CI status..." not just silence.
|
|
- **Explain why before asking.** "Deploys are irreversible, so I check X before proceeding."
|
|
- **Be specific, not generic.** "Your Fly.io app 'myapp' is healthy" not "deploy looks good."
|
|
- **Acknowledge the stakes.** This is production. The user is trusting you with their users' experience.
|
|
- **First run = teacher mode.** Walk them through everything. Explain what each check does and why.
|
|
- **Subsequent runs = efficient mode.** Brief status updates, no re-explanations.
|
|
- **Never be robotic.** "I ran 4 checks and found 1 issue" not "CHECKS: 4, ISSUES: 1."
|
|
|
|
---
|
|
|
|
## Step 1: Pre-flight
|
|
|
|
Tell the user: "Starting deploy sequence. First, let me make sure everything is connected and find your PR."
|
|
|
|
1. Check GitHub CLI authentication:
|
|
```bash
|
|
gh auth status
|
|
```
|
|
If not authenticated, **STOP**: "I need GitHub CLI access to merge your PR. Run `gh auth login` to connect, then try `/land-and-deploy` again."
|
|
|
|
2. Parse arguments. If the user specified `#NNN`, use that PR number. If a URL was provided, save it for canary verification in Step 7.
|
|
|
|
3. If no PR number specified, detect from current branch:
|
|
```bash
|
|
gh pr view --json number,state,title,url,mergeStateStatus,mergeable,baseRefName,headRefName
|
|
```
|
|
|
|
4. Tell the user what you found: "Found PR #NNN — '{title}' (branch → base)."
|
|
|
|
5. Validate the PR state:
|
|
- If no PR exists: **STOP.** "No PR found for this branch. Run `/ship` first to create a PR, then come back here to land and deploy it."
|
|
- If `state` is `MERGED`: "This PR is already merged — nothing to deploy. If you need to verify the deploy, run `/canary <url>` instead."
|
|
- If `state` is `CLOSED`: "This PR was closed without merging. Reopen it on GitHub first, then try again."
|
|
- If `state` is `OPEN`: continue.
|
|
|
|
---
|
|
|
|
## Step 1.5: First-run dry-run validation
|
|
|
|
Check whether this project has been through a successful `/land-and-deploy` before,
|
|
and whether the deploy configuration has changed since then:
|
|
|
|
```bash
|
|
{{SLUG_EVAL}}
|
|
if [ ! -f ~/.gstack/projects/$SLUG/land-deploy-confirmed ]; then
|
|
echo "FIRST_RUN"
|
|
else
|
|
# Check if deploy config has changed since confirmation
|
|
SAVED_HASH=$(cat ~/.gstack/projects/$SLUG/land-deploy-confirmed 2>/dev/null)
|
|
CURRENT_HASH=$(sed -n '/## Deploy Configuration/,/^## /p' CLAUDE.md 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
# Also hash workflow files that affect deploy behavior
|
|
WORKFLOW_HASH=$(find .github/workflows -maxdepth 1 \( -name '*deploy*' -o -name '*cd*' \) 2>/dev/null | xargs cat 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
COMBINED_HASH="${CURRENT_HASH}-${WORKFLOW_HASH}"
|
|
if [ "$SAVED_HASH" != "$COMBINED_HASH" ] && [ -n "$SAVED_HASH" ]; then
|
|
echo "CONFIG_CHANGED"
|
|
else
|
|
echo "CONFIRMED"
|
|
fi
|
|
fi
|
|
```
|
|
|
|
**If CONFIRMED:** Print "I've deployed this project before and know how it works. Moving straight to readiness checks." Proceed to Step 2.
|
|
|
|
**If CONFIG_CHANGED:** The deploy configuration has changed since the last confirmed deploy.
|
|
Re-trigger the dry run. Tell the user:
|
|
|
|
"I've deployed this project before, but your deploy configuration has changed since the last
|
|
time. That could mean a new platform, a different workflow, or updated URLs. I'm going to
|
|
do a quick dry run to make sure I still understand how your project deploys."
|
|
|
|
Then proceed to the FIRST_RUN flow below (steps 1.5a through 1.5e).
|
|
|
|
**If FIRST_RUN:** This is the first time `/land-and-deploy` is running for this project. Before doing anything irreversible, show the user exactly what will happen. This is a dry run — explain, validate, and confirm.
|
|
|
|
Tell the user:
|
|
|
|
"This is the first time I'm deploying this project, so I'm going to do a dry run first.
|
|
|
|
Here's what that means: I'll detect your deploy infrastructure, test that my commands actually work, and show you exactly what will happen — step by step — before I touch anything. Deploys are irreversible once they hit production, so I want to earn your trust before I start merging.
|
|
|
|
Let me take a look at your setup."
|
|
|
|
### 1.5a: Deploy infrastructure detection
|
|
|
|
Run the deploy configuration bootstrap to detect the platform and settings:
|
|
|
|
{{DEPLOY_BOOTSTRAP}}
|
|
|
|
Parse the output and record: the detected platform, production URL, deploy workflow (if any),
|
|
and any persisted config from CLAUDE.md.
|
|
|
|
### 1.5b: Command validation
|
|
|
|
Test each detected command to verify the detection is accurate. Build a validation table:
|
|
|
|
```bash
|
|
# Test gh auth (already passed in Step 1, but confirm)
|
|
gh auth status 2>&1 | head -3
|
|
|
|
# Test platform CLI if detected
|
|
# Fly.io: fly status --app {app} 2>/dev/null
|
|
# Heroku: heroku releases --app {app} -n 1 2>/dev/null
|
|
# Vercel: vercel ls 2>/dev/null | head -3
|
|
|
|
# Test production URL reachability
|
|
# curl -sf {production-url} -o /dev/null -w "%{http_code}" 2>/dev/null
|
|
```
|
|
|
|
Run whichever commands are relevant based on the detected platform. Build the results into this table:
|
|
|
|
```
|
|
╔══════════════════════════════════════════════════════════╗
|
|
║ DEPLOY INFRASTRUCTURE VALIDATION ║
|
|
╠══════════════════════════════════════════════════════════╣
|
|
║ ║
|
|
║ Platform: {platform} (from {source}) ║
|
|
║ App: {app name or "N/A"} ║
|
|
║ Prod URL: {url or "not configured"} ║
|
|
║ ║
|
|
║ COMMAND VALIDATION ║
|
|
║ ├─ gh auth status: ✓ PASS ║
|
|
║ ├─ {platform CLI}: ✓ PASS / ⚠ NOT INSTALLED / ✗ FAIL ║
|
|
║ ├─ curl prod URL: ✓ PASS (200 OK) / ⚠ UNREACHABLE ║
|
|
║ └─ deploy workflow: {file or "none detected"} ║
|
|
║ ║
|
|
║ STAGING DETECTION ║
|
|
║ ├─ Staging URL: {url or "not configured"} ║
|
|
║ ├─ Staging workflow: {file or "not found"} ║
|
|
║ └─ Preview deploys: {detected or "not detected"} ║
|
|
║ ║
|
|
║ WHAT WILL HAPPEN ║
|
|
║ 1. Run pre-merge readiness checks (reviews, tests, docs) ║
|
|
║ 2. Wait for CI if pending ║
|
|
║ 3. Merge PR via {merge method} ║
|
|
║ 4. {Wait for deploy workflow / Wait 60s / Skip} ║
|
|
║ 5. {Run canary verification / Skip (no URL)} ║
|
|
║ ║
|
|
║ MERGE METHOD: {squash/merge/rebase} (from repo settings) ║
|
|
║ MERGE QUEUE: {detected / not detected} ║
|
|
╚══════════════════════════════════════════════════════════╝
|
|
```
|
|
|
|
**Validation failures are WARNINGs, not BLOCKERs** (except `gh auth status` which already
|
|
failed at Step 1). If `curl` fails, note "I couldn't reach that URL — might be a network
|
|
issue, VPN requirement, or incorrect address. I'll still be able to deploy, but I won't
|
|
be able to verify the site is healthy afterward."
|
|
If platform CLI is not installed, note "The {platform} CLI isn't installed on this machine.
|
|
I can still deploy through GitHub, but I'll use HTTP health checks instead of the platform
|
|
CLI to verify the deploy worked."
|
|
|
|
### 1.5c: Staging detection
|
|
|
|
Check for staging environments in this order:
|
|
|
|
1. **CLAUDE.md persisted config:** Check for a staging URL in the Deploy Configuration section:
|
|
```bash
|
|
grep -i "staging" CLAUDE.md 2>/dev/null | head -3
|
|
```
|
|
|
|
2. **GitHub Actions staging workflow:** Check for workflow files with "staging" in the name or content:
|
|
```bash
|
|
for f in $(find .github/workflows -maxdepth 1 \( -name '*.yml' -o -name '*.yaml' \) 2>/dev/null); do
|
|
[ -f "$f" ] && grep -qiE "staging" "$f" 2>/dev/null && echo "STAGING_WORKFLOW:$f"
|
|
done
|
|
```
|
|
|
|
3. **Vercel/Netlify preview deploys:** Check PR status checks for preview URLs:
|
|
```bash
|
|
gh pr checks --json name,targetUrl 2>/dev/null | head -20
|
|
```
|
|
Look for check names containing "vercel", "netlify", or "preview" and extract the target URL.
|
|
|
|
Record any staging targets found. These will be offered in Step 5.
|
|
|
|
### 1.5d: Readiness preview
|
|
|
|
Tell the user: "Before I merge any PR, I run a series of readiness checks — code reviews, tests, documentation, PR accuracy. Let me show you what that looks like for this project."
|
|
|
|
Preview the readiness checks that will run at Step 3.5 (without re-running tests):
|
|
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-read 2>/dev/null
|
|
```
|
|
|
|
Show a summary of review status: which reviews have been run, how stale they are.
|
|
Also check if CHANGELOG.md and VERSION have been updated.
|
|
|
|
Explain in plain English: "When I merge, I'll check: has the code been reviewed recently? Do the tests pass? Is the CHANGELOG updated? Is the PR description accurate? If anything looks off, I'll flag it before merging."
|
|
|
|
### 1.5e: Dry-run confirmation
|
|
|
|
Tell the user: "That's everything I detected. Take a look at the table above — does this match how your project actually deploys?"
|
|
|
|
Present the full dry-run results to the user via AskUserQuestion:
|
|
|
|
- **Re-ground:** "First deploy dry-run for [project] on branch [branch]. Above is what I detected about your deploy infrastructure. Nothing has been merged or deployed yet — this is just my understanding of your setup."
|
|
- Show the infrastructure validation table from 1.5b above.
|
|
- List any warnings from command validation, with plain-English explanations.
|
|
- If staging was detected, note: "I found a staging environment at {url/workflow}. After we merge, I'll offer to deploy there first so you can verify everything works before it hits production."
|
|
- If no staging was detected, note: "I didn't find a staging environment. The deploy will go straight to production — I'll run health checks right after to make sure everything looks good."
|
|
- **RECOMMENDATION:** Choose A if all validations passed. Choose B if there are issues to fix. Choose C to run /setup-deploy for a more thorough configuration.
|
|
- A) That's right — this is how my project deploys. Let's go. (Completeness: 10/10)
|
|
- B) Something's off — let me tell you what's wrong (Completeness: 10/10)
|
|
- C) I want to configure this more carefully first (runs /setup-deploy) (Completeness: 10/10)
|
|
|
|
**If A:** Tell the user: "Great — I've saved this configuration. Next time you run `/land-and-deploy`, I'll skip the dry run and go straight to readiness checks. If your deploy setup changes (new platform, different workflows, updated URLs), I'll automatically re-run the dry run to make sure I still have it right."
|
|
|
|
Save the deploy config fingerprint so we can detect future changes:
|
|
```bash
|
|
mkdir -p ~/.gstack/projects/$SLUG
|
|
CURRENT_HASH=$(sed -n '/## Deploy Configuration/,/^## /p' CLAUDE.md 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
WORKFLOW_HASH=$(find .github/workflows -maxdepth 1 \( -name '*deploy*' -o -name '*cd*' \) 2>/dev/null | xargs cat 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
echo "${CURRENT_HASH}-${WORKFLOW_HASH}" > ~/.gstack/projects/$SLUG/land-deploy-confirmed
|
|
```
|
|
Continue to Step 2.
|
|
|
|
**If B:** **STOP.** "Tell me what's different about your setup and I'll adjust. You can also run `/setup-deploy` to walk through the full configuration."
|
|
|
|
**If C:** **STOP.** "Running `/setup-deploy` will walk through your deploy platform, production URL, and health checks in detail. It saves everything to CLAUDE.md so I'll know exactly what to do next time. Run `/land-and-deploy` again when that's done."
|
|
|
|
---
|
|
|
|
## Step 2: Pre-merge checks
|
|
|
|
Tell the user: "Checking CI status and merge readiness..."
|
|
|
|
Check CI status and merge readiness:
|
|
|
|
```bash
|
|
gh pr checks --json name,state,status,conclusion
|
|
```
|
|
|
|
Parse the output:
|
|
1. If any required checks are **FAILING**: **STOP.** "CI is failing on this PR. Here are the failing checks: {list}. Fix these before deploying — I won't merge code that hasn't passed CI."
|
|
2. If required checks are **PENDING**: Tell the user "CI is still running. I'll wait for it to finish." Proceed to Step 3.
|
|
3. If all checks pass (or no required checks): Tell the user "CI passed." Skip Step 3, go to Step 4.
|
|
|
|
Also check for merge conflicts:
|
|
```bash
|
|
gh pr view --json mergeable -q .mergeable
|
|
```
|
|
If `CONFLICTING`: **STOP.** "This PR has merge conflicts with the base branch. Resolve the conflicts and push, then run `/land-and-deploy` again."
|
|
|
|
---
|
|
|
|
## Step 3: Wait for CI (if pending)
|
|
|
|
If required checks are still pending, wait for them to complete. Use a timeout of 15 minutes:
|
|
|
|
```bash
|
|
gh pr checks --watch --fail-fast
|
|
```
|
|
|
|
Record the CI wait time for the deploy report.
|
|
|
|
If CI passes within the timeout: Tell the user "CI passed after {duration}. Moving to readiness checks." Continue to Step 4.
|
|
If CI fails: **STOP.** "CI failed. Here's what broke: {failures}. This needs to pass before I can merge."
|
|
If timeout (15 min): **STOP.** "CI has been running for over 15 minutes — that's unusual. Check the GitHub Actions tab to see if something is stuck."
|
|
|
|
---
|
|
|
|
## Step 3.4: VERSION drift detection (workspace-aware ship)
|
|
|
|
Before gathering readiness evidence, verify that the VERSION this PR claims is still the next free slot. A sibling workspace may have shipped and landed since `/ship` ran, leaving this PR's VERSION stale.
|
|
|
|
```bash
|
|
BRANCH_VERSION=$(git show HEAD:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
|
|
BASE_BRANCH=$(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)
|
|
BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
|
|
|
|
# Imply bump level by comparing branch VERSION to base (crude but good enough for drift detection)
|
|
# We don't need the exact original level — we just need "a level" that passes to the util.
|
|
# If the minor digit advanced, call it minor; patch digit, patch; etc. If base > branch, skip (not ours to land).
|
|
# For simplicity: use "patch" as a conservative default; util handles collision-past regardless of input level.
|
|
QUEUE_JSON=$(bun run bin/gstack-next-version \
|
|
--base "$BASE_BRANCH" \
|
|
--bump patch \
|
|
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')
|
|
NEXT_SLOT=$(echo "$QUEUE_JSON" | jq -r '.version // empty')
|
|
OFFLINE=$(echo "$QUEUE_JSON" | jq -r '.offline // false')
|
|
```
|
|
|
|
Behavior:
|
|
|
|
1. If `OFFLINE=true` or the util fails: print `⚠ VERSION drift check unavailable (util offline) — proceeding with PR version v<BRANCH_VERSION>`. Continue to Step 3.5. CI's version-gate job is the backstop.
|
|
|
|
2. If `BRANCH_VERSION` is already `>=` than `NEXT_SLOT`: no drift (or our PR is ahead of the queue). Continue.
|
|
|
|
3. If drift is detected (a PR landed ahead of us and `BRANCH_VERSION < NEXT_SLOT`): **STOP** and print exactly:
|
|
```
|
|
⚠ VERSION drift detected.
|
|
This PR claims: v<BRANCH_VERSION>
|
|
Next free slot: v<NEXT_SLOT> (queue moved since last /ship)
|
|
|
|
Rerun /ship from the feature branch to reconcile. /ship's ALREADY_BUMPED
|
|
branch will detect the drift and rewrite VERSION + CHANGELOG header + PR title
|
|
atomically. Do NOT merge from here — the landed PR would overwrite the other
|
|
branch's CHANGELOG entry or land with a duplicate version header.
|
|
```
|
|
|
|
Exit non-zero. Do NOT auto-bump from `/land-and-deploy` — rerunning `/ship` is the clean path (it already handles VERSION + package.json + CHANGELOG header + PR title atomically via Step 12 ALREADY_BUMPED detection).
|
|
|
|
---
|
|
|
|
## Step 3.5: Pre-merge readiness gate
|
|
|
|
**This is the critical safety check before an irreversible merge.** The merge cannot
|
|
be undone without a revert commit. Gather ALL evidence, build a readiness report,
|
|
and get explicit user confirmation before proceeding.
|
|
|
|
Tell the user: "CI is green. Now I'm running readiness checks — this is the last gate before I merge. I'm checking code reviews, test results, documentation, and PR accuracy. Once you see the readiness report and approve, the merge is final."
|
|
|
|
Collect evidence for each check below. Track warnings (yellow) and blockers (red).
|
|
|
|
### 3.5a: Review staleness check
|
|
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-read 2>/dev/null
|
|
```
|
|
|
|
Parse the output. For each review skill (plan-eng-review, plan-ceo-review,
|
|
plan-design-review, design-review-lite, codex-review, review, adversarial-review,
|
|
codex-plan-review):
|
|
|
|
1. Find the most recent entry within the last 7 days.
|
|
2. Extract its `commit` field.
|
|
3. Compare against current HEAD: `git rev-list --count STORED_COMMIT..HEAD`
|
|
|
|
**Staleness rules:**
|
|
- 0 commits since review → CURRENT
|
|
- 1-3 commits since review → RECENT (yellow if those commits touch code, not just docs)
|
|
- 4+ commits since review → STALE (red — review may not reflect current code)
|
|
- No review found → NOT RUN
|
|
|
|
**Critical check:** Look at what changed AFTER the last review. Run:
|
|
```bash
|
|
git log --oneline STORED_COMMIT..HEAD
|
|
```
|
|
If any commits after the review contain words like "fix", "refactor", "rewrite",
|
|
"overhaul", or touch more than 5 files — flag as **STALE (significant changes
|
|
since review)**. The review was done on different code than what's about to merge.
|
|
|
|
**Also check for adversarial review (`codex-review`).** If codex-review has been run
|
|
and is CURRENT, mention it in the readiness report as an extra confidence signal.
|
|
If not run, note as informational (not a blocker): "No adversarial review on record."
|
|
|
|
### 3.5a-bis: Inline review offer
|
|
|
|
**We are extra careful about deploys.** If engineering review is STALE (4+ commits since)
|
|
or NOT RUN, offer to run a quick review inline before proceeding.
|
|
|
|
Use AskUserQuestion:
|
|
- **Re-ground:** "I noticed {the code review is stale / no code review has been run} on this branch. Since this code is about to go to production, I'd like to do a quick safety check on the diff before we merge. This is one of the ways I make sure nothing ships that shouldn't."
|
|
- **RECOMMENDATION:** Choose A for a quick safety check. Choose B if you want the full
|
|
review experience. Choose C only if you're confident in the code.
|
|
- A) Run a quick review (~2 min) — I'll scan the diff for common issues like SQL safety, race conditions, and security gaps (Completeness: 7/10)
|
|
- B) Stop and run a full `/review` first — deeper analysis, more thorough (Completeness: 10/10)
|
|
- C) Skip the review — I've reviewed this code myself and I'm confident (Completeness: 3/10)
|
|
|
|
**If A (quick checklist):** Tell the user: "Running the review checklist against your diff now..."
|
|
|
|
Read the review checklist:
|
|
```bash
|
|
cat ~/.claude/skills/gstack/review/checklist.md 2>/dev/null || echo "Checklist not found"
|
|
```
|
|
Apply each checklist item to the current diff. This is the same quick review that `/ship`
|
|
runs in its Step 3.5. Auto-fix trivial issues (whitespace, imports). For critical findings
|
|
(SQL safety, race conditions, security), ask the user.
|
|
|
|
**If any code changes are made during the quick review:** Commit the fixes, then **STOP**
|
|
and tell the user: "I found and fixed a few issues during the review. The fixes are committed — run `/land-and-deploy` again to pick them up and continue where we left off."
|
|
|
|
**If no issues found:** Tell the user: "Review checklist passed — no issues found in the diff."
|
|
|
|
**If B:** **STOP.** "Good call — run `/review` for a thorough pre-landing review. When that's done, run `/land-and-deploy` again and I'll pick up right where we left off."
|
|
|
|
**If C:** Tell the user: "Understood — skipping review. You know this code best." Continue. Log the user's choice to skip review.
|
|
|
|
**If review is CURRENT:** Skip this sub-step entirely — no question asked.
|
|
|
|
### 3.5b: Test results
|
|
|
|
**Free tests — run them now:**
|
|
|
|
Read CLAUDE.md to find the project's test command. If not specified, use `bun test`.
|
|
Run the test command and capture the exit code and output.
|
|
|
|
```bash
|
|
bun test 2>&1 | tail -10
|
|
```
|
|
|
|
If tests fail: **BLOCKER.** Cannot merge with failing tests.
|
|
|
|
**E2E tests — check recent results:**
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
ls -t ~/.gstack-dev/evals/*-e2e-*-$(date +%Y-%m-%d)*.json 2>/dev/null | head -20
|
|
```
|
|
|
|
For each eval file from today, parse pass/fail counts. Show:
|
|
- Total tests, pass count, fail count
|
|
- How long ago the run finished (from file timestamp)
|
|
- Total cost
|
|
- Names of any failing tests
|
|
|
|
If no E2E results from today: **WARNING — no E2E tests run today.**
|
|
If E2E results exist but have failures: **WARNING — N tests failed.** List them.
|
|
|
|
**LLM judge evals — check recent results:**
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
ls -t ~/.gstack-dev/evals/*-llm-judge-*-$(date +%Y-%m-%d)*.json 2>/dev/null | head -5
|
|
```
|
|
|
|
If found, parse and show pass/fail. If not found, note "No LLM evals run today."
|
|
|
|
### 3.5c: PR body accuracy check
|
|
|
|
Read the current PR body:
|
|
```bash
|
|
gh pr view --json body -q .body
|
|
```
|
|
|
|
Read the current diff summary:
|
|
```bash
|
|
git log --oneline $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)..HEAD | head -20
|
|
```
|
|
|
|
Compare the PR body against the actual commits. Check for:
|
|
1. **Missing features** — commits that add significant functionality not mentioned in the PR
|
|
2. **Stale descriptions** — PR body mentions things that were later changed or reverted
|
|
3. **Wrong version** — PR title or body references a version that doesn't match VERSION file
|
|
|
|
If the PR body looks stale or incomplete: **WARNING — PR body may not reflect current
|
|
changes.** List what's missing or stale.
|
|
|
|
### 3.5d: Document-release check
|
|
|
|
Check if documentation was updated on this branch:
|
|
|
|
```bash
|
|
git log --oneline --all-match --grep="docs:" $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)..HEAD | head -5
|
|
```
|
|
|
|
Also check if key doc files were modified:
|
|
```bash
|
|
git diff --name-only $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)...HEAD -- README.md CHANGELOG.md ARCHITECTURE.md CONTRIBUTING.md CLAUDE.md VERSION
|
|
```
|
|
|
|
If CHANGELOG.md and VERSION were NOT modified on this branch and the diff includes
|
|
new features (new files, new commands, new skills): **WARNING — /document-release
|
|
likely not run. CHANGELOG and VERSION not updated despite new features.**
|
|
|
|
If only docs changed (no code): skip this check.
|
|
|
|
### 3.5e: Readiness report and confirmation
|
|
|
|
Tell the user: "Here's the full readiness report. This is everything I checked before merging."
|
|
|
|
Build the full readiness report:
|
|
|
|
```
|
|
╔══════════════════════════════════════════════════════════╗
|
|
║ PRE-MERGE READINESS REPORT ║
|
|
╠══════════════════════════════════════════════════════════╣
|
|
║ ║
|
|
║ PR: #NNN — title ║
|
|
║ Branch: feature → main ║
|
|
║ ║
|
|
║ REVIEWS ║
|
|
║ ├─ Eng Review: CURRENT / STALE (N commits) / — ║
|
|
║ ├─ CEO Review: CURRENT / — (optional) ║
|
|
║ ├─ Design Review: CURRENT / — (optional) ║
|
|
║ └─ Codex Review: CURRENT / — (optional) ║
|
|
║ ║
|
|
║ TESTS ║
|
|
║ ├─ Free tests: PASS / FAIL (blocker) ║
|
|
║ ├─ E2E tests: 52/52 pass (25 min ago) / NOT RUN ║
|
|
║ └─ LLM evals: PASS / NOT RUN ║
|
|
║ ║
|
|
║ DOCUMENTATION ║
|
|
║ ├─ CHANGELOG: Updated / NOT UPDATED (warning) ║
|
|
║ ├─ VERSION: 0.9.8.0 / NOT BUMPED (warning) ║
|
|
║ └─ Doc release: Run / NOT RUN (warning) ║
|
|
║ ║
|
|
║ PR BODY ║
|
|
║ └─ Accuracy: Current / STALE (warning) ║
|
|
║ ║
|
|
║ WARNINGS: N | BLOCKERS: N ║
|
|
╚══════════════════════════════════════════════════════════╝
|
|
```
|
|
|
|
If there are BLOCKERS (failing free tests): list them and recommend B.
|
|
If there are WARNINGS but no blockers: list each warning and recommend A if
|
|
warnings are minor, or B if warnings are significant.
|
|
If everything is green: recommend A.
|
|
|
|
Use AskUserQuestion:
|
|
|
|
- **Re-ground:** "Ready to merge PR #NNN — '{title}' into {base}. Here's what I found."
|
|
Show the report above.
|
|
- If everything is green: "All checks passed. This PR is ready to merge."
|
|
- If there are warnings: List each one in plain English. E.g., "The engineering review
|
|
was done 6 commits ago — the code has changed since then" not "STALE (6 commits)."
|
|
- If there are blockers: "I found issues that need to be fixed before merging: {list}"
|
|
- **RECOMMENDATION:** Choose A if green. Choose B if there are significant warnings.
|
|
Choose C only if the user understands the risks.
|
|
- A) Merge it — everything looks good (Completeness: 10/10)
|
|
- B) Hold off — I want to fix the warnings first (Completeness: 10/10)
|
|
- C) Merge anyway — I understand the warnings and want to proceed (Completeness: 3/10)
|
|
|
|
If the user chooses B: **STOP.** Give specific next steps:
|
|
- If reviews are stale: "Run `/review` or `/autoplan` to review the current code, then `/land-and-deploy` again."
|
|
- If E2E not run: "Run your E2E tests to make sure nothing is broken, then come back."
|
|
- If docs not updated: "Run `/document-release` to update CHANGELOG and docs."
|
|
- If PR body stale: "The PR description doesn't match what's actually in the diff — update it on GitHub."
|
|
|
|
If the user chooses A or C: Tell the user "Merging now." Continue to Step 4.
|
|
|
|
---
|
|
|
|
## Step 4: Merge the PR
|
|
|
|
Record the start timestamp for timing data. Also record which merge path is taken
|
|
(auto-merge vs direct) for the deploy report.
|
|
|
|
Try auto-merge first (respects repo merge settings and merge queues):
|
|
|
|
```bash
|
|
gh pr merge --auto --delete-branch
|
|
```
|
|
|
|
If `--auto` succeeds: record `MERGE_PATH=auto`. This means the repo has auto-merge enabled
|
|
and may use merge queues.
|
|
|
|
If `--auto` is not available (repo doesn't have auto-merge enabled), merge directly:
|
|
|
|
```bash
|
|
gh pr merge --squash --delete-branch
|
|
```
|
|
|
|
If direct merge succeeds: record `MERGE_PATH=direct`. Tell the user: "PR merged successfully. The branch has been cleaned up."
|
|
|
|
If the merge fails with a permission error: **STOP.** "I don't have permission to merge this PR. You'll need a maintainer to merge it, or check your repo's branch protection rules."
|
|
|
|
### 4a-postfail: Post-failure PR-state check
|
|
|
|
**Universal invariant:** after ANY non-zero exit from `gh pr merge`, query authoritative PR state before retrying or stopping. Do NOT retry `gh pr merge`. Related: cli/cli#3442, cli/cli#13380.
|
|
|
|
```bash
|
|
gh pr view --json state,mergeCommit,mergedAt,mergedBy
|
|
```
|
|
|
|
**If `state == "MERGED"`:**
|
|
|
|
The server-side merge succeeded (possibly completed before the local cleanup phase failed, or a concurrent merge landed). Tell the user: "PR is merged on GitHub." (Do NOT say "the merge succeeded" — this handles the concurrent-merge case.)
|
|
|
|
Capture merge SHA:
|
|
```bash
|
|
gh pr view --json mergeCommit -q .mergeCommit.oid
|
|
```
|
|
|
|
Worktree cleanup — non-destructive, candidate-based:
|
|
```bash
|
|
git worktree list --porcelain
|
|
```
|
|
Identify candidates: a worktree is stale if (a) it is checked out on the base branch, AND (b) it is not the user's current main working tree, AND (c) `git status --porcelain` inside it is empty (no uncommitted work).
|
|
|
|
- For each clean candidate: OFFER to remove it. Say: "There's a stale worktree at `<path>` checked out on `<branch>` with no uncommitted work. Remove it?" Remove only if user confirms (`git worktree remove <path> && git worktree prune`).
|
|
- If any candidate has uncommitted work: list the files, tell the user, and STOP worktree cleanup without removing anything.
|
|
- Do NOT use `--force`. Do NOT remove the user's primary working tree.
|
|
|
|
Record `MERGE_PATH=direct`, then continue to §4a (CI auto-deploy detection).
|
|
|
|
**If `state == "OPEN"`:**
|
|
|
|
Check whether auto-merge is enabled:
|
|
```bash
|
|
gh pr view --json autoMergeRequest -q .autoMergeRequest
|
|
```
|
|
|
|
- If non-null: auto-merge is enabled or merge queue is in use. The open state is expected — proceed to §4a's merge-queue wait path.
|
|
- If null: genuine failure. Surface both errors — the `gh pr merge` stderr AND the current PR open state — then **STOP**.
|
|
|
|
**If `state == "CLOSED"`:** PR was closed without merging. **STOP.**
|
|
|
|
**Hard rule: never call `gh pr merge` a second time** after a non-zero exit. Server state is authoritative.
|
|
|
|
### 4a: Merge queue detection and messaging
|
|
|
|
If `MERGE_PATH=auto` and the PR state does not immediately become `MERGED`, the PR is
|
|
in a **merge queue**. Tell the user:
|
|
|
|
"Your repo uses a merge queue — that means GitHub will run CI one more time on the final merge commit before it actually merges. This is a good thing (it catches last-minute conflicts), but it means we wait. I'll keep checking until it goes through."
|
|
|
|
Poll for the PR to actually merge:
|
|
|
|
```bash
|
|
gh pr view --json state -q .state
|
|
```
|
|
|
|
Poll every 30 seconds, up to 30 minutes. Show a progress message every 2 minutes:
|
|
"Still in the merge queue... ({X}m so far)"
|
|
|
|
If the PR state changes to `MERGED`: capture the merge commit SHA. Tell the user:
|
|
"Merge queue finished — PR is merged. Took {duration}."
|
|
|
|
If the PR is removed from the queue (state goes back to `OPEN`): **STOP.** "The PR was removed from the merge queue — this usually means a CI check failed on the merge commit, or another PR in the queue caused a conflict. Check the GitHub merge queue page to see what happened."
|
|
If timeout (30 min): **STOP.** "The merge queue has been processing for 30 minutes. Something might be stuck — check the GitHub Actions tab and the merge queue page."
|
|
|
|
### 4b: CI auto-deploy detection
|
|
|
|
After the PR is merged, check if a deploy workflow was triggered by the merge:
|
|
|
|
```bash
|
|
gh run list --branch <base> --limit 5 --json name,status,workflowName,headSha
|
|
```
|
|
|
|
Look for runs matching the merge commit SHA. If a deploy workflow is found:
|
|
- Tell the user: "PR merged. I can see a deploy workflow ('{workflow-name}') kicked off automatically. I'll monitor it and let you know when it's done."
|
|
|
|
If no deploy workflow is found after merge:
|
|
- Tell the user: "PR merged. I don't see a deploy workflow — your project might deploy a different way, or it might be a library/CLI that doesn't have a deploy step. I'll figure out the right verification in the next step."
|
|
|
|
If `MERGE_PATH=auto` and the repo uses merge queues AND a deploy workflow exists:
|
|
- Tell the user: "PR made it through the merge queue and the deploy workflow is running. Monitoring it now."
|
|
|
|
Record merge timestamp, duration, and merge path for the deploy report.
|
|
|
|
---
|
|
|
|
## Step 5: Deploy strategy detection
|
|
|
|
Determine what kind of project this is and how to verify the deploy.
|
|
|
|
First, run the deploy configuration bootstrap to detect or read persisted deploy settings:
|
|
|
|
{{DEPLOY_BOOTSTRAP}}
|
|
|
|
Then run `gstack-diff-scope` to classify the changes:
|
|
|
|
```bash
|
|
eval $(~/.claude/skills/gstack/bin/gstack-diff-scope $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main) 2>/dev/null)
|
|
echo "FRONTEND=$SCOPE_FRONTEND BACKEND=$SCOPE_BACKEND DOCS=$SCOPE_DOCS CONFIG=$SCOPE_CONFIG"
|
|
```
|
|
|
|
**Decision tree (evaluate in order):**
|
|
|
|
1. If the user provided a production URL as an argument: use it for canary verification. Also check for deploy workflows.
|
|
|
|
2. Check for GitHub Actions deploy workflows:
|
|
```bash
|
|
gh run list --branch <base> --limit 5 --json name,status,conclusion,headSha,workflowName
|
|
```
|
|
Look for workflow names containing "deploy", "release", "production", or "cd". If found: poll the deploy workflow in Step 6, then run canary.
|
|
|
|
3. If SCOPE_DOCS is the only scope that's true (no frontend, no backend, no config): skip verification entirely. Tell the user: "This was a docs-only change — nothing to deploy or verify. You're all set." Go to Step 9.
|
|
|
|
4. If no deploy workflows detected and no URL provided: use AskUserQuestion once:
|
|
- **Re-ground:** "PR is merged, but I don't see a deploy workflow or a production URL for this project. If this is a web app, I can verify the deploy if you give me the URL. If it's a library or CLI tool, there's nothing to verify — we're done."
|
|
- **RECOMMENDATION:** Choose B if this is a library/CLI tool. Choose A if this is a web app.
|
|
- A) Here's the production URL: {let them type it}
|
|
- B) No deploy needed — this isn't a web app
|
|
|
|
### 5a: Staging-first option
|
|
|
|
If staging was detected in Step 1.5c (or from CLAUDE.md deploy config), and the changes
|
|
include code (not docs-only), offer the staging-first option:
|
|
|
|
Use AskUserQuestion:
|
|
- **Re-ground:** "I found a staging environment at {staging URL or workflow}. Since this deploy includes code changes, I can verify everything works on staging first — before it hits production. This is the safest path: if something breaks on staging, production is untouched."
|
|
- **RECOMMENDATION:** Choose A for maximum safety. Choose B if you're confident.
|
|
- A) Deploy to staging first, verify it works, then go to production (Completeness: 10/10)
|
|
- B) Skip staging — go straight to production (Completeness: 7/10)
|
|
- C) Deploy to staging only — I'll check production later (Completeness: 8/10)
|
|
|
|
**If A (staging first):** Tell the user: "Deploying to staging first. I'll run the same health checks I'd run on production — if staging looks good, I'll move on to production automatically."
|
|
|
|
Run Steps 6-7 against the staging target first. Use the staging
|
|
URL or staging workflow for deploy verification and canary checks. After staging passes,
|
|
tell the user: "Staging is healthy — your changes are working. Now deploying to production." Then run
|
|
Steps 6-7 again against the production target.
|
|
|
|
**If B (skip staging):** Tell the user: "Skipping staging — going straight to production." Proceed with production deployment as normal.
|
|
|
|
**If C (staging only):** Tell the user: "Deploying to staging only. I'll verify it works and stop there."
|
|
|
|
Run Steps 6-7 against the staging target. After verification,
|
|
print the deploy report (Step 9) with verdict "STAGING VERIFIED — production deploy pending."
|
|
Then tell the user: "Staging looks good. When you're ready for production, run `/land-and-deploy` again."
|
|
**STOP.** The user can re-run `/land-and-deploy` later for production.
|
|
|
|
**If no staging detected:** Skip this sub-step entirely. No question asked.
|
|
|
|
---
|
|
|
|
## Step 6: Wait for deploy (if applicable)
|
|
|
|
The deploy verification strategy depends on the platform detected in Step 5.
|
|
|
|
### Strategy A: GitHub Actions workflow
|
|
|
|
If a deploy workflow was detected, find the run triggered by the merge commit:
|
|
|
|
```bash
|
|
gh run list --branch <base> --limit 10 --json databaseId,headSha,status,conclusion,name,workflowName
|
|
```
|
|
|
|
Match by the merge commit SHA (captured in Step 4). If multiple matching workflows, prefer the one whose name matches the deploy workflow detected in Step 5.
|
|
|
|
Poll every 30 seconds:
|
|
```bash
|
|
gh run view <run-id> --json status,conclusion
|
|
```
|
|
|
|
### Strategy B: Platform CLI (Fly.io, Render, Heroku)
|
|
|
|
If a deploy status command was configured in CLAUDE.md (e.g., `fly status --app myapp`), use it instead of or in addition to GitHub Actions polling.
|
|
|
|
**Fly.io:** After merge, Fly deploys via GitHub Actions or `fly deploy`. Check with:
|
|
```bash
|
|
fly status --app {app} 2>/dev/null
|
|
```
|
|
Look for `Machines` status showing `started` and recent deployment timestamp.
|
|
|
|
**Render:** Render auto-deploys on push to the connected branch. Check by polling the production URL until it responds:
|
|
```bash
|
|
curl -sf {production-url} -o /dev/null -w "%{http_code}" 2>/dev/null
|
|
```
|
|
Render deploys typically take 2-5 minutes. Poll every 30 seconds.
|
|
|
|
**Heroku:** Check latest release:
|
|
```bash
|
|
heroku releases --app {app} -n 1 2>/dev/null
|
|
```
|
|
|
|
### Strategy C: Auto-deploy platforms (Vercel, Netlify)
|
|
|
|
Vercel and Netlify deploy automatically on merge. No explicit deploy trigger needed. Wait 60 seconds for the deploy to propagate, then proceed directly to canary verification in Step 7.
|
|
|
|
### Strategy D: Custom deploy hooks
|
|
|
|
If CLAUDE.md has a custom deploy status command in the "Custom deploy hooks" section, run that command and check its exit code.
|
|
|
|
### Common: Timing and failure handling
|
|
|
|
Record deploy start time. Show progress every 2 minutes: "Deploy is still running... ({X}m so far). This is normal for most platforms."
|
|
|
|
If deploy succeeds (`conclusion` is `success` or health check passes): Tell the user "Deploy finished successfully. Took {duration}. Now I'll verify the site is healthy." Record deploy duration, continue to Step 7.
|
|
|
|
If deploy fails (`conclusion` is `failure`): use AskUserQuestion:
|
|
- **Re-ground:** "The deploy workflow failed after the merge. The code is merged but may not be live yet. Here's what I can do:"
|
|
- **RECOMMENDATION:** Choose A to investigate before reverting.
|
|
- A) Let me look at the deploy logs to figure out what went wrong
|
|
- B) Revert the merge immediately — roll back to the previous version
|
|
- C) Continue to health checks anyway — the deploy failure might be a flaky step, and the site might actually be fine
|
|
|
|
If timeout (20 min): "The deploy has been running for 20 minutes, which is longer than most deploys take. The site might still be deploying, or something might be stuck." Ask whether to continue waiting or skip verification.
|
|
|
|
---
|
|
|
|
## Step 7: Canary verification (conditional depth)
|
|
|
|
Tell the user: "Deploy is done. Now I'm going to check the live site to make sure everything looks good — loading the page, checking for errors, and measuring performance."
|
|
|
|
Use the diff-scope classification from Step 5 to determine canary depth:
|
|
|
|
| Diff Scope | Canary Depth |
|
|
|------------|-------------|
|
|
| SCOPE_DOCS only | Already skipped in Step 5 |
|
|
| SCOPE_CONFIG only | Smoke: `$B goto` + verify 200 status |
|
|
| SCOPE_BACKEND only | Console errors + perf check |
|
|
| SCOPE_FRONTEND (any) | Full: console + perf + screenshot |
|
|
| Mixed scopes | Full canary |
|
|
|
|
**Full canary sequence:**
|
|
|
|
```bash
|
|
$B goto <url>
|
|
```
|
|
|
|
Check that the page loaded successfully (200, not an error page).
|
|
|
|
```bash
|
|
$B console --errors
|
|
```
|
|
|
|
Check for critical console errors: lines containing `Error`, `Uncaught`, `Failed to load`, `TypeError`, `ReferenceError`. Ignore warnings.
|
|
|
|
```bash
|
|
$B perf
|
|
```
|
|
|
|
Check that page load time is under 10 seconds.
|
|
|
|
```bash
|
|
$B text
|
|
```
|
|
|
|
Verify the page has content (not blank, not a generic error page).
|
|
|
|
```bash
|
|
$B snapshot -i -a -o ".gstack/deploy-reports/post-deploy.png"
|
|
```
|
|
|
|
Take an annotated screenshot as evidence.
|
|
|
|
**Health assessment:**
|
|
- Page loads successfully with 200 status → PASS
|
|
- No critical console errors → PASS
|
|
- Page has real content (not blank or error screen) → PASS
|
|
- Loads in under 10 seconds → PASS
|
|
|
|
If all pass: Tell the user "Site is healthy. Page loaded in {X}s, no console errors, content looks good. Screenshot saved to {path}." Mark as HEALTHY, continue to Step 9.
|
|
|
|
If any fail: show the evidence (screenshot path, console errors, perf numbers). Use AskUserQuestion:
|
|
- **Re-ground:** "I found some issues on the live site after the deploy. Here's what I see: {specific issues}. This might be temporary (caches clearing, CDN propagating) or it might be a real problem."
|
|
- **RECOMMENDATION:** Choose based on severity — B for critical (site down), A for minor (console errors).
|
|
- A) That's expected — the site is still warming up. Mark it as healthy.
|
|
- B) That's broken — revert the merge and roll back to the previous version
|
|
- C) Let me investigate more — open the site and look at logs before deciding
|
|
|
|
---
|
|
|
|
## Step 8: Revert (if needed)
|
|
|
|
If the user chose to revert at any point:
|
|
|
|
Tell the user: "Reverting the merge now. This will create a new commit that undoes all the changes from this PR. The previous version of your site will be restored once the revert deploys."
|
|
|
|
```bash
|
|
git fetch origin <base>
|
|
git checkout <base>
|
|
git revert <merge-commit-sha> --no-edit
|
|
git push origin <base>
|
|
```
|
|
|
|
If the revert has conflicts: "The revert has merge conflicts — this can happen if other changes landed on {base} after your merge. You'll need to resolve the conflicts manually. The merge commit SHA is `<sha>` — run `git revert <sha>` to try again."
|
|
|
|
If the base branch has push protections: "This repo has branch protections, so I can't push the revert directly. I'll create a revert PR instead — merge it to roll back."
|
|
Then create a revert PR: `gh pr create --title 'revert: <original PR title>'`
|
|
|
|
After a successful revert: Tell the user "Revert pushed to {base}. The deploy should roll back automatically once CI passes. Keep an eye on the site to confirm." Note the revert commit SHA and continue to Step 9 with status REVERTED.
|
|
|
|
---
|
|
|
|
## Step 9: Deploy report
|
|
|
|
Create the deploy report directory:
|
|
|
|
```bash
|
|
mkdir -p .gstack/deploy-reports
|
|
```
|
|
|
|
Produce and display the ASCII summary:
|
|
|
|
```
|
|
LAND & DEPLOY REPORT
|
|
═════════════════════
|
|
PR: #<number> — <title>
|
|
Branch: <head-branch> → <base-branch>
|
|
Merged: <timestamp> (<merge method>)
|
|
Merge SHA: <sha>
|
|
Merge path: <auto-merge / direct / merge queue>
|
|
First run: <yes (dry-run validated) / no (previously confirmed)>
|
|
|
|
Timing:
|
|
Dry-run: <duration or "skipped (confirmed)">
|
|
CI wait: <duration>
|
|
Queue: <duration or "direct merge">
|
|
Deploy: <duration or "no workflow detected">
|
|
Staging: <duration or "skipped">
|
|
Canary: <duration or "skipped">
|
|
Total: <end-to-end duration>
|
|
|
|
Reviews:
|
|
Eng review: <CURRENT / STALE / NOT RUN>
|
|
Inline fix: <yes (N fixes) / no / skipped>
|
|
|
|
CI: <PASSED / SKIPPED>
|
|
Deploy: <PASSED / FAILED / NO WORKFLOW / CI AUTO-DEPLOY>
|
|
Staging: <VERIFIED / SKIPPED / N/A>
|
|
Verification: <HEALTHY / DEGRADED / SKIPPED / REVERTED>
|
|
Scope: <FRONTEND / BACKEND / CONFIG / DOCS / MIXED>
|
|
Console: <N errors or "clean">
|
|
Load time: <Xs>
|
|
Screenshot: <path or "none">
|
|
|
|
VERDICT: <DEPLOYED AND VERIFIED / DEPLOYED (UNVERIFIED) / STAGING VERIFIED / REVERTED>
|
|
```
|
|
|
|
Save report to `.gstack/deploy-reports/{date}-pr{number}-deploy.md`.
|
|
|
|
Log to the review dashboard:
|
|
|
|
```bash
|
|
{{SLUG_EVAL}}
|
|
mkdir -p ~/.gstack/projects/$SLUG
|
|
```
|
|
|
|
Write a JSONL entry with timing data:
|
|
```json
|
|
{"skill":"land-and-deploy","timestamp":"<ISO>","status":"<SUCCESS/REVERTED>","pr":<number>,"merge_sha":"<sha>","merge_path":"<auto/direct/queue>","first_run":<true/false>,"deploy_status":"<HEALTHY/DEGRADED/SKIPPED>","staging_status":"<VERIFIED/SKIPPED>","review_status":"<CURRENT/STALE/NOT_RUN/INLINE_FIX>","ci_wait_s":<N>,"queue_s":<N>,"deploy_s":<N>,"staging_s":<N>,"canary_s":<N>,"total_s":<N>}
|
|
```
|
|
|
|
---
|
|
|
|
## Step 10: Suggest follow-ups
|
|
|
|
After the deploy report:
|
|
|
|
If verdict is DEPLOYED AND VERIFIED: Tell the user "Your changes are live and verified. Nice ship."
|
|
|
|
If verdict is DEPLOYED (UNVERIFIED): Tell the user "Your changes are merged and should be deploying. I wasn't able to verify the site — check it manually when you get a chance."
|
|
|
|
If verdict is REVERTED: Tell the user "The merge was reverted. Your changes are no longer on {base}. The PR branch is still available if you need to fix and re-ship."
|
|
|
|
Then suggest relevant follow-ups:
|
|
- If a production URL was verified: "Want extended monitoring? Run `/canary <url>` to watch the site for the next 10 minutes."
|
|
- If performance data was collected: "Want a deeper performance analysis? Run `/benchmark <url>`."
|
|
- "Need to update docs? Run `/document-release` to sync README, CHANGELOG, and other docs with what you just shipped."
|
|
|
|
---
|
|
|
|
## Important Rules
|
|
|
|
- **Never force push.** Use `gh pr merge` which is safe.
|
|
- **Never skip CI.** If checks are failing, stop and explain why.
|
|
- **Narrate the journey.** The user should always know: what just happened, what's happening now, and what's about to happen next. No silent gaps between steps.
|
|
- **Auto-detect everything.** PR number, merge method, deploy strategy, project type, merge queues, staging environments. Only ask when information genuinely can't be inferred.
|
|
- **Poll with backoff.** Don't hammer GitHub API. 30-second intervals for CI/deploy, with reasonable timeouts.
|
|
- **Revert is always an option.** At every failure point, offer revert as an escape hatch. Explain what reverting does in plain English.
|
|
- **Single-pass verification, not continuous monitoring.** `/land-and-deploy` checks once. `/canary` does the extended monitoring loop.
|
|
- **Clean up.** Delete the feature branch after merge (via `--delete-branch`).
|
|
- **First run = teacher mode.** Walk the user through everything. Explain what each check does and why it matters. Show them their infrastructure. Let them confirm before proceeding. Build trust through transparency.
|
|
- **Subsequent runs = efficient mode.** Brief status updates, no re-explanations. The user already trusts the tool — just do the job and report results.
|
|
- **The goal is: first-timers think "wow, this is thorough — I trust it." Repeat users think "that was fast — it just works."**
|