mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 14:34:42 +01:00
Garry Tanandcapy-ai[bot]
b3b08d0108
* fix(flaky): 2026-10-30 flaky pass — two paid detector gaps, a guard-PTY dispatch delta, five free races, the QA deadline receipt ack and a Chromium WSAENOBUFS backport (GSTA-178) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore(changelog): move the GSTA-178 entry to changelog.d/capy-gsta178-flaky.md (fragments, #3654) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(playwright-patch): read the 1.62.1 backport patch by literal path so pregate maps the patch to its test Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (no-ack worker test, passive-pitch negation, shared descendant cleanup) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore(changelog): note the review fixes in the GSTA-178 fragment Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(project-structure): patches/ also carries the TcpPortRandomizationWin backport Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
37 lines
2.0 KiB
Diff
37 lines
2.0 KiB
Diff
diff --git a/lib/coreBundle.js b/lib/coreBundle.js
|
|
index d9041dd0f009072511a7d808dec83121ff29e127..542acd31dd7e8ae084de952dc42ec63d0caba849 100644
|
|
--- a/lib/coreBundle.js
|
|
+++ b/lib/coreBundle.js
|
|
@@ -8906,6 +8906,10 @@ async function launchProcess(options) {
|
|
env: options.env,
|
|
cwd: options.cwd,
|
|
shell: options.shell,
|
|
+ // gstack patch (#2160/#1989): Node defaults windowsHide to false for
|
|
+ // child_process.spawn, so browser children could flash a console window
|
|
+ // on Windows. Playwright never needs the child's window shown.
|
|
+ windowsHide: true,
|
|
stdio
|
|
};
|
|
const spawnedProcess = childProcess.spawn(options.command, options.args || [], spawnOptions);
|
|
@@ -8985,7 +8989,7 @@ async function launchProcess(options) {
|
|
options.log(`[pid=${spawnedProcess.pid}] <will force kill>`);
|
|
try {
|
|
if (process.platform === "win32") {
|
|
- const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true });
|
|
+ const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true, windowsHide: true });
|
|
const [stdout2, stderr2] = [taskkillProcess.stdout.toString(), taskkillProcess.stderr.toString()];
|
|
if (stdout2)
|
|
options.log(`[pid=${spawnedProcess.pid}] taskkill stdout: ${stdout2}`);
|
|
@@ -34634,7 +34638,10 @@ var init_chromiumSwitches = __esm({
|
|
// Disables forced sign-in in Edge.
|
|
"msForceBrowserSignIn",
|
|
// Disables updating the preferred version in LaunchServices preferences on mac.
|
|
- "msEdgeUpdateLaunchServicesPreferredVersion"
|
|
+ "msEdgeUpdateLaunchServicesPreferredVersion",
|
|
+ // gstack patch: backport of microsoft/playwright#43605 (1.65). Random client ports fail with
|
|
+ // net::ERR_NO_BUFFER_SPACE (WSAENOBUFS) on Windows even when ports are free (crbug.com/572515601).
|
|
+ "TcpPortRandomizationWin"
|
|
].filter(Boolean);
|
|
chromiumSwitches = (options) => [
|
|
"--disable-field-trial-config",
|