mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-10 10:40:32 +01:00
* fix(ship): base merges, adjacent base edits, test-only and audit-requested fixes no longer force a second review loop (GST-407, GST-384, GST-391) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: trim two phrases for headroom with #3662 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: keep the Next steps heading phrase the handoff check reads; trim elsewhere Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: regenerate ship goldens Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes comparePath returns same only when every hunk sits where the base change puts it (patch-ids ignore positions) and treats a file-mode change as changed; the scoped-review packet says when a fence is truncated; --docs-result must be the posted audit's result; the --context-reviewed record goes beside the packet, outside the worktree. Negative controls for each. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes A test edit routes as tests= only when it adds lines with no gate tag; a removed or changed line or an unreadable test diff goes through the full loop. Diffs skip textconv. A hunkless patch (binary, empty, mode-only) is same when its patch-id matches. Without --reviewed-base test files route as before. finish's packet path and attempt's state directory have fallbacks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes; a version-only stamp_files edit after review is release metadata (GBRA-251) gateEditedPaths reads removed lines only inside hunks; carry refuses when a path listing fails; docs freshness stops on a failed listing; attempt counts an unreadable state file. releasePaths includes stamp_files paths whose edit is a version swap under stamp_patterns. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: no test edit skips review; guard packet writes; exclusive attempt state A test-only edit with no gate tag gets the scoped fix-check of its test hunks instead of a lanes-only rerun. Packet write failures print a STOP or RECEIPT_CARRY_REFUSED. attempt's allowance uses an exclusive create. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: attempt prints gstack's install command; carry checks the product diff outside context paths The attempt STOP no longer echoes the audit child's fix text. A scoped-review carry now requires the product patch-id without the context paths to match at both heads. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: oversized packets take the full loop; exact --docs-requested match; name-only test globs only in test dirs A scoped-review packet section over 200 lines sends that path to the full loop instead of a truncated packet. The docs-result path match is exact. test_*.py, *Test.java and similar count as test code only under a test directory. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(unattended): carry's scoped-review refusal and what it keeps Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry's scoped-review route in ship-policy, review-policy and troubleshooting (docs-a-1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(windows): curate ship-rereview-triggers out of the Windows lane like ship-release (run 41193336209) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review-log): record a notes-only /ship pass clean; name the cause and repair when a pass's tree moved (GST-430) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(receipt): carry and write handle PRs with thousands of files; tree receipt fails closed on a failed diff (GST-448) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): preflight routes RECEIPT_CARRY_SCOPED_REVIEW to the scoped review; carry --dry-run writes no packet (GST-442) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(ship): Step 1.4 and Step 16 route the scoped-review refusal and the --docs-requested fix; trims keep the cap (GST-442, GST-444) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship review pass 1: notes-only floor, scoped carry order, named temp and diff refusals - A notes-only pass is recorded clean only when every finding is fixed, or noted or deferred below the blocking floor (never CRITICAL or blocking), by its logger-stamped action, and the findings account for the claimed issue and critical counts (GST-430). - The preflight scoped carry route commits and pushes the base-merge fix before writing the packet (GST-442). - patchId refuses by name on an unwritable TMPDIR; the tree receipt names why its diff failed (GST-448). - Step 16 stage 3 spells out --docs-requested with its --docs-result (GST-444). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: pin the Step 16 --docs-requested route with its --docs-result Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with a logger-stamped open gate finding reads UNVERIFIED (red-team, pass 1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 findings: gate rows from --findings are stamped, one open rule, stale patch-id dirs swept - deriveFromFindings stamps gate rows with the session kind before deriving status, so a findings file cannot dispose of a gate finding the unattended logger forces open (outside-voice#1). - reviewFreshness reads a claimed row's findings with isOpenByAction, the rule the notes-only rewrite uses; noted and deferred clear a finding only when it is marked blocking: false and is not CRITICAL. - patchId sweeps gstack-patch-id-* directories over an hour old that a killed carry left in TMPDIR. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 round 2: stamped-open gates win over status and disposition; resolved gate, skipped and below-floor actions stay CURRENT - isOpenFinding treats action 'open' (the logger's forced-open stamp) as open before a row's status or disposition. - reviewFreshness flags a claimed clean row only for an 'open' action or a CRITICAL or blocking deferral or note, so interactive kept and restored gates, skipped advisories and INFORMATIONAL deferrals read CURRENT as before. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: carry dry run offers the scoped route last; patch-id diff under the git dir; changelog matches the review-log floor Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with any unresolved non-gate CRITICAL finding reads UNVERIFIED (pass 2 red-team) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry dry-run scoped route, patch-id directory, tree-receipt refusal (docs-d-1 audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 3 names merge conflicts in its STOP sentence again (ship-workflow-clarity pin) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(tree-receipt): keep the gated-to-current diff at the file helper timeout (60 s); pregate literals check Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(carry): large-diff fixture sets core.longpaths so Git for Windows can add its long receipt paths (windows-free-shard 1, run 41210080055) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): a stale local base branch yields to its origin twin in gate-diff and diff-scope (GST-462) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 11 saves the targeted record and the receipt writes carry it; Step 9 clears it (GST-464) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: GST-464 and GST-462 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): pass 1: ahead and diverged labels, diff-scope needs shared history; preflight refreshes origin/<base> and stops on a diff far beyond the PR (GST-462, HARN-15) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes for base twin, prSized stop and targeted record Resolve the tracking twin by refs/remotes/<remote>/<ref> and only for a bare branch name, keep a local base that is ahead or diverged, quote the prSized stop's base and name the fork case, and have every Step 9 entry create, exclude and clear .gstack/tmp/targeted.json. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: origin's tracking base wins whenever related; prSized lower bound The fix-check found that keeping a local base ahead of origin left unpushed base commits out of the gate scan while review-plan listed them. The tracking branch now wins whenever it shares history with HEAD, an explicit origin/main reads refs/remotes/origin/main, the preflight also stops when the diff lists fewer files than the PR, and the Step 9 exclude line survives a missing .git/info and an exclude file without a final newline. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: the tracking-ref claim holds while the tracking branch exists Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the two ship section briefs under no-loss replay GST-464 GST-464 brief-identity check: every reviewer brief lib/review-brief.ts cuts from ship/sections/review-army.md and adversarial.md stays byte-identical to the bodies the L and GST-257 replays admitted; only lead instructions outside the cut spans changed. The check is a test CI runs. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: keep Step 9's PASS_HEAD sentence whole; repin review-army under GST-464 The targeted-record line follows the PASS_HEAD/RANGE_BASE sentence instead of splitting it (test/review-fix-range.test.ts pins that sentence). The brief-body check still holds: every reviewer brief is byte-identical. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: restore bin/gstack-ship-receipt after the main merge The merge commitb10e2dbwrote a truncated copy of the file. This is the three-way merge of both sides with the refused() union: main's codes plus RECEIPT_CARRY_SCOPED_REVIEW. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: narrow the consumer scan and give it one 300 s deadline (GST-544) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: keep the consumer scan deadline under the 180 s plan timeout (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: plain paths under --literal-pathspecs; whole-millisecond timeout override (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: whole-tree grep for non-UTF-8 names, no argument spread, name spawn errors (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: cap the consumer grep output at 256 MB across calls; per-scan deadline wording (review fix, cycle 4) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: read a missing spawn status as null (Bun 1.4.2 returns undefined on ENOENT) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: review-collect whole-tree helper reads a null status as -1 (typecheck:test ratchet) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: /review and /ship triage every configured review bot, not only Greptile (#3122) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (gh before 2.48 pages without --slurp; driver routes Step 10; tests for guards, review-bot fence, REMOTE_SLUG owner) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: drop the review-bot fence test that could not fail (the tool-fence WARN degrade is unreachable: placeholder spans are skipped first) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes (record by comment id so a filename never reaches a shell; lookup failures are errors; tojson pages; longest bot prefix wins) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes (record refuses * paths, colliding ids and a missing fetch dir; parent requires id and dir; botOwning doc) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: classify the PR type and always check repo conventions (#356) The checklist now opens with a PR-type line (application, CI/infra, scripts/tooling, docs-only or mixed). Application and mixed diffs run every category; other types always run five categories, including the new Repo Conventions & Platform Fit, and report the rest as not applicable in one line instead of skipping silently. No-loss replay: GSTA-224 H1 preregistered no-loss run (run id gsta224-h1-20261031, Opus 5.5, 81 calls, $9.53) against main's checklist with a no-gstack arm; every preregistered bar passed. The review/checklist.md pin in test/review-packets-removed.test.ts moves to a32963ef with replay 'GSTA-224 H1'. Refs GSTA-224 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: allowlist the record placeholders and match Step 10's id rule in tests The record fence uses <comment-id>, <fix|fp|already-fixed> and <category>, each with an enum or numeric grammar; <greptile-dir> becomes <bot-dir>. review/greptile-triage.md also lists every REVIEW_BOTS skip reason. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: review-bot triage covers every configured bot (#3122) README, CONTRIBUTING, the contributor reference and standalone-binaries name gstack-review-bots and the review-bot fence; TODOS drops the #3122 item; the changelog fragment covers record-by-id and lookup errors. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: the PR-type test also pins the compose, Terraform and README/CHANGELOG phrases Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: follow the review-bot rename in the remote free tier's three reds The cross-skill consistency judge describes review-bot-history.md and its record helper; the tracker-guard exemption for the removed raw Greptile fetch in review/greptile-triage.md is dropped (the fetch now lives in gstack-review-bots, whose bodies still reach context only through gstack-issue-guard); the Step 10 PR-check test expects 'Review bots: not run'. HARNESS_VERSION stays 6: skill-fixture.ts and llm-judge.ts are recorded non-behavioral for every other case. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the cross-skill judge's rubric to one renamed bullet Name review-bot-history.md beside the older greptile-history.md so the calibration corpus still matches, and keep the REMOTE_SLUG bullet. One live 3-sample panel at this tree: consistent 3/3, scores 4/4/4. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: H1 fragment passes prose lint Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: name the H1 fragment after its branch; TODOS drops #356 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: /review's PR type step in docs/skills.md (#356) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-policy: review_exclude_paths key and loadPolicyAt (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: apply the base policy's review_exclude_paths and the reviewer diff ceiling (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * receipt: bind review_exclude in write, carry and the queue (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs, tests and changelog for review_exclude_paths (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (binary by bytes, links kept, untracked files out of the selection) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep binary files at code paths under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: name the reasons that keep a binary file under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep every review_exclude_paths candidate when the gate scan is unknown; docs example names its version Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the NUL fixture clear of the sync-spawn tripwire Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: split the ceiling sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep a live binary file whose bytes cannot be read; tests render outside voices from a clean checkout and read the ship fixture text Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(review-exclude): explicit +x for the census script; skip the chmod-000 read case on Windows and root Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * refactor: move loadPolicyAt to lib/ship-policy-at.ts so lib/ship-policy.ts stays under the 800-line module cap Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: refuse a base that contains HEAD; skip a self-pointing origin/HEAD (GST-774) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore: regenerate gstack-doctor-components.sh for BASE_CONTAINS_HEAD Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: land resumes a merged merge-only PR instead of refusing BASE_CONTAINS_HEAD (GST-774 review) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: changelog fragment for GST-774 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: troubleshooting names diff-scope base_contains_head and the self-pointing no_base case (GST-774 docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the reviewer briefs to GST-508's no-loss-tested bytes ship/sections/review-army.md, ship/sections/adversarial.md and lib/review-depth.ts now pin the bytes the GST-508 preregistered no-loss replay ran atef2760f(handoffs/GSTA-202/noloss-results.md in the GStack Minder drive): Arm V 33/41 vs R 33/41, delta 4, exact sign flip, p_NI 0.0279 (pass). The merge of main83ae96eleaves these three files byte-identical toef2760f, and an Arm P unit (3593) renders byte-identical briefs atef2760fand at the merge. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: GST-774 review round 1 — merged resume depth, aliased and detached PR checkouts, develop/trunk defaults Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: Step 20 says a metrics row, keeping DRIVER.md at 12 KB after the main merge Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: ship-parts resend case leaves room for the first phase-3 part after the Step 9 targeted-record sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship delivers review/checklist.md in two parts so checklist v1 fits the 24576-byte part cap (#3670) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: drop the GST-407 and GST-430 fragments, already released on main (stacked history) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: lib/ship-policy.ts back to 800 lines (module-size ratchet after merging #3744 and #3795) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: /ship pass 1 fixes - lib/ship-receipt-depth.ts: a merged resume (land after a true merge) no longer recomputes the review_exclude digest over the emptied range, so it lands instead of RECEIPT_INVALID (failing-first land test with review_exclude_paths active). - bin/gstack-review-dispatch render: a standalone targeted render under an active review_exclude_paths refuses and points at the pass manifest voices stage, instead of writing a brief with no selection that leaves verify dirty (failing-first test). - test/default-base.test.ts: #3795 expectations follow main R51 depth (light for an 80-line code diff; runtime_lines=80 still proves the real base). - test/review-dispatch.test.ts: the GST-897 fingerprint test renders from the clean checkout, like its neighbor, because CI rebuilds the tracked lib/diagram-render/dist/diagram-render.html and the reviewer diff ceiling refused the ROOT render. * wave review-53cfb5bfe011: /ship pass 2 fixes - lib/review-exclude.ts: binaryContent reads each blob's first 8,000 bytes (git cat-file blob, 8 KB buffer) instead of one --batch read capped at 256 MB, so head mode (receipt, carry, queue) and the plan agree past 256 MB of blobs; an unreadable blob is kept, as in live mode. Failing-first test with two 270 MB blobs. - lib/review-bots.ts: a file-level bot review comment (subject_type file, no line position) is triaged instead of read as outdated. Failing-first test. - test/ship-queue-land.test.ts: the merged-resume exclusion test runs its gate scan under the fixture state root, not the real home (CI free-suite 6 home containment). * fix: merge follow-ups for main3d99c22: origin/* stays qualified in diff-scope's twin step, retro skeleton back under its cap, combined no-loss pin GST-508+R51+GST-911 * fix(review): receipt write gate-scans whenever the base declares review_exclude_paths; collectLive never re-qualifies origin/<base> (#3852 /ship red-team#1, outside-voice#1) * test: the docs-only receipt digest test keeps its gate scan out of the real home (free-suite shard 5 FREE_SUBSHARD_REJECTED) * fix(mergefc292e22f): tentative REVIEW_EXCLUDE_KEY_VERSION, classify targeted.json, render main's new outside-voice test from a clean checkout - lib/ship-policy.ts: REVIEW_EXCLUDE_KEY_VERSION 1.93.0.0 -> 1.94.0.0, the next-minor tentative form stamp_paths moves (docs/ship-policy.md, #3512); 1.93.0.0 is a released heading that never names the key. - test/gstack-clean-producers.test.ts (new from main): KEPT gains targeted.json, the wave's --review-targeted input. - test/review-dispatch.test.ts: main's wrong-tree test rendered the outside voice from ROOT; a CI build that dirties ROOT pushes that diff past the wave's REVIEW_DIFF_MAX_BYTES ceiling, so render refused and verify saw no brief (exit 3). It now runs in cleanCheckout like the wave's other outside-voice tests. * test(merge68410828f): GST-967's brief-body pin carries the wave's GST-508 placeholders The merged sectionTexts differ from main's by exactly the wave's GST-508 exclude-pathspec lines (merged minus main equals wave minusfc292e22f); the 1,440-case plan grid still hashes to main's MAIN_PLANS. Checks: GStack Minder drive handoffs/GSTA-202/merge-6841-checks.md. * fix(mergee85005482): targeted classes since the read accept an empty range; the wave's receipt tests pass main's targeted record - lib/ship-receipt-depth.ts targetedClassesSince (main, GST-986) reads the range from the commit the targeted reader read to HEAD through headInputs, which since #3795 runs gstack-diff-scope's BASE_CONTAINS_HEAD check. When the reader read HEAD itself the range is empty, diff-scope reported base_contains_head, and every write with --review-targeted was refused (the product patch matched). It now passes merged=true (--merged), which skips only that check; an ancestor check already guards the range. - test/review-exclude.test.ts and test/review-targeted.test.ts: since #3887 write refuses a money head with no targeted record and requires the record's head, so the wave's two writes that must succeed pass one, as main's own tests do (targetedAtHead in test/ship-receipt-depth.test.ts). * test(mergee85005482): drop the wave's duplicate targeted.json KEPT entry Main (#3887) classified .gstack/tmp/targeted.json in KEPT too; the auto-merge kept both keys, which typecheck:test rejects (TS1117). Main's entry stays. * test(mergee85005482): ship size ledger entry for the merged tree (-232 B) Main's ship size ledger plus the wave's entries summed to 345,334 B; the merged tree measures 345,102 B because DRIVER.md takes main's shorter Step 19 line. Recorded with scripts/size-ledger.ts record ship. --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
434 lines
19 KiB
TypeScript
434 lines
19 KiB
TypeScript
/**
|
|
* Contract + behavior tests for bin/gstack-retro-metrics (retro
|
|
* token-reduction wave — the inline git/awk pipelines from retro/SKILL.md
|
|
* Steps 0.5-9 and 11, consolidated into one script).
|
|
*
|
|
* Three layers:
|
|
* 1. CONTRACT — every labeled `KEY:` line the rendered retro prose
|
|
* interprets must be emitted (hermetic temp HOME + GSTACK_HOME, synthetic
|
|
* git repo fixture with pinned author AND committer dates).
|
|
* 2. BEHAVIOR — deterministic values on the fixture: commit/type/session
|
|
* counts, streak anchoring, window --until, local-branch fallback,
|
|
* AI-trailer vs human co-author split, VERSION range, aux-file presence.
|
|
* 3. EDGES — a 1-commit repo and a non-repo dir both survive (exit 0, no
|
|
* dropped lines); the skill fence shape stays pinned in the template.
|
|
*
|
|
* All hermetic: HOME + GSTACK_HOME point at throwaway temp dirs; the script
|
|
* runs from the live worktree bin/ (the subject under test).
|
|
*/
|
|
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
|
|
import { execFileSync, spawnSync } from 'child_process';
|
|
import * as fs from 'fs';
|
|
import * as os from 'os';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const SCRIPT = path.join(ROOT, 'bin', 'gstack-retro-metrics');
|
|
|
|
let tmpHome: string;
|
|
let tmpGstackHome: string;
|
|
let repoDir: string;
|
|
|
|
function hermeticEnv(): Record<string, string> {
|
|
return { PATH: process.env.PATH!, HOME: tmpHome, GSTACK_HOME: tmpGstackHome };
|
|
}
|
|
|
|
function runMetrics(args: string[], cwd: string = repoDir): string {
|
|
return execFileSync(SCRIPT, args, { encoding: 'utf-8', cwd, env: hermeticEnv() });
|
|
}
|
|
|
|
/** Commit with pinned author AND committer dates (guard + --until read %ci). */
|
|
function commit(dir: string, msg: string, date: string, author?: { name: string; email: string }): void {
|
|
const env: Record<string, string> = {
|
|
...hermeticEnv(),
|
|
GIT_COMMITTER_DATE: date,
|
|
...(author ? { GIT_AUTHOR_NAME: author.name, GIT_AUTHOR_EMAIL: author.email } : {}),
|
|
};
|
|
const r = spawnSync('git', ['commit', '-m', msg, '--date', date], {
|
|
cwd: dir, stdio: 'pipe', timeout: 10_000, env,
|
|
});
|
|
if (r.status !== 0) throw new Error(`fixture commit failed: ${r.stderr}`);
|
|
}
|
|
|
|
function git(dir: string, args: string[]): void {
|
|
const r = spawnSync('git', args, { cwd: dir, stdio: 'pipe', timeout: 10_000, env: hermeticEnv() });
|
|
if (r.status !== 0) throw new Error(`git ${args.join(' ')} failed: ${r.stderr}`);
|
|
}
|
|
|
|
function write(dir: string, file: string, content: string): void {
|
|
fs.writeFileSync(path.join(dir, file), content);
|
|
git(dir, ['add', file]);
|
|
}
|
|
|
|
beforeAll(() => {
|
|
tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-home-'));
|
|
tmpGstackHome = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-gh-'));
|
|
repoDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-repo-'));
|
|
|
|
git(repoDir, ['init', '-b', 'main']);
|
|
git(repoDir, ['config', 'user.email', 'dev@example.com']);
|
|
git(repoDir, ['config', 'user.name', 'Dev']);
|
|
|
|
// Day 1 — one 20-minute session (2 commits) + one solo commit later.
|
|
write(repoDir, 'app.ts', 'console.log("hello");\n');
|
|
commit(repoDir, 'feat: initial app', '2026-03-10T09:00:00');
|
|
write(repoDir, 'auth.ts', 'export function login() {}\n');
|
|
commit(repoDir, 'feat: add auth (#12)', '2026-03-10T09:20:00');
|
|
write(repoDir, 'foo.test.ts', 'test("login", () => {});\n');
|
|
commit(repoDir, 'test(qa): add regression test', '2026-03-10T11:00:00');
|
|
|
|
// Day 2 — 5-minute session; first commit carries an AI trailer AND a human
|
|
// co-author trailer.
|
|
write(repoDir, 'app.ts', '// wire auth\nimport "./auth";\nconsole.log("hello");\n');
|
|
commit(
|
|
repoDir,
|
|
'fix: wire auth\n\nCo-Authored-By: Claude Opus <noreply@anthropic.com>\nCo-Authored-By: Alice Smith <alice@example.com>',
|
|
'2026-03-11T10:00:00',
|
|
);
|
|
write(repoDir, 'VERSION', '1.0.0.0\n');
|
|
commit(repoDir, 'chore: add VERSION', '2026-03-11T10:05:00');
|
|
|
|
// Day 3 — a second author bumps VERSION (contributors=2, team streak=3).
|
|
write(repoDir, 'VERSION', '1.1.0.0\n');
|
|
commit(repoDir, 'chore: bump VERSION', '2026-03-12T09:30:00', { name: 'Bob', email: 'bob@example.com' });
|
|
});
|
|
|
|
afterAll(() => {
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
fs.rmSync(tmpGstackHome, { recursive: true, force: true });
|
|
fs.rmSync(repoDir, { recursive: true, force: true });
|
|
});
|
|
|
|
/** Labeled keys the rendered retro prose interprets (Steps 1-11). */
|
|
const REQUIRED_KEYS = [
|
|
'RETRO_METRICS_PROTO',
|
|
'GUARD_REMOTE',
|
|
'GUARD_HEAD',
|
|
'RETRO_REF',
|
|
'GUARD_LATEST_COMMIT',
|
|
'WINDOW_SINCE',
|
|
'WINDOW_UNTIL',
|
|
'USER_NAME',
|
|
'USER_EMAIL',
|
|
'COMMIT',
|
|
'COMMITS',
|
|
'MERGE_COMMITS',
|
|
'CONTRIBUTORS',
|
|
'INSERTIONS',
|
|
'DELETIONS',
|
|
'NET_LOC',
|
|
'TEST_INSERTIONS',
|
|
'TEST_RATIO',
|
|
'WEIGHTED_COMMITS',
|
|
'ACTIVE_DAYS',
|
|
'TEST_FILES_CHANGED',
|
|
'SESSIONS',
|
|
'DEEP_SESSIONS',
|
|
'MEDIUM_SESSIONS',
|
|
'MICRO_SESSIONS',
|
|
'TOTAL_ACTIVE_MINUTES',
|
|
'AVG_SESSION_MINUTES',
|
|
'LOC_PER_SESSION_HOUR',
|
|
'COMMIT_TYPES',
|
|
'FIX_RATIO',
|
|
'COMMIT_SIZE_BUCKETS',
|
|
'HOURS',
|
|
'PEAK_HOUR',
|
|
'FOCUS_SCORE',
|
|
'BIGGEST_COMMIT',
|
|
'HOTSPOT',
|
|
'AUTHOR',
|
|
'AUTHOR_BIGGEST',
|
|
'WEEK',
|
|
'COAUTHOR',
|
|
'AI_ASSISTED_COMMITS',
|
|
'LOGICAL_SLOC_ADDED',
|
|
'PRS_REFERENCED',
|
|
'PR_REFS',
|
|
'TEST_FILES_TOTAL',
|
|
'REGRESSION_TEST_COMMITS',
|
|
'REGRESSION_COMMIT',
|
|
'VERSION_RANGE',
|
|
'TEAM_STREAK',
|
|
'USER_STREAK',
|
|
'RETRO_CONTEXT',
|
|
'GREPTILE_HISTORY',
|
|
'REVIEW_BOT_HISTORY',
|
|
'TODOS_FILE',
|
|
'SKILL_USAGE_LOG',
|
|
'EUREKA_LOG',
|
|
'FRICTION_SOURCES',
|
|
'FRICTION',
|
|
'RETRO_METRICS_END',
|
|
] as const;
|
|
|
|
describe('gstack-retro-metrics contract', () => {
|
|
test('emits every labeled key the retro prose interprets', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
const missing = REQUIRED_KEYS.filter((k) => !new RegExp(`^${k}: `, 'm').test(out));
|
|
expect(missing, `Script stopped emitting: ${missing.join(', ')} — the prose contract broke`).toEqual([]);
|
|
});
|
|
|
|
test('proto handshake is the FIRST line', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out.split('\n')[0]).toBe('RETRO_METRICS_PROTO: 1');
|
|
});
|
|
|
|
test('the skill fence invokes the script with primary path + degraded fallback', () => {
|
|
const tmpl = fs.readFileSync(path.join(ROOT, 'retro', 'SKILL.md.tmpl'), 'utf-8');
|
|
expect(tmpl).toContain('"{{RUNTIME_ROOT}}/bin/gstack-retro-metrics"');
|
|
expect(fs.readFileSync(path.join(ROOT, 'retro', 'SKILL.md'), 'utf-8')).toContain('$HOME/.claude/skills/gstack/bin/gstack-retro-metrics');
|
|
expect(tmpl).toContain('".claude/skills/gstack/bin/gstack-retro-metrics"');
|
|
expect(tmpl).toContain('--base "<default>" --since "<since>"');
|
|
expect(tmpl).toContain(
|
|
'RETRO_METRICS: unavailable — stale install (read the helper source for manual computation)',
|
|
);
|
|
// Degraded-mode prose keys off the proto handshake.
|
|
expect(tmpl).toContain('RETRO_METRICS_PROTO: 1');
|
|
});
|
|
|
|
test('script is executable', () => {
|
|
expect(fs.statSync(SCRIPT).mode & 0o111).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe('gstack-retro-metrics behavior', () => {
|
|
test('deterministic aggregates on the fixture', () => {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out).toMatch(/^COMMITS: 6$/m);
|
|
expect(out).toMatch(/^CONTRIBUTORS: 2$/m);
|
|
expect(out).toMatch(/^ACTIVE_DAYS: 3$/m);
|
|
// No origin remote: guard discloses, ref falls back to the local branch.
|
|
expect(out).toMatch(/^GUARD_REMOTE: none$/m);
|
|
expect(out).toMatch(/^GUARD_HEAD: main$/m);
|
|
expect(out).toMatch(/^RETRO_REF: main$/m);
|
|
expect(out).toMatch(/^GUARD_LATEST_COMMIT: 2026-03-12$/m);
|
|
// Conventional-commit mix (feat 2, fix 1, test 1, chore 2).
|
|
const types = out.match(/^COMMIT_TYPES: (.*)$/m)![1];
|
|
expect(types).toContain('feat=2');
|
|
expect(types).toContain('fix=1');
|
|
expect(types).toContain('test=1');
|
|
expect(types).toContain('chore=2');
|
|
// Session detection: [09:00,09:20]=medium, [11:00]=micro, [10:00,10:05]=micro, [09:30]=micro.
|
|
expect(out).toMatch(/^SESSIONS: 4$/m);
|
|
expect(out).toMatch(/^MEDIUM_SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^MICRO_SESSIONS: 3$/m);
|
|
expect(out).toMatch(/^DEEP_SESSIONS: 0$/m);
|
|
expect(out).toMatch(/^TOTAL_ACTIVE_MINUTES: 25$/m);
|
|
// Test health.
|
|
expect(out).toMatch(/^TEST_FILES_TOTAL: 1$/m);
|
|
expect(out).toMatch(/^TEST_FILES_CHANGED: 1$/m);
|
|
expect(out).toMatch(/^REGRESSION_TEST_COMMITS: 1$/m);
|
|
expect(out).toMatch(/^REGRESSION_COMMIT: \w+ test\(qa\): add regression test$/m);
|
|
// PR refs from subjects.
|
|
expect(out).toMatch(/^PRS_REFERENCED: 1$/m);
|
|
expect(out).toMatch(/^PR_REFS: #12$/m);
|
|
// AI trailer counted separately from the human co-author credit.
|
|
expect(out).toMatch(/^AI_ASSISTED_COMMITS: 1$/m);
|
|
expect(out).toMatch(/^COAUTHOR: \w+\|Alice Smith <alice@example\.com>$/m);
|
|
expect(out).not.toMatch(/^COAUTHOR: .*anthropic\.com/m);
|
|
// VERSION range across the window.
|
|
expect(out).toMatch(/^VERSION_RANGE: v1\.0\.0\.0 → v1\.1\.0\.0$/m);
|
|
// Streaks anchored at the newest commit date, never the wall clock.
|
|
expect(out).toMatch(/^TEAM_STREAK: 3 days \(anchor 2026-03-12\)$/m);
|
|
expect(out).toMatch(/^USER_STREAK: 2 days \(anchor 2026-03-11\)$/m);
|
|
// Hour histogram carries the fixture's commit hours.
|
|
const hours = out.match(/^HOURS: (.*)$/m)![1];
|
|
expect(hours).toContain('09=');
|
|
expect(hours).toContain('10=');
|
|
});
|
|
|
|
test('--until bounds the window (compare mode prior window)', () => {
|
|
const out = runMetrics([
|
|
'--base', 'main',
|
|
'--since', '2026-03-09T00:00:00',
|
|
'--until', '2026-03-11T00:00:00',
|
|
]);
|
|
expect(out).toMatch(/^COMMITS: 3$/m);
|
|
expect(out).toMatch(/^ACTIVE_DAYS: 1$/m);
|
|
expect(out).toMatch(/^WINDOW_UNTIL: 2026-03-11T00:00:00$/m);
|
|
});
|
|
|
|
test('aux inputs report present when the files exist under GSTACK_HOME', () => {
|
|
fs.writeFileSync(path.join(tmpGstackHome, 'greptile-history.md'), '# history\n');
|
|
fs.writeFileSync(path.join(tmpGstackHome, 'review-bot-history.md'), '# history\n');
|
|
fs.mkdirSync(path.join(tmpGstackHome, 'analytics'), { recursive: true });
|
|
fs.writeFileSync(path.join(tmpGstackHome, 'analytics', 'skill-usage.jsonl'), '{}\n');
|
|
try {
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out).toMatch(/^GREPTILE_HISTORY: present /m);
|
|
expect(out).toMatch(/^REVIEW_BOT_HISTORY: present /m);
|
|
expect(out).toMatch(/^SKILL_USAGE_LOG: present /m);
|
|
expect(out).toMatch(/^RETRO_CONTEXT: absent$/m);
|
|
expect(out).toMatch(/^EUREKA_LOG: absent$/m);
|
|
} finally {
|
|
fs.rmSync(path.join(tmpGstackHome, 'greptile-history.md'), { force: true });
|
|
fs.rmSync(path.join(tmpGstackHome, 'review-bot-history.md'), { force: true });
|
|
fs.rmSync(path.join(tmpGstackHome, 'analytics'), { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('friction lines count this project only, within the window', () => {
|
|
const slug = execFileSync(path.join(ROOT, 'bin', 'gstack-slug'), ['--get', 'SLUG'], {
|
|
encoding: 'utf-8', cwd: repoDir, env: hermeticEnv(), timeout: 10_000,
|
|
}).trim();
|
|
const projects = path.join(tmpGstackHome, 'projects');
|
|
const line = (o: Record<string, unknown>) => JSON.stringify(o) + '\n';
|
|
fs.mkdirSync(path.join(projects, slug), { recursive: true });
|
|
fs.mkdirSync(path.join(projects, 'other-project'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(projects, slug, 'timeline.jsonl'),
|
|
line({ skill: 'ship', event: 'started', session: 's1', ts: '2026-03-10T12:00:00Z' }) +
|
|
line({ skill: 'ship', event: 'completed', outcome: 'abort', session: 's1', ts: '2026-03-10T12:30:00Z' }) +
|
|
line({ skill: 'ship', event: 'completed', outcome: 'error', ts: '2020-01-01T00:00:00Z' }),
|
|
);
|
|
fs.writeFileSync(
|
|
path.join(projects, slug, 'question-log.jsonl'),
|
|
line({ skill: 'ship', source: 'agent', session_id: 'A', question_id: 'ship-x', ts: '2026-03-10T12:10:00Z' }) +
|
|
line({ skill: 'unknown', source: 'hook', session_id: 'claude-uuid', tool_use_id: 't1', ts: '2026-03-10T12:10:00Z' }),
|
|
);
|
|
fs.writeFileSync(
|
|
path.join(projects, 'other-project', 'timeline.jsonl'),
|
|
line({ skill: 'qa', event: 'completed', outcome: 'error', ts: '2026-03-10T12:00:00Z' }),
|
|
);
|
|
try {
|
|
const untracked = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(untracked).toMatch(/^FRICTION_SOURCES: timeline=present questions=absent$/m);
|
|
expect(untracked).toMatch(/^FRICTION: \/ship score=1 runs=1 questions=0 typed=0 errors=0 aborts=1$/m);
|
|
execFileSync(path.join(ROOT, 'bin', 'gstack-config'), ['set', 'question_tuning', 'true'], {
|
|
encoding: 'utf-8', cwd: repoDir, env: hermeticEnv(), timeout: 10_000,
|
|
});
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00']);
|
|
expect(out).toMatch(/^FRICTION_SOURCES: timeline=present questions=present$/m);
|
|
expect(out).toMatch(/^FRICTION: \/ship score=2 runs=1 questions=1 typed=0 errors=0 aborts=1$/m);
|
|
expect(out).not.toMatch(/^FRICTION: \/qa /m);
|
|
expect(out).not.toMatch(/^FRICTION: \/unknown /m);
|
|
const prior = runMetrics(['--base', 'main', '--since', '2026-03-01T00:00:00', '--until', '2026-03-08T00:00:00']);
|
|
expect(prior).toMatch(/^FRICTION: none$/m);
|
|
} finally {
|
|
fs.rmSync(projects, { recursive: true, force: true });
|
|
fs.rmSync(path.join(tmpGstackHome, 'config.yaml'), { force: true });
|
|
}
|
|
});
|
|
|
|
test('a failing bun prints FRICTION: unavailable and the script still ends ok', () => {
|
|
const fakeBin = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-fakebun-'));
|
|
fs.writeFileSync(path.join(fakeBin, 'bun'), '#!/bin/sh\nexit 1\n', { mode: 0o755 });
|
|
try {
|
|
const out = execFileSync(SCRIPT, ['--base', 'main', '--since', '2026-03-09T00:00:00'], {
|
|
encoding: 'utf-8', cwd: repoDir, env: { ...hermeticEnv(), PATH: `${fakeBin}:${process.env.PATH}` }, timeout: 30_000,
|
|
});
|
|
expect(out).toMatch(/^FRICTION: unavailable \(friction helper failed\)$/m);
|
|
expect(out).toMatch(/^RETRO_METRICS_END: ok$/m);
|
|
} finally {
|
|
fs.rmSync(fakeBin, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('zero-commit window still emits the full labeled surface', () => {
|
|
const out = runMetrics([
|
|
'--base', 'main',
|
|
'--since', '2020-01-01T00:00:00',
|
|
'--until', '2020-01-08T00:00:00',
|
|
]);
|
|
expect(out).toMatch(/^COMMITS: 0$/m);
|
|
expect(out).toMatch(/^SESSIONS: 0$/m);
|
|
expect(out).toMatch(/^RETRO_METRICS_END: ok$/m);
|
|
});
|
|
});
|
|
|
|
describe('gstack-retro-metrics edges', () => {
|
|
test('survives a repo with exactly 1 commit', () => {
|
|
const oneDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-one-'));
|
|
try {
|
|
git(oneDir, ['init', '-b', 'main']);
|
|
git(oneDir, ['config', 'user.email', 'solo@example.com']);
|
|
git(oneDir, ['config', 'user.name', 'Solo']);
|
|
write(oneDir, 'a.txt', 'hi\n');
|
|
commit(oneDir, 'feat: first', '2026-03-10T09:00:00');
|
|
const out = runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00'], oneDir);
|
|
expect(out).toMatch(/^COMMITS: 1$/m);
|
|
expect(out).toMatch(/^CONTRIBUTORS: 1$/m);
|
|
expect(out).toMatch(/^SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^MICRO_SESSIONS: 1$/m);
|
|
expect(out).toMatch(/^TEAM_STREAK: 1 days \(anchor 2026-03-10\)$/m);
|
|
expect(out).toMatch(/^BIGGEST_COMMIT: \w+\|1\|Solo\|feat: first$/m);
|
|
expect(out).toMatch(/^RETRO_METRICS_END: ok$/m);
|
|
} finally {
|
|
fs.rmSync(oneDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('non-repo dir reports RETRO_METRICS_ERROR and exits 0', () => {
|
|
const emptyDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-rm-empty-'));
|
|
try {
|
|
const out = runMetrics(['--since', '7 days ago'], emptyDir);
|
|
expect(out).toContain('RETRO_METRICS_PROTO: 1');
|
|
expect(out).toContain('RETRO_METRICS_ERROR: not inside a git repository');
|
|
} finally {
|
|
fs.rmSync(emptyDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('local reads only: no network git ops or curl anywhere in the script', () => {
|
|
const script = fs.readFileSync(SCRIPT, 'utf-8');
|
|
expect(script).not.toMatch(/(^|[;|&`($!]|\s)git(\s+-C\s+\S+)?\s+(push|pull|fetch|clone|ls-remote)\b/m);
|
|
expect(script).not.toMatch(/(^|[|&;(`]|\s|\$\()curl\s/);
|
|
});
|
|
});
|
|
|
|
// G6 riders #2812, #2809, #2037: the test census only knew JS/TS-style names,
|
|
// so pytest, minitest, XCTest, Terraform and Bats suites counted as zero, while
|
|
// a committed build directory counted as authored (and test) code.
|
|
describe('gstack-retro-metrics test census beyond JS/TS', () => {
|
|
function fixtureRepo(prefix: string, files: Record<string, string>): string {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
|
git(dir, ['init', '-b', 'main']);
|
|
git(dir, ['config', 'user.email', 'dev@example.com']);
|
|
git(dir, ['config', 'user.name', 'Dev']);
|
|
for (const [rel, body] of Object.entries(files)) {
|
|
fs.mkdirSync(path.dirname(path.join(dir, rel)), { recursive: true });
|
|
write(dir, rel, body);
|
|
}
|
|
commit(dir, 'feat: suite', '2026-03-10T09:00:00');
|
|
return dir;
|
|
}
|
|
|
|
test('pytest/minitest test_*.py|rb, Terraform and Bats files count; dir-homed helpers do not', () => {
|
|
const dir = fixtureRepo('gstack-rm-py-', {
|
|
'tests/test_login.py': 'def test_login():\n assert True\n',
|
|
'tests/test_signup.rb': "require 'minitest'\n",
|
|
'tests/helper_test.rb': "require 'minitest'\n",
|
|
'infra/main.tftest.hcl': 'run "plan" {}\n',
|
|
'scripts/cli.bats': '@test "runs" { true; }\n',
|
|
'tests/utils.py': 'HELPER = 1\n',
|
|
'app/testing.py': 'MODE = 1\n',
|
|
});
|
|
try {
|
|
expect(runMetrics(['--base', 'main', '--since', '2026-03-09T00:00:00'], dir)).toMatch(/^TEST_FILES_TOTAL: 5$/m);
|
|
} finally {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('Swift/XCTest naming counts; generated output and prose specs do not', () => {
|
|
const dir = fixtureRepo('gstack-rm-swift-', {
|
|
'App/Store.swift': 'struct Store {}\n',
|
|
'AppTests/StoreTests.swift': 'import XCTest\nfinal class StoreTests: XCTestCase {}\n',
|
|
'.build/Logs/Test/manifest.plist': 'generated\ngenerated\ngenerated\n',
|
|
'docs/specs/design.md': '# Design\nprose\nprose\n',
|
|
});
|
|
try {
|
|
const out = runMetrics(['--since', '2026-03-01T00:00:00'], dir);
|
|
expect(out).toMatch(/^TEST_FILES_TOTAL: 1$/m);
|
|
expect(out).toMatch(/^TEST_FILES_CHANGED: 1$/m);
|
|
expect(out).toMatch(/^TEST_INSERTIONS: 2$/m);
|
|
// 1 production + 2 test + 3 prose lines; the 3 generated lines are dropped.
|
|
expect(out).toMatch(/^INSERTIONS: 6$/m);
|
|
expect(out).not.toMatch(/^FOCUS_SCORE: .*\.build/m);
|
|
} finally {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|