mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 22:14:25 +01:00
* feat(ship): version-less repos, docs-audit record and caps, the frozen-scope paid case, and the review-loop follow-ups Follow-up to the review-loop convergence PR: Step 12 and the CHANGELOG step skip cleanly in a repository with no version source (receipt version "none"); the receipt records the docs audit outcome and the owner exception (DOCS_AUDIT_BLOCKED without one) and a policy may declare doc caps (gstack-ship-receipt docs-caps); docs/unattended.md names the READY evidence and the cross-family outside voice; the ship-frozen-scope-convergence behaviour case runs the generated Step 9.4 under review_scope frozen through the real binaries; carry probes git >= 2.39 (RECEIPT_GIT_TOO_OLD); defer passes the repository to gh repo view positionally and names its search limit; late defers count without being passes; reviewers diff from RANGE_BASE on pass 2+; the cap check runs before edits; --review-fanout batches specialists by free slots; read --check-prose compares quoted counters with the receipt (RECEIPT_PROSE_MISMATCH); checklist rule ids prereg-with-results and test-keyboard-count-loop; gstack-coauthor-trailers. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repair the CI reds the retarget onto main surfaced (test-only) Seven test files, no product change. The pull_request run at2d73faddfailed 5 Linux shards and 4 Windows shards: - test/ship-frozen-scope-actor.test.ts imported only test code, so the test-of-test ratchet refused it; the first case now recomputes the loop summary with summarizeReviewLoop/reviewLoopLine from lib/review-scope and asserts the exact REVIEW_LOOP line. Its three cases replay the bash workflow through bash -c and the shebang bins, so they are POSIX-only. - test/codex-host.test.ts: the new gate case is Claude-specific (33 -> 34). - test/paid-retry-supervision.test.ts: the gate census fixture now carries a trial record for the one planned behavior-kind gate case, the way test/ci-paid-coordination.test.ts already does. - test/review-fix-range.test.ts asserted the pre-#3487 DIFF_BASE sentence; it now asserts the ${RANGE_BASE:-merge-base} clause that carries the same contract (every reviewer reads the range from pass 2 on). - test/gstack-coauthor-trailers.test.ts: the fixture sets its own git identity; a CI runner has none to auto-detect ("Committer identity unknown"). - test/review-scope-followups.test.ts and test/gstack-ship-receipt-docs.test.ts: the gh and old-git stand-ins are sh scripts on a colon-joined PATH, which CreateProcess cannot run, so those three cases skip on win32. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (pass 1) Twelve informational findings from the /ship pass-1 review, all below the blocking floor, fixed in place: - docs-caps reads docs.caps from origin/<base>'s policy (--base <ref>), never the branch's copy; an unavailable base policy refuses with POLICY_SOURCE_UNAVAILABLE instead of substituting DEFAULT_POLICY - receiptVersion returns "none" only when the stamp file is absent; other errors surface as undefined - checkReceiptProse groups counters by leaf key and uses word boundaries that cover hyphenated names, so shared leaf keys and hyphenated words no longer report RECEIPT_PROSE_MISMATCH - gstack-coauthor-trailers refuses a --range/--base starting with "-", prefixes origin/ when origin/<ref> resolves (slash-named branches), and passes --end-of-options to git log - REVIEW_SCOPE_KEY_VERSION and DOCS_CAPS_KEY_VERSION name the releases that first read their keys - the Step 11 late-defer row logs under skill review-late-defer so a tokenless review row never reads UNVERIFIED; summarizeReviewLoop counts both - the "already filed" literal is one constant shared by bin and renderer - receiptDocs (dead) removed - Step 14.5 clears .gstack/tmp/docs-audit.json on first entry - dispatched review prompts carry a literal diff-base sha (<diff-base>) instead of a shell variable the reviewer process never sees - the coauthor-trailers tests launch the bin through runScriptSync so the Windows lane can run them Tests extended for each change; SKILL.md, sections and goldens regenerated. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: cover the carry patch-id refusal (Step 7 coverage gap) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: derive the too-old review_scope minimum from the constant Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep co-author trailers in one trailer block gstack-coauthor-trailers --message appended the new Co-authored-by lines as a separate paragraph after existing trailers, so git interpret-trailers (and GitHub attribution) read only the last paragraph and the existing co-author lost credit. The new lines now join the existing trailer block; the test checks the result with git interpret-trailers --parse. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: let git place co-author trailers; name the docs key release gstack-coauthor-trailers --message now runs git interpret-trailers --in-place, so the appended lines join the existing trailer block whatever its shape (CRLF, comment lines, folded continuations) and the existing co-author keeps attribution; the interpret-trailers check in the test carries a timeout for the spawnSync tripwire. DOCS_CAPS_KEY_VERSION names the release after the newest CHANGELOG heading on main (1.91.258.0), and a test ties every unreleased policy key to that next release so a stamp elsewhere fails loudly. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: hold unreleased policy keys newer than any visible heading; pin trailer placement The CHANGELOG-heading test asked for the exact next release after the newest heading, which a depth-1 CI clone (no origin/main) computes from the branch alone, so it went red there. It now requires an unreleased key's version to be newer than every heading the checkout can see, which holds at depth 1, on the stamped train tree and on main; the ship-policy comment says who moves the constant when the stamp lands under another number. gstack-coauthor-trailers pins git interpret-trailers' placement on the command line (--no-divider so a --- body line is not a divider, --where end, --if-exists addIfDifferentNeighbor, trailer.separators=:, -- before the path) so a user's trailer.* config cannot replace or drop the existing co-author. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: describe the shipped contracts (Step 13 and 14.5) CHANGELOG [Unreleased]: docs-caps --base <base> reading origin/<base>'s policy, the review-late-defer row, the literal <diff-base> prompt rule, the coauthor-trailers placement and refusals, the policy key versions (review_scope 1.91.256.0 re-pin, docs.caps at the stamping release), the version-less conditions split between Step 12 and the receipt, and the carry refusal wording. docs/ship-policy.md, docs/review-policy.md and docs/unattended.md follow the code: docs-caps --base, the literal diff-base sha, the trailer block, the gstack-outside-voice run binding and the Step 11 row fields. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: scope the literal diff-base claim to the review-army prompts; name where the outside-voice cause lives Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): declare Step 14.5's own-tree commands to the fixture; exclude .gstack/tmp at the Entry The ship-docsync-completion and ship-docsync-current paid cases failed twice at775d9804: Step 14.5's continue path now runs gstack-ship-receipt docs-caps and writes .gstack/tmp/docs-audit.json, and the docsync fixture's closed interface declared neither, while its repository had no origin/main for docs-caps to read. The actor stopped correctly (blocked, no exception) and never reached the publication stand-in. - test/helpers/docsync-interface.ts: the three housekeeping commands (the shared exclude line, rm -f of the record, docs-caps --base main) and the record write are declared, byte for byte with the generated section; DOCS_AUDIT_RECORD_PATHS names what the kernel observer may see. - test/helpers/docsync-observer.ts: accepts exactly those commands and the record write; every neighbour (another base, --json, write --docs, another .gstack file) stays outside the interface. - test/helpers/docsync-fixture.ts: every scenario pushes main to the fixture remote, as Steps 0-14 would have. - ship/sections/documentation.md.tmpl: the Entry runs the shared .gstack/tmp exclude line before rm -f, so the record never surfaces as an untracked file when no earlier step added it; the caps paragraph tightened to hold the ship parity ratio at 1.7400. - test/docsync-command-grammar.test.ts: pins the literals against the generated section and the refusals around them. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): the receipt record is housekeeping for read-only audits and the fault cases too Pass 9's outside voice found two gaps in the fixture change (2524ec4): a read-only audit (ship-docsync-current) must still write .gstack/tmp/docs-audit.json, but docsToolFailures flagged every product write under readOnly before the record allowance; and the unseeded fault cases (missing-asset, legacy-completion) run the Entry too, so their kernel-write check saw .git/info/exclude as a forbidden write because only the lifecycle test named the housekeeping paths. - docsToolFailures: the record write is permitted under readOnly; the document and every other product file stay refused. - docsWriteFailures: DOCS_AUDIT_RECORD_PATHS are permitted for every caller, so the fault evaluator needs no per-scenario list; anything else under .git or .gstack stays forbidden. - test/docsync-command-grammar.test.ts pins both: the record under readOnly, the document refused there, the observed housekeeping paths accepted with an empty allowance and two neighbours refused. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(docsync): accept the cap gate's ~/.claude/skills/gstack form the section prints (pass 9 Red Team note) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(docsync): name the admitted composed line precisely (pass 9 maintainability note) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): install lib/ beside bin/ in the fixture so the declared cap gate can load (2524ec4rerun: module error, not a verdict) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): admit the Write tool's temp sibling of the receipt record (0230fc2rerun: both lifecycle cases red on it) The paid rerun at0230fc2cleared every earlier refusal and both cases then failed on one path: forbidden docs write: .gstack/tmp/docs-audit.json.tmp.<pid>.<12 hex>. Claude Code's Write and Edit tools land every file, new ones included, through that sibling plus fsync and rename, and the fixture's kernel observer proved such a landing for the document only (atomicTargets: [DOC_PATH]). The observer now treats the record's sibling as a transient file too, and docsWriteFailures admits it only as the cookie-paired MOVED_FROM source of a MOVED_TO on the record whose other events are create/modify/attrib/close_write and which is left in neither snapshot nor in changed. A lingering sibling, an unpaired move, a move onto another path or a sibling of the document moved onto the record stay forbidden (grammar test). A live check on this machine saw the second landing's create/modify/close_write/moved_from events admitted and a stray sibling refused. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
361 lines
25 KiB
TypeScript
361 lines
25 KiB
TypeScript
/**
|
|
* Exercised-path consumer map (W2-A2, shadow mode): edge classes on a
|
|
* synthetic tree, the five variant-c miss shapes as negative controls,
|
|
* union-only refreshes, the refresh contract on unavailable or partial input,
|
|
* shadow-only map data selecting nothing, shadow output that never changes the
|
|
* real selection, MAP_GAP detection, and parity with the
|
|
* measured prototype (docs/TESTING_INTERNALS.md#exercised-path-map).
|
|
*/
|
|
import { describe, expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
import { spawnSync } from 'node:child_process';
|
|
import {
|
|
deriveDependencies, EXERCISED_MAP_PATH, exercisedConsumers, parseExercisedMap, type ExercisedMap,
|
|
} from '../scripts/pr-dependencies';
|
|
import {
|
|
formatPrCoverageSummary, PR_FULL_GATE_FILES, PR_PROFILE_MAPS, selectPrProfile,
|
|
} from '../scripts/test-pr-profile';
|
|
import {
|
|
attributeCommands, blindCases, formatExercisedMap, formatMapGap, formatShadowReplay, mapGaps, mergeExercisedMap, observeRun, readCaseCosts, readShardCommands,
|
|
REFRESH_EXIT, RefreshError, refreshFromReportDirs, refreshFromRun, REPLAY_FIXTURE, replayShadow, type ArtifactDownload, type ReplayRun,
|
|
} from '../scripts/exercised-map';
|
|
import { reportMapGaps } from '../scripts/lib/paid-report';
|
|
import { computePaidCaseSelection } from '../scripts/test-paid-shards';
|
|
import { prototypeConsumers } from './helpers/exercised-prototype';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
function fixtureRepo(files: Record<string, string>): string {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-map-'));
|
|
for (const [file, text] of Object.entries(files)) {
|
|
fs.mkdirSync(path.dirname(path.join(root, file)), { recursive: true });
|
|
fs.writeFileSync(path.join(root, file), text);
|
|
}
|
|
for (const args of [['init', '-q'], ['add', '-A']]) {
|
|
const result = spawnSync('git', args, { cwd: root, encoding: 'utf8', timeout: 10_000 });
|
|
if (result.status !== 0) throw new Error(`git ${args[0]} failed: ${result.stderr}`);
|
|
}
|
|
return root;
|
|
}
|
|
|
|
const map = (cases: ExercisedMap['cases'], sourceRuns = ['1'], observedThrough = '2026-10-01T00:00:00Z'): ExercisedMap =>
|
|
({ schema: 1, generatedAt: observedThrough, observedThrough, sourceRuns, cases });
|
|
|
|
const FENCE = '```';
|
|
const skill = [
|
|
'# alpha', '', 'Prose naming gstack-prose and /gstack-slash is not run.', '', FENCE + 'bash',
|
|
'gstack-start --quiet',
|
|
'echo "see gstack-echoed for details"',
|
|
'echo "now $(gstack-subst --print)"',
|
|
'# gstack-commented',
|
|
'case "$x" in gstack-casepat) true ;; esac',
|
|
'VAR=gstack-bare',
|
|
'"$ROOT/bin/gstack-pathed" run',
|
|
'. "$ROOT/lib/sourced.sh"',
|
|
"cat <<'EOF'", 'gstack-quoted-heredoc', 'EOF',
|
|
'cat <<EOF', '$(gstack-expanding)', 'gstack-heredoc-prose', 'EOF',
|
|
"bash <<'EOF'", 'gstack-interp', 'EOF',
|
|
'$B goto https://example.com',
|
|
'bun run build-thing',
|
|
'./setup --quiet',
|
|
FENCE, '',
|
|
].join('\n');
|
|
const bins = ['echoed', 'subst', 'commented', 'casepat', 'bare', 'pathed', 'quoted-heredoc', 'expanding', 'heredoc-prose', 'interp', 'prose', 'slash', 'observed', 'gapper'];
|
|
const tree = {
|
|
'test/skill-e2e-alpha.test.ts': "import './helpers/h';\n",
|
|
'test/helpers/h.ts': "const a = path.join(ROOT, 'lib', 'joined.ts');\nconst b = 'lib/quoted.ts';\nexport { a, b };\n",
|
|
'lib/joined.ts': '', 'lib/quoted.ts': '', 'lib/deep.ts': '', 'lib/sourced.sh': '#!/bin/sh\n', 'lib/unreached.ts': '',
|
|
'alpha/SKILL.md.tmpl': skill,
|
|
'bin/gstack-start': '#!/usr/bin/env bash\ngstack-helper "$@"\n',
|
|
'bin/gstack-helper': "#!/usr/bin/env bun\nimport '../lib/deep';\n",
|
|
'bin/gstack-config': '#!/usr/bin/env bash\necho config\n',
|
|
...Object.fromEntries(bins.map(name => [`bin/gstack-${name}`, '#!/bin/sh\n'])),
|
|
'test/skill-e2e-beta.test.ts': '', 'test/skill-e2e-gamma.test.ts': '', 'test/skill-e2e-delta.test.ts': '',
|
|
'gamma/SKILL.md.tmpl': `# gamma\n\n${FENCE}bash\ngstack-config get proactive\n${FENCE}\n`,
|
|
'scripts/build.sh': 'bun build --compile browse/src/cli.ts --outfile browse/dist/browse\n', 'browse/src/cli.ts': "import './page';\n", 'browse/src/page.ts': '',
|
|
'scripts/thing.ts': '', 'scripts/resolvers/index.ts': '', 'setup': '#!/usr/bin/env bash\n',
|
|
'package.json': JSON.stringify({ scripts: { 'build-thing': 'bun run scripts/thing.ts' } }),
|
|
};
|
|
const maps = {
|
|
e2eTouchfiles: {
|
|
alpha: ['test/skill-e2e-alpha.test.ts', 'alpha/**'], beta: ['test/skill-e2e-beta.test.ts'],
|
|
gamma: ['test/skill-e2e-gamma.test.ts', 'gamma/**'], delta: ['test/skill-e2e-delta.test.ts', 'bin/gstack-config', 'lib/deep.ts'],
|
|
},
|
|
judgeTouchfiles: {}, globalTouchfiles: [] as string[],
|
|
};
|
|
const profileMaps = { ...maps, tiers: { alpha: 'gate', beta: 'gate', gamma: 'gate', delta: 'gate' } as const };
|
|
const observed = map({ beta: { observations: 3, withCommands: 2, commands: ['bin/gstack-observed'], costUsd: 2, costRuns: 3 },
|
|
alpha: { observations: 4, withCommands: 4, commands: [], costUsd: 5, costRuns: 4 }, gamma: { observations: 2, withCommands: 0, commands: [] } });
|
|
|
|
describe('exercised consumers on a synthetic tree', () => {
|
|
const root = fixtureRepo(tree);
|
|
const ex = exercisedConsumers(maps, root, { observed, stopAt: ['setup'] });
|
|
const alpha = ex.closure('alpha');
|
|
|
|
test('each kept edge class reaches its file, with its provenance', () => {
|
|
expect(alpha.get('alpha/SKILL.md.tmpl')).toBe('touchfile');
|
|
expect(alpha.get('bin/gstack-start')).toBe('skill bash via bin/gstack-start');
|
|
expect(alpha.get('lib/deep.ts')).toBe('skill bash via bin/gstack-start');
|
|
expect(alpha.get('lib/joined.ts')).toBe('import');
|
|
expect(alpha.get('lib/quoted.ts')).toBe('import');
|
|
for (const file of ['bin/gstack-subst', 'bin/gstack-pathed', 'lib/sourced.sh', 'bin/gstack-expanding', 'bin/gstack-interp', 'browse/src/page.ts', 'scripts/thing.ts', 'setup']) {
|
|
expect(alpha.has(file), file).toBe(true);
|
|
}
|
|
expect(ex.closure('beta').get('bin/gstack-observed')).toBe('observed bin/gstack-observed');
|
|
});
|
|
|
|
test('messages, comments, case patterns, bare assignments, quoted and expanded heredoc prose, prose and slash commands are not edges', () => {
|
|
for (const name of ['echoed', 'commented', 'casepat', 'bare', 'quoted-heredoc', 'heredoc-prose', 'prose', 'slash']) {
|
|
expect(alpha.has(`bin/gstack-${name}`), name).toBe(false);
|
|
}
|
|
expect(ex.e2e.get('lib/unreached.ts')).toBeUndefined();
|
|
});
|
|
|
|
test('the closure stops at a full-gate file and at the global set', () => {
|
|
const stopped = exercisedConsumers({ ...maps, globalTouchfiles: ['bin/gstack-start'] }, fixtureRepo(tree), { observed, stopAt: ['setup'] });
|
|
expect(stopped.closure('alpha').has('bin/gstack-start')).toBe(true);
|
|
expect(stopped.closure('alpha').has('lib/deep.ts')).toBe(false);
|
|
});
|
|
|
|
test('bins in recorded commands: paths, bare names, PTY lines and compiled outfiles', () => {
|
|
expect(ex.binsInCommand('gstack-start --x && "$B" goto y')).toEqual(['bin/gstack-start', 'browse/dist/browse']);
|
|
expect(ex.binsInCommand('PTY:gstack-config-get proactive')).toEqual(['bin/gstack-config']);
|
|
expect(ex.binsInCommand('"$ROOT/bin/gstack-start" --x')).toEqual(['bin/gstack-start']);
|
|
expect(ex.binsInCommand('run /gstack-start next')).toEqual([]);
|
|
expect(ex.commandFiles('browse/dist/browse').sort()).toEqual(['browse/src/cli.ts', 'browse/src/page.ts']);
|
|
});
|
|
|
|
test('the variant-c miss shapes stay selected in the shadow (negative controls)', () => {
|
|
const shadow = (changedFiles: string[], selectedE2E: string[]) => selectPrProfile({
|
|
maps: profileMaps, profile: ['alpha', 'beta', 'gamma', 'delta'], selectedE2E, selectedJudges: [], changedFiles,
|
|
derived: deriveDependencies(maps, root), exercised: ex,
|
|
}).shadow!;
|
|
// A preamble hub a touchfile maps only for another case (skill-start/end x3; gstack-config for the PTY case with no observations).
|
|
expect(shadow(['bin/gstack-config'], ['delta']).e2e).toEqual(['delta', 'gamma']);
|
|
expect(observed.cases.gamma!.withCommands).toBe(0);
|
|
// A lib reached only through a bin the skill runs (redact-patterns via gstack-redact).
|
|
expect(shadow(['lib/deep.ts'], ['delta']).e2e).toEqual(['alpha', 'delta']);
|
|
expect(shadow(['lib/deep.ts'], ['delta']).provenance).toEqual([{ file: 'lib/deep.ts', summary: 'selects 2 case(s): skill bash via bin/gstack-start (1), touchfile (1)' }]);
|
|
});
|
|
});
|
|
|
|
describe('the five recorded variant-c misses on this checkout', () => {
|
|
const shadowOf = (file: string) => computePaidCaseSelection({ profile: 'pr', env: {}, changedFiles: [file], packageVersionOnly: true }).coverage!.shadow!;
|
|
|
|
test('skill-start reds stay in the shadow of a gstack-skill-start change', () => {
|
|
const shadow = shadowOf('bin/gstack-skill-start');
|
|
expect(shadow.error).toBeUndefined();
|
|
for (const id of ['qa-functional-webhook-fix', 'qa-functional-cli-report', 'ship-exploratory-plan-checks']) expect(shadow.e2e, id).toContain(id);
|
|
}, 60_000);
|
|
|
|
test('gstack-config reaches the PTY case that records no commands; redact-patterns reaches ship-docsync-store', () => {
|
|
expect(shadowOf('bin/gstack-config').e2e).toContain('plan-mode-no-op');
|
|
const committed = parseExercisedMap(fs.readFileSync(path.join(ROOT, EXERCISED_MAP_PATH), 'utf8'));
|
|
const ex = exercisedConsumers(PR_PROFILE_MAPS, ROOT, { observed: committed, stopAt: PR_FULL_GATE_FILES });
|
|
expect(ex.closure('plan-mode-no-op').get('bin/gstack-config')).toStartWith('skill bash via');
|
|
expect(ex.closure('ship-docsync-store').has('lib/redact-patterns.ts')).toBe(true);
|
|
}, 60_000);
|
|
});
|
|
|
|
describe('shadow output never changes the real selection', () => {
|
|
test('mode, cases, judges and reasons equal the selection without a shadow', () => {
|
|
for (const files of [['bin/gstack-config'], ['design/src/evolve.ts'], ['review/SKILL.md.tmpl'], ['lib/fs-utils.ts', 'docs/x.md'], ['ETHOS.md']]) {
|
|
const withShadow = selectPrProfile({ selectedE2E: [], selectedJudges: [], changedFiles: files });
|
|
const without = selectPrProfile({ selectedE2E: [], selectedJudges: [], changedFiles: files, exercised: null });
|
|
expect(withShadow.shadow, files.join()).toBeDefined();
|
|
const { shadow, ...rest } = withShadow;
|
|
expect(rest, files.join()).toEqual(without);
|
|
if (withShadow.mode === 'full-fallback') expect(shadow!.e2e).toEqual(withShadow.e2e);
|
|
}
|
|
}, 60_000);
|
|
|
|
test('the coverage summary prints one shadow line; a broken map is reported, not fatal', () => {
|
|
const result = computePaidCaseSelection({ profile: 'pr', env: {}, changedFiles: ['design/src/evolve.ts'], packageVersionOnly: true });
|
|
const lines = formatPrCoverageSummary({ profile: 'pr', selection: result.selection, prCoverage: result.coverage });
|
|
expect(lines.filter(line => line.includes('Shadow exercised-path map (not active)'))).toHaveLength(1);
|
|
const broken = selectPrProfile({ selectedE2E: [], selectedJudges: [], changedFiles: ['design/src/evolve.ts'], exercised: null });
|
|
expect(formatPrCoverageSummary({ prCoverage: { ...broken, shadow: { e2e: broken.e2e, wouldDrop: [], wouldAdd: [], provenance: [], predictedSavingUsd: 0, unpricedCases: 0, unknownCostShare: 0, error: 'bad map' } } })
|
|
.some(line => line.includes('unavailable (bad map); selection unaffected'))).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('union-only refreshes', () => {
|
|
const base = map({ a: { observations: 2, withCommands: 1, commands: ['bin/x'], costUsd: 4, costRuns: 2 } }, ['1']);
|
|
|
|
test('disjoint branches merge to the same union in either order, and nothing is removed', () => {
|
|
const left = map({ a: { observations: 1, withCommands: 1, commands: ['bin/y'] } }, ['2'], '2026-10-02T00:00:00Z');
|
|
const right = map({ b: { observations: 1, withCommands: 1, commands: ['bin/z'], costUsd: 1, costRuns: 1 } }, ['3'], '2026-10-03T00:00:00Z');
|
|
const one = mergeExercisedMap(mergeExercisedMap(base, left, 't'), right, 't');
|
|
const two = mergeExercisedMap(mergeExercisedMap(base, right, 't'), left, 't');
|
|
expect(one).toEqual(two);
|
|
expect(one.cases.a!.commands).toEqual(['bin/x', 'bin/y']);
|
|
expect(one.cases.b!.commands).toEqual(['bin/z']);
|
|
expect(one.sourceRuns).toEqual(['1', '2', '3']);
|
|
expect(one.observedThrough).toBe('2026-10-03T00:00:00Z');
|
|
expect(one.cases.a!.costUsd).toBe(4);
|
|
});
|
|
|
|
test('empty or missing artifacts never erase consumers, and a run already merged is not counted twice', () => {
|
|
expect(mergeExercisedMap(base, map({}, ['9']), 't').cases).toEqual(base.cases);
|
|
expect(mergeExercisedMap(base, map({ a: { observations: 1, withCommands: 0, commands: [] } }, ['9']), 't').cases.a!.commands).toEqual(['bin/x']);
|
|
expect(mergeExercisedMap(base, map({ a: { observations: 5, withCommands: 5, commands: ['bin/x'], costUsd: 9, costRuns: 1 } }, ['1']), 't').cases.a)
|
|
.toEqual(base.cases.a!);
|
|
const costed = mergeExercisedMap(base, map({ a: { observations: 1, withCommands: 1, commands: [], costUsd: 7, costRuns: 1 } }, ['4']), 't');
|
|
expect(costed.cases.a).toMatchObject({ observations: 3, costUsd: 5, costRuns: 3 });
|
|
expect(parseExercisedMap(formatExercisedMap(costed))).toEqual(costed);
|
|
});
|
|
});
|
|
|
|
describe('shadow-only map data', () => {
|
|
test('a map-only diff selects no paid case and says why', () => {
|
|
const selection = selectPrProfile({ selectedE2E: [], selectedJudges: [], changedFiles: [EXERCISED_MAP_PATH] });
|
|
expect(selection).toMatchObject({ mode: 'pr', e2e: [], judges: [], unknownFiles: [], derivedFiles: [], noConsumerFiles: [] });
|
|
expect(selection.shadow!.e2e).toEqual([]);
|
|
expect(selection.reasons).toContain(`${EXERCISED_MAP_PATH} is shadow-only data (it changes no selection yet), so it selects no paid case (docs/TESTING_INTERNALS.md#exercised-path-map)`);
|
|
const plan = computePaidCaseSelection({ profile: 'pr', env: {}, changedFiles: [EXERCISED_MAP_PATH, 'package.json'], packageVersionOnly: true });
|
|
expect(plan.selection.e2e).toEqual([]);
|
|
expect(plan.selection.judges).toEqual([]);
|
|
}, 60_000);
|
|
});
|
|
|
|
describe('refresh contract: unavailable or partial input writes nothing', () => {
|
|
const root = fixtureRepo(tree);
|
|
const ex = exercisedConsumers(maps, root, { observed, stopAt: ['setup'] });
|
|
const report = (files: Record<string, string>) => {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-refresh-'));
|
|
for (const [file, text] of Object.entries(files)) { fs.mkdirSync(path.dirname(path.join(dir, file)), { recursive: true }); fs.writeFileSync(path.join(dir, file), text); }
|
|
return dir;
|
|
};
|
|
const outcome = (id: string) => JSON.stringify({ case: id, execution: 'executed', cost_usd: 1 });
|
|
const shard = { 'paid-slice-1-a1/shards/skill-e2e-beta/junit.xml': '<testsuite><testcase name="beta"/></testsuite>' };
|
|
const code = (run: () => unknown) => { try { run(); return 0; } catch (error) { return error instanceof RefreshError ? error.exitCode : -1; } };
|
|
|
|
test('report directories: missing is unavailable; no shards, no trial outcomes or an executed case without a shard is incomplete', () => {
|
|
expect(code(() => refreshFromReportDirs([path.join(os.tmpdir(), 'no-such-census-dir')], '1', observed, ex, 't', profileMaps))).toBe(REFRESH_EXIT.unavailable);
|
|
expect(code(() => refreshFromReportDirs([report({ 'trial-outcomes.jsonl': outcome('beta') })], '1', observed, ex, 't', profileMaps))).toBe(REFRESH_EXIT.incomplete);
|
|
expect(code(() => refreshFromReportDirs([report(shard)], '1', observed, ex, 't', profileMaps))).toBe(REFRESH_EXIT.incomplete);
|
|
expect(() => refreshFromReportDirs([report({ ...shard, 'trial-outcomes.jsonl': `${outcome('beta')}\n${outcome('alpha')}` })], '1', observed, ex, 't', profileMaps))
|
|
.toThrow('1 executed case(s) have no shard artifact: alpha');
|
|
const { merged } = refreshFromReportDirs([report({ ...shard, 'trial-outcomes.jsonl': outcome('beta') })], '9', observed, ex, 't', profileMaps);
|
|
expect(merged.sourceRuns).toEqual(['1', '9']);
|
|
expect(merged.cases.beta!.observations).toBe(4);
|
|
});
|
|
|
|
test('--from-run: a 403, a missing map or a malformed map leaves the target byte-identical; a complete artifact is unioned', () => {
|
|
const target = path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-target-')), 'exercised-commands.json');
|
|
fs.writeFileSync(target, formatExercisedMap(observed));
|
|
const before = fs.readFileSync(target, 'utf8');
|
|
const artifact = (files: Record<string, string>): ArtifactDownload => (_runId, dir) => {
|
|
for (const [file, text] of Object.entries(files)) { fs.mkdirSync(path.dirname(path.join(dir, file)), { recursive: true }); fs.writeFileSync(path.join(dir, file), text); }
|
|
return { status: 0, stderr: '' };
|
|
};
|
|
let forbidden: unknown;
|
|
try { refreshFromRun('42', target, () => ({ status: 1, stderr: 'HTTP 403: Resource not accessible by integration' })); } catch (error) { forbidden = error; }
|
|
expect(forbidden).toBeInstanceOf(RefreshError);
|
|
expect((forbidden as RefreshError).exitCode).toBe(REFRESH_EXIT.unavailable);
|
|
expect((forbidden as Error).message).toContain('pass its directory with --from-dir');
|
|
expect(code(() => refreshFromRun('42', target, artifact({ 'exercised-map-a1/report.md': 'x' })))).toBe(REFRESH_EXIT.incomplete);
|
|
expect(code(() => refreshFromRun('42', target, artifact({ 'exercised-map-a1/exercised-commands.json': '{"schema":1,"cases":' })))).toBe(REFRESH_EXIT.incomplete);
|
|
expect(code(() => refreshFromRun('42', target, artifact({ 'exercised-map-a1/exercised-commands.json': formatExercisedMap(map({}, ['5'])), 'exercised-map-a2/exercised-commands.json': '{}' })))).toBe(REFRESH_EXIT.incomplete);
|
|
expect(code(() => refreshFromRun('not-a-run', target))).toBe(REFRESH_EXIT.unavailable);
|
|
expect(fs.readFileSync(target, 'utf8')).toBe(before);
|
|
const fresh = map({ beta: { observations: 1, withCommands: 1, commands: ['bin/gstack-new'] } }, ['5'], '2026-10-09T00:00:00Z');
|
|
refreshFromRun('5', target, artifact({ 'exercised-map-a1/exercised-commands.json': formatExercisedMap(fresh) }));
|
|
const after = parseExercisedMap(fs.readFileSync(target, 'utf8'));
|
|
expect(after.cases.beta!.commands).toEqual(['bin/gstack-new', 'bin/gstack-observed']);
|
|
expect(after.sourceRuns).toEqual(['1', '5']);
|
|
});
|
|
|
|
test('the CLI exits 2 on usage and 3 on a missing report directory, writing nothing', () => {
|
|
const out = path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-cli-')), 'map.json');
|
|
const cli = (args: string[]) => spawnSync('bun', ['run', path.join(ROOT, 'scripts/exercised-map.ts'), ...args], { cwd: ROOT, encoding: 'utf8', timeout: 60_000 });
|
|
expect(cli([]).status).toBe(REFRESH_EXIT.usage);
|
|
const missing = cli(['--from-dir', path.join(os.tmpdir(), 'no-such-census-dir'), '--run-id', '1', '--out', out]);
|
|
expect(missing.status).toBe(REFRESH_EXIT.unavailable);
|
|
expect(missing.stderr).toContain('nothing was written, the committed union is unchanged');
|
|
expect(fs.existsSync(out)).toBe(false);
|
|
}, 90_000);
|
|
});
|
|
|
|
describe('recorded commands and MAP_GAP', () => {
|
|
const root = fixtureRepo(tree);
|
|
const ex = exercisedConsumers(maps, root, { observed, stopAt: ['setup'] });
|
|
const report = fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-report-'));
|
|
const write = (file: string, text: string) => { fs.mkdirSync(path.dirname(path.join(report, file)), { recursive: true }); fs.writeFileSync(path.join(report, file), text); };
|
|
write('paid-slice-1-a1/shards/skill-e2e-alpha--alpha.t1/result.json', JSON.stringify({ tests: [{ name: 'alpha', transcript: [{ type: 'tool_use', input: { command: 'gstack-start && $B goto x' } }] }] }));
|
|
write('paid-slice-1-a1/shards/skill-e2e-beta/junit.xml', '<testsuite><testcase name="beta"/></testsuite>');
|
|
write('paid-slice-1-a1/shards/skill-e2e-beta/session.jsonl', `${JSON.stringify({ type: 'tool_use', input: { command: 'bin/gstack-gapper --x' } })}\n`);
|
|
write('paid-slice-1-a1/shards/skill-e2e-gamma/junit.xml', '<testsuite><testcase name="gamma"/></testsuite>');
|
|
write('paid-slice-1-a1/trial-outcomes.jsonl', [{ case: 'alpha', execution: 'executed', cost_usd: 1.5 }, { case: 'alpha', execution: 'executed', cost_usd: 0, cost_known: false }, { case: 'beta', execution: 'reused', cost_usd: 3 }].map(record => JSON.stringify(record)).join('\n'));
|
|
|
|
test('commands are read per shard and attributed to their cases', () => {
|
|
const commands = attributeCommands(readShardCommands(report), profileMaps);
|
|
expect(commands.get('alpha')).toEqual(['gstack-start && $B goto x']);
|
|
expect(commands.get('beta')).toEqual(['bin/gstack-gapper --x']);
|
|
expect(commands.get('gamma')).toEqual([]);
|
|
expect(observeRun(commands, ex, { runId: '7', observedAt: 't', costs: readCaseCosts(report) }).cases.alpha)
|
|
.toEqual({ observations: 1, withCommands: 1, commands: ['bin/gstack-start', 'browse/dist/browse'], costUsd: 1.5, costRuns: 1 });
|
|
});
|
|
|
|
test('a command outside the static-plus-observed closure is a MAP_GAP; a skill-running case with no commands is blind', () => {
|
|
const commands = attributeCommands(readShardCommands(report), profileMaps);
|
|
expect(mapGaps(commands, ex)).toEqual([{ id: 'beta', command: 'bin/gstack-gapper' }]);
|
|
expect(blindCases(commands, ex)).toEqual(['gamma']);
|
|
});
|
|
|
|
test('the paid report writes MAP_GAP lines without failing, and an unreadable checkout degrades to unavailable', () => {
|
|
const live = fs.mkdtempSync(path.join(os.tmpdir(), 'exercised-live-'));
|
|
const committed = parseExercisedMap(fs.readFileSync(path.join(ROOT, EXERCISED_MAP_PATH), 'utf8'));
|
|
const ex = exercisedConsumers(PR_PROFILE_MAPS, ROOT, { observed: committed, stopAt: PR_FULL_GATE_FILES });
|
|
const outside = fs.readdirSync(path.join(ROOT, 'bin')).map(name => `bin/${name}`).find(file => /^bin\/gstack-[a-z-]+$/.test(file) && !ex.closure('ship-docsync-store').has(file))!;
|
|
fs.mkdirSync(path.join(live, 'paid-slice-2-a1/shards/skill-e2e-ship-docsync--ship-docsync-store.t1'), { recursive: true });
|
|
fs.writeFileSync(path.join(live, 'paid-slice-2-a1/shards/skill-e2e-ship-docsync--ship-docsync-store.t1/r.json'),
|
|
JSON.stringify({ tests: [{ name: 'ship-docsync-store', transcript: [{ type: 'tool_use', input: { command: `${path.basename(outside)} --help` } }] }] }));
|
|
const line = `MAP_GAP ship-docsync-store ${outside}: non-blocking for this PR; the next census refresh widens the map (docs/TESTING_INTERNALS.md#exercised-path-map)`;
|
|
expect(formatMapGap({ id: 'ship-docsync-store', command: outside })).toBe(line);
|
|
expect(reportMapGaps(live, new Set(['ship-docsync-store']), ROOT)).toEqual([line]);
|
|
expect(fs.readFileSync(path.join(live, 'map-gaps.txt'), 'utf8')).toBe(`${line}\n`);
|
|
expect(reportMapGaps(live, new Set(['ship-docsync-store']), path.join(live, 'no-checkout'))).toEqual([]);
|
|
expect(fs.readFileSync(path.join(live, 'map-gaps.txt'), 'utf8')).toStartWith('MAP_GAP unavailable:');
|
|
}, 60_000);
|
|
});
|
|
|
|
describe('parity with the measured prototype', () => {
|
|
/** Files the shipped function reaches beyond the prototype, each with the reviewed edge class behind it. */
|
|
const REVIEWED_SUPERSET: Record<string, string> = {
|
|
setup: './setup, $ROOT/setup and join(..., "setup") exec edges (plan A2-2); setup is a full-gate file, so the closure stops there',
|
|
'lib/bun-isolation.ts': 'GSTA-56: every bun launcher (script-invocation, restamp, qa-deadline, the hooks) imports it, so it reaches every consumer of those launchers',
|
|
'lib/ship-receipt-docs.ts': 'bin/gstack-ship-receipt imports it (the docs audit record and doc caps), so it reaches every consumer of the receipt binary',
|
|
'lib/ship-receipt-prose.ts': 'bin/gstack-ship-receipt imports it (read --check-prose), so it reaches every consumer of the receipt binary',
|
|
};
|
|
|
|
test('the shipped map equals or is a reviewed superset of the prototype map on this checkout', () => {
|
|
const committed = parseExercisedMap(fs.readFileSync(path.join(ROOT, EXERCISED_MAP_PATH), 'utf8'));
|
|
const prototype = prototypeConsumers(PR_PROFILE_MAPS, ROOT, committed, PR_FULL_GATE_FILES);
|
|
const shipped = exercisedConsumers(PR_PROFILE_MAPS, ROOT, { observed: committed, stopAt: PR_FULL_GATE_FILES });
|
|
const missing = [...prototype].flatMap(([file, ids]) => [...ids].filter(id => !shipped.e2e.get(file)?.has(id)).map(id => `${file} ${id}`));
|
|
expect(missing).toEqual([]);
|
|
const unreviewed = [...new Set([...shipped.e2e].filter(([file, ids]) => [...ids].some(id => !prototype.get(file)?.has(id))).map(([file]) => file))]
|
|
.filter(file => !Object.hasOwn(REVIEWED_SUPERSET, file));
|
|
expect(unreviewed.map(file => `${file}: reached beyond the prototype; review the edge class and add it to REVIEWED_SUPERSET with its reason`)).toEqual([]);
|
|
}, 60_000);
|
|
});
|
|
|
|
describe('replay of the recorded red PR runs', () => {
|
|
test('every recorded failed gate case stays in the shadow selection (the PR receipt: bun run test:exercised-map --replay)', () => {
|
|
const fixture = JSON.parse(fs.readFileSync(path.join(ROOT, REPLAY_FIXTURE), 'utf8')) as { failedGateCases: number; runs: ReplayRun[] };
|
|
expect(fixture.runs.reduce((sum, run) => sum + run.failedGateCases.length, 0)).toBe(fixture.failedGateCases);
|
|
const rows = replayShadow(fixture.runs);
|
|
expect(rows.flatMap(row => row.misses.map(id => `${row.runId}:${id}`))).toEqual([]);
|
|
expect(formatShadowReplay(rows).at(-1)).toBe('- MISSES (failed, not in the shadow selection): 0');
|
|
}, 120_000);
|
|
|
|
test('a red the shadow drops is reported as a miss', () => {
|
|
const [row] = replayShadow([{ runId: 1, pr: 1, packageVersionOnly: true, failedGateCases: ['plan-mode-no-op'], changedFiles: ['docs/designs/x.md'] }]);
|
|
expect(row!.misses).toEqual(['plan-mode-no-op']);
|
|
expect(formatShadowReplay([row!]).slice(-2)).toEqual(['- MISSES (failed, not in the shadow selection): 1', ' - 1 #1 plan-mode-no-op']);
|
|
});
|
|
});
|