Garry Tan and Claude Fable 5
3e7251a2e6
fix(codex): sandbox the review path, fail the gate closed, order timeouts wrapper-first
...
Closes #2496 , #2524 , #2477 — three defects in the class "a guard that
reports success while doing nothing", all in codex/SKILL.md.tmpl:
(a) Review sandbox. The default `codex review` path was the only codex call
with no sandbox override, inheriting ~/.codex/config.toml's default — write
access on a trusted project — while Important Rules claimed read-only.
Top-level `codex review` has no -s/--sandbox flag (verified on 0.147.0), so
the invocation now pins `-c 'sandbox_mode="read-only"'`, the same form the
consult-resume path already uses.
(b) Fail-closed verdict gate. The old rule ("no [P1] found → PASS") could
not fail on the default path: native `codex review` output carries no
bracketed tags, and a non-zero exit, expired auth, timeout, or empty result
also contains no [P1] — all read as PASS. The gate is now an ordered,
fail-closed check: non-zero exit → FAIL; empty output → FAIL; [P0]/[P1]
(bracketed or codex's native labels) → FAIL with count; NO severity tags at
all → FAIL requiring a human read; PASS is only reachable through the
explicit tagged-advisory-only branch. [P0] is recognized as blocking, and
the review-log findings count includes it.
(c) Bash gate above the wrapper. Step 2A instructed `timeout: 300000` under
a 330s wrapper, and Challenge's 300s gate sat under a 600s wrapper — the
harness killed the call before the wrapper could emit its diagnosable
exit-124 message. Every Bash gate now sits strictly ABOVE its wrapper:
360000 over the 330s review wrapper, 660000 over the 600s challenge/consult
wrappers, with the ordering rationale stated at each site.
Also from #2477/#2524: a new Error Handling entry for the model-entitlement
400 ("The '<model>' model is not supported...") pointing at the `model =`
pin and `[notice.model_migrations]` in ~/.codex/config.toml and saying
exactly which override to retry with (-m for exec-based modes,
`-c model="..."` for review mode, which rejects -m); the Model & Reasoning
section no longer documents `-m` for `/codex review`.
Static assertions in test/codex-hardening.test.ts pin (a)-(c) across both
the .tmpl and the generated SKILL.md: every scoped review invocation carries
sandbox_mode="read-only" and never -s; the default-PASS sentence is banned
and the fail-closed branches are present; and per-section, every Bash
`timeout: N` is strictly greater than every wrapper budget, with 2A/2B/2C
all required to be inspected. Generated SKILL.md regenerated via
gen:skill-docs in this commit.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com >
2026-08-14 20:20:55 -07:00
..
2026-08-14 20:20:55 -07:00
2026-08-14 09:28:56 -07:00
2026-06-14 11:40:57 -07:00
2026-03-18 23:57:59 -05:00
2026-05-17 08:26:36 -07:00
2026-06-25 09:42:45 -07:00
2026-06-07 21:38:21 -07:00
2026-06-07 21:38:21 -07:00
2026-07-10 13:58:07 -07:00
2026-08-07 15:08:12 -07:00
2026-04-19 17:50:31 +08:00
2026-06-21 07:15:19 -07:00
2026-06-08 06:39:38 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-25 10:57:15 -07:00
2026-08-14 09:28:56 -07:00
2026-06-21 07:15:19 -07:00
2026-05-20 07:35:01 -07:00
2026-04-08 22:21:28 -10:00
2026-05-29 08:35:00 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-08-14 09:28:56 -07:00
2026-05-30 14:57:07 -07:00
2026-05-30 14:57:07 -07:00
2026-04-23 07:25:20 -07:00
2026-06-04 11:14:43 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 20:20:55 -07:00
2026-05-09 08:06:47 -07:00
2026-05-16 12:32:33 -07:00
2026-08-14 09:28:56 -07:00
2026-08-08 09:28:45 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-05-28 18:21:09 -07:00
2026-08-08 09:28:45 -07:00
2026-06-09 22:29:23 -07:00
2026-06-12 15:38:53 -07:00
2026-06-08 06:39:38 -07:00
2026-05-30 12:09:10 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-05-21 21:21:07 -07:00
2026-06-07 19:13:24 -07:00
2026-04-26 13:55:13 -07:00
2026-08-12 11:12:28 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 09:28:56 -07:00
2026-08-07 15:08:12 -07:00
2026-08-14 20:20:51 -07:00
2026-05-24 01:43:51 -07:00
2026-05-20 07:35:01 -07:00
2026-06-08 06:20:58 -07:00
2026-05-30 14:57:07 -07:00
2026-06-21 07:15:19 -07:00
2026-06-21 07:15:19 -07:00
2026-06-08 06:20:58 -07:00
2026-05-17 08:26:36 -07:00
2026-06-08 06:20:58 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-05-21 21:21:07 -07:00
2026-04-24 01:38:21 -07:00
2026-08-08 09:28:45 -07:00
2026-08-14 09:28:56 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 14:57:07 -07:00
2026-08-08 09:28:45 -07:00
2026-05-30 14:57:07 -07:00
2026-05-21 21:21:07 -07:00
2026-07-10 16:51:16 -07:00
2026-05-21 18:55:55 -07:00
2026-08-14 09:28:56 -07:00
2026-05-26 16:50:03 -07:00
2026-06-09 22:29:23 -07:00
2026-08-14 20:20:55 -07:00
2026-05-20 06:56:41 -07:00
2026-05-14 11:11:52 -04:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-05-28 18:21:09 -07:00
2026-05-30 08:54:46 -07:00
2026-06-08 06:20:58 -07:00
2026-06-08 06:20:58 -07:00
2026-06-08 06:20:58 -07:00
2026-06-14 11:40:57 -07:00
2026-08-08 09:28:45 -07:00
2026-08-14 09:28:56 -07:00
2026-08-08 09:28:45 -07:00
2026-08-14 09:28:56 -07:00
2026-04-28 01:17:54 -07:00
2026-05-20 07:35:01 -07:00
2026-06-08 06:39:38 -07:00
2026-07-14 12:56:09 -07:00
2026-08-14 20:20:52 -07:00
2026-05-25 10:57:15 -07:00
2026-05-20 07:35:01 -07:00
2026-06-21 07:15:19 -07:00
2026-08-08 09:28:45 -07:00
2026-05-30 08:54:46 -07:00
2026-07-10 03:09:13 -07:00
2026-05-29 08:35:00 -07:00
2026-06-07 21:38:21 -07:00
2026-05-28 18:21:09 -07:00
2026-08-14 20:20:53 -07:00
2026-06-02 22:36:34 -07:00
2026-05-28 18:21:09 -07:00
2026-08-14 15:35:04 -07:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-05-25 10:57:15 -07:00
2026-05-30 12:09:10 -07:00
2026-04-26 13:55:13 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 20:20:53 -07:00
2026-08-14 20:20:48 -07:00
2026-08-14 20:20:53 -07:00
2026-07-14 12:56:10 -07:00
2026-08-14 20:20:48 -07:00
2026-07-14 16:35:30 -07:00
2026-07-14 16:35:30 -07:00
2026-06-14 11:40:57 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 14:57:07 -07:00
2026-06-08 06:20:58 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-06-21 07:15:19 -07:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-08-08 09:28:45 -07:00
2026-08-14 20:20:52 -07:00
2026-05-20 07:35:01 -07:00
2026-05-30 14:57:07 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-08-14 20:20:53 -07:00
2026-04-25 11:52:48 -07:00
2026-08-14 20:20:53 -07:00
2026-08-14 20:20:53 -07:00
2026-05-14 21:19:58 -07:00
2026-08-14 20:20:51 -07:00
2026-08-08 09:28:45 -07:00
2026-04-17 00:45:13 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 20:20:49 -07:00
2026-05-26 16:50:03 -07:00
2026-05-30 12:09:10 -07:00
2026-06-08 21:17:18 -07:00
2026-05-28 18:21:09 -07:00
2026-05-30 11:42:13 -07:00
2026-05-06 19:37:53 -07:00
2026-05-01 07:06:37 -07:00
2026-06-07 22:04:18 -07:00
2026-06-14 11:40:57 -07:00
2026-06-25 09:42:45 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 09:28:56 -07:00
2026-08-14 20:20:52 -07:00
2026-08-08 09:28:45 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-08-14 20:20:49 -07:00
2026-05-30 08:54:46 -07:00
2026-08-14 20:20:49 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 12:09:10 -07:00
2026-06-07 06:51:10 -07:00
2026-05-21 21:21:07 -07:00
2026-08-14 20:20:54 -07:00
2026-05-20 06:56:41 -07:00
2026-05-20 06:56:41 -07:00
2026-05-21 21:21:07 -07:00
2026-05-30 12:09:10 -07:00
2026-06-14 11:40:57 -07:00
2026-05-26 16:50:03 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-03-26 23:21:27 -06:00
2026-08-14 20:20:48 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-04-24 01:38:21 -07:00
2026-06-04 11:14:43 -07:00
2026-06-21 07:15:19 -07:00
2026-07-09 23:49:09 -07:00
2026-08-14 20:20:52 -07:00
2026-08-14 20:20:54 -07:00
2026-05-24 01:43:51 -07:00
2026-05-14 21:19:58 -07:00
2026-05-29 18:06:19 -07:00
2026-05-06 19:37:53 -07:00
2026-05-30 11:42:13 -07:00
2026-08-14 20:20:54 -07:00
2026-05-30 12:09:10 -07:00
2026-08-14 20:20:54 -07:00
2026-05-30 12:09:10 -07:00
2026-05-30 12:09:10 -07:00
2026-04-18 23:58:59 +08:00
2026-08-14 09:28:56 -07:00
2026-08-14 09:28:56 -07:00
2026-06-04 11:14:43 -07:00
2026-04-19 08:38:19 +08:00
2026-05-26 16:50:03 -07:00
2026-05-26 16:50:03 -07:00
2026-06-12 15:38:53 -07:00
2026-05-01 19:51:51 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-06-14 11:40:57 -07:00
2026-08-14 09:28:56 -07:00
2026-07-09 23:49:09 -07:00
2026-08-14 09:28:56 -07:00
2026-05-06 19:37:53 -07:00
2026-06-25 09:42:45 -07:00
2026-06-14 11:40:57 -07:00
2026-04-19 08:38:19 +08:00
2026-03-23 06:57:22 -07:00
2026-03-26 11:08:31 -07:00
2026-08-12 11:12:28 -07:00
2026-06-12 15:38:53 -07:00
2026-06-25 09:42:45 -07:00
2026-05-29 08:35:00 -07:00
2026-08-14 09:28:56 -07:00
2026-07-14 16:35:30 -07:00
2026-07-14 16:35:30 -07:00
2026-07-14 16:35:30 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-05-01 08:45:36 -07:00
2026-06-04 11:14:43 -07:00
2026-05-01 19:51:51 -07:00
2026-06-04 11:14:43 -07:00
2026-04-22 01:06:22 -07:00
2026-04-23 18:42:58 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-08-14 09:28:56 -07:00
2026-08-12 11:12:28 -07:00
2026-06-07 19:13:24 -07:00
2026-05-26 23:43:07 -07:00
2026-04-30 02:50:09 -07:00
2026-08-12 11:12:28 -07:00
2026-08-12 11:12:28 -07:00
2026-08-14 09:28:56 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-03 20:26:59 -07:00
2026-04-30 02:50:09 -07:00
2026-08-12 11:12:28 -07:00
2026-05-09 17:01:13 -07:00
2026-08-12 11:12:28 -07:00
2026-05-01 19:51:51 -07:00
2026-08-12 11:12:28 -07:00
2026-04-23 18:25:34 -07:00
2026-08-08 09:28:45 -07:00
2026-04-18 15:05:42 +08:00
2026-08-08 09:28:45 -07:00
2026-05-11 12:16:26 -07:00
2026-03-23 10:17:33 -07:00
2026-03-30 22:07:50 -06:00
2026-08-08 09:28:45 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-08-14 09:28:56 -07:00
2026-06-07 19:13:24 -07:00
2026-04-04 15:32:20 -07:00
2026-05-11 12:16:26 -07:00
2026-05-26 21:36:53 -07:00
2026-05-11 12:16:26 -07:00
2026-06-04 11:14:43 -07:00
2026-05-26 21:36:53 -07:00
2026-06-25 09:42:45 -07:00
2026-03-13 21:08:12 -07:00
2026-05-29 08:35:00 -07:00
2026-04-16 10:41:38 -07:00
2026-06-07 19:13:24 -07:00
2026-08-14 20:20:55 -07:00
2026-06-07 19:13:24 -07:00
2026-05-26 21:36:53 -07:00
2026-05-25 10:57:15 -07:00
2026-08-14 09:28:56 -07:00
2026-05-29 08:35:00 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-06-02 22:36:34 -07:00
2026-06-21 07:15:19 -07:00
2026-05-30 12:09:10 -07:00
2026-06-08 05:41:07 -07:00
2026-05-01 07:21:28 -07:00
2026-05-25 10:57:15 -07:00
2026-06-04 11:14:43 -07:00
2026-05-30 12:09:10 -07:00
2026-03-27 00:44:37 -06:00
2026-08-14 20:20:49 -07:00
2026-05-24 01:43:51 -07:00
2026-08-14 20:20:51 -07:00
2026-04-18 15:05:42 +08:00
2026-04-06 14:41:06 -07:00
2026-05-26 16:50:03 -07:00