mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-01 19:25:10 +02:00
484cf1fb3b
* refactor: extract processExternalHost() shared helper for multi-host generation Refactor the Codex-specific output routing block in gen-skill-docs.ts into a shared processExternalHost() function. Both Codex and future external hosts (Factory Droid) will use this helper for output routing, symlink loop detection, frontmatter transformation, path rewrites, and metadata generation. - Rename codexSkillName() to externalSkillName() everywhere - Extract ExternalHostConfig interface with per-host settings - Codex output is byte-identical (verified via --dry-run) - Skip /codex skill for all non-Claude hosts (not just codex) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add Factory Droid host type, preamble, and co-author trailer - Add 'factory' to Host union type with .factory/skills/gstack paths - Extend preamble runtime root detection for Factory ($HOME/.factory/) - Add GSTACK_DESIGN env var to preamble (was missing for Codex too) - Add Factory Droid co-author trailer for git commits Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Factory Droid generation, --host all, and host-aware frontmatter - Add --host factory (alias: --host droid) to gen-skill-docs - Add --host all: generates for claude, codex, and factory in one invocation with fault-tolerant per-host error handling (only fails if claude fails) - Factory frontmatter: name + description + user-invocable: true - Factory sensitive skills: disable-model-invocation: true (from sensitive: field) - Claude: strips sensitive: field from output (only Factory uses it) - Factory tool name translation: Claude tool names → generic phrasing - Replace chained gen:skill-docs calls with --host all in package.json build Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: sensitive frontmatter for Factory Droid auto-invocation safety Add sensitive: true to 6 skill templates with side effects that Factory Droids shouldn't auto-invoke (ship, land-and-deploy, guard, careful, freeze, unfreeze). The field is: - Factory: emitted as disable-model-invocation: true - Claude/Codex: stripped from output by transformFrontmatter() Also fix Claude host path: call transformFrontmatter() for Claude to strip the sensitive: field from Claude output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: gstack-platform-detect binary for multi-host debugging Bash script that prints a table of installed AI coding agents (Claude, Codex, Factory Droid, Kiro) with versions, skill paths, and gstack installation status. Useful for debugging multi-host setups. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Factory Droid support in setup script - Add factory to --host values (auto-detected via command -v droid) - Add .factory/ skill doc generation step alongside .agents/ - Add create_factory_runtime_root() and link_factory_skill_dirs() helpers mirroring the Codex equivalents - Factory install section creates ~/.factory/skills/ with symlinks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Factory Droid awareness in skill-check and uninstall - skill-check.ts: add Factory skills validation and freshness check - gstack-uninstall: add Factory artifact cleanup (~/.factory/skills/gstack* and per-project .factory/ sidecar) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: Factory Droid generation + --host all test suites Add 13 new tests: - Factory output paths, frontmatter (user-invocable, disable-model-invocation) - Sensitive vs non-sensitive skill classification - Path rewrites (no .claude/skills/ in Factory output) - /codex skill exclusion, openai.yaml absence - Factory keeps Codex integration blocks (for second opinions) - --host droid alias, --dry-run freshness, preamble paths - --host all generates for all 3 hosts - Setup script host validation updated for factory Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: Factory Droid install instructions + CI freshness check - README: add Factory Droid section with install instructions and restart note (Factory requires restart to rescan skills) - CI: add Factory skill doc freshness verification to skill-docs.yml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: generated Factory Droid skill output (.factory/skills/) 29 skills generated for Factory Droid with: - user-invocable: true on all skills - disable-model-invocation: true on 6 sensitive skills - .factory/skills/ paths (no .claude/skills/ references) - $GSTACK_ROOT env vars for runtime root detection - Tool name translation (Claude tool names → generic phrasing) Committed to git for CI freshness checks and direct consumption. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: add Factory Droid P1 TODO for browse MCP server Add 3 TODOs under new ## Factory Droid section: - P1: Browse MCP server (Option B, deeper Factory integration) - P3: .agent/skills/ dual output for cross-agent compatibility - P3: Custom Droid definitions alongside skills Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v0.13.5.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
191 lines
7.1 KiB
TypeScript
191 lines
7.1 KiB
TypeScript
#!/usr/bin/env bun
|
|
/**
|
|
* skill:check — Health summary for all SKILL.md files.
|
|
*
|
|
* Reports:
|
|
* - Command validation (valid/invalid/snapshot errors)
|
|
* - Template coverage (which SKILL.md files have .tmpl sources)
|
|
* - Freshness check (generated files match committed files)
|
|
*/
|
|
|
|
import { validateSkill } from '../test/helpers/skill-parser';
|
|
import { discoverTemplates, discoverSkillFiles } from './discover-skills';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { execSync } from 'child_process';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
// Find all SKILL.md files (dynamic discovery — no hardcoded list)
|
|
const SKILL_FILES = discoverSkillFiles(ROOT);
|
|
|
|
let hasErrors = false;
|
|
|
|
// ─── Skills ─────────────────────────────────────────────────
|
|
|
|
console.log(' Skills:');
|
|
for (const file of SKILL_FILES) {
|
|
const fullPath = path.join(ROOT, file);
|
|
const result = validateSkill(fullPath);
|
|
|
|
if (result.warnings.length > 0) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — ${result.warnings.join(', ')}`);
|
|
continue;
|
|
}
|
|
|
|
const totalValid = result.valid.length;
|
|
const totalInvalid = result.invalid.length;
|
|
const totalSnapErrors = result.snapshotFlagErrors.length;
|
|
|
|
if (totalInvalid > 0 || totalSnapErrors > 0) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${file.padEnd(30)} — ${totalValid} valid, ${totalInvalid} invalid, ${totalSnapErrors} snapshot errors`);
|
|
for (const inv of result.invalid) {
|
|
console.log(` line ${inv.line}: unknown command '${inv.command}'`);
|
|
}
|
|
for (const se of result.snapshotFlagErrors) {
|
|
console.log(` line ${se.command.line}: ${se.error}`);
|
|
}
|
|
} else {
|
|
console.log(` \u2705 ${file.padEnd(30)} — ${totalValid} commands, all valid`);
|
|
}
|
|
}
|
|
|
|
// ─── Templates ──────────────────────────────────────────────
|
|
|
|
console.log('\n Templates:');
|
|
const TEMPLATES = discoverTemplates(ROOT);
|
|
|
|
for (const { tmpl, output } of TEMPLATES) {
|
|
const tmplPath = path.join(ROOT, tmpl);
|
|
const outPath = path.join(ROOT, output);
|
|
if (!fs.existsSync(tmplPath)) {
|
|
console.log(` \u26a0\ufe0f ${output.padEnd(30)} — no template`);
|
|
continue;
|
|
}
|
|
if (!fs.existsSync(outPath)) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${output.padEnd(30)} — generated file missing! Run: bun run gen:skill-docs`);
|
|
continue;
|
|
}
|
|
console.log(` \u2705 ${tmpl.padEnd(30)} \u2192 ${output}`);
|
|
}
|
|
|
|
// Skills without templates
|
|
for (const file of SKILL_FILES) {
|
|
const tmplPath = path.join(ROOT, file + '.tmpl');
|
|
if (!fs.existsSync(tmplPath) && !TEMPLATES.some(t => t.output === file)) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — no template (OK if no $B commands)`);
|
|
}
|
|
}
|
|
|
|
// ─── Codex Skills ───────────────────────────────────────────
|
|
|
|
const AGENTS_DIR = path.join(ROOT, '.agents', 'skills');
|
|
if (fs.existsSync(AGENTS_DIR)) {
|
|
console.log('\n Codex Skills (.agents/skills/):');
|
|
const codexDirs = fs.readdirSync(AGENTS_DIR).sort();
|
|
let codexCount = 0;
|
|
let codexMissing = 0;
|
|
for (const dir of codexDirs) {
|
|
const skillMd = path.join(AGENTS_DIR, dir, 'SKILL.md');
|
|
if (fs.existsSync(skillMd)) {
|
|
codexCount++;
|
|
const content = fs.readFileSync(skillMd, 'utf-8');
|
|
// Quick validation: must have frontmatter with name + description only
|
|
const hasClaude = content.includes('.claude/skills');
|
|
if (hasClaude) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — contains .claude/skills reference`);
|
|
} else {
|
|
console.log(` \u2705 ${dir.padEnd(30)} — OK`);
|
|
}
|
|
} else {
|
|
codexMissing++;
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — SKILL.md missing`);
|
|
}
|
|
}
|
|
console.log(` Total: ${codexCount} skills, ${codexMissing} missing`);
|
|
} else {
|
|
console.log('\n Codex Skills: .agents/skills/ not found (run: bun run gen:skill-docs --host codex)');
|
|
}
|
|
|
|
// ─── Factory Skills ─────────────────────────────────────────
|
|
|
|
const FACTORY_DIR = path.join(ROOT, '.factory', 'skills');
|
|
if (fs.existsSync(FACTORY_DIR)) {
|
|
console.log('\n Factory Skills (.factory/skills/):');
|
|
const factoryDirs = fs.readdirSync(FACTORY_DIR).sort();
|
|
let factoryCount = 0;
|
|
let factoryMissing = 0;
|
|
for (const dir of factoryDirs) {
|
|
const skillMd = path.join(FACTORY_DIR, dir, 'SKILL.md');
|
|
if (fs.existsSync(skillMd)) {
|
|
factoryCount++;
|
|
const content = fs.readFileSync(skillMd, 'utf-8');
|
|
const hasClaude = content.includes('.claude/skills');
|
|
if (hasClaude) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — contains .claude/skills reference`);
|
|
} else {
|
|
console.log(` \u2705 ${dir.padEnd(30)} — OK`);
|
|
}
|
|
} else {
|
|
factoryMissing++;
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — SKILL.md missing`);
|
|
}
|
|
}
|
|
console.log(` Total: ${factoryCount} skills, ${factoryMissing} missing`);
|
|
} else {
|
|
console.log('\n Factory Skills: .factory/skills/ not found (run: bun run gen:skill-docs --host factory)');
|
|
}
|
|
|
|
// ─── Freshness ──────────────────────────────────────────────
|
|
|
|
console.log('\n Freshness (Claude):');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All Claude generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Claude generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs');
|
|
}
|
|
|
|
console.log('\n Freshness (Codex):');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --host codex --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All Codex generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Codex generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs --host codex');
|
|
}
|
|
|
|
console.log('\n Freshness (Factory):');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --host factory --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All Factory generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Factory generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs --host factory');
|
|
}
|
|
|
|
console.log('');
|
|
process.exit(hasErrors ? 1 : 0);
|