mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 14:34:42 +01:00
* fix(make-pdf,design): real TOC page numbers and anchors; design models move to gpt-5.5 + gpt-image-2 (#2903, #2807) * ci: pin every action to a SHA, Scorecard, checksummed Bun, scoped Codex CLI in the CI image, macOS named-regressions job (#1948, #1706, #1997) * fix(cso,browse): Windows/macOS lease identity, retention skips bad runs, truthful 'not assessed' reports, env.kv false positive, Windows browse spawn fixes (#2894, #2912, #2048, #2637, #2805) * fix(outside-voice): one Codex model precedence for probe and dispatch, bounded timeouts with KILL escalation, probe cache identity, guarded mktemp, skills hidden in nested Codex (#2776, #2914, #2787, #2881, #2847) * feat(setup): install registry, ./setup --status, staged activation, per-scope migrations, host tiers and conformance kit, OpenCode/Hermes fixes, Copilot CLI (experimental), disabled_skills, slimmer CLAUDE.md (#1925, #2879, #2347, #2338, #2626, #2629, #2825, #2015, #393, #1206, #2096) Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com> * fix(preamble): skills start in worktree-isolated Claude Code sessions — one literal skill-start line, context-recovery helper, no eval in skill blocks, $N token tripwire, honest plan-mode precedence (#2763, #2896, #2851) * fix(setup): per-install renders for renamed, vendored and custom-config installs, space-safe alias roots, per-host /cso launcher path (#1882, #2906) * test: free tests never write the real HOME (home-write tripwire), no orphaned browse daemons, symlinked-TMPDIR (macOS) fixes, gbrain-on-PATH isolation (#2895, #2816, #2829, #2841, #2982, #2911, #2909, #2908, #2910) * chore: integrate wave follow-ups — regenerate all hosts, README model docs, TODOS, touchfiles, duration seeds, Bun 1.3 telemetry test fix, replay fixtures pinned to their recorded bytes * v1.91.14.0: release metadata * test(browse): group-kill cleanup falls back to the leader when macOS returns EPERM for a live group * ci: Codex login steps run under bash (the CI container's default sh rejects pipefail) * fix: full-suite repairs — private state roots for 7 real-HOME writers, truthful home-guard attribution with --attribute-home, gstack-paths shim in ship-hook fixtures, Copilot in team-init probes, test-of-test detector, cookie review fixture pinned to the approved excerpt * fix(windows): LF for Dockerfiles, normalized home-guard exclusions, path.relative fixture containment, ship push test spawn timeouts * test(design-detect): widen the whole-scan budget test's timing margins so a loaded macOS runner can't time out the single-batch call * fix(evals): qa protocol names defined for the judge, async PTY judge so overlapping sessions keep their cleanup deadline, bws setup cases use the standard JUDGE_MS tier * test(pty): the non-blocking judge case is POSIX-only (its fake judge is a shebang script, like the PTY harness it covers) * test(evals): ship-coverage-audit names absolute skill paths, uses Read, and skips the Step 7 artifact nothing consumes (removes the mechanism behind 3 of 4 historical timeouts) * test: deflake terminal-agent concurrent startup (write the placeholder record before spawning, like the product) and qa-evidence resumed pipe (barrier on a full high-water mark instead of a sleep) * fix(design): daemon log stream handles open errors instead of crashing the daemon; shutdown test awaits the stubbed exit * test(evals): skillify checks the product's resolved state root (no GSTACK_HOME bypass), negative cases check every root; tpa shims live outside the agent's cwd and answer consistently * test(evals): coverage-audit detector splits parallel columns at │ rails and [+] groups; coverage prompts name absolute skill paths; TODOs from the gate eval census * fix(plan-eng-review): scope gate always sends the menu (no headless 'Scope pending' exit); PTY harness ends idle turn-ends and API-error panels promptly with a precise diagnostic * test(evals): one position-bound coverage-read rule credits read-only && chains (labels, context ranges, git displays in either order) and still rejects forged output * fix(ship): documentation section has one saved source inserted by cat (never retyped); spawned-marker evidence is the child output; refreshed codex/factory ship goldens * test(docsync): the byte-exact insert positive is POSIX-only (the bash-command observer refuses backslash paths by design) * test(evals): plan-design-with-ui focus-title rule accepts the comma-less 'dimensions or focus' wording (replayed on the captured CI run, negative controls kept) * fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files --------- Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>
126 lines
5.3 KiB
Cheetah
126 lines
5.3 KiB
Cheetah
Structure the output as:
|
|
|
|
---
|
|
|
|
**Tweetable summary** (first line, before everything else):
|
|
```
|
|
Week of Mar 1: 47 commits (3 contributors), 3.2k LOC, 38% tests, 12 PRs, peak: 10pm | Streak: 47d
|
|
```
|
|
|
|
## Engineering Retro: [date range]
|
|
|
|
### Summary Table
|
|
(from Step 2)
|
|
|
|
### Trends vs Last Retro
|
|
(from Step 12, loaded before save — skip if no matching history; in `compare` mode use **Current vs Prior Period** from the computed prior window even on the first run)
|
|
|
|
### Time & Session Patterns
|
|
(from Steps 3-4)
|
|
|
|
Narrative interpreting what the team-wide patterns mean:
|
|
- When the most productive hours are and what drives them
|
|
- Whether sessions are getting longer or shorter over time
|
|
- Estimated hours per day of active coding (team aggregate)
|
|
- Notable patterns: do team members code at the same time or in shifts?
|
|
|
|
### Shipping Velocity
|
|
(from Steps 5-7)
|
|
|
|
Narrative covering:
|
|
- Commit type mix and what it reveals
|
|
- PR size distribution and what it reveals about shipping cadence
|
|
- Fix-chain detection (sequences of fix commits on the same subsystem)
|
|
- Version bump discipline
|
|
|
|
### Code Quality Signals
|
|
- Test LOC ratio trend
|
|
- Hotspot analysis (are the same files churning?)
|
|
- Greptile signal ratio and trend (if history exists): "Greptile: X% signal (Y valid catches, Z false positives)"
|
|
|
|
### Test Health
|
|
- Total test files: N (`TEST_FILES_TOTAL`)
|
|
- Test files changed this period: M (`TEST_FILES_CHANGED`; not newly added test cases)
|
|
- Regression test commits: list the `REGRESSION_COMMIT` lines (`test(qa):`, `test(design):`, and `test: coverage` commits)
|
|
- If prior retro exists and has `test_health`: show delta "Test count: {last} → {now} (+{delta})"
|
|
- If test ratio < 20%: flag as growth area — "100% test coverage is the goal. Tests make vibe coding safe."
|
|
|
|
### Plan Completion
|
|
Check review JSONL logs for plan completion data from /ship runs this period:
|
|
|
|
```bash
|
|
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
SLUG=$(~/.claude/skills/gstack/bin/gstack-slug --get SLUG 2>/dev/null)
|
|
cat "$GSTACK_STATE_ROOT"/projects/$SLUG/*-reviews.jsonl 2>/dev/null | grep '"skill":"ship"' | grep '"plan_items_total"' || echo "NO_PLAN_DATA"
|
|
```
|
|
|
|
If plan completion data exists within the retro time window:
|
|
- Count branches shipped with plans (entries that have `plan_items_total` > 0)
|
|
- Compute average completion: sum of `plan_items_done` / sum of `plan_items_total`
|
|
- Identify most-skipped item category if data supports it
|
|
|
|
Output:
|
|
```
|
|
Plan Completion This Period:
|
|
{N} branches shipped with plans
|
|
Average completion: {X}% ({done}/{total} items)
|
|
```
|
|
|
|
If no plan data exists, skip this section silently.
|
|
|
|
### Focus & Highlights
|
|
(from Step 8)
|
|
- Focus score with interpretation
|
|
- Ship of the week callout
|
|
|
|
### Shipping Streaks
|
|
(from Step 11: team and personal streaks, including broken-streak disclosure)
|
|
|
|
### Shortcut Debt
|
|
(from Step 11.5: marker ledger and count, or the clean-ledger statement)
|
|
|
|
### Your Week (personal deep-dive)
|
|
(from Step 9, for the current user only)
|
|
|
|
This is the section the user cares most about. Include:
|
|
- Their personal commit count, LOC, test ratio
|
|
- Their session patterns and peak hours
|
|
- Their focus areas
|
|
- Their biggest ship
|
|
- **What you did well** (2-3 specific things anchored in commits)
|
|
- **Where to level up** (1-2 specific, actionable suggestions)
|
|
|
|
### Team Breakdown
|
|
(from Step 9, for each teammate — skip if solo repo)
|
|
|
|
For each teammate (sorted by commits descending), write a section:
|
|
|
|
#### [Name]
|
|
- **What they shipped**: 2-3 sentences on their contributions, areas of focus, and commit patterns
|
|
- **Praise**: 1-2 specific things they did well, anchored in actual commits. Be genuine — what would you actually say in a 1:1? Examples:
|
|
- "Cleaned up the entire auth module in 3 small, reviewable PRs — textbook decomposition"
|
|
- "Added integration tests for every new endpoint, not just happy paths"
|
|
- "Fixed the N+1 query that was causing 2s load times on the dashboard"
|
|
- **Opportunity for growth**: 1 specific, constructive suggestion. Frame as investment, not criticism. Examples:
|
|
- "Test coverage on the payment module is at 8% — worth investing in before the next feature lands on top of it"
|
|
- "Most commits land in a single burst — spacing work across the day could reduce context-switching fatigue"
|
|
- "All commits land between 1-4am — sustainable pace matters for code quality long-term"
|
|
|
|
**AI collaboration note:** If many commits have `Co-Authored-By` AI trailers (e.g., Claude, Copilot), note the AI-assisted commit percentage as a team metric. Frame it neutrally — "N% of commits were AI-assisted" — without judgment.
|
|
|
|
### Top 3 Team Wins
|
|
Identify the 3 highest-impact things shipped in the window across the whole team. For each:
|
|
- What it was
|
|
- Who shipped it
|
|
- Why it matters (product/architecture impact)
|
|
|
|
### 3 Things to Improve
|
|
Specific, actionable, anchored in actual commits. Mix personal and team-level suggestions. Phrase as "to get even better, the team could..."
|
|
|
|
### 3 Habits for Next Week
|
|
Small, practical, realistic. Each must be something that takes <5 minutes to adopt. At least one should be team-oriented (e.g., "review each other's PRs same-day").
|
|
|
|
### Week-over-Week Trends
|
|
(if applicable, from Step 10)
|