mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-02 23:14:33 +01:00
* fix(make-pdf,design): real TOC page numbers and anchors; design models move to gpt-5.5 + gpt-image-2 (#2903, #2807) * ci: pin every action to a SHA, Scorecard, checksummed Bun, scoped Codex CLI in the CI image, macOS named-regressions job (#1948, #1706, #1997) * fix(cso,browse): Windows/macOS lease identity, retention skips bad runs, truthful 'not assessed' reports, env.kv false positive, Windows browse spawn fixes (#2894, #2912, #2048, #2637, #2805) * fix(outside-voice): one Codex model precedence for probe and dispatch, bounded timeouts with KILL escalation, probe cache identity, guarded mktemp, skills hidden in nested Codex (#2776, #2914, #2787, #2881, #2847) * feat(setup): install registry, ./setup --status, staged activation, per-scope migrations, host tiers and conformance kit, OpenCode/Hermes fixes, Copilot CLI (experimental), disabled_skills, slimmer CLAUDE.md (#1925, #2879, #2347, #2338, #2626, #2629, #2825, #2015, #393, #1206, #2096) Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com> * fix(preamble): skills start in worktree-isolated Claude Code sessions — one literal skill-start line, context-recovery helper, no eval in skill blocks, $N token tripwire, honest plan-mode precedence (#2763, #2896, #2851) * fix(setup): per-install renders for renamed, vendored and custom-config installs, space-safe alias roots, per-host /cso launcher path (#1882, #2906) * test: free tests never write the real HOME (home-write tripwire), no orphaned browse daemons, symlinked-TMPDIR (macOS) fixes, gbrain-on-PATH isolation (#2895, #2816, #2829, #2841, #2982, #2911, #2909, #2908, #2910) * chore: integrate wave follow-ups — regenerate all hosts, README model docs, TODOS, touchfiles, duration seeds, Bun 1.3 telemetry test fix, replay fixtures pinned to their recorded bytes * v1.91.14.0: release metadata * test(browse): group-kill cleanup falls back to the leader when macOS returns EPERM for a live group * ci: Codex login steps run under bash (the CI container's default sh rejects pipefail) * fix: full-suite repairs — private state roots for 7 real-HOME writers, truthful home-guard attribution with --attribute-home, gstack-paths shim in ship-hook fixtures, Copilot in team-init probes, test-of-test detector, cookie review fixture pinned to the approved excerpt * fix(windows): LF for Dockerfiles, normalized home-guard exclusions, path.relative fixture containment, ship push test spawn timeouts * test(design-detect): widen the whole-scan budget test's timing margins so a loaded macOS runner can't time out the single-batch call * fix(evals): qa protocol names defined for the judge, async PTY judge so overlapping sessions keep their cleanup deadline, bws setup cases use the standard JUDGE_MS tier * test(pty): the non-blocking judge case is POSIX-only (its fake judge is a shebang script, like the PTY harness it covers) * test(evals): ship-coverage-audit names absolute skill paths, uses Read, and skips the Step 7 artifact nothing consumes (removes the mechanism behind 3 of 4 historical timeouts) * test: deflake terminal-agent concurrent startup (write the placeholder record before spawning, like the product) and qa-evidence resumed pipe (barrier on a full high-water mark instead of a sleep) * fix(design): daemon log stream handles open errors instead of crashing the daemon; shutdown test awaits the stubbed exit * test(evals): skillify checks the product's resolved state root (no GSTACK_HOME bypass), negative cases check every root; tpa shims live outside the agent's cwd and answer consistently * test(evals): coverage-audit detector splits parallel columns at │ rails and [+] groups; coverage prompts name absolute skill paths; TODOs from the gate eval census * fix(plan-eng-review): scope gate always sends the menu (no headless 'Scope pending' exit); PTY harness ends idle turn-ends and API-error panels promptly with a precise diagnostic * test(evals): one position-bound coverage-read rule credits read-only && chains (labels, context ranges, git displays in either order) and still rejects forged output * fix(ship): documentation section has one saved source inserted by cat (never retyped); spawned-marker evidence is the child output; refreshed codex/factory ship goldens * test(docsync): the byte-exact insert positive is POSIX-only (the bash-command observer refuses backslash paths by design) * test(evals): plan-design-with-ui focus-title rule accepts the comma-less 'dimensions or focus' wording (replayed on the captured CI run, negative controls kept) * fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files --------- Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>
84 lines
4.5 KiB
TypeScript
84 lines
4.5 KiB
TypeScript
import { afterAll, beforeAll, describe, expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
import { spawn, spawnSync } from 'node:child_process';
|
|
import { identityStartedAtMs, processIdentitySource } from '../lib/cso/process-identity';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const macos = process.platform === 'darwin';
|
|
const required = process.env.GSTACK_CSO_MACOS_TESTS === '1';
|
|
if (required && !macos) throw new Error('GSTACK_CSO_MACOS_TESTS=1 requires native macOS; emulation does not qualify the launcher.');
|
|
let temporary = '', marker = '', library = '';
|
|
|
|
beforeAll(() => {
|
|
if (!macos) return;
|
|
temporary = fs.mkdtempSync(path.join(fs.realpathSync(os.tmpdir()), 'gstack-cso-macos-'));
|
|
marker = path.join(temporary, 'dyld-constructor-ran');
|
|
library = path.join(temporary, 'hostile.dylib');
|
|
const source = path.join(temporary, 'hostile.c');
|
|
fs.writeFileSync(source, '#include <fcntl.h>\n#include <stdlib.h>\n#include <unistd.h>\n__attribute__((constructor)) static void mark(void){const char*p=getenv("CSO_PRELOAD_MARKER");if(p){int f=open(p,O_WRONLY|O_CREAT,0600);if(f>=0)close(f);}}\n');
|
|
const built = spawnSync('/usr/bin/clang', ['-dynamiclib', source, '-o', library], { encoding: 'utf8', timeout: 30_000 });
|
|
expect(built.status).toBe(0);
|
|
}, 40_000);
|
|
|
|
afterAll(() => { if (temporary) fs.rmSync(temporary, { recursive: true, force: true }); });
|
|
|
|
describe('CSO native macOS build contract', () => {
|
|
test('macOS CI runs native signature and injection checks', () => {
|
|
const workflow = Bun.YAML.parse(fs.readFileSync(path.join(ROOT, '.github/workflows/free-tests.yml'), 'utf8')) as any;
|
|
const build = fs.readFileSync(path.join(ROOT, 'scripts/build-cso.sh'), 'utf8');
|
|
const job = workflow.jobs['cso-macos-launcher'];
|
|
expect(job['runs-on']).toBe('macos-latest');
|
|
expect(job.steps.some((step: any) => step.run === 'bun run build:cso')).toBe(true);
|
|
const gate = job.steps.find((step: any) => step.run === 'bun run test:cso:macos');
|
|
expect(gate.env.GSTACK_CSO_MACOS_TESTS).toBe('1');
|
|
expect(gate['continue-on-error']).not.toBe(true);
|
|
expect(build).toContain('-Wl,-sectcreate,__RESTRICT,__restrict,/dev/null');
|
|
});
|
|
});
|
|
|
|
(macos ? describe : describe.skip)('CSO native macOS startup', () => {
|
|
test('#2894 the darwin process identity source reads real process start times', async () => {
|
|
const own = processIdentitySource.read(process.pid), started = identityStartedAtMs(own ?? '');
|
|
expect(own).toMatch(/^darwin:\d+$/);
|
|
expect(processIdentitySource.read(process.pid)).toBe(own!);
|
|
expect(started!).toBeLessThanOrEqual(Date.now());
|
|
expect(started!).toBeGreaterThan(Date.now() - 3_600_000);
|
|
await Bun.sleep(20);
|
|
const child = spawn(process.execPath, ['-e', 'setTimeout(()=>{},30000)'], { stdio: 'ignore' });
|
|
try {
|
|
const identity = processIdentitySource.read(child.pid!);
|
|
expect(identity).toMatch(/^darwin:\d+$/);
|
|
expect(identity).not.toBe(own!);
|
|
expect(identityStartedAtMs(identity!)!).toBeGreaterThanOrEqual(started!);
|
|
} finally { child.kill(); }
|
|
expect(processIdentitySource.read(2147483647)).toBeUndefined();
|
|
});
|
|
|
|
test('the public launcher has a valid hardened-runtime signature', () => {
|
|
const launcher = path.join(ROOT, 'bin', 'gstack-cso-launcher');
|
|
const verified = spawnSync('/usr/bin/codesign', ['--verify', '--strict', launcher], { encoding: 'utf8', timeout: 30_000 });
|
|
expect(verified.status).toBe(0);
|
|
const details = spawnSync('/usr/bin/codesign', ['-d', '--verbose=4', launcher], { encoding: 'utf8', timeout: 30_000 });
|
|
expect(details.status).toBe(0);
|
|
expect(details.stderr).toMatch(/flags=.*runtime/);
|
|
const layout = spawnSync('/usr/bin/otool', ['-l', launcher], { encoding: 'utf8', timeout: 30_000 });
|
|
expect(layout.status).toBe(0);
|
|
expect(layout.stdout).toMatch(/sectname __restrict\s+segname __RESTRICT/);
|
|
});
|
|
|
|
test('DYLD constructor injection cannot run before the launcher scrubs the environment', () => {
|
|
const launcher = path.join(ROOT, 'bin', 'gstack-cso-launcher');
|
|
const result = spawnSync(launcher, ['--version'], {
|
|
cwd: temporary,
|
|
encoding: 'utf8',
|
|
timeout: 30_000,
|
|
env: { ...process.env, HOME: temporary, GSTACK_HOME: path.join(temporary, 'state'), DYLD_INSERT_LIBRARIES: library, CSO_PRELOAD_MARKER: marker },
|
|
});
|
|
expect(result.status).toBe(0);
|
|
expect(JSON.parse(result.stdout)).toEqual({ version: '3.0.0', abi: 3 });
|
|
expect(fs.existsSync(marker)).toBe(false);
|
|
});
|
|
});
|