Files
gstack/test/remote-identity-vectors.test.ts
T
f30b7b788a v1.91.13.0 fix: severe bug wave (autoplan guard, land-and-deploy CI gate, project identity, gbrain, review gates) (#3013)
* fix(land-and-deploy): never merge over red, pending or missing CI (#2995)

/land-and-deploy gated only on required checks, so a repo with none
(every GitHub Free private repo, any repo without branch protection)
skipped the CI wait and could merge over red CI. The verdict now comes
from bin/gstack-ci-gate, a tested helper bound to the head SHA: all
checks by default, cancel/unknown buckets fail, NO_CHECKS needs explicit
per-head approval, and both merge commands (including --auto) run only
after a PASS for the same SHA they pin with --match-head-commit.

Co-authored-by: harshitgavita-07 <harshit.gavita@gmail.com>

* fix(slug): give nested-group projects their own state bucket and verify checkpoint identity (#3003, #2901)

gstack-slug kept only the last two remote path segments, so
customer-a/product/repo and customer-b/product/repo shared one bucket
and /context-restore could present another project's checkpoint.

- One canonical-remote rule (bash + TS, golden vectors) used by all six
  resolvers: lowercased host, no userinfo/port/.git, Azure DevOps and
  Bitbucket Server normalized. 3+ segment remotes get
  <last-two>-<16 hex>; two-segment remotes (all of GitHub) are unchanged.
- Versioned sticky cache (v2:) keeps cache hits git-free.
- context-save stamps the credential-free remote and root;
  context-restore only treats this project's checkpoints as latest,
  reports foreign/unverified ones first, and treats a different root
  with the same remote (Conductor handoff) as information.
- gstack-slug --adopt-legacy copies only files the user confirms.
- question-preference-hook reads the same versioned cache, so never-ask
  preferences fire; unknown identity asks instead of auto-deciding.

* fix(gbrain): brain context loads, managed sync works, memory sync stops duplicating (#2883, #2985, #2922)

- brain-context-load called 'gbrain list_pages' (an MCP tool name), so
  every skill's brain context was 0 bytes. It now uses 'gbrain list'
  with gbrain's real filter flags, and prints one line when queries fail.
- The code-stage sync always passes --no-pull (managed gbrain >= 0.51
  refuses without it); a gbrain that rejects the flag fails with an
  upgrade message and is never retried without it. stderr is streamed
  with a bounded tail and quoted in failure summaries.
- /sync-gbrain gains --sources (and GSTACK_MEMORY_INGEST_SOURCES); by
  default it skips types already synced through a federated curated
  source, so curated pages stop being re-duplicated.

Co-authored-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Co-authored-by: harshitgavita-07 <harshit.gavita@gmail.com>

* fix(codex,cso): clean Codex reviews stop failing; semgrep and trivy SARIF results import (#2769, #3011)

- Codex review gate is PASS / FAIL / UNVERIFIED. Untagged output (what
  a clean 'codex review --base' prints) is UNVERIFIED, not FAIL, and
  never a false PASS; P2/P3-only output passes.
- import-sarif resolves semgrep's undeclared %SRCROOT% and trivy's
  ROOTPATH (including git-URL targets) through explicit, captured
  mappings; declared bases must sit inside the source root or the
  run's checkout, URIs are percent-decoded, and rejected results are
  counted with rule, base and path instead of silently dropped.

* fix: version strings are not IPs, failed update checks are not 'up to date', private security reporting (#2856, #2786, #2984)

- The pre-push redact hook exempts a root VERSION file that is only a
  version string and the version token in CHANGELOG release headings;
  the engine allowlist is untouched.
- gstack-update-check caches an unreadable remote as CHECK_FAILED with
  a short TTL instead of UP_TO_DATE; /gstack-upgrade never reports
  'latest' after a failed check.
- SECURITY.md points reporters at GitHub private vulnerability
  reporting.
- pr-title-sync (pull_request_target, write token) pins actions/checkout
  to a reviewed SHA.

* fix(autoplan): publication guard accepts real Claude Code journals (#3007, #3009, #2968, #2977, #2986, #3006)

The guard required a session journal to start with a user message, but
Claude Code starts it with SessionStart hook attachments (and a forked
compacted session starts with a compact_boundary), so every phase was
denied for anyone with a SessionStart hook. Windows path spellings
(C:/, /c/, drive case) were rejected too.

- Reader accepts the captured startup, compact, clear and fork shapes
  (claude 2.1.284 fixture), computes root uniqueness over every
  candidate, and returns typed reason codes instead of one string.
- Hard denials (competing root, foreign cwd, sidechain, agent, cycle,
  malformed, identity) say what happened and how to run the reviews by
  hand; unflushed journals still retry.
- A well-formed, stable journal whose root shape is unrecognized now
  warns ('phase publication was NOT verified') and continues, without
  overriding Claude Code's own permission check; no bypass switch.
- Windows paths fold before validation, so '..' is still rejected.
- Periodic drift canary runs the reader on fresh journals from the
  pinned claude.

Co-authored-by: Charles M Berg <77517285+CharlesBerg85@users.noreply.github.com>
Co-authored-by: laurenbdaniels-coder <264343335+laurenbdaniels-coder@users.noreply.github.com>
Co-authored-by: Jordan Mayer <176445995+maydaycyber@users.noreply.github.com>
Co-authored-by: elmesery-dev <elmesery.dev@gmail.com>

* v1.91.13.0: severe bug fix wave release notes, stale gbrain verbs in docs

* test: seed the versioned slug cache in the memory-injection deny case (#2901)

The preference hook now resolves the project bucket from gstack-slug's
v2 slug-cache entry instead of basename(cwd); this fixture still wrote
preferences under the basename bucket without the entry the skill
preamble always writes first.

* fix: full-suite follow-ups for the fix wave

- gstack-slug's --help heredoc is over 512B, so it gets the BASH_COMPAT=50
  pipe-deadlock guard like the other bins.
- Refresh the codex/factory ship goldens for the plan-gates slug change.
- The periodic lane gains the autoplan journal drift canary (107 paid
  files); raise the eval-slices cap to 25 so every slice still starts
  at once until its recorded duration lets the planner pack it.

* fix(plan-eng-review): clearer Step 0 sequencing, write routes and section outputs

The workflow judge scored plan-eng-review's instructions at
actionability 3.67 (bar 4) on text unchanged from main. Resolve the
ambiguities it named together, without changing any gate or output:
Step 0 names the Read's order and keeps one STOP; the pending-call,
read-only, forbidden-write and failed-save rules become one Write
routes block; header/label limits and grid checks are concrete;
Performance gets a checklist; each section has a stated output shape;
Lake Score is defined. Same total length (parity cap).

---------

Co-authored-by: harshitgavita-07 <harshit.gavita@gmail.com>
Co-authored-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Co-authored-by: Charles M Berg <77517285+CharlesBerg85@users.noreply.github.com>
Co-authored-by: laurenbdaniels-coder <264343335+laurenbdaniels-coder@users.noreply.github.com>
Co-authored-by: Jordan Mayer <176445995+maydaycyber@users.noreply.github.com>
Co-authored-by: elmesery-dev <elmesery.dev@gmail.com>
2026-10-02 11:11:00 -07:00

147 lines
6.2 KiB
TypeScript

/**
* Canonical remote + slug golden vectors (#3003).
*
* Every implementation of project identity must agree on these vectors:
* lib/remote-identity.ts (bin-context, browse config, global-discover) and
* bin/gstack-remote-identity.sh (gstack-slug, browse/bin/remote-slug). The
* fixture pins literal digests, so a drift in either twin (or in the bash
* sha256 tool selection) fails here rather than splitting a user's state.
*/
import { describe, test, expect } from 'bun:test';
import { spawnSync } from 'child_process';
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
import { canonicalRemote, legacyRemoteSlug, remoteSlug } from '../lib/remote-identity';
import { normalizeRemoteUrl } from '../bin/gstack-global-discover';
const ROOT = path.resolve(import.meta.dir, '..');
const VECTORS: Array<{ url: string; canonical: string; slug: string; legacy_slug: string }> = JSON.parse(
fs.readFileSync(path.join(ROOT, 'test', 'fixtures', 'remote-identity-vectors.json'), 'utf-8'),
);
function bashVectors(): Array<{ canonical: string; slug: string; legacy: string }> {
const script = `set -euo pipefail
. "$1/bin/gstack-remote-identity.sh"
shift
for u in "$@"; do
gstack_remote_slug "$u"
printf '%s\\037%s\\037%s\\n' "$_gri_canon" "$_gri_slug" "$_gri_legacy_slug"
done`;
const r = spawnSync('bash', ['-c', script, 'vectors', ROOT, ...VECTORS.map((v) => v.url)], {
encoding: 'utf-8',
timeout: 30_000,
});
expect(r.status).toBe(0);
return r.stdout
.split('\n')
.filter((l) => l !== '')
.map((l) => {
const [canonical, slug, legacy] = l.split('\x1f');
return { canonical, slug, legacy };
});
}
describe('remote identity golden vectors', () => {
test('fixture covers 2/3/4-segment, ssh/https/port/credential, Azure, Bitbucket, local forms', () => {
expect(VECTORS.length).toBeGreaterThanOrEqual(20);
const nested = VECTORS.filter((v) => v.slug !== v.legacy_slug);
expect(nested.length).toBeGreaterThan(5);
for (const v of nested) expect(v.slug).toMatch(/-[0-9a-f]{16}$/);
});
test('TypeScript twin matches every vector', () => {
for (const v of VECTORS) {
expect({ url: v.url, canonical: canonicalRemote(v.url).canonical, slug: remoteSlug(v.url), legacy: legacyRemoteSlug(v.url) })
.toEqual({ url: v.url, canonical: v.canonical, slug: v.slug, legacy: v.legacy_slug });
}
});
// The bash twin runs on POSIX CI; windows-free-tests covers the TS twin.
test.skipIf(process.platform === 'win32')('bash twin matches every vector byte-for-byte', () => {
const got = bashVectors();
expect(got.length).toBe(VECTORS.length);
VECTORS.forEach((v, i) => {
expect({ url: v.url, ...got[i] }).toEqual({ url: v.url, canonical: v.canonical, slug: v.slug, legacy: v.legacy_slug });
});
});
test('ssh, https, ssh:// with port and credential-bearing https of one nested repo share one slug', () => {
const forms = [
'https://gitlab.com/customer-a/product/repo.git',
'git@gitlab.com:customer-a/product/repo.git',
'ssh://git@gitlab.com:2222/customer-a/product/repo.git',
'https://oauth2:PASSWORD@GitLab.com:8443/customer-a/product/repo.git',
];
const slugs = new Set(forms.map(remoteSlug));
expect(slugs.size).toBe(1);
expect(remoteSlug('https://gitlab.com/customer-b/product/repo.git')).not.toBe([...slugs][0]);
for (const f of forms) expect(canonicalRemote(f).canonical).not.toContain('PASSWORD');
});
test('2-segment remotes keep the legacy slug, so no GitHub bucket moves', () => {
for (const v of VECTORS.filter((x) => canonicalRemote(x.url).hosted && canonicalRemote(x.url).segments.length <= 2)) {
expect(v.slug).toBe(v.legacy_slug);
}
});
test('gstack-global-discover groups by the same canonical remote (ssh:// port no longer leaks into the path)', () => {
for (const v of VECTORS.filter((x) => canonicalRemote(x.url).hosted)) {
expect(normalizeRemoteUrl(v.url)).toBe(`https://${v.canonical}`);
}
expect(normalizeRemoteUrl('ssh://git@host.example:2222/team/repo.git')).toBe('https://host.example/team/repo');
});
});
describe('every resolver files a nested-group repo under the same slug', () => {
const NESTED = 'git@gitlab.com:customer-a/product/repo.git';
const WANT = 'product-repo-5eca1fe041984543';
let tmp: string;
function nestedRepo(): string {
tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'resolver-parity-')));
const repo = path.join(tmp, 'checkout');
fs.mkdirSync(repo);
for (const args of [['init', '-q', '-b', 'feat-x'], ['remote', 'add', 'origin', NESTED]]) {
spawnSync('git', args, { cwd: repo, timeout: 30_000 });
}
return repo;
}
test('browse getRemoteSlug', () => {
const repo = nestedRepo();
try {
const r = spawnSync(
'bun',
['-e', `import { getRemoteSlug } from ${JSON.stringify(path.join(ROOT, 'browse', 'src', 'config.ts'))}; console.log(getRemoteSlug());`],
{ cwd: repo, encoding: 'utf-8', timeout: 30_000 },
);
expect(r.stdout.trim()).toBe(WANT);
} finally {
fs.rmSync(tmp, { recursive: true, force: true });
}
});
test.skipIf(process.platform === 'win32')('generated plan-file discovery (_PLAN_SLUG) searches the gstack-slug bucket', () => {
const repo = nestedRepo();
try {
const md = fs.readFileSync(path.join(ROOT, 'review', 'sections', 'plan-completion.md'), 'utf-8');
const block = md.slice(md.indexOf('### Plan File Discovery')).match(/```bash\n([\s\S]*?)```/)![1];
const state = path.join(tmp, '.gstack');
const planDir = path.join(state, 'projects', WANT);
fs.mkdirSync(planDir, { recursive: true });
fs.writeFileSync(path.join(planDir, 'plan.md'), '# plan for feat-x\n');
const { GSTACK_PROJECT_SLUG: _drop, GSTACK_STATE_ROOT: _drop2, ...ambient } = process.env;
const r = spawnSync('bash', ['-c', block.replaceAll('~/.claude/skills/gstack', ROOT)], {
cwd: repo,
env: { ...ambient, HOME: tmp, GSTACK_HOME: state },
encoding: 'utf-8',
timeout: 30_000,
});
expect(r.stdout).toContain(`PLAN_FILE: ${path.join(planDir, 'plan.md')}`);
} finally {
fs.rmSync(tmp, { recursive: true, force: true });
}
});
});