Files
gstack/browse/test/error-handling.test.ts
T
Garry Tan 6a857d41ba fix: restore isProcessAlive boolean semantics, add safeUnlinkQuiet, remove unused json()
isProcessAlive now catches ALL errors and returns false (pure boolean
probe). Callers use it in if/while conditions without try/catch, so
throwing on EPERM was a behavior change that could crash the CLI.
Windows path gets its safety catch restored.

safeUnlinkQuiet added for best-effort cleanup paths where throwing on
non-ENOENT errors (like EPERM during shutdown) would abort cleanup.

json() removed — dead code, never imported anywhere.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 05:17:54 -10:00

48 lines
1.5 KiB
TypeScript

import { describe, test, expect } from 'bun:test';
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
import { safeUnlink, safeKill, isProcessAlive } from '../src/error-handling';
describe('safeUnlink', () => {
test('removes an existing file', () => {
const tmp = path.join(os.tmpdir(), `test-safeUnlink-${Date.now()}`);
fs.writeFileSync(tmp, 'hello');
safeUnlink(tmp);
expect(fs.existsSync(tmp)).toBe(false);
});
test('ignores ENOENT (file does not exist)', () => {
expect(() => safeUnlink('/tmp/nonexistent-file-' + Date.now())).not.toThrow();
});
test('rethrows non-ENOENT errors', () => {
// Attempt to unlink a directory — throws EPERM/EISDIR
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'test-safeUnlink-'));
expect(() => safeUnlink(dir)).toThrow();
fs.rmdirSync(dir);
});
});
describe('safeKill', () => {
test('sends signal to a running process', () => {
// signal 0 is a no-op existence check — safe to send to self
expect(() => safeKill(process.pid, 0)).not.toThrow();
});
test('ignores ESRCH (process does not exist)', () => {
// PID 99999999 is extremely unlikely to exist
expect(() => safeKill(99999999, 0)).not.toThrow();
});
});
describe('isProcessAlive', () => {
test('returns true for current process', () => {
expect(isProcessAlive(process.pid)).toBe(true);
});
test('returns false for non-existent process', () => {
expect(isProcessAlive(99999999)).toBe(false);
});
});