mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-17 13:44:32 +01:00
* feat: retire /investigate after a no-gain eval (GST-1717)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(skill-start): core routing offer drops every non-core rule line (GST-1717)
The retired /investigate rule became 'Bugs/errors → fix them directly', which no
longer matches '→ invoke /', so proactive=core leaked it into the offered section.
Match any '- … → ' rule line.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* revert(review): keep review/checklist.md at its no-loss-pinned bytes (GST-1717)
The pin names replay GSTA-224 H1; a reviewer checklist edit merges only after a
passing no-loss replay (crew rule 15). The /investigate flake line stays until a
replayed repin.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test: repair free-suite fallout from retiring /investigate (GST-1717)
CI run 42340956269 at 83a8a9a: drop fixtures, ledger rows, allowlist entries and
counts for the retired skill and its deleted paid files; record the harness
change as non-behavioral; the test-of-test detector accepts path.join(ROOT, 'bin');
uncovered-prompt fixtures use a tracked prompt, since an untracked path now
reads as a deleted one.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(relink): back up a retired skill's real SKILL.md before cleaning it (GST-1717)
With the skill's source gone, the customized-file check never ran, so a
banner-carrying local copy of investigate/SKILL.md was deleted instead of moved
to the backup root (red-team review, pass 1).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qm): restore the review checklist's flake-line rewrite (GST-1717)
review/checklist.md keeps its pinned /investigate line, so the QM edition needs
its replaceText rule back; qm/ stays fresh against the generator.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(changelog): name the setup flag break, the relink backup and the pinned checklist line (GST-1717)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup,relink): back up a retired skill's real SKILL.md instead of deleting it (GST-1717)
Scoped fix round under grant a-360dd62bd46a (outside-voice blocking finding and
adversarial #1, #4). setup's prune compares a copied host entry with the render
before removing that render, and backs up a copy that differs or whose render is
gone; relink no longer takes the marker's rm -rf for a skill whose source is
gone, so a real SKILL.md is backed up and the user's files stay. setup reports a
failed remove-source of the retired gate hooks on stderr.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pr-profile): a changed prompt counts as deleted only when it is gone from disk (GST-1717)
An untracked prompt file on disk still needs prompt validation (targeted review
finding); harness change recorded as non-behavioral.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(changelog): exact backup wording, the hook-removal warning and GST-1744 (GST-1717)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup): one backup folder per host for a retired skill's copies (GST-1717)
Under grant a-c95576b8b1f9 (fix-check#1): every copy host moved its
gstack-investigate/SKILL.md to the same backup path, so a later host's copy
overwrote an earlier host's edits. A sandboxed ./setup --host factory run showed
gen-skill-docs removes the retired render before the prune, so every real copy
is backed up; each host now gets its own folder.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(changelog): say exactly what setup backs up for a retired skill (GST-1717)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(changelog): end the two colon sentences prose-lint flagged (GST-1717)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(retired-skills): name plan-eng-review once behind a pregate-literal waiver (GST-1717)
pregate's literals check read the GSTACK_RETIRED_SKILLS change as an old
value still in the tests. plan-eng-review is still retired; investigate was
appended. The fixture names it once, with the waiver.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
90 lines
3.3 KiB
Cheetah
90 lines
3.3 KiB
Cheetah
---
|
|
name: verify
|
|
preamble-tier: 1
|
|
version: 0.1.0
|
|
description: |
|
|
Use when coding: run the checks and tests /ship picks until green.
|
|
Build loop: run the repo's checks and the tests /ship would pick, fix, repeat.
|
|
Never green when no test covers a change. Fits "verify", "check my work", "run
|
|
the checks", "make it green", or after each change before /ship. (gstack)
|
|
triggers:
|
|
- verify my change
|
|
- run the checks
|
|
- make the tests pass
|
|
- make it green
|
|
- is it green
|
|
- check my work before ship
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Edit
|
|
- Grep
|
|
- Glob
|
|
- AskUserQuestion
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
# /verify — build, check, fix, repeat
|
|
|
|
Use this while building, before /ship. It runs checks and fixes code. It never
|
|
reviews, bumps a version, edits CHANGELOG, pushes, or opens a PR: that is /ship.
|
|
|
|
## 1. See what will run
|
|
|
|
Each Bash call is a fresh shell, so every block sets `C` again.
|
|
|
|
```bash
|
|
C="{{RUNTIME_ROOT}}/bin/gstack-checks"; "$C" detect
|
|
```
|
|
|
|
`detect` reads files only. It lists each check with its source, the pregate
|
|
test selection, and `TRUST trusted|untrusted`. `CHECKS: none` means the repo declares no check,
|
|
pregate policy or test file: there is nothing to run, so say so and stop. Never invent a
|
|
command the repo does not declare.
|
|
|
|
When `untrusted`: in an interactive session, show the user the listed commands
|
|
and ask before `"$C" trust`. In a session launched to run repo commands, pass
|
|
`--allow-repo-commands` to `run` instead. Never trust without one of the two.
|
|
|
|
## 2. Loop: run, fix, run
|
|
|
|
```bash
|
|
C="{{RUNTIME_ROOT}}/bin/gstack-checks"; "$C" run
|
|
```
|
|
|
|
One line per check: `CHECK <name> <VERDICT> <secs>`, at most 40 failing lines
|
|
and a log path. Exit 0 is green; only `PASS` is green.
|
|
|
|
- `FAIL`: fix the code under test. A changed source file breaking an untouched
|
|
test is your bug, not a pre-existing one. Call a red "possibly pre-existing"
|
|
only if it was already red on your first `run` this session, before any edit.
|
|
- `UNMAPPED`: no test covers a touched file. Add a test that does, or map it in
|
|
`.gstack/pregate.json`. `ZERO_RUN`: the selected tests ran nothing; fix the
|
|
selector or the test file. `TOO_BROAD`: the change selects over 300 test
|
|
files; leave them to /ship's pregate and say so.
|
|
- `ENV` or `TIMEOUT` (exit 2): a missing tool, service, secret or network.
|
|
Report it with the log line; do not fix the environment or work around it.
|
|
A `FAIL` whose own error says a service, secret or env var is missing is
|
|
the same: report it, do not stub or skip it.
|
|
- Rerun one check with `"$C" run --only <name>` while fixing it, then a full
|
|
`run` before you stop.
|
|
|
|
Never weaken, skip, delete or edit a test, a checker config or a package.json
|
|
script to get green.
|
|
|
|
Stop after 5 runs, when the same failure comes back twice after a fix, or on an
|
|
`ENV`/`TIMEOUT`. Report what is still red and why. Before another fix to a stubborn
|
|
red in your own change, reproduce it in one focused test and trace its root cause.
|
|
|
|
## 3. Hand off
|
|
|
|
```bash
|
|
C="{{RUNTIME_ROOT}}/bin/gstack-checks"; "$C" status
|
|
```
|
|
|
|
`status` reruns nothing. Only `READY_FOR_SHIP tree=<tree> ... not_covered=<lanes>`
|
|
(exit 0) means green at this exact tree. Print that line, name any
|
|
`not_covered` lanes (platform tests /ship's pregate owns), and stop with
|
|
"ready for /ship". `NOT_READY` means run again; never claim green from it.
|