mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-08 01:38:10 +01:00
Garry Tanandcapy-ai[bot]
6665e20d56
* feat(ship-queue): require a current /ship receipt before READY, train build and train merge Garry, 2026-10-25: use the gstack ship skill before merging PRs. ready printed SHIP_RECEIPT: none as information and returned ok, so the pool was READY'd without /ship. Now ready, train build (dry run included) and verify --train refuse with QUEUE_RECEIPT_MISSING or QUEUE_RECEIPT_STALE from the PR body alone; verify accepts the receipt written for the pinned head when the current head is its stamp commit. gstack-ship-receipt result is /ship's terminal step (GSTACK_RESULT: skill=ship, run dir with the head and receipt), unattended /ship may update an existing PR's body, and INSTALL_UNVERIFIED with no verdict names the project directory to install from (GSTA-85). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(ship): pin Step 22 in workflow-required-steps and tighten the ship skeleton Gate edit: test/fixtures/workflow-required-steps.json pins the new "## Step 22: Terminal line (every run)" heading (strengthens: a later edit that drops the terminal line turns the required-steps test red). Steps 14, 16, 18, 20 and 22 prose tightened so the carve-guards raise shrinks to 81,600 / 1.6740 (measured skeleton 81,535, union 314,027). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (ready at the stamp commit, screen on a stale merge ref, ship-run.json) - ready accepts the pin's receipt at a slot's stamp commit (plus the slot-2 merge of main), as verify --train already did; a real edit stays STALE - ready --screen refuses QUEUE_SCREEN_STALE_REF when refs/pull/<n>/merge is missing or merges an older head; a finished screen that planned 0 cases is never followed, and train build seats that slot unscreened (GSTA-95 on #3431) - gstack-ship-receipt result writes ship-run.json (a /ship record, not a run v1 manifest), validates --head, and prints status=incomplete on gh failures - bindReceipt takes an optional pr and renders one-line SHIP_RECEIPT lines - tests for every state-matrix cell the review named; the train fixture's merge ref is a real merge commit Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: cycle-2 review fixes (private screen scratch, no bare-merge receipt reuse, 12-hex --head, one receipt scrub) and align the unattended hook text with the GSTACK_RESULT writers (GSTA-91) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: adversarial-review fixes (result refuses an unpushed HEAD, resolves --out and reports unwritable records; ready names a failed merge-ref fetch; unattended /ship never runs gh pr ready) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: close review-cycle gaps (a stamp must change a stamp file, result requires a full --head and fails closed without headRefOid, digits-only --pr) with tests for every cycle-3 branch Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: give the fsck-rejected merge-ref spawns a timeout (spawnsync tripwire) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: detect a hollow screen from the plan it uploads (no paid-plan artifact or nothing planned), correct two troubleshooting facts, and normalise result --pr Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(hollow-screen): read manifest.json by name, list artifacts by name, say when the plan is unreadable; lowercase result --head Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(hollow-screen): expired and unreadable run rows, uppercase --head; docs name every SCREEN: literal Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(train build): say when the repository slug is unreadable instead of counting the screen silently Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: name an ls-remote failure in ready --screen, refuse result --pr with --body, cap echoed receipt errors, tell an unreadable install verdict from a missing one Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: ls-remote refusal, --pr with --body, capped receipt errors, unreadable slug and verdict (both twins); docs name the new literals Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: scrub Unicode line separators from receipt text, report an unreadable --body as incomplete, refuse unsupported verdict schemas in the bash twin Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
219 lines
8.1 KiB
JSON
219 lines
8.1 KiB
JSON
{
|
|
"source": "Step and phase headings of the judged workflow skills, derived on 2026-10-04 from the generated Claude SKILL.md and sections (templates at the integration head). qa-only lists its template's own top-level headings. C1 calibration showed the workflow judges pass a bundle with a required step removed, so missing-step coverage lives here.",
|
|
"skills": {
|
|
"qa": {
|
|
"SKILL.md": [
|
|
"## Step 0: Detect platform and base branch",
|
|
"## Phases 1-6: QA Baseline",
|
|
"## Phase 7: Triage",
|
|
"## Phase 8: Fix Loop",
|
|
"### 8a. Diagnose and reproduce",
|
|
"### 8a.5. Regression test before repair",
|
|
"### 8b. Fix",
|
|
"### 8c. Re-test",
|
|
"### 8d. Commit verified work",
|
|
"### 8e. Classify",
|
|
"### 8e.5. Regression Test record",
|
|
"### 8f. Self-Regulation (STOP AND EVALUATE)",
|
|
"## Phase 9: Final QA",
|
|
"## Phase 10: Report",
|
|
"## Phase 11: TODOS.md Update"
|
|
],
|
|
"sections/exploratory.md": [
|
|
"## 1. Charter and preflight",
|
|
"## 2. Probe loop",
|
|
"## 3. Parent handoff",
|
|
"## 4. Final report"
|
|
],
|
|
"sections/qa-patterns.md": [
|
|
"### Phase 1: Initialize",
|
|
"### Phase 2: Authenticate (if needed)",
|
|
"### Phase 3: Orient",
|
|
"### Phase 4: Explore",
|
|
"### Phase 5: Document",
|
|
"### Phase 6: Wrap Up"
|
|
]
|
|
},
|
|
"qa-only": {
|
|
"SKILL.md": [
|
|
"## Request Parameters",
|
|
"## Test Plan Context",
|
|
"## Select Surfaces and Isolation",
|
|
"## Prepare Report Artifacts",
|
|
"## Browser Setup (conditional)",
|
|
"## Run the Selected Checks",
|
|
"## Output",
|
|
"## Additional Rules (qa-only specific)"
|
|
],
|
|
"sections/exploratory.md": [
|
|
"## 0. Preparation gate",
|
|
"## 1. Charter and preflight",
|
|
"## 2. Probe loop",
|
|
"## 3. Parent handoff",
|
|
"## 4. Final report"
|
|
],
|
|
"sections/reporting.md": [
|
|
"## 1. Establish each finding once",
|
|
"## 2. Fill timing fields from their actual boundaries",
|
|
"## 3. Assemble and check every repetition before writing",
|
|
"## 4. Capture permitted notes, then write the report"
|
|
]
|
|
},
|
|
"review": {
|
|
"SKILL.md": [
|
|
"## Step 0: Detect platform and base branch",
|
|
"## Step 1: Check branch",
|
|
"## Step 1.5: Scope Drift Detection",
|
|
"## Step 2: Read the checklist",
|
|
"## Step 2.5: Check for Greptile review comments",
|
|
"## Step 3: Get the diff",
|
|
"## Step 3.4: Workspace-aware queue status (advisory)",
|
|
"## Step 3.5: Diff scans",
|
|
"## Step 3.6: Gather review context",
|
|
"## Step 4: Critical pass (core review)",
|
|
"### Step 4.7: Exploratory QA (before Fix-First)",
|
|
"## Step 5: Fix-First Review",
|
|
"### Step 5.0: Cross-review finding dedup",
|
|
"### Step 5a: Classify each finding",
|
|
"### Step 5b: Auto-fix all AUTO-FIX items",
|
|
"### Step 5c: Batch-ask about ASK items",
|
|
"### Step 5d: Apply user-approved fixes",
|
|
"## Step 5.8: Persist Eng Review result",
|
|
"### 1. Re-review after edits",
|
|
"### 2. Fill the record"
|
|
],
|
|
"sections/adversarial.md": [
|
|
"## Step 4.8: Adversarial review (always-on)"
|
|
],
|
|
"sections/review-army.md": [
|
|
"## Step 4.5: Review Army — Specialist Dispatch",
|
|
"### Step 4.6: Collect and merge findings",
|
|
"#### 1. Parse outputs",
|
|
"#### 2. Validate severity",
|
|
"#### 3. Identify and merge",
|
|
"#### 4. Apply specialist confidence gates",
|
|
"#### 5. Score and present specialists",
|
|
"#### 6. Save specialist activity",
|
|
"#### 7. Hand off to Fix-First"
|
|
]
|
|
},
|
|
"ship": {
|
|
"SKILL.md": [
|
|
"## Step 0: Detect platform and base branch",
|
|
"## Step 0.9: Apple target detection",
|
|
"## Step 1: Pre-flight",
|
|
"## Step 2: Distribution Pipeline Check",
|
|
"## Step 3: Merge the base branch (BEFORE tests)",
|
|
"## Step 11.5: Bind the reviews",
|
|
"## Step 12: Version bump (auto-decide)",
|
|
"## Step 14: TODOS.md (auto-update)",
|
|
"## Step 14.5: Documentation audit (every ship)",
|
|
"## Step 15: Commit (bisectable chunks)",
|
|
"## Step 16: Verification Gate",
|
|
"### 1. Finish writers and prepare outputs",
|
|
"### 2. Choose the change route",
|
|
"### 3. Resolve documentation freshness",
|
|
"### 4. Verify the frozen candidate",
|
|
"### 5. Report, then push",
|
|
"## Step 17: Push",
|
|
"## Step 18: Prepare publication metadata",
|
|
"## Step 20: Persist ship metrics",
|
|
"## Step 21: Plan-tune discoverability nudge (first-successful-ship only)",
|
|
"## Step 22: Terminal line (every run)"
|
|
],
|
|
"sections/adversarial.md": [
|
|
"## Step 11: Adversarial review (always-on)"
|
|
],
|
|
"sections/changelog.md": [
|
|
"## Step 13: CHANGELOG (auto-generate)"
|
|
],
|
|
"sections/greptile-early.md": [
|
|
"## Step 6.5: Early Greptile PR (after the free tests pass)"
|
|
],
|
|
"sections/greptile.md": [
|
|
"## Step 10: Address Greptile review comments (if PR exists)"
|
|
],
|
|
"sections/plan-completion.md": [
|
|
"## Step 8: Plan Completion Audit",
|
|
"## Step 8.1: Plan Verification",
|
|
"## Step 8.2: Scope Drift Detection"
|
|
],
|
|
"sections/pr-body.md": [
|
|
"## Step 19: Create PR/MR"
|
|
],
|
|
"sections/review-army.md": [
|
|
"## Step 9: Pre-Landing Review",
|
|
"## Step 9.1: Review Army — Specialist Dispatch",
|
|
"### Step 9.2: Collect and merge findings",
|
|
"#### 1. Parse outputs",
|
|
"#### 2. Validate severity",
|
|
"#### 3. Identify and merge",
|
|
"#### 4. Apply specialist confidence gates",
|
|
"#### 5. Score and present specialists",
|
|
"#### 6. Save specialist activity",
|
|
"#### 7. Hand off to Fix-First",
|
|
"### Step 9.2.1: Exploratory QA (before Fix-First)",
|
|
"### Step 9.3: Cross-review finding dedup",
|
|
"## Step 9.4: Fix-First and persistence"
|
|
],
|
|
"sections/test-coverage.md": [
|
|
"## Step 7: Test Coverage Audit"
|
|
],
|
|
"sections/tests.md": [
|
|
"## Step 4: Test Framework Bootstrap",
|
|
"## Step 5: Run tests (on merged code)",
|
|
"## Step 6: Eval Suites (conditional)"
|
|
]
|
|
},
|
|
"plan-ceo-review": {
|
|
"SKILL.md": [
|
|
"## Step 0: Detect platform and base branch",
|
|
"## Step 0: Nuclear Scope Challenge + Mode Selection",
|
|
"### 0A. Premise Challenge",
|
|
"### 0B. Existing Code Leverage",
|
|
"### 0C. Dream State Mapping",
|
|
"### 0D. Alternatives (reusable decision procedure)",
|
|
"### 0E. Mode Selection",
|
|
"### 0F. Expansion Framing (shared by EXPANSION and SELECTIVE EXPANSION)",
|
|
"### 0G. Mode-Specific Analysis",
|
|
"### 0H. Persist CEO Plan (EXPANSION and SELECTIVE EXPANSION only)",
|
|
"### 0I. Temporal Interrogation (EXPANSION, SELECTIVE EXPANSION, and HOLD modes)"
|
|
],
|
|
"sections/review-sections.md": [
|
|
"### Section 1: Architecture Review",
|
|
"### Section 2: Error & Rescue Map",
|
|
"### Section 3: Security & Threat Model",
|
|
"### Section 4: Data Flow & Interaction Edge Cases",
|
|
"### Section 5: Code Quality Review",
|
|
"### Section 6: Test Review",
|
|
"### Section 7: Performance Review",
|
|
"### Section 8: Observability & Debuggability Review",
|
|
"### Section 9: Deployment & Rollout Review",
|
|
"### Section 10: Long-Term Trajectory Review",
|
|
"### Section 11: Design & UX Review (skip if no UI scope detected)"
|
|
]
|
|
},
|
|
"plan-eng-review": {
|
|
"SKILL.md": [
|
|
"### Step 0: Scope Challenge"
|
|
],
|
|
"sections/review-sections.md": [
|
|
"### 1. Architecture review",
|
|
"### 2. Code quality review",
|
|
"### 3. Test review",
|
|
"### 4. Performance review"
|
|
]
|
|
},
|
|
"setup-deploy": {
|
|
"SKILL.md": [
|
|
"### Step 1: Check existing configuration",
|
|
"### Step 2: Detect platform",
|
|
"### Step 3: Platform-specific setup",
|
|
"### Step 4: Write configuration",
|
|
"### Step 5: Verify",
|
|
"### Step 6: Summary"
|
|
]
|
|
}
|
|
}
|
|
}
|