Garry Tan 51a8d26be2 fix(design): reload guard rejects directory paths ...

design/src/serve.ts:200-212 used to accept a path that resolved to the
allowedDir itself (the OR branch `|| resolvedReload === allowedDir`),
which then crashed readFileSync with EISDIR. Now:

  1. startsWith(allowedDir + path.sep) must pass — rejects the dir itself
     and anything outside (403).
  2. statSync(resolvedReload).isFile() must pass — rejects subdirectories
     inside allowedDir with a clear "Path must be a file" 400.

The test stub in serve.test.ts mirrors prod; both updated, plus two new
test cases for the previously-broken paths. Codex caught this in the
plan-review pass; it's a latent bug in shipping code, not a regression
from the daemon work.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-25 14:32:06 -07:00

..

auth.test.ts

v1.42.0.0 Daegu wave: 23 community-filed bugs + PTY classifier enforcement (24 bisect commits) (#1594)

2026-05-20 07:35:01 -07:00

feedback-roundtrip.test.ts

refactor(design): board JS uses relative paths; drop __GSTACK_SERVER_URL injection

2026-05-25 14:31:22 -07:00

gallery.test.ts

feat: design binary — real UI mockup generation for gstack skills (v0.13.0.0) (#551)

2026-03-27 20:32:59 -06:00

serve.test.ts

fix(design): reload guard rejects directory paths

2026-05-25 14:32:06 -07:00

variants-retry-after.test.ts

v1.30.0.0 fix wave: 21 community PRs + Windows CI extension + codex flag-semantics smoke (#1391)

2026-05-09 08:06:47 -07:00