Files
gstack/lib/pregate/docs-lane.ts
T
Garry Tanandcapy-ai[bot] d62eb914dc fix(pregate): waive version-stamp-only manifests from the lanes check (GBRA-95) (#3461)
gbrain's release:restamp rewrites its plugin manifests and VERSION; its
base's .gstack/pregate.json declares no lane for them, and pregate reads
policy from the base, so every restamp PR failed lanes with
PREGATE_NO_LANE and could not fix itself (gbrain PRs 7625 and 7606).

lib/pregate/stamp-only.ts defines version-stamp-only per file kind: a JSON
document of the same shape whose every changed leaf is a bare version under
a key named for a version; plist <string> versions under a ...Version...
key; a VERSION file that is one bare version on both sides. lane-selection
applies it only after the import graph, the declarations, the regen
registry and both empty lanes found nothing; lanes prints the waived files
on their own line and --explain the per-file verdict. Anything else (a
changed description, a new key, a dependency pin, an added or deleted
manifest) keeps its PREGATE_NO_LANE.

Tests: pure rows for every rule, and bin fixtures for a stamp-only PR
(passes), a manifest with a changed description (refused), a mixed diff
(stamped files waived, the orphan source file still refused, a mapped file
still runs its test) and an added/deleted manifest.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-10-26 12:14:55 +00:00

102 lines
6.0 KiB
TypeScript

/**
* pregate docs/no-tests — Markdown no test depends on is an empty lane.
*
* A repo with no `.gstack/pregate.json` used to fail `lanes` on a tracked
* `.work` plan, a redproof note, or any other Markdown file (`PREGATE_NO_LANE`).
* Those files document a change; they are not test subjects. `isDocsEmptyLane`
* is that class. `lane-selection` consults it only when the import graph
* mapped nothing (`testsFor`: imports, repo-path literals including `join()`,
* the bin convention, declarations), so a test that reads the file — a
* fixture or a doc — still runs. Source code and anything under a test
* directory never qualify, including when `empty_lanes` globs match them.
* Unmapped code stays `PREGATE_NO_LANE`.
*
* `isInertNoTests` is the second empty-lane class (#3267): files no test
* runner loads — binary and media assets, and a named allowlist of editor,
* lint, format and repository-metadata configuration. It applies under the
* same rule (only when nothing maps the file to a test) and never to code,
* the test tree, snapshot or golden baselines, CI workflows, the pin files,
* stylesheets (they import each other), or any dotfile not on the list: an
* unknown dotfile may be read by a runner (`.rspec`, `.taprc`) or executed
* (`.husky/pre-commit`), so it still needs a lane.
*/
import { SOURCE_EXT } from './import-graph';
import { matchesAny } from '../ship-policy';
const TEST_TREE = /(?:^|\/)(?:test|tests|spec|__tests__)(?:\/|$)/i;
const MARKDOWN = /\.(?:md|markdown|rst|adoc|asciidoc)$/i;
/** Prose names, with or without `.md` (LICENSE has no extension). */
const PROSE_NAME = /^(?:README|CHANGELOG|CONTRIBUTING|AGENTS|CLAUDE|ETHOS|LICENSE|LICENCE|COPYING|NOTICE)(?:\.md)?$/i;
/** Licence text under any name a vendored asset ships it with: `roboto-LICENSE.txt`, `LICENSE-MIT`, `COPYING.LESSER`, `licenses/apache.txt`. */
const LICENCE_TEXT = /(?:^|[-_.])(?:LICEN[CS]E|COPYING|COPYRIGHT|NOTICE)(?:[-_.][\w-]*)?(?:\.(?:txt|md))?$|^(?:licen[cs]es?|LICENSES)\/(?:.*\/)?[^/]+\.(?:txt|md)$/i;
const ASSET = /\.(?:png|jpe?g|gif|webp|avif|bmp|ico|icns|tiff?|svg|heic|woff2?|ttf|otf|eot|mp3|mp4|m4a|wav|ogg|oga|webm|mov|flac|pdf|psd)$/i;
/** Directories whose files a test compares against or that pregate and CI read: never inert, assets included. */
const PROTECTED_TREE = /(?:^|\/)(?:__snapshots__|__image_snapshots__|[^/]*-snapshots|snapshots?|goldens?|baselines?|fixtures?)\/|^\.(?:github\/(?:workflows|actions)|gstack)\//i;
/** Editor, lint, format, hook-manager and repository-metadata configuration no test runner reads. */
const INERT_DOTFILE = /^\.(?:editorconfig|gitignore|gitattributes|gitmessage|mailmap|dockerignore|npmignore|prettierignore|eslintignore|pre-commit-config\.ya?ml|pre-commit-hooks\.ya?ml|prettierrc(?:\.(?:json|ya?ml|toml))?|eslintrc(?:\.(?:json|ya?ml))?|stylelintrc(?:\.(?:json|ya?ml))?|markdownlint(?:\.(?:json|jsonc|ya?ml))?|markdownlintignore|yamllint(?:\.ya?ml)?|flake8|pylintrc|isort\.cfg|rubocop\.yml|shellcheckrc|hadolint\.ya?ml|codespellrc|clang-format)$/i;
/** Dot-directories of editors and design tools, and GitHub's repository metadata (not workflows or actions). */
const INERT_DOT_DIR = /^\.(?:vscode|idea|fleet|zed|cursor|impeccable)\/|^\.github\/(?:ISSUE_TEMPLATE\/|DISCUSSION_TEMPLATE\/|PULL_REQUEST_TEMPLATE|pull_request_template|CODEOWNERS$|FUNDING\.ya?ml$|dependabot\.ya?ml$|labeler\.ya?ml$|release\.ya?ml$)/;
function isMarkdown(rel: string): boolean {
return MARKDOWN.test(rel);
}
function isTestTree(rel: string): boolean {
return TEST_TREE.test(rel);
}
/** Code the empty-lane class must not swallow. Extensionless `bin/` entrypoints count; `bin/README.md` does not. */
function isSourceCode(rel: string): boolean {
if (SOURCE_EXT.test(rel)) return true;
const base = rel.split('/').pop() ?? rel;
if (rel.startsWith('bin/') && !isMarkdown(rel) && !PROSE_NAME.test(base)) return true;
return false;
}
function isBuiltinDocsPath(rel: string): boolean {
const base = rel.split('/').pop() ?? rel;
if (PROSE_NAME.test(base) || LICENCE_TEXT.test(base) || LICENCE_TEXT.test(rel)) return true;
// Any Markdown file. Name and directory do not matter: `planet.md` and
// `prompts/system.md` qualify the same way a `.work` plan does. A test
// that reads the file is handled by the caller, before this check.
return isMarkdown(rel);
}
/**
* True when `rel` is documentation that needs no test lane.
* `extraGlobs` are the repo's `empty_lanes` (`.gstack/pregate.json` on the
* base branch). They add paths; they cannot classify source code or a file
* under a test directory. Callers apply this only after the import graph
* found no test.
*/
export function isDocsEmptyLane(rel: string, extraGlobs: readonly string[] = []): boolean {
const norm = rel.replace(/\\/g, '/').replace(/^\.\//, '');
if (!norm || isTestTree(norm) || isSourceCode(norm)) return false;
if (extraGlobs.length > 0 && matchesAny(extraGlobs, norm)) return true;
return isBuiltinDocsPath(norm);
}
/** True under a test directory or a protected tree (snapshots, goldens, baselines, fixtures, CI workflows and actions, `.gstack/`): never an empty lane, never a version stamp. */
export function isProtectedTree(rel: string): boolean {
const norm = rel.replace(/\\/g, '/').replace(/^\.\//, '');
return isTestTree(norm) || PROTECTED_TREE.test(norm);
}
/** Tool configuration on the allowlist: a named dotfile at any depth, or a file under an editor or design-tool dot-directory. */
function isToolConfig(rel: string): boolean {
return INERT_DOTFILE.test(rel.split('/').pop() ?? rel) || INERT_DOT_DIR.test(rel);
}
/**
* True when `rel` is a file no test runner loads (#3267): a binary or media
* asset outside any snapshot, golden or fixture tree, or allowlisted tool
* configuration. Callers apply this only
* after the import graph found no test, so an asset a test imports or names
* still selects that test.
*/
export function isInertNoTests(rel: string): boolean {
const norm = rel.replace(/\\/g, '/').replace(/^\.\//, '');
if (!norm || isTestTree(norm) || isSourceCode(norm) || PROTECTED_TREE.test(norm)) return false;
return ASSET.test(norm) || isToolConfig(norm);
}