mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-26 14:50:55 +02:00
* fix: acknowledge seeded plans before invoking review skills * fix: distinguish current plan input from conversation history * fix: keep hermetic plan reviews on manual permissions * fix: distinguish tool discovery from file permission ownership * fix: preserve initial plan mode in observation tests * fix: wait for scope decisions before writing review findings * fix: carry autoplan decisions consistently into review artifacts * test: retain native failure context in periodic assertions * fix: advance active file permissions before queued questions * fix: finish red-team attempts before retry and cleanup * fix: finalize plan format captures and judges before retry * fix: cancel setup-gbrain SDK attempts before fixture cleanup * test: select periodic consumers of the bounded attempt helper * fix native Bash permission cards and queued questions * fix: preserve independent decisions and review scope Keep CEO approach, engineering scope and outside-review choices from approving independent remedies together. Carry declared contracts through DX polish and resolve new gaps before editing the plan. Regenerate every host and retain existing stop boundaries. Validation: 654 focused tests passed across nine files; all-host generation passed. Full free and periodic validation pending. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: require approval before design plan amendments Align the Design review philosophy and rating recipe with its section protocol: resolve one proposed fix, then apply only that approved decision and retain honest scores for declined fixes. Validation: 469 focused tests passed across four files; all-host generation passed. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: observe native question completion before transcript persistence Match owned completion hooks to submitted choices, reject conflicting or late answers, and retain bounded failure evidence. * test: recognize review posture in acknowledged native questions Require the selected mode acknowledgement, a completed follow-up question, and its current decoded display while preserving existing posture assertions. * fix: preserve settled CEO choices and isolate pending remedies Resolve established approach gates with cited authority and keep independent fixes out of unrelated option commitments and plan amendments. * fix: carry approved DX choices through later review steps Choose documentation approaches within the accepted scope and map resolved confusion points without reopening them through a bulk menu. * test: handle native settings-file edit prompts Keep one-time owned-file approvals and retain the actual sampled Autoplan permission frame with its matching barrier state. * test: accept standard CEO reply directives with tuning footers Recognize the exact trailing preference footer and letter-list directive while preserving current-display and exact acknowledgement checks. * test: scope split reviewers to their generated plan artifacts * test: observe native Bash permissions and invocation results * test: handle owned Bash prompts during mode preference checks * test: preserve synchronous subprocess rejection in Codex fixture * Fix periodic review handoff navigation Recognize review-first and explicit manual-next-step labels while preserving exact action families, manual preference, and ambiguous-menu rejection. Co-authored-by: OpenAI Codex <noreply@openai.com> * Bind pending file permissions to distinct current targets Allow one captured file request to own the complete current dialog while unrelated file work is pending. Preserve same-path ambiguity, exact input ownership, and one-time grant checks. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make paired CEO verification choices genuinely unresolved Start the positive control with proposed manual checks so its unchanged oracle measures two new coverage decisions. Preserve runtime contracts, targets, count bounds, and all assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO review options and verification within approved scope Audit every offered option for independent add-ons and keep new verification depth pending until accepted. Preserve already requested coverage and trace plan changes to the actual decision. Co-authored-by: OpenAI Codex <noreply@openai.com> * Assemble DX review artifacts before appending the final report Keep early DX evidence above decisions, update artifact sections in place, and append the report using the actual current file suffix. Re-read after deleting an existing report before choosing the append anchor. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep outside plan reviews exclusive and invocation-owned Follow one preflight-selected backend, terminate failed Codex work before fallback, and allocate extra prompt/output files uniquely. Consume only the current invocation’s completed output. Co-authored-by: OpenAI Codex <noreply@openai.com> * Select periodic completion evaluations for report writer changes Register the shared review resolver for eight missing consumers and regress selection for all nine completion cases without changing their IDs or tiers. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep permission ambiguity fixtures on the same normalized target Use distinct raw spellings of one target in the four negative fixtures so they exercise the normalized duplicate-owner guard after exact current-file disambiguation. Preserve the existing exception, no-input, diagnostic and cleanup assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Clarify preserved contracts in engineering review fixture Co-authored-by: OpenAI Codex <noreply@openai.com> * Recognize the offered DX follow-up handoff Co-authored-by: OpenAI Codex <noreply@openai.com> * Check independent commitments before presenting review options Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep Codex review output and status in one shell invocation Co-authored-by: OpenAI Codex <noreply@openai.com> * Distinguish seeded plans from reports written by a test attempt Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Autoplan file approvals with bounded viewport resizing Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Bash approvals before binding the complete command Co-authored-by: OpenAI Codex <noreply@openai.com> * Isolate setup message tests from the shared checkout Run the real installer in a temporary payload with private config, require successful completion, and guard source and binary contents and mtimes. Co-authored-by: OpenAI Codex <noreply@openai.com> * Fix periodic native permission and report completion handling Match the pinned CLI's soft wraps and clipped headings without granting from incomplete frames. Retire completed file requests, retain mode annotations, and ask section captures for a short final acknowledgement after their full report is saved. Co-authored-by: OpenAI Codex <noreply@openai.com> * Preserve review approvals and validate DX comparison artifacts Keep independent remedies and approved amendments explicit. Give the synthetic DX review its existing documentation and validate peer comparison as required analysis alongside four native decisions. Add positive and negative semantic calibrations while preserving review counts, model budgets and prompt size limits. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make the five-finding CEO fixture's application boundary explicit Materialize the request adapter and service composition used by the synthetic payment application. Explicitly declare the revised unregistered-event and mail-telemetry assumptions while preserving uncaught handler errors, the original invoice path and all five unresolved findings. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO state-path checks scoped to directory preparation Co-authored-by: OpenAI Codex <noreply@openai.com> * Use checked ports and bounded cleanup in pair-agent tests Discover the daemon port from its owned state file, retain startup diagnostics, and await failed-start cleanup. Add occupied-port, early-exit, deadline, and foreign-state regressions while preserving the existing HTTP assertions and hook budgets. Co-authored-by: Codex <noreply@openai.com> * Preserve queued edit identity and recover clipped Bash permissions Distinguish separately queued unfinished edits from mutation of one native tool ID. Keep grants bound to an exact owned request and reject reused IDs, ambiguous inputs, and competing owners. Support the pinned renderer's literal em dash and request a repaint when only the Bash card's top rule is clipped. Grants still require the complete fresh card and an exact native acknowledgment. Validation: 413 integrated parser/event tests passed; private repaint controls and joint source review passed. Full canonical suite and native periodic rerun remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep periodic reviews within their approved contracts and deliverables Carry exact approvals through engineering review, preserve declared contracts when amending CEO plans, and keep prioritization at the requested decision level. Materialize the revised synthetic SDK reference contract while retaining the five original documentation gaps. Accept the observed semicolon in the finite DX handoff menu and register the direct source dependencies used by the engineering cases. Regenerate canonical review documents without changing model budgets, retries, count bands, or native completion assertions. Validation: all-host generation and 275 review, fixture, selection and parity tests passed. Full free-suite and native periodic validation remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep Eng approval cadence and independence guards explicit * Accept ordinary punctuation in manual review handoffs * Recover file permissions alongside queued Bash calls * Carry approved DX work through later review findings * Clarify the synthetic auth internal failure decision * Bound the periodic DX fixture to onboarding changes * Recognize native Design review handoff labels * Hold scope in the integration-choice review fixture * Carry approved Design decisions through review evidence * Capture listener state when feedback reload fails * Exclude workspace caches before checking deprecated flags * Verify Design UI scope against a seeded review plan * Clarify plan review decisions and outside-voice approval flow * Reject setup menus in the Design UI gate * docs: require focused repair validation before final acceptance * fix: separate review commitments within existing prompt budgets * docs: align generation and contributor validation guidance * fix: advance native review prompts and count acknowledged findings * chore: bump version and changelog (v1.87.1.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: enforce cheap checks and side-effect-free validation previews * fix: handle owned Fetch permissions and oversized native cards * test: ground review fixtures in independent executable contracts * fix: preserve review decisions and verify reports before completion * test: construct the synthetic credential URL without a scanner false positive * test: materialize DX examples and verify their actual local behavior * fix: clarify CEO review decisions and execution order * fix: clarify review workflow ordering and select Design quality checks * Fix review decision gates and incomplete evaluation fixtures Persist CEO and engineering commitment ledgers before menus, preserve exact approvals, and distinguish implementation structure from feature scope. Route Autoplan through the canonical CEO Step 0 ordering. Classify DX findings before requesting approval and ground runtime claims in actual evidence. Complete neutral non-target fixture contracts and accept the captured Design handoff purpose without relaxing its ownership or acknowledgment checks. Record runtime-capability verification in AGENTS.md validation discipline. Validation: 1,335 focused tests passed across 21 files; build, all-host freshness, skill validation (647 artifacts / 107 tracked), and credential checks passed. Prior paid failures are preserved; behavioral acceptance remains pending. * Fix review decision boundaries and owned Read prompts Preserve exact approvals across review options, compare consistent DX milestones, and keep proposed implementation separate from review evidence. Bind modern Read prompts to one immutable native request and wait for its result. Retain captured regression verdicts, correct fixture error names, improve import probe diagnostics, and record focused-first validation discipline in AGENTS.md. * Clarify CEO and engineering review decisions Use explicit decision steps, one engineering ledger, and clear scope/write transitions. Preserve exact approvals and distinguish pending test requirements. Keep unrelated generated content unchanged. * Fix review decision ordering and native evaluation interactions * Clarify engineering decisions and test artifact order * Clarify pending choices and approvals in CEO reviews * Make CEO review phases sequential and clarify completion * Fix Design board submission intent matching * Seed an existing browser test baseline for Autoplan * Document decision-log payloads before state initialization * Preserve exact review scope and decide one change before drafting options * Require input identity before repeating passing model judges * Honor permitted storage throughout CEO review completion * Match complete native permission text within the pinned renderer contract * Align review approvals, independent choices, and bounded validation * fix: preserve reopened approvals and declare fixture interfaces * fix: isolate review artifacts and audit complete questions * fix: match detector artifact permissions to configured storage * fix: complete native permissions and review fixture workflows * fix: order CEO review work and separate engineering guarantees * fix: preserve native validation and separate review choices * fix: clarify review decisions and judge complete report context * fix: constrain review judgments and retain parse failures * fix: compare each affected value before review decisions * fix: make engineering review decisions and completion order explicit * fix: give the complete Autoplan evaluation a bounded chain budget * fix(cso): diagnose forbidden Docker endpoints before tool lookup * fix(reviews): reconcile workflow contracts and generated artifacts after main integration * fix(evals): migrate retained regressions to the native review harness * fix(tests): close native harness and workflow integration regressions * fix(evals): preserve complete permission context and native menu contracts * fix(tests): capture synchronous command output without pipe drain stalls * fix(reviews): clarify decision and completion ordering * fix(reviews): separate decision readiness from final completion checks * refactor(reviews): consolidate decision rules and completion branches * fix(plan-eng-review): order preparation and clarify decision routing * fix(plan-eng-review): restore size and question-format guard parity * fix(plan-eng-review): clarify scope phases and blocked completion * fix(plan-eng-review): unify review flow and report destination * fix(plan-eng-review): define bootstrap and question stage ownership * fix(plan-eng-review): clarify review structure and design lookup * fix(plan-eng-review): render report examples and show saved decisions * fix: consolidate Eng review decisions and select their evaluations * test: cover overlapping terminal attachments and clean merged runner type * fix: preserve Office Hours relationship closings during review updates * fix: retain pasted review targets across slash invocations * docs: preserve validation traces and correct release scope * test: cover pasted targets in both review skills * fix: validate report artifacts before recording success * fix: redact source roots at CSO report boundaries * fix: bind native Design questions before answering * test: select report privacy and native recovery regressions * test: bind rejection predicate in extracted observers * fix: bind complete boxed native questions * test: keep the Design UI fixture on native review * fix: preserve review decisions and evaluation completion outcomes * fix: clarify CEO approval and report completion order * fix: align native review evaluation ownership and completion * fix: bind review evaluators to native decisions and owned artifacts * fix: validate review decisions against native outcomes * fix: preserve review evidence and Autoplan phase handoffs * test: bind review evidence to owned decisions and completion * fix: retain owned native history across compaction * fix(evals): validate current review decisions and setup choices * fix: bind Autoplan reviews and phase completion to current amended input * fix: reconcile native review evidence and close Autoplan phases * test: recognize owned whole-candidate complexity decisions * test: preserve report freshness for approved investigation handoffs * fix: recognize scoped review findings and isolate dual voice fixtures * fix: make review handoffs and question dispatch self-contained * test: recognize complete CEO decisions and procedural pauses * fix: bind current CEO comparison options and risk intervals * test: bind engineering decisions and completion to owned evidence * fix: publish Autoplan phase reports before continuing tools * test: verify actual Autoplan dual-review dispatch evidence * test: select dual review when shared evidence fixtures change * fix: clarify plan review decisions and completion gates * fix: make CEO review decisions and return paths explicit * test: keep Autoplan prompt files inside attempt state * test: preserve source whitespace across permission dialog wraps * fix: publish Autoplan phase reports before continuing * test: recognize current CEO comparisons and reject inactive records * fix: reconcile engineering decision states before completion * test: recognize complete Design decisions and reports * test: verify current engineering decisions before navigation * Recognize source-owned component reduction choices * fix: recognize current CEO ledger and commitment grids * test: supply RequestPolicy context to Eng count fixture * fix: save complete engineering decisions before asking * fix: bind Autoplan publication to the complete phase readback * chore: prepare 1.87.5.0 reliability release * fix: clarify engineering review completion and preserve log failures * fix: bind CEO saved choices and current section ancestry * fix(evals): bind review execution and completion evidence * fix(plan-ceo-review): verify complete decisions before asking * fix(evals): preserve complete engineering choice records * fix(evals): preserve complete review outcomes and bounded fixtures * fix(autoplan): publish phase reports before advancing * fix(plan-ceo-review): validate option fields before asking * fix(plan-eng-review): verify current decisions after answers * fix(evals): bind review decisions and bound fixture scope * fix(plan-ceo-review): verify decision rows and edit saved checkpoints * fix(evals): bind review evidence and scope document lookup * fix(plan-eng-review): update resolution state with its answer * fix(reviews): preserve complete questions through dispatch * fix(evals): recognize completed mode declarations * fix(evals): define cache consistency at wrapper completion * fix(evals): validate owned initial scope and completed review handoffs * fix: assemble complete CEO decision fields before saving * fix: authenticate automatic mode decisions without guessing selectors * fix: bind engineering coverage to approved regression contracts * fix(evals): supply review helpers to native Eng capture * fix(plan-eng-review): preserve the full selected option scope * fix(evals): recognize owned engineering seed and regression evidence * fix(evals): bind engineering retry reports to native approvals * docs: clarify release guarantees (v1.87.5.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix(evals): recognize owned engineering decisions and handoffs * fix(evals): bind engineering decisions and completion evidence * fix(tests): align review contracts and selection fixtures * fix(skills): restore review prompt size limits * fix(plan-eng-review): clarify review execution and completion * fix(evals): preserve configured retries through all supervision layers * Clarify Engineering decisions and report completion * Keep native decision assertions within their source boundary * fix: recognize owned engineering decisions and completed navigation * fix: bind completed auto decisions to their current review * fix: recognize explicit CEO source attribution * fix: dispatch verified CEO decisions without recomposing fields * test: expose existing execution deadlines to review actors * fix: distinguish CEO decision records from incidental headings * test: bind split-scope choices to the registered native actor * test: connect reviewed regressions to required evaluation coverage * Clarify CEO decision routing and completion stages * test: expose existing section review deadlines to fixture actors * test: recognize complete native CEO pacing inventories * test: exclude answered history from current CEO payloads * test: detect phase entry through owned skill HOME aliases * test: validate native review completion and owned report permissions * fix: make Autoplan close packets carry the parent handoff steps * test: assess source-bound HOLD decisions within the existing deadline * fix: keep CEO native decision fields under one formatting authority * test: register integrated review and permission dependencies * test: align native review adapters and finding coverage Preserve explicit AUTO decisions, apply native single-select defaults, and bind complete cropped questions and report permissions to their owned requests. Require seeded review findings instead of crediting setup menus. Keep captured failure controls and additive selection dependencies. The integrated candidate passed 3,099 focused tests across 65 files; affected paid validation remains required before publication. * fix(autoplan): require phase reports before advancing * fix(evals): bind setup and evidence to complete attempts * fix(evals): bind native answers and pending writes to fixture scope Preserve complete option rows when native descriptions wrap, retain current owned Write arguments before journal publication, and keep engineering and DX answers within their declared fixture interfaces. Add captured free regressions without increasing model budgets or relaxing completion checks. * fix(autoplan): verify phase reports across native tool paths Guard owned methodology reads and reviewer dispatches, detect complete driver loads through Bash, and distinguish report-only edits from implementation changes. Follow authenticated native UUID ancestry when journal writes arrive out of order and verify earlier native content for cached phase reads. Keep current close acknowledgment and parent publication in order, require CEO entry before later phases, and register captured failure regressions. * fix(evals): honor native input and collection lifecycles Match complete native Edit panes and truncated question borders, reject stderr close before EOF, and stop the CEO split fixture once its acknowledged scope decisions are collected. Keep semantic validation, process failures, report requirements, and absolute deadlines authoritative. Add captured-event and real-process regressions with selection dependencies. Focused checks pass; final integrated paid and full-suite acceptance remain pending. * fix(autoplan): retain native session ownership across directory changes Recover missed native UUID ancestry through the existing strict graph while preserving ordinary event order and legacy scoping. Bind publication hooks to Claude's original project directory while retaining current cwd for requested file paths. Captured public-event regressions, existing caller checks, and a pinned native CLI loopback verify both fixes. Preserve failed attempts and require fresh paid and final full-suite acceptance. * docs: align evaluation limits and completion version * fix(autoplan): allow authenticated phase reads during journal streaming * fix(evals): bind clipped native questions and owned edit dialogs * fix: preserve overlay retries and bounded cleanup * fix: recognize owned planning preludes in native questions * docs: explain overlay scheduling and cleanup guarantees * fix: require fresh publication after Autoplan phase reruns * Release gstack 1.87.6 * fix: preserve CI paths, process identity, and test deadlines * fix: keep informational setup commands independent of install probes * fix: clarify plan review decisions and bound source audit reports * Fix remaining Windows identity and native path CI failures * Clarify CEO review decision and reviewer-result routing * test: accept no-install planner in retry supervision * fix(ceo-review): make review decisions and report completion explicit * perf(test): add fast PR gates, input-keyed judge reuse and isolated free shards * fix(test): start isolated CEO smoke from its existing project plan * fix(test): repair CI fixture races and preserve retry evidence * fix(ceo-review): clarify approvals, depth and saved completion --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
494 lines
31 KiB
TypeScript
494 lines
31 KiB
TypeScript
import { expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
import { runGeneration } from '../scripts/gen-skill-docs';
|
|
import { ALL_HOST_NAMES, getHostConfig } from '../hosts';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
test('every host exposes the DX per-call rule before the pre-review audit and Step 0', async () => {
|
|
const outputRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'devex-rule-free-'));
|
|
try {
|
|
const generated = await runGeneration({ host: 'all', outputRoot });
|
|
expect(generated.exitCode).toBe(0);
|
|
const skills = generated.artifacts.filter(artifact => artifact.kind === 'skill'
|
|
&& /(?:^|\/)gstack-plan-devex-review\/SKILL\.md$|^plan-devex-review\/SKILL\.md$/.test(artifact.relativePath));
|
|
expect(skills.map(artifact => artifact.host).sort()).toEqual([...ALL_HOST_NAMES].sort());
|
|
for (const artifact of skills) {
|
|
const content = fs.readFileSync(path.join(outputRoot, artifact.relativePath), 'utf8');
|
|
const audit = content.indexOf('## PRE-REVIEW SYSTEM AUDIT');
|
|
expect(audit).toBeGreaterThan(0);
|
|
const beforeAudit = content.slice(0, audit);
|
|
expect(beforeAudit).toContain('including Step 0 and outside voice');
|
|
expect(beforeAudit).toContain('One independent choice per AskUserQuestion call, never separate tabs');
|
|
// Claude loads the review section later; these evidence limits must also
|
|
// govern Step 0's first journey questions on every host.
|
|
const earlyEvidence = beforeAudit.replace(/\s+/g, ' ');
|
|
expect(earlyEvidence).toContain('A description of what a reporter includes does not establish its exact words');
|
|
expect(earlyEvidence).toContain('Confirmation of an empathy narrative is not runtime observation');
|
|
// The retained DX run reopened an approved CLI/library entrypoint after
|
|
// its outside prompt reduced the mode to "no new APIs". These are source
|
|
// propagation checks; the native eval still owns behavioral acceptance.
|
|
expect(earlyEvidence).toContain('selected option, answer reference and approved scope');
|
|
expect(earlyEvidence).toContain("user's task boundaries and requested mode, amended only by exact approved exceptions");
|
|
expect(earlyEvidence).toContain("A mode's default does not cancel an explicitly approved exception");
|
|
// Required factual/navigation repair is review work; it must not become
|
|
// an approval solely because the rating pass finds a gap. New approaches
|
|
// and policies still go through the same gate.
|
|
const classification = earlyEvidence.slice(earlyEvidence.indexOf('2. **Classify the finding.**'),
|
|
earlyEvidence.indexOf('3. **Check the scope.**'));
|
|
expect(classification).toContain('verifying sources, correcting facts and restoring docs or navigation');
|
|
expect(classification).toContain('unverified behavior or destinations stay unknown');
|
|
expect(classification).toContain('A new presentation approach, guarantee, channel, scope extension or optional verification depth remains a decision');
|
|
const rating = content.slice(content.indexOf('## The 0-10 Rating Method'));
|
|
expect(rating).toContain('4. Run the Decision gate for each gap.');
|
|
expect(rating).not.toContain('Resolve each new in-scope gap via AskUserQuestion');
|
|
const journey = content.slice(content.indexOf('### 0F.'), content.indexOf('### 0G.'));
|
|
const wholeGate = journey.indexOf('Run all four Decision gate steps');
|
|
expect(wholeGate).toBeGreaterThanOrEqual(0);
|
|
expect(wholeGate).toBeLessThan(journey.indexOf('> "Journey Stage: INSTALL'));
|
|
expect(journey).not.toContain('AskUserQuestion per friction point');
|
|
const mode = content.slice(content.indexOf('### 0E. Mode Selection'), content.indexOf('Context-dependent defaults:'));
|
|
expect(mode).toContain('Use the mode the user explicitly requested for this review.');
|
|
expect(mode).toContain('skip the mode question and continue to 0F. Otherwise, ask below.');
|
|
const sectionText = generated.artifacts.filter(item => item.kind === 'section'
|
|
&& item.host === artifact.host && item.relativePath.startsWith('plan-devex-review/'))
|
|
.map(item => fs.readFileSync(path.join(outputRoot, item.relativePath), 'utf8')).join('\n');
|
|
const allContent = content + '\n' + sectionText;
|
|
expect(allContent).toContain('if viable, split them before asking');
|
|
expect(allContent).toContain('A code example and an optional checklist are separate choices');
|
|
expect(allContent).toContain('as are a timer and its release-gate policy');
|
|
const gate = beforeAudit.indexOf('### Decision gate');
|
|
const ground = beforeAudit.indexOf('1. **Ground the evidence.**', gate);
|
|
const classify = beforeAudit.indexOf('2. **Classify the finding.**', gate);
|
|
const scope = beforeAudit.indexOf('3. **Check the scope.**', gate);
|
|
const options = beforeAudit.indexOf('4. **Draft and answer one decision.**', gate);
|
|
expect([gate, ground, classify, scope, options].every((offset, i, offsets) =>
|
|
offset >= 0 && (i === 0 || offset > offsets[i - 1]!))).toBe(true);
|
|
const localRule = allContent.slice(allContent.indexOf('## CRITICAL RULE — How to ask questions'),
|
|
allContent.indexOf('## Required Outputs', allContent.indexOf('## CRITICAL RULE — How to ask questions')));
|
|
expect(localRule).toContain('Run the Decision gate before drafting options.');
|
|
expect(localRule).not.toContain('use AskUserQuestion for each gap');
|
|
expect(allContent).toContain('Record observed human onboarding separately from automated execution');
|
|
expect(allContent).toContain('a warm snippet timer is neither a fresh-start check nor a human benchmark');
|
|
expect(allContent).toContain('Keep estimates labeled until measured');
|
|
const benchmark = content.slice(content.indexOf('### 0C. Competitive DX Benchmarking'),
|
|
content.indexOf('### 0D. Magical Moment Design'));
|
|
expect(benchmark.indexOf('Define the clock before comparing')).toBeGreaterThanOrEqual(0);
|
|
expect(benchmark.indexOf('Define the clock before comparing')).toBeLessThan(benchmark.indexOf('AskUserQuestion:'));
|
|
expect(benchmark).toContain('Compare times only across equivalent boundaries');
|
|
expect(benchmark).toContain('Never infer no wait from a peer');
|
|
expect(benchmark).toContain('Start → result');
|
|
expect(benchmark).toContain('Carry the approved clock and target into 0D, Pass 1, Pass 8 and the report');
|
|
expect(allContent).toContain('Measure the approved 0C clock and 0D useful result');
|
|
expect(allContent).not.toContain('**STOP.** AskUserQuestion once per issue.');
|
|
expect(allContent).toContain('A target tier does not itself approve telemetry, an automated');
|
|
expect(allContent).toContain('only when proposing them, with ownership and frequency explicit');
|
|
expect(allContent).toContain('Continue the same working list from Step 0');
|
|
expect(allContent).toContain('compare its evidence with the prior decision and options already considered');
|
|
expect(allContent).toContain('A disclosed tradeoff or rejected alternative is not new evidence merely because a reviewer prefers it');
|
|
expect(allContent).toContain('identify a concrete contradiction or changed assumption before reopening');
|
|
expect(allContent).toContain('Unverified loss of existing coverage remains a risk to verify');
|
|
expect(allContent).toContain('not proof that a new release policy is needed');
|
|
expect(allContent).toContain('If a necessary remedy crosses an explicit scope boundary, name that boundary');
|
|
expect(allContent).toContain('obtain scope approval before choosing or applying the remedy');
|
|
expect(allContent).toContain('Implementation details and proof of one chosen behavior\nstay together; independent policies each need their own decision');
|
|
if (!getHostConfig(artifact.host!).suppressedResolvers.includes('CODEX_PLAN_REVIEW')) {
|
|
const outside = allContent.slice(allContent.indexOf('## Outside Voice — Independent Plan Challenge'));
|
|
const context = outside.indexOf('REVIEW CONTEXT (from the full working list, outside the truncated plan body)');
|
|
const planBody = outside.indexOf('THE PLAN:\n<plan content>');
|
|
expect(context).toBeGreaterThan(0);
|
|
expect(planBody).toBeGreaterThan(context);
|
|
expect(outside.slice(context, planBody)).toContain('selected option, answer reference and exact scope');
|
|
expect(outside.slice(context, planBody)).toContain('including any explicitly approved exception');
|
|
expect(outside.slice(context, planBody)).toContain('Missing implementation remains a verification');
|
|
expect(outside.slice(context, planBody)).toContain('concrete new evidence or a changed assumption');
|
|
expect(outside).toContain("Apply the Decision gate's distinction between routine review work and a new choice.");
|
|
} else {
|
|
expect(allContent).not.toContain('REVIEW CONTEXT (from the full working list, outside the truncated plan body)');
|
|
}
|
|
|
|
}
|
|
} finally { fs.rmSync(outputRoot, { recursive: true, force: true }); }
|
|
}, 20_000);
|
|
|
|
// Import the actual paid registration in a child with only its process boundary
|
|
// mocked. Coverage and report validation remain the production predicates.
|
|
function runDxRegistration(scenario: string) {
|
|
const directory = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'devex-registration-free-')));
|
|
const script = path.join(directory, 'registration.test.ts');
|
|
const facts = path.join(directory, 'facts.json');
|
|
fs.writeFileSync(script, `
|
|
import { describe, expect, mock } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as path from 'node:path';
|
|
import { DEVEX_COUNT_FILES, planDevexCountFixture, isDevexReviewIssue, devexReviewModePick }
|
|
from ${JSON.stringify(path.join(ROOT, 'test/helpers/devex-count-fixture.ts'))};
|
|
import captured from ${JSON.stringify(path.join(ROOT, 'test/fixtures/devex-seed-coverage-ad-v3.json'))};
|
|
const { assertReviewReportAtBottom: actualReport, devexStep0Boundary } =
|
|
await import(${JSON.stringify(path.join(ROOT, 'test/helpers/claude-pty-runner.ts'))});
|
|
const scenario = ${JSON.stringify(scenario)};
|
|
const factsPath = ${JSON.stringify(facts)};
|
|
const finalPlan = '# Reviewed DX plan\\n\\nThe five seeded gaps each have a recorded decision.\\n\\n## GSTACK REVIEW REPORT\\n\\nDX review complete.\\n';
|
|
const facts = { checked: false, runnerCalls: 0, reportCalls: 0, judgeCalls: 0, planPath: '', finalPlan: '' };
|
|
const save = () => fs.writeFileSync(factsPath, JSON.stringify(facts));
|
|
mock.module(${JSON.stringify(path.join(ROOT, 'test/helpers/e2e-gate.ts'))}, () => ({
|
|
describeE2ETier: tier => { expect(tier).toBe('periodic'); return describe; },
|
|
}));
|
|
mock.module(${JSON.stringify(path.join(ROOT, 'test/helpers/claude-pty-runner.ts'))}, () => ({
|
|
devexStep0Boundary,
|
|
assertReviewReportAtBottom: content => {
|
|
facts.reportCalls++;
|
|
facts.finalPlan = content;
|
|
save();
|
|
expect(content).toBe(fs.readFileSync(facts.planPath, 'utf8'));
|
|
return actualReport(content);
|
|
},
|
|
runPlanSkillCounting: async opts => {
|
|
facts.runnerCalls++;
|
|
facts.planPath = opts.expectedPlanPath;
|
|
save();
|
|
expect(path.dirname(path.dirname(opts.expectedPlanPath))).toBe(${JSON.stringify(directory)});
|
|
expect(fs.existsSync(path.dirname(opts.expectedPlanPath))).toBe(true);
|
|
// The runner owns the seeded Git project. The caller owns only its report.
|
|
expect(opts.cwd).toBeUndefined();
|
|
expect(opts.skillName).toBe('plan-devex-review');
|
|
expect(opts.slashCommand).toBe('/plan-devex-review');
|
|
expect(opts.timeoutMs).toBe(1500000);
|
|
expect(opts.reviewCountCeiling).toBe(Infinity);
|
|
expect(opts.pickAUQ).toBe(devexReviewModePick);
|
|
expect(opts.isReviewAUQ).toBe(isDevexReviewIssue);
|
|
expect(opts.isLastStep0AUQ).toBe(devexStep0Boundary);
|
|
expect(opts.env).toEqual({ QUESTION_TUNING: 'false', EXPLAIN_LEVEL: 'default' });
|
|
expect(opts.followUpPrompt).toBe(planDevexCountFixture(opts.expectedPlanPath) +
|
|
'\\nFinish this DX review; I will handle subsequent reviews manually.');
|
|
expect(opts.fixtureFiles).toEqual(DEVEX_COUNT_FILES);
|
|
expect(opts.followUpPrompt).toContain('Use DX POLISH');
|
|
// These are the five unresolved contracts in the current native fixture.
|
|
expect(opts.fixtureFiles['docs/current-contracts.md']).toContain('There is no skip flag or offline first-run path.');
|
|
expect(opts.fixtureFiles['docs/package-contents.txt']).toContain('that file is absent');
|
|
expect(opts.fixtureFiles['docs/api.md']).toContain('run_eval(dataset, evaluator)');
|
|
expect(opts.fixtureFiles['docs/api.md']).toContain('run_batch(evaluator, dataset)');
|
|
expect(opts.fixtureFiles['docs/api.md']).toContain('AuthError("request failed")');
|
|
expect(opts.fixtureFiles['docs/api.md']).toContain('removes the old name immediately');
|
|
facts.checked = true;
|
|
save();
|
|
if (scenario === 'throw') throw new Error('controlled DX runner failure');
|
|
// Replay public question/reply evidence only. Its historical run did not
|
|
// complete; the terminal/report below are controlled caller-boundary inputs.
|
|
const transcript = { status: 'ready', calls: structuredClone(captured.attempts[0].calls), assistantMessages: [] };
|
|
if (scenario.startsWith('missing-seed-')) transcript.calls.splice(Number(scenario.slice(-1)), 1);
|
|
if (scenario === 'missing-native') transcript.status = 'missing';
|
|
if (scenario === 'repeated-seed') transcript.calls = Array.from({length: 5}, (_, i) =>
|
|
({ ...structuredClone(transcript.calls[0]), toolUseId: 'repeated-' + i }));
|
|
if (scenario === 'batched') {
|
|
const call = structuredClone(transcript.calls[0]);
|
|
call.questions = transcript.calls.flatMap(item => item.questions);
|
|
call.answers = Object.fromEntries(transcript.calls.flatMap(item => Object.entries(item.answers)));
|
|
transcript.calls = [call];
|
|
}
|
|
if (scenario === 'pending') transcript.calls[0].answered = false;
|
|
if (scenario !== 'missing-report') fs.writeFileSync(opts.expectedPlanPath,
|
|
finalPlan + (scenario === 'trailing-report' ? '\\n## Unexpected follow-up\\n' : ''));
|
|
return { outcome: scenario === 'timeout' ? 'timeout' : scenario === 'summary' ? 'completion_summary' : 'plan_ready',
|
|
transcript, fingerprints: [], step0Count: 2, reviewCount: scenario.startsWith('missing-seed-') ? 100 : 5,
|
|
elapsedMs: 100, evidence: 'controlled DX observation' };
|
|
},
|
|
}));
|
|
mock.module(${JSON.stringify(path.join(ROOT, 'test/helpers/plan-review-decisions.ts'))}, () => ({
|
|
evaluatePlanReviewDecisions: () => { facts.judgeCalls++; save(); throw new Error('unexpected paid judge'); },
|
|
}));
|
|
await import(${JSON.stringify(path.join(ROOT, 'test/skill-e2e-plan-devex-finding-count.test.ts'))});
|
|
`);
|
|
try {
|
|
const child = Bun.spawnSync([process.execPath, 'test', script], {
|
|
cwd: ROOT, timeout: 10_000,
|
|
env: { PATH: process.env.PATH ?? '', HOME: directory, TMPDIR: directory, TMP: directory, TEMP: directory,
|
|
GIT_CONFIG_NOSYSTEM: '1', ...(process.env.SystemRoot ? { SystemRoot: process.env.SystemRoot } : {}) },
|
|
});
|
|
const output = child.stdout.toString() + child.stderr.toString();
|
|
expect(child.signalCode ?? null, output).toBeNull();
|
|
expect(fs.existsSync(facts), output).toBe(true);
|
|
const observed = JSON.parse(fs.readFileSync(facts, 'utf8'));
|
|
expect(observed.checked, output).toBe(true);
|
|
expect(observed.runnerCalls, output).toBe(1);
|
|
expect(observed.judgeCalls, output).toBe(0);
|
|
expect(fs.existsSync(path.dirname(observed.planPath)), 'actual paid finally must remove its owned report directory').toBe(false);
|
|
return { output, exitCode: child.exitCode, observed };
|
|
} finally { fs.rmSync(directory, { recursive: true, force: true }); }
|
|
}
|
|
|
|
test('the actual DX registration supplies its complete native fixture and preserves runner failure', () => {
|
|
const result = runDxRegistration('throw');
|
|
expect(result.exitCode, result.output).toBe(1);
|
|
expect(result.output).toContain('controlled DX runner failure');
|
|
expect(result.observed.reportCalls).toBe(0);
|
|
});
|
|
|
|
for (const outcome of ['success', 'summary']) test(`DX registration accepts completed seed decisions and the owned final report: ${outcome}`, () => {
|
|
const result = runDxRegistration(outcome);
|
|
expect(result.exitCode, result.output).toBe(0);
|
|
expect(result.observed.reportCalls).toBe(1);
|
|
expect(result.observed.finalPlan).toContain('## GSTACK REVIEW REPORT');
|
|
});
|
|
|
|
for (const scenario of [
|
|
...Array.from({ length: 5 }, (_, index) => 'missing-seed-' + index),
|
|
'missing-native', 'repeated-seed', 'batched', 'pending',
|
|
]) test(`DX registration requires complete distinct native coverage: ${scenario}`, () => {
|
|
const result = runDxRegistration(scenario);
|
|
expect(result.exitCode, result.output).toBe(1);
|
|
expect(result.output).toContain('SEEDED COVERAGE FAIL');
|
|
expect(result.observed.reportCalls).toBe(0);
|
|
});
|
|
|
|
for (const scenario of ['missing-report', 'trailing-report', 'timeout']) test(`DX registration rejects incomplete delivery: ${scenario}`, () => {
|
|
const result = runDxRegistration(scenario);
|
|
expect(result.exitCode, result.output).toBe(1);
|
|
expect(result.output).toContain(scenario === 'timeout' ? 'outcome=timeout' : 'D19 FAIL');
|
|
expect(result.observed.reportCalls).toBe(scenario === 'trailing-report' ? 1 : 0);
|
|
});
|
|
|
|
test('materialized DX references have working local links without inventing completed launch work', () => {
|
|
const fixture = path.join(ROOT, 'test/fixtures/devex-existing-sdk');
|
|
const files = ['README.md', 'docs/getting-started.md', 'docs/feedback.md', 'docs/reference-v1.md'];
|
|
for (const file of files) {
|
|
const body = fs.readFileSync(path.join(fixture, file), 'utf8');
|
|
for (const [, target] of body.matchAll(/\[[^\]]+\]\(([^)]+)\)/g)) {
|
|
const [relative, anchor] = target!.split('#');
|
|
const destination = path.resolve(path.dirname(path.join(fixture, file)), relative || path.basename(file));
|
|
expect(destination.startsWith(fixture + path.sep)).toBe(true);
|
|
const linked = fs.readFileSync(destination, 'utf8');
|
|
if (anchor) {
|
|
const headings = [...linked.matchAll(/^#+ (.+)$/gm)].map(match => match[1]!.toLowerCase()
|
|
.replace(/[^\w\s-]/g, '').replace(/\s/g, '-'));
|
|
expect(headings, target).toContain(anchor);
|
|
}
|
|
}
|
|
}
|
|
const readme = fs.readFileSync(path.join(fixture, 'README.md'), 'utf8');
|
|
expect(readme).toContain('no selected primary developer persona or peer-DX study');
|
|
expect(readme).toContain('No first-run duration has\nbeen measured');
|
|
expect(readme).toContain('There is no skip');
|
|
expect(readme).toContain('no interactive demo or designed aha sequence');
|
|
expect(readme).toContain('one ordinary passing case; it has no staged regression');
|
|
const reference = fs.readFileSync(path.join(fixture, 'docs/reference-v1.md'), 'utf8');
|
|
const guide = fs.readFileSync(path.join(fixture, 'docs/getting-started.md'), 'utf8');
|
|
const errorLink = /^Reference: (docs\/[^#]+)#([^\s]+)$/m.exec(guide);
|
|
expect(errorLink).not.toBeNull();
|
|
expect(fs.readFileSync(path.join(fixture, errorLink![1]!), 'utf8')).toBe(reference);
|
|
const errorHeadings = [...reference.matchAll(/^### (.+)$/gm)].map(match => match[1]!.toLowerCase().replace(/\s/g, '-'));
|
|
expect(errorHeadings).toContain(errorLink![2]!);
|
|
|
|
expect(reference).toContain('cannot interrupt arbitrary application code or cap requests made by a separate');
|
|
expect(reference).toContain('those calls have not been executed against\nthe SDK here');
|
|
expect(reference).toContain('Fixture checks execute the local application files and explicit\ncontract doubles');
|
|
});
|
|
|
|
test('materialized DX error examples identify their cause, bound and reachable code reference', () => {
|
|
const reference = fs.readFileSync(path.join(ROOT, 'test/fixtures/devex-existing-sdk/docs/reference-v1.md'), 'utf8');
|
|
const expected = [
|
|
{ heading: '### SDK E002', count: 1, causes: ['MetricTypeError'], values: ['cases[0]'] },
|
|
{ heading: '### SDK E003', count: 2, causes: ['DeadlineExceeded', 'ManagedProviderCostLimit'],
|
|
values: ['deadline_seconds=20', 'max_cost_usd=0.25'] },
|
|
];
|
|
for (const spec of expected) {
|
|
const start = reference.indexOf(spec.heading);
|
|
const next = reference.indexOf('\n##', start + spec.heading.length);
|
|
const section = reference.slice(start, next < 0 ? undefined : next);
|
|
const blocks = [...section.matchAll(/```text\n([\s\S]*?)\n```/g)].map(match => match[1]!);
|
|
expect(blocks, spec.heading).toHaveLength(spec.count);
|
|
for (const [index, block] of blocks.entries()) {
|
|
const code = spec.heading.replace('### SDK ', 'SDK_');
|
|
expect(block.split('\n')[0]).toStartWith(code + ':');
|
|
expect(block).toContain('Cause: ' + spec.causes[index]);
|
|
expect(block).toContain(spec.values[index]!);
|
|
expect(block).toMatch(/^Next: .+/m);
|
|
const anchor = spec.heading.replace('### ', '').toLowerCase().replace(/ /g, '-');
|
|
expect(block).toContain('Reference: docs/reference-v1.md#' + anchor);
|
|
}
|
|
}
|
|
});
|
|
|
|
// Materialize the documented files in a temp directory. These controls test
|
|
// application examples against an explicit contract stub, never the absent SDK.
|
|
const dxDocs = () => Object.fromEntries(['README.md', 'docs/getting-started.md', 'docs/reference-v1.md']
|
|
.map(file => [file, fs.readFileSync(path.join(ROOT, 'test/fixtures/devex-existing-sdk', file), 'utf8')]));
|
|
function dxBlock(body: string, after: string, language: string): string {
|
|
const offset = body.indexOf(after);
|
|
expect(offset, `missing documented example: ${after}`).toBeGreaterThanOrEqual(0);
|
|
const match = new RegExp('```' + language + '\\n([\\s\\S]*?)\\n```').exec(body.slice(offset));
|
|
expect(match, `missing ${language} block after ${after}`).not.toBeNull();
|
|
return match![1]!;
|
|
}
|
|
function runDxDocumentationControl(code: string, payload: unknown) {
|
|
const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'devex-doc-control-'));
|
|
try {
|
|
const script = path.join(directory, 'control.py');
|
|
fs.writeFileSync(script, code);
|
|
// Like bin/gstack-config, support both Python command names. Windows
|
|
// installs normally expose python.exe; avoid preferring its python3 Store alias.
|
|
const python = (process.platform === 'win32' ? ['python', 'python3'] : ['python3', 'python'])
|
|
.map(command => Bun.which(command)).find((command): command is string => command !== null);
|
|
if (!python) throw new Error('Python 3 is required for the DX documentation controls');
|
|
const child = Bun.spawnSync([python, script], { cwd: directory, timeout: 10_000,
|
|
stdin: Buffer.from(JSON.stringify(payload)), stdout: 'pipe', stderr: 'pipe' });
|
|
expect(child.signalCode ?? null, child.stderr.toString()).toBeNull();
|
|
expect(child.exitCode, child.stderr.toString()).toBe(0);
|
|
return child.stdout.toString();
|
|
} finally { fs.rmSync(directory, { recursive: true, force: true }); }
|
|
}
|
|
|
|
test('materialized DX success blocks print the documented structured fields without assuming SDK repr', () => {
|
|
const docs = dxDocs();
|
|
const first = dxBlock(docs['README.md']!, '## Quick start', 'python');
|
|
expect(first).toBe(dxBlock(docs['docs/getting-started.md']!, '## Neutral first evaluation', 'python'));
|
|
const examples = [
|
|
{ code: first, expected: dxBlock(docs['README.md']!, 'Shown application output', 'text') },
|
|
{ code: dxBlock(docs['docs/getting-started.md']!, '## Neutral first evaluation', 'python'),
|
|
expected: dxBlock(docs['docs/getting-started.md']!, 'Shown application output', 'text') },
|
|
{ code: dxBlock(docs['docs/getting-started.md']!, '## Caller-owned metric for free text', 'python'),
|
|
expected: dxBlock(docs['docs/getting-started.md']!, 'Shown free-text application output', 'text') },
|
|
];
|
|
for (const { code } of examples) { expect(code).not.toContain('print(result)'); expect(code).toContain('result.cases'); }
|
|
const output = runDxDocumentationControl(String.raw`
|
|
import contextlib, io, json, sys, types
|
|
examples = json.load(sys.stdin)
|
|
# Deliberate assumed-contract double: not an implementation of eval-sdk.
|
|
def evaluate(target, cases, metric):
|
|
result = []
|
|
for case in cases:
|
|
actual = target(case['inputs'])
|
|
result.append(types.SimpleNamespace(actual=actual, expected=case['expected'], score=metric(actual, case['expected'])))
|
|
return types.SimpleNamespace(cases=result)
|
|
stub = types.ModuleType('eval_sdk'); stub.evaluate = evaluate; sys.modules['eval_sdk'] = stub
|
|
for example in examples:
|
|
output = io.StringIO(); namespace = {}
|
|
with contextlib.redirect_stdout(output): exec(example['code'], namespace)
|
|
assert output.getvalue().strip() == example['expected']
|
|
assert json.loads(output.getvalue())[0]['score'] == 1.0
|
|
# Preserve the caller-owned metric's mismatching-prose behavior separately.
|
|
assert namespace['text_metric']('red', 'green') == 0.0
|
|
print('three documented outputs match the contract stub; no SDK executed')
|
|
`, examples);
|
|
expect(output).toContain('three documented outputs match the contract stub; no SDK executed');
|
|
});
|
|
|
|
test('materialized DX application client bounds actual local process timeouts, retries and reservations', () => {
|
|
const guide = dxDocs()['docs/getting-started.md']!;
|
|
const client = dxBlock(guide, 'Save as `bounded_client.py`', 'python');
|
|
const transport = dxBlock(guide, 'Save as `fixture_transport.py`', 'python');
|
|
const usage = dxBlock(guide, 'Use the application client in the callable', 'python');
|
|
expect(guide).toContain('verified upper bound');
|
|
expect(guide).toContain('not refunded');
|
|
expect(guide).toContain('does not prove that a remote provider cancelled');
|
|
const output = runDxDocumentationControl(String.raw`
|
|
import json, pathlib, subprocess, sys, time, types
|
|
payload = json.load(sys.stdin)
|
|
pathlib.Path('bounded_client.py').write_text(payload['client'])
|
|
pathlib.Path('fixture_transport.py').write_text(payload['transport'])
|
|
from bounded_client import BoundedClient
|
|
# Observe the real handles; subprocess.run still owns timeout/kill/wait.
|
|
original_popen = subprocess.Popen
|
|
children = []
|
|
def capture_popen(*args, **kwargs):
|
|
child = original_popen(*args, **kwargs)
|
|
children.append(child)
|
|
return child
|
|
subprocess.Popen = capture_popen
|
|
command = [sys.executable, 'fixture_transport.py']
|
|
client = BoundedClient(command, timeout_seconds=1, max_attempts=2, total_cents=4, attempt_cents=2)
|
|
assert client({'enabled': True}) == {'ready': True}
|
|
assert client.reserved_cents == 2
|
|
assert client({'enabled': False}) == {'ready': False}
|
|
assert client.reserved_cents == 4
|
|
try: client({'enabled': True}); raise AssertionError('budget exceeded')
|
|
except RuntimeError as e: assert 'spending limit' in str(e)
|
|
assert client.reserved_cents == 4
|
|
# Calls sharing this application client also share one reservation ceiling.
|
|
from concurrent.futures import ThreadPoolExecutor
|
|
client = BoundedClient(command, timeout_seconds=1, max_attempts=2, total_cents=4, attempt_cents=2)
|
|
def concurrent_call(_):
|
|
try: return client({'enabled': True})
|
|
except RuntimeError as e:
|
|
assert 'spending limit' in str(e); return None
|
|
with ThreadPoolExecutor(max_workers=4) as pool: outputs = list(pool.map(concurrent_call, range(4)))
|
|
assert outputs.count({'ready': True}) == 2 and outputs.count(None) == 2
|
|
assert client.reserved_cents == 4
|
|
# Real child failure/retry and real child timeout: no network or SDK involved.
|
|
pathlib.Path('controlled_transport.py').write_text('''import sys, time
|
|
mode = sys.argv[1]
|
|
with open('attempts', 'a') as f: f.write('attempt\\n')
|
|
if mode == 'stall': time.sleep(30)
|
|
if mode == 'fail': sys.exit(75)
|
|
''')
|
|
for mode in ('fail', 'stall'):
|
|
first_child = len(children)
|
|
pathlib.Path('attempts').unlink(missing_ok=True)
|
|
client = BoundedClient([sys.executable, 'controlled_transport.py', mode], timeout_seconds=0.2,
|
|
max_attempts=2, total_cents=6, attempt_cents=2)
|
|
started = time.monotonic()
|
|
try: client({'enabled': True}); raise AssertionError('failed transport succeeded')
|
|
except (RuntimeError, subprocess.TimeoutExpired): pass
|
|
assert time.monotonic() - started < 3
|
|
attempts = pathlib.Path('attempts').read_text().splitlines()
|
|
owned_children = children[first_child:]
|
|
assert len(attempts) == len(owned_children) == 2 and client.reserved_cents == 4
|
|
for child in owned_children:
|
|
assert child.poll() is not None, 'transport process leaked'
|
|
assert child.wait(timeout=0) == child.returncode
|
|
assert child.returncode != 0
|
|
if mode == 'fail': assert child.returncode == 75
|
|
# Insufficient reservation prevents even the retry from starting.
|
|
pathlib.Path('attempts').unlink()
|
|
client = BoundedClient([sys.executable, 'controlled_transport.py', 'fail'], timeout_seconds=1,
|
|
max_attempts=2, total_cents=2, attempt_cents=2)
|
|
try: client({'enabled': True}); raise AssertionError('budget exceeded')
|
|
except RuntimeError as e: assert 'spending limit' in str(e)
|
|
assert len(pathlib.Path('attempts').read_text().splitlines()) == 1
|
|
assert client.reserved_cents == 2
|
|
# The full shown usage sends independent limits to the SDK contract double.
|
|
seen = []
|
|
def evaluate(target, cases, metric, **options):
|
|
seen.append(options)
|
|
assert target(cases[0]['inputs']) == cases[0]['expected']
|
|
return types.SimpleNamespace(cases=[])
|
|
stub = types.ModuleType('eval_sdk'); stub.evaluate = evaluate; sys.modules['eval_sdk'] = stub
|
|
exec(payload['usage'], {})
|
|
assert seen == [{'deadline_seconds': 20, 'max_cost_usd': 0.25}]
|
|
print('local timeout/retry/reservation bounds verified; no SDK/provider call')
|
|
`, { client, transport, usage });
|
|
expect(output).toContain('local timeout/retry/reservation bounds verified; no SDK/provider call');
|
|
});
|
|
|
|
test('materialized DX CLI cases and import targets match the exact shown invocation in an offline contract double', () => {
|
|
const reference = dxDocs()['docs/reference-v1.md']!;
|
|
const cli = reference.slice(reference.indexOf('## CLI'), reference.indexOf('## Errors'));
|
|
const payload = { app: dxBlock(cli, 'Save as `app.py`', 'python'), cases: dxBlock(cli, 'Save as `cases.json`', 'json'),
|
|
command: dxBlock(cli, 'Run with the assumed SDK', 'bash') };
|
|
expect(JSON.parse(payload.cases)).toEqual([{ inputs: { enabled: true }, expected: { ready: true } }]);
|
|
const output = runDxDocumentationControl(String.raw`
|
|
import argparse, importlib, json, pathlib, shlex, sys
|
|
payload = json.load(sys.stdin)
|
|
pathlib.Path('app.py').write_text(payload['app']); pathlib.Path('cases.json').write_text(payload['cases'])
|
|
# Parse the documented command as an explicit contract double, not the absent CLI.
|
|
args = shlex.split(payload['command']); assert args[:2] == ['eval-sdk', 'run']
|
|
parser = argparse.ArgumentParser()
|
|
for flag in ('target', 'cases', 'metric', 'deadline-seconds', 'max-cost-usd'): parser.add_argument('--' + flag, required=True)
|
|
parser.add_argument('--no-input', action='store_true')
|
|
options = parser.parse_args(args[2:])
|
|
assert options.no_input and options.deadline_seconds == '20' and options.max_cost_usd == '0.25'
|
|
def resolve(value):
|
|
module, name = value.split(':'); return getattr(importlib.import_module(module), name)
|
|
target, metric = resolve(options.target), resolve(options.metric)
|
|
cases = json.loads(pathlib.Path(options.cases).read_text())
|
|
assert isinstance(cases, list) and len(cases) == 1
|
|
for case in cases:
|
|
assert set(case) == {'inputs', 'expected'}
|
|
assert metric(target(case['inputs']), case['expected']) == 1.0
|
|
print('shown cases file, CLI arguments and import targets agree; no SDK executed')
|
|
`, payload);
|
|
expect(output).toContain('shown cases file, CLI arguments and import targets agree; no SDK executed');
|
|
});
|