Files
gstack/test/helpers/native-auto-decide.ts
T
Garry TanandOpenAI Codex 636175d349 v1.87.6.0 fix: make checks reliable and everyday validation faster (#2898)
* fix: acknowledge seeded plans before invoking review skills

* fix: distinguish current plan input from conversation history

* fix: keep hermetic plan reviews on manual permissions

* fix: distinguish tool discovery from file permission ownership

* fix: preserve initial plan mode in observation tests

* fix: wait for scope decisions before writing review findings

* fix: carry autoplan decisions consistently into review artifacts

* test: retain native failure context in periodic assertions

* fix: advance active file permissions before queued questions

* fix: finish red-team attempts before retry and cleanup

* fix: finalize plan format captures and judges before retry

* fix: cancel setup-gbrain SDK attempts before fixture cleanup

* test: select periodic consumers of the bounded attempt helper

* fix native Bash permission cards and queued questions

* fix: preserve independent decisions and review scope

Keep CEO approach, engineering scope and outside-review choices from approving independent remedies together. Carry declared contracts through DX polish and resolve new gaps before editing the plan. Regenerate every host and retain existing stop boundaries.

Validation: 654 focused tests passed across nine files; all-host generation passed. Full free and periodic validation pending.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: require approval before design plan amendments

Align the Design review philosophy and rating recipe with its section protocol: resolve one proposed fix, then apply only that approved decision and retain honest scores for declined fixes.

Validation: 469 focused tests passed across four files; all-host generation passed.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: observe native question completion before transcript persistence

Match owned completion hooks to submitted choices, reject conflicting or late answers, and retain bounded failure evidence.

* test: recognize review posture in acknowledged native questions

Require the selected mode acknowledgement, a completed follow-up question, and its current decoded display while preserving existing posture assertions.

* fix: preserve settled CEO choices and isolate pending remedies

Resolve established approach gates with cited authority and keep independent fixes out of unrelated option commitments and plan amendments.

* fix: carry approved DX choices through later review steps

Choose documentation approaches within the accepted scope and map resolved confusion points without reopening them through a bulk menu.

* test: handle native settings-file edit prompts

Keep one-time owned-file approvals and retain the actual sampled Autoplan permission frame with its matching barrier state.

* test: accept standard CEO reply directives with tuning footers

Recognize the exact trailing preference footer and letter-list directive while preserving current-display and exact acknowledgement checks.

* test: scope split reviewers to their generated plan artifacts

* test: observe native Bash permissions and invocation results

* test: handle owned Bash prompts during mode preference checks

* test: preserve synchronous subprocess rejection in Codex fixture

* Fix periodic review handoff navigation

Recognize review-first and explicit manual-next-step labels while preserving exact action families, manual preference, and ambiguous-menu rejection.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Bind pending file permissions to distinct current targets

Allow one captured file request to own the complete current dialog while unrelated file work is pending. Preserve same-path ambiguity, exact input ownership, and one-time grant checks.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Make paired CEO verification choices genuinely unresolved

Start the positive control with proposed manual checks so its unchanged oracle measures two new coverage decisions. Preserve runtime contracts, targets, count bounds, and all assertions.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Keep CEO review options and verification within approved scope

Audit every offered option for independent add-ons and keep new verification depth pending until accepted. Preserve already requested coverage and trace plan changes to the actual decision.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Assemble DX review artifacts before appending the final report

Keep early DX evidence above decisions, update artifact sections in place, and append the report using the actual current file suffix. Re-read after deleting an existing report before choosing the append anchor.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Keep outside plan reviews exclusive and invocation-owned

Follow one preflight-selected backend, terminate failed Codex work before fallback, and allocate extra prompt/output files uniquely. Consume only the current invocation’s completed output.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Select periodic completion evaluations for report writer changes

Register the shared review resolver for eight missing consumers and regress selection for all nine completion cases without changing their IDs or tiers.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Keep permission ambiguity fixtures on the same normalized target

Use distinct raw spellings of one target in the four negative fixtures so they exercise the normalized duplicate-owner guard after exact current-file disambiguation. Preserve the existing exception, no-input, diagnostic and cleanup assertions.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Clarify preserved contracts in engineering review fixture

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Recognize the offered DX follow-up handoff

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Check independent commitments before presenting review options

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Keep Codex review output and status in one shell invocation

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Distinguish seeded plans from reports written by a test attempt

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Recover clipped Autoplan file approvals with bounded viewport resizing

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Recover clipped Bash approvals before binding the complete command

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Isolate setup message tests from the shared checkout

Run the real installer in a temporary payload with private config, require successful completion, and guard source and binary contents and mtimes.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Fix periodic native permission and report completion handling

Match the pinned CLI's soft wraps and clipped headings without granting from incomplete frames. Retire completed file requests, retain mode annotations, and ask section captures for a short final acknowledgement after their full report is saved.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Preserve review approvals and validate DX comparison artifacts

Keep independent remedies and approved amendments explicit. Give the synthetic DX review its existing documentation and validate peer comparison as required analysis alongside four native decisions. Add positive and negative semantic calibrations while preserving review counts, model budgets and prompt size limits.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Make the five-finding CEO fixture's application boundary explicit

Materialize the request adapter and service composition used by the synthetic payment application. Explicitly declare the revised unregistered-event and mail-telemetry assumptions while preserving uncaught handler errors, the original invoice path and all five unresolved findings.

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Keep CEO state-path checks scoped to directory preparation

Co-authored-by: OpenAI Codex <noreply@openai.com>

* Use checked ports and bounded cleanup in pair-agent tests

Discover the daemon port from its owned state file, retain startup diagnostics, and await failed-start cleanup. Add occupied-port, early-exit, deadline, and foreign-state regressions while preserving the existing HTTP assertions and hook budgets.

Co-authored-by: Codex <noreply@openai.com>

* Preserve queued edit identity and recover clipped Bash permissions

Distinguish separately queued unfinished edits from mutation of one native tool ID. Keep grants bound to an exact owned request and reject reused IDs, ambiguous inputs, and competing owners.

Support the pinned renderer's literal em dash and request a repaint when only the Bash card's top rule is clipped. Grants still require the complete fresh card and an exact native acknowledgment.

Validation: 413 integrated parser/event tests passed; private repaint controls and joint source review passed. Full canonical suite and native periodic rerun remain pending.

Co-authored-by: Codex <noreply@openai.com>

* Keep periodic reviews within their approved contracts and deliverables

Carry exact approvals through engineering review, preserve declared contracts when amending CEO plans, and keep prioritization at the requested decision level. Materialize the revised synthetic SDK reference contract while retaining the five original documentation gaps.

Accept the observed semicolon in the finite DX handoff menu and register the direct source dependencies used by the engineering cases. Regenerate canonical review documents without changing model budgets, retries, count bands, or native completion assertions.

Validation: all-host generation and 275 review, fixture, selection and parity tests passed. Full free-suite and native periodic validation remain pending.

Co-authored-by: Codex <noreply@openai.com>

* Keep Eng approval cadence and independence guards explicit

* Accept ordinary punctuation in manual review handoffs

* Recover file permissions alongside queued Bash calls

* Carry approved DX work through later review findings

* Clarify the synthetic auth internal failure decision

* Bound the periodic DX fixture to onboarding changes

* Recognize native Design review handoff labels

* Hold scope in the integration-choice review fixture

* Carry approved Design decisions through review evidence

* Capture listener state when feedback reload fails

* Exclude workspace caches before checking deprecated flags

* Verify Design UI scope against a seeded review plan

* Clarify plan review decisions and outside-voice approval flow

* Reject setup menus in the Design UI gate

* docs: require focused repair validation before final acceptance

* fix: separate review commitments within existing prompt budgets

* docs: align generation and contributor validation guidance

* fix: advance native review prompts and count acknowledged findings

* chore: bump version and changelog (v1.87.1.0)

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* chore: enforce cheap checks and side-effect-free validation previews

* fix: handle owned Fetch permissions and oversized native cards

* test: ground review fixtures in independent executable contracts

* fix: preserve review decisions and verify reports before completion

* test: construct the synthetic credential URL without a scanner false positive

* test: materialize DX examples and verify their actual local behavior

* fix: clarify CEO review decisions and execution order

* fix: clarify review workflow ordering and select Design quality checks

* Fix review decision gates and incomplete evaluation fixtures

Persist CEO and engineering commitment ledgers before menus, preserve exact
approvals, and distinguish implementation structure from feature scope.
Route Autoplan through the canonical CEO Step 0 ordering. Classify DX findings
before requesting approval and ground runtime claims in actual evidence.

Complete neutral non-target fixture contracts and accept the captured Design
handoff purpose without relaxing its ownership or acknowledgment checks.
Record runtime-capability verification in AGENTS.md validation discipline.

Validation: 1,335 focused tests passed across 21 files; build, all-host freshness,
skill validation (647 artifacts / 107 tracked), and credential checks passed.
Prior paid failures are preserved; behavioral acceptance remains pending.

* Fix review decision boundaries and owned Read prompts

Preserve exact approvals across review options, compare consistent DX milestones,
and keep proposed implementation separate from review evidence. Bind modern
Read prompts to one immutable native request and wait for its result.

Retain captured regression verdicts, correct fixture error names, improve import
probe diagnostics, and record focused-first validation discipline in AGENTS.md.

* Clarify CEO and engineering review decisions

Use explicit decision steps, one engineering ledger, and clear scope/write transitions. Preserve exact approvals and distinguish pending test requirements. Keep unrelated generated content unchanged.

* Fix review decision ordering and native evaluation interactions

* Clarify engineering decisions and test artifact order

* Clarify pending choices and approvals in CEO reviews

* Make CEO review phases sequential and clarify completion

* Fix Design board submission intent matching

* Seed an existing browser test baseline for Autoplan

* Document decision-log payloads before state initialization

* Preserve exact review scope and decide one change before drafting options

* Require input identity before repeating passing model judges

* Honor permitted storage throughout CEO review completion

* Match complete native permission text within the pinned renderer contract

* Align review approvals, independent choices, and bounded validation

* fix: preserve reopened approvals and declare fixture interfaces

* fix: isolate review artifacts and audit complete questions

* fix: match detector artifact permissions to configured storage

* fix: complete native permissions and review fixture workflows

* fix: order CEO review work and separate engineering guarantees

* fix: preserve native validation and separate review choices

* fix: clarify review decisions and judge complete report context

* fix: constrain review judgments and retain parse failures

* fix: compare each affected value before review decisions

* fix: make engineering review decisions and completion order explicit

* fix: give the complete Autoplan evaluation a bounded chain budget

* fix(cso): diagnose forbidden Docker endpoints before tool lookup

* fix(reviews): reconcile workflow contracts and generated artifacts after main integration

* fix(evals): migrate retained regressions to the native review harness

* fix(tests): close native harness and workflow integration regressions

* fix(evals): preserve complete permission context and native menu contracts

* fix(tests): capture synchronous command output without pipe drain stalls

* fix(reviews): clarify decision and completion ordering

* fix(reviews): separate decision readiness from final completion checks

* refactor(reviews): consolidate decision rules and completion branches

* fix(plan-eng-review): order preparation and clarify decision routing

* fix(plan-eng-review): restore size and question-format guard parity

* fix(plan-eng-review): clarify scope phases and blocked completion

* fix(plan-eng-review): unify review flow and report destination

* fix(plan-eng-review): define bootstrap and question stage ownership

* fix(plan-eng-review): clarify review structure and design lookup

* fix(plan-eng-review): render report examples and show saved decisions

* fix: consolidate Eng review decisions and select their evaluations

* test: cover overlapping terminal attachments and clean merged runner type

* fix: preserve Office Hours relationship closings during review updates

* fix: retain pasted review targets across slash invocations

* docs: preserve validation traces and correct release scope

* test: cover pasted targets in both review skills

* fix: validate report artifacts before recording success

* fix: redact source roots at CSO report boundaries

* fix: bind native Design questions before answering

* test: select report privacy and native recovery regressions

* test: bind rejection predicate in extracted observers

* fix: bind complete boxed native questions

* test: keep the Design UI fixture on native review

* fix: preserve review decisions and evaluation completion outcomes

* fix: clarify CEO approval and report completion order

* fix: align native review evaluation ownership and completion

* fix: bind review evaluators to native decisions and owned artifacts

* fix: validate review decisions against native outcomes

* fix: preserve review evidence and Autoplan phase handoffs

* test: bind review evidence to owned decisions and completion

* fix: retain owned native history across compaction

* fix(evals): validate current review decisions and setup choices

* fix: bind Autoplan reviews and phase completion to current amended input

* fix: reconcile native review evidence and close Autoplan phases

* test: recognize owned whole-candidate complexity decisions

* test: preserve report freshness for approved investigation handoffs

* fix: recognize scoped review findings and isolate dual voice fixtures

* fix: make review handoffs and question dispatch self-contained

* test: recognize complete CEO decisions and procedural pauses

* fix: bind current CEO comparison options and risk intervals

* test: bind engineering decisions and completion to owned evidence

* fix: publish Autoplan phase reports before continuing tools

* test: verify actual Autoplan dual-review dispatch evidence

* test: select dual review when shared evidence fixtures change

* fix: clarify plan review decisions and completion gates

* fix: make CEO review decisions and return paths explicit

* test: keep Autoplan prompt files inside attempt state

* test: preserve source whitespace across permission dialog wraps

* fix: publish Autoplan phase reports before continuing

* test: recognize current CEO comparisons and reject inactive records

* fix: reconcile engineering decision states before completion

* test: recognize complete Design decisions and reports

* test: verify current engineering decisions before navigation

* Recognize source-owned component reduction choices

* fix: recognize current CEO ledger and commitment grids

* test: supply RequestPolicy context to Eng count fixture

* fix: save complete engineering decisions before asking

* fix: bind Autoplan publication to the complete phase readback

* chore: prepare 1.87.5.0 reliability release

* fix: clarify engineering review completion and preserve log failures

* fix: bind CEO saved choices and current section ancestry

* fix(evals): bind review execution and completion evidence

* fix(plan-ceo-review): verify complete decisions before asking

* fix(evals): preserve complete engineering choice records

* fix(evals): preserve complete review outcomes and bounded fixtures

* fix(autoplan): publish phase reports before advancing

* fix(plan-ceo-review): validate option fields before asking

* fix(plan-eng-review): verify current decisions after answers

* fix(evals): bind review decisions and bound fixture scope

* fix(plan-ceo-review): verify decision rows and edit saved checkpoints

* fix(evals): bind review evidence and scope document lookup

* fix(plan-eng-review): update resolution state with its answer

* fix(reviews): preserve complete questions through dispatch

* fix(evals): recognize completed mode declarations

* fix(evals): define cache consistency at wrapper completion

* fix(evals): validate owned initial scope and completed review handoffs

* fix: assemble complete CEO decision fields before saving

* fix: authenticate automatic mode decisions without guessing selectors

* fix: bind engineering coverage to approved regression contracts

* fix(evals): supply review helpers to native Eng capture

* fix(plan-eng-review): preserve the full selected option scope

* fix(evals): recognize owned engineering seed and regression evidence

* fix(evals): bind engineering retry reports to native approvals

* docs: clarify release guarantees (v1.87.5.0)

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix(evals): recognize owned engineering decisions and handoffs

* fix(evals): bind engineering decisions and completion evidence

* fix(tests): align review contracts and selection fixtures

* fix(skills): restore review prompt size limits

* fix(plan-eng-review): clarify review execution and completion

* fix(evals): preserve configured retries through all supervision layers

* Clarify Engineering decisions and report completion

* Keep native decision assertions within their source boundary

* fix: recognize owned engineering decisions and completed navigation

* fix: bind completed auto decisions to their current review

* fix: recognize explicit CEO source attribution

* fix: dispatch verified CEO decisions without recomposing fields

* test: expose existing execution deadlines to review actors

* fix: distinguish CEO decision records from incidental headings

* test: bind split-scope choices to the registered native actor

* test: connect reviewed regressions to required evaluation coverage

* Clarify CEO decision routing and completion stages

* test: expose existing section review deadlines to fixture actors

* test: recognize complete native CEO pacing inventories

* test: exclude answered history from current CEO payloads

* test: detect phase entry through owned skill HOME aliases

* test: validate native review completion and owned report permissions

* fix: make Autoplan close packets carry the parent handoff steps

* test: assess source-bound HOLD decisions within the existing deadline

* fix: keep CEO native decision fields under one formatting authority

* test: register integrated review and permission dependencies

* test: align native review adapters and finding coverage

Preserve explicit AUTO decisions, apply native single-select defaults, and bind complete cropped questions and report permissions to their owned requests. Require seeded review findings instead of crediting setup menus.

Keep captured failure controls and additive selection dependencies. The integrated candidate passed 3,099 focused tests across 65 files; affected paid validation remains required before publication.

* fix(autoplan): require phase reports before advancing

* fix(evals): bind setup and evidence to complete attempts

* fix(evals): bind native answers and pending writes to fixture scope

Preserve complete option rows when native descriptions wrap, retain current
owned Write arguments before journal publication, and keep engineering and
DX answers within their declared fixture interfaces. Add captured free
regressions without increasing model budgets or relaxing completion checks.

* fix(autoplan): verify phase reports across native tool paths

Guard owned methodology reads and reviewer dispatches, detect complete driver
loads through Bash, and distinguish report-only edits from implementation
changes. Follow authenticated native UUID ancestry when journal writes arrive
out of order and verify earlier native content for cached phase reads.

Keep current close acknowledgment and parent publication in order, require CEO
entry before later phases, and register captured failure regressions.

* fix(evals): honor native input and collection lifecycles

Match complete native Edit panes and truncated question borders, reject stderr close before EOF, and stop the CEO split fixture once its acknowledged scope decisions are collected. Keep semantic validation, process failures, report requirements, and absolute deadlines authoritative.

Add captured-event and real-process regressions with selection dependencies. Focused checks pass; final integrated paid and full-suite acceptance remain pending.

* fix(autoplan): retain native session ownership across directory changes

Recover missed native UUID ancestry through the existing strict graph while preserving ordinary event order and legacy scoping. Bind publication hooks to Claude's original project directory while retaining current cwd for requested file paths.

Captured public-event regressions, existing caller checks, and a pinned native CLI loopback verify both fixes. Preserve failed attempts and require fresh paid and final full-suite acceptance.

* docs: align evaluation limits and completion version

* fix(autoplan): allow authenticated phase reads during journal streaming

* fix(evals): bind clipped native questions and owned edit dialogs

* fix: preserve overlay retries and bounded cleanup

* fix: recognize owned planning preludes in native questions

* docs: explain overlay scheduling and cleanup guarantees

* fix: require fresh publication after Autoplan phase reruns

* Release gstack 1.87.6

* fix: preserve CI paths, process identity, and test deadlines

* fix: keep informational setup commands independent of install probes

* fix: clarify plan review decisions and bound source audit reports

* Fix remaining Windows identity and native path CI failures

* Clarify CEO review decision and reviewer-result routing

* test: accept no-install planner in retry supervision

* fix(ceo-review): make review decisions and report completion explicit

* perf(test): add fast PR gates, input-keyed judge reuse and isolated free shards

* fix(test): start isolated CEO smoke from its existing project plan

* fix(test): repair CI fixture races and preserve retry evidence

* fix(ceo-review): clarify approvals, depth and saved completion

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>
2026-09-22 14:57:52 -04:00

398 lines
26 KiB
TypeScript

import type { AutoDecisionState } from './auto-decision-state';
import type { NativePublicToolEvent, PlanCountTranscript } from './plan-count-transcript';
export interface NativeAutoDecision {
sessionId: string;
skillToolUseId?: string;
preambleToolUseId?: string;
preferenceToolUseId?: string;
questionLogToolUseId?: string;
timestamp: string;
summary: string;
option: string;
annotation: string;
stateRecord?: Record<string, unknown>;
}
const plain = (text: string) => text.replace(/\*\*([^*]+)\*\*/g, '$1').trim();
const annotationLine = /^Auto-decided ([^\r\n→]{1,240}) → ([^\r\n→]{1,200}) \(your (?:preference|saved preference on `([a-z][a-z0-9-]*)`)\)\. Change with \/plan-tune\.$/;
/** Asserted prose only; later quoted examples cannot retract a current decision. */
function publicProse(text: string): string {
const lines: string[] = [];
let fence: { char: string; length: number } | undefined;
for (const line of text.split(/\r?\n/)) {
const marker = /^ {0,3}(`{3,}|~{3,})/.exec(line);
if (marker) {
if (!fence) fence = { char: marker[1]![0]!, length: marker[1]!.length };
else if (marker[1]![0] === fence.char && marker[1]!.length >= fence.length && /^\s*$/.test(line.slice(marker[0].length))) fence = undefined;
continue;
}
if (fence || /^(?: {4}|\t|\s*>)/.test(line)) continue;
const current = plain(line);
// A quoted name is still the target of an otherwise asserted mode field.
// Preserve only that slot; whole quoted declarations remain non-assertions.
const correction = /^(?:Correction|Actually|Update):\s*/i.test(current);
lines.push(current.replace(/"(?:[^"\\]|\\.)*"|“[^”]*”|`[^`]*`/g, (quoted, offset) => {
const field = modeField(current.slice(0, offset) + '""');
if (field && modeNames.some(mode => field.value.toUpperCase() === `${mode} FOR ""`)) return quoted;
return correction ? quoted.replace(/["“”`]/g, '') : '""';
}));
}
return lines.join('\n');
}
// The same current-mode field grammar owns declarations and later corrections.
function modeField(line: string): { value: string; completed: boolean } | null {
const match = /^(?:(?:Correction|Actually|Update):\s*)?(?<label>(?:Review )?Mode(?: decision)?|Decision)(?: (?<status>[^:\r\n]+))?:\s*(?<value>.*)$/i.exec(line.replace(/^\s*[-*+]\s+/, '').trim());
if (!match) return null;
// "Mode" and "Mode decision" are both field labels. If an explicit status
// follows, only the completion class is supported. Pending, cancelled,
// unfinished and unknown statuses also invalidate an earlier declaration.
const { label, status, value: rawValue } = match.groups!;
const completeStatus = !status || /^(?:done|complete|completed)$/i.test(status.trim());
const explicitMode = /^(?:the )?(?:review )?mode\b(?:\s+is\b|:)?\s*/i;
// An unqualified Decision field owns a review mode only when its value
// names that vocabulary. Keep unrelated decisions out of withdrawal checks;
// partial/negated mode names still own a field and therefore fail closed.
if (/^Decision$/i.test(label!) && !explicitMode.test(rawValue!) &&
!/\b(?:HOLD|SCOPE|SELECTIVE)\b/i.test(rawValue!)) return null;
const value = plain(rawValue!).replace(explicitMode, '');
// Target-name words are identifiers, not modal/lifecycle assertions.
const choiceValue = value.replace(/^(.*?\bfor\s+)(?:"(?:[^"\\]|\\.)*"|“[^”]*”|`[^`]*`)/i, '$1""');
// A completed choice and commentary about the recommendation are different
// assertions. Modal words in an explicitly owned recommendation clause do
// not make the selected mode conditional. Keep uncertain choice assertions,
// including those after that commentary, and every lifecycle veto intact.
const chosenMode = modeNames.find(mode => value.toUpperCase().startsWith(mode) &&
!/\w/.test(value[mode.length] ?? ''));
const conditionalChoice = choiceValue.split(/[();,\n]|[.!?](?=\s|$)|\s+[—–-]\s+|\b(?:and|but|while|whereas|however)\b/i).some(clause => {
const recommendation = /^\s*(?:(?:the|my|our)\s+)?recommendation\b/i.exec(clause);
const remainder = recommendation ? clause.slice(recommendation[0].length) : clause;
const ownsChoice = /\b(?:mode|decision|selection|choice|I|we)\b/i.test(remainder) ||
modeNames.some(mode => mode !== chosenMode && new RegExp(`\\b${mode.replaceAll(' ', '[ _]+')}\\b`, 'i').test(remainder));
return (!recommendation || ownsChoice) && /\b(?:if|unless|would|might|will)\b/i.test(clause);
});
const unfinishedValue = conditionalChoice || /\b(?:withdrawn|retracted|revoked|cancelled|canceled|undecided|unfinished|incomplete|not complete(?:d)?|not selected|not decided|not yet|pending|proposed)\b/i.test(choiceValue);
const negatedMode = modeNames.some(mode => new RegExp(`\\b(?:not|never|no longer)\\s+${mode.replaceAll(' ', '[ _]+')}\\b`, 'i').test(choiceValue));
return { value, completed: completeStatus && !unfinishedValue && !negatedMode };
}
function selectedMode(value: string, questionSummary?: string): string | null {
// The label ends before an explanatory clause or parenthetical. Use this same
// boundary for declarations and corrections: explanation punctuation cannot
// turn a completed choice into a withdrawal. modeField checks the full value
// first so conditional or unfinished explanations still fail closed.
const match = /^(.+?)(?:(\s+\()|[.,;:]|\s+[—–-]\s+\S|(\s+for\s+\S)|$)/i.exec(value);
const mode = match?.[1]?.trim().toUpperCase() ?? null;
// The new completed-field form belongs to the closed review-mode vocabulary.
// Generic Skill annotations keep their prior mode delimiter behavior.
if (!mode || !modeNames.includes(mode)) {
const original = /^(.+?)(?:\s+\([^()]*\)[.!;]?$|[.,;:]|\s+[—–-]\s+\S|$)/.exec(value);
return original?.[1]?.trim().toUpperCase() ?? null;
}
// A balanced explanation can contain punctuation, nesting and following
// prose. Validate its whole field before recognizing the opening boundary;
// an unfinished explanation or a glued-on alternative is not a declaration.
let depth = 0;
let firstParentheticalEnd = -1;
for (let i = 0; i < value.length; i++) {
if (value[i] === '(') depth++;
if (value[i] === ')') {
if (--depth < 0) return null;
if (depth === 0 && firstParentheticalEnd < 0) firstParentheticalEnd = i;
if (depth === 0 && value[i + 1] && !/[\s.,;:—–-]/.test(value[i + 1]!)) return null;
}
}
if (depth !== 0) return null;
if (match?.[3]) {
// A target clause must belong to the same completed audit decision. A
// matching mode alone cannot authenticate another draft or future review.
const target = (text: string) => /\bfor\s+((?:"(?:[^"\\]|\\.)*"|“[^”]*”|`[^`]*`)(?:\s+(?:draft|plan))?|.+?)(?=\s+\(|[,;:]|[.!?](?=\s|$)|$)/i.exec(text)?.[1]?.trim();
const identity = (text: string) => {
const normalize = (name: string) => name.replace(/\s+/g, ' ').trim().toLowerCase();
const value = text.replace(/^the\s+/i, '');
const quoted = /^(?:"((?:[^"\\]|\\.)*)"|“([^”]*)”|`([^`]*)`)(?:\s+(?:draft|plan))?$/i.exec(value);
if (quoted) return { name: normalize(quoted[1] ?? quoted[2] ?? quoted[3]!), bare: null };
if (/["“”`]/.test(value)) return null;
const name = normalize(value), wrapper = /^(.+)\s+(?:draft|plan)$/i.exec(name);
return { name, bare: wrapper?.[1] ?? null };
};
const declared = target(value), recorded = questionSummary && target(questionSummary);
const named = declared && identity(declared), logged = recorded && identity(recorded);
// A plan/draft head noun may wrap one exact title. Never strip words inside
// a quoted title, or strip different suffixes from both names to force a match.
const sameTarget = named && logged && !!named.name && (named.name === logged.name ||
named.name === logged.bare || named.bare === logged.name);
const noncurrent = /\b(?:future|previous|prior|earlier|past|later|next|another|different|other|historical|hypothetical|example|quoted)\s+(?:draft|plan|review|invocation|session)\b/i;
if (!questionSummary || !declared || noncurrent.test(declared) || (recorded && noncurrent.test(recorded)) ||
(!/^(?:this|the current) (?:draft|plan|review|invocation|session)$/i.test(declared) &&
!sameTarget)) return null;
}
if (match?.[2] || match?.[3]) {
// One current field names one mode. A different mode after its explanation
// is ambiguous regardless of the joining word or punctuation; it cannot be
// discarded as suffix prose. A separate later Mode field is checked below.
const suffix = value.slice(match[2] ? firstParentheticalEnd + 1 : match[1]!.length);
if (modeNames.some(other => other !== mode &&
new RegExp(`\\b${other.replaceAll(' ', '[ _]+')}\\b`, 'i').test(suffix))) return null;
}
return mode;
}
function withdrawn(text: string, option: string, questionSummary?: string): boolean {
const prose = publicProse(text);
if (/\b(?:I|we)\s+(?:retract|withdraw|revoke|cancel)\b[^.!?\n]{0,100}\b(?:auto[- ]decision|annotation|decision|selection|choice)\b/i.test(prose) ||
/\b(?:I|we)\s+(?:did not|didn't|have not|haven't|will not|won't|no longer)\s+auto-decide\b/i.test(prose) ||
/\b(?:I|we)\s+(?:did not|didn't|have not|haven't)\s+make\s+(?:this|that|the)\s+(?:decision|selection|choice)\b/i.test(prose) ||
/\b(?:this|that|the)\s+(?:auto[- ]decision|annotation|statement|decision|selection|choice)\b[^.!?\n]{0,100}\b(?:withdrawn|retracted|revoked|cancelled|canceled|hypothetical|conditional|example)\b/i.test(prose)) return true;
return prose.split('\n').some(line => {
const parsed = modeField(line);
if (parsed === null) return false;
if (!parsed.completed) return true;
return selectedMode(parsed.value, questionSummary)?.toLowerCase() !== option.toLowerCase();
});
}
function assertedAnnotation(text: string, skillName: string): RegExpExecArray | null {
const paragraphs = text.replace(/^(?:[ \t]*\r?\n)+|(?:\r?\n[ \t]*)+$/g, '').split(/\r?\n\s*\r?\n/);
let index = 0;
// A preamble notice is independent of the immediately following current
// mode declaration. No arbitrary source/example prefix is skipped.
const preambleNotice = "Heads-up from the preamble: unshipped work on this branch, so `/review` then `/ship` when you're ready. Also, gstack follows the **Boil the Ocean** principle: do the complete thing when AI makes the marginal cost near zero. Read more at https://garryslist.org/posts/boil-the-ocean if you'd like.";
const decisionNotice = "Heads-up from gstack: there is unshipped work on this branch, so `/review` then `/ship` when you get to it.";
if (/^Heads-up from gstack: this branch has unshipped work\. Run `\/review` then `\/ship` when you're ready\.$/.test(paragraphs[0] ?? '') || paragraphs[0] === preambleNotice || paragraphs[0] === decisionNotice) index++;
const mode = /^\*\*Review mode:\s*([^*\n.]+)\.\*\*$/.exec(paragraphs[index] ?? '');
const decisionHeading = /^\*\*D[1-9]\d* [—–-] Review mode for the ([^*\n]+) draft\*\*$/.exec(paragraphs[index] ?? '');
if (decisionHeading && /\b(?:example|hypothetical|historical|previous|quoted)\b/i.test(decisionHeading[1]!)) return null;
if (mode || decisionHeading) index++;
if (index && !mode && !decisionHeading) return null;
const paragraph = paragraphs[index];
if (!paragraph || /^(?: {4}|\t)/.test(paragraph) || paragraph.includes('\n')) return null;
const match = annotationLine.exec(paragraph);
if (!match || !plain(match[1]!) || !plain(match[2]!)) return null;
if (decisionHeading && (!/^"Review mode:[^"]+\?"$/.test(match[1]!) ||
!/^(?:HOLD SCOPE|SCOPE EXPANSION|SELECTIVE EXPANSION|SCOPE REDUCTION)$/.test(plain(match[2]!)))) return null;
// The printed skill template is not a concrete observed choice.
if (/<[^>\r\n]+>/.test(match[1]!) || /<[^>\r\n]+>/.test(match[2]!)) return null;
// A named saved preference belongs to the invoked skill's mode, and its
// concrete choice must agree with the adjacent current mode declaration.
if (match[3] && (match[3] !== `${skillName}-mode` || !mode ||
!/^(?:HOLD SCOPE|SCOPE EXPANSION|SELECTIVE EXPANSION|SCOPE REDUCTION)$/.test(plain(match[2]!)))) return null;
if (mode && (plain(mode[1]!).toLowerCase() !== plain(match[2]!).toLowerCase() ||
(!/^(?:review mode|"Review mode:[^"]+\?")$/i.test(match[1]!) &&
!(match[3] && /^"Select review mode"$/.test(match[1]!))))) return null;
return match;
}
// These are closed literal CLI forms, not a shell evaluator. In particular,
// source quoted in echo, substitutions, extra commands and pipelines cannot
// authenticate a completed preference action.
function literalWords(command: string): string[] | null {
const words: string[] = [];
const token = /[ \t]*(?:'([^']*)'|"([^"\\]*)"|([^\s'"\\|;&<>]+))/y;
let offset = 0;
while (offset < command.length) {
if (!command.slice(offset).trim()) break;
token.lastIndex = offset;
const match = token.exec(command);
if (!match || (token.lastIndex < command.length && !/\s/.test(command[token.lastIndex]!))) return null;
const value = match[1] ?? match[2] ?? match[3]!;
if (match[1] === undefined && /[$`]/.test(value) &&
value !== '$PPID' && !/^\$HOME\/[\w./-]+$/.test(value)) return null;
words.push(value); offset = token.lastIndex;
}
return words;
}
function cliArgs(command: string, name: string): string[] | null {
const words = literalWords(command);
if (!words?.length || !/^(?:~\/|\$HOME\/|\.claude\/|\/)/.test(words[0]!) ||
words[0]!.split('/').includes('..') || !words[0]!.endsWith(`/skills/gstack/bin/${name}`)) return null;
// Tilde and variable expansion are not performed inside single quotes.
if (/^\s*['"]~\//.test(command) || /^\s*'\$HOME\//.test(command)) return null;
return words.slice(1);
}
function preambleArgs(command: string): string[] | null {
const direct = cliArgs(command, 'gstack-skill-start');
if (direct) return direct;
// The generated preamble's fixed fallback wrapper owns its _SS variable.
const prefix = '_SS="$HOME/.claude/skills/gstack/bin/gstack-skill-start"\n[ -x "$_SS" ] || _SS=".claude/skills/gstack/bin/gstack-skill-start"\n"$_SS" ';
const suffix = ' || echo "SKILL_START: unavailable — stale install; run ./setup or /gstack-upgrade (preamble degraded, continue the user\'s task)"';
const normalized = command.replace(/\\\r?\n\s*/g, ' ');
return normalized.startsWith(prefix) && normalized.endsWith(suffix)
? literalWords(normalized.slice(prefix.length, -suffix.length).trim()) : null;
}
const modeNames = ['HOLD SCOPE', 'SCOPE EXPANSION', 'SELECTIVE EXPANSION', 'SCOPE REDUCTION'];
const modeValue = (value: unknown) => typeof value === 'string' && modeNames.includes(value.replaceAll('_', ' '))
? value.replaceAll('_', ' ') : null;
function currentModeStatement(text: string, questionSummary?: string): { option: string; statement: string } | null {
const prose = publicProse(text);
const lines = prose.split('\n');
for (let i = 0; i < lines.length; i++) {
const statement = lines[i]!.replace(/^\s*[-*+]\s+/, '').trim();
const field = modeField(statement);
const option = field?.completed ? selectedMode(field.value, questionSummary) : null;
if (!option || !modeNames.includes(option)) continue;
// Source/example introductions and conditional selections cannot supply
// a current declaration merely by putting a Mode field on the next line.
const context = lines.slice(0, i + 1).join('\n').replace(/\b[\w/-]+(?:\.[\w-]+)+\b/g, '');
if (/\b(?:example|hypothetical|historical|previous|quoted)\b/i.test(context)) continue;
return { option, statement: lines[i]!.trim() };
}
return null;
}
/** A native slash expansion need not produce a Skill tool call. Its completed
* preamble → preference check → decision log → current public mode provides
* the alternative evidence, without attributing a synthetic Skill event. */
function structuredModeDecision(transcript: PlanCountTranscript, tools: NativePublicToolEvent[],
opts: { skillName: string; sessionId: string; commandStartedAt: number; now: number; proseQuestionObserved?: boolean; stateEvidence?: AutoDecisionState },
): NativeAutoDecision | null {
const time = (value: string) => Date.parse(value);
const timely = (value: string) => Number.isFinite(time(value)) && time(value) >= opts.commandStartedAt && time(value) <= opts.now;
const owned = tools.filter(e => e.sessionId === opts.sessionId);
const messages = transcript.assistantMessages.filter(m => m.sessionId === opts.sessionId);
if (opts.proseQuestionObserved || transcript.calls.some(c => c.sessionId === opts.sessionId) ||
owned.some(e => e.kind === 'use' && /(?:^|__)AskUserQuestion$/.test(e.name ?? '')) ||
messages.some(m => !Number.isFinite(time(m.timestamp)) || time(m.timestamp) > opts.now)) return null;
const current = messages.filter(m => timely(m.timestamp));
const prose = current.map(m => publicProse(m.text)).join('\n\n');
if (/\b(?:reply|respond)\s+(?:with|using)\b/i.test(prose) ||
(/^\s*A[).]\s+\S/m.test(prose) && /^\s*B[).]\s+\S/m.test(prose))) return null;
const successful = (use: NativePublicToolEvent) => {
if (!timely(use.timestamp) || !use.toolUseId || owned.filter(e => e.kind === 'use' && e.toolUseId === use.toolUseId).length !== 1) return null;
const results = owned.filter(e => e.kind === 'result' && e.toolUseId === use.toolUseId);
const result = results.length === 1 ? results[0]! : null;
return result && result.isError === false && timely(result.timestamp) && time(result.timestamp) >= time(use.timestamp) ? result : null;
};
const bash = owned.filter(e => e.kind === 'use' && e.name === 'Bash' && timely(e.timestamp) && typeof e.input?.command === 'string');
const starts = bash.flatMap(use => {
const args = preambleArgs(use.input!.command as string), result = successful(use);
if (!args || !result || args.length % 2 || args.length < 2) return [];
const pairs = new Map<string, string>();
for (let i = 0; i < args.length; i += 2) {
if (!['--skill', '--model', '--parent-pid'].includes(args[i]!) || pairs.has(args[i]!)) return [];
pairs.set(args[i]!, args[i + 1]!);
}
if (pairs.get('--skill') !== opts.skillName || typeof result.content !== 'string') return [];
const status = result.content.split('GSTACK_INSTRUCTION_BEGIN:')[0]!;
const sessions = [...status.matchAll(/^SESSION_ID: ([A-Za-z0-9-]+)$/gm)];
if (sessions.length !== 1 || !/^SKILL_START_PROTO: 1$/m.test(status) || !/^QUESTION_TUNING: true$/m.test(status)) return [];
return [{ use, result, session: sessions[0]![1]! }];
});
if (starts.length !== 1) return null;
const start = starts[0]!, questionId = `${opts.skillName}-mode`;
// Opt-in fixture evidence bypasses no failed shell ACK: the owned file is
// the completed write. The preamble, record and current public declaration
// must all agree in this native session, after invocation and before now.
if (opts.stateEvidence?.questionId === questionId && opts.stateEvidence.preference === 'never-ask') {
const rows = opts.stateEvidence.records.filter(row => row.question_id === questionId);
if (rows.length === 1) {
const row = rows[0]!;
const loggedAt = typeof row.ts === 'string' ? time(row.ts) : NaN;
if (row.skill === opts.skillName && row.session_id === start.session && row.source === 'agent' &&
row.auto_decided === true && modeValue(row.user_choice) && modeValue(row.user_choice) === modeValue(row.recommended) &&
typeof row.question_summary === 'string' && row.question_summary.trim() &&
loggedAt >= time(start.result.timestamp) && loggedAt <= opts.now) {
for (const message of current) {
const declared = currentModeStatement(message.text, row.question_summary);
if (time(message.timestamp) < loggedAt || !declared || declared.option !== modeValue(row.user_choice)) continue;
const after = current.filter(m => time(m.timestamp) >= time(message.timestamp)).map(m => m.text).join('\n\n');
if (withdrawn(after, declared.option, row.question_summary)) continue;
return { sessionId: opts.sessionId, timestamp: message.timestamp, summary: row.question_summary,
option: declared.option, annotation: message.text, preambleToolUseId: start.use.toolUseId, stateRecord: row };
}
}
}
return null;
}
const checks = bash.flatMap(use => {
let command = (use.input!.command as string).trim();
const result = successful(use); if (time(use.timestamp) < time(start.result.timestamp)) return [];
const status = '; echo "EXIT: $?"', hasStatus = command.endsWith(status);
if (hasStatus) command = command.slice(0, -status.length);
const pipe = /^printf\s+(?:'%s'|"%s")\s+(?:'[^']*'|"[^"$`\\]*")\s*\|\s*/.exec(command);
if (pipe) command = command.slice(pipe[0].length);
const args = cliArgs(command, 'gstack-question-preference');
if (!args || args[0] !== '--check' || args[1] !== questionId ||
(pipe ? args.length !== 3 || args[2] !== '--summary-stdin' : args.length !== 2)) return [];
const valid = result && typeof result.content === 'string' &&
result.content.trim() === (hasStatus ? 'AUTO_DECIDE\nEXIT: 0' : 'AUTO_DECIDE');
return [{ use, result: valid ? result : null }];
});
if (checks.length !== 1 || !checks[0]!.result) return null;
const check = checks[0]!;
const logs = bash.flatMap(use => {
let command = (use.input!.command as string).trim();
const result = successful(use); if (time(use.timestamp) < time(check.result!.timestamp)) return [];
let valid = !!result;
// Optional quiet logging reports success only through &&, never a masked
// failed log followed by an unconditional echo.
const reported = /(?:\s+2>\/dev\/null)?\s+&&\s+echo\s+((?:[A-Za-z0-9_-]+|"[A-Za-z0-9_-]+"|'[A-Za-z0-9_-]+'))(?:\s+\|\|\s+echo\s+"([^"$`\\]*)")?$/.exec(command);
if (reported) { command = command.slice(0, -reported[0].length); valid &&= typeof result?.content === 'string' && result.content.trim() === literalWords(reported[1]!)?.[0] &&
(reported[2] === undefined || reported[2].trim() !== literalWords(reported[1]!)?.[0]); }
else valid &&= typeof result?.content === 'string' && !result.content.trim();
const args = cliArgs(command, 'gstack-question-log'); if (!args || args.length !== 1) return [];
let log: any; try { log = JSON.parse(args[0]!); } catch { return []; }
if (!log || Array.isArray(log) || log.skill !== opts.skillName || log.question_id !== questionId) return [];
valid &&= log.session_id === start.session && log.auto_decided === true &&
typeof log.question_summary === 'string' && !!log.question_summary.trim() &&
!!modeValue(log.user_choice) && modeValue(log.user_choice) === modeValue(log.recommended);
return [{ use, result: valid ? result : null, log }];
});
if (logs.length !== 1 || !logs[0]!.result) return null;
const logged = logs[0]!;
for (const message of current) {
if (time(message.timestamp) < time(logged.result!.timestamp)) continue;
const declared = currentModeStatement(message.text, logged.log.question_summary);
if (!declared || declared.option !== modeValue(logged.log.user_choice)) continue;
const after = current.filter(m => time(m.timestamp) >= time(message.timestamp)).map(m => m.text).join('\n\n');
if (withdrawn(after, declared.option, logged.log.question_summary) || current.some(m => time(m.timestamp) >= time(message.timestamp) &&
currentModeStatement(m.text, logged.log.question_summary)?.option !== undefined && currentModeStatement(m.text, logged.log.question_summary)!.option !== declared.option)) continue;
return { sessionId: opts.sessionId, timestamp: message.timestamp, summary: logged.log.question_summary,
option: declared.option, annotation: message.text, preambleToolUseId: start.use.toolUseId,
preferenceToolUseId: check.use.toolUseId, questionLogToolUseId: logged.use.toolUseId };
}
return null;
}
/** Owned native auto-decision evidence; exact annotations retain their original path. */
export function findNativeAutoDecision(
transcript: PlanCountTranscript,
tools: NativePublicToolEvent[],
opts: { skillName: string; sessionId: string; commandStartedAt: number; now: number; proseQuestionObserved?: boolean; stateEvidence?: AutoDecisionState },
): NativeAutoDecision | null {
if (transcript.status !== 'ready' || !opts.sessionId || !opts.skillName || opts.proseQuestionObserved ||
!Number.isFinite(opts.commandStartedAt) || !Number.isFinite(opts.now) || opts.now < opts.commandStartedAt) return null;
const structured = structuredModeDecision(transcript, tools, opts);
if (structured) return structured;
const at = (timestamp: string) => Date.parse(timestamp);
const timely = (timestamp: string) => Number.isFinite(at(timestamp)) && at(timestamp) >= opts.commandStartedAt && at(timestamp) <= opts.now;
const uses = tools.filter(e => e.kind === 'use' && e.sessionId === opts.sessionId && e.name === 'Skill' &&
[opts.skillName, `gstack:${opts.skillName}`].includes(String(e.input?.skill ?? '')) && timely(e.timestamp));
if (uses.length !== 1 || !uses[0]!.toolUseId) return null;
const use = uses[0]!;
const results = tools.filter(e => e.kind === 'result' && e.sessionId === opts.sessionId && e.toolUseId === use.toolUseId);
if (results.length !== 1 || results[0]!.isError !== false || !timely(results[0]!.timestamp) || at(results[0]!.timestamp) < at(use.timestamp)) return null;
// A native question actually surfaced; the annotation cannot erase it.
if (transcript.calls.some(call => call.sessionId === opts.sessionId)) return null;
const messages = transcript.assistantMessages.filter(m => m.sessionId === opts.sessionId);
if (messages.some(m => !Number.isFinite(at(m.timestamp)) || at(m.timestamp) > opts.now)) return null;
const loadedAt = at(results[0]!.timestamp);
for (const message of messages) {
if (at(message.timestamp) < loadedAt) continue;
const match = assertedAnnotation(message.text, opts.skillName);
if (!match) continue;
const option = plain(match[2]!);
const current = messages.filter(m => at(m.timestamp) >= at(message.timestamp)).map(m => m.text).join('\n\n');
if (withdrawn(current, option)) continue;
return { sessionId: opts.sessionId, skillToolUseId: use.toolUseId, timestamp: message.timestamp,
summary: plain(match[1]!), option, annotation: match[0] };
}
return null;
}