Garry TanandClaude Fable 5 63e2b7ac2c fix(ship): review fix loop stays in one invocation, bounded at 3 cycles (#2391) ...

The pre-landing review committed its fixes, then STOPPED and told the user
to run /ship again — 5-10 manual invocations on a branch with a few
auto-fixable findings, violating /ship's fully-automated contract. There is
no user decision between those invocations; each rerun just repeats the
workflow until a review pass produces no fixes.

ship/sections/review-army.md.tmpl item 7 now makes the loop explicit: after
committing fixes, re-run the test suite (Step 5) and this review (Step 9
items 2-6) in the SAME invocation, repeating until one full pass applies
zero fixes, then continue to Step 12. Bounded at 3 fix cycles — a review
that will not converge STOPs with a report of which findings keep
reappearing (a genuine blocker), never with a rerun request.

test/ship-review-loop.test.ts asserts no rendered ship surface (section +
all three host goldens) carries the STOP-and-rerun shape and that the
bounded loop language renders.

Fixes #2391

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-08-16 10:59:35 -07:00

..

sections

fix(ship): review fix loop stays in one invocation, bounded at 3 cycles (#2391)

2026-08-16 10:59:35 -07:00

SKILL.md

fix(resolvers): slug-canonical branch form in file-path positions (#2550, #1851)

2026-08-16 10:59:34 -07:00

SKILL.md.tmpl

feat: subdirectory manifests + npm-valid version mirror (#2531)

2026-08-16 10:02:32 -07:00