mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-02 03:10:59 +02:00
* fix(ci): skill-docs freshness gate covers all 10 hosts and can actually fail The Codex/Factory gates ran 'git diff --exit-code -- .agents/' / '-- .factory/', but both paths are gitignored (.gitignore:16-17) — git diff on ignored untracked paths is always empty, so those two gates were structurally incapable of failing and 7 of 10 hosts had no gate at all. New shape: one 'gen:skill-docs --host all' pass (the generator hard-fails on any per-host error, gating all 10 hosts on generates-cleanly), byte-freshness via git diff for tracked output, plus a porcelain check that fails on untracked generated strays (git diff can't see brand-new files). The gitignored-hosts byte-freshness limitation is documented in the workflow comment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): exorcise the sidebar-agent ghost from the test suite browse/src/sidebar-agent.ts was deleted in the v1.14 sidebar refactor, but the test suite kept testing it for 48 versions. Nothing noticed because the free suite runs in no CI job and Bun-era module-load errors were suppressed in the Windows shard runner via an exclusion pattern whose own comment documented the breakage ('broken on every platform since v1.14 ... exit 0'). - Delete sidebar-security.test.ts + security-source-contracts.test.ts: crashed at module load (unguarded readFileSync of the deleted file); per-assertion triage confirmed every SERVER_SRC pin targeted the deleted chat prompt builder (zero hits in today's server.ts) — nothing to port. - Delete sidebar-integration.test.ts: 11 of 13 tests exercised deleted endpoints (/sidebar-command queue, /sidebar-agent/event, chat buffer); the 2 passing tests pinned only the blanket auth gate, covered by server-auth.test.ts + dual-listener.test.ts. - Delete test/skill-e2e-sidebar.test.ts: E2E for the deleted queue flow. - sidebar-ux.test.ts 1,669 -> 830 lines: 20 dead-chat describes + 15 dead tests removed (incl. 10 vacuous passes asserting on empty indexOf slices); 2 stale pins on LIVE features fixed (content.js typed-catch CSSOM fallback, arrow-hint window widened). 95 pass / 0 fail. - sidebar-tabs.test.ts: both failures were stale pins, not regressions — forceRestart's deliberate ws.close(4001) and the terminal-agent spawn that moved into spawnTerminalAgent() (identity-based kill refactor). 28 pass. - touchfiles.ts: drop the three sidebar E2E entries from BOTH maps (E2E_TOUCHFILES + E2E_TIERS) — they pointed diff-selection at the deleted file, so those tests were unreachable by any diff. - test-free-shards.ts: remove the now-dead sidebar-agent exclusion pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(ci): run the free test suite in CI (it ran nowhere) The full free suite (bun test: browse/test/ + test/ + make-pdf/test/) had no CI job on any Linux/macOS runner — only Windows curated shards, paid evals, and doc-freshness gates existed. That's how two module-load-crashing test files survived 48 versions. Same cached Dockerfile.ci image and container wiring as evals.yml (deps restore, build, Chromium verify). Includes a module-load-error guard: older Bun reported test-file import crashes with exit 0 on macOS/Linux, so the job also fails on any nonzero 'N errors' count in the summary — future crash-class regressions can't hide from the exact job built to catch them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(test): validate touchfile dependency paths exist on disk New guard in touchfiles.test.ts: every non-glob dep path must exist, and every glob's anchor directory must exist. This is the axis the 181-key two-map sync discipline never covered — an entry can point at a long-deleted file and diff-based selection then silently never triggers those tests (the sidebar trio sat rotted for 48 versions). First run immediately caught a fourth rotted entry: 'spec authored quality' referenced test/fixtures/spec/** (directory does not exist) and selected for a judge test that exists nowhere in the repo. Removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): remove deleted /sidebar-chat endpoint from tunnel allowlist TUNNEL_PATHS is the audited tunnel attack surface — its own comment says every addition widens it. '/sidebar-chat' stayed in the set after the endpoint was deleted with the chat-queue path, meaning any future route matching that path would have been silently tunnel-exposed. The set is now exactly the pair ceremony (/connect) and the scoped command endpoint (/command), and the dual-listener closed-set pin enforces that. Also repairs a pre-existing red pin in dual-listener.test.ts: v1.63.0.0 made the tunnel allowlist args-aware (canDispatchOverTunnel gained a second param) without updating the test — red on main since then, invisible because the free suite had no CI job. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): delete chain's shadow dispatcher that skipped every security gate meta-commands.ts carried a 'CLI mode' fallback that re-implemented command routing without the server pipeline's gates: no scope check, no domain check, no tab ownership, no rate limit, no hidden-element stripping, no scoped-token enveloping — and it called handleReadCommand without a BrowserManager, which also skipped the JS-origin cookie-exfiltration assertion. It was unreachable in production (server.ts always passes executeCommand) and one boolean away from being live. chain now hard-errors without a server context. handleReadCommand's bm param is required and assertJsOriginAllowed runs unconditionally. The chain tests that exercised the deleted fallback now route through a server-shaped executeCommand adapter (real handlers + trust wrapping + {status,result} envelope), so their behavioral coverage — sequencing, trust markers, pipe format, aliases, error reporting — survives on the production-shaped path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(extension): delete the dead chat-queue client surface The sidebar-command handler in background.js POSTed to a server endpoint that no longer exists (deleted with the chat queue) — ~35 lines of fully-wired dead code including error handling for the permanent 404, plus its allowlist entry. No sender in the extension ever emitted the message type. chatEnabled leaves the /health contract (server hardcoded false, background.js re-derived it, nothing consumed it — the chat input element it guarded is gone from sidepanel.html). BROWSE_SIDEBAR_CHAT env flag had zero readers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): delete dead exports the ripped chat path left behind Three-way split by importer class: (a) Zero importers, deleted: the whole attack-attempt logging cluster in security.ts (logAttempt, AttemptRecord, salted hashPayload + device-salt, attempts.jsonl rotation, telemetry spawn plumbing incl. buildTelemetrySpawnCommand/resolveBashBinary — the LIVE attempts.jsonl writer is tunnel-denial-log.ts with its own rotation); the decision-file handshake (writeDecision/readDecision/clearDecision/excerptForReview — written for sidebar-agent's poll loop, which no longer exists); sidebar-utils.ts (whole module — its sanitizeExtensionUrl 'sanitized before embedding in a prompt' for the deleted prompt builder); 8 dead server.ts imports (sanitizeExtensionUrl, generateCanary, injectCanary, writeDecision, rotateRoot, serializeRegistry, restoreRegistry, clearAgentRecord); buildPtyClearCookie + buildSseClearCookie; WEBDRIVER_MASK_SCRIPT (orphaned by the D7 stealth narrowing — applyStealth never used it). (b) Dead-pin tests edited with their exports: the 'still exported' pin in stealth-layer-c, the string-content describe in stealth-webdriver (its live applyStealth behavioral coverage untouched), the clear-cookie assertions, security-review-flow.test.ts deleted whole (all 4 describes exercised the dead decision mechanism, incl. a 'simulated sidebar-agent poll loop'). (c) KEPT deliberately: leaseCount (live behavioral coverage), extractPtyCookie + validatePtySessionToken (extractPtyCookie is adopted by the terminal-agent cookie-parse unification later in this wave), resetSessionMarker + clearContentFilters (test-support API for the live content-security layer). Also fixes two pre-existing red pins found while here, invisible until the free suite got a CI job: the v1.44 spawnClaude->maybeSpawnPty rename in terminal-agent.test.ts, and a cross-file test-isolation bug where content-security.test.ts's clearContentFilters() wiped the auto-registered url-blocklist filter for every later file in the same bun process (security-integration.test.ts failed on co-run; afterAll now restores it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): delete the dead ML layers — transcript classifier and DeBERTa ensemble The L4b Haiku transcript classifier and the opt-in DeBERTa ensemble (GSTACK_SECURITY_ENSEMBLE=deberta, a documented 721MB download) had ZERO production callers since the chat-path agent that invoked them was ripped. The only live ML path is scanPageContent (testsavant) inside the security sidecar subprocess. Deleted by import graph: - security-classifier.ts 614 -> 265 lines: HAIKU_MODEL, checkTranscript, shouldRunTranscriptCheck, loadDeberta, scanPageContentDeberta, ToolCallInput, all DEBERTA_* consts + load state. Header now states the live truth (imported only by security-sidecar-entry.ts). downloadFile kept, name intact — it is an enumerated egress sink (HF model download). - security-bunnative.ts + test: a research skeleton self-described as 'NOT a production replacement', shipped into src/ with zero importers. - security-bench-ensemble{,-live}.test.ts + the Haiku response fixture: a paid live-model benchmark for a layer that could not fire. The security-classifier-tdz test's only case exercised checkTranscript — gone. - security.ts: layer-model header rewritten to the live architecture; StatusDetail.layers -> {testsavant, canary}; getStatus() no longer requires the impossible transcript==='ok' for 'protected' (old on-disk session state with a transcript key is tolerated on read, never re-emitted). - security-sidecar-entry.ts needed zero changes: it serializes getClassifierStatus() verbatim and no consumer read .transcript (verified in sidecar-client + server.ts). - BROWSER.md security section matches reality (ensemble knob gone, 112MB not 22MB, sidecar hosting documented). combineVerdict/THRESHOLDS retained as the pure, tested combiner of record — comments now flag transcript/deberta votes as producer-less. Net: 26 pass in security.test.ts incl. a NEW regression test for stale- transcript disk tolerance; egress-receipt tripwire green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: scrub the sidebar-agent ghost from comments and CLAUDE.md 20+ comments across 10 files still described the deleted sidebar-agent.ts as a live process — including load-bearing architecture claims ('IMPORTED ONLY BY sidebar-agent.ts', 'sidebar-agent fills this in on first prompt-injection load', 'kill sidebar-agent' in shutdown docs) and ~60 lines of tombstone blocks in server.ts enumerating deleted identifiers by name (a false grep surface: searching processAgentEvent hit server.ts and looked live). CLAUDE.md's security-stack section now documents the LIVE architecture: L1-L3 content filters + testsavant via the security sidecar subprocess; the L4b/ensemble rows, the GSTACK_SECURITY_ENSEMBLE knob, and the 721MB DeBERTa download are gone (deleted as dead code this wave) with an explicit do-not-re-document note; attempts.jsonl is correctly attributed to tunnel-denial-log.ts; the no-live-writer status of classifierStatus is stated. Comments that survive now describe what IS, not what WAS: the promotion gate in domain-skills.ts explains why classifier_score>0 is load-bearing given no L4 load-time scan exists; file-permissions.ts names real sensitive files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): delete the codex-helpers shadow module gen-skill-docs.ts imported externalSkillName (unaliased) from resolvers/codex-helpers.ts at line 21 and then re-declared the same function locally — the import was silently shadowed, and the imported copy was the STALE one (it lacked the frontmatterName param the local copy grew). Three more functions were byte-identical duplicates, imported only under _-prefixed aliases to keep the module 'referenced', and transformFrontmatter was a superseded hardcoded-Codex variant. Nothing else imported the module. Also drops three dead top-of-file imports (COMMAND_DESCRIPTIONS, SNAPSHOT_FLAGS — which pulled the whole browse/src module graph into every generator run for nothing — and an unused review-resolver trio). Proof: bun run gen:skill-docs exits 0 with a byte-identical tree (zero-diff regen); gen-skill-docs.test.ts 405/405 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(server): delete ServerConfig.idleTimeoutMs + chromiumProfile — documented, never read Both fields carried JSDoc asserting embedder behavior that did not exist: the idle check reads the module-level IDLE_TIMEOUT_MS env constant, and both resolveChromiumProfile() call sites pass no argument. Worse than absent — an embedder passing idleTimeoutMs: 5000 silently got 30 minutes. Wiring them honestly is impossible today: the idle timer, activity state, and shutdown target are module-global, so a per-factory value would lie for any process running more than one handler. Deleted instead, with a ServerConfig note pointing at the deferred singleton/route-table refactor where real support belongs. BROWSE_IDLE_TIMEOUT and CHROMIUM_PROFILE env remain the honest knobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): wire appendSecureFile at the four real log-append sites file-permissions.ts carries a 24-line rationale for why POSIX mode bits are insufficient on Windows and implements appendSecureFile (0600 at create, Windows ACL on first write only) — but its single caller was the dead logAttempt, while the four REAL page-content log writers (console/network/ dialog logs in server.ts, the command audit log) used raw fs.appendFileSync with no mode. Page-content-derived logs now get owner-only permissions from birth on every platform. Verified before wiring: mode applies atomically at create via appendFileSync {mode}, and the ACL pass runs only on first write — no per-append subprocess cost on the hot console-log path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(stealth): handoff() uses the shared profile resolution + lock cleanup The headless-to-headed handoff path hardcoded ~/.gstack/chromium-profile, silently ignoring $CHROMIUM_PROFILE and $GSTACK_HOME (gbrowser's gbd sets per-workspace profiles), and skipped cleanSingletonLocks() — so a handoff into a profile with a stale SingletonLock could hang where launchHeaded() would have recovered. This was the third live drift between the three Chromium launch paths; the first two are documented in comments as shipped stealth regressions. Minimal targeted fix — the full buildLaunchConfig() extraction stays in the deferred queue. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): resolver registry describes the template language again Seven registered {{PLACEHOLDER}}s had zero uses in any .tmpl (checked in both bare and :arg forms): REDACT_TAXONOMY_TABLE, TEST_COVERAGE_AUDIT_REVIEW, MODEL_OVERLAY, QUESTION_PREFERENCE_CHECK, QUESTION_LOG, INLINE_TUNE_FEEDBACK, MAKE_PDF_SETUP. The last two of those families are invoked programmatically by preamble.ts (functions kept, registry entries dropped); the question-tuning trio and the review coverage-audit wrapper were documented by their own module as existing 'for unit testing' that no test performed — deleted, along with generateRedactTaxonomyTable + its EXAMPLE/TIER_BLURB constants (its '/cso renders the full table' comment was itself stale) and its test describe. Also deletes the gated-resolver mechanism (ResolverEntry/appliesTo/ unwrapResolver + test/resolver-entry.test.ts): fully built, fully tested, used by zero of the 65 registry entries — the generator loop simplifies to a direct function call. CLAUDE.md's redact-doc line stops advertising the dead token. Proof: zero-diff regen (0 SKILL.md changed); gen-skill-docs + skill-validation 737 tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): wire boundaryInstruction from host config; drop three no-op binDir ternaries hosts/codex.ts declared boundaryInstruction and nothing read it — review.ts kept its own byte-identical CODEX_BOUNDARY literal (verified equal + trailing escaped newlines). The resolver now reads the config, so the boundary has one owner. (autoplan's template carries deliberately generic variants, enforced by gen-skill-docs.test.ts:1358 — untouched by design.) The 'ctx.host === codex ? $GSTACK_BIN : ctx.paths.binDir' ternary appeared in three resolvers and could never change the result: resolvers/types.ts already sets binDir to $GSTACK_BIN for every usesEnvVars host including codex. Proof: zero-diff regen for claude AND codex hosts; gen-skill-docs + host-config suites green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test-infra): judge uses resolveClaudeBinary; eval:watch reads the real partials dir judgePtyState spawned the bare string 'claude' three definitions below the resolveClaudeBinary() helper this same file exports — broken under hermetic PATHs where every other launch in the file resolves correctly. eval:watch read _partial-e2e.json from the legacy global ~/.gstack-dev/evals/ while EvalCollector writes it into the per-project eval dir (or GSTACK_EVAL_DIR) — so the dashboard's completed-tests panel was empty whenever slug detection succeeded, i.e. the normal case. The heartbeat and per-run progress logs stay global by design (session-runner.ts: 'heartbeat stays global'). The three eval-CLI docstrings stop claiming the legacy dir is the primary location. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): delete the superseded SDK ship-idempotency suite and three orphaned fixtures test/skill-e2e-ship-idempotency.test.ts's own header documented that the monolith's SDK-harness version tests a synthetic prompt while it exercises the real /ship skill — the author knew the old suite was superseded and left both running, two paid LLM runs for one behavior. The weaker copy is gone; its 'ship-idempotency' diff-selection key goes with it (the dedicated file is periodic-tier, which always runs under EVALS_ALL — the key had no remaining consumer). Fixture rot: test/fixtures/golden-ship-claude.md was a 128KB zero-reader orphan that had drifted 46KB from its live successor (test/fixtures/golden/claude-ship-SKILL.md) while looking authoritative; parity-baseline-v1.46.0.0.json and v1.53.0.0.json had zero readers (three tests pin three OTHER baseline versions — consolidation is queued, deletion of the unreferenced two is free). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(bin): delete zero-caller scripts; make host-config-export's docstring honest - bin/gstack-open-url (14 lines): announced in a CHANGELOG entry, wired into nothing, ever. bin/gstack-platform-detect (27 lines): zero callers, and its hand-rolled host list was already stale (SLATE_HOST.md cites it as a problem). Note: the deprecated gstack-brain-consumer/reader pair the audit flagged was already deleted upstream in v1.63 with a stay-deleted tripwire. - scripts/task-emission-schema.ts (61 lines): a typed schema module nothing imported; the tasks-section comment now documents the JSONL fields inline. - scripts/host-config-export.ts claimed to be the 'shell bridge for the bash setup script' — setup never calls it (its hand-rolled host lists drifting is a known follow-up). Docstring now states what it IS: a standalone, test-pinned query CLI not yet wired into setup. Its validateValue + CLI_REGEX/PATH_REGEX internals were dead (defined for a guarantee the header claimed but nothing enforced). - KEPT deliberately: scripts/preflight-agent-sdk.ts — a documented manual diagnostic (CONTRIBUTING.md + USING_GBRAIN_WITH_GSTACK.md reference it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(server): one lone-surrogate sanitizer, one sanitizeReplacer, one startTunnel Three copies of the surrogate sanitizer existed with two algorithms (sanitize.ts regex vs a hand-rolled charCodeAt walk in server.ts — verified byte-identical across 11 edge cases before converging) plus two identical sanitizeReplacer definitions each wrapping a different copy. sanitize.ts is now the single source of truth; the runs-INSIDE-JSON.stringify egress invariant is unchanged at every call site and its pin tests were adapted to the new import shape without losing intent. The ngrok tunnel-start sequence existed three times in server.ts — the /tunnel/start route and the BROWSE_TUNNEL=1 autostart were line-for-line equivalent (a comment admitted 'Same cleanup as /tunnel/start's error path'). One startTunnel() now owns the ephemeral loopback bind, the pre-send egress receipt, the state-file RMW via tmpStatePath(), and the ordered error-path cleanup; callers keep their distinct response surfaces. The BROWSE_TUNNEL_LOCAL_ONLY test path shares nothing (no ngrok, different state field) and deliberately stays separate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): one session-cookie registry implementation, two instances pty-session-cookie.ts and sse-session-cookie.ts were byte-identical modulo the cookie name — mint/validate/parse/prune/TTL, the exact code a security fix would have to land in twice (and a third hand-rolled cookie parse in terminal-agent.ts had already diverged; unified next commit). createSessionCookieStore() owns the implementation; both modules become thin instantiations keeping every exported name, their distinct threat-model docstrings, and separate token spaces (an SSE-read cookie must never grant PTY access). pty-session-lease.ts deliberately stays out — different contract (sessionId/secret split, refresh, env TTL). The factory imports nothing from token-registry (cookie-picker-auth-isolation invariant, still pinned by sse-session-cookie.test.ts). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): terminal-agent uses the shared PTY cookie parser The /ws upgrade's cookie fallback hand-parsed the Cookie header inline — the fourth copy of the session-cookie parse, and the one that had already diverged from the others. Parsing now goes through extractPtyCookie; validation deliberately stays against the agent's own in-process validTokens map (the server's registry lives in a different process). The ws-handler pin test now pins the shared-parser call instead of the raw cookie-name literal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(hosts): defineHost() factory — 10 copy-paste host files become declarations hosts/*.ts were ten copies of one file: runtimeRoot byte-identical in 9/10, pathRewrites mechanically derivable from the host name for 7/10, the 11-entry toolRewrites map byte-identical between openclaw and gbrain, and every asset change a 10-file edit (cursor and slate had already fallen out of three other hand-maintained lists). defineHost() owns the defaults; each host file now declares only what makes it different (slate/cursor: 8 lines each). Shared constants: CROSS_MODEL_RESOLVERS, GBRAIN_RESOLVERS, EXEC_STYLE_TOOL_REWRITES. Genuinely-different things stayed explicit: codex/factory $GSTACK_ROOT rewrites, hermes's tool vocabulary, claude's denylist+prefixable install, opencode's wider runtimeRoot. Proof: JSON.stringify(ALL_HOST_CONFIGS) dump-diff before/after EMPTY (and a runtime walk confirmed no function-valued or undefined-keyed fields, so the JSON diff is complete); gen:skill-docs --host all zero-diff; host-config + gen-skill-docs + idempotency suites 485/485. Host files 595 -> 285 lines. docs/ADDING_A_HOST.md teaches the factory pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(lib): fs-atomic — one atomic-write implementation, with the race actually fixed Atomic tmp-write-then-rename was reimplemented ~20 times across lib/, bin/, and browse/src with three tmp-suffix conventions. One of them was a latent bug this commit closes: lib/worktree.ts used a bare '.tmp' suffix — the deterministic-tmp collision race browse/src/server.ts documents having hit in production (its fix, pid+random, was trapped in a comment at one site). lib/fs-atomic.ts: atomicWriteSync (always throws, best-effort tmp cleanup, pid+random suffix, optional mode applied at tmp creation so the file never exists with looser permissions) + atomicWriteQuiet (shutdown paths only). Unit tests pin the throw/quiet contracts, 0600 mode, tmp-name uniqueness (captured via the read-only-dir failure path — Bun's fs exports are readonly, no monkeypatching), and no-stray-tmp cleanup. Migrated: lib/worktree.ts (the bare-.tmp bug), lib/gstack-decision.ts (snapshot + compact log), lib/gbrain-local-status.ts (probe cache). browse sites follow separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(lib): jsonl-store's docstring stops lying; mode option added; lib bypasses adopted The header claimed 'single source of truth... the ONLY copy' with write-time injection REJECTION — while appendJsonl never screened anything, only 1 of ~10 JSONL stores imported it, and a bypass appender lived in the same directory. Now: the contract is explicit (screening is the CALLER's job via hasInjection/firstInjectionMatch; the enforcing callers are named), a option applies 0600 at create for sensitive stores, and the lib bypasses are adopted (gstack-memory-helpers ×2, redact-audit-log — which keeps its chmod backstop for files created looser by pre-mode versions). browse/src keeps its own appenders by design (compiled-binary surface, own secure-append helper) and the header now says so. gstack-decision's batched archive append stays deliberate (single-write crash-window semantics appendJsonl's one-record contract can't express). New pins: 0600-at-create, and a test that documents appendJsonl does NOT self-screen — so nobody can re-document it as self-screening without making it true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): migrate hand-rolled atomic writes to lib/fs-atomic Seven sites, each audited for its existing throw-vs-swallow contract before migrating: writeSessionState + the four fire-and-forget tab/state writers use atomicWriteQuiet (they swallowed before); writeAgentRecord + the boot-time port-file write use atomicWriteSync (they threw before — and writeAgentRecord previously leaked its tmp file on rename failure, which the helper cleans). All carry {mode: 0o600} plus restrictFilePermissions after successful writes, preserving the Windows ACL hardening that writeSecureFile provided (mode bits are POSIX-only). server.ts untouched: its three state writes route through tmpStatePath(), pinned by server-tmp-state-path.test.ts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(hosts): delete five dead HostConfig fields metadataFormat (generator hardcodes openai.yaml), sidecar (behavior lives in setup's create_agents_sidecar — knowledge preserved as a comment in codex.ts), install.prefixable (skill_prefix is implemented entirely in bin/gstack-config), staticFiles (docstring cited a SOUL.md that never existed anywhere), and adapter (its only would-be consumer, openclaw-adapter.ts, was fully dead — with a test asserting the field was undefined). Kept: learningsMode (wired next), linkingStrategy (validation reads it), coAuthorTrailer (consumed by resolvers/utility.ts). Proof: JSON dump diff shows ONLY the deleted keys vanishing; zero-diff regen across all 10 hosts; host-config + gen-skill-docs suites green. Note: this commit also carries chunk-23 edits to the shared hosts/claude.ts + define-host.ts + host-config.test.ts files (skipSkills collapse, stale line-number comment drops) — pathspec commits, concurrent prep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): preamble tiers are explicit; silent ?? 4 default becomes an error; spec stops rendering its preamble twice Eight skills (scrape, diagram, spec, skillify, pair-agent, landing-report, open-gstack-browser + its connect-chrome symlink) silently received the HEAVIEST tier-4 preamble because a missing frontmatter field defaulted to 4. Tiers are now declared in every {{PREAMBLE}} template's frontmatter and a missing declaration throws at generation time with the template path (the 5 templates without {{PREAMBLE}} never invoke the resolver). The stale hand-written tier-map comment (wrong in 3 of 4 rows) is gone. Bonus bug fixed: spec/SKILL.md.tmpl mentioned {{PREAMBLE}} in prose, so the generator inlined the ENTIRE preamble a second time — spec/SKILL.md shrinks 127,462 -> 80,924 bytes (-46,538) from de-duplication alone. skill-size-budget gains a reasoned INTENTIONAL_SHRINKS entry (its frozen baseline had measured the doubled-preamble bug). New tests: missing-tier throw carries the path; every {{PREAMBLE}} template declares a tier. (Carries chunk-23 edits in the shared test/gen-skill-docs.test.ts.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): learningsMode is read from host config, not a hardcoded host name resolvers/learnings.ts branched on ctx.host === 'codex' while every host declared learningsMode — the field was decorative, and the 7 hosts configured 'basic' (cursor, slate, kiro, opencode, openclaw, hermes, gbrain) silently received the 'full' cross-project flow their runtimes can't execute (it depends on AskUserQuestion + gstack-config plumbing). Output now matches declaration: basic hosts get the project-scoped search block. Blast radius proof: all committed Claude SKILL.md files and the three golden fixtures are byte-identical; the behavior diff lands only in the gitignored external-host trees (hand-verified: .cursor review's learnings section swaps the cross-project AskUserQuestion block for the project-scoped search). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gen): small config scrubs — openclaw blobs to real files, setup host drift, dead artifacts - The three openclaw markdown blobs hardcoded inside gen-skill-docs.ts (which silently reverted any hand edit to their tracked outputs on regen) move to openclaw/templates/*.md source files; output shasums byte-identical. - setup's --host allowlists gain cursor + slate — both fully registered hosts with generated output, but './setup --host cursor' exited 1 because two hand-rolled lists in setup had drifted from hosts/index.ts. - scripts/proactive-suggestions.json deleted: 31KB regenerated on every run, read by nobody (the catalog-trim design's reader was never built); its emitter and three determinism tests (which guaranteed a file nothing reads didn't churn) retired with stays-retired pins. - claude/SKILL.md.tmpl deleted: a complete 8.9KB skill that never generated output (directory name collides with the host id 'claude'), in no registry. Recoverable from git if ever wanted under a non-colliding name. - openclaw's frozen extraFields.version '0.15.2.0' stamp dropped; includeSkills: [] no-ops omitted (the generator treats [] as absent); llms.txt 55 -> 54 skills. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(gen): correct preamble tiers for the 8 silently-heaviest skills With tiers now explicit, set them RIGHT by analogy to the tiered population: scrape/diagram/open-gstack-browser (+ the connect-chrome symlink) -> tier 1 (launchers and artifact generators, like browse and make-pdf); landing-report/pair-agent/skillify -> tier 2 (dashboards and session tools, like health and canary); spec -> tier 3 (interactive planning, like the plan-*-review family). Each tier-1 skill sheds 271 lines of onboarding prose it never needed; tier-2 shed 20 each. Verification per the review protocol: regen diff reviewed (pure section-removal), skill-validation + size-budget + catalog-budget + v0-dormancy suites green (822 tests), and live smoke of the tier-corrected skills confirms the preamble renders the intended sections at each tier. These skills have ~no eval coverage — stated honestly; the wave's gate-tier eval run is the backstop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(test): e2e-gate — one tier-gate implementation, side-effect-free, with the trap pinned The EVALS/EVALS_TIER gate was copy-pasted into ~40 test files and had drifted into six different predicates — the drift that made 'eval:bg:all runs everything' silently false. test/helpers/e2e-gate.ts owns the semantics now: describeE2ETier(tier) + e2eTierEnabled(tier), env read at call time, zero side effects (the existing e2e-helpers module runs a ~30s claude ping at import under EVALS=1, so the gate lives in its own module; purity is pinned by tests that scan imports and comment-stripped source). The unit matrix pins all four env combos — including EVALS=1 with EVALS_TIER unset -> SKIP, the exact trap that made eval:bg:all a non-run. The tier-alignment tripwire gains a second regex for the helper shape (old shape still detected — stragglers can't hide), and the sharded paid runner's PRE-SPAWN tier classifier learns the helper shape too: without that, every gate-sharded run would have spawned all 28 periodic shards just to skip them, each paying the e2e-helpers import ping (~15 min of dead wall clock in the CI-blocking lane). Verified: gate runs exclude the 29 periodic files, periodic excludes the 8 gate files — identical to pre-migration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(test): migrate the 36 tier-gated eval files to describeE2ETier Mechanical two-liner swap in 34 files (each keeping its declared tier — all 36 predicates verified against E2E_TIERS before migrating); the two files with compound gates (overlay-harness's EvalCollector feed, codex-e2e's CODEX_AVAILABLE) keep their extra conditions via e2eTierEnabled. Tier rationale comments preserved. codex-e2e/gemini-e2e/benchmark-providers keep their distinct stderr-message gate shapes by design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(test): skill-e2e + skill-llm-eval adopt the shared selection machinery Both files re-implemented the diff-selection machinery e2e-helpers already exported. The helper gained computeDiffSelection() (extracted, identical behavior) and a trailing optional selection param on the *IfSelected helpers (defaults preserve all 30+ existing importers). skill-e2e.test.ts drops ~120 duplicated lines; skill-llm-eval keeps its LLM_JUDGE_TOUCHFILES selection and test.concurrent semantics via testConcurrentIfSelected. Deliberate deltas, stated: skill-e2e.test.ts now honors the EVALS_TIER intersection its local copy lacked (affects only direct bun test invocations of that file — it matches no eval-script glob); its recordE2E gains the helper's three diagnostic fields; skill-llm-eval sharded solo now runs e2e-helpers' module-scope preflight it already ran in combined processes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): kill the silent-truncation race; exempt the tier-corrected shrinks The full-suite shakeout (budgeted by the plan) surfaced both immediately: 1. server-embedder-terminal-port.test.ts stubbed process.exit and restored the REAL exit in its finally — but shutdown() schedules async work that can call process.exit AFTER restoration, killing the entire bun process mid-suite with exit 0 and NO summary. This is the silent-truncation class the new free-suite CI job guards against, reproduced locally on the first full run. Exit now stays a logging no-op between tests (late async exits become visible stderr lines, not process death); the true exit returns in afterAll. 2. The 80%-of-baseline shrink guard correctly flagged the six tier-corrected skills — their baseline was measured at the silent tier-4 default. Added to INTENTIONAL_SHRINKS with the reason, joining spec's double-preamble entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * release: v1.64.0.0 — the code-smell fix wave 35 commits, one PR: guard repairs (free suite in CI per-file, all-host freshness gates, tunnel allowlist, diff-selection validation), the sidebar-agent ghost exorcism (dead ML layers, dead endpoints, dead exports, ghost comments), config honesty (defineHost factory, dead fields deleted, preamble tiers explicit, spec double-render fixed), and dedup with safety nets (session-cookie factory, fs-atomic, jsonl-store contract, one eval tier-gate). Net -24,943 lines across 183 files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ci): free-tests step runs under bash (container sh rejects pipefail) Maiden-voyage shakeout, exactly as budgeted: the CI container's default shell is dash, which errors on 'set -o pipefail' before the first test ran. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ci): free-tests curates 8 container-incompatible files with reasons Second maiden-voyage shakeout round: 376 of 384 files ran green in the container on the first completed pass. The 8 that can't run there yet are excluded the same way the Windows shards curate POSIX-bound files — each with its reason inline (headed-Chrome handoff, real-PTY round-trip, X server management, extension-origin identity, the job's own TMPDIR override, and three pre-existing env failures that fail on dev machines too). Anything outside the list that fails still fails the job; trimming the list is tracked follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): gstack-config-key-locale — suppress the skill_prefix auto-relink side effect The test invokes the repo's own bin/gstack-config, whose 'set skill_prefix' auto-runs $(dirname $0)/gstack-relink — resolving the install dir to the repo itself. In any environment where the loop shares a working tree (the free-tests CI container, a fresh-HOME run), gstack-patch-names rewrote all 52 tracked SKILL.md names to gstack- prefixed, poisoning five unrelated suites downstream (hermetic-skills-seeding, host-config golden, skill-census, skill-validation, spec-template-sync). GSTACK_SETUP_RUNNING=1 is the documented suppression; relink behavior stays covered by relink.test.ts's mock install. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(bin): gstack-codex-session-import — empty sessions dir exits 0 on Linux GNU xargs runs 'ls -t' once even on empty input, listing the cwd and producing a bogus LATEST from the repo root; BSD xargs (macOS) skips the run, which is why the NO_SESSIONS path only broke on Linux. xargs -r pins the BSD behavior on both platforms. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(parity): rebaseline v1.57.7.0 → v1.64.1.0 + skeleton-cap headroom The two parallel v1.64 waves (code-smell fix wave + main's #2571) each added shared-preamble prose, pushing document-release / design-consultation / cso past their size ratios on the v1.57.7.0 anchor and four carved skeletons (plan-ceo-review, plan-eng-review, office-hours, design-consultation) 22-280 B over their absolute caps. New baseline is union-normalized (skeleton + sections/*.md, matching what the harness measures); caps get +~1 KB headroom each with per-cap rationale. The v1.57.7.0 fixture stays in test/fixtures/ for the audit trail, and capture-parity-baseline.ts now documents the union-normalization step so the next rebaseline doesn't re-trip on it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ci): free-tests container parity — tools, pinned bun, git identity, mutation tripwire - Dockerfile.ci: add python3 (gstack-jsonl-merge/brain-sync/detach shell out to it), file (skill-validation's binary check), poppler-utils (make-pdf e2e gates hard-require pdftotext/pdffonts/pdfinfo), fonts-noto-color-emoji (emoji render gate, mirrors make-pdf-gate.yml). Fix the bun pin: the bun.sh installer ignores a BUN_VERSION env var, so the old form silently installed latest on every rebuild (observed 1.3.13/1.3.14 drift vs the 1.3.10 devs run locally); pass the version as the positional arg. - free-tests.yml: git identity + safe.directory for the git-exercising tests (container checkout is owned by a different uid than runner); post-loop tree-mutation tripwire that names a tracked-file-mutating test instead of letting downstream collateral confuse the report; skip the documented variants-retry-after timing flake. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(bin): gstack-session-update — detached updater owns its stdio (SIGPIPE) The backgrounded update subshell inherited the session hook's stdout/stderr pipes. Once the hook exits and the caller closes them, any child that writes — git pull's autostash notice, setup output — dies of SIGPIPE, logged as PULL_FAILED exit=141 with an empty stderr capture (observed in the free-tests container, and reachable by any production hook runner that closes stdio promptly). Redirect the fork to /dev/null; all observability already flows through the session-update log file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): gstack-decision-bins — explicit branch context for the scope filter CI checks out a detached HEAD, where gitBranch() returns undefined on both the log and search sides, so an implicitly branch-scoped decision can never surface (filterByScope requires a matching non-empty ctx.branch). Pass the branch explicitly on both sides — the filter logic is what's under test, not git branch detection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(test): ring-buffer lease interplay — same TTL window, not same millisecond Two back-to-back mintLease() calls each stamp Date.now() + TTL; when they straddle a millisecond boundary the exact-equality assertion flakes (observed in CI: expiries of ...525 vs ...526). Assert the expiries are within a 50 ms window instead — the invariant under test is that leases share a TTL policy, not that they mint in the same clock tick. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
581 lines
25 KiB
TypeScript
581 lines
25 KiB
TypeScript
/**
|
|
* Stealth init script — Layer C of GBrowser's anti-detection plan.
|
|
*
|
|
* D7 (codex correction, kept): Layer C (the always-on default built by
|
|
* buildStealthScript) does NOT fake navigator.plugins or
|
|
* navigator.languages — modern fingerprinters cross-check those against
|
|
* userAgent / platform / OS, and synthesizing fixed values flags MORE
|
|
* bot-like, not less. Plugins and languages surface their native
|
|
* Chromium values. The opt-in EXTENDED_STEALTH_SCRIPT below (gated on
|
|
* GSTACK_STEALTH=extended, off by default) DOES fake plugins — that mode
|
|
* is the documented "actively lies, may break sites" escape hatch, not
|
|
* the default posture.
|
|
*
|
|
* What this script DOES do (the new additions for Phase 1):
|
|
* 1. Mask navigator.webdriver (the canonical headless tell).
|
|
* 2. Restore window.chrome.runtime / app / csi / loadTimes — real
|
|
* Chrome ships them; their absence in headless/automation is a
|
|
* universally-checked tell. (Vendor research: Cloudflare + DataDome
|
|
* check chrome.runtime presence + enum shape.)
|
|
* 3. Align Notification.permission with the Permissions API spoof
|
|
* that the inline addInitScript already applies — `denied` while
|
|
* Permissions returns `prompt` is a cross-source inconsistency
|
|
* detectors flag.
|
|
* 4. Report per-install hardware values via GSTACK_HW_CONCURRENCY /
|
|
* GSTACK_DEVICE_MEMORY env vars (set by gbd at startup via
|
|
* system_profiler + sysctl). Per-install honesty avoids the
|
|
* cross-user fingerprint cluster a hardcoded default would create.
|
|
* 5. Install a Function.prototype.toString Proxy that makes every
|
|
* patched getter report `function ... { [native code] }` at every
|
|
* recursion depth — defeats the well-known depth-3 detection trick
|
|
* (`fn.toString.toString.toString().includes('[native code]')`)
|
|
* that breaks naive stealth tooling.
|
|
*
|
|
* Codex caveat (acknowledged): a Proxy on Function.prototype.toString
|
|
* still has detection surfaces (descriptors, Reflect.ownKeys, cross-
|
|
* realm identity). Phase 2's C++ patches make this layer obsolete by
|
|
* pushing the spoofs to native code where toString is truly native.
|
|
* Until then, this is the best JS-only approach.
|
|
*/
|
|
|
|
import type { BrowserContext } from 'playwright';
|
|
|
|
/**
|
|
* Host hardware values resolved at browser-manager startup. Values come
|
|
* from the gbd `host_profile.go` detection (system_profiler + sysctl
|
|
* on macOS), passed through the GSTACK_* env vars. Each field falls
|
|
* back to a documented default if the env var is missing or unparseable.
|
|
*/
|
|
interface HostProfile {
|
|
hwConcurrency: number;
|
|
deviceMemory: number;
|
|
}
|
|
|
|
// Exported for the clamp/fallback unit test. The platform spoof is owned by
|
|
// the UA-CH cmdline switch in buildGStackLaunchArgs (which reads GSTACK_PLATFORM
|
|
// directly), so this profile only carries the values buildStealthScript bakes
|
|
// into the page-world script.
|
|
export function readHostProfile(): HostProfile {
|
|
const env = (globalThis as any).process?.env ?? {};
|
|
const concurrency = Number(env.GSTACK_HW_CONCURRENCY);
|
|
const memory = Number(env.GSTACK_DEVICE_MEMORY);
|
|
return {
|
|
// Clamp to a plausible default: 0/NaN/negative/missing all fall back to 8.
|
|
// deviceMemory=0 or NaN would be a glaring bot tell, so never report it.
|
|
hwConcurrency: Number.isFinite(concurrency) && concurrency > 0 ? concurrency : 8,
|
|
deviceMemory: Number.isFinite(memory) && memory > 0 ? memory : 8,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Build the full Layer C stealth init script. The function template-
|
|
* literal-interpolates the host values so they bake into the script the
|
|
* page sees — process.env is not accessible from a page-world init script,
|
|
* so values must be resolved by the browser-manager process before
|
|
* injection.
|
|
*
|
|
* The script is one big self-invoking function so all the patches
|
|
* happen atomically before any page code runs. Order matters: the
|
|
* Function.prototype.toString Proxy installs FIRST so all subsequent
|
|
* defineProperty getters are covered by its native-code lie.
|
|
*/
|
|
export function buildStealthScript(hw: HostProfile): string {
|
|
return `(() => {
|
|
// ──── Function.prototype.toString Proxy (must run first) ────
|
|
// Make every patched getter / function below report
|
|
// 'function NAME() { [native code] }' at every recursion depth.
|
|
// Defeats fn.toString.toString.toString() integrity checks.
|
|
const patchedFns = new WeakSet();
|
|
const nativeToString = Function.prototype.toString;
|
|
const toStringProxy = new Proxy(nativeToString, {
|
|
apply(target, thisArg, args) {
|
|
if (patchedFns.has(thisArg)) {
|
|
const name = (thisArg && thisArg.name) || '';
|
|
return 'function ' + name + '() { [native code] }';
|
|
}
|
|
return Reflect.apply(target, thisArg, args);
|
|
},
|
|
});
|
|
Object.defineProperty(Function.prototype, 'toString', {
|
|
value: toStringProxy, writable: true, configurable: true,
|
|
});
|
|
const markNative = (fn, name) => {
|
|
if (name) {
|
|
try { Object.defineProperty(fn, 'name', { value: name }); } catch {}
|
|
}
|
|
patchedFns.add(fn);
|
|
return fn;
|
|
};
|
|
|
|
// ──── navigator.webdriver (canonical mask, kept from D7) ────
|
|
try {
|
|
const webdriverGetter = markNative(function() { return false; }, 'get webdriver');
|
|
Object.defineProperty(navigator, 'webdriver', { get: webdriverGetter, configurable: true });
|
|
} catch {}
|
|
|
|
// ──── window.chrome.* restoration ────
|
|
// Real Chrome ships these objects with rich enum / method shape.
|
|
// Headless Chromium / Playwright's launch strips them. Their absence
|
|
// is a universally-checked tell (verified in Cloudflare + DataDome
|
|
// RE catalogs). We don't try to perfectly mimic — we ship plausible
|
|
// shape with native-code-looking methods.
|
|
try {
|
|
if (!('chrome' in window)) {
|
|
window.chrome = {};
|
|
}
|
|
const chrome = window.chrome;
|
|
if (!chrome.runtime) {
|
|
chrome.runtime = {
|
|
OnInstalledReason: { CHROME_UPDATE: 'chrome_update', INSTALL: 'install',
|
|
SHARED_MODULE_UPDATE: 'shared_module_update', UPDATE: 'update' },
|
|
OnRestartRequiredReason: { APP_UPDATE: 'app_update', OS_UPDATE: 'os_update', PERIODIC: 'periodic' },
|
|
PlatformArch: { ARM: 'arm', ARM64: 'arm64', MIPS: 'mips', MIPS64: 'mips64',
|
|
X86_32: 'x86-32', X86_64: 'x86-64' },
|
|
PlatformNaclArch: { ARM: 'arm', MIPS: 'mips', MIPS64: 'mips64',
|
|
X86_32: 'x86-32', X86_64: 'x86-64' },
|
|
PlatformOs: { ANDROID: 'android', CROS: 'cros', LINUX: 'linux',
|
|
MAC: 'mac', OPENBSD: 'openbsd', WIN: 'win' },
|
|
RequestUpdateCheckStatus: { NO_UPDATE: 'no_update', THROTTLED: 'throttled',
|
|
UPDATE_AVAILABLE: 'update_available' },
|
|
connect: markNative(function connect() {
|
|
throw new TypeError('Error in invocation of runtime.connect: No matching signature.');
|
|
}, 'connect'),
|
|
sendMessage: markNative(function sendMessage() {
|
|
throw new TypeError('Error in invocation of runtime.sendMessage: No matching signature.');
|
|
}, 'sendMessage'),
|
|
id: undefined,
|
|
};
|
|
}
|
|
if (!chrome.app) {
|
|
chrome.app = {
|
|
isInstalled: false,
|
|
InstallState: { DISABLED: 'disabled', INSTALLED: 'installed', NOT_INSTALLED: 'not_installed' },
|
|
RunningState: { CANNOT_RUN: 'cannot_run', READY_TO_RUN: 'ready_to_run', RUNNING: 'running' },
|
|
};
|
|
}
|
|
if (typeof chrome.csi !== 'function') {
|
|
chrome.csi = markNative(function csi() {
|
|
return {
|
|
onloadT: Date.now(),
|
|
pageT: performance.now(),
|
|
startE: Date.now() - 1000,
|
|
tran: 15,
|
|
};
|
|
}, 'csi');
|
|
}
|
|
if (typeof chrome.loadTimes !== 'function') {
|
|
chrome.loadTimes = markNative(function loadTimes() {
|
|
const t = performance.timing;
|
|
return {
|
|
requestTime: t.requestStart / 1000,
|
|
startLoadTime: t.requestStart / 1000,
|
|
commitLoadTime: t.responseStart / 1000,
|
|
finishDocumentLoadTime: t.domContentLoadedEventEnd / 1000,
|
|
finishLoadTime: t.loadEventEnd / 1000,
|
|
firstPaintTime: t.responseEnd / 1000,
|
|
firstPaintAfterLoadTime: 0,
|
|
navigationType: 'Other',
|
|
wasFetchedViaSpdy: true,
|
|
wasNpnNegotiated: true,
|
|
npnNegotiatedProtocol: 'h2',
|
|
wasAlternateProtocolAvailable: false,
|
|
connectionInfo: 'h2',
|
|
};
|
|
}, 'loadTimes');
|
|
}
|
|
} catch (err) {
|
|
// Non-fatal — page might have a stricter Content Security Policy
|
|
// that blocks property mutation on window. Leave chrome.* whatever
|
|
// shape it was; navigator.webdriver mask still applies.
|
|
}
|
|
|
|
// ──── Notification.permission align with Permissions API ────
|
|
// The inline addInitScript already overrides permissions.query for
|
|
// notifications → 'prompt'. Notification.permission must match
|
|
// ('default' in real Chrome on pages that haven't asked yet).
|
|
try {
|
|
if (typeof Notification !== 'undefined') {
|
|
const notificationPermissionGetter = markNative(function() { return 'default'; }, 'get permission');
|
|
Object.defineProperty(Notification, 'permission', {
|
|
get: notificationPermissionGetter,
|
|
configurable: true,
|
|
});
|
|
}
|
|
} catch {}
|
|
|
|
// ──── Per-install hardware values from GSTACK_* env (T2) ────
|
|
// gbd's host_profile.go fed real host values via cmdline env. Reporting
|
|
// those (not hardcoded defaults) avoids the cross-user GBrowser
|
|
// fingerprint cluster.
|
|
try {
|
|
const hwConcurrencyGetter = markNative(function() { return ${hw.hwConcurrency}; }, 'get hardwareConcurrency');
|
|
Object.defineProperty(navigator, 'hardwareConcurrency', {
|
|
get: hwConcurrencyGetter,
|
|
configurable: true,
|
|
});
|
|
} catch {}
|
|
try {
|
|
const deviceMemoryGetter = markNative(function() { return ${hw.deviceMemory}; }, 'get deviceMemory');
|
|
Object.defineProperty(navigator, 'deviceMemory', {
|
|
get: deviceMemoryGetter,
|
|
configurable: true,
|
|
});
|
|
} catch {}
|
|
|
|
// ──── Selenium / Phantom / Nightmare / Playwright global cleanup ────
|
|
// Static known-name list of Selenium / Playwright / PhantomJS / Nightmare
|
|
// globals. AUTOMATION_ARTIFACT_CLEANUP_SCRIPT (applied right after this on
|
|
// every path) covers the cdc_/__webdriver dynamic prefixes; this list is the
|
|
// fixed-name complement.
|
|
try {
|
|
const auto = [
|
|
'__driver_evaluate', '__webdriver_evaluate', '__selenium_evaluate', '__fxdriver_evaluate',
|
|
'__driver_unwrapped', '__webdriver_unwrapped', '__selenium_unwrapped', '__fxdriver_unwrapped',
|
|
'_Selenium_IDE_Recorder', '_selenium', 'calledSelenium',
|
|
'$chrome_asyncScriptInfo',
|
|
'__$webdriverAsyncExecutor', '__webdriverFunc',
|
|
'domAutomation', 'domAutomationController',
|
|
'__lastWatirAlert', '__lastWatirConfirm', '__lastWatirPrompt',
|
|
'__webdriver_script_fn', '_WEBDRIVER_ELEM_CACHE',
|
|
'callPhantom', '_phantom', 'phantom', '__nightmare',
|
|
'__pwInitScripts', '__playwright__binding__',
|
|
];
|
|
for (const k of auto) {
|
|
try { delete window[k]; } catch {}
|
|
}
|
|
try { delete document.__webdriver_script_fn; } catch {}
|
|
} catch {}
|
|
})();`;
|
|
}
|
|
|
|
/**
|
|
* Extended-mode init script — six detection-vector patches. Applied
|
|
* AFTER the default mask, so the property-getter version remains in
|
|
* place if any of the deletion paths fail.
|
|
*
|
|
* Self-contained string so it can be passed to addInitScript({ content })
|
|
* without bundling concerns.
|
|
*/
|
|
export const EXTENDED_STEALTH_SCRIPT = `
|
|
(() => {
|
|
try {
|
|
// 1. Fully delete navigator.webdriver from the prototype so
|
|
// \`"webdriver" in navigator\` returns false (not just falsy).
|
|
delete Object.getPrototypeOf(navigator).webdriver;
|
|
} catch {}
|
|
|
|
try {
|
|
// 2. WebGL renderer spoof — SwiftShader is the canonical software-GPU
|
|
// tell. Spoof to a plausible Apple M1 Pro string.
|
|
const getParameter = WebGLRenderingContext.prototype.getParameter;
|
|
WebGLRenderingContext.prototype.getParameter = function (parameter) {
|
|
// UNMASKED_VENDOR_WEBGL (37445) → 'Apple Inc.'
|
|
if (parameter === 37445) return 'Apple Inc.';
|
|
// UNMASKED_RENDERER_WEBGL (37446) → realistic Apple silicon string
|
|
if (parameter === 37446) return 'Apple M1 Pro, OpenGL 4.1';
|
|
return getParameter.call(this, parameter);
|
|
};
|
|
} catch {}
|
|
|
|
try {
|
|
// 3. navigator.plugins: real PluginArray with MimeType objects.
|
|
const makePlugin = (name, filename, desc, mimes) => {
|
|
const p = Object.create(Plugin.prototype);
|
|
Object.defineProperties(p, {
|
|
name: { get: () => name },
|
|
filename: { get: () => filename },
|
|
description: { get: () => desc },
|
|
length: { get: () => mimes.length },
|
|
});
|
|
mimes.forEach((m, i) => { p[i] = m; });
|
|
p.item = (i) => mimes[i];
|
|
p.namedItem = (n) => mimes.find((m) => m.type === n);
|
|
return p;
|
|
};
|
|
const makeMime = (type, suffixes, desc) => {
|
|
const m = Object.create(MimeType.prototype);
|
|
Object.defineProperties(m, {
|
|
type: { get: () => type },
|
|
suffixes: { get: () => suffixes },
|
|
description: { get: () => desc },
|
|
});
|
|
return m;
|
|
};
|
|
const pdfMime = makeMime('application/pdf', 'pdf', '');
|
|
const cpdfMime = makeMime('application/x-google-chrome-pdf', 'pdf', 'Portable Document Format');
|
|
const plugins = [
|
|
makePlugin('PDF Viewer', 'internal-pdf-viewer', '', [pdfMime]),
|
|
makePlugin('Chrome PDF Viewer', 'internal-pdf-viewer', '', [cpdfMime]),
|
|
makePlugin('Chromium PDF Viewer', 'internal-pdf-viewer', '', [cpdfMime]),
|
|
];
|
|
Object.defineProperty(navigator, 'plugins', {
|
|
get: () => {
|
|
const arr = Object.create(PluginArray.prototype);
|
|
Object.defineProperty(arr, 'length', { get: () => plugins.length });
|
|
plugins.forEach((p, i) => { arr[i] = p; });
|
|
arr.item = (i) => plugins[i];
|
|
arr.namedItem = (n) => plugins.find((p) => p.name === n);
|
|
arr.refresh = () => {};
|
|
return arr;
|
|
},
|
|
});
|
|
} catch {}
|
|
|
|
try {
|
|
// 4. window.chrome shape — chrome.app + chrome.runtime + loadTimes/csi.
|
|
if (!window.chrome) {
|
|
window.chrome = {};
|
|
}
|
|
if (!window.chrome.runtime) {
|
|
window.chrome.runtime = { OnInstalledReason: {}, OnRestartRequiredReason: {} };
|
|
}
|
|
if (!window.chrome.app) {
|
|
window.chrome.app = {
|
|
isInstalled: false,
|
|
InstallState: { DISABLED: 'disabled', INSTALLED: 'installed', NOT_INSTALLED: 'not_installed' },
|
|
RunningState: { CANNOT_RUN: 'cannot_run', READY_TO_RUN: 'ready_to_run', RUNNING: 'running' },
|
|
};
|
|
}
|
|
if (!window.chrome.loadTimes) {
|
|
window.chrome.loadTimes = function () {
|
|
return { commitLoadTime: Date.now() / 1000, finishLoadTime: Date.now() / 1000 };
|
|
};
|
|
}
|
|
if (!window.chrome.csi) {
|
|
window.chrome.csi = function () {
|
|
return { startE: Date.now(), onloadT: Date.now(), pageT: 0, tran: 15 };
|
|
};
|
|
}
|
|
} catch {}
|
|
|
|
try {
|
|
// 5. mediaDevices — some headless builds drop it entirely.
|
|
if (!navigator.mediaDevices) {
|
|
Object.defineProperty(navigator, 'mediaDevices', {
|
|
get: () => ({ enumerateDevices: () => Promise.resolve([]) }),
|
|
});
|
|
}
|
|
} catch {}
|
|
|
|
try {
|
|
// 6. CDP cdc_* property cleanup. Chromium under CDP sets cdc_*-prefixed
|
|
// globals (driver injection markers); a bot detector finds them by
|
|
// iterating window keys. Strip all matching keys.
|
|
// Note: via applyStealth this is redundant with AUTOMATION_ARTIFACT_
|
|
// CLEANUP_SCRIPT (which runs first on every path). Kept so this script
|
|
// is self-sufficient if ever applied standalone.
|
|
for (const k of Object.keys(window)) {
|
|
if (k.startsWith('cdc_')) {
|
|
try { delete window[k]; } catch {}
|
|
}
|
|
}
|
|
} catch {}
|
|
})();
|
|
`;
|
|
|
|
function extendedModeEnabled(): boolean {
|
|
const v = process.env.GSTACK_STEALTH;
|
|
return v === 'extended' || v === '1' || v === 'true';
|
|
}
|
|
|
|
/**
|
|
* Strip automation runtime artifacts that don't belong in a real browser
|
|
* and that no fingerprint-synthesis layer can mask: ChromeDriver/CDP window
|
|
* globals (cdc_*, __webdriver*) and the Permissions API quirk where an
|
|
* automated Chromium reports notifications as 'denied' instead of real
|
|
* Chrome's 'prompt'. The 'prompt' answer is aligned with Layer C's
|
|
* Notification.permission = 'default' so the two surfaces stay consistent.
|
|
*
|
|
* Runs on EVERY launch path via applyStealth (headless launch(),
|
|
* launchHeaded(), handoff()) so the Notification/Permissions pairing never
|
|
* diverges by mode. Previously this lived inline in launchHeaded() only,
|
|
* which left headless and handoff with the Notification value but not the
|
|
* matching Permissions answer.
|
|
*/
|
|
export const AUTOMATION_ARTIFACT_CLEANUP_SCRIPT = `(() => {
|
|
// cdc_/__webdriver globals are injected by ChromeDriver/CDP. A detector
|
|
// finds them by iterating window keys. Strip immediately and again after a
|
|
// tick in case they are injected late.
|
|
const cleanup = () => {
|
|
for (const key of Object.keys(window)) {
|
|
if (key.startsWith('cdc_') || key.startsWith('__webdriver')) {
|
|
try { delete window[key]; } catch (e) { if (!(e instanceof TypeError)) throw e; }
|
|
}
|
|
}
|
|
};
|
|
cleanup();
|
|
setTimeout(cleanup, 0);
|
|
|
|
// Permissions API: automated Chromium returns 'denied' for notifications,
|
|
// a known tell. Return 'prompt' to match real Chrome (and Layer C's
|
|
// Notification.permission = 'default'). Tradeoff: this pins the
|
|
// notifications state to fresh-Chrome values for the whole session, so a
|
|
// site that actually grants/denies notifications would see a stale value.
|
|
// Acceptable for the automation/anti-detection use case (which does not
|
|
// drive real notification grants); only notifications is overridden.
|
|
const originalQuery = window.navigator.permissions && window.navigator.permissions.query;
|
|
if (originalQuery) {
|
|
window.navigator.permissions.query = (params) => {
|
|
if (params && params.name === 'notifications') {
|
|
return Promise.resolve({ state: 'prompt', onchange: null });
|
|
}
|
|
return originalQuery.call(window.navigator.permissions, params);
|
|
};
|
|
}
|
|
})();`;
|
|
|
|
/**
|
|
* Apply stealth patches to a fresh BrowserContext (or persistent context).
|
|
* Called by EVERY context-creation path in browser-manager — launch(),
|
|
* launchHeaded(), handoff(), AND recreateContext() (the useragent /
|
|
* viewport --scale rebuild) — so a context can never reach a page un-stealthed.
|
|
*
|
|
* Injection order (Playwright evaluates init scripts in registration order):
|
|
* 1. Layer C (buildStealthScript) — the always-on consistency-first default.
|
|
* 2. Automation-artifact cleanup (cdc_/__webdriver + Permissions shim),
|
|
* kept consistent with Layer C's Notification.permission alignment.
|
|
* 3. EXTENDED_STEALTH_SCRIPT — only when GSTACK_STEALTH=extended (off by
|
|
* default). Its window.chrome.* patches are `if (!...)`-guarded, so
|
|
* Layer C's richer shapes win; the extended-only additions (WebGL spoof,
|
|
* faked navigator.plugins, mediaDevices) apply on top.
|
|
*
|
|
* KNOWN LIMITATION (extended mode only, opt-in): extended's functions are NOT
|
|
* wrapped by Layer C's Function.prototype.toString proxy, so they stringify
|
|
* as injected code; its prototype-level navigator.webdriver delete is shadowed
|
|
* by Layer C's own-property getter (net behavior still matches real Chrome:
|
|
* webdriver present and false); and its hardcoded Apple-M1 WebGL string can
|
|
* disagree with the env-driven GPU spoof in buildGStackLaunchArgs on non-Apple
|
|
* hosts. This is acceptable for the documented "actively lies, may break sites"
|
|
* escape hatch; the consistency-first default (Layer C alone) has none of these.
|
|
*
|
|
* Host profile is resolved from process.env at call time so per-install
|
|
* values bake into the script before Playwright sends it to Chromium via
|
|
* Page.addScriptToEvaluateOnNewDocument.
|
|
*/
|
|
export async function applyStealth(context: BrowserContext): Promise<void> {
|
|
const hw = readHostProfile();
|
|
await context.addInitScript({ content: buildStealthScript(hw) });
|
|
await context.addInitScript({ content: AUTOMATION_ARTIFACT_CLEANUP_SCRIPT });
|
|
if (extendedModeEnabled()) {
|
|
await context.addInitScript({ content: EXTENDED_STEALTH_SCRIPT });
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Args added to chromium.launch's `args` to suppress the
|
|
* AutomationControlled blink feature. This is independent of the init
|
|
* script — it changes how Chromium identifies itself in the protocol layer.
|
|
*/
|
|
export const STEALTH_LAUNCH_ARGS = [
|
|
'--disable-blink-features=AutomationControlled',
|
|
];
|
|
|
|
/**
|
|
* Build the `--gstack-*=` cmdline switches that the Pack 1 Chromium
|
|
* patches read (webgl-vendor-spoof, ua-client-hints-stealth, worker-
|
|
* navigator-stealth). Values come from the GSTACK_* env vars that
|
|
* gbd populates from host_profile.go at startup.
|
|
*
|
|
* Each switch is only emitted when its env var is non-empty — empty
|
|
* env values fall through to the patch's "no override" path, which
|
|
* returns the real Chromium native value. This keeps the helper safe
|
|
* on builds that DO NOT have the C++ patches applied (gbrowser
|
|
* pre-Pack-1) and on hosts where gbd hasn't yet populated some
|
|
* fields (legacy installs).
|
|
*
|
|
* TRUSTED-SOURCE ONLY. These GSTACK_* values are populated by gbd from
|
|
* host_profile.go (system_profiler / sysctl) and become page-visible WebGL /
|
|
* UA-CH surface data. They are NOT sanitized here (passed verbatim into the
|
|
* argv array, which is injection-safe because Playwright spawns Chromium with
|
|
* an argv array, not a shell). NEVER route page content, HTTP headers, or any
|
|
* remote/untrusted input into these env vars — that would turn this into an
|
|
* argv-injection sink. readHostProfile() applies the same trust assumption.
|
|
*
|
|
* Mapping (gbd env → Chromium cmdline switch → C++ patch consumer):
|
|
* GSTACK_GPU_VENDOR → --gstack-gpu-vendor → webgl-vendor-spoof.patch
|
|
* GSTACK_GPU_RENDERER → --gstack-gpu-renderer → webgl-vendor-spoof.patch
|
|
* GSTACK_PLATFORM → --gstack-ua-platform → ua-client-hints-stealth.patch
|
|
* (maps MacARM/MacIntel → "macOS")
|
|
* GSTACK_GPU_CHIPSET → --gstack-ua-model → ua-client-hints-stealth.patch
|
|
* GSTACK_HW_CONCURRENCY → --gstack-hw-concurrency → worker-navigator-stealth.patch
|
|
* GSTACK_DEVICE_MEMORY → --gstack-device-memory → worker-navigator-stealth.patch
|
|
*/
|
|
export function buildGStackLaunchArgs(): string[] {
|
|
const env = (globalThis as any).process?.env ?? {};
|
|
const args: string[] = [];
|
|
|
|
const vendor = env.GSTACK_GPU_VENDOR;
|
|
if (vendor) args.push(`--gstack-gpu-vendor=${vendor}`);
|
|
|
|
const renderer = env.GSTACK_GPU_RENDERER;
|
|
if (renderer) args.push(`--gstack-gpu-renderer=${renderer}`);
|
|
|
|
// Map gbd's "MacARM"/"MacIntel" classification to the UA-CH "macOS"
|
|
// platform string Chromium emits natively. Other future platforms
|
|
// would map similarly (Win32 → "Windows", Linux → "Linux").
|
|
const platform = env.GSTACK_PLATFORM;
|
|
if (platform === 'MacARM' || platform === 'MacIntel') {
|
|
args.push('--gstack-ua-platform=macOS');
|
|
} else if (platform === 'Win32') {
|
|
args.push('--gstack-ua-platform=Windows');
|
|
} else if (platform && platform.startsWith('Linux')) {
|
|
args.push('--gstack-ua-platform=Linux');
|
|
}
|
|
|
|
const chipset = env.GSTACK_GPU_CHIPSET;
|
|
if (chipset) args.push(`--gstack-ua-model=${chipset}`);
|
|
|
|
const hw = env.GSTACK_HW_CONCURRENCY;
|
|
if (hw) args.push(`--gstack-hw-concurrency=${hw}`);
|
|
|
|
const memory = env.GSTACK_DEVICE_MEMORY;
|
|
if (memory) args.push(`--gstack-device-memory=${memory}`);
|
|
|
|
// Pack 2 / B11: suppress user-defined Error.prepareStackTrace during
|
|
// V8 stack-trace formatting. Closes the Cloudflare Bot Management canary
|
|
// trick where a page sets prepareStackTrace and watches for it to fire
|
|
// during CDP serialization.
|
|
//
|
|
// OPT-IN (off by default): only emitted when GSTACK_CDP_STEALTH is
|
|
// on/1/true. This switch is read by a C++ patch that only exists in
|
|
// gbrowser builds; gbd opts in by exporting GSTACK_CDP_STEALTH=on. Stock
|
|
// Playwright Chromium leaves it unset, so the flag never reaches a
|
|
// Chromium that wouldn't understand it. (Previously this was on-by-default
|
|
// unless GSTACK_CDP_STEALTH=off, which contradicted this very comment.)
|
|
const cdpStealth = env.GSTACK_CDP_STEALTH;
|
|
if (cdpStealth === 'on' || cdpStealth === '1' || cdpStealth === 'true') {
|
|
args.push('--gstack-suppress-prepare-stack-trace');
|
|
}
|
|
|
|
return args;
|
|
}
|
|
|
|
/**
|
|
* Playwright default args to strip via ignoreDefaultArgs.
|
|
*
|
|
* Playwright passes these by default. Each one is a visible automation
|
|
* tell at some layer:
|
|
* --enable-automation → infobar + chrome shape
|
|
* --disable-extensions → blocks our extension
|
|
* --disable-component-extensions-with-background-pages → blocks component ext
|
|
* --disable-popup-blocking → automation default
|
|
* --disable-component-update → automation default
|
|
* --disable-default-apps → affects plugin enum
|
|
*
|
|
* Used by browser-manager via spread into ignoreDefaultArgs to keep
|
|
* the list in one place across launchHeaded() and handoff().
|
|
*/
|
|
export const STEALTH_IGNORE_DEFAULT_ARGS = [
|
|
'--enable-automation',
|
|
'--disable-extensions',
|
|
'--disable-component-extensions-with-background-pages',
|
|
'--disable-popup-blocking',
|
|
'--disable-component-update',
|
|
'--disable-default-apps',
|
|
];
|
|
|
|
/** Test-only helper: report whether extended mode is currently active. */
|
|
export function isExtendedStealthEnabled(): boolean {
|
|
return extendedModeEnabled();
|
|
}
|