mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-02 17:40:02 +02:00
garrytan
6415690a18
- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
budget, never on skill behavior; delete them, their touchfile/tier ids,
AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
(11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
closure, and delete the free replay tests whose assertions exercised only
that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
only as input for a live subject keep their assertions: the multiSelect
default moved to plan-review-decisions, runner PTY tests use inline caller
policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
(its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
and per-finding cadence coverage with their re-entry tests.
140 lines
9.3 KiB
TypeScript
140 lines
9.3 KiB
TypeScript
import { expect, test } from 'bun:test';
|
||
import captured from './fixtures/eng-d1-clipped-elision-1579.json';
|
||
import planningCapture from './fixtures/eng-d2-planning-prelude-4d.json';
|
||
import { capturePlanCountQuestion, matchesNativePlanQuestion } from './helpers/claude-pty-runner';
|
||
import type { NativePlanQuestionCall } from './helpers/plan-count-transcript';
|
||
|
||
const screen = captured.screen;
|
||
function pending(): NativePlanQuestionCall {
|
||
const record = structuredClone(captured.pendingRecord.pending);
|
||
return { sessionId: record.sessionId, toolUseId: record.toolUseId,
|
||
questions: record.questions, answered: false, failed: false };
|
||
}
|
||
const cursor = screen.indexOf('❯ 1.');
|
||
const body = screen.slice(0, cursor);
|
||
const menu = screen.slice(cursor);
|
||
for (const [name, visible] of [
|
||
['CRLF transport', screen.replaceAll('\n', '\r\n')],
|
||
['blank viewport padding', '\n \n' + screen],
|
||
['blank rail padding', '│\n' + screen],
|
||
['further viewport clipping', screen.slice(screen.indexOf('\n') + 1)],
|
||
] as const) test(`clipped native elision preserves ${name}`, () => {
|
||
const call = pending();
|
||
expect(matchesNativePlanQuestion(visible, call)).toBe(true);
|
||
expect(capturePlanCountQuestion(visible, new Set(), 0, true, call)?.nativeCall).toBe(call);
|
||
});
|
||
|
||
const negatives: [string, (value: string) => string][] = [
|
||
['foreign introduction', value => 'Quoted earlier menu:\n' + value],
|
||
['fenced copy', value => '```text\n' + value + '\n```'],
|
||
['competing header', value => '☐ Other\n' + value],
|
||
['earlier menu', value => '❯ 1. Old option\n' + value],
|
||
['changed visible body', value => value.replace('Project/branch/task:', 'Unrelated/branch/task:')],
|
||
['missing elision', value => value.replace('DRY sme…', 'DRY sme')],
|
||
['invented body suffix', value => value.replace('DRY sme…', 'DRY smell and extra work…')],
|
||
['changed offered label', value => value.replace('1. Simplify class layout', '1. Expand feature scope')],
|
||
['reordered offered labels', value => value.replace('1. Simplify class layout', '1. Keep all five as proposed').replace('2. Keep all five as proposed', '2. Simplify class layout')],
|
||
['extra offered action', value => value.replace('4. Type something.', '4. New action')],
|
||
['missing footer', value => value.replace(' · Esc to cancel', '')],
|
||
['later prose', value => value + '\nAnother unrelated prompt'],
|
||
['options only', value => value.slice(cursor)],
|
||
['short common suffix', () => '│ a DRY sme…\n\n' + menu],
|
||
];
|
||
for (const [name, mutate] of negatives) test(`clipped elision cannot authorize ${name}`, () => {
|
||
const changed = mutate(screen), call = pending();
|
||
expect(changed).not.toBe(screen);
|
||
expect(matchesNativePlanQuestion(changed, call)).toBe(false);
|
||
expect(capturePlanCountQuestion(changed, new Set(), 0, true, call)?.nativeCall).toBeUndefined();
|
||
});
|
||
|
||
test('clipped native display uses the pinned UTF-16 boundary and tab substitution', () => {
|
||
const call = pending();
|
||
const prefix = 'Hidden first line\n' + 'a'.repeat(1999 - 'Hidden first line\n'.length - 1) + '\n';
|
||
expect(prefix.length).toBe(1999);
|
||
call.questions[0]!.question = prefix + '😀' + 'unrendered tail'.repeat(40);
|
||
const visible = '│ ' + prefix.slice('Hidden first line\n'.length, 1400) + '\n│ ' + prefix.slice(1400) + '…\n\n' + menu;
|
||
expect(matchesNativePlanQuestion(visible, call)).toBe(true);
|
||
expect(matchesNativePlanQuestion(visible.replace('…', '\uD83D…'), call)).toBe(false);
|
||
const tabCall = pending();
|
||
tabCall.questions[0]!.question = tabCall.questions[0]!.question.replace('Project/branch/task: ', 'Project/branch/task:\t');
|
||
expect(matchesNativePlanQuestion(screen, tabCall)).toBe(true);
|
||
});
|
||
|
||
test('the clipped prefix cannot borrow another elision boundary', () => {
|
||
const longer = pending(), shorter = pending();
|
||
longer.questions[0]!.question = 'X' + longer.questions[0]!.question;
|
||
shorter.questions[0]!.question = shorter.questions[0]!.question.slice(1);
|
||
expect(matchesNativePlanQuestion(screen, longer)).toBe(false);
|
||
expect(matchesNativePlanQuestion(screen, shorter)).toBe(false);
|
||
});
|
||
|
||
test('an elided packet must match exactly one current native tab', () => {
|
||
const call = pending(), other = structuredClone(call.questions[0]!);
|
||
other.question = other.question.replace('Project/branch/task:', 'Other/branch/task:');
|
||
call.questions.unshift(other);
|
||
const pane = screen.replace('↑/↓ to navigate', 'Tab/Arrow keys to navigate');
|
||
expect(matchesNativePlanQuestion(pane, call)).toBe(true);
|
||
expect(capturePlanCountQuestion(pane, new Set(), 0, true, call)?.nativeQuestionIndex).toBe(1);
|
||
call.questions[0] = structuredClone(call.questions[1]!);
|
||
expect(matchesNativePlanQuestion(pane, call)).toBe(false);
|
||
});
|
||
// The native CLI, not the model, prepends this plan-mode path block. Its
|
||
// basename is not independently witnessed: authority is limited to a direct
|
||
// Markdown child of the same session's isolated native plans directory.
|
||
const planningDirectory = planningCapture.pendingRecord.configDir + '/plans';
|
||
const planningScreen = planningCapture.screen;
|
||
const planningPane = planningScreen.slice(planningScreen.indexOf('─'));
|
||
const planningPath = planningScreen.slice(0, planningScreen.indexOf('─')).trimEnd().replaceAll('\n', '').slice('Planning: '.length);
|
||
function planningPending(): NativePlanQuestionCall {
|
||
const record = structuredClone(planningCapture.pendingRecord.pending);
|
||
return { sessionId: record.sessionId, toolUseId: record.toolUseId,
|
||
questions: record.questions, answered: false, failed: false };
|
||
}
|
||
const withPlanning = (file: string, columns = 120) =>
|
||
Bun.wrapAnsi('Planning: ' + file, columns, {hard:true,trim:false}).split('\n').map((row, index) =>
|
||
(index && row.startsWith(' ') && Bun.stringWidth(row.slice(1)) > 0 ? row.slice(1) : row).trimEnd()).join('\n') + '\n' +
|
||
planningPane.replace(/^─+/, '─'.repeat(columns));
|
||
for (const [name, visible, directory] of [
|
||
['unwrapped path', withPlanning(planningPath, 160), planningDirectory],
|
||
['three physical path rows', withPlanning(planningPath, 60), planningDirectory],
|
||
['native leading rule', '─'.repeat(120) + '\n' + planningScreen, planningDirectory],
|
||
['CRLF and blank viewport padding', '\r\n \r\n' + planningScreen.replaceAll('\n', '\r\n'), planningDirectory],
|
||
['another direct Markdown basename', withPlanning(planningDirectory + '/second_native-plan.md'), planningDirectory],
|
||
['spaces in the owned config path', withPlanning('/tmp/owned workspace/.claude/plans/native-plan.md', 40), '/tmp/owned workspace/.claude/plans'],
|
||
['wide characters in the owned config path', withPlanning('/tmp/工作区/.claude/plans/native-plan.md', 40), '/tmp/工作区/.claude/plans'],
|
||
['native soft-row space removal', withPlanning('/tmp/' + 'x'.repeat(15) + ' workspace/.claude/plans/native.md', 30), '/tmp/' + 'x'.repeat(15) + ' workspace/.claude/plans'],
|
||
] as const) test(`owned native Planning prelude supports ${name}`, () => {
|
||
const call = planningPending();
|
||
expect(matchesNativePlanQuestion(visible, call, directory)).toBe(true);
|
||
expect(capturePlanCountQuestion(visible, new Set(), 0, true, call, directory)?.nativeCall).toBe(call);
|
||
});
|
||
|
||
for (const [name, visible, directory] of [
|
||
['absent ownership context', planningScreen, undefined],
|
||
['foreign session config', planningScreen, '/tmp/other-session/.claude/plans'],
|
||
['relative ownership context', planningScreen, 'plans'],
|
||
['sibling directory', withPlanning(planningDirectory + '-other/native.md'), planningDirectory],
|
||
['nested child', withPlanning(planningDirectory + '/nested/native.md'), planningDirectory],
|
||
['parent traversal', withPlanning(planningDirectory + '/../plans/native.md'), planningDirectory],
|
||
['dot traversal', withPlanning(planningDirectory + '/./native.md'), planningDirectory],
|
||
['non-Markdown path', withPlanning(planningDirectory + '/native.txt'), planningDirectory],
|
||
['quoted path', withPlanning('"' + planningPath + '"'), planningDirectory],
|
||
['quoted block', planningScreen.split('\n').map(row => '> ' + row).join('\n'), planningDirectory],
|
||
['open fence', '```text\n' + planningScreen, planningDirectory],
|
||
['extra leading prose', 'Earlier question:\n' + planningScreen, planningDirectory],
|
||
['extra prose after path', planningScreen.replace('\n─', '\nPlease choose now.\n─'), planningDirectory],
|
||
['blank gap before native rule', planningScreen.replace('\n─', '\n\n─'), planningDirectory],
|
||
['foreign native header', planningScreen.replace('☐ Structure', '☐ Other'), planningDirectory],
|
||
['changed current body', planningScreen.replace('Class arrangement:', 'Unrelated arrangement:'), planningDirectory],
|
||
['changed offered label', planningScreen.replace('1. Simplify class layout', '1. Add new product behavior'), planningDirectory],
|
||
['missing footer', planningScreen.replace(' · Esc to cancel', ''), planningDirectory],
|
||
['later prose', planningScreen + '\nAnother question', planningDirectory],
|
||
['wrong wrap width', planningScreen.replace(/^─+/m, '─'.repeat(119)), planningDirectory],
|
||
['invented early wrap', planningScreen.replace('Planning: /tmp/', 'Planning: /\ntmp/'), planningDirectory],
|
||
['mismatched leading rule', '─'.repeat(119) + '\n' + planningScreen, planningDirectory],
|
||
] as const) test(`native Planning prelude rejects ${name}`, () => {
|
||
const call = planningPending();
|
||
expect(matchesNativePlanQuestion(visible, call, directory)).toBe(false);
|
||
expect(capturePlanCountQuestion(visible, new Set(), 0, true, call, directory)?.nativeCall).toBeUndefined();
|
||
});
|