Files
gstack/test/plan-count-transcript.test.ts
T
garrytan 6415690a18 test: retire the finding-count cluster and trim its helpers (C)
- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
  skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
  budget, never on skill behavior; delete them, their touchfile/tier ids,
  AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
  (11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
  closure, and delete the free replay tests whose assertions exercised only
  that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
  only as input for a live subject keep their assertions: the multiSelect
  default moved to plan-review-decisions, runner PTY tests use inline caller
  policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
  (its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
  and per-finding cadence coverage with their re-entry tests.
2026-09-29 06:08:49 +00:00

209 lines
12 KiB
TypeScript

import { afterEach, describe, expect, test } from 'bun:test';
import * as fs from 'node:fs';
import * as os from 'node:os';
import * as path from 'node:path';
import { readPlanCountTranscript, unresolvedPlanQuestionCalls } from './helpers/plan-count-transcript';
import { nativePlanCallFingerprint, planCountQuestionPhase, engStep0Boundary } from './helpers/claude-pty-runner';
const dirs: string[] = [];
afterEach(() => { for (const dir of dirs.splice(0)) fs.rmSync(dir, { recursive: true, force: true }); });
function fixture() {
const config = fs.mkdtempSync(path.join(os.tmpdir(), 'plan-count-transcript-'));
dirs.push(config);
const cwd = path.join(config, 'fixture');
const project = path.join(config, 'projects', 'fixture');
fs.mkdirSync(project, { recursive: true });
const sessionId = 'session-a';
const file = path.join(project, `${sessionId}.jsonl`);
const record = (role: string, content: object[], extra = {}) => ({
cwd, sessionId, isSidechain: false, timestamp: '2026-09-08T15:31:13.607Z',
message: { role, content }, ...extra,
});
const question = (text = 'D1 — Cross-project learnings scope <gstack-qid:learnings-cross-project>') => ({
header: 'Learnings', question: text,
options: [{ label: 'Enable cross-project learnings (Recommended)' }, { label: 'Keep project-scoped' }],
});
const ask = (id: string, questions = [question()], extra = {}) => record('assistant', [
{ type: 'tool_use', id, name: 'AskUserQuestion', input: { questions } },
], extra);
const answer = (id: string, questions = [question()], extra = {}) => record('user', [
{ type: 'tool_result', tool_use_id: id, content: 'Your questions have been answered.' },
], { toolUseResult: { answers: Object.fromEntries(questions.map(q => [q.question, q.options[0].label])) }, ...extra });
const append = (...records: object[]) => fs.appendFileSync(file, records.map(r => JSON.stringify(r) + '\n').join(''));
const read = () => readPlanCountTranscript(config, cwd);
return { config, cwd, project, file, question, ask, answer, append, read, record };
}
describe('native plan-count transcripts', () => {
test('requires a matching successful answer and preserves full native question metadata', () => {
const f = fixture();
const questions = [f.question('D1 — Cross-project learnings scope\n' + 'full context '.repeat(40) + '<gstack-qid:learnings-cross-project>')];
f.append(f.ask('one', questions));
expect(f.read().calls[0].answered).toBe(false);
f.append(f.answer('one', questions));
const before = fs.readFileSync(f.file, 'utf8');
const observed = f.read();
expect(observed.status).toBe('ready');
expect(observed.calls).toHaveLength(1);
expect(observed.calls[0].answered).toBe(true);
expect(observed.calls[0].questions).toEqual(questions);
const fp = nativePlanCallFingerprint(observed.calls[0], 1, true);
expect(fp.promptSnippet.length).toBeGreaterThan(240);
expect(fp.promptSnippet).toContain('<gstack-qid:learnings-cross-project>');
expect(planCountQuestionPhase(fp, false, engStep0Boundary)).toEqual({ preReview: true, reviewStarted: true });
expect(fs.readFileSync(f.file, 'utf8')).toBe(before);
});
test('one completed batched AskUserQuestion call remains one count even with unanswered questions', () => {
const f = fixture();
const questions = [f.question('D1 — Retry behavior?'), f.question('D2 — Error handling?')];
f.append(f.ask('batch', questions), f.answer('batch', [questions[0]]));
expect(f.read().calls.filter(c => c.answered)).toHaveLength(1);
expect(f.read().calls[0].unansweredQuestionIndices).toEqual([1]);
f.append(f.answer('batch', questions));
expect(f.read().calls.filter(c => c.answered)).toHaveLength(1);
expect(f.read().calls[0].questions).toHaveLength(2);
});
test('partial JSONL appends add no call or completion until the final newline', () => {
const f = fixture();
const call = JSON.stringify(f.ask('one'));
fs.writeFileSync(f.file, call.slice(0, 80));
expect(f.read()).toEqual({ status: 'missing', calls: [], assistantMessages: [] });
fs.appendFileSync(f.file, call.slice(80));
expect(f.read().calls).toEqual([]);
fs.appendFileSync(f.file, '\n');
expect(f.read().calls[0].answered).toBe(false);
const result = JSON.stringify(f.answer('one'));
fs.appendFileSync(f.file, result.slice(0, 80));
expect(f.read().calls[0].answered).toBe(false);
fs.appendFileSync(f.file, result.slice(80) + '\n');
expect(f.read().calls[0].answered).toBe(true);
});
test('repeated records and polls dedupe by tool ID, while identical questions in distinct calls remain distinct', () => {
const f = fixture();
f.append(f.ask('one'), f.ask('one'), f.answer('one'), f.answer('one'), f.ask('two'), f.answer('two'));
const first = f.read();
expect(first.calls.filter(c => c.answered)).toHaveLength(2);
expect(f.read()).toEqual(first);
expect(first.calls.map(c => nativePlanCallFingerprint(c, 0, false).signature)).toEqual(['session-a:one', 'session-a:two']);
});
test('wrong cwd, sidechain, session, tool ID, and missing scope cannot provide an answer', () => {
const f = fixture();
f.append(f.ask('one'));
for (const extra of [{ cwd: '/other' }, { isSidechain: true }, { sessionId: 'other' }, { cwd: undefined }, { isSidechain: undefined }]) {
f.append(f.answer('one', undefined, extra), f.ask('foreign', undefined, extra));
}
f.append(f.answer('wrong-id'));
expect(f.read().calls).toHaveLength(1);
expect(f.read().calls[0].answered).toBe(false);
fs.writeFileSync(path.join(f.project, 'other.jsonl'), JSON.stringify(f.answer('one', undefined, { sessionId: 'other' })) + '\n');
expect(f.read().calls[0].answered).toBe(false);
});
test('native permissions, schema failures, errors and refusals do not become completed questions', () => {
const f = fixture();
f.append(f.record('assistant', [{ type: 'tool_use', id: 'write', name: 'Write', input: { file_path: 'PLAN.md' } }]));
f.append(f.answer('write'));
f.append(f.record('assistant', [{ type: 'tool_use', id: 'bad', name: 'AskUserQuestion', input: { questions: [] } }]));
f.append(f.answer('bad'));
f.append(f.ask('error'));
f.append(f.record('user', [{ type: 'tool_result', tool_use_id: 'error', is_error: true, content: 'Rejected' }],
{ toolUseResult: { answers: { [f.question().question]: 'Yes' } } }));
f.append(f.ask('refusal'), f.answer('refusal', undefined, { toolUseResult: { answers: {} } }));
expect(f.read().calls).toHaveLength(2);
expect(f.read().calls.filter(c => c.answered)).toHaveLength(0);
expect(f.read().calls.every(c => c.failed)).toBe(true);
});
test('unrelated answered questions cannot conceal a refusal, but an actual retry can resolve it', () => {
const f = fixture();
const missing = [f.question('Should retries preserve idempotency?')];
const unrelated = [f.question('Should errors be logged?')];
f.append(f.ask('refusal', missing), f.answer('refusal', [], { toolUseResult: { answers: {} } }));
f.append(f.ask('unrelated', unrelated), f.answer('unrelated', unrelated));
expect(unresolvedPlanQuestionCalls(f.read().calls).map(c => c.toolUseId)).toEqual(['refusal']);
f.append(f.ask('retry', missing), f.answer('retry', missing));
expect(unresolvedPlanQuestionCalls(f.read().calls)).toEqual([]);
expect(f.read().calls.filter(c => c.answered)).toHaveLength(2);
});
test('missing transcripts and files from another fixture produce no positive coverage', () => {
const f = fixture();
expect(f.read()).toEqual({ status: 'missing', calls: [], assistantMessages: [] });
f.append(f.ask('other', undefined, { cwd: '/different-fixture' }), f.answer('other', undefined, { cwd: '/different-fixture' }));
expect(f.read()).toEqual({ status: 'missing', calls: [], assistantMessages: [] });
expect(readPlanCountTranscript(path.join(f.config, 'absent'), f.cwd)).toEqual({ status: 'missing', calls: [], assistantMessages: [] });
});
test('invalid completed JSON and excessive bytes fail explicitly without retaining partial coverage', () => {
const f = fixture();
f.append(f.ask('one'), f.answer('one'));
fs.appendFileSync(f.file, 'not JSON\n');
expect(f.read().status).toBe('error');
expect(f.read().calls).toEqual([]);
fs.writeFileSync(f.file, '');
fs.truncateSync(f.file, 32 * 1024 * 1024 + 1);
expect(f.read().error).toContain('32 MiB');
expect(f.read().calls).toEqual([]);
});
test('assistant posture evidence is scoped, timestamped text rather than tool results or partial records', () => {
const f = fixture();
f.append(f.record('assistant', [{ type: 'text', text: 'Earlier assistant posture.' }], { timestamp: '2026-09-08T15:31:10.000Z' }));
f.append(f.ask('mode'), f.answer('mode'));
f.append(f.record('assistant', [{ type: 'text', text: 'Later assistant posture.' }], { timestamp: '2026-09-08T15:31:20.000Z' }));
for (const extra of [{ cwd: '/other' }, { isSidechain: true }, { sessionId: 'other' }, { timestamp: 'invalid' }, { timestamp: undefined }]) {
f.append(f.record('assistant', [{ type: 'text', text: 'Not evidence.' }], extra));
}
f.append(f.record('user', [{ type: 'text', text: 'User prose is not assistant posture.' }]));
f.append(f.record('user', [{ type: 'tool_result', tool_use_id: 'other', content: 'Tool result posture is not evidence.' }]));
const observed = f.read();
expect(observed.assistantMessages).toEqual([
{ sessionId: 'session-a', text: 'Earlier assistant posture.', timestamp: '2026-09-08T15:31:10.000Z' },
{ sessionId: 'session-a', text: 'Later assistant posture.', timestamp: '2026-09-08T15:31:20.000Z' },
]);
expect(observed.calls[0].answeredAt).toBe('2026-09-08T15:31:13.607Z');
fs.appendFileSync(f.file, JSON.stringify(f.record('assistant', [{ type: 'text', text: 'Still writing.' }])));
expect(f.read().assistantMessages).toEqual(observed.assistantMessages);
fs.appendFileSync(f.file, '\ninvalid JSON\n');
expect(f.read().assistantMessages).toEqual([]);
expect(f.read().calls).toEqual([]);
});
});
describe('native plan approval request evidence', () => {
test('captures only a scoped complete ExitPlanMode request and retains error results', () => {
const f = fixture();
// Exact native tool shape from G Design's pending approval gate (its
// zero-question workflow remains a separate failed count observation).
const ready = f.record('assistant', [{ type: 'tool_use', id: 'plan-ready', name: 'ExitPlanMode', input: {}, caller: { type: 'direct' } }]);
const line = JSON.stringify(ready);
fs.writeFileSync(f.file, line);
expect(f.read().planReadyRequests).toBeUndefined();
fs.appendFileSync(f.file, '\n');
expect(f.read().planReadyRequests).toEqual([{ sessionId: 'session-a', toolUseId: 'plan-ready', timestamp: ready.timestamp, failed: false }]);
f.append(f.record('user', [{ type: 'tool_result', tool_use_id: 'plan-ready', is_error: true, content: 'Plan not accepted' }]));
expect(f.read().planReadyRequests![0]!.failed).toBe(true);
f.append(ready); // duplicate request cannot clear a recorded failure
expect(f.read().planReadyRequests![0]!.failed).toBe(true);
});
test('foreign, sidechain, quoted, lookalike and untimestamped requests add no readiness', () => {
const f = fixture();
const block = { type: 'tool_use', id: 'ready', name: 'ExitPlanMode', input: {} };
f.append(f.record('assistant', [block], { cwd: f.cwd + '-other' }),
f.record('assistant', [block], { sessionId: 'foreign' }),
f.record('assistant', [block], { isSidechain: true }),
f.record('assistant', [block], { timestamp: 'invalid' }),
f.record('assistant', [{ ...block, name: 'example_ExitPlanMode' }]),
f.record('assistant', [{ type: 'text', text: JSON.stringify(block) }]));
expect(f.read().planReadyRequests).toBeUndefined();
fs.appendFileSync(f.file, 'bad JSON\n');
expect(f.read().status).toBe('error');
expect(f.read().planReadyRequests).toBeUndefined();
});
});