mirror of
https://github.com/garrytan/gstack.git
synced 2026-07-05 23:57:53 +02:00
d0463e59ed
Cherry-picked from #1465 by genisis0x and extended with the v1.40.0.0 upgrade migration that codex review #5 surfaced. #1465 alone only patches bin/gstack-artifacts-init, which means fresh installs and re-inits pick up the new pattern. But existing users who already ran v1.38.1.0 have a `.migrations/v1.38.1.0.done` marker — that migration won't re-run no matter what we change. So their installed `.brain-allowlist`, `.brain-privacy-map.json`, and `.gitattributes` stay without the new pattern, and `/plan-eng-review` artifacts continue to silently drop out of their federation queue. This commit: - bin/gstack-artifacts-init: adds projects/*/*-eng-review-test-plan-*.md to the three managed blocks. v1.38.1.0 covered design + test-plan; this completes the set for /plan-eng-review. - gstack-upgrade/migrations/v1.40.0.0.sh: targeted in-place repair for existing installs. Same idempotent jq-based shape as v1.38.1.0. Adds the new pattern to .brain-allowlist (before the USER ADDITIONS marker), .brain-privacy-map.json (as class=artifact), and .gitattributes (as merge=union). NEVER commits + pushes — the user controls when the patches ship to their federated artifacts repo. - test/artifacts-init-migration.test.ts: 5 new tests covering the v1.40.0.0 migration applied on top of a post-v1.38.1.0 state, jq patching, gitattributes append, idempotent re-run, and done-marker write when files are missing entirely. Co-Authored-By: Claude <noreply@anthropic.com>
98 lines
3.3 KiB
Bash
Executable File
98 lines
3.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Migration: v1.40.0.0 — add eng-review-test-plan project-root pattern to
|
|
# .brain-allowlist, .brain-privacy-map.json, and .gitattributes (#1452 follow-on).
|
|
#
|
|
# Why a second migration: v1.38.1.0 shipped two of three filenames for #1452
|
|
# (`*-design-*.md` and `*-test-plan-*.md`) but missed `/plan-eng-review`'s
|
|
# actual filename: `*-eng-review-test-plan-*.md`. The v1.38.1.0 migration has
|
|
# a done-marker, so a "fix v1.38.1.0 and re-run" approach silently no-ops on
|
|
# existing users. v1.40.0.0 needs its own migration to patch installs that
|
|
# already ran v1.38.1.0.
|
|
#
|
|
# Per-file independent — if one file is missing we still repair the others.
|
|
#
|
|
# Idempotent: each insertion is gated on `not already present` so re-running
|
|
# the migration is a no-op.
|
|
|
|
set -u
|
|
|
|
GSTACK_HOME="${HOME}/.gstack"
|
|
ALLOWLIST="${GSTACK_HOME}/.brain-allowlist"
|
|
PRIVACY="${GSTACK_HOME}/.brain-privacy-map.json"
|
|
GITATTRS="${GSTACK_HOME}/.gitattributes"
|
|
|
|
MIGRATION_DIR="${GSTACK_HOME}/.migrations"
|
|
DONE="${MIGRATION_DIR}/v1.40.0.0.done"
|
|
|
|
mkdir -p "${MIGRATION_DIR}" 2>/dev/null || true
|
|
if [ -f "${DONE}" ]; then
|
|
exit 0
|
|
fi
|
|
|
|
NEW_PATTERNS=(
|
|
'projects/*/*-eng-review-test-plan-*.md'
|
|
)
|
|
|
|
added_any=0
|
|
|
|
# ----- .brain-allowlist ---------------------------------------------------
|
|
if [ -f "${ALLOWLIST}" ]; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
if ! grep -Fq -- "${PATTERN}" "${ALLOWLIST}" 2>/dev/null; then
|
|
if grep -q '^# ---- USER ADDITIONS BELOW' "${ALLOWLIST}" 2>/dev/null; then
|
|
sed -i.bak "/^# ---- USER ADDITIONS BELOW/i\\
|
|
${PATTERN}
|
|
" "${ALLOWLIST}" && rm -f "${ALLOWLIST}.bak"
|
|
added_any=1
|
|
else
|
|
printf '%s\n' "${PATTERN}" >> "${ALLOWLIST}"
|
|
added_any=1
|
|
fi
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# ----- .brain-privacy-map.json -------------------------------------------
|
|
if [ -f "${PRIVACY}" ]; then
|
|
if command -v jq >/dev/null 2>&1; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
if ! jq -e --arg p "${PATTERN}" 'map(select(.pattern == $p)) | length > 0' "${PRIVACY}" >/dev/null 2>&1; then
|
|
if jq --arg p "${PATTERN}" '. += [{"pattern": $p, "class": "artifact"}]' "${PRIVACY}" > "${PRIVACY}.tmp" 2>/dev/null; then
|
|
mv "${PRIVACY}.tmp" "${PRIVACY}"
|
|
added_any=1
|
|
else
|
|
rm -f "${PRIVACY}.tmp"
|
|
echo " [v1.40.0.0] WARN: jq failed to patch ${PRIVACY}; skipping pattern ${PATTERN}." >&2
|
|
fi
|
|
fi
|
|
done
|
|
else
|
|
echo " [v1.40.0.0] WARN: jq not found; skipping privacy-map repair. Install jq and re-run gstack-upgrade, or run gstack-artifacts-init manually." >&2
|
|
fi
|
|
fi
|
|
|
|
# ----- .gitattributes -----------------------------------------------------
|
|
if [ -f "${GITATTRS}" ]; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
RULE="${PATTERN} merge=union"
|
|
if ! grep -Fq -- "${RULE}" "${GITATTRS}" 2>/dev/null; then
|
|
printf '%s\n' "${RULE}" >> "${GITATTRS}"
|
|
added_any=1
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# Mark done even if no patches needed — a fresh-init user's
|
|
# bin/gstack-artifacts-init now writes the pattern directly, so re-runs
|
|
# should no-op. The touchfile keeps the migration runner from looping.
|
|
touch "${DONE}"
|
|
|
|
if [ "${added_any}" = "1" ]; then
|
|
echo " [v1.40.0.0] allowlist/privacy-map/gitattributes patched for /plan-eng-review test plans (idempotent)" >&2
|
|
fi
|
|
|
|
# NEVER `git commit + push` from this migration. The user controls when the
|
|
# patches ship into their federated artifacts repo.
|
|
|
|
exit 0
|