mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 06:28:59 +02:00
JSON escaping is not shell escaping. Interpolating JSON.stringify(script)
into `bash -c ${...}` left every JSON "\n" as a literal backslash-n inside
shell double quotes, collapsing the extracted release-body tripwire block
onto one line: `then\n` parsed as the command word `thenn`, and
`>&2\nelse\n` parsed as the redirect `>&2nelsen` — so every full-suite run
littered a `2nelsen` file (containing "bash: thenn: command not found") in
the repo root, and the test's single not-contains assertion passed
VACUOUSLY because all output had been redirected into that file. The
"and it actually fires" functional check never verified anything.
Fix: pass the script as an argv element (spawnSync array form) and assert
both branches for real — ABORT case must print the leak message to stderr,
clean case must print "banner tripwire clean" to stdout.
Verified: `bun test test/binding-template-drift.test.ts` previously created
the artifact deterministically; the full free suite now runs artifact-free.
The other shell-interpolation sites (evidence, schema-aware concurrency,
empty-find-fallthrough, branch-slug-hygiene) already use correct quoting.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
123 lines
6.0 KiB
TypeScript
123 lines
6.0 KiB
TypeScript
import { describe, test, expect } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
/**
|
|
* Template-drift tripwire for the content-binding wave. The bins are
|
|
* code-enforced; the GRADING rules live as prose in rendered templates that
|
|
* agents follow. This test pins the load-bearing rule text in the GENERATED
|
|
* files so a template refactor can't silently drop a rule while the bins keep
|
|
* working. (Prompt-followed prose is honest tier-2 enforcement — this tripwire
|
|
* is what keeps it from being tier-3 vibes.)
|
|
*/
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
function rendered(rel: string): string {
|
|
return fs.readFileSync(path.join(ROOT, rel), 'utf-8');
|
|
}
|
|
|
|
describe('content-binding template drift', () => {
|
|
test('ship Step 16 carries the evidence check (mechanized IRON LAW)', () => {
|
|
const ship = rendered('ship/SKILL.md');
|
|
expect(ship).toMatch(/gstack-evidence check --label tests --expect-cmd '[^']+' --label vitest --expect-cmd '[^']+' --max-age 24 --allow-paths CHANGELOG\.md,VERSION,package\.json/);
|
|
expect(ship).toContain('a failed CHECK never blocks');
|
|
});
|
|
|
|
test('ship Step 5 lanes run wrapped with per-lane labels', () => {
|
|
const tests = rendered('ship/sections/tests.md');
|
|
expect(tests).toContain('gstack-evidence run --label tests');
|
|
expect(tests).toContain('gstack-evidence run --label vitest');
|
|
});
|
|
|
|
test('land-and-deploy grades staleness content-first (wtree rule) and checks evidence', () => {
|
|
const land = rendered('land-and-deploy/SKILL.md');
|
|
expect(land).toContain('wtree');
|
|
expect(land).toContain('---WTREE---');
|
|
expect(land).toMatch(/gstack-evidence check --label tests --expect-cmd '[^']+' --max-age 24/);
|
|
expect(land).toContain('UNKNOWN');
|
|
});
|
|
|
|
test('the review dashboard staleness rule is wtree-first for diff-scoped rows', () => {
|
|
// The dashboard text is generated into every skill that embeds
|
|
// {{REVIEW_DASHBOARD}}; ship is the canonical carrier.
|
|
const ship = rendered('ship/SKILL.md');
|
|
expect(ship).toContain('---WTREE---');
|
|
expect(ship).toContain('diff-scoped rows only');
|
|
expect(ship).toContain('grade UNKNOWN and treat as stale');
|
|
});
|
|
|
|
test('the diff-scoped row list is IDENTICAL in both grading surfaces (no drift)', () => {
|
|
// The resolver (dashboard) and land-and-deploy each carry the row list;
|
|
// they diverged once (codex-review present in one, missing in the other).
|
|
// Rendered dashboards escape backticks (template-literal origin), so match
|
|
// structurally: the three row names in order inside the rule sentence.
|
|
const rowList = /diff-scoped rows only:[\s\S]{0,80}?adversarial-review[\s\S]{0,80}?codex-review[\s\S]{0,80}?ship-stage entries/;
|
|
expect(rendered('ship/SKILL.md')).toMatch(rowList);
|
|
expect(rendered('land-and-deploy/SKILL.md')).toMatch(rowList);
|
|
});
|
|
|
|
test('release-body write side carries the banner tripwire (and it actually fires)', () => {
|
|
const body = rendered('document-release/sections/release-body.md');
|
|
expect(body).toContain('grep -c "UNTRUSTED TRACKER CONTENT" /tmp/gstack-pr-body-$$.md');
|
|
expect(body).toContain('grep -c "UNTRUSTED TRACKER CONTENT" /tmp/gstack-pr-body-orig-$$.md');
|
|
// The fail-open shape: grep -c prints 0 AND exits 1 on no-match, so an
|
|
// `|| echo 0` double-emits and breaks the -gt into the clean branch.
|
|
expect(body).not.toContain('|| echo 0');
|
|
expect(body).toContain('banner tripwire clean');
|
|
|
|
// Functional: execute the template's tripwire block against a 0-banner
|
|
// original and a 1-banner outgoing body — the ABORT branch must fire.
|
|
//
|
|
// Pass the script as an ARGV element (spawnSync array form), never by
|
|
// interpolating JSON.stringify into a shell line: JSON escaping is not
|
|
// shell escaping. Inside shell double quotes a JSON "\n" stays a literal
|
|
// backslash-n, which collapsed this multi-line script onto one line where
|
|
// `then\n` became the command word `thenn` and `>&2\nelse\n` became the
|
|
// redirect `>&2nelsen` — silently littering a `2nelsen` file (containing
|
|
// "bash: thenn: command not found") in the repo root on every suite run,
|
|
// while the old not-contains assertion passed vacuously because ALL
|
|
// output had been redirected into that file.
|
|
const block = body.match(/_ORIG_BANNERS=\$\(grep[\s\S]*?fi\n/);
|
|
expect(block).not.toBeNull();
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const path = require('path');
|
|
const { spawnSync } = require('child_process');
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-banner-'));
|
|
try {
|
|
const scriptFor = (origContent: string, newContent: string) => {
|
|
fs.writeFileSync(path.join(dir, 'orig.md'), origContent);
|
|
fs.writeFileSync(path.join(dir, 'new.md'), newContent);
|
|
return block![0]
|
|
.replaceAll('/tmp/gstack-pr-body-orig-$$.md', path.join(dir, 'orig.md'))
|
|
.replaceAll('/tmp/gstack-pr-body-$$.md', path.join(dir, 'new.md'));
|
|
};
|
|
|
|
// Banner leaked into the outgoing body → the ABORT branch fires, loudly.
|
|
const abort = spawnSync('bash', ['-c', scriptFor(
|
|
'clean body\n',
|
|
'body with UNTRUSTED TRACKER CONTENT banner leak\n',
|
|
)], { encoding: 'utf-8' });
|
|
expect(abort.stderr).toContain('ABORT: envelope banner leaked');
|
|
expect(abort.stdout).not.toContain('banner tripwire clean');
|
|
|
|
// No banner delta → the clean branch fires.
|
|
const clean = spawnSync('bash', ['-c', scriptFor(
|
|
'clean body\n',
|
|
'also clean body\n',
|
|
)], { encoding: 'utf-8' });
|
|
expect(clean.stdout).toContain('banner tripwire clean');
|
|
expect(clean.stderr).not.toContain('ABORT');
|
|
} finally {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('greptile triage reads bodies through the guard (metadata/body split)', () => {
|
|
const triage = rendered('review/greptile-triage.md');
|
|
expect(triage).toContain('gstack-issue-guard --stdin --source greptile-line');
|
|
expect(triage).toContain('gstack-issue-guard --stdin --source greptile-replies');
|
|
});
|
|
});
|