mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-02 11:45:20 +02:00
8ddfab233d
* refactor: host-aware gen-skill-docs + --host codex generation Refactor gen-skill-docs.ts for multi-agent support: - Add Host type, HostPaths interface, HOST_PATHS config - Decompose generatePreamble() into 7 composable sub-functions - Replace all hardcoded .claude/skills/gstack paths with ctx.paths - Replace static findTemplates() list with dynamic filesystem scan - Add --host codex|agents flag (aliases, same output) - Add processTemplate host routing to .agents/skills/gstack-*/ - Add codexSkillName() with double-prefix prevention - Add transformFrontmatter() — keeps only name + description for Codex - Add extractHookSafetyProse() — converts hooks to inline advisory - Add body text path rewriting for remaining hardcoded paths - Exclude /codex skill from Codex generation (self-referential) Claude output is unchanged (verified via --dry-run). SKILL.md is an open standard: .agents/skills/ works on Codex, Gemini CLI, and Cursor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: generate Codex/Gemini/Cursor skills into .agents/skills/ Generated 21 skill files for the open SKILL.md standard: - Output: .agents/skills/gstack-*/SKILL.md (one per skill) - Frontmatter: name + description only (no allowed-tools/version) - No .claude/skills/ paths in any generated file - /codex skill excluded (Claude wrapper, self-referential on Codex) - Hook skills (careful/freeze/guard) get inline safety prose - Build script generates both hosts: bun run build Supported agents (all read .agents/skills/): - Codex CLI - Gemini CLI - Cursor Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: dual-host setup + find-browse for Codex/Gemini/Cursor - setup: add --host codex|claude|auto flag, install to ~/.codex/skills/ when targeting Codex, auto-detect installed agents - find-browse: priority chain .codex > .agents > .claude (both workspace-local and global) - dev-setup/teardown: create .agents/skills/gstack symlinks for dev mode Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: Codex generation tests + CI + docs for multi-agent support Tests (28 new): - Codex output path routing, frontmatter validation (name+description only) - No .claude/skills/ path leaks in Codex output (regression guard) - /codex skill exclusion, hook→prose conversion, multiline YAML - --host agents alias, dynamic template discovery - Codex skill validation + $B command validation - find-browse priority chain verification - Replace static ALL_SKILLS list with dynamic filesystem scan CI: - Add Codex freshness check to skill-docs workflow Docs: - AGENTS.md: Codex-facing project instructions - README: multi-agent installation section - CONTRIBUTING: dual-host development workflow - CHANGELOG: v0.9.0 multi-agent support entry Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Codex E2E test harness — verify skills work on Codex CLI New test infrastructure: - CodexSessionRunner: spawns codex exec, parses JSONL stream, returns structured results (output, reasoning, toolCalls, tokens) - JSONL parser ported from Python (codex/SKILL.md.tmpl) to TypeScript - Temp HOME skill installation for Codex discovery testing E2E tests (gated behind EVALS=1 + codex + OPENAI_API_KEY): - codex-discover-skill: installs skill, verifies Codex finds it - codex-review-findings: runs gstack-review via Codex, validates output Integrates with existing eval infrastructure: - Diff-based test selection via touchfiles - Eval persistence via EvalCollector - bun run test:codex / test:codex:all convenience scripts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: bump VERSION to 0.9.0 to match CHANGELOG Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: Codex sidecar paths + setup installs generated skills Two bugs found by Codex adversarial review: 1. Sidecar path mismatch: generated Codex skills referenced .agents/skills/gstack-review/checklist.md but setup creates sidecars at .agents/skills/gstack/review/. Fixed path rewriter to emit .agents/skills/gstack/review/ (matching setup layout). 2. Setup installed Claude-format source dirs for Codex global install instead of the generated Codex-format skills. Split link_skill_dirs into link_claude_skill_dirs (source dirs for Claude) and link_codex_skill_dirs (generated .agents/skills/ gstack-* dirs for Codex). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: comprehensive Codex path rewriting + setup install tests 17 new tests covering: - Sidecar path rewriting: .claude/skills/review → .agents/skills/gstack/review/ (catches the bug where checklist.md was unreachable at gstack-review/) - All 4 path rewrite rules tested individually across all skills - Greptile triage sidecar path correctness - Ship skill sidecar paths for pre-landing review - Claude output regression guard: zero Codex paths in any Claude skill - Setup script validation: separate link functions for Claude vs Codex, link_codex_skill_dirs reads from .agents/skills/, create_agents_sidecar links runtime assets (bin, browse, review, qa) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: regenerate Codex skills after investigate rename merge Remove stale gstack-debug, add gstack-investigate, regenerate all Codex skills to pick up changes merged from main (investigate rename, platform-agnostic templates, review helpers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: Codex E2E uses ~/.codex/ auth, not OPENAI_API_KEY - Remove OPENAI_API_KEY gate from test prerequisites - Copy real ~/.codex/ auth config into temp HOME so codex can authenticate - Increase review test timeout to 540s (codex does thorough 60+ tool call reviews) - Document in CLAUDE.md that Codex uses its own auth config Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
163 lines
5.7 KiB
TypeScript
163 lines
5.7 KiB
TypeScript
#!/usr/bin/env bun
|
|
/**
|
|
* skill:check — Health summary for all SKILL.md files.
|
|
*
|
|
* Reports:
|
|
* - Command validation (valid/invalid/snapshot errors)
|
|
* - Template coverage (which SKILL.md files have .tmpl sources)
|
|
* - Freshness check (generated files match committed files)
|
|
*/
|
|
|
|
import { validateSkill } from '../test/helpers/skill-parser';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { execSync } from 'child_process';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
// Find all SKILL.md files
|
|
const SKILL_FILES = [
|
|
'SKILL.md',
|
|
'browse/SKILL.md',
|
|
'qa/SKILL.md',
|
|
'qa-only/SKILL.md',
|
|
'ship/SKILL.md',
|
|
'review/SKILL.md',
|
|
'retro/SKILL.md',
|
|
'plan-ceo-review/SKILL.md',
|
|
'plan-eng-review/SKILL.md',
|
|
'setup-browser-cookies/SKILL.md',
|
|
'plan-design-review/SKILL.md',
|
|
'design-review/SKILL.md',
|
|
'gstack-upgrade/SKILL.md',
|
|
'document-release/SKILL.md',
|
|
].filter(f => fs.existsSync(path.join(ROOT, f)));
|
|
|
|
let hasErrors = false;
|
|
|
|
// ─── Skills ─────────────────────────────────────────────────
|
|
|
|
console.log(' Skills:');
|
|
for (const file of SKILL_FILES) {
|
|
const fullPath = path.join(ROOT, file);
|
|
const result = validateSkill(fullPath);
|
|
|
|
if (result.warnings.length > 0) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — ${result.warnings.join(', ')}`);
|
|
continue;
|
|
}
|
|
|
|
const totalValid = result.valid.length;
|
|
const totalInvalid = result.invalid.length;
|
|
const totalSnapErrors = result.snapshotFlagErrors.length;
|
|
|
|
if (totalInvalid > 0 || totalSnapErrors > 0) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${file.padEnd(30)} — ${totalValid} valid, ${totalInvalid} invalid, ${totalSnapErrors} snapshot errors`);
|
|
for (const inv of result.invalid) {
|
|
console.log(` line ${inv.line}: unknown command '${inv.command}'`);
|
|
}
|
|
for (const se of result.snapshotFlagErrors) {
|
|
console.log(` line ${se.command.line}: ${se.error}`);
|
|
}
|
|
} else {
|
|
console.log(` \u2705 ${file.padEnd(30)} — ${totalValid} commands, all valid`);
|
|
}
|
|
}
|
|
|
|
// ─── Templates ──────────────────────────────────────────────
|
|
|
|
console.log('\n Templates:');
|
|
const TEMPLATES = [
|
|
{ tmpl: 'SKILL.md.tmpl', output: 'SKILL.md' },
|
|
{ tmpl: 'browse/SKILL.md.tmpl', output: 'browse/SKILL.md' },
|
|
];
|
|
|
|
for (const { tmpl, output } of TEMPLATES) {
|
|
const tmplPath = path.join(ROOT, tmpl);
|
|
const outPath = path.join(ROOT, output);
|
|
if (!fs.existsSync(tmplPath)) {
|
|
console.log(` \u26a0\ufe0f ${output.padEnd(30)} — no template`);
|
|
continue;
|
|
}
|
|
if (!fs.existsSync(outPath)) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${output.padEnd(30)} — generated file missing! Run: bun run gen:skill-docs`);
|
|
continue;
|
|
}
|
|
console.log(` \u2705 ${tmpl.padEnd(30)} \u2192 ${output}`);
|
|
}
|
|
|
|
// Skills without templates
|
|
for (const file of SKILL_FILES) {
|
|
const tmplPath = path.join(ROOT, file + '.tmpl');
|
|
if (!fs.existsSync(tmplPath) && !TEMPLATES.some(t => t.output === file)) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — no template (OK if no $B commands)`);
|
|
}
|
|
}
|
|
|
|
// ─── Codex Skills ───────────────────────────────────────────
|
|
|
|
const AGENTS_DIR = path.join(ROOT, '.agents', 'skills');
|
|
if (fs.existsSync(AGENTS_DIR)) {
|
|
console.log('\n Codex Skills (.agents/skills/):');
|
|
const codexDirs = fs.readdirSync(AGENTS_DIR).sort();
|
|
let codexCount = 0;
|
|
let codexMissing = 0;
|
|
for (const dir of codexDirs) {
|
|
const skillMd = path.join(AGENTS_DIR, dir, 'SKILL.md');
|
|
if (fs.existsSync(skillMd)) {
|
|
codexCount++;
|
|
const content = fs.readFileSync(skillMd, 'utf-8');
|
|
// Quick validation: must have frontmatter with name + description only
|
|
const hasClaude = content.includes('.claude/skills');
|
|
if (hasClaude) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — contains .claude/skills reference`);
|
|
} else {
|
|
console.log(` \u2705 ${dir.padEnd(30)} — OK`);
|
|
}
|
|
} else {
|
|
codexMissing++;
|
|
hasErrors = true;
|
|
console.log(` \u274c ${dir.padEnd(30)} — SKILL.md missing`);
|
|
}
|
|
}
|
|
console.log(` Total: ${codexCount} skills, ${codexMissing} missing`);
|
|
} else {
|
|
console.log('\n Codex Skills: .agents/skills/ not found (run: bun run gen:skill-docs --host codex)');
|
|
}
|
|
|
|
// ─── Freshness ──────────────────────────────────────────────
|
|
|
|
console.log('\n Freshness (Claude):');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All Claude generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Claude generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs');
|
|
}
|
|
|
|
console.log('\n Freshness (Codex):');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --host codex --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All Codex generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Codex generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs --host codex');
|
|
}
|
|
|
|
console.log('');
|
|
process.exit(hasErrors ? 1 : 0);
|