Garry Tan
0f6227ecde
fix(codex): move diff scope into prompt instead of --base (Codex CLI 0.130+ argv conflict) ( #1209 )
...
Codex CLI ≥ 0.130.0 rejects passing a custom prompt and --base together
(mutually exclusive at argv level). Every /codex review, /review, and
/ship structured Codex review call ended with an argv error before the
model ran.
Fix: scope the diff in prompt text using
"Run git diff origin/<base>...HEAD 2>/dev/null || git diff <base>...HEAD"
instead of `--base <base>`. Preserves the filesystem boundary
instruction across all invocations and keeps Codex's review prompt
tuning.
Touches:
- codex/SKILL.md.tmpl + regenerated codex/SKILL.md
- scripts/resolvers/review.ts + regenerated review/SKILL.md, ship/SKILL.md
- test/gen-skill-docs.test.ts: new regression that fails if any of the
five known files still contain the prompt+--base shape
- test/skill-validation.test.ts: corresponding negative + positive pin
on the rendered SKILL.md files
Contributed by @jbetala7 via #1209 . Closes #1479 . Supersedes #1527
(@mvanhorn — same intent, different patch shape, CONFLICTING) and
#1449 (@Gujiassh — broader refactor, CONFLICTING). Credit retained
in CHANGELOG.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-18 21:06:22 -07:00
..
2026-05-15 08:13:20 -07:00
2026-05-16 12:32:33 -07:00
2026-04-24 00:04:53 -07:00
2026-03-18 23:57:59 -05:00
2026-05-17 08:26:36 -07:00
2026-04-19 17:50:31 +08:00
2026-04-19 17:50:31 +08:00
2026-04-19 17:50:31 +08:00
2026-05-06 19:37:53 -07:00
2026-05-17 08:26:36 -07:00
2026-05-18 20:59:34 -07:00
2026-04-08 22:21:28 -10:00
2026-04-23 07:25:20 -07:00
2026-03-23 23:05:22 -07:00
2026-05-14 11:11:52 -04:00
2026-05-09 08:06:47 -07:00
2026-05-16 12:32:33 -07:00
2026-04-19 08:38:19 +08:00
2026-03-30 22:07:50 -06:00
2026-05-14 21:19:58 -07:00
2026-04-26 13:55:13 -07:00
2026-04-18 15:05:42 +08:00
2026-04-24 01:38:21 -07:00
2026-05-14 17:20:48 -07:00
2026-05-17 08:26:36 -07:00
2026-05-14 17:20:48 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-05-04 09:29:48 -07:00
2026-04-24 01:38:21 -07:00
2026-05-14 17:20:48 -07:00
2026-04-16 10:41:38 -07:00
2026-05-18 21:06:22 -07:00
2026-04-05 02:02:06 -07:00
2026-05-14 11:11:52 -04:00
2026-05-06 19:37:53 -07:00
2026-05-18 20:34:05 -07:00
2026-04-18 15:05:42 +08:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-04-28 01:17:54 -07:00
2026-05-18 20:32:37 -07:00
2026-05-11 19:34:33 -07:00
2026-05-18 20:36:12 -07:00
2026-05-17 08:26:36 -07:00
2026-05-14 17:20:48 -07:00
2026-05-18 20:31:32 -07:00
2026-04-18 15:05:42 +08:00
2026-04-18 15:05:42 +08:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-04-26 13:55:13 -07:00
2026-05-10 06:57:24 -07:00
2026-04-17 00:45:13 -07:00
2026-04-18 15:05:42 +08:00
2026-04-06 00:47:04 -07:00
2026-05-14 11:11:52 -04:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-05-18 20:38:03 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-04-25 11:52:48 -07:00
2026-05-14 21:19:58 -07:00
2026-04-17 00:45:13 -07:00
2026-04-18 15:05:42 +08:00
2026-05-06 19:37:53 -07:00
2026-05-01 07:06:37 -07:00
2026-04-23 18:25:34 -07:00
2026-04-18 15:05:42 +08:00
2026-04-16 15:39:44 -07:00
2026-04-23 18:25:34 -07:00
2026-05-18 20:42:29 -07:00
2026-03-26 23:21:27 -06:00
2026-04-24 01:38:21 -07:00
2026-04-18 12:30:54 +08:00
2026-05-14 21:19:58 -07:00
2026-05-06 19:37:53 -07:00
2026-05-14 21:19:58 -07:00
2026-05-09 08:06:47 -07:00
2026-04-18 23:58:59 +08:00
2026-04-26 13:55:13 -07:00
2026-04-19 08:38:19 +08:00
2026-05-01 19:51:51 -07:00
2026-05-11 12:16:26 -07:00
2026-05-01 08:45:36 -07:00
2026-04-26 13:55:13 -07:00
2026-04-19 08:38:19 +08:00
2026-05-11 12:16:26 -07:00
2026-05-06 19:37:53 -07:00
2026-04-23 17:54:54 -07:00
2026-04-19 08:38:19 +08:00
2026-03-23 06:57:22 -07:00
2026-03-26 11:08:31 -07:00
2026-05-11 12:16:26 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-05-01 08:45:36 -07:00
2026-05-01 19:51:51 -07:00
2026-04-19 05:44:39 +08:00
2026-04-22 01:06:22 -07:00
2026-04-23 18:42:58 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-04-30 02:50:09 -07:00
2026-05-09 17:01:13 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-11 12:16:26 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-03 20:26:59 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-09 17:01:13 -07:00
2026-05-01 19:51:51 -07:00
2026-04-26 13:55:13 -07:00
2026-04-23 18:25:34 -07:00
2026-04-18 15:05:42 +08:00
2026-05-11 12:16:26 -07:00
2026-05-11 12:16:26 -07:00
2026-03-23 10:17:33 -07:00
2026-03-30 22:07:50 -06:00
2026-05-11 12:16:26 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-04-26 13:55:13 -07:00
2026-04-04 15:32:20 -07:00
2026-05-11 12:16:26 -07:00
2026-05-11 12:16:26 -07:00
2026-03-31 23:08:22 -06:00
2026-03-26 17:31:53 -06:00
2026-03-13 21:08:12 -07:00
2026-04-16 10:41:38 -07:00
2026-05-18 21:06:22 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-03-29 21:43:36 -06:00
2026-05-01 07:21:28 -07:00
2026-04-01 00:50:42 -06:00
2026-05-09 17:01:13 -07:00
2026-03-27 00:44:37 -06:00
2026-04-18 15:05:42 +08:00
2026-04-18 15:05:42 +08:00
2026-04-06 14:41:06 -07:00
2026-04-26 13:55:13 -07:00