mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 22:14:25 +01:00
* feat(design-html): craft section and free craft check, adapted from Elaya design skills (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(GSTA-92): restore the full CHANGELOG under the Unreleased entry; drop a $-digit literal from craft.md; count only craft-check executions in design-html-slop-gate Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * feat(design-shotgun,design-html): carry the chosen archetype into approved.json; persist accepted craft exceptions in finalized.json (GSTA-92 phase 2) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * feat(design-review,plan-design-review): craft audit carved on every host, Persuade plan checks, craft tells as catalog entries (GSTA-92 phase 2) Size pins and caps raised to measured sizes only: design-review (13 hosts), plan-design-review (12), design-consultation (9), design-consultation maxSizeRatio, and the new design-review parity guard. Garry 2026-10-25 "Do it" (GSTA-92). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * refactor(design-catalog): craft tells are checker-only entries; trim design-review and plan-design-review growth to the planned size (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(touchfiles): design-html-slop-gate selects on the craft check it runs (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(touchfiles): design-review and plan-design-review cases select on the craft resolver; slop gate on the catalog (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(placeholders): allow the craft audit page path placeholder (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (GSTA-92) A malformed or missing --accepted exceptions file now gets the full craft check with nothing accepted, after a warning, still exiting 2. Before, it printed nothing, and the craft section treats a missing CRAFT_RESULT as 'check unavailable', so one bad finalized.json switched the gate off (found by both adversarial passes). The header comment and the craft section now document the accepted-count suffix on CRAFT_RESULT. Tests cover duplicate carried-forward exception ids and the slop-gate touchfiles selection. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: scope --accepted to the same page; record current counts (GSTA-92) The craft section passed --accepted whenever a finalized.json sat beside the page, so a same-day Start fresh build inherited the old page's exceptions. It now passes them only when evolving or rerunning a page it finalized, records the count the check reports now, and writes [] when nothing was accepted instead of the template's placeholder entry. A test pins exit 2 for a clean page with a broken exceptions file. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: note the archetype handoff in the shotgun and design-html loops (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: craft audit capture, exceptions and trigger from /ship review (GSTA-92) - craft-audit: no CRAFT_RESULT line means unavailable (exit 2 after a malformed --accepted record still printed findings); --accepted only for a /design-html finalized page, never for needs-proof or lorem; never add [Needs proof] markers to a live page; Aside capture via pg.evaluate; the saved raw DOM is deleted in the checking block and never reported - manifest trigger covers an explicit craft audit (skeleton -6 bytes; pins lowered to measured size, union ratio back under its cap) - autoFixEntries reads RENDERED; DESIGN_CRAFT_RULE needs exactly one lead - tests: checkerOnly contract, resolver throw paths, Persuade checks in both skills, resolver touchfile selection, exception state cells - CHANGELOG: host counts and the audit's new rules Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: craft audit live-page limits, claim handling and guards (GSTA-92) - craft-audit: linked CSS/JS is unchecked on a saved page (judge by eye); a mount-node shell is framework source; --accepted takes that screen's finalized.json or none; on a live page a claim without proof is filed and asked about, never marked or cut; the saved page is removed whatever the exit code; shorter fix-order and Tailwind prose keeps the union under cap - tests: exact-lead red cases, autoFixEntries in the checkerOnly union, the audit's outcome/exception/session-data clauses; carve guard checks the session-data rule and records measured sizes (skeleton cap 137_767) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: craft check skips mount-node shells and script bodies; audit capture order (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * revert: craft checker back to bed645a's reviewed behavior; textless mount-node shell judged by eye (GSTA-92) cycle-cap exception (GSTA-92 lane, 2026-10-25): reverted 216987e's checker half to bed645a's reviewed behavior; byte-neutral prose reword; no new logic Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: craft audit judges any mount-node shell by eye; pin the clause (GSTA-92) second cycle-cap exception: GStack Minder's decision under Garry's 'do it' on phase 2 (GSTA-92, 2026-10-25): one deleted word plus one test Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: craft resolver placeholders, carved-on-every-host list, design-craft resolver (GSTA-92 /ship docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes after main merge: claim rule covers repo files, craft temp var, guard tests (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: craft audit files failed Persuade checks as deferred High, judges source tells by eye; stderr pin (GSTA-92) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(design-review): never cut a claim a rule or printed fix says to drop Pass R3 (native adversarial, Medium): the CRAFT_CHECK fix text for round-number and needs-proof says to drop or remove the claim, which could lead Phase 8 to delete a real claim. The audit sentence now covers both a rule and the printed fix: defer the claim and ask for the proof. Byte-neutral (80 -> 80); design-review/SKILL.md 137,767, union 145,037, unchanged. The test pin moves with the sentence; no carve-guard mustContain held this sentence. third cycle-cap exception (Captain, 2026-10-26): zero-byte reword closing the content-deletion path; test pin and carve-guard mustContain moved Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * design-craft: reconcile ids with the design lint (layout-transition is static-tier; legacy transition-all exceptions map to it) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
164 lines
7.9 KiB
TypeScript
164 lines
7.9 KiB
TypeScript
/**
|
|
* Section resolvers (v2 plan T9, Claude-first carve).
|
|
*
|
|
* A carved skill keeps its prose-heavy steps in `<skill>/sections/<id>.md`, read
|
|
* on demand. The SAME template ships to every host, so these resolvers make the
|
|
* carve host-aware:
|
|
*
|
|
* - On CLAUDE and for QA on every host: {{SECTION:id}} emits a STOP-Read pointer to the generated section
|
|
* file (the skeleton), and the section .md is generated + installed separately.
|
|
* - Other skills on external hosts: {{SECTION:id}} INLINES the section template's content,
|
|
* so external hosts keep the full monolith ship skill (no section files, no
|
|
* host-portable-path problem). Inlined content keeps its own {{RESOLVER}}
|
|
* tokens, which the generator's multi-pass resolve expands.
|
|
*
|
|
* {{SECTION_INDEX:skill}} renders the situation→section table from the PASSIVE
|
|
* manifest for lazy skills (empty for inlined skills). The manifest
|
|
* is the single source of id/file/title/trigger text (CM2; v2_PLAN.md:663).
|
|
*/
|
|
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import type { Host, ResolverFn, TemplateContext } from './types';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..', '..');
|
|
|
|
export const QA_ASSET_BLOCKER = 'If missing or unreadable, report a QA setup blocker and its affected probes as blocked; continue other safe probes (independent functional/static checks). Missing/unreadable assets block required QA.';
|
|
|
|
/** Skills carved on every host: QA (portable assets), those whose external
|
|
* render would exceed SKILL_BYTE_CEILING inlined (C4, #2777), and design-review,
|
|
* whose on-demand craft audit stays out of every skeleton (GSTA-92). */
|
|
const CARVED_ON_EVERY_HOST = ['qa', 'qa-only', 'ship', 'plan-ceo-review', 'office-hours', 'design-review'];
|
|
|
|
/** Hosts read at most this many UTF-8 bytes of one SKILL.md (~40K tokens). */
|
|
export const SKILL_BYTE_CEILING = 160_000;
|
|
|
|
export function usesLazySections(host: Host, skill: string): boolean {
|
|
return host === 'claude' || CARVED_ON_EVERY_HOST.includes(skill);
|
|
}
|
|
|
|
/**
|
|
* External hosts: a template's literal `~/.claude/skills/gstack/<skill>/sections/<file>`
|
|
* reference arrives here as `$GSTACK_ROOT/...` or `~/<globalRoot>/...`, and external
|
|
* runtime roots have no section trees. For a carved skill, point it at the installed copy;
|
|
* for this skill's own section inlined by {{SECTION}}, point at the inlined text.
|
|
*/
|
|
export function rewriteCarvedSectionRefs(content: string, ctx: TemplateContext): string {
|
|
if (ctx.host === 'claude') return content;
|
|
// The root arrives as $GSTACK_ROOT or as the host's literal ~/<globalRoot> (path rewrites).
|
|
return content.replace(/`(?:\$GSTACK_ROOT|~\/[\w./-]*?skills\/gstack)\/([a-z0-9-]+)\/sections\/([A-Za-z0-9._-]+)`/g, (match, skill: string, file: string) => {
|
|
if (!fs.existsSync(path.join(ROOT, skill, 'sections', `${file}.tmpl`))) return match;
|
|
if (usesLazySections(ctx.host, skill)) return `\`sections/${file}\` relative to the installed \`gstack-${skill}\` SKILL.md directory`;
|
|
const entry = loadManifest(skill).sections.find(e => e.file === file);
|
|
const inlined = skill === ctx.skillName && entry && fs.readFileSync(path.join(ROOT, skill, 'SKILL.md.tmpl'), 'utf-8').includes(`{{SECTION:${entry.id}}}`);
|
|
return inlined ? `the \`${file.replace(/\.md$/, '')}\` section inlined in this SKILL.md` : match;
|
|
});
|
|
}
|
|
|
|
interface SectionEntry {
|
|
id: string;
|
|
file: string;
|
|
title: string;
|
|
trigger: string;
|
|
/** Plan B4: read by bin/gstack-autoplan alone; interactive renders ignore it. Default `always`. */
|
|
scope?: 'always' | 'ui' | 'dx' | 'db' | 'perf' | 'security' | 'incident';
|
|
/** Plan B4: a runner-profile section (the checklist) stays out of the Section index. */
|
|
runner_only?: boolean;
|
|
}
|
|
interface SectionManifest {
|
|
skill: string;
|
|
sections: SectionEntry[];
|
|
}
|
|
|
|
function loadManifest(skill: string): SectionManifest {
|
|
const p = path.join(ROOT, skill, 'sections', 'manifest.json');
|
|
const raw = fs.readFileSync(p, 'utf-8');
|
|
return JSON.parse(raw) as SectionManifest;
|
|
}
|
|
|
|
function findSection(skill: string, id: string): SectionEntry {
|
|
const entry = loadManifest(skill).sections.find(s => s.id === id);
|
|
if (!entry) {
|
|
throw new Error(`{{SECTION:${id}}} — no section "${id}" in ${skill}/sections/manifest.json`);
|
|
}
|
|
return entry;
|
|
}
|
|
|
|
/**
|
|
* Pointer to a carved section file. Claude keeps its global-root path; QA and
|
|
* every external host point relative to the installed skill directory, because
|
|
* external runtime roots (`$GSTACK_ROOT`) carry no `<skill>/sections/` tree
|
|
* while setup links or copies whole skill directories.
|
|
*/
|
|
export function sectionPath(ctx: TemplateContext, skill: string, id: string): string {
|
|
const entry = findSection(skill, id);
|
|
if (ctx.host !== 'claude' || skill === 'qa' || skill === 'qa-only') {
|
|
fs.accessSync(path.join(ROOT, skill, 'sections', `${entry.file}.tmpl`), fs.constants.R_OK);
|
|
const installedName = ctx.host === 'claude' ? `\`${skill}\`/\`gstack-${skill}\`` : `\`${skill.startsWith('gstack-') ? skill : `gstack-${skill}`}\``;
|
|
return `\`sections/${entry.file}\` relative to the installed ${installedName} SKILL.md directory`;
|
|
}
|
|
return `\`${ctx.paths.skillRoot}/${skill}/sections/${entry.file}\``;
|
|
}
|
|
|
|
/**
|
|
* {{SECTION:id}} — installed-file pointer for QA; otherwise Claude pointers
|
|
* and external inline content retain their existing behavior.
|
|
*/
|
|
export const SECTION: ResolverFn = (ctx: TemplateContext, args?: string[]): string => {
|
|
const id = args?.[0];
|
|
if (!id) throw new Error('{{SECTION:id}} requires a section id');
|
|
const entry = findSection(ctx.skillName, id);
|
|
|
|
if (usesLazySections(ctx.host, ctx.skillName)) {
|
|
if (ctx.skillName === 'qa' || ctx.skillName === 'qa-only') {
|
|
return [
|
|
`> **STOP.** Before ${entry.trigger}, Read ${sectionPath(ctx, ctx.skillName, id)} in full and follow it.`,
|
|
'> Use this host\'s installed path, never the product working directory or another host\'s assets.',
|
|
`> ${QA_ASSET_BLOCKER}`,
|
|
].join('\n');
|
|
}
|
|
return [
|
|
`> **STOP.** Before ${entry.trigger}, Read ${sectionPath(ctx, ctx.skillName, id)} and execute it`,
|
|
`> in full. Do not work from memory — that section is the source of truth for this step.`,
|
|
].join('\n');
|
|
}
|
|
|
|
// Non-Claude hosts inline the section template content (monolith preserved).
|
|
// Inner {{RESOLVER}} tokens are expanded by the generator's multi-pass resolve.
|
|
const tmplPath = path.join(ROOT, ctx.skillName, 'sections', `${entry.file}.tmpl`);
|
|
return fs.readFileSync(tmplPath, 'utf-8').trimEnd();
|
|
};
|
|
|
|
/**
|
|
* {{SECTION_INDEX:skill}} — situation→section table from the passive manifest.
|
|
* Lazy skills only; an index would be noise for inlined skills.
|
|
*/
|
|
export const SECTION_INDEX: ResolverFn = (ctx: TemplateContext, args?: string[]): string => {
|
|
const skill = args?.[0] ?? ctx.skillName;
|
|
if (!usesLazySections(ctx.host, skill)) return '';
|
|
const manifest = loadManifest(skill);
|
|
const lines: string[] = [
|
|
'## Section index — Read each section when its situation applies',
|
|
'',
|
|
...(skill === 'qa' || skill === 'qa-only'
|
|
? ['Read sections in full when directed; do not work from memory.']
|
|
: ['This skill is a decision-tree skeleton. The steps below point to on-demand',
|
|
'sections. Read a section in full before doing its step; do not work from memory.']),
|
|
'',
|
|
'| When | Read this section |',
|
|
'|------|-------------------|',
|
|
];
|
|
for (const s of manifest.sections) {
|
|
if (s.runner_only) continue;
|
|
const reference = skill === 'qa' || skill === 'qa-only' ? sectionPath(ctx, skill, s.id) : `\`sections/${s.file}\``;
|
|
if (skill === 'review' && s.id === 'review-army') {
|
|
lines.push(`| Select surfaces and read QA methods | Inline in [Step 4](#step-4-critical-pass-core-review); setup and probes run in Step 4.7 |`);
|
|
}
|
|
lines.push(`| ${s.trigger} | ${reference} |`);
|
|
if (skill === 'ship' && s.id === 'review-army') {
|
|
lines.push(`| exploratory QA before Fix-First (Step 9.2.1) | Use the QA Read directive in ${reference} |`);
|
|
}
|
|
}
|
|
return lines.join('\n');
|
|
};
|