mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-02 23:14:33 +01:00
* feat(ship): version-less repos, docs-audit record and caps, the frozen-scope paid case, and the review-loop follow-ups Follow-up to the review-loop convergence PR: Step 12 and the CHANGELOG step skip cleanly in a repository with no version source (receipt version "none"); the receipt records the docs audit outcome and the owner exception (DOCS_AUDIT_BLOCKED without one) and a policy may declare doc caps (gstack-ship-receipt docs-caps); docs/unattended.md names the READY evidence and the cross-family outside voice; the ship-frozen-scope-convergence behaviour case runs the generated Step 9.4 under review_scope frozen through the real binaries; carry probes git >= 2.39 (RECEIPT_GIT_TOO_OLD); defer passes the repository to gh repo view positionally and names its search limit; late defers count without being passes; reviewers diff from RANGE_BASE on pass 2+; the cap check runs before edits; --review-fanout batches specialists by free slots; read --check-prose compares quoted counters with the receipt (RECEIPT_PROSE_MISMATCH); checklist rule ids prereg-with-results and test-keyboard-count-loop; gstack-coauthor-trailers. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repair the CI reds the retarget onto main surfaced (test-only) Seven test files, no product change. The pull_request run at2d73faddfailed 5 Linux shards and 4 Windows shards: - test/ship-frozen-scope-actor.test.ts imported only test code, so the test-of-test ratchet refused it; the first case now recomputes the loop summary with summarizeReviewLoop/reviewLoopLine from lib/review-scope and asserts the exact REVIEW_LOOP line. Its three cases replay the bash workflow through bash -c and the shebang bins, so they are POSIX-only. - test/codex-host.test.ts: the new gate case is Claude-specific (33 -> 34). - test/paid-retry-supervision.test.ts: the gate census fixture now carries a trial record for the one planned behavior-kind gate case, the way test/ci-paid-coordination.test.ts already does. - test/review-fix-range.test.ts asserted the pre-#3487 DIFF_BASE sentence; it now asserts the ${RANGE_BASE:-merge-base} clause that carries the same contract (every reviewer reads the range from pass 2 on). - test/gstack-coauthor-trailers.test.ts: the fixture sets its own git identity; a CI runner has none to auto-detect ("Committer identity unknown"). - test/review-scope-followups.test.ts and test/gstack-ship-receipt-docs.test.ts: the gh and old-git stand-ins are sh scripts on a colon-joined PATH, which CreateProcess cannot run, so those three cases skip on win32. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (pass 1) Twelve informational findings from the /ship pass-1 review, all below the blocking floor, fixed in place: - docs-caps reads docs.caps from origin/<base>'s policy (--base <ref>), never the branch's copy; an unavailable base policy refuses with POLICY_SOURCE_UNAVAILABLE instead of substituting DEFAULT_POLICY - receiptVersion returns "none" only when the stamp file is absent; other errors surface as undefined - checkReceiptProse groups counters by leaf key and uses word boundaries that cover hyphenated names, so shared leaf keys and hyphenated words no longer report RECEIPT_PROSE_MISMATCH - gstack-coauthor-trailers refuses a --range/--base starting with "-", prefixes origin/ when origin/<ref> resolves (slash-named branches), and passes --end-of-options to git log - REVIEW_SCOPE_KEY_VERSION and DOCS_CAPS_KEY_VERSION name the releases that first read their keys - the Step 11 late-defer row logs under skill review-late-defer so a tokenless review row never reads UNVERIFIED; summarizeReviewLoop counts both - the "already filed" literal is one constant shared by bin and renderer - receiptDocs (dead) removed - Step 14.5 clears .gstack/tmp/docs-audit.json on first entry - dispatched review prompts carry a literal diff-base sha (<diff-base>) instead of a shell variable the reviewer process never sees - the coauthor-trailers tests launch the bin through runScriptSync so the Windows lane can run them Tests extended for each change; SKILL.md, sections and goldens regenerated. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: cover the carry patch-id refusal (Step 7 coverage gap) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: derive the too-old review_scope minimum from the constant Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep co-author trailers in one trailer block gstack-coauthor-trailers --message appended the new Co-authored-by lines as a separate paragraph after existing trailers, so git interpret-trailers (and GitHub attribution) read only the last paragraph and the existing co-author lost credit. The new lines now join the existing trailer block; the test checks the result with git interpret-trailers --parse. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: let git place co-author trailers; name the docs key release gstack-coauthor-trailers --message now runs git interpret-trailers --in-place, so the appended lines join the existing trailer block whatever its shape (CRLF, comment lines, folded continuations) and the existing co-author keeps attribution; the interpret-trailers check in the test carries a timeout for the spawnSync tripwire. DOCS_CAPS_KEY_VERSION names the release after the newest CHANGELOG heading on main (1.91.258.0), and a test ties every unreleased policy key to that next release so a stamp elsewhere fails loudly. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: hold unreleased policy keys newer than any visible heading; pin trailer placement The CHANGELOG-heading test asked for the exact next release after the newest heading, which a depth-1 CI clone (no origin/main) computes from the branch alone, so it went red there. It now requires an unreleased key's version to be newer than every heading the checkout can see, which holds at depth 1, on the stamped train tree and on main; the ship-policy comment says who moves the constant when the stamp lands under another number. gstack-coauthor-trailers pins git interpret-trailers' placement on the command line (--no-divider so a --- body line is not a divider, --where end, --if-exists addIfDifferentNeighbor, trailer.separators=:, -- before the path) so a user's trailer.* config cannot replace or drop the existing co-author. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: describe the shipped contracts (Step 13 and 14.5) CHANGELOG [Unreleased]: docs-caps --base <base> reading origin/<base>'s policy, the review-late-defer row, the literal <diff-base> prompt rule, the coauthor-trailers placement and refusals, the policy key versions (review_scope 1.91.256.0 re-pin, docs.caps at the stamping release), the version-less conditions split between Step 12 and the receipt, and the carry refusal wording. docs/ship-policy.md, docs/review-policy.md and docs/unattended.md follow the code: docs-caps --base, the literal diff-base sha, the trailer block, the gstack-outside-voice run binding and the Step 11 row fields. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: scope the literal diff-base claim to the review-army prompts; name where the outside-voice cause lives Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): declare Step 14.5's own-tree commands to the fixture; exclude .gstack/tmp at the Entry The ship-docsync-completion and ship-docsync-current paid cases failed twice at775d9804: Step 14.5's continue path now runs gstack-ship-receipt docs-caps and writes .gstack/tmp/docs-audit.json, and the docsync fixture's closed interface declared neither, while its repository had no origin/main for docs-caps to read. The actor stopped correctly (blocked, no exception) and never reached the publication stand-in. - test/helpers/docsync-interface.ts: the three housekeeping commands (the shared exclude line, rm -f of the record, docs-caps --base main) and the record write are declared, byte for byte with the generated section; DOCS_AUDIT_RECORD_PATHS names what the kernel observer may see. - test/helpers/docsync-observer.ts: accepts exactly those commands and the record write; every neighbour (another base, --json, write --docs, another .gstack file) stays outside the interface. - test/helpers/docsync-fixture.ts: every scenario pushes main to the fixture remote, as Steps 0-14 would have. - ship/sections/documentation.md.tmpl: the Entry runs the shared .gstack/tmp exclude line before rm -f, so the record never surfaces as an untracked file when no earlier step added it; the caps paragraph tightened to hold the ship parity ratio at 1.7400. - test/docsync-command-grammar.test.ts: pins the literals against the generated section and the refusals around them. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): the receipt record is housekeeping for read-only audits and the fault cases too Pass 9's outside voice found two gaps in the fixture change (2524ec4): a read-only audit (ship-docsync-current) must still write .gstack/tmp/docs-audit.json, but docsToolFailures flagged every product write under readOnly before the record allowance; and the unseeded fault cases (missing-asset, legacy-completion) run the Entry too, so their kernel-write check saw .git/info/exclude as a forbidden write because only the lifecycle test named the housekeeping paths. - docsToolFailures: the record write is permitted under readOnly; the document and every other product file stay refused. - docsWriteFailures: DOCS_AUDIT_RECORD_PATHS are permitted for every caller, so the fault evaluator needs no per-scenario list; anything else under .git or .gstack stays forbidden. - test/docsync-command-grammar.test.ts pins both: the record under readOnly, the document refused there, the observed housekeeping paths accepted with an empty allowance and two neighbours refused. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(docsync): accept the cap gate's ~/.claude/skills/gstack form the section prints (pass 9 Red Team note) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(docsync): name the admitted composed line precisely (pass 9 maintainability note) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): install lib/ beside bin/ in the fixture so the declared cap gate can load (2524ec4rerun: module error, not a verdict) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(docsync): admit the Write tool's temp sibling of the receipt record (0230fc2rerun: both lifecycle cases red on it) The paid rerun at0230fc2cleared every earlier refusal and both cases then failed on one path: forbidden docs write: .gstack/tmp/docs-audit.json.tmp.<pid>.<12 hex>. Claude Code's Write and Edit tools land every file, new ones included, through that sibling plus fsync and rename, and the fixture's kernel observer proved such a landing for the document only (atomicTargets: [DOC_PATH]). The observer now treats the record's sibling as a transient file too, and docsWriteFailures admits it only as the cookie-paired MOVED_FROM source of a MOVED_TO on the record whose other events are create/modify/attrib/close_write and which is left in neither snapshot nor in changed. A lingering sibling, an unpaired move, a move onto another path or a sibling of the document moved onto the record stay forbidden (grammar test). A live check on this machine saw the second landing's create/modify/close_write/moved_from events admitted and a stray sibling refused. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
567 lines
40 KiB
TypeScript
567 lines
40 KiB
TypeScript
import { afterAll, beforeAll, expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as path from 'node:path';
|
|
import { spawnSync } from 'node:child_process';
|
|
import { DOC_PATH, fixtureDocs, gitAt, repoSnapshot } from './helpers/docsync-fixture';
|
|
import { docsCommandAllowed, docsCompletedRead, docsNativeInterface, docsSessionOptions, docsToolFailures, docsWriteFailures } from './helpers/docsync-observer';
|
|
import { parseNDJSON, type SkillTestResult } from './helpers/session-runner';
|
|
|
|
let fixture: ReturnType<typeof fixtureDocs>;
|
|
beforeAll(() => { fixture = fixtureDocs('updated'); });
|
|
afterAll(() => fixture?.clean());
|
|
|
|
function nativeResult(command: string, output = '', parent: string | null = null): SkillTestResult {
|
|
const parsed = parseNDJSON([
|
|
{ type: 'assistant', parent_tool_use_id: parent, message: { content: [
|
|
{ type: 'tool_use', id: 'docs-command', name: 'Bash', input: { command, timeout: 10000 } },
|
|
] } },
|
|
{ type: 'user', parent_tool_use_id: parent, message: { content: [
|
|
{ type: 'tool_result', tool_use_id: 'docs-command', content: output, is_error: false },
|
|
] }, tool_use_result: { stdout: output, stderr: '', interrupted: false, isImage: false } },
|
|
].map(event => JSON.stringify(event)));
|
|
expect(parsed.toolCalls).toHaveLength(1);
|
|
expect(parsed.toolCalls[0].output).toBe(output);
|
|
return { ...parsed, exitReason: 'success' } as SkillTestResult;
|
|
}
|
|
|
|
test.each([
|
|
'HEAD^{tree}', 'HEAD^{}', 'HEAD^{commit}', 'HEAD^{object}', 'v1^{tag}', 'HEAD:app.ts',
|
|
'HEAD~1^{tree}', 'HEAD^2', 'HEAD@{0}', '@{upstream}', '@{-1}', 'main...HEAD', 'HEAD^{/fixture}',
|
|
])('native docs validator accepts literal revision %s with or without quotes', revision => {
|
|
for (const argument of [revision, `'${revision}'`, `"${revision}"`]) {
|
|
const command = `git rev-parse ${argument}`;
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
expect(docsToolFailures(nativeResult(command), fixture, [], true)).toEqual([]);
|
|
}
|
|
});
|
|
|
|
test('captured parent tree read is accepted without granting the captured child remote probe', () => {
|
|
const tree = nativeResult('git rev-parse HEAD^{tree}', '68a16779dc746e381e618452afda1f50db105b1a');
|
|
expect(docsToolFailures(tree, fixture, [], true)).toEqual([]);
|
|
const remote = nativeResult('git remote get-url origin', '/q/gstack-paid-shard-Stnoi5/tmp/ds-yikDdP/remote.git', 'docs-dispatch');
|
|
remote.toolCalls.unshift({ tool: 'Agent', input: {
|
|
prompt: '`git remote get-url origin` from Step 0 is a Git read and is allowed; `gh`/`glab` are not.',
|
|
}, output: 'completed' });
|
|
expect(docsToolFailures(remote, fixture, [], true)).toEqual(['command outside declared docs observation interface']);
|
|
});
|
|
|
|
// Run 37166586458 slice 2 (dfaf154): the parent verified the prompt's claim that
|
|
// .qa-state/ is Git-excluded. check-ignore is a declared Git read; composition is not.
|
|
test('captured check-ignore read is declared, executes without changing the repository', () => {
|
|
const command = 'git check-ignore -v .qa-state';
|
|
expect(docsNativeInterface(fixture)).toContain('ls-tree, check-ignore, rev-parse');
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
const before = repoSnapshot(fixture.repo);
|
|
const result = spawnSync('bash', ['-c', command], { cwd: fixture.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain('.qa-state');
|
|
expect(docsToolFailures(nativeResult(command, result.stdout), fixture, [], true)).toEqual([]);
|
|
expect(repoSnapshot(fixture.repo)).toEqual(before);
|
|
for (const denied of ['git check-ignore -v .qa-state; git add .qa-state', 'git check-ignore -v .qa-state > out.txt']) {
|
|
expect(docsCommandAllowed(denied, fixture)).toBe(false);
|
|
}
|
|
});
|
|
|
|
// ci-37165022930 eval-slices-2 ship-docsync-store: the docs child listed tracked files with git ls-tree -r HEAD.
|
|
test('captured tracked-file listing is a declared read and leaves the repository unchanged', () => {
|
|
expect(docsNativeInterface(fixture)).toContain('ls-files, ls-tree, check-ignore');
|
|
const before = repoSnapshot(fixture.repo);
|
|
const command = 'git ls-tree -r HEAD';
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
const result = spawnSync('bash', ['-c', command], { cwd: fixture.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(result.status).toBe(0);
|
|
expect(docsToolFailures(nativeResult(command, result.stdout), fixture, [], true)).toEqual([]);
|
|
expect(repoSnapshot(fixture.repo)).toEqual(before);
|
|
for (const rejected of ['git ls-tree -r HEAD > tree.txt', 'git ls-tree -r HEAD | tee tree.txt', 'git -c core.pager=less ls-tree HEAD']) {
|
|
expect(docsCommandAllowed(rejected, fixture)).toBe(false);
|
|
}
|
|
});
|
|
|
|
test('permitted peel reads execute as single literal Bash arguments without changing the repository', () => {
|
|
const before = repoSnapshot(fixture.repo);
|
|
for (const revision of ['HEAD^{tree}', 'HEAD^{}', 'HEAD^{commit}', 'HEAD^{object}', 'HEAD@{0}']) {
|
|
for (const argument of [revision, `'${revision}'`, `"${revision}"`]) {
|
|
const command = `git rev-parse ${argument}`;
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
const result = spawnSync('bash', ['-c', command], { cwd: fixture.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout.trim()).toBe(gitAt(fixture.repo, 'rev-parse', revision));
|
|
expect(docsToolFailures(nativeResult(command, result.stdout), fixture, [], true)).toEqual([]);
|
|
}
|
|
}
|
|
expect(repoSnapshot(fixture.repo)).toEqual(before);
|
|
});
|
|
|
|
test.each([
|
|
'{ git rev-parse HEAD; }', 'git rev-parse HEAD^{tree,commit}', 'git rev-parse HEAD@{0..2}',
|
|
'git rev-parse HEAD^{tree}{,x}', 'git rev-parse HEAD^{tree', 'git rev-parse HEAD^{tree}}',
|
|
'git rev-parse {HEAD}', 'git rev-parse HEAD$(pwd)', 'git rev-parse "HEAD$(pwd)"',
|
|
'git rev-parse `pwd`', 'git rev-parse ${HEAD}', 'git rev-parse HEAD; git add app.ts',
|
|
'git rev-parse HEAD && git commit -m changed', 'git rev-parse HEAD | sh',
|
|
'git rev-parse HEAD > out.md', 'git rev-parse HEAD 2>/tmp/leak', 'git rev-parse HEAD < in.md',
|
|
'git rev-parse HEAD\ngit status', 'git rev-parse HEAD &', 'git rev-parse HEAD\\^{tree}',
|
|
'git rev-parse "HEAD^{tree}', "git rev-parse 'HEAD^{tree}", 'git rev-parse HEAD*',
|
|
'git status "unfinished', "git status 'unfinished", "git hash-object '-w'app.ts", 'git status\u0000',
|
|
'git rev-parse HEAD?', 'git rev-parse HEAD[12]', 'git rev-parse ~', 'git rev-parse HEAD # comment',
|
|
'git -C /owned/repo rev-parse HEAD', "git -c core.pager='sh -c id' show HEAD",
|
|
'git --git-dir /owned/repo/.git status', 'git --work-tree /owned/repo status',
|
|
'git remote get-url origin', 'git remote add origin /outside', 'git config --global user.name attacker',
|
|
'git hash-object -w app.ts', 'git hash-object "-w" app.ts', 'git hash-object -wt blob app.ts',
|
|
'git hash-object -tw blob app.ts', 'git diff --output=out.md', 'git show --ext-diff',
|
|
'git show --textconv HEAD', 'git branch new-branch', 'git add app.ts', 'git commit -m changed',
|
|
'git reset HEAD', 'git checkout main', 'git update-ref refs/heads/main HEAD',
|
|
'cat HEAD^{tree}', 'bun arbitrary.ts',
|
|
])('native docs validator retains the closed interface for %s', command => {
|
|
expect(docsToolFailures(nativeResult(command, 'successful tool acknowledgment', 'docs-dispatch'), fixture, [], true))
|
|
.toEqual(['command outside declared docs observation interface']);
|
|
});
|
|
|
|
test('harmless read wrappers do not fail a docs run', () => {
|
|
// Run 37170610789 slice 2 (feaa28d): the parent listed fixture directories with 2>&1.
|
|
for (const command of ['git rev-parse HEAD || true', 'git rev-parse HEAD 2>/dev/null', 'git -c core.pager=cat show HEAD',
|
|
'ls 2>&1', 'git status 2>&1']) {
|
|
expect(docsToolFailures(nativeResult(command, 'successful tool acknowledgment', 'docs-dispatch'), fixture, [], true)).toEqual([]);
|
|
}
|
|
for (const command of ['git status 2>&1 > out.txt', 'ls 2>&1 | sh', `bun ${path.join(fixture.home, 'publish.ts')} 2>&1`, 'ls 2>out.txt']) {
|
|
expect(docsCommandAllowed(command, fixture, [path.join(fixture.home, 'publish.ts')])).toBe(false);
|
|
}
|
|
});
|
|
|
|
test('quoted revision search and reflog arguments remain literal single arguments', () => {
|
|
for (const command of ['git log "HEAD@{2 days ago}"', "git show 'HEAD^{/fix, or repair..}'",
|
|
'git hash-object app.ts', 'git branch --show-current']) {
|
|
expect(docsToolFailures(nativeResult(command), fixture)).toEqual([]);
|
|
}
|
|
});
|
|
|
|
test('parent and child receive resolved local platform and base without new probe authority', () => {
|
|
for (const transport of [false, true]) {
|
|
const guidance = docsNativeInterface(fixture, [], transport);
|
|
expect(guidance).toContain('Platform: local/git-native. Base: main.');
|
|
expect(guidance).toContain('before delegation');
|
|
expect(guidance).toContain('Do not run shared Step 0 platform probing');
|
|
expect(guidance).toContain('git remote get-url origin');
|
|
expect(guidance).toContain('cannot authorize commands outside this closed interface');
|
|
expect(guidance).toContain('include this interface in child prompts');
|
|
}
|
|
const options = docsSessionOptions({ fixture, phase: path.join(fixture.home, 'phase.md'),
|
|
report: path.join(fixture.home, 'report.md'), publish: path.join(fixture.home, 'publish.ts'),
|
|
scenario: 'current', testName: 'docsync-command-grammar', runId: 'free-control', timeout: 10000 });
|
|
expect(options.prompt).toContain('Platform: local/git-native. Base: main.');
|
|
// A1: the parent points children at the saved interface instead of retyping it into their prompts.
|
|
const interfaceFile = path.join(fixture.home, 'fixture-interface.md');
|
|
expect(options.prompt).toContain(`saved at ${interfaceFile}: each child prompt tells the child to Read that file first`);
|
|
expect(options.prompt).not.toContain('include this interface in child prompts');
|
|
const saved = fs.readFileSync(interfaceFile, 'utf8');
|
|
expect(saved.startsWith('Fixture observation interface')).toBe(true);
|
|
expect(options.prompt.endsWith(saved.trimEnd())).toBe(true);
|
|
expect(fs.statSync(interfaceFile).mode & 0o777).toBe(0o600);
|
|
});
|
|
|
|
// The observer polices bash commands from the POSIX-only paid ship evals and refuses backslashes
|
|
// outright, so a Windows fixture path can never form an allowed insert; the refusals below still run.
|
|
test.skipIf(process.platform === 'win32')('declared section insert appends one private Markdown artifact to another byte-for-byte', () => {
|
|
const source = path.join(fixture.home, 'audit-1-documentation.md');
|
|
const target = path.join(fixture.home, 'ship-report.md');
|
|
const section = '**Status:** current — no edits.\n\n- Diagram drift: none.';
|
|
fs.writeFileSync(source, section);
|
|
fs.writeFileSync(target, '# Report\n\n## Documentation\n\n');
|
|
const before = repoSnapshot(fixture.repo);
|
|
for (const command of [`cat ${source} >> ${target}`, `cat '${source}' >> '${target}'`, `cat "${source}" >> "${target}"`]) {
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
expect(docsToolFailures(nativeResult(command), fixture, [], true)).toEqual([]);
|
|
}
|
|
const result = spawnSync('bash', ['-c', `cat ${source} >> ${target}`], { cwd: fixture.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(result.status).toBe(0);
|
|
expect(fs.readFileSync(target, 'utf8')).toBe(`# Report\n\n## Documentation\n\n${section}`);
|
|
expect(repoSnapshot(fixture.repo)).toEqual(before);
|
|
});
|
|
|
|
test('section insert grants no write or source outside private fixture Markdown', () => {
|
|
const home = fixture.home;
|
|
const source = path.join(home, 'audit-1-documentation.md');
|
|
const target = path.join(home, 'ship-report.md');
|
|
fs.writeFileSync(source, 'section');
|
|
const link = path.join(home, 'linked-report.md');
|
|
fs.rmSync(link, { force: true });
|
|
fs.symlinkSync(path.join(fixture.repo, 'README.md'), link);
|
|
for (const command of [
|
|
`cat ${source} > ${target}`, `cat ${source} >> ${path.join(fixture.repo, 'README.md')}`,
|
|
`cat ${path.join(fixture.repo, 'README.md')} >> ${target}`, `cat ${source} >> ${link}`,
|
|
`cat ${source} >> ${path.join(home, 'report.txt')}`, `cat ${source} >> ${path.join(home, 'publication.json')}`,
|
|
`cat ${source} >> ${path.join(fixture.skills, 'ship/SKILL.md')}`, `cat ${source} >> ship-report.md`,
|
|
`cat ${source} ${source} >> ${target}`, `cat ${source} >> ${target}; ls`, `cat ${source} 2>> ${target}`,
|
|
`cat ${source} >> ${target} >> ${target}`, `cat ${path.join(home, '*.md')} >> ${target}`,
|
|
`cat ${path.join(home, '$x.md')} >> ${target}`, `cat ${source} >> ${path.join(home, '..', 'outside.md')}`, `cat ${source} >> ${home}/../outside.md`,
|
|
]) {
|
|
expect(docsCommandAllowed(command, fixture)).toBe(false);
|
|
expect(docsToolFailures(nativeResult(command), fixture, [], true)).toEqual(['command outside declared docs observation interface']);
|
|
}
|
|
});
|
|
|
|
test('only the native ship parent interface declares the section insert', () => {
|
|
const options = docsSessionOptions({ fixture, phase: path.join(fixture.home, 'phase.md'),
|
|
report: path.join(fixture.home, 'report.md'), publish: path.join(fixture.home, 'publish.ts'),
|
|
scenario: 'current', testName: 'docsync-command-grammar', runId: 'free-control', timeout: 10000 });
|
|
expect(options.prompt).toContain('cat SOURCE.md >> TARGET.md');
|
|
expect(options.prompt).toContain('.qa-state/ directory is the fixture owner');
|
|
for (const transport of [false, true]) expect(docsNativeInterface(fixture, [], transport)).not.toContain('>> TARGET.md');
|
|
});
|
|
|
|
test('the installed docs-candidate helper is admitted only with a private .json record, or for its own --help', () => {
|
|
const helper = path.join(fixture.skills, 'bin/gstack-docs-candidate');
|
|
const record = path.join(fixture.home, 'audit-1-candidate.json');
|
|
for (const command of [
|
|
`${helper} snapshot --out ${record} --audit-id audit-1 --mode edit --base main --docs handbook`,
|
|
`${helper} snapshot --out ${record} --audit-id audit-1 --mode read-only --base main --select app.ts --docs handbook`,
|
|
`${helper} compare ${record}`,
|
|
`${helper} --help`,
|
|
]) expect(docsCommandAllowed(command, fixture), command).toBe(true);
|
|
for (const command of [
|
|
`${helper} snapshot --out ${path.join(fixture.repo, 'candidate.json')} --audit-id a --mode edit --base main`,
|
|
`${helper} snapshot --out ${path.join(fixture.home, 'candidate.txt')} --audit-id a --mode edit --base main`,
|
|
`${helper} snapshot --out ${record} --out ${record} --audit-id a --mode edit --base main`,
|
|
`${helper} snapshot --audit-id a --mode edit --base main`,
|
|
`${helper} snapshot --out ${record} --audit-id a --mode edit --base main --exec rm`,
|
|
`${helper} compare ${path.join(fixture.skills, 'bin/x.json')}`,
|
|
`${helper} compare ${record} extra`,
|
|
`${helper} install`,
|
|
`${helper} --help snapshot`,
|
|
`${helper} --version`,
|
|
`~/.claude/skills/gstack/bin/gstack-docs-candidate compare ${record}`,
|
|
]) expect(docsCommandAllowed(command, fixture), command).toBe(false);
|
|
expect(docsNativeInterface(fixture)).toContain(`${fixture.skills.split(path.sep).join('/')}/bin/gstack-docs-candidate snapshot`);
|
|
expect(docsNativeInterface(fixture)).toContain('compare <that .json> and --help commands');
|
|
});
|
|
|
|
// Train gate 39904966815 (ship-docsync-completion, attempt 1) and GSTA-63's focused run joined the candidate's
|
|
// --help onto a line of reads. The join stays refused; the own-call rule now sits in the sentence naming --help.
|
|
test('a candidate --help joined to reads stays refused, and the interface says so where it names the command', () => {
|
|
const skills = fixture.skills.split(path.sep).join('/');
|
|
const joined = `git diff; git diff --cached; cat options.ts; ls -la handbook handbook/reference handbook/reference/commands; ${skills}/bin/gstack-docs-candidate --help`;
|
|
expect(docsCommandAllowed(joined, fixture)).toBe(false);
|
|
expect(docsCommandAllowed(`${skills}/bin/gstack-docs-candidate --help`, fixture)).toBe(true);
|
|
const sentence = docsNativeInterface(fixture).split(/(?<=\.)\s+(?=[A-Z])/).find(part => part.includes('gstack-docs-candidate snapshot'));
|
|
expect(sentence).toContain('as its own Bash call, with nothing joined before or after it');
|
|
expect(sentence).toContain('a --help is no exception');
|
|
});
|
|
|
|
test('the installed lifecycle helpers are admitted for their own --help, which starts nothing', () => {
|
|
const skills = fixture.skills.split(path.sep).join('/');
|
|
for (const helper of ['gstack-skill-start', 'gstack-skill-end']) {
|
|
expect(docsCommandAllowed(`${skills}/bin/${helper} --help`, fixture)).toBe(true);
|
|
for (const command of [
|
|
`${skills}/bin/${helper} --help --skill review`,
|
|
`${skills}/bin/${helper} --skill review`,
|
|
`${skills}/bin/${helper} -h`,
|
|
`${skills}/bin/${helper} --help; ${skills}/bin/${helper} --skill document-release`,
|
|
`~/.claude/skills/gstack/bin/${helper} --help`,
|
|
]) expect(docsCommandAllowed(command, fixture), command).toBe(false);
|
|
}
|
|
expect(docsNativeInterface(fixture)).toContain('or their own --help');
|
|
});
|
|
|
|
// PR gate run 38969924945 (ship-docsync-store) went red only on `gstack-skill-start --help`.
|
|
test('every Bash command of the captured ship-docsync-store run is inside the interface', () => {
|
|
const capture = JSON.parse(fs.readFileSync(path.join(import.meta.dir, 'fixtures/docsync-store-38969924945-bash.json'), 'utf8'));
|
|
const commands: string[] = capture.commands.map((command: string) => command.replaceAll('<HOME>', fixture.home));
|
|
for (const file of ['docs-audit-20261016T2140Z-1-documentation.md', 'ship-report.md']) fs.writeFileSync(path.join(fixture.home, file), '');
|
|
const publish = path.join(fixture.home, 'fixture-publish.ts');
|
|
expect(commands).toHaveLength(54);
|
|
expect(commands.filter(command => !docsCommandAllowed(command, fixture, [publish]))).toEqual([]);
|
|
});
|
|
|
|
// PR gate run 38990111230 (ship-docsync-stale-after, head 6c07d85c82d17bda81860cd0d78616de3dc14cc2) went red only on
|
|
// `gstack-docs-candidate snapshot --help` (bash#8), which the helper rejected as an unknown argument. Every Bash
|
|
// command of the parent, in order; <HOME> is the fixture home and <ACTOR> the fault actor.
|
|
const STALE_AFTER_38990111230 = [
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate compare <HOME>/candidate-ship-docs-a1.json',
|
|
'bun <ACTOR> inspect <HOME>/actor-state.json',
|
|
'sha256sum <HOME>/.claude/skills/gstack/document-release/SKILL.md <HOME>/.claude/skills/gstack/document-release/sections/audit-scope.md <HOME>/.claude/skills/gstack/document-release/sections/release-body.md',
|
|
'bun <ACTOR> prepare <HOME>/actor-state.json audit_id=ship-docs-a2',
|
|
'bun <ACTOR> dispatch <HOME>/actor-state.json audit_id=ship-docs-a2 candidate=<HOME>/candidate-ship-docs-a2.json prompt=<HOME>/prompt-ship-docs-a2.md run_in_background=false',
|
|
'bun <ACTOR> inspect <HOME>/actor-state.json',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate compare <HOME>/candidate-ship-docs-a2.json',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate snapshot --help',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate snapshot --out <HOME>/ship-docs-a2-post.json --audit-id ship-docs-a2 --mode edit --base 21cebf26714abdfc6b80267507b88a4df6e933a8 --docs handbook --select AGENTS.md --select CHANGELOG.md --select README.md --select TODOS.md --select VERSION --select app.ts --select handbook/reference/commands/widget.md.tmpl --select package.json',
|
|
'bun <ACTOR> inspect <HOME>/actor-state.json',
|
|
'bun <ACTOR> publish <HOME>/actor-state.json audit_id=ship-docs-a2 report=<HOME>/ship-report.md',
|
|
];
|
|
|
|
test('every Bash command of the captured ship-docsync-stale-after run is inside the fault interface', () => {
|
|
const actor = path.join(import.meta.dir, 'helpers/docsync-fault-actor.ts');
|
|
const commands = STALE_AFTER_38990111230.map(command => command.replaceAll('<HOME>', fixture.home).replaceAll('<ACTOR>', actor));
|
|
expect(commands).toHaveLength(11);
|
|
expect(commands.filter(command => !docsCommandAllowed(command, fixture, [actor]))).toEqual([]);
|
|
});
|
|
|
|
test('subcommand --help is admitted alone and runs without effect; with any other argument it stays outside the interface', () => {
|
|
const helper = path.join(fixture.skills, 'bin/gstack-docs-candidate');
|
|
const record = path.join(fixture.home, 'help-probe.json');
|
|
const before = repoSnapshot(fixture.repo);
|
|
for (const sub of ['snapshot', 'compare']) {
|
|
expect(docsCommandAllowed(`${helper} ${sub} --help`, fixture)).toBe(true);
|
|
const run = spawnSync(helper, [sub, '--help'], { cwd: fixture.repo, encoding: 'utf8', timeout: 20_000 });
|
|
expect(run.status, run.stderr).toBe(0);
|
|
expect(run.stdout).toContain('usage: gstack-docs-candidate snapshot --out <candidate.json>');
|
|
}
|
|
for (const command of [
|
|
`${helper} snapshot --help --out ${record}`,
|
|
`${helper} compare --help ${record}`,
|
|
`${helper} snapshot --out ${record} --help`,
|
|
`${helper} snapshot -h`,
|
|
`${helper} compare -h`,
|
|
`${helper} snapshot --help --out ${path.join(fixture.repo, 'inside.json')}`,
|
|
`${helper} snapshot --out ${path.join(fixture.repo, 'inside.json')} --audit-id a --mode edit --base main`,
|
|
`${helper} snapshot --help; ${helper} compare ${record}`,
|
|
]) expect(docsCommandAllowed(command, fixture), command).toBe(false);
|
|
expect(fs.existsSync(record)).toBe(false);
|
|
expect(repoSnapshot(fixture.repo)).toEqual(before);
|
|
});
|
|
|
|
// PR gate run 39153452209 (ship-docsync-store, head a844821583d664e3dea279fff12b935865e92f52) went red only on the
|
|
// document-release child's `git describe --tags --always` (bash#24). Every Bash command of the parent and its child,
|
|
// in order; <HOME> is the fixture home.
|
|
const STORE_39153452209 = [
|
|
'git status',
|
|
'git rev-parse HEAD',
|
|
'git ls-files',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate --help',
|
|
'git diff --cached',
|
|
'git diff',
|
|
'git branch --show-current',
|
|
'git log --oneline',
|
|
'git check-ignore -v .qa-state',
|
|
'ls -la <HOME>',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-skill-start --help',
|
|
'git ls-files -z --cached --others --exclude-standard',
|
|
'git show HEAD:handbook/reference/commands/widget.md.tmpl',
|
|
'ls -la <HOME>/state',
|
|
'git hash-object README.md handbook/reference/commands/widget.md.tmpl options.ts app.ts personal-note.txt',
|
|
'git log --oneline --decorate --all',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate snapshot --out <HOME>/ship-docs-20261018-c0048c5-a1.json --audit-id ship-docs-20261018-c0048c5-a1 --mode read-only --base c0048c54c542cf0ba46b7587cf7fea1b519c75e4 --select app.ts --select README.md --select options.ts --docs handbook --docs README.md --docs AGENTS.md --docs CHANGELOG.md --docs TODOS.md',
|
|
'GSTACK_SESSION_KIND=spawned <HOME>/.claude/skills/gstack/bin/gstack-skill-start --skill document-release --model claude',
|
|
'git status',
|
|
'git log --oneline',
|
|
'git diff c0048c54c542cf0ba46b7587cf7fea1b519c75e4 HEAD --stat',
|
|
'git diff --cached',
|
|
'git diff',
|
|
'git ls-files --cached --others --exclude-standard',
|
|
'git hash-object README.md options.ts app.ts personal-note.txt',
|
|
'git describe --tags --always',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-skill-end --skill document-release --outcome success --session-id 878-1792348356-d8b277ad --tel-start 1792348356 --used-browse no',
|
|
'<HOME>/.claude/skills/gstack/bin/gstack-docs-candidate compare <HOME>/ship-docs-20261018-c0048c5-a1.json',
|
|
'git status',
|
|
'git rev-parse HEAD',
|
|
'git hash-object README.md handbook/reference/commands/widget.md.tmpl options.ts app.ts personal-note.txt AGENTS.md CHANGELOG.md TODOS.md VERSION package.json',
|
|
'ls -la <HOME>',
|
|
'ls -la <HOME>/repo',
|
|
'cat <HOME>/ship-docs-20261018-c0048c5-a1-documentation.md >> <HOME>/ship-report.md',
|
|
'git status',
|
|
'ls -la <HOME>',
|
|
];
|
|
|
|
test('every Bash command of the captured run 39153452209 ship-docsync-store is inside the interface', () => {
|
|
const commands = STORE_39153452209.map(command => command.replaceAll('<HOME>', fixture.home));
|
|
for (const file of ['ship-docs-20261018-c0048c5-a1-documentation.md', 'ship-report.md']) fs.writeFileSync(path.join(fixture.home, file), '');
|
|
expect(commands).toHaveLength(36);
|
|
expect(commands).toContain('git describe --tags --always');
|
|
expect(commands.filter(command => !docsCommandAllowed(command, fixture))).toEqual([]);
|
|
expect(docsToolFailures(nativeResult('git describe --tags --always', 'c0048c5', 'docs-dispatch'), fixture, [], true)).toEqual([]);
|
|
});
|
|
|
|
const DESCRIBE_READS = ['git describe', 'git describe --tags', 'git describe --always', 'git describe --abbrev=7',
|
|
'git describe --exact-match', 'git describe HEAD', "git describe --tags --always --abbrev=12 'HEAD^{}'",
|
|
'git describe --exact-match --tags main', 'git describe --always main', 'git describe --tags --always 2>/dev/null'];
|
|
const DESCRIBE_REFUSED = ['git describe --dirty', 'git describe --dirty=-modified', 'git describe --always --dirty',
|
|
'git describe --broken', 'git describe --broken=-broken', 'git describe --contains HEAD', 'git describe --all',
|
|
'git describe --abbrev', 'git describe --abbrev=x', 'git describe HEAD main', 'git describe -- HEAD',
|
|
'git describe --tags > tag.md', 'git describe --tags; git tag v9', 'git describe --tags && git tag v9'];
|
|
|
|
test('read-only git describe forms are declared and leave the index and repository unchanged', () => {
|
|
expect(docsNativeInterface(fixture)).toContain('describe with only --tags, --always, --abbrev=<n> or --exact-match and at most one revision');
|
|
const own = fixtureDocs('store');
|
|
try {
|
|
gitAt(own.repo, 'tag', '-a', 'v0.1.0', '-m', 'fixture release', 'HEAD');
|
|
const stale = new Date(Date.now() - 3600_000);
|
|
fs.utimesSync(path.join(own.repo, 'AGENTS.md'), stale, stale);
|
|
const index = () => fs.readFileSync(path.join(own.repo, '.git/index')).toString('base64');
|
|
const before = { repo: repoSnapshot(own.repo), index: index() };
|
|
for (const command of DESCRIBE_READS) {
|
|
expect(docsCommandAllowed(command, own), command).toBe(true);
|
|
expect(docsToolFailures(nativeResult(command), own, [], true), command).toEqual([]);
|
|
const run = spawnSync('bash', ['-c', command], { cwd: own.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(run.status, `${command}: ${run.stderr}`).toBe(0);
|
|
expect({ repo: repoSnapshot(own.repo), index: index() }, command).toEqual(before);
|
|
}
|
|
} finally {
|
|
own.clean();
|
|
}
|
|
});
|
|
|
|
test('describe forms that refresh the index or fall outside the declared set, and Git writes, stay outside the interface', () => {
|
|
for (const command of [...DESCRIBE_REFUSED, 'git tag v9 HEAD', 'git update-index --refresh', 'git notes add -m x HEAD']) {
|
|
expect(docsCommandAllowed(command, fixture), command).toBe(false);
|
|
expect(docsToolFailures(nativeResult(command, 'successful tool acknowledgment', 'docs-dispatch'), fixture, [], true), command)
|
|
.toEqual(['command outside declared docs observation interface']);
|
|
}
|
|
const own = fixtureDocs('store');
|
|
try {
|
|
const stale = new Date(Date.now() - 3600_000);
|
|
fs.utimesSync(path.join(own.repo, 'AGENTS.md'), stale, stale);
|
|
const index = () => fs.readFileSync(path.join(own.repo, '.git/index')).toString('base64');
|
|
const before = index();
|
|
const run = spawnSync('git', ['describe', '--always', '--dirty'], { cwd: own.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(run.status, run.stderr).toBe(0);
|
|
expect(index()).not.toBe(before);
|
|
} finally {
|
|
own.clean();
|
|
}
|
|
});
|
|
|
|
|
|
// ship-docsync-current on Opus 5.5: run 39347827595 (PR #3300 @ ca215b0) went red only on the parent's joined Git read,
|
|
// and run 39344306426 (PR #3312 @ c895ab9) only on the child's loop that printed each selected file under a header.
|
|
// Both are pure reads; each still runs as declared and leaves the repository unchanged.
|
|
const CURRENT_COMPOSED_READS = [
|
|
'cat personal-note.txt; echo ---; git diff main HEAD',
|
|
'for f in AGENTS.md README.md CHANGELOG.md TODOS.md VERSION app.ts package.json handbook/reference/commands/widget.md.tmpl personal-note.txt; do echo "=== $f"; cat $f; done',
|
|
'git status --porcelain && git diff --cached | head -5',
|
|
'for doc in README.md AGENTS.md; do git log --oneline -- $doc; done',
|
|
'for f in app.ts; do echo "== ${f}"; cat "$f" 2>/dev/null; done',
|
|
// Focused Opus trial after the first repair (2026-10-20): a loop joined to a find.
|
|
'for f in AGENTS.md README.md CHANGELOG.md TODOS.md VERSION app.ts package.json handbook/reference/commands/widget.md.tmpl; do echo "== $f"; cat $f; done; find <HOME>/repo -name .gstack -not -path "*/.git/*"',
|
|
'git status; for f in README.md AGENTS.md; do cat $f; done && git rev-parse HEAD',
|
|
// Round-1 focused trial and the round-2 ship-docsync-completion trial: NUL-separated paths shown one per line.
|
|
"git ls-files -z --cached --others --exclude-standard | tr '\\0' '\\n'",
|
|
"git status --porcelain=v1 --ignored; git rev-parse HEAD; git merge-base main HEAD; git branch --show-current; git ls-files -z --cached --others --exclude-standard | tr '\\0' '\\n'",
|
|
];
|
|
|
|
test('captured composed reads of ship-docsync-current are declared and leave the repository unchanged (39347827595, 39344306426)', () => {
|
|
const own = fixtureDocs('current');
|
|
try {
|
|
expect(docsNativeInterface(own)).toContain('The Git reads above may join such a line too');
|
|
expect(docsNativeInterface(own)).toContain('A for loop over literal words');
|
|
const before = repoSnapshot(own.repo);
|
|
for (const command of CURRENT_COMPOSED_READS.map(line => line.replaceAll('<HOME>', own.home))) {
|
|
expect(docsCommandAllowed(command, own), command).toBe(true);
|
|
expect(docsToolFailures(nativeResult(command, 'output', 'docs-dispatch'), own, [], true), command).toEqual([]);
|
|
const run = spawnSync('bash', ['-c', command], { cwd: own.repo, encoding: 'utf8', timeout: 10000 });
|
|
expect(run.status, `${command}: ${run.stderr}`).toBe(0);
|
|
}
|
|
expect(repoSnapshot(own.repo)).toEqual(before);
|
|
const doc = path.join(own.repo, DOC_PATH);
|
|
const source = fs.readFileSync(doc, 'utf8');
|
|
const credited = (command: string) => docsCompletedRead(nativeResult(command, source), doc, own);
|
|
expect(credited(`cat ${DOC_PATH}; git status`)).toBe(true);
|
|
expect(credited(`git status; cat ${DOC_PATH} | head`)).toBe(false);
|
|
// The focused trial's child read the document only inside its loop.
|
|
const loop = `for f in personal-note.txt README.md ${DOC_PATH} app.ts; do echo "=== $f"; cat $f; done`;
|
|
const looped = spawnSync('bash', ['-c', loop], { cwd: own.repo, encoding: 'utf8', timeout: 10000 }).stdout;
|
|
expect(docsCompletedRead(nativeResult(loop, looped), doc, own)).toBe(true);
|
|
expect(docsCompletedRead(nativeResult(`for f in ${DOC_PATH}; do cat $f | head -1; done`, source), doc, own)).toBe(false);
|
|
expect(docsCompletedRead(nativeResult(`for f in ${DOC_PATH}; do cat $f; cat $HOME; done`, source), doc, own)).toBe(false);
|
|
} finally {
|
|
own.clean();
|
|
}
|
|
});
|
|
|
|
// Run 39338691964 (PR #3308 @ 8da34e2) keeps failing on purpose: the child's stray assignment, and the parent's reads
|
|
// of agents' session transcripts in the Claude config dir (now named off-limits in the interface). Joined Git reads
|
|
// and loops grant no write, bypass option, pipe sink, cd, glob, variable or denied path.
|
|
test.each([
|
|
'for_none=1; cat AGENTS.md README.md',
|
|
'find <HOME>/cc/projects -type f',
|
|
'grep -o SESSION_KIND <HOME>/cc/projects/session/subagents/agent-a.jsonl',
|
|
'cat README.md; git add app.ts', 'git diff; git commit -m changed', 'ls && git -c core.pager=less show HEAD',
|
|
'ls; git -C /tmp status', 'cat app.ts | git hash-object -w --stdin', 'cat app.ts | git hash-object --stdin',
|
|
'cd .. && git status; ls', 'cd handbook; git status', 'git diff > out.md; ls', 'ls; git diff --output=out.md',
|
|
'git status & ls', 'git status; rm app.ts', 'git log | sh', 'git log | tee log.md', 'git status; cat <HOME>/cc/.claude.json',
|
|
'git status; git remote get-url origin', "ls; git show 'HEAD", 'git status; ls $HOME',
|
|
'for f in README.md; do cat $f > out.md; done', 'for f in app.ts; do rm $f; done', 'for f in $(ls); do cat $f; done',
|
|
'for f in *; do cat $f; done', 'for f in c*/.claude.json; do cat "$f"; done', 'for PATH in /tmp; do cat README.md; done',
|
|
'for f in README.md; do cat $f; cat $HOME; done', 'for f in README.md; do cat $f; done; rm app.ts',
|
|
'for f in README.md; do cat $f; done > out.md', 'for f in "README.md"; do cat $f; done', 'for f in ../../outside; do cat $f; done',
|
|
'for f in ../cc/.claude.json; do cat $f; done', 'for f in app.ts; do git add $f; done', 'for f in a b; do for g in c; do cat $g; done; done',
|
|
'for f in README.md; do cat $f; done &', 'for f in {README,AGENTS}.md; do cat $f; done', 'for f in ~/x; do cat $f; done',
|
|
'ls; for f in README.md; do cat $f; done > out.md', 'for f in README.md; do cat $f; done; for g in app.ts; do rm $g; done',
|
|
'ls; for f in README.md; do cat $f; done | sh', 'cd ..; for f in README.md; do git status; done', 'for f in README.md; do cat $f && done',
|
|
"git ls-files -z | tr '\\0' '\\n' | sh", "git ls-files -z | tr '\\0' '\\n' > files.md", 'tr a b', "git ls-files | tr '$x' y",
|
|
])('composed reads stay closed to writes and bypasses: %s', command => {
|
|
const line = command.replaceAll('<HOME>', fixture.home);
|
|
expect(docsCommandAllowed(line, fixture), line).toBe(false);
|
|
expect(docsToolFailures(nativeResult(line, 'successful tool acknowledgment', 'docs-dispatch'), fixture, [], true))
|
|
.toEqual(['command outside declared docs observation interface']);
|
|
});
|
|
|
|
test('the docs interface names the Claude config dir and private actor state as unreadable', () => {
|
|
const guidance = docsNativeInterface(fixture);
|
|
expect(guidance).toContain(`off ${fixture.env.CLAUDE_CONFIG_DIR} except its settings.json`);
|
|
expect(guidance).toContain("every agent's session transcript");
|
|
expect(guidance).toContain('judge a child only by the output it returns');
|
|
expect(guidance).toContain('Every read stays off actor-state.json');
|
|
});
|
|
|
|
// /ship Step 14.5's continue path (PR 2 of the convergence lane) runs three own-tree housekeeping commands and writes
|
|
// the receipt's docs record inside the repository. The closed interface declares exactly those, byte for byte with the
|
|
// generated section, and nothing adjacent: a reworded exclude line, a bare rm, another receipt subcommand or another
|
|
// write under .gstack/ stay outside it (gate: ship-docsync-completion/current red twice at 775d9804 before they were declared).
|
|
test('Step 14.5 housekeeping commands and the docs record are declared exactly as the generated section writes them', () => {
|
|
const { DOCS_AUDIT_RECORD, DOCS_AUDIT_RECORD_PATHS, DOCS_AUDIT_RESET, DOCS_TMP_EXCLUDE, docsCapsCommand } = require('./helpers/docsync-interface') as typeof import('./helpers/docsync-interface');
|
|
const section = fs.readFileSync(path.resolve(import.meta.dir, '..', 'ship/sections/documentation.md'), 'utf8');
|
|
expect(section).toContain(DOCS_TMP_EXCLUDE);
|
|
expect(section).toContain(DOCS_AUDIT_RESET);
|
|
expect(section).toContain('gstack-ship-receipt docs-caps --base <base>');
|
|
const skills = fixture.skills.split(path.sep).join('/');
|
|
const caps = docsCapsCommand(skills);
|
|
const interfaceText = docsNativeInterface(fixture);
|
|
for (const command of [DOCS_TMP_EXCLUDE, DOCS_AUDIT_RESET, caps, docsCapsCommand('~/.claude/skills/gstack')]) {
|
|
if (command === caps) expect(interfaceText).toContain(command);
|
|
expect(docsCommandAllowed(command, fixture)).toBe(true);
|
|
expect(docsToolFailures(nativeResult(command, 'DOCS_CAP: none declared'), fixture, [], true)).toEqual([]);
|
|
}
|
|
for (const command of [DOCS_TMP_EXCLUDE.replace("'/.gstack/tmp/'", "'/.gstack/'"), `${DOCS_TMP_EXCLUDE}; git add -A`, 'rm -f .gstack/tmp', 'rm -rf .gstack/tmp/docs-audit.json',
|
|
`${skills}/bin/gstack-ship-receipt docs-caps --base feature/docs`, '~/.claude/skills/other/bin/gstack-ship-receipt docs-caps --base main', `${skills}/bin/gstack-ship-receipt write --docs @${DOCS_AUDIT_RECORD}`, `${skills}/bin/gstack-ship-receipt docs-caps --base main --json`]) {
|
|
expect(docsCommandAllowed(command, fixture)).toBe(false);
|
|
}
|
|
const write = (file: string): SkillTestResult => {
|
|
const parsed = parseNDJSON([
|
|
{ type: 'assistant', parent_tool_use_id: null, message: { content: [{ type: 'tool_use', id: 'docs-write', name: 'Write', input: { file_path: file, content: '{"status":"current","scope":"handbook"}' } }] } },
|
|
{ type: 'user', parent_tool_use_id: null, message: { content: [{ type: 'tool_result', tool_use_id: 'docs-write', content: 'ok', is_error: false }] } },
|
|
].map(event => JSON.stringify(event)));
|
|
return { ...parsed, exitReason: 'success' } as unknown as SkillTestResult;
|
|
};
|
|
expect(docsToolFailures(write(path.join(fixture.repo, DOCS_AUDIT_RECORD)), fixture, [], false)).toEqual([]);
|
|
expect(docsToolFailures(write(path.join(fixture.repo, DOCS_AUDIT_RECORD)), fixture, [], true)).toEqual([]);
|
|
expect(docsToolFailures(write(path.join(fixture.repo, DOC_PATH)), fixture, [], true)).toEqual(['read-only docs write attempt']);
|
|
// The kernel observer sees the exclude file and the record's directories in every scenario that runs the Entry, the fault cases'
|
|
// unseeded first attempts included, so the shared list is permitted without each caller naming it; anything else under .git or .gstack is not.
|
|
const observed = (paths: string[]) => ({ complete: true, failures: [], events: paths.map(p => ({ path: p, mask: 0x2, cookie: 0, at: 0 })), changed: paths, before: {}, after: {}, limits: [] });
|
|
expect(docsWriteFailures(observed(['.qa-state/.observer-check', ...DOCS_AUDIT_RECORD_PATHS]), [])).toEqual([]);
|
|
expect(docsWriteFailures(observed(['.git/info/attributes']), [])).toEqual(['forbidden docs write: .git/info/attributes']);
|
|
expect(docsWriteFailures(observed(['.gstack/tmp/review-loop.json']), [DOC_PATH])).toEqual(['forbidden docs write: .gstack/tmp/review-loop.json']);
|
|
// The Write tool lands the record through `<record>.tmp.<pid>.<12 hex>` + rename (gate: both lifecycle cases red at 0230fc2 on exactly
|
|
// that sibling). The sibling is admitted only as the cookie-paired source of a move onto the record that leaves nothing behind.
|
|
const temp = `${DOCS_AUDIT_RECORD}.tmp.564.6161e6c7f0b7`;
|
|
const moved = (edits: { path: string; mask: number; cookie?: number }[], after: Record<string, string> = {}) => ({
|
|
complete: true, failures: [], events: edits.map((e, at) => ({ path: e.path, mask: e.mask, cookie: e.cookie ?? 0, at })), changed: Object.keys(after), before: {}, after, limits: [],
|
|
});
|
|
const landing = [{ path: temp, mask: 0x100 }, { path: temp, mask: 0x2 }, { path: temp, mask: 0x8 }, { path: temp, mask: 0x40, cookie: 7 }, { path: DOCS_AUDIT_RECORD, mask: 0x80, cookie: 7 }];
|
|
expect(docsWriteFailures(moved(landing), [])).toEqual([]);
|
|
expect(docsWriteFailures(moved(landing.slice(1)), [])).toEqual([]);
|
|
expect(docsWriteFailures(moved(landing, { [temp]: '0:' + 'a'.repeat(64) }), [])).toEqual([`forbidden docs write: ${temp}`]);
|
|
expect(docsWriteFailures(moved(landing.slice(0, 3)), [])).toEqual([`forbidden docs write: ${temp}`]);
|
|
expect(docsWriteFailures(moved([...landing.slice(0, 4), { path: '.gstack/tmp/other.json', mask: 0x80, cookie: 7 }]), [])).toEqual([`forbidden docs write: ${temp}`, 'forbidden docs write: .gstack/tmp/other.json']);
|
|
expect(docsWriteFailures(moved([...landing.slice(0, 3), { path: temp, mask: 0x40, cookie: 7 }, { path: DOCS_AUDIT_RECORD, mask: 0x80, cookie: 7 }, { path: temp, mask: 0x100 }]), [])).toEqual([`forbidden docs write: ${temp}`]);
|
|
expect(docsWriteFailures(moved([{ path: `${DOC_PATH}.tmp.564.6161e6c7f0b7`, mask: 0x40, cookie: 9 }, { path: DOCS_AUDIT_RECORD, mask: 0x80, cookie: 9 }]), [])).toEqual([`forbidden docs write: ${DOC_PATH}.tmp.564.6161e6c7f0b7`]);
|
|
expect(docsToolFailures(write(path.join(fixture.repo, '.gstack/tmp/review-loop.json')), fixture, [], false)).toEqual(['non-document product write attempt', 'write outside docs fixture authority']);
|
|
expect(docsToolFailures(write(path.join(fixture.repo, '.gstack/ship-policy.json')), fixture, [], false)).toEqual(['non-document product write attempt', 'write outside docs fixture authority']);
|
|
expect(gitAt(fixture.repo, 'rev-parse', '--verify', 'origin/main')).toBe(gitAt(fixture.repo, 'rev-parse', '--verify', 'main'));
|
|
// The declared gate must run from the fixture install: bin/gstack-ship-receipt imports ../lib/*, so the install carries lib/ too.
|
|
const gate = spawnSync('bun', ['--no-env-file', '--config=/dev/null', path.join(fixture.skills, 'bin/gstack-ship-receipt'), 'docs-caps', '--base', 'main'],
|
|
{ cwd: fixture.repo, encoding: 'utf8', env: { ...process.env, ...fixture.env, HOME: fixture.home }, timeout: 60_000 });
|
|
expect(gate.stderr).toBe('');
|
|
expect(gate.stdout.trim()).toBe('DOCS_CAP: none declared');
|
|
expect(gate.status).toBe(0);
|
|
});
|