mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 02:16:56 +02:00
* refactor(resolvers): split review.ts into MECE resolver modules (pure move) Move every function from scripts/resolvers/review.ts, unchanged, into: - review-dashboard.ts: review dashboard, plan-file review report - plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery, plan-completion audit/gate (ship + review), plan verification exec - spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause - outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan review, Codex doc review, disabled-outside record - review-scope.ts: scope drift, cross-review dedup, shared-code reuse review.ts is deleted; index.ts imports the new modules. gen-skill-docs output is byte-identical for every host (--host all). Test imports and source-path references are re-pointed; the two source-text report/gate tests in gen-skill-docs.test.ts become behavioral renders across every consuming skill and host. All 46 touchfile entries that named review.ts now name all five modules, guarded by a recorded selection golden. * test(browse): black-box auth matrix for every server route and both surfaces Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token, root token, scoped token and the SSE cookie for all 33 routes, plus unmatched paths and wrong methods. Denials assert today's exact status, body and content type; allowed credentials assert the handler was reached. Written against the unchanged if-chain server so the W3 route-table refactor must keep it green. * refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts The shared shard engine grows from the existing strict-output module (runShardChild, killProcessGroup, signal forwarding, strict classifier). scripts/test-strict-output.ts stays as a re-export so existing importers, mock.module paths and the strict-output/run-shard-child tests are unchanged. The engine inherits the global touchfile entry; the free runner's CLI-routing fixture copies the new module. * refactor(resolvers): decompose the three >150-line review resolvers (output-neutral) Split generateAdversarialStep, generateCodexPlanReview and generatePlanCompletionAuditInner into per-section helpers whose template literals are copied verbatim, so every function in the new modules is at or under 150 lines. gen-skill-docs output is byte-identical for every host (--host all, compared against96764e80with a fixed --link-root). * refactor(resolvers): one outside-voice failure policy (deliberate prose unification) outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the auth / timeout / empty-response bullets for all four call sites that hand-typed them (Codex second opinion, adversarial step, Codex plan review, design outside voices). Options are explicit per site (timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no defaults. Deliberate generated-prose changes (every host): - office-hours: 'Fall back to <native> subagent.' becomes 'Fall back to the <native> subagent below.' - plan-devex-review: the plain 'Auth failure (stderr contains ...)' bullets become the canonical bold bullets; auth also triggers on 'API key'; 'auth failed' becomes 'authentication failed'. - review/ship adversarial: 'exceeded 9 minutes and was terminated' becomes 'timed out after 9 minutes and was terminated'; the timeout is still MISSING COVERAGE. - design outside voices: unchanged. Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE retention test, refreshed codex/factory ship goldens, and outside-voice.ts in every touchfile entry of review.ts and design.ts (selection golden extended). * test(pty): fake PTY session driver with an injectable clock through the runner launch seam The three plan-skill runners take an optional PtyDriver (launch, now, monotonic, sleep); omitted, they use the real launcher and clocks exactly as before. test/helpers/pty/fake-session.ts feeds scripted frames through that seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting and floor for success, deadline timeout, permission prompt and plan-ready outcomes with no CLI or real timers. These cases must stay green unchanged through the W4 split and the runPtySession extraction. Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now also lists test/helpers/pty/**. * refactor(shard-engine): run both lanes on the shared engine; lane policy injected Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard tmp/Chromium sandbox + async cleanup backstop, log-path allocation and full-stream log capture, one duration-seed reader/writer with a lane predicate, LanePolicy (seed predicate + zero-execution verdict), strictShardStatus, and the shared CLI flag loop. runShardChild takes an optional companion (signal/settle) and waits a bounded 250ms to reap a wall-killed child. Free lane stops spawning shards itself: runFreeShard uses runShardChild with trackShardBrowser as the companion (win32 path unchanged: no process group, no negative-pid kill). Its sync state-dir removal stays lane policy. Paid lane uses the sandbox, log, seed, verdict and flag primitives; the hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged (free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds, warning under selection and passed-empty under EVALS_ALL). paid-free-boundary's closure assertion now names the engine module, where the strict classifier lives. * test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity - test/shard-engine.test.ts: failing/unhandled/module-load output fails both lanes, per-lane zero-execution and seed rules, whole-group kill on a wall timeout (both lanes), mocked-win32 path with no negative-pid kill, companion settle order, log capture, sandbox isolation, flag loop. - test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence: seven outcome fixtures plus one real shard, run through both lanes and compared with classifications recorded from the base runners (96764e80). - test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set, defaults, validation errors and the Unknown argument error per lane match the base runners. * refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines Output-neutral extraction under the fixture-corpus equivalence and runner tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free); paidShardCommand, settleShardSpool, settleBootstrapRetention and printLogTail (paid). The bootstrap scope-creation block that bootstrap-retention.test.ts evaluates stays verbatim. * refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel Pure move: every line of the former 5,047-line runner lands verbatim in one module (four private helpers gain `export` for cross-module use): binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it), launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries, runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the original public surface by name; pty/ modules import siblings directly. Tests that read the runner's source text: - rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv: fallback chain, --model before extraArgs, hermetic --strict-mcp-config), pty-skill-seeding-wiring (runners through the fake driver; launcher through a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model" grep is replaced by the runners' fake-driver launch assertions. - pty-screen-session / pty-screen-supervision: stop copying runner source; they mock.module the real pty/screen.ts (and the fixture cleanup) instead. - re-pointed to the owning module (they execute a sliced runner body with injected boundaries; no seam exists for those boundaries yet): eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication, plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts and scans every pty/ module for raw process.env spreads. - plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts. * test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and top-level function lengths by brace matching over masked source (strings, comments, regex literals and template text masked; ${} expressions kept), covering function declarations, arrow functions assigned to consts and route-table handler properties, with no parser dependency. Its self-test uses template literals and code-fence braces copied from scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and records the residual runner sizes (free 2352, paid 1921) as non-growth caps; allowlist entries are keyed on file plus matched text and need a reason. Failure output lists file:line, the rule, Fix: and the allowlist path. touchfiles.test.ts gains the moved-code superset check over test/fixtures/touchfile-move-goldens/ (W2 golden recorded at96764e80: test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none). * refactor(browse): declared route table replaces the buildFetchHandler if-chain The ~1,300-line if-chain in buildFetchHandler becomes a route table: each entry declares method, path, auth kind and surfaces, and one auth gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer, scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token required; extension-origin: 403 Forbidden). Unmatched requests take the declared fallthrough (root-bearer check, then plain-text 404). Handlers move to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files, inspector}.ts and receive a RouteContext with auth checks as functions instead of closing over factory locals. Dispatch order is unchanged: tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a literal in server.ts. Behavior-preserving: the black-box auth matrix from the previous commit passes unchanged. /memory and /inspector/events are declared root-bearer because the blanket check always ran before their SSE-cookie branch. Source-text route tests are rewritten as behavioral tests through buildFetchHandler or a route's real handler with a stub RouteContext (browse/test/route-test-harness.ts). Checks with no runtime seam are re-pointed to the route modules: Surface type, /inspector/events SSE helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import, and the ngrok config lookup and startTunnel wiring that stay in server.ts. * test(browse): stubbed-handler auth matrix and route inventory for the route table Every ROUTES entry runs through the real dispatcher and gate with stub handlers on each declared surface and six credentials; denials assert the exact status and body each auth kind returned at96764e8, admitted credentials assert the handler ran (with the gate's TokenInfo for scoped routes). Also pins the reviewed route inventory (method, path, auth kind, surfaces), that every entry declares auth and surfaces, that the table's tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the unmatched fallthrough, and that the root token is rejected on every tunnel route through buildFetchHandler. * test(browse): ratchet (b) keeps route dispatch inside the route table Scans browse/src/server.ts and browse/src/routes/*.ts for pathname comparisons; only the table matcher and the tunnel-surface filter are allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json (keyed on file plus line text). Also checks every entry declares auth and surfaces and that gstack registers no beforeRoute overlay itself. Self-tests plant a violation and assert the file:line, Fix: and allowlist path in the message, that a shifted line stays allowlisted, and that a reasonless entry is rejected. * test: touchfile superset check for modules moved out of browse/src/server.ts Records the paid evals selected by touching browse/src/server.ts at96764e80(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects a superset. The test reads every golden in test/fixtures/moved-module-selection/ so other moved-code goldens can sit beside it. * test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded host cannot turn a pass into a timeout. Base and branch runners still agree on every classification under the new walls. The Windows exclusion entry moves the free runner's ratchet (c) residual cap to 2356 lines. * refactor(pty): one runPtySession loop drives observation, counting and floor test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* -> timeout and the failure contract the three runners each hand-rolled: the run's own error wins over capture and close errors, close always runs, owned fixture cleanup runs last (also when launch fails). Each runner now supplies a PtySessionPlan: its boot/command step, poll cadence (2s observation/floor sleep; counting's output wake + 250ms coalesce), tick policy (permission handling, native identity, terminal rules stay per runner because they differ) and capture hooks. The runner bodies are decomposed into top-level steps so no function exceeds 150 lines; behavior is unchanged and the fake-driver cases from the first W4 commit pass unmodified. The counting capture step and the native completion-summary predicate are now named functions (countingCapture, isNativeCompletionSummary), so plan-create-prepublication and plan-count-completion call them directly instead of executing sliced source. The two harnesses that still execute a sliced runner body with injected boundaries (eng-seeded-completion-ai, plan-floor-permission) pass the PtyDriver seam instead of overriding Date/Bun.sleep. * test(ratchet-c): register route modules, review resolver modules and server.ts residual cap * refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines launchClaudePty (349 lines) becomes launch preparation (args, hermetic child env, owned state roots), recorder creation, spawn, the trust-dialog watcher, close, and the session handle over one PtyProcess state object. The failure order is unchanged: abort the viewport, dispose any recorders created so far, dispose the viewport, rethrow. The --model / --strict-mcp-config ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests. engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each self-contained issue family (declared cache, library retry hooks, cache owner, injected singleton, shared writers, injected export) moves verbatim into its own function. Every pty/ module is now <= 800 lines and every top-level function <= 150 lines. * test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams The 188 unit tests move verbatim into claude-pty-runner.{screen,classify, auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each file imports only what it uses from the barrel). The five files that no longer read a SKILL.md template join the test-of-test ratchet baseline with a reason. * test(touchfiles): moved PTY modules keep their paid-eval selection test/fixtures/touchfile-selection/w4-pty.json records, at96764e8, the paid evals selected by touching test/helpers/claude-pty-runner.ts (20) and test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file under test/helpers/pty/ (and pty/screen.ts for both sources) selects a superset, reading every golden in that directory so later moves can add one; a planted-violation case pins the report and its Fix line. * fix(browse): unexchanged pair setup keys no longer authenticate bearer requests validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and /file (found while building the W3 auth matrix). A setup key now only authenticates the /connect exchange. * W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests * W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design, ios-qa daemon, lib and scripts resolve the state root through bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the twin and stop with a reinstall message when it is missing; hooks source it and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts delegate to resolveStateRoot. Analytics writers and readers move together so the usage log stays one file. gstack-uninstall deletes state only at ~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor, the checkout or the git root, and leaves any other resolved root in place with the removal command. Fixtures that copy single bins now copy the twin. * W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity readConfigKey / gstack_read_config_key return the most restrictive telemetry, memorable_recall, codex_reviews and update_check across the resolved root and ~/.gstack; other keys read the resolved root only. gstack-config set reports an overriding root with the exact override command, list shows the winning root and a root-variable disagreement line. gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress reads through readConfigKey. test-setup.ts strips inherited GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root. * W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts) One hook-errors.log writer: root from resolveStateRoot, 0600 on every append, opt-in rate limit used only by memorable-user-prompt. The five hooks route through it. * W1: docs/state-root.md and README troubleshooting pointer Precedence table, a real --explain example, the move-your-state recipe, merged privacy keys, the uninstall rule, the resolver-failure fix, and the plugin-mode note (evidence gate: no official plugin distribution). * W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a) Every gstack-paths eval in templates and resolvers carries the fail-stop guard; executable ~/.gstack paths in bash blocks (context recovery preamble, eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock, retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE. ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex), ship goldens re-pinned, parity and context-budget caps raised to the measured sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a reasoned allowlist; W1 touchfile entries plus a superset golden. * refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams * test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps * v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave * test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture * fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees * fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity) * test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck * test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case * fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped * fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks) * test(qa-callers): disable git auto maintenance in the caller fixture Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git 2.55 it rewrote .git/objects fan-out directories while the write observer was running, which surfaced as unauthorized mutations. Same gc.auto=0 / maintenance.auto=false guard the shared-libs fixture already uses. * test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked * test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files) The doc-sync fault cases replayed attempt 1 before reaching their gate and ran out of their 285s budget. The fixture now seeds attempt 1 and the parent starts at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave (fb526898,e6ac813d,6ce10ff7,d0c53577,77cce3be). Local: stale-before, recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
466 lines
21 KiB
Cheetah
466 lines
21 KiB
Cheetah
---
|
|
name: autoplan
|
|
preamble-tier: 3
|
|
version: 1.0.0
|
|
description: |
|
|
Auto-review pipeline — reads the full CEO, design, eng, and DX review skills from disk
|
|
and runs them sequentially with auto-decisions using 6 decision principles. Surfaces
|
|
taste decisions (close approaches, borderline scope, outside-review disagreements) at a final
|
|
approval gate. One command, fully reviewed plan out.
|
|
Use when asked to "auto review", "autoplan", "run all reviews", "review this plan
|
|
automatically", or "make the decisions for me".
|
|
Proactively suggest when the user has a plan file and wants to run the full review
|
|
gauntlet without answering 15-30 intermediate questions. (gstack)
|
|
voice-triggers:
|
|
- "auto plan"
|
|
- "automatic review"
|
|
benefits-from: [office-hours]
|
|
triggers:
|
|
- run all reviews
|
|
- automatic review pipeline
|
|
- auto plan review
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Write
|
|
- Edit
|
|
- Glob
|
|
- Grep
|
|
- WebSearch
|
|
- AskUserQuestion
|
|
{{AUTOPLAN_PUBLICATION_HOOK}}
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
{{BASE_BRANCH_DETECT}}
|
|
|
|
## Design Doc Check
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
SLUG=$(~/.claude/skills/gstack/browse/bin/remote-slug 2>/dev/null || basename "$(git rev-parse --show-toplevel 2>/dev/null || pwd)")
|
|
BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null | tr '/' '-' || echo 'no-branch')
|
|
{{DESIGN_DOC_DISCOVERY}}
|
|
```
|
|
If a design doc exists, read it and use its problem statement, constraints, and
|
|
chosen approach as input to the review pipeline.
|
|
|
|
{{BENEFITS_FROM}}
|
|
|
|
# /autoplan — Auto-Review Pipeline
|
|
|
|
Read every CEO, design, DX and eng section from disk at full interactive depth.
|
|
The 6 principles answer intermediate questions; taste goes to one final approval gate.
|
|
|
|
---
|
|
|
|
{{SECTION_INDEX:autoplan}}
|
|
|
|
---
|
|
|
|
## The 6 Decision Principles
|
|
|
|
1. **Choose completeness** — Ship the whole thing. Pick the approach that covers more edge cases.
|
|
2. **Boil lakes** — Fix everything in the blast radius (files modified by this plan + direct importers). Auto-approve expansions that are in blast radius AND < 1 day CC effort (< 5 files, no new infra).
|
|
3. **Pragmatic** — If two options fix the same thing, pick the cleaner one. 5 seconds choosing, not 5 minutes.
|
|
4. **DRY** — Duplicates existing functionality? Reject. Reuse what exists.
|
|
5. **Explicit over clever** — 10-line obvious fix > 200-line abstraction. Pick what a new contributor reads in 30 seconds.
|
|
6. **Bias toward action** — Merge > review cycles > stale deliberation. Flag concerns but don't block.
|
|
|
|
**Conflict resolution (context-dependent tiebreakers):**
|
|
- **CEO phase:** P1 (completeness) + P2 (boil lakes) dominate.
|
|
- **Eng phase:** P5 (explicit) + P3 (pragmatic) dominate.
|
|
- **Design phase:** P5 (explicit) + P1 (completeness) dominate.
|
|
|
|
---
|
|
|
|
## Decision Classification
|
|
|
|
Every auto-decision is classified:
|
|
|
|
**Mechanical** — one clearly right answer. Auto-decide silently.
|
|
Examples: run the outside reviewer when enabled (always yes), run evals (always yes), reduce scope on a complete plan (always no).
|
|
|
|
**Taste** — reasonable people could disagree. Auto-decide with recommendation, but surface at the final gate. Three natural sources:
|
|
1. **Close approaches** — top two are both viable with different tradeoffs.
|
|
2. **Borderline scope** — in blast radius but 3-5 files, or ambiguous radius.
|
|
3. **{{OUTSIDE_LABEL}} disagreements** — the outside reviewer recommends differently and has a valid point.
|
|
|
|
**User Challenge** — {{NATIVE_LABEL}} and {{OUTSIDE_LABEL}} both recommend changing the
|
|
user's stated direction: merge, split, add or remove features/skills/workflows.
|
|
NEVER auto-decide these. At the final approval gate, give:
|
|
the original direction, proposed change, reasoning, blind spots and cost of being
|
|
wrong, using the Phase 4 template. Flag agreed security/feasibility risks explicitly.
|
|
The user's original direction stands unless they approve the change.
|
|
|
|
---
|
|
|
|
## Sequential Execution — MANDATORY
|
|
|
|
Phases MUST execute in strict order: CEO → Design (if UI scope) → DX (if
|
|
developer-facing scope) → Eng. Eng runs LAST, always, reviewing all prior amendments.
|
|
Keep ONE phase active, completing these gates in order:
|
|
1. Load its phase instructions and full skill/sections, recording complete Read ranges.
|
|
On Claude Code, enter through a native `Read` of the installed phase driver,
|
|
then use native `Read` for its methodology ranges. The driver Read is the
|
|
guarded entrypoint. If denied, finish or repair the preceding phase and retry
|
|
that same Read; changing file-loading tools does not satisfy the boundary.
|
|
2. Complete the phase's required preliminary work (CEO: all Step 0, including its
|
|
Spec Review Loop and its amendment checkpoint), then create the fresh snapshot
|
|
and dispatch its nativeDispatchPrompt unchanged.
|
|
3. Consume the native terminal result and apply the phase's failure policy, then
|
|
consume enabled outside results. Complete the phase's remaining primary review
|
|
sections after these results.
|
|
4. At the phase's exit, load its `phase-close` section afresh. Execute its numbered
|
|
operations: prepare the current packet, Read it completely, reconcile it
|
|
semantically, then SEND the parent completion message. Publication is a separate
|
|
operation in that procedure; an earlier Read is not this close.
|
|
5. Only after the message has been sent may the driver load/create/dispatch the
|
|
next phase. Then continue to the next phase's tool calls in the same turn;
|
|
after Eng, proceed to final synthesis/approval. Use the declared skip rule for
|
|
an inapplicable phase; do not load its review or close steps.
|
|
Phase notifications, including skips, are progress updates: do not end the turn
|
|
or wait for a "continue" reply at these boundaries.
|
|
A missing gate means the current phase remains open, even if a reviewer finished.
|
|
Read requests/self-reports and INPUT hashes do not prove uptake or review quality.
|
|
Never draft future-phase reviews or outputs. Headings/promises are not completion.
|
|
After compaction, reload current phase instructions/skill/sections, then
|
|
reconcile saved artifacts and sent conversation messages separately. If closing,
|
|
reload `phase-close` and resume its first incomplete numbered operation;
|
|
regenerate and reread the full packet if the implementation or accepted decisions changed:
|
|
- If a verified phase lacks its announcement, resume the close procedure at step 6 (Publish) before advancing.
|
|
- If its reviewer is pending, wait for that same reviewer.
|
|
- If native dispatch has not happened, finish any incomplete preliminary work before recovering a voice input.
|
|
If the final voice input does not exist, create it after the preliminary gates.
|
|
Read `snapshot.json` beside that final `<PHASE_INPUT>` and use its `nativeDispatchPrompt` unchanged.
|
|
Never dispatch `<CEO_STEP0_CHECKPOINT>`: it is the stable amendment baseline, not current review input.
|
|
`nativePrompt` is the file's review body, not the Agent prompt. Resume at the first incomplete gate.
|
|
|
|
Pending is not unavailable. Never skip native passes/required sections for time,
|
|
context pressure or your own review. Missing outside coverage does not block native
|
|
completion; report accurately. Never read raw agent transcripts.
|
|
|
|
---
|
|
|
|
## What "Auto-Decide" Means
|
|
|
|
Auto-decide replaces the USER'S answer, not ANALYSIS. Run each loaded section at
|
|
full interactive depth; answer AskUserQuestion using the 6 principles.
|
|
|
|
**Default resolution: the recommended option.** Take `(recommended)` or the mode's
|
|
context default. Use the 6 principles for missing recommendations/ties. On principle
|
|
disagreement, take the recommendation and surface the disagreement as Taste at the final gate.
|
|
|
|
**Never auto-decide User Challenges:** both models agree to change the user's
|
|
direction/settled decisions, or a premise is clearly wrong. Use Decision
|
|
Classification; ask once at Final Approval Gate, never mid-run. The user has
|
|
context models lack.
|
|
|
|
Read referenced code/diffs/files; decide every issue. Produce all required
|
|
diagrams, tables, registries and artifacts on disk or in the plan. LOG decisions,
|
|
record ALL accepted obligations below and run `amend-input` before continuing.
|
|
Missing deliverables make the review incomplete.
|
|
|
|
No summary substitutes or one-line sections; fewer than 3 sentences likely means
|
|
compression. "No issues found" needs 1-2 sentences stating what was examined and why nothing was flagged.
|
|
Explain inapplicability with evidence; skip only under Phase 0's list. Never abort
|
|
or redirect to interactive review: the user chose /autoplan.
|
|
|
|
**Accepted obligations:** One unfenced block per phase in `Review record`:
|
|
```markdown
|
|
<!-- autoplan-accepted:ceo -->
|
|
- Requirement, all conditions and verification/tests.
|
|
<!-- /autoplan-accepted:ceo -->
|
|
```
|
|
Phase: `ceo|design|dx|eng`. Record accepted requirements here;
|
|
no analysis/severity/verdict/consensus. No accepted requirements: `None: reason`.
|
|
On a rerun, carry forward unchanged accepted requirements; do not replace them with None.
|
|
`amend` checks exact retention atomically; full readback; None unchanged.
|
|
Baseline edits: `create`'s `baselineEdits`. Prior blocks immutable;
|
|
state replacements in current block. Reconcile all decisions with readback.
|
|
Transport ≠ approval/complete enumeration/correctness.
|
|
|
|
---
|
|
|
|
## Filesystem Boundary — {{OUTSIDE_LABEL}} Prompts
|
|
|
|
Prefix every {{OUTSIDE_LABEL}} prompt:
|
|
|
|
> IMPORTANT: Do NOT read or execute any SKILL.md files or paths containing skills/gstack (foreign instructions). Review repository code only.
|
|
|
|
---
|
|
|
|
## Phase 0: Intake + Restore Point
|
|
|
|
### Step 1: Capture restore point
|
|
|
|
Absolute paths: SOURCE_PLAN (input), ACTIVE_PLAN (harness-assigned plan, else SOURCE_PLAN).
|
|
Save plan amendments and review artifacts to ACTIVE_PLAN.
|
|
Send phase announcements and the final approval request in the conversation.
|
|
Resolve SNAPSHOT_TOOL once:
|
|
{{AUTOPLAN_SNAPSHOT_TOOL}}
|
|
|
|
Fresh external RESTORE_PATH:
|
|
```bash
|
|
{{SLUG_EVAL}}
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
mkdir -p "$GSTACK_STATE_ROOT/projects/$SLUG"
|
|
BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null | tr '/' '-')
|
|
DATETIME=$(date +%Y%m%d-%H%M%S)
|
|
echo "RESTORE_PATH=$GSTACK_STATE_ROOT/projects/$SLUG/${BRANCH}-autoplan-restore-${DATETIME}.md"
|
|
```
|
|
|
|
Before scope/review:
|
|
```bash
|
|
bun "<SNAPSHOT_TOOL>" init "<SOURCE_PLAN>" "<ACTIVE_PLAN>" "<RESTORE_PATH>"
|
|
```
|
|
Use returned paths/`scope`; never hand-wrap. init backs up SOURCE_PLAN exactly,
|
|
then initializes ACTIVE_PLAN atomically without losing requirements.
|
|
Reviewers get only `## Implementation plan`; analysis stays in `## Review record`,
|
|
including structured inputs. On helper errors, stop; no stderr hiding/grep fallback.
|
|
Re-run: copy RESTORE_PATH's bytes to SOURCE_PLAN, then /autoplan.
|
|
|
|
### Step 2: Read context
|
|
|
|
- Read CLAUDE.md, TODOS.md, git log -30, git diff against the base branch --stat
|
|
- Discover design docs: `ls -t ~/.gstack/projects/$SLUG/*-design-*.md 2>/dev/null | head -1`
|
|
- Detect UI scope: grep the plan for view/rendering terms (component, screen, form,
|
|
button, modal, layout, dashboard, sidebar, nav, dialog). Require 2+ matches. Exclude
|
|
false positives ("page" alone, "UI" in acronyms).
|
|
- Use init's full-input `scope`. For changed input or semantic enabling flags, rerun:
|
|
```bash
|
|
bun "<SNAPSHOT_TOOL>" scope "<ACTIVE_PLAN>"
|
|
```
|
|
Use returned `dxRequired` (initially `scope.dxRequired`) and record its input hash/matched terms. The existing
|
|
threshold is 2+ term matches (occurrences, not distinct terms). Also enable DX when the product is a developer tool
|
|
(developers install, integrate or build on it) or an AI agent is the primary user:
|
|
add `--developer-tool` or `--agent-primary` to this command. These flags only enable
|
|
DX; no context label can negate a positive result. Skip DX only when the result is
|
|
false and neither semantic trigger applies.
|
|
|
|
|
|
### Step 3: Locate review skills; load each at phase entry
|
|
|
|
Resolve this phase's source to absolute `<REVIEW_SKILL>`; load via its checkpoint:
|
|
- Phase 1: {{AUTOPLAN_REVIEW_FILE:plan-ceo-review}}
|
|
- Phase 2: {{AUTOPLAN_REVIEW_FILE:plan-design-review}} (only if UI scope detected)
|
|
- Phase 2.5: {{AUTOPLAN_REVIEW_FILE:plan-devex-review}} (only if DX scope detected)
|
|
- Phase 3: {{AUTOPLAN_REVIEW_FILE:plan-eng-review}}
|
|
|
|
Use /autoplan's installed registry; resolve siblings from its discovered SKILL.md
|
|
directory, never cwd/runtime assets. Missing skill: report phase and setup repair,
|
|
without substituting a harness or claiming completion.
|
|
|
|
Read skills/sections only at their triggers, never prefetch future phases. Load
|
|
the tasks aggregator at Phase 4. Run all applicable skills and lazy sections fully.
|
|
|
|
**Section skip list — when following a loaded skill file, SKIP these sections
|
|
(they are already handled by /autoplan):**
|
|
- Preamble (run first)
|
|
- Scope gate (the plan under review is already the target)
|
|
- AskUserQuestion Format
|
|
- Completeness Principle — Boil the Ocean
|
|
- Search Before Building
|
|
- Completion Status Protocol
|
|
- Telemetry (run last)
|
|
- Step 0: Detect base branch
|
|
- Review Readiness Dashboard
|
|
- Plan File Review Report
|
|
- Prerequisite Skill Offer (BENEFITS_FROM)
|
|
- Outside Voice — Independent Plan Challenge
|
|
- Design Outside Voices (parallel)
|
|
|
|
Follow ONLY the review-specific methodology, sections, and required outputs.
|
|
|
|
Output: "Here's what I'm working with: [plan summary]. UI scope: [yes/no]. DX scope: [yes/no].
|
|
Review skills will load at each phase entry. Starting full review pipeline with auto-decisions."
|
|
|
|
---
|
|
|
|
## Phase 0.5: Outside reviewer preflight
|
|
|
|
{{OUTSIDE_PREFLIGHT:autoplan}}
|
|
|
|
Disabled/unavailable retains applicable native passes. Recheck each outside dispatch.
|
|
Record provider and completed/unavailable/disabled/skipped per phase; CEO covers
|
|
only CEO. Missing voices: N/A, never CONFIRMED. Skipped scope stays skipped.
|
|
|
|
|
|
## Phase 1: CEO Review (Strategy & Scope)
|
|
|
|
{{SECTION:ceo-phase}}
|
|
|
|
---
|
|
|
|
## Phase 2: Design Review (conditional — skip if no UI scope)
|
|
|
|
**Skip condition:** If UI scope was NOT detected in Phase 0, skip this phase
|
|
entirely — do NOT read its section. Send: "Phase 2 skipped — no UI scope detected."
|
|
Record the skip in ACTIVE_PLAN; it is not a completed review.
|
|
|
|
{{SECTION:design-phase}}
|
|
|
|
---
|
|
|
|
## Phase 2.5: DX Review (conditional — skip if no developer-facing scope)
|
|
|
|
**Skip condition:** If DX scope was NOT detected in Phase 0, skip this phase
|
|
entirely — do NOT read its section. Send: "Phase 2.5 skipped — no developer-facing scope detected."
|
|
Record the skip in ACTIVE_PLAN; it is not a completed review.
|
|
|
|
{{SECTION:dx-phase}}
|
|
|
|
---
|
|
|
|
## Phase 3: Eng Review + Dual Voices (always runs, always LAST — the required gate reviews the final amended plan)
|
|
|
|
{{SECTION:eng-phase}}
|
|
|
|
---
|
|
|
|
## Decision Audit Trail
|
|
|
|
Immediately after each auto-decision, append one row to the plan file using Edit:
|
|
|
|
```markdown
|
|
<!-- AUTONOMOUS DECISION LOG -->
|
|
## Decision Audit Trail
|
|
|
|
| # | Phase | Decision | Classification | Principle | Rationale | Rejected |
|
|
|---|-------|----------|-----------|-----------|----------|
|
|
```
|
|
|
|
---
|
|
|
|
## Pre-Gate Verification
|
|
|
|
Check the plan and conversation for every applicable deliverable:
|
|
|
|
| Phase | Required outputs |
|
|
|---|---|
|
|
| CEO | Named premise challenges; findings or explicit examination/no-findings for every applicable section; Error & Rescue and Failure Modes registries (or N/A with reason); NOT in scope; What already exists; dream state delta; Completion Summary; consensus table. |
|
|
| Design, if UI | Scores for all 7 dimensions; identified and decided issues; litmus scorecard. |
|
|
| DX, if developer-facing | Scores for all 8 dimensions; developer journey map; empathy narrative; TTHW assessment and target; DX Implementation Checklist; consensus table. |
|
|
| Eng, always last | Scope challenge grounded in code; architecture ASCII diagram; codepath-to-test diagram; test plan on disk at ~/.gstack/projects/$SLUG/; NOT in scope; What already exists; failure modes registry with critical gaps; Completion Summary; consensus table. |
|
|
|
|
For each phase, verify native and outside voice results or explicit
|
|
unavailable/skipped status. Verify cross-phase themes and at least one Decision
|
|
Audit Trail row per auto-decision. Produce missing outputs before the gate; after
|
|
at most 2 repair attempts, warn at the gate with each still-incomplete item.
|
|
|
|
---
|
|
|
|
## Phase 4: Final Approval Gate
|
|
|
|
{{SECTION:tasks-aggregator}}
|
|
|
|
**STOP here and present the final state to the user.**
|
|
|
|
Present this message, then use AskUserQuestion:
|
|
|
|
```
|
|
## /autoplan Review Complete
|
|
|
|
### Plan Summary
|
|
[1-3 sentence summary]
|
|
|
|
### Decisions Made: [N] total ([M] auto-decided, [K] taste choices, [J] user challenges)
|
|
|
|
### User Challenges (both models disagree with your stated direction)
|
|
For each: **Challenge [N]: [title]** (from [phase]); You said: [original];
|
|
Both models recommend: [change]; Why: [reasoning]; What we might be missing:
|
|
[blind spots]; If wrong: [cost]. If security/feasibility, say both models flag
|
|
that risk. Your original direction stands unless you explicitly change it.
|
|
|
|
### Your Choices (taste decisions)
|
|
For each: **Choice [N]: [title]** (from [phase]). Recommend [X] — [principle].
|
|
Name the viable alternative and its downstream impact.
|
|
|
|
### Auto-Decided: [M] decisions [see Decision Audit Trail in plan file]
|
|
|
|
### Review Scores
|
|
CEO, Design, DX and Eng: phase summary plus {{OUTSIDE_LABEL}}, {{NATIVE_LABEL}}
|
|
and consensus status; say skipped where a phase did not run.
|
|
|
|
### Cross-Phase Themes
|
|
List concerns independently raised in 2+ phases. If none: "No cross-phase themes — each phase's concerns were distinct."
|
|
|
|
### Deferred to TODOS.md
|
|
[Items auto-deferred with reasons]
|
|
|
|
### Implementation Tasks (aggregated across phases)
|
|
[Substitute $AGGREGATED_TASKS. If empty: "_No per-phase task lists found in $TASKS_DIR for branch $BRANCH._"]
|
|
```
|
|
|
|
**Cognitive load:** skip empty User Challenges / Your Choices. Use a flat list
|
|
for 1-7 taste decisions; group 8+ by phase and warn that ambiguity is high.
|
|
|
|
AskUserQuestion options:
|
|
- A) Approve as-is
|
|
- B) Approve with overrides
|
|
- B2) Resolve user challenges
|
|
- C) Interrogate
|
|
- D) Revise
|
|
- E) Reject
|
|
|
|
**Option handling:**
|
|
- A: mark APPROVED, write review logs, suggest /ship
|
|
- B: ask which overrides, apply, then follow D's affected-phase rerun rule (including Eng last) before re-presenting the gate. Counts toward the same 3-cycle cap as D.
|
|
- B2: accept/reject User Challenges one at a time; rejected ones preserve the user's direction. Re-run Eng, then re-present the gate.
|
|
- C: answer freeform, re-present gate
|
|
- D: make changes, re-run affected phases (scope→1, design→2, dx→2.5, test plan→3, arch→3; a re-run of any earlier phase re-runs Eng after it — the gate always reviews the final plan). Max 3 cycles.
|
|
- E: start over
|
|
|
|
**Starting an affected-phase rerun:** Keep the current Implementation plan and all
|
|
prior accepted obligations intact. Move that phase's already-applied
|
|
`autoplan-baseline-edits` record verbatim into fenced history in Review record,
|
|
retaining its original source SHA.
|
|
Create a fresh amendment checkpoint. For new baseline edits, use `create`'s
|
|
`baselineEdits.record` and `sourceSha256`; review projection hash is not baseline
|
|
identity. Carry forward unchanged accepted requirements. Never replay old
|
|
replacements or rewrite historical source SHA. This starts a new phase invocation;
|
|
compaction resumes the existing invocation and checkpoint. Eng still runs last.
|
|
|
|
---
|
|
|
|
## Completion: Write Review Logs
|
|
|
|
On approval, log each completed review for /ship's dashboard. Replace TIMESTAMP,
|
|
STATUS and N with actual phase values. STATUS is "clean" or "issues_open".
|
|
|
|
```bash
|
|
COMMIT=$(git rev-parse --short HEAD 2>/dev/null)
|
|
TIMESTAMP=$(date -u +%Y-%m-%dT%H:%M:%SZ)
|
|
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-ceo-review","timestamp":"'"$TIMESTAMP"'","status":"STATUS","unresolved":N,"critical_gaps":N,"mode":"SELECTIVE_EXPANSION","via":"autoplan","commit":"'"$COMMIT"'"}'
|
|
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-eng-review","timestamp":"'"$TIMESTAMP"'","status":"STATUS","unresolved":N,"critical_gaps":N,"issues_found":N,"mode":"FULL_REVIEW","via":"autoplan","commit":"'"$COMMIT"'"}'
|
|
```
|
|
|
|
If Phase 2 ran (UI scope):
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-design-review","timestamp":"'"$TIMESTAMP"'","status":"STATUS","unresolved":N,"via":"autoplan","commit":"'"$COMMIT"'"}'
|
|
```
|
|
|
|
If Phase 2.5 ran (DX scope):
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-devex-review","timestamp":"'"$TIMESTAMP"'","status":"STATUS","initial_score":N,"overall_score":N,"product_type":"TYPE","tthw_current":"TTHW","tthw_target":"TARGET","unresolved":N,"via":"autoplan","commit":"'"$COMMIT"'"}'
|
|
```
|
|
|
|
Dual voice logs: write one record per PHASE (`ceo`, `design`, `dx`, `eng`) with
|
|
that phase's status/counts. Generate one AUTOPLAN_RUN_ID and share it with TIMESTAMP.
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"autoplan-voices","run_id":"AUTOPLAN_RUN_ID","timestamp":"'"$TIMESTAMP"'","status":"STATUS","source":"SOURCE","host":"{{HOST_ID}}","outside_provider":"{{OUTSIDE_PROVIDER}}","outside_status":"OUTSIDE_STATUS","phase":"PHASE","via":"autoplan","consensus_confirmed":N,"consensus_disagree":N,"commit":"'"$COMMIT"'"}'
|
|
```
|
|
|
|
Always log skipped Design/DX: status/outside_status "skipped", source "none",
|
|
zero consensus counts. SOURCE = "{{OUTSIDE_PROVIDER}}" only for completed external
|
|
output; native results use "in-host". OUTSIDE_STATUS is completed, unavailable,
|
|
disabled or skipped. Never carry success across phases/runs; preserve modelUsage.
|
|
|
|
{{OUTSIDE_PROVENANCE:autoplan}}
|
|
|
|
Present a phase coverage table (CEO, design, DX, eng): host, outside provider/status,
|
|
native completion, findings, and partial coverage. Replace N with actual counts.
|
|
|
|
Suggest next step: `/ship` when ready to create the PR.
|