mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-06 03:16:56 +02:00
* refactor(resolvers): split review.ts into MECE resolver modules (pure move) Move every function from scripts/resolvers/review.ts, unchanged, into: - review-dashboard.ts: review dashboard, plan-file review report - plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery, plan-completion audit/gate (ship + review), plan verification exec - spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause - outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan review, Codex doc review, disabled-outside record - review-scope.ts: scope drift, cross-review dedup, shared-code reuse review.ts is deleted; index.ts imports the new modules. gen-skill-docs output is byte-identical for every host (--host all). Test imports and source-path references are re-pointed; the two source-text report/gate tests in gen-skill-docs.test.ts become behavioral renders across every consuming skill and host. All 46 touchfile entries that named review.ts now name all five modules, guarded by a recorded selection golden. * test(browse): black-box auth matrix for every server route and both surfaces Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token, root token, scoped token and the SSE cookie for all 33 routes, plus unmatched paths and wrong methods. Denials assert today's exact status, body and content type; allowed credentials assert the handler was reached. Written against the unchanged if-chain server so the W3 route-table refactor must keep it green. * refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts The shared shard engine grows from the existing strict-output module (runShardChild, killProcessGroup, signal forwarding, strict classifier). scripts/test-strict-output.ts stays as a re-export so existing importers, mock.module paths and the strict-output/run-shard-child tests are unchanged. The engine inherits the global touchfile entry; the free runner's CLI-routing fixture copies the new module. * refactor(resolvers): decompose the three >150-line review resolvers (output-neutral) Split generateAdversarialStep, generateCodexPlanReview and generatePlanCompletionAuditInner into per-section helpers whose template literals are copied verbatim, so every function in the new modules is at or under 150 lines. gen-skill-docs output is byte-identical for every host (--host all, compared against96764e80with a fixed --link-root). * refactor(resolvers): one outside-voice failure policy (deliberate prose unification) outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the auth / timeout / empty-response bullets for all four call sites that hand-typed them (Codex second opinion, adversarial step, Codex plan review, design outside voices). Options are explicit per site (timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no defaults. Deliberate generated-prose changes (every host): - office-hours: 'Fall back to <native> subagent.' becomes 'Fall back to the <native> subagent below.' - plan-devex-review: the plain 'Auth failure (stderr contains ...)' bullets become the canonical bold bullets; auth also triggers on 'API key'; 'auth failed' becomes 'authentication failed'. - review/ship adversarial: 'exceeded 9 minutes and was terminated' becomes 'timed out after 9 minutes and was terminated'; the timeout is still MISSING COVERAGE. - design outside voices: unchanged. Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE retention test, refreshed codex/factory ship goldens, and outside-voice.ts in every touchfile entry of review.ts and design.ts (selection golden extended). * test(pty): fake PTY session driver with an injectable clock through the runner launch seam The three plan-skill runners take an optional PtyDriver (launch, now, monotonic, sleep); omitted, they use the real launcher and clocks exactly as before. test/helpers/pty/fake-session.ts feeds scripted frames through that seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting and floor for success, deadline timeout, permission prompt and plan-ready outcomes with no CLI or real timers. These cases must stay green unchanged through the W4 split and the runPtySession extraction. Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now also lists test/helpers/pty/**. * refactor(shard-engine): run both lanes on the shared engine; lane policy injected Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard tmp/Chromium sandbox + async cleanup backstop, log-path allocation and full-stream log capture, one duration-seed reader/writer with a lane predicate, LanePolicy (seed predicate + zero-execution verdict), strictShardStatus, and the shared CLI flag loop. runShardChild takes an optional companion (signal/settle) and waits a bounded 250ms to reap a wall-killed child. Free lane stops spawning shards itself: runFreeShard uses runShardChild with trackShardBrowser as the companion (win32 path unchanged: no process group, no negative-pid kill). Its sync state-dir removal stays lane policy. Paid lane uses the sandbox, log, seed, verdict and flag primitives; the hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged (free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds, warning under selection and passed-empty under EVALS_ALL). paid-free-boundary's closure assertion now names the engine module, where the strict classifier lives. * test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity - test/shard-engine.test.ts: failing/unhandled/module-load output fails both lanes, per-lane zero-execution and seed rules, whole-group kill on a wall timeout (both lanes), mocked-win32 path with no negative-pid kill, companion settle order, log capture, sandbox isolation, flag loop. - test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence: seven outcome fixtures plus one real shard, run through both lanes and compared with classifications recorded from the base runners (96764e80). - test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set, defaults, validation errors and the Unknown argument error per lane match the base runners. * refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines Output-neutral extraction under the fixture-corpus equivalence and runner tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free); paidShardCommand, settleShardSpool, settleBootstrapRetention and printLogTail (paid). The bootstrap scope-creation block that bootstrap-retention.test.ts evaluates stays verbatim. * refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel Pure move: every line of the former 5,047-line runner lands verbatim in one module (four private helpers gain `export` for cross-module use): binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it), launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries, runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the original public surface by name; pty/ modules import siblings directly. Tests that read the runner's source text: - rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv: fallback chain, --model before extraArgs, hermetic --strict-mcp-config), pty-skill-seeding-wiring (runners through the fake driver; launcher through a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model" grep is replaced by the runners' fake-driver launch assertions. - pty-screen-session / pty-screen-supervision: stop copying runner source; they mock.module the real pty/screen.ts (and the fixture cleanup) instead. - re-pointed to the owning module (they execute a sliced runner body with injected boundaries; no seam exists for those boundaries yet): eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication, plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts and scans every pty/ module for raw process.env spreads. - plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts. * test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and top-level function lengths by brace matching over masked source (strings, comments, regex literals and template text masked; ${} expressions kept), covering function declarations, arrow functions assigned to consts and route-table handler properties, with no parser dependency. Its self-test uses template literals and code-fence braces copied from scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and records the residual runner sizes (free 2352, paid 1921) as non-growth caps; allowlist entries are keyed on file plus matched text and need a reason. Failure output lists file:line, the rule, Fix: and the allowlist path. touchfiles.test.ts gains the moved-code superset check over test/fixtures/touchfile-move-goldens/ (W2 golden recorded at96764e80: test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none). * refactor(browse): declared route table replaces the buildFetchHandler if-chain The ~1,300-line if-chain in buildFetchHandler becomes a route table: each entry declares method, path, auth kind and surfaces, and one auth gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer, scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token required; extension-origin: 403 Forbidden). Unmatched requests take the declared fallthrough (root-bearer check, then plain-text 404). Handlers move to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files, inspector}.ts and receive a RouteContext with auth checks as functions instead of closing over factory locals. Dispatch order is unchanged: tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a literal in server.ts. Behavior-preserving: the black-box auth matrix from the previous commit passes unchanged. /memory and /inspector/events are declared root-bearer because the blanket check always ran before their SSE-cookie branch. Source-text route tests are rewritten as behavioral tests through buildFetchHandler or a route's real handler with a stub RouteContext (browse/test/route-test-harness.ts). Checks with no runtime seam are re-pointed to the route modules: Surface type, /inspector/events SSE helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import, and the ngrok config lookup and startTunnel wiring that stay in server.ts. * test(browse): stubbed-handler auth matrix and route inventory for the route table Every ROUTES entry runs through the real dispatcher and gate with stub handlers on each declared surface and six credentials; denials assert the exact status and body each auth kind returned at96764e8, admitted credentials assert the handler ran (with the gate's TokenInfo for scoped routes). Also pins the reviewed route inventory (method, path, auth kind, surfaces), that every entry declares auth and surfaces, that the table's tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the unmatched fallthrough, and that the root token is rejected on every tunnel route through buildFetchHandler. * test(browse): ratchet (b) keeps route dispatch inside the route table Scans browse/src/server.ts and browse/src/routes/*.ts for pathname comparisons; only the table matcher and the tunnel-surface filter are allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json (keyed on file plus line text). Also checks every entry declares auth and surfaces and that gstack registers no beforeRoute overlay itself. Self-tests plant a violation and assert the file:line, Fix: and allowlist path in the message, that a shifted line stays allowlisted, and that a reasonless entry is rejected. * test: touchfile superset check for modules moved out of browse/src/server.ts Records the paid evals selected by touching browse/src/server.ts at96764e80(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects a superset. The test reads every golden in test/fixtures/moved-module-selection/ so other moved-code goldens can sit beside it. * test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded host cannot turn a pass into a timeout. Base and branch runners still agree on every classification under the new walls. The Windows exclusion entry moves the free runner's ratchet (c) residual cap to 2356 lines. * refactor(pty): one runPtySession loop drives observation, counting and floor test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* -> timeout and the failure contract the three runners each hand-rolled: the run's own error wins over capture and close errors, close always runs, owned fixture cleanup runs last (also when launch fails). Each runner now supplies a PtySessionPlan: its boot/command step, poll cadence (2s observation/floor sleep; counting's output wake + 250ms coalesce), tick policy (permission handling, native identity, terminal rules stay per runner because they differ) and capture hooks. The runner bodies are decomposed into top-level steps so no function exceeds 150 lines; behavior is unchanged and the fake-driver cases from the first W4 commit pass unmodified. The counting capture step and the native completion-summary predicate are now named functions (countingCapture, isNativeCompletionSummary), so plan-create-prepublication and plan-count-completion call them directly instead of executing sliced source. The two harnesses that still execute a sliced runner body with injected boundaries (eng-seeded-completion-ai, plan-floor-permission) pass the PtyDriver seam instead of overriding Date/Bun.sleep. * test(ratchet-c): register route modules, review resolver modules and server.ts residual cap * refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines launchClaudePty (349 lines) becomes launch preparation (args, hermetic child env, owned state roots), recorder creation, spawn, the trust-dialog watcher, close, and the session handle over one PtyProcess state object. The failure order is unchanged: abort the viewport, dispose any recorders created so far, dispose the viewport, rethrow. The --model / --strict-mcp-config ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests. engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each self-contained issue family (declared cache, library retry hooks, cache owner, injected singleton, shared writers, injected export) moves verbatim into its own function. Every pty/ module is now <= 800 lines and every top-level function <= 150 lines. * test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams The 188 unit tests move verbatim into claude-pty-runner.{screen,classify, auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each file imports only what it uses from the barrel). The five files that no longer read a SKILL.md template join the test-of-test ratchet baseline with a reason. * test(touchfiles): moved PTY modules keep their paid-eval selection test/fixtures/touchfile-selection/w4-pty.json records, at96764e8, the paid evals selected by touching test/helpers/claude-pty-runner.ts (20) and test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file under test/helpers/pty/ (and pty/screen.ts for both sources) selects a superset, reading every golden in that directory so later moves can add one; a planted-violation case pins the report and its Fix line. * fix(browse): unexchanged pair setup keys no longer authenticate bearer requests validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and /file (found while building the W3 auth matrix). A setup key now only authenticates the /connect exchange. * W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests * W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design, ios-qa daemon, lib and scripts resolve the state root through bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the twin and stop with a reinstall message when it is missing; hooks source it and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts delegate to resolveStateRoot. Analytics writers and readers move together so the usage log stays one file. gstack-uninstall deletes state only at ~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor, the checkout or the git root, and leaves any other resolved root in place with the removal command. Fixtures that copy single bins now copy the twin. * W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity readConfigKey / gstack_read_config_key return the most restrictive telemetry, memorable_recall, codex_reviews and update_check across the resolved root and ~/.gstack; other keys read the resolved root only. gstack-config set reports an overriding root with the exact override command, list shows the winning root and a root-variable disagreement line. gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress reads through readConfigKey. test-setup.ts strips inherited GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root. * W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts) One hook-errors.log writer: root from resolveStateRoot, 0600 on every append, opt-in rate limit used only by memorable-user-prompt. The five hooks route through it. * W1: docs/state-root.md and README troubleshooting pointer Precedence table, a real --explain example, the move-your-state recipe, merged privacy keys, the uninstall rule, the resolver-failure fix, and the plugin-mode note (evidence gate: no official plugin distribution). * W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a) Every gstack-paths eval in templates and resolvers carries the fail-stop guard; executable ~/.gstack paths in bash blocks (context recovery preamble, eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock, retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE. ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex), ship goldens re-pinned, parity and context-budget caps raised to the measured sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a reasoned allowlist; W1 touchfile entries plus a superset golden. * refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams * test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps * v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave * test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture * fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees * fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity) * test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck * test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case * fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped * fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks) * test(qa-callers): disable git auto maintenance in the caller fixture Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git 2.55 it rewrote .git/objects fan-out directories while the write observer was running, which surfaced as unauthorized mutations. Same gc.auto=0 / maintenance.auto=false guard the shared-libs fixture already uses. * test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked * test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files) The doc-sync fault cases replayed attempt 1 before reaching their gate and ran out of their 285s budget. The fixture now seeds attempt 1 and the parent starts at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave (fb526898,e6ac813d,6ce10ff7,d0c53577,77cce3be). Local: stale-before, recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
374 lines
15 KiB
Cheetah
374 lines
15 KiB
Cheetah
---
|
|
name: design-shotgun
|
|
preamble-tier: 2
|
|
version: 1.0.0
|
|
description: |
|
|
Design shotgun: generate multiple AI design variants, open a comparison board,
|
|
collect structured feedback, and iterate. Standalone design exploration you can
|
|
run anytime. Use when: "explore designs", "show me options", "design variants",
|
|
"visual brainstorm", or "I don't like how this looks".
|
|
Proactively suggest when the user describes a UI feature but hasn't seen
|
|
what it could look like. (gstack)
|
|
triggers:
|
|
- explore design variants
|
|
- show me design options
|
|
- visual design brainstorm
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Glob
|
|
- Grep
|
|
- Agent
|
|
- AskUserQuestion
|
|
gbrain:
|
|
schema: 1
|
|
context_queries:
|
|
- id: prior-approved-variants
|
|
kind: filesystem
|
|
glob: "{gstack_state_root}/projects/{repo_slug}/designs/*/approved.json"
|
|
sort: mtime_desc
|
|
limit: 5
|
|
render_as: "## Prior approved design variants for this project"
|
|
- id: design-md
|
|
kind: filesystem
|
|
glob: "DESIGN.md"
|
|
tail: 1
|
|
render_as: "## DESIGN.md (project design system)"
|
|
- id: recent-design-docs
|
|
kind: filesystem
|
|
glob: "~/.gstack/projects/{repo_slug}/*-design-*.md"
|
|
sort: mtime_desc
|
|
limit: 3
|
|
render_as: "## Recent design docs"
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
# /design-shotgun: Visual Design Exploration
|
|
|
|
You are a design brainstorming partner. Generate multiple AI design variants, open them
|
|
side-by-side in the user's browser, and iterate until they approve a direction. This is
|
|
visual brainstorming, not a review process.
|
|
|
|
---
|
|
|
|
{{SECTION_INDEX:design-shotgun}}
|
|
|
|
---
|
|
|
|
{{DESIGN_SETUP}}
|
|
|
|
{{SECTION:doctrine}}
|
|
|
|
## Step 0: Session Detection
|
|
|
|
Check for prior design exploration sessions for this project:
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true
|
|
_PREV=$(find "$GSTACK_STATE_ROOT/projects/$SLUG/designs/" -name "approved.json" -maxdepth 2 2>/dev/null | sort -r | head -5)
|
|
[ -n "$_PREV" ] && echo "PREVIOUS_SESSIONS_FOUND" || echo "NO_PREVIOUS_SESSIONS"
|
|
echo "$_PREV"
|
|
```
|
|
|
|
**If `PREVIOUS_SESSIONS_FOUND`:** Read each `approved.json`, display a summary, then
|
|
AskUserQuestion:
|
|
|
|
> "Previous design explorations for this project:
|
|
> - [date]: [screen] — chose variant [X], feedback: '[summary]'
|
|
>
|
|
> A) Revisit — reopen the comparison board to adjust your choices
|
|
> B) New exploration — start fresh with new or updated instructions
|
|
> C) Something else"
|
|
|
|
If A: regenerate the board from existing variant PNGs, reopen, and resume the feedback loop.
|
|
If B: proceed to Step 1.
|
|
|
|
**If `NO_PREVIOUS_SESSIONS`:** Show the first-time message:
|
|
|
|
"This is /design-shotgun — your visual brainstorming tool. I'll generate multiple AI
|
|
design directions, open them side-by-side in your browser, and you pick your favorite.
|
|
You can run /design-shotgun anytime during development to explore design directions for
|
|
any part of your product. Let's start."
|
|
|
|
## Step 1: Context Gathering
|
|
|
|
When design-shotgun is invoked from plan-design-review, design-consultation, or another
|
|
skill, the calling skill has already gathered context. Check for `$_DESIGN_BRIEF` — if
|
|
it's set, skip to Step 2.
|
|
|
|
When run standalone, gather context to build a proper design brief.
|
|
|
|
**Required context (5 dimensions):**
|
|
1. **Who** — who is the design for? (persona, audience, expertise level)
|
|
2. **Job to be done** — what is the user trying to accomplish on this screen/page?
|
|
3. **What exists** — what's already in the codebase? (existing components, pages, patterns)
|
|
4. **User flow** — how do users arrive at this screen and where do they go next?
|
|
5. **Edge cases** — long names, zero results, error states, mobile, first-time vs power user
|
|
|
|
**Auto-gather first:**
|
|
|
|
```bash
|
|
cat DESIGN.md 2>/dev/null | head -80 || echo "NO_DESIGN_MD"
|
|
cat PRODUCT.md 2>/dev/null | head -120 || echo "NO_PRODUCT_MD"
|
|
```
|
|
|
|
A `PRODUCT.md` (impeccable's product-context file) answers the job-to-be-done and audience questions: confirm, do not re-ask. Never open `.claude/skills/impeccable/**`.
|
|
|
|
```bash
|
|
ls src/ app/ pages/ components/ 2>/dev/null | head -30
|
|
```
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true
|
|
ls "$GSTACK_STATE_ROOT"/projects/$SLUG/*office-hours* 2>/dev/null | head -5
|
|
```
|
|
|
|
If DESIGN.md exists, tell the user: "I'll follow your design system in DESIGN.md by
|
|
default. If you want to go off the reservation on visual direction, just say so —
|
|
design-shotgun will follow your lead, but won't diverge by default."
|
|
|
|
**Check for a live site to screenshot** (for the "I don't like THIS" use case):
|
|
|
|
```bash
|
|
curl -s -o /dev/null -w "%{http_code}" http://localhost:3000 2>/dev/null || echo "NO_LOCAL_SITE"
|
|
```
|
|
|
|
If the user referenced a URL or said something like "I don't like how this looks,"
|
|
screenshot that page with Aside in Step 3c and use `$D evolve` instead of `$D variants`
|
|
to generate improvement variants from the existing design. If they didn't name the URL,
|
|
ask for it — never guess which page they mean. If the probe above printed `200`, offer
|
|
`http://localhost:3000` as the default in the AskUserQuestion below (still ask — never assume).
|
|
|
|
**AskUserQuestion with pre-filled context:** Pre-fill what you inferred from the codebase,
|
|
DESIGN.md, and office-hours output. Then ask for what's missing. Frame as ONE question
|
|
covering all gaps:
|
|
|
|
> "Here's what I know: [pre-filled context]. I'm missing [gaps].
|
|
> Tell me: [specific questions about the gaps].
|
|
> How many variants? (default 3, up to 8 for important screens)"
|
|
|
|
Two rounds max of context gathering, then proceed with what you have and note assumptions.
|
|
|
|
## Step 2: Taste Memory
|
|
|
|
Read both the persistent taste profile (cross-session) AND the per-session approved
|
|
designs to bias generation toward the user's demonstrated taste.
|
|
|
|
**Persistent taste profile (v1 schema at `~/.gstack/projects/$SLUG/taste-profile.json`):**
|
|
|
|
{{TASTE_PROFILE}}
|
|
|
|
**Per-session approved.json files (legacy, still supported):**
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true
|
|
_TASTE=$(find "$GSTACK_STATE_ROOT/projects/$SLUG/designs/" -name "approved.json" -maxdepth 2 2>/dev/null | sort -r | head -10)
|
|
```
|
|
|
|
If prior sessions exist, read each `approved.json` and extract patterns from the
|
|
approved variants. Merge these into the taste-profile.json-derived signal — if the
|
|
profile already says "user prefers Geist font" (from aggregated history), the
|
|
approved.json files add the specific recent approval context.
|
|
|
|
Limit to last 10 sessions. Try/catch JSON parse on each (skip corrupted files).
|
|
|
|
**Updating taste profile after a design-shotgun session:** When the user picks a
|
|
variant, call `{{BIN_DIR}}/gstack-taste-update approved <variant-path>`. When they
|
|
explicitly reject a variant, call `{{BIN_DIR}}/gstack-taste-update rejected <variant-path>`.
|
|
The CLI handles schema migration from approved.json, decay, and conflict flagging.
|
|
|
|
## Step 3: Generate Variants
|
|
|
|
Set up the output directory:
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
_DESIGN_DIR="$GSTACK_STATE_ROOT/projects/$SLUG/designs/<screen-name>-$(date +%Y%m%d)"
|
|
mkdir -p "$_DESIGN_DIR"
|
|
echo "DESIGN_DIR: $_DESIGN_DIR"
|
|
```
|
|
|
|
Replace `<screen-name>` with a descriptive kebab-case name from the context gathering.
|
|
|
|
### Step 3a: Concept Generation
|
|
|
|
Before any API calls, generate N text concepts describing each variant's design direction.
|
|
Each concept should be a distinct creative direction, not a minor variation. Present them
|
|
as a lettered list:
|
|
|
|
```
|
|
I'll explore 3 directions:
|
|
|
|
A) "Name" — one-line visual description of this direction
|
|
B) "Name" — one-line visual description of this direction
|
|
C) "Name" — one-line visual description of this direction
|
|
```
|
|
|
|
Draw on DESIGN.md, taste memory, and the user's request to make each concept distinct.
|
|
|
|
**Anti-convergence directive (hard requirement):** Each variant MUST use a different
|
|
font family, color palette, and layout approach. If two variants look like siblings
|
|
— same typographic feel, overlapping color temperature, comparable layout rhythm —
|
|
one of them failed. Regenerate the weaker one with a deliberately different direction.
|
|
|
|
Concrete test: if someone could swap the headline text between two variants without
|
|
noticing, they're too similar. Variants should feel like they came from three
|
|
different design teams, not the same team at three different coffee levels.
|
|
|
|
### Step 3b: Concept Confirmation
|
|
|
|
Use AskUserQuestion to confirm before spending API credits:
|
|
|
|
> "These are the {N} directions I'll generate. Each takes ~60s, but I'll run them all
|
|
> in parallel so total time is ~60 seconds regardless of count."
|
|
|
|
Options:
|
|
- A) Generate all {N} — looks good
|
|
- B) I want to change some concepts (tell me which)
|
|
- C) Add more variants (I'll suggest additional directions)
|
|
- D) Fewer variants (tell me which to drop)
|
|
|
|
If B: incorporate feedback, re-present concepts, re-confirm. Max 2 rounds.
|
|
If C: add concepts, re-present, re-confirm.
|
|
If D: drop specified concepts, re-present, re-confirm.
|
|
|
|
### Step 3c: Parallel Generation
|
|
|
|
**If evolving from a screenshot** (user said "I don't like THIS"), take ONE screenshot
|
|
of the page the user named, in Aside (PNG — `$D evolve` reads PNG):
|
|
|
|
```bash
|
|
aside repl '
|
|
const pg = await openTab("<url>");
|
|
await pg.screenshot({ path: "current.png", type: "png", fullPage: true });
|
|
console.log("ASIDE_DIR=" + pwd);
|
|
await closeTab(pg);
|
|
console.log("GSTACK_STEP_OK");
|
|
'
|
|
```
|
|
|
|
Then `cp "<ASIDE_DIR>/current.png" "$_DESIGN_DIR/current.png"` and Read it so the user
|
|
sees what you're evolving from.
|
|
|
|
**Launch N Agent subagents in a single message** (parallel execution). Use the Agent
|
|
tool with `subagent_type: "general-purpose"` and `run_in_background: false` for each
|
|
variant (parallel foreground calls in one message still run concurrently; subagents
|
|
default to background since Claude Code v2.1.198, and the comparison board needs every
|
|
variant's result). Each agent is independent
|
|
and handles its own generation, quality check, verification, and retry.
|
|
|
|
**Important: $D path propagation.** The `$D` variable from DESIGN SETUP is a shell
|
|
variable that agents do NOT inherit. Substitute the resolved absolute path (from the
|
|
`DESIGN_READY: /path/to/design` output in Step 0) into each agent prompt.
|
|
|
|
**Agent prompt template** (one per variant, substitute all `{...}` values):
|
|
|
|
```
|
|
Generate a design variant and save it.
|
|
|
|
Design binary: {absolute path to $D binary}
|
|
Brief: {the full variant-specific brief for this direction}
|
|
Output: /tmp/variant-{letter}.png
|
|
Final location: {_DESIGN_DIR absolute path}/variant-{letter}.png
|
|
|
|
Steps:
|
|
1. Run: {$D path} generate --brief "{brief}" --output /tmp/variant-{letter}.png
|
|
2. If the command fails with a rate limit error (429 or "rate limit"), wait 5 seconds
|
|
and retry. Up to 3 retries.
|
|
3. If the output file is missing or empty after the command succeeds, retry once.
|
|
4. Copy: cp /tmp/variant-{letter}.png {_DESIGN_DIR}/variant-{letter}.png
|
|
5. Quality check: {$D path} check --image {_DESIGN_DIR}/variant-{letter}.png --brief "{brief}"
|
|
If quality check fails, retry generation once.
|
|
6. Verify: ls -lh {_DESIGN_DIR}/variant-{letter}.png
|
|
7. Report exactly one of:
|
|
VARIANT_{letter}_DONE: {file size}
|
|
VARIANT_{letter}_FAILED: {error description}
|
|
VARIANT_{letter}_RATE_LIMITED: exhausted retries
|
|
```
|
|
|
|
For the evolve path, replace step 1 with:
|
|
```
|
|
{$D path} evolve --screenshot {_DESIGN_DIR}/current.png --brief "{brief}" --output /tmp/variant-{letter}.png
|
|
```
|
|
|
|
**Why /tmp/ then cp?** In observed sessions, `$D generate --output ~/.gstack/...`
|
|
failed with "The operation was aborted" while `--output /tmp/...` succeeded. This is
|
|
a sandbox restriction. Always generate to `/tmp/` first, then `cp`.
|
|
|
|
### Step 3d: Results
|
|
|
|
After all agents complete:
|
|
|
|
1. Read each generated PNG inline (Read tool) so the user sees all variants at once.
|
|
2. Report status: "All {N} variants generated in ~{actual time}. {successes} succeeded,
|
|
{failures} failed."
|
|
3. For any failures: report explicitly with the error. Do NOT silently skip.
|
|
4. If zero variants succeeded: fall back to sequential generation (one at a time with
|
|
`$D generate`, showing each as it lands). Tell the user: "Parallel generation failed
|
|
(likely rate limiting). Falling back to sequential..."
|
|
5. Proceed to Step 4 (comparison board).
|
|
|
|
**Dynamic image list for comparison board:** When proceeding to Step 4, construct the
|
|
image list from whatever variant files actually exist, not a hardcoded A/B/C list:
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
_IMAGES=$(ls "$_DESIGN_DIR"/variant-*.png 2>/dev/null | tr '\n' ',' | sed 's/,$//')
|
|
```
|
|
|
|
Use `$_IMAGES` in the `$D compare --images` command.
|
|
|
|
## Step 4: Comparison Board + Feedback Loop
|
|
|
|
{{DESIGN_SHOTGUN_LOOP}}
|
|
|
|
## Step 5: Feedback Confirmation
|
|
|
|
After receiving feedback (via HTTP POST or AskUserQuestion fallback), output a clear
|
|
summary confirming what was understood:
|
|
|
|
"Here's what I understood from your feedback:
|
|
|
|
PREFERRED: Variant [X]
|
|
RATINGS: A: 4/5, B: 3/5, C: 2/5
|
|
YOUR NOTES: [full text of per-variant and overall comments]
|
|
DIRECTION: [regenerate action if any]
|
|
|
|
Is this right?"
|
|
|
|
Use AskUserQuestion to confirm before saving.
|
|
|
|
## Step 6: Save & Next Steps
|
|
|
|
Write `approved.json` to `$_DESIGN_DIR/` (handled by the loop above).
|
|
|
|
If invoked from another skill: return the structured feedback for that skill to consume.
|
|
The calling skill reads `approved.json` and the approved variant PNG.
|
|
|
|
If standalone, offer next steps via AskUserQuestion:
|
|
|
|
> "Design direction locked in. What's next?
|
|
> A) Iterate more — refine the approved variant with specific feedback
|
|
> B) Finalize — generate production Pretext-native HTML/CSS with /design-html
|
|
> C) Save to plan — add this as an approved mockup reference in the current plan
|
|
> D) Done — I'll use this later"
|
|
|
|
## Important Rules
|
|
|
|
1. **Use the configured state root.** All design artifacts go to
|
|
`$GSTACK_STATE_ROOT/projects/$SLUG/designs/`, even when that root is temporary.
|
|
Do not substitute `.context/`, `docs/designs/`, or an arbitrary `/tmp/` path. See DESIGN_SETUP above.
|
|
2. **Show variants inline before opening the board.** The user should see designs
|
|
immediately in their terminal. The browser board is for detailed feedback.
|
|
3. **Confirm feedback before saving.** Always summarize what you understood and verify.
|
|
4. **Taste memory is automatic.** Prior approved designs inform new generations by default.
|
|
5. **Two rounds max on context gathering.** Don't over-interrogate. Proceed with assumptions.
|
|
6. **DESIGN.md is the default constraint.** Unless the user says otherwise.
|