mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 14:06:50 +01:00
Garry Tanandcapy-ai[bot]
021d817c36
* feat(proactive): default to the four core skills (core | all | off); docs, prompt and tests (GSTA-99) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(proactive): gstack-skill-start falls back to core, not true, when gstack-config is missing The PROACTIVE status line's fallback literal still said true (= all) after the default moved to core. Found by /ship's coverage audit; the regression test fails at the previous head and passes at main. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(proactive): STATUS line carries the stored value; every surface names the same core four and three values Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(proactive): off gates the office-hours handoff; the preamble and router scope the setting to unasked suggestions The office-hours next-review handoff gated on the legacy false only, so an off user was still asked to launch /plan-eng-review. The per-skill preamble now says the setting governs unasked suggestions and this skill's own steps still run (a handoff, a review gate, a dispatched /document-release is not a suggestion), at exactly the previous length, so the 89 size pins return to main's values; the router says the same in full. Found by /ship's specialist and red-team review. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(skill-start): unknown proactive values read as core; first-run tips name core skills and stay quiet under off A hand-edited config can hold any value and only set validates, so STATUS normalizes anything but core|all|off|true|false to core. The first-run and first-loop tips named /spec, /investigate and /plan-eng-review whatever the setting; they now name the core four and are skipped under off. The fallback regression test folds into test/proactive-skill-start.test.ts, the duplicate header assertion leaves proactive-config, and the frozen-length preamble test is retired (the size guard enforces it). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(proactive): scope note, the unknown-value rule, and the CLAUDE.md routing follow-up; CHANGELOG Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(skill-start): no CLAUDE.md routing offer under proactive off The one-time offer to append ## Skill routing to the project's CLAUDE.md fired whatever the proactive value, and its rules are the auto-invocation an off user turned off. The offer is skipped under off and the legacy false; a section already in CLAUDE.md is left alone. Under core the offered section still routes every skill, which docs/proactive.md records as the follow-up. Found by /ship's red team. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(proactive): STATUS says only core | all | off, and the preamble carves out only named skills gstack-skill-start reads the legacy true/false as all/off and tolerates a quoted, upper-case or commented hand edit (proactive: OFF # mine read as core before), so every surface sees one of three values and the off gating lives in one flag. The per-skill preamble drops the legacy spellings and replaces 'This skill's steps still run', which licensed any in-skill offer under off, with 'Skills the user or this skill's steps name run', at the same length, so the 89 size pins stay at main's. Tests run the script for the tips and the routing offer under core and off instead of grepping the source. Found by /ship's fix-range repeat (red team, testing, maintainability). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(config): set proactive is case-insensitive; follow-up #3446 cited; test hygiene set proactive OFF warned and stored core, the opposite of the opt-out typed; the value is lowercased first, as gstack-skill-start does for a hand edit. The fixture git init carries the tripwire timeout, the source-shape assertion on the private _PROACTIVE_OFF line goes (the routing-offer test proves the behavior), and the CHANGELOG Tests bullets collapse to one per file with the known gap pointing at #3446. Found by /ship's full repeat pass and its tests lane. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(proactive): a stored off answers the one-time prompt; the router names /browse and /investigate under core instead of invoking them Red team, full repeat pass: with proactive: off stored before the prompt, skill-start still emitted the opt-in prompt; it now writes the marker and asks nothing. The router's Route-first browser step and the Failures branches invoked non-core skills under core while the core block said to answer directly; one sentence in the core block resolves it, pinned by the core-set tests. CHANGELOG and docs/proactive.md say both. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(proactive): the full-catalog skill descriptions are the second surface that still routes every skill under core (#3446) From /ship's document-release audit: a --catalog-mode=full build and the non-Claude hosts keep the "Proactively suggest when ..." description sentences, which do not follow the setting; the default Claude build trims them. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(proactive): the tips test runs skill-start as an interactive session GitHub CI sets CI/GITHUB_ACTIONS, which gstack-session-kind reads as headless, and a headless start skips first-task detection, so the first-run tip never fires there (Free Tests shard 16 red at 0d7dbe6; green locally and on the Ubicloud pregate, which have no CI marker). The fixture now sets CLAUDE_CODE_ENTRYPOINT=cli, the positive interactive signal; reproduced locally with CI=1 and fixed. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(proactive): an opt-out never fails open; the preamble carves out invocations, not offers The YAML yes/no family (yes/on/1, no/none/0/disabled/never) reads as all/off in both gstack-skill-start and gstack-config set, so a typed or hand-edited opt-out cannot land on core. The per-skill preamble says "Skills the user names or this one invokes run" (same 168-char length, pins unchanged): a skill dispatching another is not a suggestion, an in-skill offer to run one still is under off. The stored-off prompt marker is written before STATUS prints PROACTIVE_PROMPTED, so the line is true. docs/proactive.md's table row carves out in-skill handoffs. Fourth /ship fix cycle, past the skill's three-cycle cap by GStack Minder's decision (2026-10-26) under Garry's "do it" on the proactive core set; items from the Step 11 adversarial pass. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * v1.91.240.0 stamp Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
680 lines
25 KiB
TypeScript
680 lines
25 KiB
TypeScript
/**
|
|
* Question Registry — typed schema for AskUserQuestion invocations across gstack.
|
|
*
|
|
* Purpose
|
|
* -------
|
|
* Every AskUserQuestion invocation is tagged with a stable question_id that maps
|
|
* to an entry in this registry. The registry is the substrate /plan-tune builds on:
|
|
* - Logging (question-log.jsonl) tags events with a registered id
|
|
* - Per-question preferences (question-preferences.json) are keyed by registered id
|
|
* - One-way door safety is declared here, not inferred from prose summaries
|
|
* - The psychographic signal map (scripts/psychographic-signals.ts) maps id → dimension delta
|
|
*
|
|
* Not every AskUserQuestion in gstack needs a registry entry right away. Skills
|
|
* often craft questions dynamically at runtime — the agent generates an ad-hoc id
|
|
* of the form `{skill}-{slug}` for those. The /plan-tune skill surfaces frequently-
|
|
* firing ad-hoc ids as candidates for registry promotion.
|
|
*
|
|
* v1 coverage target: the ~30-50 most-common recurring question categories across
|
|
* ship, review, office-hours, plan-ceo-review, plan-eng-review, plan-design-review,
|
|
* plan-devex-review, qa, investigate, and land-and-deploy. One-way doors 100%.
|
|
*
|
|
* Adding a new entry
|
|
* ------------------
|
|
* 1. Pick a kebab-case id of the form `{skill}-{what-it-asks-about}`.
|
|
* 2. Classify `door_type`:
|
|
* - `one-way` for destructive ops, architecture/data-model forks,
|
|
* scope-adds > 1 day CC effort, security/compliance choices.
|
|
* ALWAYS asked regardless of user preference.
|
|
* - `two-way` for everything else (can be auto-decided by explicit preference).
|
|
* 3. Pick the `category` that describes the question's shape.
|
|
* 4. Add an optional `signal_key` if this question's answer should nudge a
|
|
* specific psychographic dimension. The signal map in scripts/psychographic-
|
|
* signals.ts uses (id, user_choice) to look up the dimension delta.
|
|
* 5. `options` is a short list of stable option keys. UI labels can vary; keys
|
|
* must stay the same so preferences survive wording changes.
|
|
* 6. Run `bun test test/plan-tune.test.ts` to verify format + uniqueness.
|
|
*/
|
|
|
|
export type QuestionCategory =
|
|
| 'approval' // proceed/stop gate (e.g., "approve this plan?")
|
|
| 'clarification' // need more info to proceed
|
|
| 'routing' // which path to take (modes, strategies)
|
|
| 'cherry-pick' // opt-in scope decision (add/defer/skip)
|
|
| 'feedback-loop'; // inline tune: prompt, iteration feedback
|
|
|
|
export type DoorType = 'one-way' | 'two-way';
|
|
|
|
/**
|
|
* Stable keys for the most-common user choice patterns. UI labels can vary
|
|
* (e.g., "Add to plan" vs "Include in scope"); the stored choice is the key.
|
|
* Skills may emit custom keys for uncategorizable questions — those still log
|
|
* but don't get psychographic signal attribution.
|
|
*/
|
|
export type StandardOption =
|
|
| 'accept'
|
|
| 'reject'
|
|
| 'defer'
|
|
| 'skip'
|
|
| 'investigate'
|
|
| 'approve'
|
|
| 'deny'
|
|
| 'expand'
|
|
| 'hold'
|
|
| 'reduce'
|
|
| 'selective'
|
|
| 'fix-now'
|
|
| 'fix-later'
|
|
| 'ack-and-ship'
|
|
| 'false-positive'
|
|
| 'continue'
|
|
| 'rerun'
|
|
| 'stop';
|
|
|
|
export interface QuestionDef {
|
|
/** Stable kebab-case id: `{skill}-{semantic-description}` */
|
|
id: string;
|
|
/** Skill that owns this question (must match a gstack skill directory name) */
|
|
skill: string;
|
|
/** Shape of the question */
|
|
category: QuestionCategory;
|
|
/** Safety classification. one-way is ALWAYS asked regardless of preference */
|
|
door_type: DoorType;
|
|
/** Stable option keys (skills may emit keys outside this list; those are logged but untagged) */
|
|
options?: StandardOption[] | string[];
|
|
/** Optional key into scripts/psychographic-signals.ts for dimension attribution */
|
|
signal_key?: string;
|
|
/** One-line description for docs and /plan-tune profile output */
|
|
description: string;
|
|
}
|
|
|
|
/**
|
|
* QUESTIONS — initial v1 coverage of recurring question categories.
|
|
* Grouped by skill for readability. Maintained by hand.
|
|
*
|
|
* When adding new skills or question types, extend this object. The CI lint
|
|
* test/plan-tune.test.ts verifies format, uniqueness, and required fields.
|
|
*/
|
|
export const QUESTIONS = {
|
|
// -----------------------------------------------------------------------
|
|
// /ship — pre-landing review, deploy, PR creation
|
|
// -----------------------------------------------------------------------
|
|
'ship-release-pipeline-missing': {
|
|
id: 'ship-release-pipeline-missing',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'defer', 'skip'],
|
|
signal_key: 'distribution-care',
|
|
description: "New artifact added without CI/CD release pipeline — add now, defer to TODOs, or skip?",
|
|
},
|
|
'ship-test-failure-triage': {
|
|
id: 'ship-test-failure-triage',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['fix-now', 'investigate', 'ack-and-ship'],
|
|
signal_key: 'test-discipline',
|
|
description: "Failing tests detected — fix before shipping or investigate root cause?",
|
|
},
|
|
'ship-pre-landing-review-fix': {
|
|
id: 'ship-pre-landing-review-fix',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'skip'],
|
|
signal_key: 'code-quality-care',
|
|
description: "Pre-landing review flagged an issue — fix now or ship as-is?",
|
|
},
|
|
'ship-greptile-comment-valid': {
|
|
id: 'ship-greptile-comment-valid',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'ack-and-ship', 'false-positive'],
|
|
signal_key: 'code-quality-care',
|
|
description: "Greptile flagged a valid issue — fix, ack and ship, or mark false positive?",
|
|
},
|
|
'ship-greptile-comment-false-positive': {
|
|
id: 'ship-greptile-comment-false-positive',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['reply', 'fix-anyway', 'ignore'],
|
|
description: "Greptile comment looks like a false positive — reply to explain, fix anyway, or ignore silently?",
|
|
},
|
|
'ship-todos-create': {
|
|
id: 'ship-todos-create',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "No TODOS.md found — create a skeleton file now?",
|
|
},
|
|
'ship-todos-reorganize': {
|
|
id: 'ship-todos-reorganize',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
signal_key: 'detail-preference',
|
|
description: "TODOS.md doesn't follow the recommended structure — reorganize now?",
|
|
},
|
|
'ship-changelog-voice-polish': {
|
|
id: 'ship-changelog-voice-polish',
|
|
skill: 'ship',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
signal_key: 'detail-preference',
|
|
description: "CHANGELOG entry could be polished for voice — apply edits?",
|
|
},
|
|
'ship-version-bump-tier': {
|
|
id: 'ship-version-bump-tier',
|
|
skill: 'ship',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['major', 'minor', 'patch'],
|
|
description: "Version bump: major, minor, or patch?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /review — pre-landing code review
|
|
// -----------------------------------------------------------------------
|
|
'review-finding-fix': {
|
|
id: 'review-finding-fix',
|
|
skill: 'review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'ack-and-ship', 'false-positive'],
|
|
signal_key: 'code-quality-care',
|
|
description: "Review finding — fix now, ack and ship, or false positive?",
|
|
},
|
|
'review-sql-safety': {
|
|
id: 'review-sql-safety',
|
|
skill: 'review',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['fix-now', 'investigate'],
|
|
description: "Potential SQL injection / unsafe query — fix or investigate further?",
|
|
},
|
|
'review-llm-trust-boundary': {
|
|
id: 'review-llm-trust-boundary',
|
|
skill: 'review',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['fix-now', 'investigate'],
|
|
description: "LLM trust boundary violation — fix before merge?",
|
|
},
|
|
'review-gate-disposition': {
|
|
id: 'review-gate-disposition',
|
|
skill: 'review',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['restore', 'keep-justified', 'keep-other', 'leave-open'],
|
|
description: "Gate edit (test, threshold, CI or suppression relaxed) — restore the gate, keep it with a reason, or leave it open for a later human?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /office-hours — YC diagnostic + builder brainstorm
|
|
// -----------------------------------------------------------------------
|
|
'office-hours-mode-goal': {
|
|
id: 'office-hours-mode-goal',
|
|
skill: 'office-hours',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['startup', 'intrapreneur', 'hackathon', 'oss-research', 'learning', 'fun'],
|
|
signal_key: 'session-mode',
|
|
description: "What's your goal with this session? (Sets mode: startup vs builder)",
|
|
},
|
|
'office-hours-premise-confirm': {
|
|
id: 'office-hours-premise-confirm',
|
|
skill: 'office-hours',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'reject'],
|
|
description: "Premise check — agree or disagree?",
|
|
},
|
|
'office-hours-cross-model-run': {
|
|
id: 'office-hours-cross-model-run',
|
|
skill: 'office-hours',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Want a second-opinion cross-model review of your brainstorm?",
|
|
},
|
|
'office-hours-landscape-privacy-gate': {
|
|
id: 'office-hours-landscape-privacy-gate',
|
|
skill: 'office-hours',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Run a web search for landscape awareness? (Sends generalized terms to search provider.)",
|
|
},
|
|
'office-hours-approach-choose': {
|
|
id: 'office-hours-approach-choose',
|
|
skill: 'office-hours',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['minimal', 'ideal', 'creative'],
|
|
signal_key: 'scope-appetite',
|
|
description: "Which implementation approach? (minimal viable vs ideal architecture vs creative lateral)",
|
|
},
|
|
'office-hours-design-doc-approve': {
|
|
id: 'office-hours-design-doc-approve',
|
|
skill: 'office-hours',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'revise', 'restart'],
|
|
description: "Approve the design doc, revise sections, or start over?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /plan-ceo-review — scope & strategy
|
|
// -----------------------------------------------------------------------
|
|
'plan-ceo-review-mode': {
|
|
id: 'plan-ceo-review-mode',
|
|
skill: 'plan-ceo-review',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['expand', 'selective', 'hold', 'reduce'],
|
|
signal_key: 'scope-appetite',
|
|
description: "Review mode: push scope up, cherry-pick expansions, hold scope, or cut to minimum?",
|
|
},
|
|
'plan-ceo-review-expansion-proposal': {
|
|
id: 'plan-ceo-review-expansion-proposal',
|
|
skill: 'plan-ceo-review',
|
|
category: 'cherry-pick',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'defer', 'skip'],
|
|
signal_key: 'scope-appetite',
|
|
description: "Scope expansion proposal — add to plan, defer to TODOs, or skip?",
|
|
},
|
|
'plan-ceo-review-premise-revise': {
|
|
id: 'plan-ceo-review-premise-revise',
|
|
skill: 'plan-ceo-review',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['revise', 'hold'],
|
|
description: "Cross-model challenged an agreed premise — revise or keep?",
|
|
},
|
|
'plan-ceo-review-outside-voice': {
|
|
id: 'plan-ceo-review-outside-voice',
|
|
skill: 'plan-ceo-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Get an outside-voice second opinion on the plan?",
|
|
},
|
|
'plan-ceo-review-promote-to-docs': {
|
|
id: 'plan-ceo-review-promote-to-docs',
|
|
skill: 'plan-ceo-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'keep-local', 'skip'],
|
|
description: "Promote the CEO plan to docs/designs/ in the repo?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /plan-eng-review — architecture & tests (required gate)
|
|
// -----------------------------------------------------------------------
|
|
'plan-eng-review-arch-finding': {
|
|
id: 'plan-eng-review-arch-finding',
|
|
skill: 'plan-eng-review',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['fix-now', 'defer', 'accept-risk'],
|
|
signal_key: 'architecture-care',
|
|
description: "Architecture finding — fix, defer, or accept the risk?",
|
|
},
|
|
'plan-eng-review-scope-reduce': {
|
|
id: 'plan-eng-review-scope-reduce',
|
|
skill: 'plan-eng-review',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['reduce', 'hold'],
|
|
signal_key: 'scope-appetite',
|
|
description: "Plan touches 8+ files — reduce scope or hold?",
|
|
},
|
|
'plan-eng-review-structure': {
|
|
id: 'plan-eng-review-structure',
|
|
skill: 'plan-eng-review',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['original-arrangement', 'smaller-arrangement'],
|
|
description: "Complexity gate — Original arrangement or Smaller arrangement (file/class layout only)?",
|
|
},
|
|
'plan-eng-review-test-gap': {
|
|
id: 'plan-eng-review-test-gap',
|
|
skill: 'plan-eng-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['add-test', 'defer', 'skip'],
|
|
signal_key: 'test-discipline',
|
|
description: "Test gap identified — add now, defer, or skip?",
|
|
},
|
|
'plan-eng-review-outside-voice': {
|
|
id: 'plan-eng-review-outside-voice',
|
|
skill: 'plan-eng-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Get an outside-voice second opinion on the plan?",
|
|
},
|
|
'plan-eng-review-todo-add': {
|
|
id: 'plan-eng-review-todo-add',
|
|
skill: 'plan-eng-review',
|
|
category: 'cherry-pick',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip', 'build-now'],
|
|
description: "Proposed TODO item — add to TODOs, skip, or build in this PR?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /plan-design-review — UI/UX plan audit
|
|
// -----------------------------------------------------------------------
|
|
'plan-design-review-mode': {
|
|
id: 'plan-design-review-mode',
|
|
skill: 'plan-design-review',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['expand', 'polish', 'triage'],
|
|
signal_key: 'design-care',
|
|
description: "Design review depth: expand for competitive edge, polish every touchpoint, or triage critical gaps?",
|
|
},
|
|
'plan-design-review-fix': {
|
|
id: 'plan-design-review-fix',
|
|
skill: 'plan-design-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'defer', 'skip'],
|
|
signal_key: 'design-care',
|
|
description: "Design issue flagged — fix now, defer to TODOs, or skip?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /plan-devex-review — developer experience plan audit
|
|
// -----------------------------------------------------------------------
|
|
'plan-devex-review-persona': {
|
|
id: 'plan-devex-review-persona',
|
|
skill: 'plan-devex-review',
|
|
category: 'clarification',
|
|
door_type: 'two-way',
|
|
description: "Who is your target developer? (Determines persona for review.)",
|
|
},
|
|
'plan-devex-review-mode': {
|
|
id: 'plan-devex-review-mode',
|
|
skill: 'plan-devex-review',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['expand', 'polish', 'triage'],
|
|
signal_key: 'devex-care',
|
|
description: "DX review depth: expand for competitive advantage, polish every touchpoint, or triage critical gaps?",
|
|
},
|
|
'plan-devex-review-friction-fix': {
|
|
id: 'plan-devex-review-friction-fix',
|
|
skill: 'plan-devex-review',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'defer', 'skip'],
|
|
signal_key: 'devex-care',
|
|
description: "Friction point in the developer journey — fix now, defer, or skip?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /qa — QA testing
|
|
// -----------------------------------------------------------------------
|
|
'qa-bug-fix-scope': {
|
|
id: 'qa-bug-fix-scope',
|
|
skill: 'qa',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['fix-now', 'defer', 'skip'],
|
|
signal_key: 'code-quality-care',
|
|
description: "Bug found during QA — fix now, defer, or skip?",
|
|
},
|
|
'qa-tier': {
|
|
id: 'qa-tier',
|
|
skill: 'qa',
|
|
category: 'routing',
|
|
door_type: 'two-way',
|
|
options: ['quick', 'standard', 'deep'],
|
|
description: "QA tier: quick (critical/high only), standard (+medium), or deep (+low)?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /investigate — root-cause debugging
|
|
// -----------------------------------------------------------------------
|
|
'investigate-hypothesis-confirm': {
|
|
id: 'investigate-hypothesis-confirm',
|
|
skill: 'investigate',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'reject', 'refine'],
|
|
description: "Root-cause hypothesis — accept, reject, or refine before proceeding to fix?",
|
|
},
|
|
'investigate-fix-apply': {
|
|
id: 'investigate-fix-apply',
|
|
skill: 'investigate',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject'],
|
|
description: "Apply the proposed fix?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /land-and-deploy — merge + deploy + verify
|
|
// -----------------------------------------------------------------------
|
|
'land-and-deploy-merge-confirm': {
|
|
id: 'land-and-deploy-merge-confirm',
|
|
skill: 'land-and-deploy',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject'],
|
|
signal_key: 'decision-autonomy',
|
|
description: "Merge this PR to base branch?",
|
|
},
|
|
'land-and-deploy-rollback': {
|
|
id: 'land-and-deploy-rollback',
|
|
skill: 'land-and-deploy',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject'],
|
|
signal_key: 'decision-autonomy',
|
|
description: "Canary detected regressions — roll back the deploy?",
|
|
},
|
|
'land-and-deploy-ci-override': {
|
|
id: 'land-and-deploy-ci-override',
|
|
skill: 'land-and-deploy',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject'],
|
|
description: "Merge this head while these named non-required CI checks are red or pending?",
|
|
},
|
|
'land-and-deploy-no-ci-confirm': {
|
|
id: 'land-and-deploy-no-ci-confirm',
|
|
skill: 'land-and-deploy',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject'],
|
|
description: "No CI ran on this head — merge it anyway?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /cso — security audit
|
|
// -----------------------------------------------------------------------
|
|
'cso-global-scan-approval': {
|
|
id: 'cso-global-scan-approval',
|
|
skill: 'cso',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'deny'],
|
|
description: "Run a global security scan? (Scans files outside this branch.)",
|
|
},
|
|
'cso-finding-fix': {
|
|
id: 'cso-finding-fix',
|
|
skill: 'cso',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['fix-now', 'defer', 'accept-risk'],
|
|
description: "Security finding — fix, defer to TODOs, or accept the risk?",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /gstack-upgrade — version upgrade
|
|
// -----------------------------------------------------------------------
|
|
'gstack-upgrade-inline': {
|
|
id: 'gstack-upgrade-inline',
|
|
skill: 'gstack-upgrade',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['yes-upgrade', 'always-auto', 'not-now', 'never-ask'],
|
|
description: "Upgrade gstack now? (Also: always auto-upgrade, snooze, or disable the prompt.)",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Preamble one-time prompts (telemetry, proactive, routing)
|
|
// -----------------------------------------------------------------------
|
|
'preamble-telemetry-consent': {
|
|
id: 'preamble-telemetry-consent',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['community', 'anonymous', 'off'],
|
|
description: "Share usage data with gstack? community (recommended) / anonymous / off",
|
|
},
|
|
'preamble-proactive-behavior': {
|
|
id: 'preamble-proactive-behavior',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['core', 'all', 'off'],
|
|
description: "Let gstack proactively suggest skills based on conversation context? core (the four core skills, default) / all / off",
|
|
},
|
|
'preamble-routing-injection': {
|
|
id: 'preamble-routing-injection',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'decline'],
|
|
description: "Add gstack skill routing rules to CLAUDE.md?",
|
|
},
|
|
'preamble-vendored-migration': {
|
|
id: 'preamble-vendored-migration',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'keep-vendored'],
|
|
description: "This repo has vendored gstack (deprecated) — migrate to team mode?",
|
|
},
|
|
'preamble-completeness-intro': {
|
|
id: 'preamble-completeness-intro',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Open the Boil-the-Lake essay in your browser? (one-time intro)",
|
|
},
|
|
'preamble-cross-project-learnings': {
|
|
id: 'preamble-cross-project-learnings',
|
|
skill: 'preamble',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'reject'],
|
|
description: "Enable cross-project learnings search? (local only, helpful for solo devs)",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /plan-tune — the skill itself
|
|
// -----------------------------------------------------------------------
|
|
'plan-tune-enable-setup': {
|
|
id: 'plan-tune-enable-setup',
|
|
skill: 'plan-tune',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'skip'],
|
|
description: "Question tuning is off — enable it and set up your profile?",
|
|
},
|
|
'plan-tune-declared-dimension': {
|
|
id: 'plan-tune-declared-dimension',
|
|
skill: 'plan-tune',
|
|
category: 'clarification',
|
|
door_type: 'two-way',
|
|
description: "Self-declaration question (one per dimension during /plan-tune setup)",
|
|
},
|
|
'plan-tune-confirm-mutation': {
|
|
id: 'plan-tune-confirm-mutation',
|
|
skill: 'plan-tune',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'reject'],
|
|
description: "Confirm profile change before writing (user sovereignty gate for free-form edits)",
|
|
},
|
|
|
|
// -----------------------------------------------------------------------
|
|
// /autoplan — sequential auto-review
|
|
// -----------------------------------------------------------------------
|
|
'autoplan-taste-decision': {
|
|
id: 'autoplan-taste-decision',
|
|
skill: 'autoplan',
|
|
category: 'approval',
|
|
door_type: 'two-way',
|
|
options: ['accept', 'override', 'investigate'],
|
|
description: "Autoplan surfaced a taste decision at the final gate — accept, override, or investigate?",
|
|
},
|
|
'autoplan-user-challenge': {
|
|
id: 'autoplan-user-challenge',
|
|
skill: 'autoplan',
|
|
category: 'approval',
|
|
door_type: 'one-way',
|
|
options: ['accept', 'reject', 'revise'],
|
|
description: "Both models agree your direction should change — accept, reject, or revise the plan?",
|
|
},
|
|
} as const satisfies Record<string, QuestionDef>;
|
|
|
|
export type RegisteredQuestionId = keyof typeof QUESTIONS;
|
|
|
|
/**
|
|
* Runtime lookup — returns undefined for ad-hoc question_ids (not registered).
|
|
* Ad-hoc ids still log; they just don't get psychographic signal attribution.
|
|
*/
|
|
export function getQuestion(id: string): QuestionDef | undefined {
|
|
return (QUESTIONS as Record<string, QuestionDef>)[id];
|
|
}
|
|
|
|
/** Get all registered one-way door question ids (used by sensitivity checker) */
|
|
export function getOneWayDoorIds(): Set<string> {
|
|
return new Set(
|
|
Object.values(QUESTIONS as Record<string, QuestionDef>)
|
|
.filter((q) => q.door_type === 'one-way')
|
|
.map((q) => q.id),
|
|
);
|
|
}
|
|
|
|
/** All registered question ids, for CI completeness checks */
|
|
export function getAllRegisteredIds(): Set<string> {
|
|
return new Set(Object.keys(QUESTIONS));
|
|
}
|
|
|
|
/** Registry stats, for /plan-tune stats */
|
|
export function getRegistryStats() {
|
|
const all = Object.values(QUESTIONS as Record<string, QuestionDef>);
|
|
const bySkill: Record<string, number> = {};
|
|
const byCategory: Record<string, number> = {};
|
|
let oneWay = 0;
|
|
let twoWay = 0;
|
|
for (const q of all) {
|
|
bySkill[q.skill] = (bySkill[q.skill] ?? 0) + 1;
|
|
byCategory[q.category] = (byCategory[q.category] ?? 0) + 1;
|
|
if (q.door_type === 'one-way') oneWay++;
|
|
else twoWay++;
|
|
}
|
|
return {
|
|
total: all.length,
|
|
one_way: oneWay,
|
|
two_way: twoWay,
|
|
by_skill: bySkill,
|
|
by_category: byCategory,
|
|
};
|
|
}
|