mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-17 15:20:11 +02:00
Garry Tan
7fdd5a377d
Adversarial review (Claude subagent) found a CRITICAL the specialist pass missed: - F1 (CRITICAL): 'Human:'/'Assistant:' turn-prefixes bypassed BOTH the write-time denylist AND datamark(), landing verbatim in agent context inside the trusted ACTIVE DECISIONS fence. Add 'human:' (+ 'disregard previous', 'from now on') to the shared denylist, and have datamark() neutralize Human:/Assistant:/System:/User: turn-prefixes (ZWSP) at the render boundary. - F2: datamark() only stripped ASCII C0; extend to Unicode line terminators (U+0085/2028/2029) and U+007F so 'strip newlines' actually holds. - F3: validateDecide blocked only HIGH secrets; MEDIUM-tier PII (e.g. SSN) persisted silently and synced cross-machine. The store is non-interactive (no confirm path), so fail closed on MEDIUM too. - F4: compact() was a lock-free read-modify-rewrite that could clobber a concurrent append (lost decision). Add an O_EXCL compact lock + a pre-rename size recheck that aborts untouched (skipped=true) if an append landed; caller re-runs. - F7: filterByScope unknown/garbage scope fell through to 'return true' (leaked into every context); fail conservative (false). F5 (pid reuse) and F6 (pgrep over-match) are intentionally left as-is: both fail SAFE (over-refuse sync); making them precise would introduce a fail-DANGEROUS path (allowing sync during a real autopilot). True disambiguation needs gbrain to stamp the lock with a start-time, which gstack doesn't own. F8 (compact moves history to archive) is by design. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
90 lines
2.8 KiB
TypeScript
Executable File
90 lines
2.8 KiB
TypeScript
Executable File
#!/usr/bin/env bun
|
|
/**
|
|
* gstack-decision-log — append a durable decision (or supersede/redact/compact it).
|
|
*
|
|
* Usage:
|
|
* gstack-decision-log '{"decision":"...","rationale":"...","scope":"repo","source":"user"}'
|
|
* gstack-decision-log --supersede <decision-id>
|
|
* gstack-decision-log --redact <decision-id>
|
|
* gstack-decision-log --compact
|
|
*
|
|
* Event-sourced (lib/gstack-decision): every call appends an event and refreshes the
|
|
* bounded active snapshot. NON-INTERACTIVE — never prompts (agents/skills call this;
|
|
* a prompt would hang them). Validation + injection + HIGH-secret rejection happen in
|
|
* validateDecide; a rejected decision exits 1 with a message, nothing persisted.
|
|
*/
|
|
|
|
import { mkdirSync } from "fs";
|
|
import { dirname } from "path";
|
|
import { spawnSync } from "child_process";
|
|
import {
|
|
decisionPaths,
|
|
validateDecide,
|
|
makeRefEvent,
|
|
appendEvent,
|
|
rebuildSnapshot,
|
|
compact,
|
|
type DecisionEvent,
|
|
} from "../lib/gstack-decision";
|
|
import { resolveSlug, gitBranch, flagValue } from "../lib/bin-context";
|
|
|
|
const HERE = import.meta.dir;
|
|
|
|
const args = process.argv.slice(2);
|
|
const slug = resolveSlug(`${HERE}/gstack-slug`);
|
|
const paths = decisionPaths(slug);
|
|
mkdirSync(dirname(paths.log), { recursive: true });
|
|
|
|
function enqueue(): void {
|
|
// Fire-and-forget cross-machine sync (no-op when artifacts_sync is off).
|
|
spawnSync(`${HERE}/gstack-brain-enqueue`, [`projects/${slug}/decisions.jsonl`], { stdio: "ignore" });
|
|
}
|
|
|
|
if (args.includes("--compact")) {
|
|
const r = compact(paths);
|
|
if (r.skipped) {
|
|
console.log("compact skipped: a concurrent write/compact is in progress; log left intact — re-run");
|
|
process.exit(0);
|
|
}
|
|
console.log(`compacted: ${r.activeCount} active, ${r.archivedCount} archived, ${r.expungedCount} expunged`);
|
|
enqueue();
|
|
process.exit(0);
|
|
}
|
|
|
|
const supersedeId = flagValue(args, "--supersede");
|
|
const redactId = flagValue(args, "--redact");
|
|
if (supersedeId || redactId) {
|
|
const kind = supersedeId ? "supersede" : "redact";
|
|
const targetId = (supersedeId || redactId) as string;
|
|
appendEvent(paths, makeRefEvent(kind, targetId, { source: "agent" }));
|
|
rebuildSnapshot(paths);
|
|
enqueue();
|
|
console.log(`${kind}: ${targetId}`);
|
|
process.exit(0);
|
|
}
|
|
|
|
const jsonArg = args.find((a) => !a.startsWith("--"));
|
|
if (!jsonArg) {
|
|
process.stderr.write(
|
|
"gstack-decision-log: provide a JSON decision, or --supersede/--redact <id>, or --compact\n",
|
|
);
|
|
process.exit(1);
|
|
}
|
|
let obj: Partial<DecisionEvent>;
|
|
try {
|
|
obj = JSON.parse(jsonArg);
|
|
} catch {
|
|
process.stderr.write("gstack-decision-log: invalid JSON\n");
|
|
process.exit(1);
|
|
}
|
|
if (obj.scope === "branch" && !obj.branch) obj.branch = gitBranch();
|
|
const res = validateDecide(obj);
|
|
if (!res.ok) {
|
|
process.stderr.write(`gstack-decision-log: ${res.error}\n`);
|
|
process.exit(1);
|
|
}
|
|
appendEvent(paths, res.event);
|
|
rebuildSnapshot(paths);
|
|
enqueue();
|
|
console.log(res.event.id);
|