mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-03 01:46:55 +02:00
* feat: add surface-aware exploratory QA and ship documentation gates * test: preserve delegated QA setup authority after main integration * fix(qa): clarify exploration order and preserve report artifacts * test(qa): follow the shared setup reference directly * refactor(ship): make verification and recovery routes explicit * test(ship): align evidence and review guards with explicit routes * fix(workflows): clarify ship recovery and functional QA evidence * fix(workflows): clarify approval recovery and full QA coverage * refactor(workflows): order review transactions and clarify ship state * fix(ship): clarify final verification and fail closed at publication * fix(evals): attribute native atomic documentation writes * fix(ship): clarify recovery and documentation lifecycle guidance * fix(test): preserve observed native placeholder styling in CI * fix(codex): report watchdog timeouts without a process-exit race * Checkpoint functional QA implementation and workflow validation repairs * Fix documentation and shared-review fixture contracts * docs: clarify judge reuse and evaluation supervision * test: align review evidence and selected case contracts * test: verify append-only documentation checkpoints and recovery * fix: qualify QA workflows and CI validation repairs * fix: launch shared-libs fixture scripts on Windows * fix: qualify QA deadlines, fixture isolation, and shard cleanup * fix: preserve qualified QA and cancellation repairs * fix: enforce functional fixture authority and share strict event decoding * fix: retain free-test evidence and explain recovery * fix: reject malformed native evidence after decoder consolidation * test: use reliable capture for telemetry privacy filters * test: refresh measured quick coverage and document validation costs * Fix native fixture receipts and preserve VM validation evidence * Align negative judge controls with upstream clarity policy * Fix report-only QA preparation and public evidence handling * Clarify QA-only preparation and current-report preservation * Stream Ship quality judgments with an explicit 64k response contract * Validate compact judge reasoning locally with supported wire schema * Align functional QA fixture instructions with evidence acceptance * Bind native browser diagnostics to execution evidence and align review verdicts * Preserve native diagnostic line boundaries * Serialize functional QA evidence from native captures * Keep large QA evidence fixture payload out of Windows argv
80 lines
4.0 KiB
TypeScript
80 lines
4.0 KiB
TypeScript
/**
|
|
* R2 pin (fork port wave 2): the Apple release adapter loads BEFORE ship's
|
|
* branch gate, and the non-Apple gate is byte-unchanged.
|
|
*
|
|
* Two failure modes this prevents: a future ship-template refactor that
|
|
* re-blocks store releases behind "ship from a feature branch" (the exact
|
|
* live failure the fork hit — a solo dev with a clean tree on main shipping
|
|
* to TestFlight got aborted over branch topology), and the reverse — the
|
|
* Apple path accidentally weakening the branch gate for normal
|
|
* repository-landing ships.
|
|
*/
|
|
|
|
import { describe, test, expect } from "bun:test";
|
|
import { readFileSync } from "fs";
|
|
import { join } from "path";
|
|
|
|
const ROOT = join(import.meta.dir, "..");
|
|
const SKELETON = readFileSync(join(ROOT, "ship", "SKILL.md"), "utf-8");
|
|
|
|
const GATE_TEXT =
|
|
'If on the base branch or the repo\'s default branch, **abort**: "You\'re on the base branch. Ship from a feature branch."';
|
|
|
|
describe("ship Apple gate ordering (R2)", () => {
|
|
test("the section index requires a store-distribution request, not merely an Apple repository", () => {
|
|
const manifest = JSON.parse(readFileSync(join(ROOT, "ship", "sections", "manifest.json"), "utf-8"));
|
|
const apple = manifest.sections.find((section: { id: string }) => section.id === "apple-release");
|
|
expect(apple.trigger).toContain("App Store/TestFlight distribution is requested for an Apple app");
|
|
expect(apple.trigger).toContain("an Apple repository-landing request follows the normal pipeline");
|
|
expect(SKELETON).toContain("is App Store/TestFlight distribution");
|
|
});
|
|
|
|
test("the Apple adapter read directive precedes the branch gate", () => {
|
|
const appleRead = SKELETON.indexOf("sections/apple-release.md");
|
|
const gate = SKELETON.indexOf(GATE_TEXT);
|
|
expect(appleRead).toBeGreaterThan(-1);
|
|
expect(gate).toBeGreaterThan(-1);
|
|
expect(appleRead).toBeLessThan(gate);
|
|
});
|
|
|
|
test("store distribution explicitly bypasses the branch/PR ceremony", () => {
|
|
expect(SKELETON).toContain("Store distribution proceeds");
|
|
expect(SKELETON).toMatch(/branch gate and repository-landing pipeline below apply ONLY to\s*\n?repository-landing asks/);
|
|
});
|
|
|
|
test("the non-Apple branch gate is byte-unchanged and appears exactly once", () => {
|
|
const first = SKELETON.indexOf(GATE_TEXT);
|
|
expect(first).toBeGreaterThan(-1);
|
|
expect(SKELETON.indexOf(GATE_TEXT, first + 1)).toBe(-1);
|
|
});
|
|
|
|
test("the adapter section exists in the union with its battle-tested spine", () => {
|
|
const section = readFileSync(join(ROOT, "ship", "sections", "apple-release.md"), "utf-8");
|
|
for (const anchor of [
|
|
"one authorization moment",
|
|
"fastlane spaceauth",
|
|
"iris/v1/apiKeys",
|
|
"appPriceSchedules",
|
|
"CLASSIFY the error before touching credentials",
|
|
"Never abort an App Store release over branch topology",
|
|
]) {
|
|
expect(section).toContain(anchor);
|
|
}
|
|
});
|
|
|
|
test("routine interaction limits cannot waive blocking documentation or safety decisions", () => {
|
|
for (const name of ["apple-release.md.tmpl", "apple-release.md"]) {
|
|
const section = readFileSync(join(ROOT, "ship", "sections", name), "utf-8");
|
|
expect(section).toContain("Plan for two routine interactions");
|
|
expect(section).toContain("A genuine blocker may require a safety or named documentation-risk decision");
|
|
expect(section).toContain("STOP for that decision rather than treating release authorization as a waiver");
|
|
expect(section).toContain("routine interactions and blocking decisions above");
|
|
expect(section).not.toContain("exactly two interactions, and no others");
|
|
expect(section).not.toContain("two permitted interactions");
|
|
expect(section.indexOf("**Documentation preflight:**")).toBeLessThan(section.indexOf("## The one authorization moment"));
|
|
expect(section).toContain("in `read-only` mode against the selected release source");
|
|
expect(section).toContain("Resolve blockers or obtain an explicit named documentation-risk exception before distribution");
|
|
}
|
|
});
|
|
});
|