Garry Tan
8933cf7c0e
fix(gbrain-sync): defensive guards against destructive gbrain ops ( #1734 )
...
The orchestrator shelled out to gbrain's destructive subcommands as if they were
safe. gbrain can rm-rf a user's working tree during an autopilot race (its own
bug, upstream gbrain #1526 ); gstack now defends itself. New lib/gbrain-guards.ts
gates the two destructive reach points, all checked immediately before the op:
- Autopilot refuse (multi-signal, affirmative-only): refuse a destructive op when
a live 'gbrain autopilot' process (primary) or a known autopilot lock file
(secondary; checked under both GBRAIN_HOME and ~/.gbrain since gbrain #1226
ignores GBRAIN_HOME) is present. No signal → proceed; inability to introspect
never bricks a normal sync.
- sources remove: routed through safeSourcesRemove → decideSourceRemove. Fail
CLOSED — refuse to remove a user-managed source (remote_url set, local_path
outside gbrain's clones) when gbrain has no --keep-storage to protect the files
(it doesn't in 0.41.x). Also fail closed when the source list can't be read.
Path containment uses realpath so a symlink can't smuggle a delete out of clones.
- sync --strategy code: decideCodeSync refuses URL-managed sources (remote_url
set) unless --allow-reclone is passed, since the walk can auto-reclone (rm-rf).
Capability detection memoizes per process keyed to gbrain's identity (no stale
persistent cache); --keep-storage can't be probed (generic help) so it defaults
unsupported → fail closed. Every guard surfaces a visible reason; autopilot/reclone
refusals fail the code stage (verdict ERR) rather than silently skipping protection.
test/gbrain-guards.test.ts covers all branches hermetically (injected rows + probe
overrides): autopilot signals, fail-closed remove, keep-storage path, reclone gate,
realpath/symlink containment. Supersedes #1736 (which guarded a nonexistent path).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-05-30 10:49:31 -07:00
..
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-04-24 00:04:53 -07:00
2026-03-18 23:57:59 -05:00
2026-05-17 08:26:36 -07:00
2026-04-19 17:50:31 +08:00
2026-05-21 21:21:07 -07:00
2026-04-19 17:50:31 +08:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-25 10:57:15 -07:00
2026-05-06 19:37:53 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-04-08 22:21:28 -10:00
2026-05-29 08:35:00 -07:00
2026-05-26 16:50:03 -07:00
2026-05-30 10:48:49 -07:00
2026-04-23 07:25:20 -07:00
2026-03-23 23:05:22 -07:00
2026-05-14 11:11:52 -04:00
2026-05-09 08:06:47 -07:00
2026-05-16 12:32:33 -07:00
2026-04-19 08:38:19 +08:00
2026-05-26 16:50:03 -07:00
2026-05-28 18:21:09 -07:00
2026-05-25 10:57:15 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-05-21 21:21:07 -07:00
2026-04-26 13:55:13 -07:00
2026-05-24 01:43:51 -07:00
2026-05-20 07:35:01 -07:00
2026-04-24 01:38:21 -07:00
2026-05-14 17:20:48 -07:00
2026-05-29 08:35:00 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 10:49:31 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-05-21 21:21:07 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 10:39:26 -07:00
2026-05-04 09:29:48 -07:00
2026-05-30 10:42:15 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-04-16 10:41:38 -07:00
2026-05-26 16:50:03 -07:00
2026-05-30 10:38:01 -07:00
2026-05-20 06:56:41 -07:00
2026-05-14 11:11:52 -04:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-05-28 18:21:09 -07:00
2026-05-25 10:57:15 -07:00
2026-05-21 21:21:07 -07:00
2026-05-06 19:37:53 -07:00
2026-04-28 01:17:54 -07:00
2026-05-20 07:35:01 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-17 08:26:36 -07:00
2026-05-25 10:57:15 -07:00
2026-05-20 07:35:01 -07:00
2026-04-18 15:05:42 +08:00
2026-05-26 23:43:07 -07:00
2026-05-29 08:35:00 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-05-25 10:57:15 -07:00
2026-04-26 13:55:13 -07:00
2026-05-10 06:57:24 -07:00
2026-04-17 00:45:13 -07:00
2026-05-25 10:57:15 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 10:36:29 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 11:11:52 -04:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-05-28 18:21:09 -07:00
2026-05-20 07:35:01 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-04-25 11:52:48 -07:00
2026-05-14 21:19:58 -07:00
2026-04-17 00:45:13 -07:00
2026-05-26 16:50:03 -07:00
2026-05-26 16:50:03 -07:00
2026-05-28 18:21:09 -07:00
2026-04-18 15:05:42 +08:00
2026-05-06 19:37:53 -07:00
2026-05-01 07:06:37 -07:00
2026-04-23 18:25:34 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-04-18 15:05:42 +08:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 06:56:41 -07:00
2026-05-20 06:56:41 -07:00
2026-05-21 21:21:07 -07:00
2026-05-26 23:43:07 -07:00
2026-05-26 16:50:03 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-03-26 23:21:27 -06:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-04-24 01:38:21 -07:00
2026-05-24 01:43:51 -07:00
2026-05-14 21:19:58 -07:00
2026-05-29 18:06:19 -07:00
2026-05-06 19:37:53 -07:00
2026-05-14 21:19:58 -07:00
2026-05-09 08:06:47 -07:00
2026-04-18 23:58:59 +08:00
2026-05-28 18:21:09 -07:00
2026-04-19 08:38:19 +08:00
2026-05-26 16:50:03 -07:00
2026-05-26 16:50:03 -07:00
2026-05-26 21:36:53 -07:00
2026-05-01 19:51:51 -07:00
2026-05-11 12:16:26 -07:00
2026-05-01 08:45:36 -07:00
2026-04-26 13:55:13 -07:00
2026-04-19 08:38:19 +08:00
2026-05-11 12:16:26 -07:00
2026-05-06 19:37:53 -07:00
2026-04-23 17:54:54 -07:00
2026-04-19 08:38:19 +08:00
2026-03-23 06:57:22 -07:00
2026-03-26 11:08:31 -07:00
2026-05-11 12:16:26 -07:00
2026-05-29 08:35:00 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-05-01 08:45:36 -07:00
2026-05-29 08:35:00 -07:00
2026-05-01 19:51:51 -07:00
2026-04-19 05:44:39 +08:00
2026-04-22 01:06:22 -07:00
2026-04-23 18:42:58 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-04-30 02:50:09 -07:00
2026-05-09 17:01:13 -07:00
2026-05-26 23:43:07 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-11 12:16:26 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-03 20:26:59 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-09 17:01:13 -07:00
2026-05-01 19:51:51 -07:00
2026-04-26 13:55:13 -07:00
2026-04-23 18:25:34 -07:00
2026-05-28 18:21:09 -07:00
2026-04-18 15:05:42 +08:00
2026-05-21 16:09:26 -07:00
2026-05-11 12:16:26 -07:00
2026-03-23 10:17:33 -07:00
2026-03-30 22:07:50 -06:00
2026-05-11 12:16:26 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-04-26 13:55:13 -07:00
2026-04-04 15:32:20 -07:00
2026-05-11 12:16:26 -07:00
2026-05-26 21:36:53 -07:00
2026-05-11 12:16:26 -07:00
2026-03-31 23:08:22 -06:00
2026-05-26 21:36:53 -07:00
2026-03-26 17:31:53 -06:00
2026-03-13 21:08:12 -07:00
2026-05-29 08:35:00 -07:00
2026-04-16 10:41:38 -07:00
2026-05-28 18:21:09 -07:00
2026-05-26 16:50:03 -07:00
2026-05-26 21:36:53 -07:00
2026-05-26 21:36:53 -07:00
2026-05-25 10:57:15 -07:00
2026-05-29 08:35:00 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-03-29 21:43:36 -06:00
2026-05-26 16:50:03 -07:00
2026-05-01 07:21:28 -07:00
2026-05-25 10:57:15 -07:00
2026-05-26 23:43:07 -07:00
2026-03-27 00:44:37 -06:00
2026-05-24 01:43:51 -07:00
2026-05-29 08:35:00 -07:00
2026-04-18 15:05:42 +08:00
2026-04-06 14:41:06 -07:00
2026-05-26 16:50:03 -07:00