gstack/browse/test/memory-command.test.ts

import { describe, test, expect } from 'bun:test';
import { formatBytes, type MemorySnapshot, type MemoryStructureStats } from '../src/memory-snapshot';

// Unit coverage for the $B memory diagnostic surface — formatter, byte
// renderer, and the structures-stats aggregator. The integration path
// ($B memory through the BrowserManager → CDP) requires a real headless
// Chromium and is covered indirectly by browse-basic in the eval suite.
// These tests pin the renderer logic in isolation so format regressions
// (rounded GB drift, missing "and N more" tail, snapshot.notes ordering)
// surface immediately.

// ─── formatBytes() ─────────────────────────────────────────────

describe('formatBytes', () => {
  test('1. < 1 KB renders as bytes', () => {
    expect(formatBytes(0)).toBe('0 B');
    expect(formatBytes(1)).toBe('1 B');
    expect(formatBytes(1023)).toBe('1023 B');
  });

  test('2. KB tier (1024 ... 1024^2-1)', () => {
    expect(formatBytes(1024)).toBe('1.0 KB');
    expect(formatBytes(1536)).toBe('1.5 KB');
    expect(formatBytes(1024 * 1024 - 1)).toMatch(/^1024\.0 KB$|^1023\.\d KB$/);
  });

  test('3. MB tier', () => {
    expect(formatBytes(1024 * 1024)).toBe('1.0 MB');
    expect(formatBytes(312 * 1024 * 1024)).toBe('312.0 MB');
  });

  test('4. GB tier renders with 2 decimals', () => {
    expect(formatBytes(1024 * 1024 * 1024)).toBe('1.00 GB');
    expect(formatBytes(1.4 * 1024 * 1024 * 1024)).toMatch(/^1\.40 GB$/);
    // 160.61 GB — the friend's OOM number from the original screenshot.
    // Verify the renderer doesn't blow up at the actual leak scale.
    const big = 160.61 * 1024 * 1024 * 1024;
    expect(formatBytes(big)).toMatch(/^160\.6\d GB$/);
  });

  test('5. negative input behavior — coerces to bytes path (best-effort, do not throw)', () => {
    // Diagnostic should never crash on a weird CDP reading; render
    // something reasonable.
    expect(() => formatBytes(-1)).not.toThrow();
  });
});

// ─── handleMemoryCommand text + json output ────────────────────

// Build a minimal MemorySnapshot fixture exercising every render branch.
// This is what bm.getMemorySnapshot would return; we stub the BrowserManager
// so the test never spins up real Chromium.
function makeStructureStats(): MemoryStructureStats {
  return {
    modificationHistory: { current: 42, cap: 200, evicted: 0 },
    activitySubscribers: 1,
    inspectorSubscribers: 0,
    consoleBufferLen: 1842,
    networkBufferLen: 12000,
    dialogBufferLen: 3,
    captureBufferBytes: 0,
  };
}

function makeSnapshot(overrides: Partial<MemorySnapshot> = {}): MemorySnapshot {
  return {
    bunServer: {
      rss: 312 * 1024 * 1024,
      heapUsed: 84 * 1024 * 1024,
      heapTotal: 120 * 1024 * 1024,
      external: 21 * 1024 * 1024,
    },
    tabs: [],
    processes: null,
    structures: makeStructureStats(),
    capturedAt: 1700000000000,
    notes: [],
    ...overrides,
  };
}

// Mock BrowserManager surface for handleMemoryCommand. Only
// getMemorySnapshot is touched.
function makeFakeBm(snapshot: MemorySnapshot) {
  return {
    getMemorySnapshot: async (structures: MemoryStructureStats) => ({
      ...snapshot,
      structures,
    }),
  } as unknown as import('../src/browser-manager').BrowserManager;
}

describe('handleMemoryCommand', () => {
  test('6. --json mode emits parseable JSON with bunServer + structures', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const snapshot = makeSnapshot();
    const result = await handleMemoryCommand(['--json'], makeFakeBm(snapshot));
    const parsed = JSON.parse(result);
    expect(parsed.bunServer.rss).toBe(312 * 1024 * 1024);
    expect(parsed.structures).toBeDefined();
    expect(parsed.structures.modificationHistory.cap).toBe(200);
  });

  test('7. text mode renders Bun server line with RSS + heap', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot()));
    expect(result).toContain('Bun server:');
    expect(result).toContain('312.0 MB');
    expect(result).toContain('84.0 MB');
  });

  test('8. text mode renders "no tabs tracked" when tabs array is empty', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot({ tabs: [] })));
    expect(result).toContain('Renderers:');
    expect(result).toContain('(no tabs tracked)');
  });

  test('9. text mode shows top 10 tabs + "...and N more" tail when > 10', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const tabs = Array.from({ length: 15 }, (_, i) => ({
      id: i,
      url: `https://example.com/tab${i}`,
      title: `Tab ${i}`,
      jsHeapUsed: (15 - i) * 50 * 1024 * 1024, // descending so sort matters
      jsHeapTotal: (15 - i) * 60 * 1024 * 1024,
      documents: 1,
      nodes: 100,
      listeners: 10,
    }));
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot({ tabs })));
    expect(result).toContain('Renderers:         15 tabs');
    expect(result).toContain('and 5 more');
    // Sorted by JS heap descending — tab 0 (largest) should appear before tab 9
    expect(result.indexOf('tab #0 —')).toBeLessThan(result.indexOf('tab #9 —'));
  });

  test('10. text mode renders Chromium processes grouped by type', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const snapshot = makeSnapshot({
      processes: [
        { id: 1, type: 'browser', cpuTime: 1.5 },
        { id: 2, type: 'renderer', cpuTime: 3.2 },
        { id: 3, type: 'renderer', cpuTime: 2.1 },
        { id: 4, type: 'gpu', cpuTime: 0.5 },
      ],
    });
    const result = await handleMemoryCommand([], makeFakeBm(snapshot));
    expect(result).toContain('Chromium processes: 4 total');
    expect(result).toContain('renderer=2');
    expect(result).toContain('browser=1');
    expect(result).toContain('gpu=1');
  });

  test('11. text mode renders "unavailable" line when processes is null', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot({ processes: null })));
    expect(result).toContain('Chromium processes: (unavailable — see notes)');
  });

  test('13. text mode renders modificationHistory line shape', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot()));
    // collectStructureStats reads live module state; values may be 0 in
    // the test env. Verify the LINE SHAPE rather than specific numbers.
    expect(result).toMatch(/modificationHistory:\s+\d+ \/ \d+ entries/);
  });

  test('14. text mode prints notes section when notes are present', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const snapshot = makeSnapshot({
      notes: ['Per-Chromium-process RSS not collected — CDP limitation.'],
    });
    const result = await handleMemoryCommand([], makeFakeBm(snapshot));
    expect(result).toContain('Notes:');
    expect(result).toContain('CDP limitation.');
  });

  test('15. text mode omits notes section when notes is empty', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot({ notes: [] })));
    expect(result).not.toContain('Notes:');
  });

  test('16. text mode truncates long tab URLs with ellipsis', async () => {
    const { handleMemoryCommand } = await import('../src/memory-command');
    const longUrl = 'https://example.com/' + 'a'.repeat(120);
    const tabs = [{
      id: 1,
      url: longUrl,
      title: 'long',
      jsHeapUsed: 1024,
      jsHeapTotal: 2048,
      documents: 1,
      nodes: 10,
      listeners: 1,
    }];
    const result = await handleMemoryCommand([], makeFakeBm(makeSnapshot({ tabs })));
    expect(result).toContain('...');
    // The truncated URL appears, the full URL does not
    expect(result.includes(longUrl)).toBe(false);
  });
});

// ─── buildMemorySnapshotJson — server-endpoint entry ──────────

describe('buildMemorySnapshotJson', () => {
  test('17. returns the snapshot with structures populated', async () => {
    const { buildMemorySnapshotJson } = await import('../src/memory-command');
    const snapshot = makeSnapshot();
    const result = await buildMemorySnapshotJson(makeFakeBm(snapshot));
    expect(result.bunServer.rss).toBe(snapshot.bunServer.rss);
    expect(result.structures.modificationHistory.cap).toBe(200);
    // structures is populated from live module accessors, not from the
    // fixture. Just assert the shape is right.
    expect(typeof result.structures.consoleBufferLen).toBe('number');
    expect(typeof result.structures.networkBufferLen).toBe('number');
  });
});