mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 22:48:57 +02:00
The merge-blocking gate census counted tests that could not run. Deleted (critic-verified against both quoted-occurrence and dep-registration liveness): 7 *-prosons-format keys with no declaring test, ship-plan- completion/-verification, review-plan-completion, design-shotgun-path/ session/full, autoplan-core (dead ~10 months), e2e-harness-audit (its namesake is a FREE-suite file), plus 2 dead LLM-judge keys and 2 free-file keys (budget-regression-pty, global-discover) misplaced in the PAID maps. Census: 191 -> 174 keys, gate 86 -> 78 honest. The new reverse invariant in touchfiles.test.ts makes the class structurally impossible: every key must be quoted in a living paid test file OR registered to an existing paid test file via its dep list (the constructed- name binding the 2026-08 self-registration sweep established) — zero exceptions needed today, with a live-file check on any future exception. Also: '.agents/skills/**' dep patterns replaced with the generator (scripts/gen-skill-docs.ts) — .agents/ is gitignored, so those patterns could NEVER match a git diff and review-template edits silently stopped selecting codex/gemini tests; the codex/gemini local touchfile maps are now DERIVED from the canonical map (loud throw if a key vanishes) instead of hand-forked copies that had already drifted. ios-qa-e2e demoted gate -> periodic: its gate declaration was never executable in CI (hardware exclusion only applies at tier=periodic), so every Linux PR planned a hollow shard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
175 lines
6.7 KiB
TypeScript
175 lines
6.7 KiB
TypeScript
/**
|
|
* Gemini CLI E2E smoke test — verify Gemini CLI can start and discover skills.
|
|
*
|
|
* This is a lightweight smoke test, not a full integration test. Gemini CLI
|
|
* gets lost in worktrees and times out on complex tasks. The smoke test
|
|
* validates that the skill files are structured correctly for Gemini's
|
|
* .agents/skills/ discovery mechanism.
|
|
*
|
|
* Prerequisites:
|
|
* - `gemini` binary installed (npm install -g @google/gemini-cli)
|
|
* - Gemini authenticated via ~/.gemini/ config or GEMINI_API_KEY env var
|
|
* - EVALS=1 env var set (same gate as Claude E2E tests)
|
|
*
|
|
* Skips gracefully when prerequisites are not met.
|
|
*/
|
|
|
|
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
|
|
import { JUDGE_MS } from './helpers/eval-budgets';
|
|
import { runGeminiSkill } from './helpers/gemini-session-runner';
|
|
import type { GeminiResult } from './helpers/gemini-session-runner';
|
|
import { EvalCollector } from './helpers/eval-store';
|
|
import { selectTests, detectBaseBranch, getChangedFiles, E2E_TOUCHFILES, GLOBAL_TOUCHFILES } from './helpers/touchfiles';
|
|
import { createTestWorktree, harvestAndCleanup } from './helpers/e2e-helpers';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
// --- Prerequisites check ---
|
|
|
|
const GEMINI_AVAILABLE = (() => {
|
|
try {
|
|
const result = Bun.spawnSync(['which', 'gemini'], { timeout: 30_000 });
|
|
return result.exitCode === 0;
|
|
} catch { return false; }
|
|
})();
|
|
|
|
// A binary on PATH is not enough: the CLI can be present but UNUSABLE — the
|
|
// individual code-assist auth path was deprecated upstream ("migrate to the
|
|
// Antigravity suite"), which fails every run before any model call, and flag
|
|
// churn (--skip-trust removed in 0.34) errors at argv parse. Probe with a
|
|
// bare --help: a CLI that can't even print usage is unusable, and a working
|
|
// one is cheap to confirm. Deeper auth failures are classified per-run.
|
|
const GEMINI_USABLE = GEMINI_AVAILABLE && (() => {
|
|
try {
|
|
const result = Bun.spawnSync(['gemini', '--help'], { timeout: 15_000 });
|
|
return result.exitCode === 0;
|
|
} catch { return false; }
|
|
})();
|
|
|
|
const evalsEnabled = !!process.env.EVALS;
|
|
|
|
// External-service tests are periodic-tier (CLAUDE.md tiering rule 3):
|
|
// "Requires external service (Codex, Gemini)? -> periodic". The positive
|
|
// form below is the canonical whole-file guard shape — the sharded runner's
|
|
// classifyPaidTestFile greps for it to exclude this file from gate.
|
|
const tierOk = process.env.EVALS_TIER === 'periodic';
|
|
|
|
// Skip all tests if gemini is not available/usable, EVALS is not set, or
|
|
// we're in the gate tier.
|
|
const SKIP = !GEMINI_USABLE || !evalsEnabled || !tierOk;
|
|
|
|
const describeGemini = SKIP ? describe.skip : describe;
|
|
|
|
// Log why we're skipping (helpful for debugging CI)
|
|
if (!evalsEnabled) {
|
|
// Silent — same as Claude E2E tests, EVALS=1 required
|
|
} else if (!tierOk) {
|
|
process.stderr.write('\nGemini E2E: SKIPPED — external-service test, periodic tier only (EVALS_TIER === \'periodic\')\n');
|
|
} else if (!GEMINI_AVAILABLE) {
|
|
process.stderr.write('\nGemini E2E: SKIPPED — gemini binary not found (install: npm i -g @google/gemini-cli)\n');
|
|
} else if (!GEMINI_USABLE) {
|
|
process.stderr.write('\nGemini E2E: SKIPPED — gemini CLI present but unusable (auth path deprecated upstream or CLI broken; try updating @google/gemini-cli)\n');
|
|
}
|
|
|
|
// --- Diff-based test selection ---
|
|
|
|
// Gemini E2E touchfiles — DERIVED from the canonical map, never a local fork
|
|
// (the old hand-copy kept a gitignored '.agents/skills/**' pattern that can
|
|
// never match a git diff and missed canonical deps — same drift class as the
|
|
// codex copy).
|
|
const GEMINI_E2E_TOUCHFILES: Record<string, string[]> = Object.fromEntries(
|
|
(['gemini-smoke'] as const).map((key) => {
|
|
if (!E2E_TOUCHFILES[key]) throw new Error(`canonical E2E_TOUCHFILES lost key '${key}' — fix the map, not this file`);
|
|
return [key, E2E_TOUCHFILES[key]];
|
|
}),
|
|
);
|
|
|
|
let selectedTests: string[] | null = null; // null = run all
|
|
|
|
if (evalsEnabled && !process.env.EVALS_ALL) {
|
|
const baseBranch = process.env.EVALS_BASE
|
|
|| detectBaseBranch(ROOT)
|
|
|| 'main';
|
|
const changedFiles = getChangedFiles(baseBranch, ROOT);
|
|
|
|
if (changedFiles.length > 0) {
|
|
const selection = selectTests(changedFiles, GEMINI_E2E_TOUCHFILES, GLOBAL_TOUCHFILES);
|
|
selectedTests = selection.selected;
|
|
process.stderr.write(`\nGemini E2E selection (${selection.reason}): ${selection.selected.length}/${Object.keys(GEMINI_E2E_TOUCHFILES).length} tests\n`);
|
|
if (selection.skipped.length > 0) {
|
|
process.stderr.write(` Skipped: ${selection.skipped.join(', ')}\n`);
|
|
}
|
|
process.stderr.write('\n');
|
|
}
|
|
}
|
|
|
|
/** Skip an individual test if not selected by diff-based selection. */
|
|
function testIfSelected(testName: string, fn: () => Promise<void>, timeout: number) {
|
|
const shouldRun = selectedTests === null || selectedTests.includes(testName);
|
|
(shouldRun ? test.concurrent : test.skip)(testName, fn, timeout);
|
|
}
|
|
|
|
// --- Eval result collector ---
|
|
|
|
const evalCollector = evalsEnabled && !SKIP ? new EvalCollector('e2e-gemini') : null;
|
|
|
|
function recordGeminiE2E(name: string, result: GeminiResult, passed: boolean) {
|
|
evalCollector?.addTest({
|
|
name,
|
|
suite: 'gemini-e2e',
|
|
tier: 'e2e',
|
|
passed,
|
|
duration_ms: result.durationMs,
|
|
cost_usd: 0,
|
|
output: result.output?.slice(0, 2000),
|
|
turns_used: result.toolCalls.length,
|
|
exit_reason: result.exitCode === 0 ? 'success' : `exit_code_${result.exitCode}`,
|
|
});
|
|
}
|
|
|
|
function logGeminiCost(label: string, result: GeminiResult) {
|
|
const durationSec = Math.round(result.durationMs / 1000);
|
|
console.log(`${label}: ${result.tokens} tokens, ${result.toolCalls.length} tool calls, ${durationSec}s`);
|
|
}
|
|
|
|
// Finalize eval results on exit
|
|
afterAll(async () => {
|
|
if (evalCollector) {
|
|
await evalCollector.finalize();
|
|
}
|
|
});
|
|
|
|
// --- Tests ---
|
|
|
|
describeGemini('Gemini E2E', () => {
|
|
let testWorktree: string;
|
|
|
|
beforeAll(() => {
|
|
testWorktree = createTestWorktree('gemini');
|
|
});
|
|
|
|
afterAll(() => {
|
|
harvestAndCleanup('gemini');
|
|
});
|
|
|
|
testIfSelected('gemini-smoke', async () => {
|
|
// Smoke test: can Gemini start, read the repo, and produce output?
|
|
// Uses a simple prompt that doesn't require skill invocation or complex navigation.
|
|
const result = await runGeminiSkill({
|
|
prompt: 'What is this project? Answer in one sentence based on the README.',
|
|
timeoutMs: JUDGE_MS,
|
|
cwd: testWorktree,
|
|
});
|
|
|
|
logGeminiCost('gemini-smoke', result);
|
|
|
|
// Pass if Gemini produced any meaningful output (even with non-zero exit from timeout)
|
|
const hasOutput = result.output.length > 10;
|
|
const passed = hasOutput;
|
|
recordGeminiE2E('gemini-smoke', result, passed);
|
|
|
|
expect(result.output.length, 'Gemini should produce output').toBeGreaterThan(10);
|
|
}, JUDGE_MS);
|
|
});
|