mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-26 21:12:26 +02:00
66f3a180d3
* fix(gbrain-sync): --full produces an empty code index on first run of a new repo
`gbrain reindex-code` only RE-EMBEDS pages that already exist; it never walks
the filesystem. On a freshly-registered source (0 pages), a --full run that
called reindex-code alone found nothing ("No code pages to reindex"), finished
in ~1s, and left the code index permanently empty while still reporting OK.
Fix: --full now runs `sync --strategy code` FIRST to create pages via the file
walk, then runs `reindex-code` to honor the documented "full walk + reindex"
contract for both fresh and populated sources.
Contributed by @jetsetterfl via #1584.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(gbrain-local-status): classifier falsely reports broken-db inside repos with their own DATABASE_URL
The freshClassify probe ran `gbrain sources list --json` with the inherited
process env. When the probe ran from inside a repo with its own .env (an app
DATABASE_URL on a different port), Bun autoloaded the project's .env, gbrain
connected to the wrong database, and the classifier reported broken-db on
otherwise-healthy brains.
Fix: route the probe env through `buildGbrainEnv` from lib/gbrain-exec, the
same helper the sync orchestrator uses. DATABASE_URL is seeded from
~/.gbrain/config.json so the result is cwd-independent. The 60s cache can no
longer propagate a poisoned negative to clean directories.
Contributed by @jetsetterfl via #1583.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(retro): stale-base + bad-today-anchor pre-flight guard (#1624)
/retro silently produced confidently-wrong output when "today" drifted (model
session-context error) or when origin/<default> was materially behind the
actual remote — git log --since returned zero or near-zero commits and the
narrative was fabricated from nothing.
Adds Step 0.5 with four ordered pre-check branches before any window analysis:
A. No 'origin' remote → skip with "base freshness not verified" note
B. Detached HEAD → skip with "base freshness not verified" note
C. `git fetch origin <default>` fails (offline) → warn, proceed against
last-known origin/<default>
D. Fetch succeeded → compare today vs latest origin/<default> commit; if
gap > window-days, BLOCK with explicit citation of latest-commit date.
Skip paths still proceed to Step 1, but the disclosure is carried into the
retro narrative ("offline run, window not freshness-verified") so the output
is never silently confidently-wrong.
Atomic .tmpl + gen:skill-docs regen commit (T-Codex-3 pattern).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(retro): regression for #1624 stale-base pre-flight guard
13 static-invariant tests pinning the four ordered pre-check branches in
retro/SKILL.md.tmpl:Step 0.5:
A. no-remote skip — must check origin presence + set verdict
B. detached-HEAD skip — must gate behind prior verdict (ordering)
C. fetch-fail warn — must match `if !` or `||` shape, gate by verdict
D. stale-base BLOCK — must read latest-commit ISO date, cite remediation
Plus a disclosure-survives-to-narrative invariant: skip-path verdicts must be
named in prose so the retro output carries the cited reason rather than
silently misreporting.
Failing build if Step 0.5 is removed, branches re-ordered (no-remote no longer
wins), or the BLOCK message stops citing today/latest-commit/remediation
path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(gbrain-sync): configurable timeouts + resume from gbrain checkpoint (#1611)
The memory and code stages hardcoded a 35-min spawn timeout. On brains with
~2000+ staged files, /sync-gbrain --full reliably SIGTERM'd the child at
exactly 35 minutes with exit 143. gbrain left ~/.gbrain/import-checkpoint.json
pointing at the staging dir, but gstack-memory-ingest's SIGTERM handler
unconditionally cleaned the dir up — so the next run found a checkpoint
pointing at nothing and restaged from scratch, repeating the SIGTERM forever.
Three changes:
1. Configurable timeouts via env (bounds 60_000ms - 86_400_000ms, default
2_100_000ms = 35min unchanged):
GSTACK_SYNC_MEMORY_TIMEOUT_MS
GSTACK_SYNC_CODE_TIMEOUT_MS
Out-of-range or non-numeric values warn and fall back to the default.
2. SIGTERM in gstack-memory-ingest no longer always cleans up the staging
dir. If gbrain has written ~/.gbrain/import-checkpoint.json pointing at
the active staging dir, the dir is PRESERVED for next-run resume.
Otherwise (no checkpoint pointing here, crash before gbrain ever
touched it) it's cleaned up as before.
3. Next /sync-gbrain run detects gbrain's checkpoint via decideResume() in
gstack-gbrain-sync.ts:
- no checkpoint → fresh ingest pass
- checkpoint + staging ok → set GSTACK_INGEST_RESUME_DIR; child
reuses staging dir and skips
writeStaged; gbrain import resumes
from processedIndex+1
- checkpoint + staging gone → warn "previous checkpoint stale
(staging dir gone), restaging from
scratch" and proceed
Reuses gbrain's own checkpoint as the source of truth (D1 — no double-store
state). Detect-then-fallback semantics per C1.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(gbrain-sync): regression for #1611 timeouts + resume
19 tests across three surfaces:
- resolveStageTimeoutMs (10 tests): undefined/empty → default; non-numeric,
zero, negative, below-floor, above-ceiling → warn + default; at-floor,
at-ceiling, valid mid-range → accepted as-is.
- decideResume (6 tests): no checkpoint, corrupt JSON, checkpoint + staging
ok, checkpoint + staging missing, checkpoint with no dir, checkpoint with
empty dir.
- SIGTERM staging preservation (3 static invariants): memory-ingest signal
handler must check stagingDirIsCheckpointed BEFORE cleanup; preserve
branch must come before cleanup branch (ordering); orchestrator must
pass GSTACK_INGEST_RESUME_DIR to the grandchild on resume.
Also threads process.env.HOME through readGbrainCheckpoint and
stagingDirIsCheckpointed so tests can redirect home. os.homedir() caches
at process start and ignores later mutation, so the env override is the
only reliable test injection point.
Failing build if the timeout bounds are removed, the resume detection
short-circuits incorrectly, or the SIGTERM handler regresses to
unconditional cleanup.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(review): pre-emit verification gate kills Django-shape FP class (#1539)
External user filed 4/8 false positives on a /review run against a Django +
DRF + PostgreSQL repo (Sprint 2.5). Every FP class was the same shape:
"resolvable in <5 minutes by viewing the actual code or running a simple
grep" — fields that don't exist on the model, dict.get()-might-be-None on a
form that returns {}-initialized cleaned_data, standard ORM save behavior
called out as data loss.
Extends the Confidence Calibration resolver (consumed by review, cso,
plan-eng-review, ship) with a Pre-emit verification gate:
Every finding MUST quote the specific code line that motivates it
(file:line + verbatim text). If the reviewer cannot produce the quote,
the finding is unverified — its confidence is forced to 4-5 so the
existing "Suppress from main report" rule fires automatically. The
finding still goes to the appendix for calibration audit, but the user
does not see it in the critical-pass output.
Reuses the existing suppression mechanism — no new code path. The FP
classes the gate kills are enumerated in the resolver text so reviewers
see the named patterns.
Framework-meta nudge included for Django Meta, Rails associations,
SQLAlchemy relationships, TypeORM decorators, Sequelize init, Prisma
generated client — the reviewer must quote the meta-construct that
generates the symbol, not just grep for the literal name. Deeper
framework-aware ORM verification (model introspection, migration-history-
aware checks) is deliberately deferred to a future wave per T-Codex-2.
Atomic .tmpl-equivalent (resolver) edit + gen:skill-docs regen commit
per T-Codex-3.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(review): regression for #1539 pre-emit verification gate
12 tests pinning the gate behavior:
- Resolver emits the gate header + #1539 reference
- Gate requires quoting file:line + verbatim text
- Unverified findings forced to confidence 4-5 (auto-suppress via
existing <7-rule, no new mechanism)
- Framework-meta nudge names Django, Rails, SQLAlchemy, TypeORM,
Sequelize, Prisma
- Deferred design doc reference present (1539-framework-aware-review.md)
- Four named FP classes from #1539 enumerated:
* field doesn't exist on model
* dict.get() might be None
* save() might lose fields
* update_fields might miss X
- All four downstream SKILL.md consumers (review, cso, plan-eng-review,
ship) carry the gate text after gen:skill-docs
- Existing confidence 9-10 'Show normally' + 3-4 'Suppress' rows
unchanged (regression on existing behavior)
Failing build if the gate is removed, the suppression mechanism is
re-invented separately, the framework-meta nudge drops a framework, or
gen:skill-docs stops propagating the gate to consumers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(config): expose explain_level default
* fix(benchmark): parse positional prompt after flags
* fix(artifacts): reject malformed remote paths
* fix(learnings): preserve current entries in cross-project search
* fix(setup): register root gstack slash alias
* fix(memory): probe gitleaks without shell builtin
* fix(gbrain-lib): pin LC_ALL=C in varname validator (macOS locale guard)
In many macOS shells the default locale (e.g. en_US.UTF-8) makes bash
glob brackets like `[A-Z]` match lowercase letters too, so the existing
`case "$name" in [A-Z_][A-Z0-9_]*)` branch lets names like `lower-case`
through validation. The function then trips `printf -v "$varname"` and
`export "$varname"` with `not a valid identifier` errors that surface
mid-prompt, which is exactly what the validator was supposed to prevent.
Pinning `LC_ALL=C` inside the function gives ASCII-only bracket semantics
on both macOS and Linux, matching the documented `[A-Z_][A-Z0-9_]*`
contract. Declared `local` so it doesn't leak to the calling shell —
`gstack-gbrain-lib.sh` is documented as a sourced helper, so a bare
assignment would mutate the caller's locale for the rest of the process
(silently affecting downstream `sort`, `tr`, locale-aware globs in the
same shell, etc.).
The existing regression test
`test/gbrain-lib-verify.test.ts:'rejects invalid var names'`
already covers the macOS repro shape (passes `lower-case` and expects
the validator to reject + emit `invalid var name`). On Linux CI the
test silently passed because `LC_ALL=C` is the typical default; on
macOS dev boxes it fails.
Verified:
- `bun test test/gbrain-lib-verify.test.ts`: 22 pass, 0 fail (on macOS).
- `_gstack_gbrain_validate_varname lower-case; echo $?` → 2.
- `_gstack_gbrain_validate_varname FOO_BAR; echo $?` → 0.
- Caller's LC_ALL preserved across calls (confirmed via sourced bash).
* fix(land-and-deploy): detect merged PR after gh failure
After `gh pr merge` exits non-zero, the PR may already be MERGED server-side
(concurrent merge landed, or local cleanup phase failed AFTER the merge
succeeded). Calling `gh pr merge` a second time then errors with a confusing
"already merged" — and worse, the deploy workflow never runs because we
stopped on the first failure.
Adds a Post-failure PR-state check (§4a-postfail) that runs after ANY
non-zero exit from `gh pr merge`:
- state == MERGED → record MERGE_PATH=direct, OFFER (don't force)
stale-worktree cleanup on the base branch with
uncommitted-work guard, proceed to §4a CI watch
- state == OPEN → check autoMergeRequest; if non-null treat as
merge-queue wait; if null surface both errors and STOP
- state == CLOSED → STOP
Hard invariant: never retry `gh pr merge` after a non-zero exit. Server
state is authoritative.
Re-authored from PR #1620 into land-and-deploy/SKILL.md.tmpl (the source of
truth) instead of the generated SKILL.md, so the next gen:skill-docs run
preserves the change. Original diff by @davidfoy via #1620.
Related: cli/cli#3442, cli/cli#13380.
Contributed by @davidfoy via #1620.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: detect PgBouncer transaction-mode pooler and set GBRAIN_PREPARE=true (#1435)
When gbrain connects through a PgBouncer transaction-mode pooler (port
6543), it auto-disables prepared statements. This breaks `gbrain search`
silently — the /sync-gbrain capability check fails and the GBrain Search
Guidance block never gets written to CLAUDE.md.
Three-layer fix:
1. **lib/gbrain-exec.ts** — `buildGbrainEnv()` now detects port 6543 in
the effective DATABASE_URL and sets `GBRAIN_PREPARE=true` in the env
passed to every gbrain spawn. This is the single chokepoint — all
gstack gbrain invocations inherit the fix. Caller can opt out with
`GBRAIN_PREPARE=false`.
2. **sync-gbrain/SKILL.md{,.tmpl}** — capability check now exports
`GBRAIN_PREPARE=true` explicitly and retries search up to 3x with 1s
delay for async index propagation under connection pooling.
3. **bin/gstack-gbrain-detect** — surfaces `gbrain_pooler_mode` field
("transaction" | "session" | null) in the preamble probe JSON so
/setup-gbrain and /sync-gbrain can advise users about pooler state.
Closes #1435
Built with [ClosedLoop.AI](https://closedloop.ai) | [GitHub](https://github.com/closedloop-ai/claude-plugins)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(supabase-provision): rewrite transaction/6543 -> session/5432 for new projects
- Single-object pooler API responses default to transaction-mode at 6543,
but the shared pooler tenant on new projects only listens on session/5432
- Add a `pool_mode == transaction && db_port == 6543` rewrite + stderr note
- Escape hatch via `GSTACK_SUPABASE_TRUST_API_PORT=1` for forward-compat
- 5 new tests covering rewrite, no-op shapes, env opt-out, array path
Fixes #1301.
* fix(browse): GSTACK_CHROMIUM_NO_SANDBOX opt-out for Ubuntu/AppArmor (#1562)
Ubuntu/AppArmor configurations often block unprivileged Chromium sandboxing
for headless agent sessions even for normal users — /qa hangs without
--no-sandbox. The kernel policy denies the unprivileged user namespaces
Chromium needs.
Adds GSTACK_CHROMIUM_NO_SANDBOX=1 as an explicit user override that forces
the sandbox off without changing the default for everyone else. Re-authored
from PR #1562 onto v1.42.2.0's shouldEnableChromiumSandbox() helper —
purely additive, preserves the headed-launch sandbox-on-by-default behavior
that v1.42.2.0 shipped to kill the --no-sandbox yellow infobar.
Three new regression tests cover:
- linux + override=1 → false (the named use case)
- darwin + override=1 → false (env wins on any platform)
- override=0 → does NOT trigger (must be exactly "1")
Original diff by @techcenter68 via #1562.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(browse): mirror isCustomChromium() guard in headless launch()
When BROWSE_EXTENSIONS_DIR is set alongside GSTACK_CHROMIUM_PATH pointing
at a baked-extension build (GBrowser / GStack Browser), the headless launch()
path was unconditionally adding --disable-extensions-except / --load-extension.
This causes the same ServiceWorkerState::SetWorkerId DCHECK crash that
launchHeaded() already guards against via isCustomChromium().
Mirror the existing guard: skip --load-extension flags when isCustomChromium()
returns true; always push the off-screen window geometry args.
* fix(browse): daemonize macOS/Linux server via setsid()
`Bun.spawn().unref()` only releases the child from Bun's event loop —
it does NOT call setsid(). The spawned bun server inherits the spawning
shell's process session. When the CLI runs inside a session-managed shell
that exits shortly after the CLI returns (Claude Code's per-command Bash
sandbox, Conductor, OpenClaw, CI step runners), the session leader's exit
sends SIGHUP to every PID in the session — killing the bun server and
its Chromium grandchildren within seconds of a successful `connect`.
Setting `BROWSE_PARENT_PID=0` (already done by the `connect` command and
pair-agent) disables the parent-process watchdog but does NOT save the
server here: SIGHUP from session teardown still reaps it.
Replace the macOS/Linux `Bun.spawn().unref()` with Node's
`child_process.spawn({ detached: true })`, which calls setsid() and
gives the server its own session leader role (PPID=1, STAT=Ss). This
mirrors the Windows path's rationale (PR #191 by @fqueiro) — same root
cause, different OS surface.
Verified on macOS in Conductor: pre-fix the server dies ~10–15s after
connect across separate Bash invocations; post-fix the same PID stays
alive (PPID=1, SESS=0, STAT=Ss) and responds to `status`/`goto`/
`snapshot` across many separate shell calls.
The `proc?.stderr` startup-error branch is removed since both platforms
now spawn with `stdio: 'ignore'`; both fall through to the on-disk
`browse-startup-error.log` written by `server.ts`'s start().catch.
* fix(design): bump image-gen timeout to 240s + pin gpt-image-2
The design binary calls /v1/responses (gpt-4o + image_generation tool,
quality:high, 1536x1024) but aborted the request after a hardcoded 120s.
That class of request consistently takes ~140-160s end-to-end, so every
generate/variants/evolve/iterate call aborted before the image returned.
In /design-shotgun this cascades: Step 3c launches N parallel agents,
each calling `$D generate`, each aborts at 120s and retries, all fail,
the comparison board never opens — the skill appears to hang indefinitely.
Reproduced the exact API call with a longer budget: HTTP 200, valid
image, 143.5s. A real /design-shotgun run after the patch generated 3
variants in parallel at 150.0s / 161.0s / 152.1s, all exit 0 — note the
161s case, which a naive 150s bump would still have failed.
- Bump AbortController timeout 120_000 -> 240_000 in generate.ts,
variants.ts, evolve.ts, iterate.ts (both call sites)
- Pin the image_generation tool to model "gpt-image-2"
design/test/variants-retry-after.test.ts: 5 pass, 0 fail. The
feedback-roundtrip.test.ts failures are a pre-existing browse-module
breakage (session.clearLoadedHtml undefined), unrelated to this change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test: fill coverage gaps for PRs #1606, #1612, #1620
Three cherry-picked PRs in this wave landed without unit-test coverage for
the specific invariant they protect:
#1606 (@andrey-esipov) — LC_ALL=C pin in _gstack_gbrain_validate_varname
8 tests by sourcing bin/gstack-gbrain-lib.sh and calling the validator
directly. Asserts uppercase/digit/underscore accepted, lowercase
REJECTED (the macOS-locale regression case), mixed-case rejected,
LC_ALL=C scoping is local (doesn't leak to caller).
#1612 (@bharat2913) — setsid daemonize via Node child_process.spawn
4 static-invariant tests on browse/src/cli.ts. The actual setsid
syscall is hard to assert without a real spawn, so we pin the source
shape: nodeSpawn imported from child_process; non-Windows branch uses
nodeSpawn(...) with detached:true and .unref(); comment documents
setsid/SIGHUP root cause; Bun.spawn() is NOT used on macOS/Linux.
#1620 (@davidfoy, re-authored into .tmpl per A3) — §4a-postfail
12 static invariants on land-and-deploy/SKILL.md.tmpl + generated
SKILL.md. Pins all three state branches (MERGED/OPEN/CLOSED), the
authoritative state query, the merge-SHA capture, non-destructive
worktree cleanup with uncommitted-work guard, autoMergeRequest probe
on OPEN, hard "never retry gh pr merge" rule, and atomic regen
propagation.
Failing build if any of the three invariants regresses.
Note: gbrain-lib-validate-varname.test.ts also surfaces a pre-existing
glob-pattern overpermissiveness (hyphens + dots accepted) — not in
#1606's scope; documented inline as a separate cleanup target.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(learnings): align injection-prevention tests with PR #1619 tagged-line shape
PR #1619 (preserve current entries in cross-project search) refactored
gstack-learnings-search to tag rows inline (`current\t<json>` vs
`cross\t<json>`) instead of filtering inside the bun block via
process.env.GSTACK_SEARCH_SLUG. The bun block no longer reads SLUG or
CROSS env vars — it parses the per-line tag and sets a per-entry
_crossProject flag.
The pre-existing test/learnings-injection.test.ts still asserted on the
old SLUG + CROSS env var shape. Updates:
- Remove the SLUG env var assertion (no longer set on bash command line)
- Remove the bun-block CROSS env var assertion (block reads the tag now,
not the env)
- Add a new positive assertion that the bun block parses the tag
(sourceTag | tabIndex | crossProject)
- Keep the shell-interpolation safety assertion unchanged — that's
independent of the SLUG refactor
The CROSS env var is still SET on the bash command line (it controls
whether the cross-project find runs at all), but the bun child no longer
reads it. The existing "env vars set on bash command line" test continues
to pin that.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(fixtures): regenerate ship-SKILL.md golden baselines
ship/SKILL.md consumes the Confidence Calibration resolver via the
preamble pipeline. This wave's #1539 pre-emit verification gate extends
the resolver text, which propagated to ship/SKILL.md via gen:skill-docs.
The golden fixtures in test/fixtures/golden/ matched the pre-#1539 shape
and failed the host-config regression check.
Refreshes claude-ship-SKILL.md, codex-ship-SKILL.md, and factory-ship-SKILL.md
to match the current generated output. Matches the Daegu wave's bisect
commit 23 ("test(fixtures): regenerate ship-SKILL.md golden baselines").
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(gbrain-detect): include gbrain_pooler_mode in schema regression (PR #1591)
PR #1591 (PgBouncer transaction-mode detection, @mikeangstadt) added
gbrain_pooler_mode to the gstack-gbrain-detect JSON output but did not
update the schema regression check in
test/gstack-gbrain-detect-mcp-mode.test.ts. Adding the key in alphabetical
order matching the rest of the schema array. Downstream sync-gbrain ignores
unknown keys, so this is forward-compat.
Without this, the test fails with a diff:
+ "gbrain_pooler_mode"
because keys is the actual set returned and the expected array was
pre-#1591.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(release): v1.43.0.0 — post-Daegu paper-cut wave
Bumps VERSION 1.42.2.0 → 1.43.0.0 (MINOR per scale-aware bump rules: new
env-var surface GSTACK_SYNC_*_TIMEOUT_MS + GSTACK_CHROMIUM_NO_SANDBOX,
behavior expansion in browse/src/browser-manager.ts headless launch,
three skill-template prompt changes affecting /retro, /review,
/sync-gbrain).
CHANGELOG entry leads with what stopped happening: /retro stops
fabricating retros against stale bases, /sync-gbrain stops SIGTERM-looping
35-min restarts on big brains, /review stops shipping framework FPs the
reviewer never grep'd.
18 fixes total — 15 community PRs + 3 self-filed silent-failure issues
(#1624, #1611, #1539) — in one bundled PR with 26 bisect commits and 7
new regression test files. Every wave-touched test file passes in
isolation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(release): bump v1.43.0.0 → v1.43.2.0 for queue collision
CI check-version-stale flagged v1.43.0.0 already claimed by PR #1574
(garrytan/colombo-v3). PR #1639 (garrytan/muscat-v3) claims v1.43.1.0.
Next available MINOR slot is v1.43.2.0.
Bump VERSION + package.json + CHANGELOG entry header. No behavior
changes — purely re-versioning to clear the queue collision.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Jayesh Betala <jayesh.betala7@gmail.com>
Co-authored-by: Andrey Esipov <andrey.esipov@outlook.com>
Co-authored-by: David Foy <davidfoy@users.noreply.github.com>
Co-authored-by: mikeangstadt <mike.angstadt@closedloop.ai>
Co-authored-by: 0xDevNinja <manmit0x@gmail.com>
Co-authored-by: techcenter68 <techcenter68@users.noreply.github.com>
Co-authored-by: shohu <shohu33@gmail.com>
Co-authored-by: Bharat <bharat@theysaid.io>
Co-authored-by: Matteo Hertel <info@matteohertel.com>
961 lines
41 KiB
Cheetah
961 lines
41 KiB
Cheetah
---
|
||
name: retro
|
||
preamble-tier: 2
|
||
version: 2.0.0
|
||
description: |
|
||
Weekly engineering retrospective. Analyzes commit history, work patterns,
|
||
and code quality metrics with persistent history and trend tracking.
|
||
Team-aware: breaks down per-person contributions with praise and growth areas.
|
||
Use when asked to "weekly retro", "what did we ship", or "engineering retrospective".
|
||
Proactively suggest at the end of a work week or sprint. (gstack)
|
||
allowed-tools:
|
||
- Bash
|
||
- Read
|
||
- Write
|
||
- Glob
|
||
- AskUserQuestion
|
||
triggers:
|
||
- weekly retro
|
||
- what did we ship
|
||
- engineering retrospective
|
||
gbrain:
|
||
schema: 1
|
||
context_queries:
|
||
- id: prior-retros
|
||
kind: filesystem
|
||
glob: "~/.gstack/projects/{repo_slug}/retros/*.md"
|
||
sort: mtime_desc
|
||
limit: 5
|
||
render_as: "## Prior retros for this project"
|
||
- id: recent-timeline
|
||
kind: filesystem
|
||
glob: "~/.gstack/projects/{repo_slug}/timeline.jsonl"
|
||
tail: 30
|
||
render_as: "## Recent timeline events"
|
||
- id: recent-learnings
|
||
kind: filesystem
|
||
glob: "~/.gstack/projects/{repo_slug}/learnings.jsonl"
|
||
tail: 10
|
||
render_as: "## Recent learnings"
|
||
---
|
||
|
||
{{PREAMBLE}}
|
||
|
||
{{BASE_BRANCH_DETECT}}
|
||
|
||
# /retro — Weekly Engineering Retrospective
|
||
|
||
Generates a comprehensive engineering retrospective analyzing commit history, work patterns, and code quality metrics. Team-aware: identifies the user running the command, then analyzes every contributor with per-person praise and growth opportunities. Designed for a senior IC/CTO-level builder using Claude Code as a force multiplier.
|
||
|
||
## User-invocable
|
||
When the user types `/retro`, run this skill.
|
||
|
||
## Arguments
|
||
- `/retro` — default: last 7 days
|
||
- `/retro 24h` — last 24 hours
|
||
- `/retro 14d` — last 14 days
|
||
- `/retro 30d` — last 30 days
|
||
- `/retro compare` — compare current window vs prior same-length window
|
||
- `/retro compare 14d` — compare with explicit window
|
||
- `/retro global` — cross-project retro across all AI coding tools (7d default)
|
||
- `/retro global 14d` — cross-project retro with explicit window
|
||
|
||
{{GBRAIN_CONTEXT_LOAD}}
|
||
|
||
## Instructions
|
||
|
||
Parse the argument to determine the time window. Default to 7 days if no argument given. All times should be reported in the user's **local timezone** (use the system default — do NOT set `TZ`).
|
||
|
||
**Midnight-aligned windows:** For day (`d`) and week (`w`) units, compute an absolute start date at local midnight, not a relative string. For example, if today is 2026-03-18 and the window is 7 days: the start date is 2026-03-11. Use `--since="2026-03-11T00:00:00"` for git log queries — the explicit `T00:00:00` suffix ensures git starts from midnight. Without it, git uses the current wall-clock time (e.g., `--since="2026-03-11"` at 11pm means 11pm, not midnight). For week units, multiply by 7 to get days (e.g., `2w` = 14 days back). For hour (`h`) units, use `--since="N hours ago"` since midnight alignment does not apply to sub-day windows.
|
||
|
||
**Argument validation:** If the argument doesn't match a number followed by `d`, `h`, or `w`, the word `compare` (optionally followed by a window), or the word `global` (optionally followed by a window), show this usage and stop:
|
||
```
|
||
Usage: /retro [window | compare | global]
|
||
/retro — last 7 days (default)
|
||
/retro 24h — last 24 hours
|
||
/retro 14d — last 14 days
|
||
/retro 30d — last 30 days
|
||
/retro compare — compare this period vs prior period
|
||
/retro compare 14d — compare with explicit window
|
||
/retro global — cross-project retro across all AI tools (7d default)
|
||
/retro global 14d — cross-project retro with explicit window
|
||
```
|
||
|
||
**If the first argument is `global`:** Skip the normal repo-scoped retro (Steps 1-14). Instead, follow the **Global Retrospective** flow at the end of this document. The optional second argument is the time window (default 7d). This mode does NOT require being inside a git repo.
|
||
|
||
{{LEARNINGS_SEARCH}}
|
||
|
||
### Non-git context (optional)
|
||
|
||
Check for non-git context that should be included in the retro:
|
||
|
||
```bash
|
||
[ -f ~/.gstack/retro-context.md ] && echo "RETRO_CONTEXT_FOUND" || echo "NO_RETRO_CONTEXT"
|
||
```
|
||
|
||
If `RETRO_CONTEXT_FOUND`: read `~/.gstack/retro-context.md`. This file is user-authored and may contain meeting notes, calendar events, decisions, and other context that doesn't appear in git history. Incorporate this context into the retro narrative where relevant.
|
||
|
||
### Step 0.5: Stale-base + bad-today-anchor pre-flight guard
|
||
|
||
The retro skill computes a window from "today" and queries `git log --since=<window> origin/<default>`. If "today" drifts (model session-context error) or the local worktree's `origin/<default>` is materially behind the actual remote, the window can return zero or near-zero commits and the retro will fabricate a coherent-looking narrative from nothing. This guard prevents silent confidently-wrong output.
|
||
|
||
Run the pre-flight in this exact order. The first branch that matches wins:
|
||
|
||
```bash
|
||
# Pre-check A: no remote configured?
|
||
_RETRO_HAS_REMOTE=$(git remote 2>/dev/null | grep -c '^origin$' || echo 0)
|
||
if [ "$_RETRO_HAS_REMOTE" = "0" ]; then
|
||
echo "RETRO_GUARD: no 'origin' remote, base freshness not verified — proceeding"
|
||
_RETRO_GUARD_VERDICT="skip-no-remote"
|
||
fi
|
||
|
||
# Pre-check B: detached HEAD or no current base?
|
||
if [ -z "$_RETRO_GUARD_VERDICT" ]; then
|
||
_RETRO_HEAD_REF=$(git symbolic-ref --quiet HEAD 2>/dev/null || echo "")
|
||
if [ -z "$_RETRO_HEAD_REF" ]; then
|
||
echo "RETRO_GUARD: detached HEAD, base freshness not verified — proceeding"
|
||
_RETRO_GUARD_VERDICT="skip-detached"
|
||
fi
|
||
fi
|
||
|
||
# Pre-check C: fetch origin <default>; if it fails, warn but proceed.
|
||
if [ -z "$_RETRO_GUARD_VERDICT" ]; then
|
||
if ! git fetch origin <default> --quiet 2>/dev/null; then
|
||
echo "RETRO_GUARD: 'git fetch origin <default>' failed (offline?) — proceeding against last-known origin/<default>"
|
||
_RETRO_GUARD_VERDICT="warn-fetch-failed"
|
||
fi
|
||
fi
|
||
|
||
# Pre-check D: BLOCK only when fetch succeeded AND the latest origin/<default>
|
||
# commit predates the retro window. Today's date should be loaded from the
|
||
# user-visible "## currentDate" tag in the session reminder; if the gap between
|
||
# origin/<default>'s newest commit and today exceeds the window, the model's
|
||
# "today" is almost certainly stale (or the worktree is wildly behind).
|
||
if [ -z "$_RETRO_GUARD_VERDICT" ]; then
|
||
_RETRO_LATEST_ISO=$(git log -1 --format=%ci origin/<default> 2>/dev/null | awk '{print $1}')
|
||
if [ -n "$_RETRO_LATEST_ISO" ]; then
|
||
# The model computes today from the session reminder (NEVER from `date` —
|
||
# the system clock can be hours off in containerized harnesses).
|
||
# Compute window in DAYS (default 7): if today - latest-commit-date > window-days,
|
||
# BLOCK. If the model cannot reliably compute "today", it MUST stop here and
|
||
# ask the user via AskUserQuestion rather than proceeding.
|
||
echo "RETRO_GUARD: latest origin/<default> commit on $_RETRO_LATEST_ISO"
|
||
_RETRO_GUARD_VERDICT="check-gap"
|
||
fi
|
||
fi
|
||
```
|
||
|
||
After running the bash block, the model evaluates `RETRO_GUARD: latest origin/<default> commit on <DATE>` against today and the window:
|
||
|
||
- If the **latest-commit date is older than (today − window-days)**, BLOCK with: "Retro window is stale. Latest commit on `origin/<default>` was `<DATE>`, but the window covers `<since>` to `<today>`. This usually means either (a) today's date is wrong in this session or (b) `origin/<default>` is materially behind the remote. Confirm today's date via the session reminder; if today is correct, run `git fetch origin <default>` manually and re-run /retro." Stop the skill until the user resolves.
|
||
- Otherwise, write: "RETRO_GUARD: latest commit `<DATE>` within window — proceeding."
|
||
|
||
Skip paths (`skip-no-remote`, `skip-detached`, `warn-fetch-failed`) all proceed to Step 1 with the cited reason on a single stderr line so the retro narrative carries the disclosure ("offline run, window not freshness-verified") rather than silently misreporting.
|
||
|
||
### Step 1: Gather Raw Data
|
||
|
||
First, fetch origin and identify the current user:
|
||
```bash
|
||
git fetch origin <default> --quiet
|
||
# Identify who is running the retro
|
||
git config user.name
|
||
git config user.email
|
||
```
|
||
|
||
The name returned by `git config user.name` is **"you"** — the person reading this retro. All other authors are teammates. Use this to orient the narrative: "your" commits vs teammate contributions.
|
||
|
||
Run ALL of these git commands in parallel (they are independent):
|
||
|
||
```bash
|
||
# 1. All commits in window with timestamps, subject, hash, AUTHOR, files changed, insertions, deletions
|
||
git log origin/<default> --since="<window>" --format="%H|%aN|%ae|%ai|%s" --shortstat
|
||
|
||
# 2. Per-commit test vs total LOC breakdown with author
|
||
# Each commit block starts with COMMIT:<hash>|<author>, followed by numstat lines.
|
||
# Separate test files (matching test/|spec/|__tests__/) from production files.
|
||
git log origin/<default> --since="<window>" --format="COMMIT:%H|%aN" --numstat
|
||
|
||
# 3. Commit timestamps for session detection and hourly distribution (with author)
|
||
git log origin/<default> --since="<window>" --format="%at|%aN|%ai|%s" | sort -n
|
||
|
||
# 4. Files most frequently changed (hotspot analysis)
|
||
git log origin/<default> --since="<window>" --format="" --name-only | grep -v '^$' | sort | uniq -c | sort -rn
|
||
|
||
# 5. PR/MR numbers from commit messages (GitHub #NNN, GitLab !NNN)
|
||
git log origin/<default> --since="<window>" --format="%s" | grep -oE '[#!][0-9]+' | sort -t'#' -k1 | uniq
|
||
|
||
# 6. Per-author file hotspots (who touches what)
|
||
git log origin/<default> --since="<window>" --format="AUTHOR:%aN" --name-only
|
||
|
||
# 7. Per-author commit counts (quick summary)
|
||
git shortlog origin/<default> --since="<window>" -sn --no-merges
|
||
|
||
# 8. Greptile triage history (if available)
|
||
cat ~/.gstack/greptile-history.md 2>/dev/null || true
|
||
|
||
# 9. TODOS.md backlog (if available)
|
||
cat TODOS.md 2>/dev/null || true
|
||
|
||
# 10. Test file count
|
||
find . -name '*.test.*' -o -name '*.spec.*' -o -name '*_test.*' -o -name '*_spec.*' 2>/dev/null | grep -v node_modules | wc -l
|
||
|
||
# 11. Regression test commits in window
|
||
git log origin/<default> --since="<window>" --oneline --grep="test(qa):" --grep="test(design):" --grep="test: coverage"
|
||
|
||
# 12. gstack skill usage telemetry (if available)
|
||
cat ~/.gstack/analytics/skill-usage.jsonl 2>/dev/null || true
|
||
|
||
# 12. Test files changed in window
|
||
git log origin/<default> --since="<window>" --format="" --name-only | grep -E '\.(test|spec)\.' | sort -u | wc -l
|
||
```
|
||
|
||
### Step 2: Compute Metrics
|
||
|
||
Calculate and present these metrics in a summary table:
|
||
|
||
| Metric | Value |
|
||
|--------|-------|
|
||
| **Features shipped** (from CHANGELOG + merged PR titles) | N |
|
||
| Commits to main | N |
|
||
| Weighted commits (commits × avg files-touched, capped at 20 per commit) | N |
|
||
| Contributors | N |
|
||
| PRs merged | N |
|
||
| **Logical SLOC added** (non-blank, non-comment — primary code-volume metric) | N |
|
||
| Raw LOC: insertions | N |
|
||
| Raw LOC: deletions | N |
|
||
| Raw LOC: net | N |
|
||
| Test LOC (insertions) | N |
|
||
| Test LOC ratio | N% |
|
||
| Version range | vX.Y.Z.W → vX.Y.Z.W |
|
||
| Active days | N |
|
||
| Detected sessions | N |
|
||
| Avg raw LOC/session-hour | N |
|
||
| Greptile signal | N% (Y catches, Z FPs) |
|
||
| Test Health | N total tests · M added this period · K regression tests |
|
||
|
||
**Metric order rationale (V1):** features shipped leads — what users got. Commits
|
||
and weighted commits reflect intent-to-ship. Logical SLOC added reflects real
|
||
new functionality. Raw LOC is demoted to context because AI inflates it; ten
|
||
lines of a good fix is not less shipping than ten thousand lines of scaffold.
|
||
See docs/designs/PLAN_TUNING_V1.md §Workstream C.
|
||
|
||
Then show a **per-author leaderboard** immediately below:
|
||
|
||
```
|
||
Contributor Commits +/- Top area
|
||
You (garry) 32 +2400/-300 browse/
|
||
alice 12 +800/-150 app/services/
|
||
bob 3 +120/-40 tests/
|
||
```
|
||
|
||
Sort by commits descending. The current user (from `git config user.name`) always appears first, labeled "You (name)".
|
||
|
||
**Greptile signal (if history exists):** Read `~/.gstack/greptile-history.md` (fetched in Step 1, command 8). Filter entries within the retro time window by date. Count entries by type: `fix`, `fp`, `already-fixed`. Compute signal ratio: `(fix + already-fixed) / (fix + already-fixed + fp)`. If no entries exist in the window or the file doesn't exist, skip the Greptile metric row. Skip unparseable lines silently.
|
||
|
||
**Backlog Health (if TODOS.md exists):** Read `TODOS.md` (fetched in Step 1, command 9). Compute:
|
||
- Total open TODOs (exclude items in `## Completed` section)
|
||
- P0/P1 count (critical/urgent items)
|
||
- P2 count (important items)
|
||
- Items completed this period (items in Completed section with dates within the retro window)
|
||
- Items added this period (cross-reference git log for commits that modified TODOS.md within the window)
|
||
|
||
Include in the metrics table:
|
||
```
|
||
| Backlog Health | N open (X P0/P1, Y P2) · Z completed this period |
|
||
```
|
||
|
||
If TODOS.md doesn't exist, skip the Backlog Health row.
|
||
|
||
**Skill Usage (if analytics exist):** Read `~/.gstack/analytics/skill-usage.jsonl` if it exists. Filter entries within the retro time window by `ts` field. Separate skill activations (no `event` field) from hook fires (`event: "hook_fire"`). Aggregate by skill name. Present as:
|
||
|
||
```
|
||
| Skill Usage | /ship(12) /qa(8) /review(5) · 3 safety hook fires |
|
||
```
|
||
|
||
If the JSONL file doesn't exist or has no entries in the window, skip the Skill Usage row.
|
||
|
||
**Eureka Moments (if logged):** Read `~/.gstack/analytics/eureka.jsonl` if it exists. Filter entries within the retro time window by `ts` field. For each eureka moment, show the skill that flagged it, the branch, and a one-line summary of the insight. Present as:
|
||
|
||
```
|
||
| Eureka Moments | 2 this period |
|
||
```
|
||
|
||
If moments exist, list them:
|
||
```
|
||
EUREKA /office-hours (branch: garrytan/auth-rethink): "Session tokens don't need server storage — browser crypto API makes client-side JWT validation viable"
|
||
EUREKA /plan-eng-review (branch: garrytan/cache-layer): "Redis isn't needed here — Bun's built-in LRU cache handles this workload"
|
||
```
|
||
|
||
If the JSONL file doesn't exist or has no entries in the window, skip the Eureka Moments row.
|
||
|
||
### Step 3: Commit Time Distribution
|
||
|
||
Show hourly histogram in local time using bar chart:
|
||
|
||
```
|
||
Hour Commits ████████████████
|
||
00: 4 ████
|
||
07: 5 █████
|
||
...
|
||
```
|
||
|
||
Identify and call out:
|
||
- Peak hours
|
||
- Dead zones
|
||
- Whether pattern is bimodal (morning/evening) or continuous
|
||
- Late-night coding clusters (after 10pm)
|
||
|
||
### Step 4: Work Session Detection
|
||
|
||
Detect sessions using **45-minute gap** threshold between consecutive commits. For each session report:
|
||
- Start/end time (Pacific)
|
||
- Number of commits
|
||
- Duration in minutes
|
||
|
||
Classify sessions:
|
||
- **Deep sessions** (50+ min)
|
||
- **Medium sessions** (20-50 min)
|
||
- **Micro sessions** (<20 min, typically single-commit fire-and-forget)
|
||
|
||
Calculate:
|
||
- Total active coding time (sum of session durations)
|
||
- Average session length
|
||
- LOC per hour of active time
|
||
|
||
### Step 5: Commit Type Breakdown
|
||
|
||
Categorize by conventional commit prefix (feat/fix/refactor/test/chore/docs). Show as percentage bar:
|
||
|
||
```
|
||
feat: 20 (40%) ████████████████████
|
||
fix: 27 (54%) ███████████████████████████
|
||
refactor: 2 ( 4%) ██
|
||
```
|
||
|
||
Flag if fix ratio exceeds 50% — this signals a "ship fast, fix fast" pattern that may indicate review gaps.
|
||
|
||
### Step 6: Hotspot Analysis
|
||
|
||
Show top 10 most-changed files. Flag:
|
||
- Files changed 5+ times (churn hotspots)
|
||
- Test files vs production files in the hotspot list
|
||
- VERSION/CHANGELOG frequency (version discipline indicator)
|
||
|
||
### Step 7: PR Size Distribution
|
||
|
||
From commit diffs, estimate PR sizes and bucket them:
|
||
- **Small** (<100 LOC)
|
||
- **Medium** (100-500 LOC)
|
||
- **Large** (500-1500 LOC)
|
||
- **XL** (1500+ LOC)
|
||
|
||
### Step 8: Focus Score + Ship of the Week
|
||
|
||
**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `app/services/`, `app/views/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (app/services/)"
|
||
|
||
**Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it:
|
||
- PR number and title
|
||
- LOC changed
|
||
- Why it matters (infer from commit messages and files touched)
|
||
|
||
### Step 9: Team Member Analysis
|
||
|
||
For each contributor (including the current user), compute:
|
||
|
||
1. **Commits and LOC** — total commits, insertions, deletions, net LOC
|
||
2. **Areas of focus** — which directories/files they touched most (top 3)
|
||
3. **Commit type mix** — their personal feat/fix/refactor/test breakdown
|
||
4. **Session patterns** — when they code (their peak hours), session count
|
||
5. **Test discipline** — their personal test LOC ratio
|
||
6. **Biggest ship** — their single highest-impact commit or PR in the window
|
||
|
||
**For the current user ("You"):** This section gets the deepest treatment. Include all the detail from the solo retro — session analysis, time patterns, focus score. Frame it in first person: "Your peak hours...", "Your biggest ship..."
|
||
|
||
**For each teammate:** Write 2-3 sentences covering what they worked on and their pattern. Then:
|
||
|
||
- **Praise** (1-2 specific things): Anchor in actual commits. Not "great work" — say exactly what was good. Examples: "Shipped the entire auth middleware rewrite in 3 focused sessions with 45% test coverage", "Every PR under 200 LOC — disciplined decomposition."
|
||
- **Opportunity for growth** (1 specific thing): Frame as a leveling-up suggestion, not criticism. Anchor in actual data. Examples: "Test ratio was 12% this week — adding test coverage to the payment module before it gets more complex would pay off", "5 fix commits on the same file suggest the original PR could have used a review pass."
|
||
|
||
**If only one contributor (solo repo):** Skip the team breakdown and proceed as before — the retro is personal.
|
||
|
||
**If there are Co-Authored-By trailers:** Parse `Co-Authored-By:` lines in commit messages. Credit those authors for the commit alongside the primary author. Note AI co-authors (e.g., `noreply@anthropic.com`) but do not include them as team members — instead, track "AI-assisted commits" as a separate metric.
|
||
|
||
{{LEARNINGS_LOG}}
|
||
|
||
{{GBRAIN_SAVE_RESULTS}}
|
||
|
||
### Step 10: Week-over-Week Trends (if window >= 14d)
|
||
|
||
If the time window is 14 days or more, split into weekly buckets and show trends:
|
||
- Commits per week (total and per-author)
|
||
- LOC per week
|
||
- Test ratio per week
|
||
- Fix ratio per week
|
||
- Session count per week
|
||
|
||
### Step 11: Streak Tracking
|
||
|
||
Count consecutive days with at least 1 commit to origin/<default>, going back from today. Track both team streak and personal streak:
|
||
|
||
```bash
|
||
# Team streak: all unique commit dates (local time) — no hard cutoff
|
||
git log origin/<default> --format="%ad" --date=format:"%Y-%m-%d" | sort -u
|
||
|
||
# Personal streak: only the current user's commits
|
||
git log origin/<default> --author="<user_name>" --format="%ad" --date=format:"%Y-%m-%d" | sort -u
|
||
```
|
||
|
||
Count backward from today — how many consecutive days have at least one commit? This queries the full history so streaks of any length are reported accurately. Display both:
|
||
- "Team shipping streak: 47 consecutive days"
|
||
- "Your shipping streak: 32 consecutive days"
|
||
|
||
### Step 12: Load History & Compare
|
||
|
||
Before saving the new snapshot, check for prior retro history:
|
||
|
||
```bash
|
||
setopt +o nomatch 2>/dev/null || true # zsh compat
|
||
ls -t .context/retros/*.json 2>/dev/null
|
||
```
|
||
|
||
**If prior retros exist:** Load the most recent one using the Read tool. Calculate deltas for key metrics and include a **Trends vs Last Retro** section:
|
||
```
|
||
Last Now Delta
|
||
Test ratio: 22% → 41% ↑19pp
|
||
Sessions: 10 → 14 ↑4
|
||
LOC/hour: 200 → 350 ↑75%
|
||
Fix ratio: 54% → 30% ↓24pp (improving)
|
||
Commits: 32 → 47 ↑47%
|
||
Deep sessions: 3 → 5 ↑2
|
||
```
|
||
|
||
**If no prior retros exist:** Skip the comparison section and append: "First retro recorded — run again next week to see trends."
|
||
|
||
### Step 13: Save Retro History
|
||
|
||
After computing all metrics (including streak) and loading any prior history for comparison, save a JSON snapshot:
|
||
|
||
```bash
|
||
mkdir -p .context/retros
|
||
```
|
||
|
||
Determine the next sequence number for today (substitute the actual date for `$(date +%Y-%m-%d)`):
|
||
```bash
|
||
setopt +o nomatch 2>/dev/null || true # zsh compat
|
||
# Count existing retros for today to get next sequence number
|
||
today=$(date +%Y-%m-%d)
|
||
existing=$(ls .context/retros/${today}-*.json 2>/dev/null | wc -l | tr -d ' ')
|
||
next=$((existing + 1))
|
||
# Save as .context/retros/${today}-${next}.json
|
||
```
|
||
|
||
Use the Write tool to save the JSON file with this schema:
|
||
```json
|
||
{
|
||
"date": "2026-03-08",
|
||
"window": "7d",
|
||
"metrics": {
|
||
"commits": 47,
|
||
"contributors": 3,
|
||
"prs_merged": 12,
|
||
"insertions": 3200,
|
||
"deletions": 800,
|
||
"net_loc": 2400,
|
||
"test_loc": 1300,
|
||
"test_ratio": 0.41,
|
||
"active_days": 6,
|
||
"sessions": 14,
|
||
"deep_sessions": 5,
|
||
"avg_session_minutes": 42,
|
||
"loc_per_session_hour": 350,
|
||
"feat_pct": 0.40,
|
||
"fix_pct": 0.30,
|
||
"peak_hour": 22,
|
||
"ai_assisted_commits": 32
|
||
},
|
||
"authors": {
|
||
"Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" },
|
||
"Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "app/services/" }
|
||
},
|
||
"version_range": ["1.16.0.0", "1.16.1.0"],
|
||
"streak_days": 47,
|
||
"tweetable": "Week of Mar 1: 47 commits (3 contributors), 3.2k LOC, 38% tests, 12 PRs, peak: 10pm",
|
||
"greptile": {
|
||
"fixes": 3,
|
||
"fps": 1,
|
||
"already_fixed": 2,
|
||
"signal_pct": 83
|
||
}
|
||
}
|
||
```
|
||
|
||
**Note:** Only include the `greptile` field if `~/.gstack/greptile-history.md` exists and has entries within the time window. Only include the `backlog` field if `TODOS.md` exists. Only include the `test_health` field if test files were found (command 10 returns > 0). If any has no data, omit the field entirely.
|
||
|
||
Include test health data in the JSON when test files exist:
|
||
```json
|
||
"test_health": {
|
||
"total_test_files": 47,
|
||
"tests_added_this_period": 5,
|
||
"regression_test_commits": 3,
|
||
"test_files_changed": 8
|
||
}
|
||
```
|
||
|
||
Include backlog data in the JSON when TODOS.md exists:
|
||
```json
|
||
"backlog": {
|
||
"total_open": 28,
|
||
"p0_p1": 2,
|
||
"p2": 8,
|
||
"completed_this_period": 3,
|
||
"added_this_period": 1
|
||
}
|
||
```
|
||
|
||
### Step 14: Write the Narrative
|
||
|
||
Structure the output as:
|
||
|
||
---
|
||
|
||
**Tweetable summary** (first line, before everything else):
|
||
```
|
||
Week of Mar 1: 47 commits (3 contributors), 3.2k LOC, 38% tests, 12 PRs, peak: 10pm | Streak: 47d
|
||
```
|
||
|
||
## Engineering Retro: [date range]
|
||
|
||
### Summary Table
|
||
(from Step 2)
|
||
|
||
### Trends vs Last Retro
|
||
(from Step 11, loaded before save — skip if first retro)
|
||
|
||
### Time & Session Patterns
|
||
(from Steps 3-4)
|
||
|
||
Narrative interpreting what the team-wide patterns mean:
|
||
- When the most productive hours are and what drives them
|
||
- Whether sessions are getting longer or shorter over time
|
||
- Estimated hours per day of active coding (team aggregate)
|
||
- Notable patterns: do team members code at the same time or in shifts?
|
||
|
||
### Shipping Velocity
|
||
(from Steps 5-7)
|
||
|
||
Narrative covering:
|
||
- Commit type mix and what it reveals
|
||
- PR size distribution and what it reveals about shipping cadence
|
||
- Fix-chain detection (sequences of fix commits on the same subsystem)
|
||
- Version bump discipline
|
||
|
||
### Code Quality Signals
|
||
- Test LOC ratio trend
|
||
- Hotspot analysis (are the same files churning?)
|
||
- Greptile signal ratio and trend (if history exists): "Greptile: X% signal (Y valid catches, Z false positives)"
|
||
|
||
### Test Health
|
||
- Total test files: N (from command 10)
|
||
- Tests added this period: M (from command 12 — test files changed)
|
||
- Regression test commits: list `test(qa):` and `test(design):` and `test: coverage` commits from command 11
|
||
- If prior retro exists and has `test_health`: show delta "Test count: {last} → {now} (+{delta})"
|
||
- If test ratio < 20%: flag as growth area — "100% test coverage is the goal. Tests make vibe coding safe."
|
||
|
||
### Plan Completion
|
||
Check review JSONL logs for plan completion data from /ship runs this period:
|
||
|
||
```bash
|
||
setopt +o nomatch 2>/dev/null || true # zsh compat
|
||
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
||
cat ~/.gstack/projects/$SLUG/*-reviews.jsonl 2>/dev/null | grep '"skill":"ship"' | grep '"plan_items_total"' || echo "NO_PLAN_DATA"
|
||
```
|
||
|
||
If plan completion data exists within the retro time window:
|
||
- Count branches shipped with plans (entries that have `plan_items_total` > 0)
|
||
- Compute average completion: sum of `plan_items_done` / sum of `plan_items_total`
|
||
- Identify most-skipped item category if data supports it
|
||
|
||
Output:
|
||
```
|
||
Plan Completion This Period:
|
||
{N} branches shipped with plans
|
||
Average completion: {X}% ({done}/{total} items)
|
||
```
|
||
|
||
If no plan data exists, skip this section silently.
|
||
|
||
### Focus & Highlights
|
||
(from Step 8)
|
||
- Focus score with interpretation
|
||
- Ship of the week callout
|
||
|
||
### Your Week (personal deep-dive)
|
||
(from Step 9, for the current user only)
|
||
|
||
This is the section the user cares most about. Include:
|
||
- Their personal commit count, LOC, test ratio
|
||
- Their session patterns and peak hours
|
||
- Their focus areas
|
||
- Their biggest ship
|
||
- **What you did well** (2-3 specific things anchored in commits)
|
||
- **Where to level up** (1-2 specific, actionable suggestions)
|
||
|
||
### Team Breakdown
|
||
(from Step 9, for each teammate — skip if solo repo)
|
||
|
||
For each teammate (sorted by commits descending), write a section:
|
||
|
||
#### [Name]
|
||
- **What they shipped**: 2-3 sentences on their contributions, areas of focus, and commit patterns
|
||
- **Praise**: 1-2 specific things they did well, anchored in actual commits. Be genuine — what would you actually say in a 1:1? Examples:
|
||
- "Cleaned up the entire auth module in 3 small, reviewable PRs — textbook decomposition"
|
||
- "Added integration tests for every new endpoint, not just happy paths"
|
||
- "Fixed the N+1 query that was causing 2s load times on the dashboard"
|
||
- **Opportunity for growth**: 1 specific, constructive suggestion. Frame as investment, not criticism. Examples:
|
||
- "Test coverage on the payment module is at 8% — worth investing in before the next feature lands on top of it"
|
||
- "Most commits land in a single burst — spacing work across the day could reduce context-switching fatigue"
|
||
- "All commits land between 1-4am — sustainable pace matters for code quality long-term"
|
||
|
||
**AI collaboration note:** If many commits have `Co-Authored-By` AI trailers (e.g., Claude, Copilot), note the AI-assisted commit percentage as a team metric. Frame it neutrally — "N% of commits were AI-assisted" — without judgment.
|
||
|
||
### Top 3 Team Wins
|
||
Identify the 3 highest-impact things shipped in the window across the whole team. For each:
|
||
- What it was
|
||
- Who shipped it
|
||
- Why it matters (product/architecture impact)
|
||
|
||
### 3 Things to Improve
|
||
Specific, actionable, anchored in actual commits. Mix personal and team-level suggestions. Phrase as "to get even better, the team could..."
|
||
|
||
### 3 Habits for Next Week
|
||
Small, practical, realistic. Each must be something that takes <5 minutes to adopt. At least one should be team-oriented (e.g., "review each other's PRs same-day").
|
||
|
||
### Week-over-Week Trends
|
||
(if applicable, from Step 10)
|
||
|
||
---
|
||
|
||
## Global Retrospective Mode
|
||
|
||
When the user runs `/retro global` (or `/retro global 14d`), follow this flow instead of the repo-scoped Steps 1-14. This mode works from any directory — it does NOT require being inside a git repo.
|
||
|
||
### Global Step 1: Compute time window
|
||
|
||
Same midnight-aligned logic as the regular retro. Default 7d. The second argument after `global` is the window (e.g., `14d`, `30d`, `24h`).
|
||
|
||
### Global Step 2: Run discovery
|
||
|
||
Locate and run the discovery script using this fallback chain:
|
||
|
||
```bash
|
||
DISCOVER_BIN=""
|
||
[ -x ~/.claude/skills/gstack/bin/gstack-global-discover ] && DISCOVER_BIN=~/.claude/skills/gstack/bin/gstack-global-discover
|
||
[ -z "$DISCOVER_BIN" ] && [ -x .claude/skills/gstack/bin/gstack-global-discover ] && DISCOVER_BIN=.claude/skills/gstack/bin/gstack-global-discover
|
||
[ -z "$DISCOVER_BIN" ] && which gstack-global-discover >/dev/null 2>&1 && DISCOVER_BIN=$(which gstack-global-discover)
|
||
[ -z "$DISCOVER_BIN" ] && [ -f bin/gstack-global-discover.ts ] && DISCOVER_BIN="bun run bin/gstack-global-discover.ts"
|
||
echo "DISCOVER_BIN: $DISCOVER_BIN"
|
||
```
|
||
|
||
If no binary is found, tell the user: "Discovery script not found. Run `bun run build` in the gstack directory to compile it." and stop.
|
||
|
||
Run the discovery:
|
||
```bash
|
||
$DISCOVER_BIN --since "<window>" --format json 2>/tmp/gstack-discover-stderr
|
||
```
|
||
|
||
Read the stderr output from `/tmp/gstack-discover-stderr` for diagnostic info. Parse the JSON output from stdout.
|
||
|
||
If `total_sessions` is 0, say: "No AI coding sessions found in the last <window>. Try a longer window: `/retro global 30d`" and stop.
|
||
|
||
### Global Step 3: Run git log on each discovered repo
|
||
|
||
For each repo in the discovery JSON's `repos` array, find the first valid path in `paths[]` (directory exists with `.git/`). If no valid path exists, skip the repo and note it.
|
||
|
||
**For local-only repos** (where `remote` starts with `local:`): skip `git fetch` and use the local default branch. Use `git log HEAD` instead of `git log origin/$DEFAULT`.
|
||
|
||
**For repos with remotes:**
|
||
|
||
```bash
|
||
git -C <path> fetch origin --quiet 2>/dev/null
|
||
```
|
||
|
||
Detect the default branch for each repo: first try `git symbolic-ref refs/remotes/origin/HEAD`, then check common branch names (`main`, `master`), then fall back to `git rev-parse --abbrev-ref HEAD`. Use the detected branch as `<default>` in the commands below.
|
||
|
||
```bash
|
||
# Commits with stats
|
||
git -C <path> log origin/$DEFAULT --since="<start_date>T00:00:00" --format="%H|%aN|%ai|%s" --shortstat
|
||
|
||
# Commit timestamps for session detection, streak, and context switching
|
||
git -C <path> log origin/$DEFAULT --since="<start_date>T00:00:00" --format="%at|%aN|%ai|%s" | sort -n
|
||
|
||
# Per-author commit counts
|
||
git -C <path> shortlog origin/$DEFAULT --since="<start_date>T00:00:00" -sn --no-merges
|
||
|
||
# PR/MR numbers from commit messages (GitHub #NNN, GitLab !NNN)
|
||
git -C <path> log origin/$DEFAULT --since="<start_date>T00:00:00" --format="%s" | grep -oE '[#!][0-9]+' | sort -t'#' -k1 | uniq
|
||
```
|
||
|
||
For repos that fail (deleted paths, network errors): skip and note "N repos could not be reached."
|
||
|
||
### Global Step 4: Compute global shipping streak
|
||
|
||
For each repo, get commit dates (capped at 365 days):
|
||
|
||
```bash
|
||
git -C <path> log origin/$DEFAULT --since="365 days ago" --format="%ad" --date=format:"%Y-%m-%d" | sort -u
|
||
```
|
||
|
||
Union all dates across all repos. Count backward from today — how many consecutive days have at least one commit to ANY repo? If the streak hits 365 days, display as "365+ days".
|
||
|
||
### Global Step 5: Compute context switching metric
|
||
|
||
From the commit timestamps gathered in Step 3, group by date. For each date, count how many distinct repos had commits that day. Report:
|
||
- Average repos/day
|
||
- Maximum repos/day
|
||
- Which days were focused (1 repo) vs. fragmented (3+ repos)
|
||
|
||
### Global Step 6: Per-tool productivity patterns
|
||
|
||
From the discovery JSON, analyze tool usage patterns:
|
||
- Which AI tool is used for which repos (exclusive vs. shared)
|
||
- Session count per tool
|
||
- Behavioral patterns (e.g., "Codex used exclusively for myapp, Claude Code for everything else")
|
||
|
||
### Global Step 7: Aggregate and generate narrative
|
||
|
||
Structure the output with the **shareable personal card first**, then the full
|
||
team/project breakdown below. The personal card is designed to be screenshot-friendly
|
||
— everything someone would want to share on X/Twitter in one clean block.
|
||
|
||
---
|
||
|
||
**Tweetable summary** (first line, before everything else):
|
||
```
|
||
Week of Mar 14: 5 projects, 138 commits, 250k LOC across 5 repos | 48 AI sessions | Streak: 52d 🔥
|
||
```
|
||
|
||
## 🚀 Your Week: [user name] — [date range]
|
||
|
||
This section is the **shareable personal card**. It contains ONLY the current user's
|
||
stats — no team data, no project breakdowns. Designed to screenshot and post.
|
||
|
||
Use the user identity from `git config user.name` to filter all per-repo git data.
|
||
Aggregate across all repos to compute personal totals.
|
||
|
||
Render as a single visually clean block. Left border only — no right border (LLMs
|
||
can't align right borders reliably). Pad repo names to the longest name so columns
|
||
align cleanly. Never truncate project names.
|
||
|
||
```
|
||
╔═══════════════════════════════════════════════════════════════
|
||
║ [USER NAME] — Week of [date]
|
||
╠═══════════════════════════════════════════════════════════════
|
||
║
|
||
║ [N] commits across [M] projects
|
||
║ +[X]k LOC added · [Y]k LOC deleted · [Z]k net
|
||
║ [N] AI coding sessions (CC: X, Codex: Y, Gemini: Z)
|
||
║ [N]-day shipping streak 🔥
|
||
║
|
||
║ PROJECTS
|
||
║ ─────────────────────────────────────────────────────────
|
||
║ [repo_name_full] [N] commits +[X]k LOC [solo/team]
|
||
║ [repo_name_full] [N] commits +[X]k LOC [solo/team]
|
||
║ [repo_name_full] [N] commits +[X]k LOC [solo/team]
|
||
║
|
||
║ SHIP OF THE WEEK
|
||
║ [PR title] — [LOC] lines across [N] files
|
||
║
|
||
║ TOP WORK
|
||
║ • [1-line description of biggest theme]
|
||
║ • [1-line description of second theme]
|
||
║ • [1-line description of third theme]
|
||
║
|
||
║ Powered by gstack
|
||
╚═══════════════════════════════════════════════════════════════
|
||
```
|
||
|
||
**Rules for the personal card:**
|
||
- Only show repos where the user has commits. Skip repos with 0 commits.
|
||
- Sort repos by user's commit count descending.
|
||
- **Never truncate repo names.** Use the full repo name (e.g., `analyze_transcripts`
|
||
not `analyze_trans`). Pad the name column to the longest repo name so all columns
|
||
align. If names are long, widen the box — the box width adapts to content.
|
||
- For LOC, use "k" formatting for thousands (e.g., "+64.0k" not "+64010").
|
||
- Role: "solo" if user is the only contributor, "team" if others contributed.
|
||
- Ship of the Week: the user's single highest-LOC PR across ALL repos.
|
||
- Top Work: 3 bullet points summarizing the user's major themes, inferred from
|
||
commit messages. Not individual commits — synthesize into themes.
|
||
E.g., "Built /retro global — cross-project retrospective with AI session discovery"
|
||
not "feat: gstack-global-discover" + "feat: /retro global template".
|
||
- The card must be self-contained. Someone seeing ONLY this block should understand
|
||
the user's week without any surrounding context.
|
||
- Do NOT include team members, project totals, or context switching data here.
|
||
|
||
**Personal streak:** Use the user's own commits across all repos (filtered by
|
||
`--author`) to compute a personal streak, separate from the team streak.
|
||
|
||
---
|
||
|
||
## Global Engineering Retro: [date range]
|
||
|
||
Everything below is the full analysis — team data, project breakdowns, patterns.
|
||
This is the "deep dive" that follows the shareable card.
|
||
|
||
### All Projects Overview
|
||
| Metric | Value |
|
||
|--------|-------|
|
||
| Projects active | N |
|
||
| Total commits (all repos, all contributors) | N |
|
||
| Total LOC | +N / -N |
|
||
| AI coding sessions | N (CC: X, Codex: Y, Gemini: Z) |
|
||
| Active days | N |
|
||
| Global shipping streak (any contributor, any repo) | N consecutive days |
|
||
| Context switches/day | N avg (max: M) |
|
||
|
||
### Per-Project Breakdown
|
||
For each repo (sorted by commits descending):
|
||
- Repo name (with % of total commits)
|
||
- Commits, LOC, PRs merged, top contributor
|
||
- Key work (inferred from commit messages)
|
||
- AI sessions by tool
|
||
|
||
**Your Contributions** (sub-section within each project):
|
||
For each project, add a "Your contributions" block showing the current user's
|
||
personal stats within that repo. Use the user identity from `git config user.name`
|
||
to filter. Include:
|
||
- Your commits / total commits (with %)
|
||
- Your LOC (+insertions / -deletions)
|
||
- Your key work (inferred from YOUR commit messages only)
|
||
- Your commit type mix (feat/fix/refactor/chore/docs breakdown)
|
||
- Your biggest ship in this repo (highest-LOC commit or PR)
|
||
|
||
If the user is the only contributor, say "Solo project — all commits are yours."
|
||
If the user has 0 commits in a repo (team project they didn't touch this period),
|
||
say "No commits this period — [N] AI sessions only." and skip the breakdown.
|
||
|
||
Format:
|
||
```
|
||
**Your contributions:** 47/244 commits (19%), +4.2k/-0.3k LOC
|
||
Key work: Writer Chat, email blocking, security hardening
|
||
Biggest ship: PR #605 — Writer Chat eats the admin bar (2,457 ins, 46 files)
|
||
Mix: feat(3) fix(2) chore(1)
|
||
```
|
||
|
||
### Cross-Project Patterns
|
||
- Time allocation across projects (% breakdown, use YOUR commits not total)
|
||
- Peak productivity hours aggregated across all repos
|
||
- Focused vs. fragmented days
|
||
- Context switching trends
|
||
|
||
### Tool Usage Analysis
|
||
Per-tool breakdown with behavioral patterns:
|
||
- Claude Code: N sessions across M repos — patterns observed
|
||
- Codex: N sessions across M repos — patterns observed
|
||
- Gemini: N sessions across M repos — patterns observed
|
||
|
||
### Ship of the Week (Global)
|
||
Highest-impact PR across ALL projects. Identify by LOC and commit messages.
|
||
|
||
### 3 Cross-Project Insights
|
||
What the global view reveals that no single-repo retro could show.
|
||
|
||
### 3 Habits for Next Week
|
||
Considering the full cross-project picture.
|
||
|
||
---
|
||
|
||
### Global Step 8: Load history & compare
|
||
|
||
```bash
|
||
setopt +o nomatch 2>/dev/null || true # zsh compat
|
||
ls -t ~/.gstack/retros/global-*.json 2>/dev/null | head -5
|
||
```
|
||
|
||
**Only compare against a prior retro with the same `window` value** (e.g., 7d vs 7d). If the most recent prior retro has a different window, skip comparison and note: "Prior global retro used a different window — skipping comparison."
|
||
|
||
If a matching prior retro exists, load it with the Read tool. Show a **Trends vs Last Global Retro** table with deltas for key metrics: total commits, LOC, sessions, streak, context switches/day.
|
||
|
||
If no prior global retros exist, append: "First global retro recorded — run again next week to see trends."
|
||
|
||
### Global Step 9: Save snapshot
|
||
|
||
```bash
|
||
mkdir -p ~/.gstack/retros
|
||
```
|
||
|
||
Determine the next sequence number for today:
|
||
```bash
|
||
setopt +o nomatch 2>/dev/null || true # zsh compat
|
||
today=$(date +%Y-%m-%d)
|
||
existing=$(ls ~/.gstack/retros/global-${today}-*.json 2>/dev/null | wc -l | tr -d ' ')
|
||
next=$((existing + 1))
|
||
```
|
||
|
||
Use the Write tool to save JSON to `~/.gstack/retros/global-${today}-${next}.json`:
|
||
|
||
```json
|
||
{
|
||
"type": "global",
|
||
"date": "2026-03-21",
|
||
"window": "7d",
|
||
"projects": [
|
||
{
|
||
"name": "gstack",
|
||
"remote": "<detected from git remote get-url origin, normalized to HTTPS>",
|
||
"commits": 47,
|
||
"insertions": 3200,
|
||
"deletions": 800,
|
||
"sessions": { "claude_code": 15, "codex": 3, "gemini": 0 }
|
||
}
|
||
],
|
||
"totals": {
|
||
"commits": 182,
|
||
"insertions": 15300,
|
||
"deletions": 4200,
|
||
"projects": 5,
|
||
"active_days": 6,
|
||
"sessions": { "claude_code": 48, "codex": 8, "gemini": 3 },
|
||
"global_streak_days": 52,
|
||
"avg_context_switches_per_day": 2.1
|
||
},
|
||
"tweetable": "Week of Mar 14: 5 projects, 182 commits, 15.3k LOC | CC: 48, Codex: 8, Gemini: 3 | Focus: gstack (58%) | Streak: 52d"
|
||
}
|
||
```
|
||
|
||
---
|
||
|
||
## Compare Mode
|
||
|
||
When the user runs `/retro compare` (or `/retro compare 14d`):
|
||
|
||
1. Compute metrics for the current window (default 7d) using the midnight-aligned start date (same logic as the main retro — e.g., if today is 2026-03-18 and window is 7d, use `--since="2026-03-11T00:00:00"`)
|
||
2. Compute metrics for the immediately prior same-length window using both `--since` and `--until` with midnight-aligned dates to avoid overlap (e.g., for a 7d window starting 2026-03-11: prior window is `--since="2026-03-04T00:00:00" --until="2026-03-11T00:00:00"`)
|
||
3. Show a side-by-side comparison table with deltas and arrows
|
||
4. Write a brief narrative highlighting the biggest improvements and regressions
|
||
5. Save only the current-window snapshot to `.context/retros/` (same as a normal retro run); do **not** persist the prior-window metrics.
|
||
|
||
## Tone
|
||
|
||
- Encouraging but candid, no coddling
|
||
- Specific and concrete — always anchor in actual commits/code
|
||
- Skip generic praise ("great job!") — say exactly what was good and why
|
||
- Frame improvements as leveling up, not criticism
|
||
- **Praise should feel like something you'd actually say in a 1:1** — specific, earned, genuine
|
||
- **Growth suggestions should feel like investment advice** — "this is worth your time because..." not "you failed at..."
|
||
- Never compare teammates against each other negatively. Each person's section stands on its own.
|
||
- Keep total output around 3000-4500 words (slightly longer to accommodate team sections)
|
||
- Use markdown tables and code blocks for data, prose for narrative
|
||
- Output directly to the conversation — do NOT write to filesystem (except the `.context/retros/` JSON snapshot)
|
||
|
||
## Important Rules
|
||
|
||
- ALL narrative output goes directly to the user in the conversation. The ONLY file written is the `.context/retros/` JSON snapshot.
|
||
- Use `origin/<default>` for all git queries (not local main which may be stale)
|
||
- Display all timestamps in the user's local timezone (do not override `TZ`)
|
||
- If the window has zero commits, say so and suggest a different window
|
||
- Round LOC/hour to nearest 50
|
||
- Treat merge commits as PR boundaries
|
||
- Do not read CLAUDE.md or other docs — this skill is self-contained
|
||
- On first run (no prior retros), skip comparison sections gracefully
|
||
- **Global mode:** Does NOT require being inside a git repo. Saves snapshots to `~/.gstack/retros/` (not `.context/retros/`). Gracefully skip AI tools that aren't installed. Only compare against prior global retros with the same window value. If streak hits 365d cap, display as "365+ days".
|