Ricky and Claude Opus 5
ca671d6f65
fix(redact): a typo'd subcommand no longer exits 0 having done nothing
...
main() recognised exactly two subcommands and let everything else fall through
to the stdin scan. On empty stdin that prints "(no findings)" and exits 0, so:
$ gstack-redact install-prepush-hooks # plural typo
gstack-redact scan — repo UNKNOWN
(no findings)
$ echo $?
0
No hook was installed, and the operator has every reason to believe the
credential guard is armed. A guard that silently no-ops must never exit 0.
Two smaller faults in the same dispatch, both of which lead people here:
- There was no --help handler, so `gstack-redact --help` fell through to the
scanner. Piping a credential to it scanned the secret and exited 3.
- With no piped input and no --from-file, readInput() blocks on readSync(fd 0)
until an EOF that an interactive terminal never sends. That prints nothing
at all, so it reads as a hang rather than as "this is a filter, feed it".
Now: --help/-h/help prints usage and exits 0; an unrecognised positional
prints the offender and exits 1; a TTY with nothing piped in prints usage
instead of blocking. "scan" stays accepted, because the human output header
reads "gstack-redact scan — repo …" and that is what people type.
Usage errors exit 1, deliberately not 2 or 3. Those mean MEDIUM and HIGH
findings and callers gate dispatch on them, so a usage error exiting 2 would
be read as "medium findings — prompt the user". A test pins that.
Tests: 4 written failing first, then fixed. Full suite 7,722 pass / 0 fail.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com >
2026-08-17 10:05:32 -07:00
..
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 22:20:30 -07:00
2026-03-18 23:57:59 -05:00
2026-08-15 22:20:30 -07:00
2026-08-16 19:34:41 -07:00
2026-05-17 08:26:36 -07:00
2026-08-15 11:42:19 -07:00
2026-06-07 21:38:21 -07:00
2026-06-07 21:38:21 -07:00
2026-08-14 22:02:07 -07:00
2026-04-19 17:50:31 +08:00
2026-08-16 19:34:41 -07:00
2026-06-21 07:15:19 -07:00
2026-08-16 09:53:31 -07:00
2026-08-16 19:34:41 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-25 10:57:15 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-20 07:35:01 -07:00
2026-04-08 22:21:28 -10:00
2026-05-29 08:35:00 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-08-15 09:37:04 -07:00
2026-06-07 19:13:24 -07:00
2026-08-14 09:28:56 -07:00
2026-05-30 14:57:07 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 11:42:19 -07:00
2026-08-16 19:34:41 -07:00
2026-04-23 07:25:20 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 22:20:30 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-09 08:06:47 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-16 12:32:33 -07:00
2026-08-15 11:42:19 -07:00
2026-08-08 09:28:45 -07:00
2026-06-07 19:13:24 -07:00
2026-08-15 09:37:04 -07:00
2026-05-28 18:21:09 -07:00
2026-08-15 22:20:30 -07:00
2026-06-09 22:29:23 -07:00
2026-06-12 15:38:53 -07:00
2026-08-16 19:34:41 -07:00
2026-05-30 12:09:10 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-05-21 21:21:07 -07:00
2026-06-07 19:13:24 -07:00
2026-04-26 13:55:13 -07:00
2026-08-15 22:20:30 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 22:20:30 -07:00
2026-08-07 15:08:12 -07:00
2026-08-15 22:20:30 -07:00
2026-08-16 09:53:31 -07:00
2026-08-14 22:02:07 -07:00
2026-08-14 22:02:07 -07:00
2026-05-20 07:35:01 -07:00
2026-08-15 11:42:19 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 11:42:19 -07:00
2026-06-08 06:20:58 -07:00
2026-08-15 22:20:30 -07:00
2026-06-21 07:15:19 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-17 08:26:36 -07:00
2026-06-08 06:20:58 -07:00
2026-05-14 17:20:48 -07:00
2026-08-15 11:42:19 -07:00
2026-05-21 21:21:07 -07:00
2026-04-24 01:38:21 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 11:42:19 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 14:57:07 -07:00
2026-08-08 09:28:45 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 22:20:30 -07:00
2026-07-10 16:51:16 -07:00
2026-05-21 18:55:55 -07:00
2026-08-14 09:28:56 -07:00
2026-08-15 09:37:04 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-20 06:56:41 -07:00
2026-08-14 22:02:07 -07:00
2026-05-21 21:21:07 -07:00
2026-08-15 11:42:19 -07:00
2026-05-28 18:21:09 -07:00
2026-08-17 10:04:54 -07:00
2026-08-15 09:37:04 -07:00
2026-05-30 08:54:46 -07:00
2026-08-15 11:42:19 -07:00
2026-06-08 06:20:58 -07:00
2026-06-08 06:20:58 -07:00
2026-06-14 11:40:57 -07:00
2026-08-08 09:28:45 -07:00
2026-08-16 19:34:41 -07:00
2026-08-08 09:28:45 -07:00
2026-08-14 09:28:56 -07:00
2026-04-28 01:17:54 -07:00
2026-08-16 19:34:41 -07:00
2026-06-08 06:39:38 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-06-21 07:15:19 -07:00
2026-08-17 10:04:01 -07:00
2026-08-17 10:05:32 -07:00
2026-07-10 03:09:13 -07:00
2026-05-29 08:35:00 -07:00
2026-06-07 21:38:21 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-28 18:21:09 -07:00
2026-08-14 22:02:07 -07:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-05-25 10:57:15 -07:00
2026-08-16 19:34:41 -07:00
2026-04-26 13:55:13 -07:00
2026-08-14 09:28:56 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 09:53:31 -07:00
2026-08-14 22:02:07 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-08-17 07:50:37 -07:00
2026-07-14 16:35:30 -07:00
2026-08-15 11:42:19 -07:00
2026-07-14 16:35:30 -07:00
2026-06-14 11:40:57 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 14:57:07 -07:00
2026-08-15 09:37:04 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-06-21 07:15:19 -07:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-08-08 09:28:45 -07:00
2026-08-15 11:42:19 -07:00
2026-05-20 07:35:01 -07:00
2026-05-30 14:57:07 -07:00
2026-04-19 08:38:19 +08:00
2026-08-15 11:42:19 -07:00
2026-08-15 11:42:19 -07:00
2026-08-15 11:42:19 -07:00
2026-08-14 22:02:07 -07:00
2026-04-25 11:52:48 -07:00
2026-08-14 22:02:07 -07:00
2026-08-14 22:02:07 -07:00
2026-08-14 22:02:07 -07:00
2026-08-15 11:42:19 -07:00
2026-08-14 22:02:07 -07:00
2026-08-08 09:28:45 -07:00
2026-04-17 00:45:13 -07:00
2026-08-15 22:20:30 -07:00
2026-08-14 22:02:07 -07:00
2026-05-26 16:50:03 -07:00
2026-05-30 12:09:10 -07:00
2026-08-15 09:37:04 -07:00
2026-05-28 18:21:09 -07:00
2026-05-30 11:42:13 -07:00
2026-05-06 19:37:53 -07:00
2026-08-14 22:02:07 -07:00
2026-06-07 22:04:18 -07:00
2026-06-14 11:40:57 -07:00
2026-06-25 09:42:45 -07:00
2026-08-14 09:28:56 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-08-08 09:28:45 -07:00
2026-08-16 19:34:41 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 08:54:46 -07:00
2026-08-15 09:37:04 -07:00
2026-05-30 08:54:46 -07:00
2026-08-17 07:50:37 -07:00
2026-08-16 19:34:41 -07:00
2026-05-30 08:54:46 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 12:09:10 -07:00
2026-06-07 06:51:10 -07:00
2026-05-21 21:21:07 -07:00
2026-08-14 22:02:07 -07:00
2026-05-20 06:56:41 -07:00
2026-05-20 06:56:41 -07:00
2026-08-16 19:34:41 -07:00
2026-05-30 12:09:10 -07:00
2026-06-14 11:40:57 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-08-16 09:53:31 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-04-24 01:38:21 -07:00
2026-06-04 11:14:43 -07:00
2026-06-21 07:15:19 -07:00
2026-07-09 23:49:09 -07:00
2026-08-14 22:02:07 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-05-14 21:19:58 -07:00
2026-05-29 18:06:19 -07:00
2026-08-16 19:34:41 -07:00
2026-05-06 19:37:53 -07:00
2026-08-14 22:02:07 -07:00
2026-05-30 11:42:13 -07:00
2026-08-14 22:02:07 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-08-16 19:34:41 -07:00
2026-08-15 11:42:19 -07:00
2026-05-30 12:09:10 -07:00
2026-08-16 19:34:41 -07:00
2026-05-30 12:09:10 -07:00
2026-08-15 11:42:19 -07:00
2026-04-18 23:58:59 +08:00
2026-08-14 09:28:56 -07:00
2026-08-16 19:34:41 -07:00
2026-06-04 11:14:43 -07:00
2026-04-19 08:38:19 +08:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-06-12 15:38:53 -07:00
2026-05-01 19:51:51 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 11:42:19 -07:00
2026-08-15 09:37:04 -07:00
2026-07-09 23:49:09 -07:00
2026-08-14 09:28:56 -07:00
2026-08-15 11:42:19 -07:00
2026-06-25 09:42:45 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-16 19:34:41 -07:00
2026-03-26 11:08:31 -07:00
2026-08-15 11:42:19 -07:00
2026-06-12 15:38:53 -07:00
2026-06-25 09:42:45 -07:00
2026-05-29 08:35:00 -07:00
2026-08-14 09:28:56 -07:00
2026-07-14 16:35:30 -07:00
2026-07-14 16:35:30 -07:00
2026-07-14 16:35:30 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-08-15 09:37:04 -07:00
2026-06-04 11:14:43 -07:00
2026-05-01 19:51:51 -07:00
2026-06-04 11:14:43 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-05-01 19:51:51 -07:00
2026-08-15 22:20:30 -07:00
2026-04-23 18:25:34 -07:00
2026-08-08 09:28:45 -07:00
2026-04-18 15:05:42 +08:00
2026-08-15 11:42:19 -07:00
2026-05-11 12:16:26 -07:00
2026-08-15 11:42:19 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-04-19 08:38:19 +08:00
2026-08-15 09:37:04 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 11:42:19 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-05-26 21:36:53 -07:00
2026-08-15 09:37:04 -07:00
2026-03-13 21:08:12 -07:00
2026-05-29 08:35:00 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 11:42:19 -07:00
2026-06-07 19:13:24 -07:00
2026-08-15 22:20:30 -07:00
2026-05-25 10:57:15 -07:00
2026-08-15 22:20:30 -07:00
2026-05-29 08:35:00 -07:00
2026-08-15 11:42:19 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-08-15 11:42:19 -07:00
2026-06-21 07:15:19 -07:00
2026-05-30 12:09:10 -07:00
2026-06-08 05:41:07 -07:00
2026-08-15 22:20:30 -07:00
2026-08-16 19:34:41 -07:00
2026-05-25 10:57:15 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 22:20:30 -07:00
2026-08-15 09:37:04 -07:00
2026-08-16 09:53:31 -07:00
2026-08-16 09:53:31 -07:00
2026-05-30 12:09:10 -07:00
2026-08-16 19:34:41 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-05-24 01:43:51 -07:00
2026-08-16 19:34:41 -07:00
2026-08-14 22:02:07 -07:00
2026-08-15 09:37:04 -07:00
2026-08-15 11:42:19 -07:00
2026-08-14 22:02:07 -07:00
2026-04-06 14:41:06 -07:00
2026-05-26 16:50:03 -07:00