mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 22:45:02 +01:00
* fix: mark Remaining Work provenance so restore verifies guessed steps first (#3004) /context-save now starts every Remaining Work item with `Open.` and ends it with how this session knows it: `(path run)` with the observed outcome, `(path read)` or `(path assumed)` for concrete paths, and `(target state checked)`, `(code read)` or `(path assumed)` for writing steps. /context-restore keeps saved order and original text but splits the list into Next steps and Verify first (assumed, code-read, failed runs and unmarked concrete or writing items), prints a banner for pre-marker checkpoints, and option A walks saved order so an unverified first item is verified before any later step runs. Adds a prompt-byte contract test for the marker wire format and a periodic behavior E2E (context-restore-provenance-order) that seeds an assumed item ahead of a run item plus a code-read write. Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> * fix(design): never overwrite a paid design image (#1529) Every image the API returns now goes through one persistence path (design/src/persist.ts): mkdir, exclusive `wx` claim that bumps x.png -> x-2.png ... x-999.png, write, fsync, close. A failure after the bytes arrived removes the claimed file and keeps a 0600 recovery copy in the temp dir; empty image data is a failure, never a 0-byte PNG. The API call is the only thing inside each retry loop, so a local save failure never buys a second image (variants, iterate fallback, generate --retry). generate, iterate, evolve and variants (both branches) print the same run fields (requested, saved, selected, failures, recovered) on every exit, with exit 0 / 2 (nothing saved) / 3 (stopped after saving). Each generate --retry attempt is its own saved image listed in `attempts`. compare accepts --images-file and JSON-array --images. The gallery lists bumped names, orders history by mtime then board-images.json, and marks approvals by approved_path. New bin/gstack-design-claim publishes staged images without clobbering; bin/gstack-design-approved resolves an approval record (legacy letter-only records still resolve; a missing approved_path is an error, never a substitute). Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> * fix(design skills): read the paths $D printed, never fixed variant names (#1529) Every design flow now captures each generating $D command's JSON and exit code without set -e, does round accounting before the first board, check or inline view (stopping when nothing was saved), and carries the printed paths forward. Boards are built from board-images.json via compare --images-file after archiving any earlier feedback.json, and approvals map the confirmed letter through that file and record approved_path. design-shotgun subagents generate into a per-run mktemp staging directory and publish with bin/gstack-design-claim instead of a shared /tmp/variant-X.png plus cp. design-html and taste memory resolve approvals with gstack-design-approved; design-review verifies against the printed target path. test/design-printed-paths.test.ts bans fixed variant names, variant globs, variant-{letter} reads, cp/mv of $D output and literal check paths in the generated skills and resolvers (one content-anchored allowlist entry: the design-html discovery probe), and pins the accounting/board marker order. test/design-approval-flow.test.ts runs the generated board and approval blocks through a stubbed two-round flow. * chore: release v1.91.17.0 (mvanhorn fix wave: checkpoint provenance, never-overwrite design images) * fix(design): keep iterate sessions in the OS temp dir and normalize tripwire paths on Windows * fix(setup-deploy): report failing status commands, specify merge-method, health and workflow checks --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
81 lines
1.9 KiB
TypeScript
81 lines
1.9 KiB
TypeScript
/**
|
|
* Session state management for multi-turn design iteration.
|
|
* Session files are JSON in the OS temp directory, keyed by PID + timestamp.
|
|
*/
|
|
|
|
import fs from "fs";
|
|
import os from "os";
|
|
import path from "path";
|
|
|
|
export interface DesignSession {
|
|
id: string;
|
|
lastResponseId: string;
|
|
originalBrief: string;
|
|
feedbackHistory: string[];
|
|
outputPaths: string[];
|
|
createdAt: string;
|
|
updatedAt: string;
|
|
}
|
|
|
|
/**
|
|
* Generate a unique session ID from PID + timestamp.
|
|
*/
|
|
export function createSessionId(): string {
|
|
return `${process.pid}-${Date.now()}`;
|
|
}
|
|
|
|
/**
|
|
* Get the file path for a session.
|
|
*/
|
|
export function sessionPath(sessionId: string): string {
|
|
return path.join(os.tmpdir(), `design-session-${sessionId}.json`);
|
|
}
|
|
|
|
/**
|
|
* Create a new session after initial generation.
|
|
*/
|
|
export function createSession(
|
|
responseId: string,
|
|
brief: string,
|
|
outputPath: string,
|
|
): DesignSession {
|
|
const id = createSessionId();
|
|
const session: DesignSession = {
|
|
id,
|
|
lastResponseId: responseId,
|
|
originalBrief: brief,
|
|
feedbackHistory: [],
|
|
outputPaths: [outputPath],
|
|
createdAt: new Date().toISOString(),
|
|
updatedAt: new Date().toISOString(),
|
|
};
|
|
|
|
fs.writeFileSync(sessionPath(id), JSON.stringify(session, null, 2), { mode: 0o600 });
|
|
return session;
|
|
}
|
|
|
|
/**
|
|
* Read an existing session from disk.
|
|
*/
|
|
export function readSession(sessionFilePath: string): DesignSession {
|
|
const content = fs.readFileSync(sessionFilePath, "utf-8");
|
|
return JSON.parse(content);
|
|
}
|
|
|
|
/**
|
|
* Update a session with new iteration data.
|
|
*/
|
|
export function updateSession(
|
|
session: DesignSession,
|
|
responseId: string,
|
|
feedback: string,
|
|
outputPath: string,
|
|
): void {
|
|
session.lastResponseId = responseId;
|
|
session.feedbackHistory.push(feedback);
|
|
session.outputPaths.push(outputPath);
|
|
session.updatedAt = new Date().toISOString();
|
|
|
|
fs.writeFileSync(sessionPath(session.id), JSON.stringify(session, null, 2));
|
|
}
|