mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-15 09:25:28 +02:00
Garry TanandClaude Fable 5
a171029e6b
Specialist army findings, all quote-verified before fixing:
Security: careful force-push guard now catches git's plus-refspec force
syntax (git push origin +main carried force with no flag — silently allowed
before) and refspec-form targets (HEAD:main); default-branch matching is
tokenized FIXED-STRING comparison on the full branch path (slashed defaults
like release/2.0 work; no ERE interpolation), glob-safe via noglob. HIGH rm
tier is tokenized too: trailing long options (--no-preserve-root) and /* are
root-class. Stored evidence fingerprints are 40-hex re-validated before
reaching git argv. normalizeForDetection sweeps ALL Unicode format chars
(\p{Cf}: soft hyphens, bidi marks, tag chars) instead of five enumerated
zero-widths. The wiring scanner gains flagless gh pr/issue view patterns. The
release-body banner tripwire diffs against the fetched original so a hostile
pre-existing banner string can't permanently DoS doc updates. Ship/land
evidence checks now pass --expect-cmd (a green `echo ok` recorded under the
label can never mint FRESH); package.json stays allow-listed with the
residual documented.
Performance: gstack-wtree seeds its temp index by COPYING the real index
(stat cache preserved — measured 40x faster than read-tree seeding, identical
hash) with read-tree fallback; evidence uses findLast and one gstack-slug
spawn; the stream pump honors backpressure via drain; careful's pattern block
short-circuits before slug resolution when no pattern file exists.
Testing: the gh-failure envelope test was VACUOUS (killing PATH killed the
bun shebang before the code under test ran) — replaced with a PATH gh shim
that exercises the real branch, plus shimmed happy paths (issue/pr-body/
unparseable JSON); evidence check --all + empty ledger + non-numeric
--max-age (now a usage error, was silent fail-open) covered; HIGH-tier
variants pinned; hook analytics respect GSTACK_HOME so tests stop writing the
operator's real skill-usage.jsonl.
Maintainability: dead exit ternary removed; flagValue deduped into
bin-context; sentinel defusal derived from the banner constants (no invisible
literals — \u escapes only); scratch-repo git fixture extracted to
test/helpers/scratch-repo.ts (one hermetic incantation, three consumers);
shared gstack_hook_log_fire in hook-extract.sh; the dashboard/land diff-scoped
row lists are aligned (codex-review) and drift-pinned.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
75 lines
3.9 KiB
Bash
75 lines
3.9 KiB
Bash
#!/usr/bin/env bash
|
|
# hook-extract.sh — SHARED JSON helpers for gstack PreToolUse hooks.
|
|
# Sourced (never executed) by careful/bin/check-careful.sh and
|
|
# freeze/bin/check-freeze.sh via a path relative to each hook script.
|
|
#
|
|
# ONE copy on purpose. These two hooks previously carried separate extractor
|
|
# copies; the escaped-quote truncation bug got fixed in careful's copy while
|
|
# freeze silently kept the broken one. Any future parsing fix lands here and
|
|
# reaches both hooks by construction.
|
|
|
|
# gstack_hook_extract_field PAYLOAD FIELD
|
|
# Prints tool_input.FIELD when PAYLOAD is valid JSON and the field is a
|
|
# string ("" when absent or non-string). Returns 1 when no parser is
|
|
# available or the payload is not parseable JSON — the CALLER decides the
|
|
# polarity for that case (careful asks, freeze denies).
|
|
#
|
|
# python3 is tried first because it ships with macOS and most Linux distros
|
|
# and is reliably on PATH in a hook environment; node is the fallback.
|
|
gstack_hook_extract_field() {
|
|
_ghef_payload="$1"
|
|
_ghef_field="$2"
|
|
if command -v python3 >/dev/null 2>&1; then
|
|
printf '%s' "$_ghef_payload" | python3 -c 'import sys,json
|
|
field = sys.argv[1]
|
|
d = json.loads(sys.stdin.read())
|
|
c = d.get("tool_input", {}).get(field, "")
|
|
sys.stdout.write(c if isinstance(c, str) else "")' "$_ghef_field" 2>/dev/null && return 0
|
|
fi
|
|
if command -v node >/dev/null 2>&1; then
|
|
printf '%s' "$_ghef_payload" | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>{try{const j=JSON.parse(s);const c=(j&&j.tool_input&&j.tool_input[process.argv[1]])||"";process.stdout.write(typeof c==="string"?c:"")}catch(e){process.exit(3)}})' "$_ghef_field" 2>/dev/null && return 0
|
|
fi
|
|
return 1
|
|
}
|
|
|
|
# gstack_hook_json_string TEXT
|
|
# Prints TEXT as a JSON string literal (surrounding quotes included),
|
|
# encoding quotes, backslashes, control characters and newlines. Never build
|
|
# hook JSON with printf/sed interpolation: a path containing a quote or a
|
|
# newline produces malformed JSON, and Claude Code silently ignores the
|
|
# whole decision — a deny that no-ops exactly when it matters.
|
|
gstack_hook_json_string() {
|
|
_ghjs_text="$1"
|
|
if command -v python3 >/dev/null 2>&1; then
|
|
printf '%s' "$_ghjs_text" | python3 -c 'import sys,json; sys.stdout.write(json.dumps(sys.stdin.read()))' 2>/dev/null && return 0
|
|
fi
|
|
if command -v node >/dev/null 2>&1; then
|
|
printf '%s' "$_ghjs_text" | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>process.stdout.write(JSON.stringify(s)))' 2>/dev/null && return 0
|
|
fi
|
|
# Last-resort fallback (no parser on PATH): strip to a safe charset so the
|
|
# envelope stays valid JSON even if the message loses characters.
|
|
printf '"%s"' "$(printf '%s' "$_ghjs_text" | tr -cd 'a-zA-Z0-9 ._/:@=+-' )"
|
|
}
|
|
|
|
# gstack_hook_decision DECISION REASON
|
|
# Emits the full PreToolUse hookSpecificOutput envelope with REASON safely
|
|
# JSON-encoded. DECISION is "ask" or "deny". The decision MUST be nested
|
|
# under hookSpecificOutput — Claude Code ignores a top-level
|
|
# permissionDecision, which silently no-ops the block.
|
|
gstack_hook_decision() {
|
|
_ghd_decision="$1"
|
|
_ghd_reason="$2"
|
|
_ghd_encoded=$(gstack_hook_json_string "$_ghd_reason")
|
|
printf '{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"%s","permissionDecisionReason":%s}}\n' "$_ghd_decision" "$_ghd_encoded"
|
|
}
|
|
|
|
# gstack_hook_log_fire SKILL PATTERN
|
|
# Append a hook_fire analytics record (pattern name only, never command
|
|
# content). Respects GSTACK_HOME so tests never pollute the operator's real
|
|
# analytics file. Best-effort: failures never affect the hook decision.
|
|
gstack_hook_log_fire() {
|
|
_ghlf_dir="${GSTACK_HOME:-$HOME/.gstack}/analytics"
|
|
mkdir -p "$_ghlf_dir" 2>/dev/null || true
|
|
echo '{"event":"hook_fire","skill":"'"$1"'","pattern":"'"$2"'","ts":"'$(date -u +%Y-%m-%dT%H:%M:%SZ)'","repo":"'$(basename "$(git rev-parse --show-toplevel 2>/dev/null)" 2>/dev/null || echo "unknown")'"}' >> "$_ghlf_dir/skill-usage.jsonl" 2>/dev/null || true
|
|
}
|