Files
gstack/bin/gstack-review-read
T
Garry Tanandcapy-ai[bot] a26529ac8e /ship accepts a stopped review once the owner rules its findings open notes (GST-3267) (#4552)
When the final review or the native reader stops on findings and the
owner records each one with `gstack-approvals rule` at that head, /ship
now counts those rulings when it binds the two reviews, so /ship can
finish.

Before, the review reader ignored rulings there, so a PR with green CI
and accepted findings could not finish /ship (harness-evals#498).

Nothing to do: a ruling for another branch, head or finding, or one
gstack wrote for itself, still counts for nothing.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-20 08:26:16 +00:00

68 lines
4.2 KiB
Bash
Executable File

#!/usr/bin/env bash
# gstack-review-read — read review log and config for dashboard
# Usage: gstack-review-read
#
# Emits, in order: reviews JSONL with computed review_freshness, ---CONFIG--- (skip_eng_review),
# ---HEAD--- (short sha), ---WTREE--- (current working-tree fingerprint from
# bin/gstack-wtree --review, or "unknown"), ---TREE--- (HEAD tree, informational) and
# ---DIRTY--- (tracked-file dirty flag). Consumers grade diff-scoped review
# rows using review_freshness; legacy or uncaptured diff evidence cannot fall
# back to HEAD equality. Plan rows are unchanged. A gate finding the owner's gstack-approvals
# gate row closes reads `kept` with its `disposition`, and the row's `gate_dispositions` lists
# those approval ids (lib/gate-dispositions.ts). review_freshness counts the owner's
# gstack-approvals rule rows at a head in the row's range (ruledOn), and the row's `ruled_notes`
# lists their approval ids; values the row itself carried are discarded.
set -euo pipefail
GSTACK_BUN_CONFIG=/dev/null; case "${OSTYPE:-}" in msys*|cygwin*) if command -v cygpath >/dev/null 2>&1; then GSTACK_BUN_CONFIG=NUL; fi ;; esac
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
case "$(uname -s)" in
MINGW*|MSYS*|CYGWIN*) command -v cygpath >/dev/null 2>&1 && SCRIPT_DIR="$(cygpath -m "$SCRIPT_DIR")" ;;
esac
eval "$("$SCRIPT_DIR/gstack-slug" 2>/dev/null)"
SLUG=$("$SCRIPT_DIR/gstack-slug" --get REPO_SLUG 2>/dev/null || true)
. "$(dirname "$0")/gstack-state-root.sh" 2>/dev/null || { echo "$0: cannot resolve the gstack state root: $(dirname "$0")/gstack-state-root.sh is missing. fix: reinstall with ./setup or /gstack-upgrade (docs/state-root.md)" >&2; exit 1; }
gstack_state_root_select
GSTACK_HOME="$_gstack_sr_root"
WTREE=$("$SCRIPT_DIR/gstack-wtree" --review 2>/dev/null || echo "unknown")
if [ -f "$GSTACK_HOME/projects/$SLUG/$BRANCH-reviews.jsonl" ]; then
GSTACK_REVIEW_LIB="$SCRIPT_DIR/../lib/review-evidence.ts" GSTACK_GATE_LIB="$SCRIPT_DIR/../lib/gate-dispositions.ts" GSTACK_RULED_LIB="$SCRIPT_DIR/../lib/ruled-notes.ts" GSTACK_REVIEW_WTREE="$WTREE" bun --no-env-file --config="${GSTACK_BUN_CONFIG:-/dev/null}" -e '
const { reviewFreshness } = await import(process.env.GSTACK_REVIEW_LIB);
const { dispositionedOn, gateKey, readGateDispositions, ruledOn, showDispositioned } = await import(process.env.GSTACK_GATE_LIB);
const { readRuledNotes } = await import(process.env.GSTACK_RULED_LIB);
let dispositions = [];
try { dispositions = readGateDispositions(process.cwd()); }
catch (e) { console.error("gstack-review-read: gate dispositions unreadable, none applied: " + e.message); }
let rulings = [];
try { rulings = readRuledNotes(process.cwd()); }
catch (e) { console.error("gstack-review-read: rulings unreadable, none applied: " + e.message); }
for (const line of (await Bun.stdin.text()).split("\n").filter(Boolean)) {
try {
const rec = JSON.parse(line);
delete rec.review_freshness;
delete rec.gate_dispositions;
delete rec.ruled_notes;
for (const f of Array.isArray(rec.findings) ? rec.findings : []) if (f && typeof f === "object") delete f.disposition;
const closed = dispositionedOn(process.cwd(), rec, dispositions);
const ruled = ruledOn(process.cwd(), rec, rulings);
const freshness = reviewFreshness(rec, process.env.GSTACK_REVIEW_WTREE, new Set(ruled.map(n => n.finding)), new Set(closed.map(d => gateKey(d.finding, d.gate_id))));
if (freshness) rec.review_freshness = freshness;
if (ruled.length) rec.ruled_notes = ruled.map(n => n.approval);
showDispositioned(rec, closed);
console.log(JSON.stringify(rec));
} catch { console.error("gstack-review-read: skipping malformed review row"); }
}
' < "$GSTACK_HOME/projects/$SLUG/$BRANCH-reviews.jsonl"
else
echo "NO_REVIEWS"
fi
echo "---CONFIG---"
"$SCRIPT_DIR/gstack-config" get skip_eng_review 2>/dev/null || echo "false"
echo "---HEAD---"
git rev-parse --short HEAD 2>/dev/null || echo "unknown"
echo "---WTREE---"
echo "$WTREE"
echo "---TREE---"
git rev-parse 'HEAD^{tree}' 2>/dev/null || echo "unknown"
echo "---DIRTY---"
if [ -n "$(git status --porcelain -uno 2>/dev/null | head -1)" ]; then echo "true"; else echo "false"; fi