Garry Tan and capy-ai[bot]
a26529ac8e
/ship accepts a stopped review once the owner rules its findings open notes (GST-3267) ( #4552 )
...
When the final review or the native reader stops on findings and the
owner records each one with `gstack-approvals rule` at that head, /ship
now counts those rulings when it binds the two reviews, so /ship can
finish.
Before, the review reader ignored rulings there, so a PR with green CI
and accepted findings could not finish /ship (harness-evals#498).
Nothing to do: a ruling for another branch, head or finding, or one
gstack wrote for itself, still counts for nothing.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-20 08:26:16 +00:00
..
2026-11-09 08:00:55 +00:00
2026-11-18 17:08:51 +00:00
2026-03-17 16:34:08 -05:00
2026-11-17 08:39:43 +00:00
2026-08-08 09:28:45 -07:00
2026-11-04 03:33:48 +00:00
2026-11-02 01:35:47 +00:00
2026-06-04 11:14:43 -07:00
2026-09-22 14:57:52 -04:00
2026-11-18 08:47:07 +00:00
2026-11-07 07:14:20 +00:00
2026-11-08 14:26:14 +00:00
2026-11-17 09:05:25 +00:00
2026-11-04 03:38:56 +00:00
2026-11-17 12:23:35 +00:00
2026-10-31 18:12:53 +00:00
2026-10-04 21:47:21 -07:00
2026-11-08 02:18:23 +00:00
2026-11-09 06:38:42 +00:00
2026-11-03 04:31:44 +00:00
2026-11-03 04:31:44 +00:00
2026-09-29 06:07:35 -07:00
2026-11-17 23:19:24 +00:00
2026-11-02 17:44:00 +00:00
2026-10-26 13:22:30 +00:00
2026-11-17 18:34:52 +00:00
2026-11-10 06:22:58 +00:00
2026-11-04 03:15:35 +00:00
2026-11-19 13:10:18 +00:00
2026-10-19 19:44:10 +00:00
2026-11-07 06:53:27 +00:00
2026-09-29 06:07:35 -07:00
2026-10-16 22:00:32 +00:00
2026-11-16 02:51:22 +00:00
2026-11-08 11:23:55 +00:00
2026-11-16 02:51:22 +00:00
2026-11-19 04:26:51 +00:00
2026-11-06 14:36:50 +00:00
2026-11-17 12:05:52 +00:00
2026-10-25 05:06:30 +00:00
2026-11-18 16:44:07 +00:00
2026-04-18 15:05:42 +08:00
2026-11-17 17:13:42 +00:00
2026-11-18 23:36:58 +00:00
2026-10-19 19:22:29 +00:00
2026-11-17 23:13:14 +00:00
2026-11-19 20:10:49 +00:00
2026-11-19 23:10:19 +00:00
2026-11-01 01:25:15 +00:00
2026-11-15 02:11:18 +00:00
2026-10-26 13:22:30 +00:00
2026-11-08 14:26:14 +00:00
2026-11-08 17:09:24 +00:00
2026-11-17 17:14:39 +00:00
2026-11-07 07:14:20 +00:00
2026-11-19 23:17:49 +00:00
2026-11-18 13:32:03 +00:00
2026-11-20 08:26:16 +00:00
2026-11-07 18:43:11 +00:00
2026-11-19 22:04:13 +00:00
2026-11-19 15:17:30 +00:00
2026-09-06 08:54:25 -07:00
2026-11-08 14:26:14 +00:00
2026-11-02 19:23:49 +00:00
2026-11-17 08:25:01 +00:00
2026-11-15 02:11:18 +00:00
2026-10-05 01:29:54 +00:00
2026-11-08 14:26:14 +00:00
2026-11-05 00:43:21 +00:00
2026-11-15 02:11:18 +00:00
2026-11-17 14:37:34 +00:00
2026-11-15 02:06:53 +00:00
2026-11-20 02:24:04 +00:00
2026-09-29 06:07:35 -07:00
2026-11-19 17:05:16 +00:00
2026-11-19 15:42:21 +00:00
2026-11-17 12:23:35 +00:00
2026-11-07 06:52:04 +00:00
2026-11-17 13:14:33 +00:00