mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 22:54:36 +01:00
Pass 1 of /ship's review loop on #3516 (core, four specialists, native and outside adversarial, Red Team). Fixed in the diff: - test/skill-e2e-ship-docsync.test.ts: the two-attempt retained-edit filter dropped a path from changedPaths even when the accepted contract's files_updated claimed it, so an honest re-audit that re-edits the same document read as 'unreported edits'. acceptedChangedPaths() in test/helpers/docsync-contract.ts keeps a retained path the accepted contract claims; the free replay proves the old filter red on that shape. - test/helpers/ship-hook-actor.ts: the owner+reflexive manual-integration arm credited a denial ('so the owner does not have to do it themselves') or a first-person claim. ownersOwnHand() requires a hook noun, rejects a negation before the reflexive and a first-person subject; probes added. - scripts/resolvers/plan-gates.ts + review/sections/manifest.json: the no-plan path still said 'Emit Step 1.5's Scope Check once' and the STOP trigger 'finishing Step 1.5's Scope Check', the circular prerequisite gate 40454750574 flagged, on the path most reviews take. Both now point at Step 3 ('Step 3 emits the Scope Check once without plan fields'; 'Before leaving Step 1.5'). - review/SKILL.md.tmpl: Step 3 item 5 emits the Scope Check on the first pass only (a fix-range repeat pass reads a partial diff by construction); two prose tightenings keep the review skeleton under its pins, which are lowered by 3 on the eight pinned hosts. - test/helpers/docsync-interface.ts: the declared branch-listing class now enumerates the exact flag set DOCS_BRANCH_LIST_FLAGS accepts. Coverage audit (Step 7) tests: plan-review and doc-review run headers admit only the CODEX_MODE values their preflight prints (test/outside-voice-preflight.test.ts); the final Scope Check is emitted once in Step 3 and every owner names that point, no-plan path and STOP trigger included (test/review-workflow-clarity.test.ts). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>