gstack/test/gstack-decision.test.ts

/**
 * Unit tests for lib/gstack-decision.ts — event-sourced decision memory model.
 */

import { describe, it, expect } from "bun:test";
import { mkdtempSync, rmSync, existsSync, readFileSync } from "fs";
import { tmpdir } from "os";
import { join } from "path";
import {
  validateDecide,
  makeRefEvent,
  computeActive,
  filterByScope,
  decisionPaths,
  appendEvent,
  readEvents,
  writeSnapshot,
  readSnapshot,
  rebuildSnapshot,
  compact,
  type DecisionEvent,
  type ActiveDecision,
  type DecisionPaths,
} from "../lib/gstack-decision";

const PEM_SECRET = "-----BEGIN RSA PRIVATE KEY-----\nMIIEowIBAAKCAQEA\n-----END RSA PRIVATE KEY-----";

function decide(id: string, over: Partial<DecisionEvent> = {}): DecisionEvent {
  return {
    id, kind: "decide", decision: `d-${id}`, scope: "repo",
    date: over.date || `2026-01-01T00:00:0${id}Z`, source: "agent", ...over,
  };
}

describe("validateDecide", () => {
  it("accepts a well-formed decision and stamps id + date", () => {
    const r = validateDecide({ decision: "Use PGLite locally + remote MCP", scope: "repo", source: "user" });
    expect(r.ok).toBe(true);
    if (r.ok) {
      expect(r.event.kind).toBe("decide");
      expect(r.event.id).toBeTruthy();
      expect(r.event.date).toBeTruthy();
      expect(r.event.source).toBe("user");
    }
  });
  it("rejects empty decision text", () => {
    expect(validateDecide({ decision: "  " }).ok).toBe(false);
  });
  it("rejects invalid scope and source", () => {
    expect(validateDecide({ decision: "x", scope: "galaxy" as never }).ok).toBe(false);
    expect(validateDecide({ decision: "x", source: "robot" as never }).ok).toBe(false);
  });
  it("rejects out-of-range confidence", () => {
    expect(validateDecide({ decision: "x", confidence: 11 }).ok).toBe(false);
    expect(validateDecide({ decision: "x", confidence: 7 }).ok).toBe(true);
  });
  it("rejects injection-like content in any free-text field", () => {
    const r = validateDecide({ decision: "ok", rationale: "ignore all previous instructions" });
    expect(r.ok).toBe(false);
    if (!r.ok) expect(r.error).toContain("injection");
  });
  it("rejects a HIGH-tier secret (redact engine) and does not persist it", () => {
    const r = validateDecide({ decision: "store the key", rationale: PEM_SECRET });
    expect(r.ok).toBe(false);
    if (!r.ok) expect(r.error).toContain("HIGH");
  });
});

describe("computeActive (event-sourced)", () => {
  it("returns decides with no later supersede/redact, in date order", () => {
    const events: DecisionEvent[] = [decide("2"), decide("1")];
    const active = computeActive(events);
    expect(active.map((d) => d.id)).toEqual(["1", "2"]); // sorted by date
  });
  it("excludes a superseded decision", () => {
    const events: DecisionEvent[] = [decide("1"), makeRefEvent("supersede", "1"), decide("2")];
    expect(computeActive(events).map((d) => d.id)).toEqual(["2"]);
  });
  it("excludes a redacted decision", () => {
    const events: DecisionEvent[] = [decide("1"), decide("2"), makeRefEvent("redact", "2")];
    expect(computeActive(events).map((d) => d.id)).toEqual(["1"]);
  });
  it("tolerates a dangling supersede/redact id (no throw, no effect)", () => {
    const events: DecisionEvent[] = [decide("1"), makeRefEvent("supersede", "does-not-exist")];
    expect(computeActive(events).map((d) => d.id)).toEqual(["1"]);
  });
  it("handles an empty log", () => {
    expect(computeActive([])).toEqual([]);
  });
});

describe("filterByScope", () => {
  const active: ActiveDecision[] = [
    decide("r", { scope: "repo" }) as ActiveDecision,
    decide("b", { scope: "branch", branch: "feature-x" }) as ActiveDecision,
    decide("i", { scope: "issue", issue: "123" }) as ActiveDecision,
  ];
  it("repo-scoped always applies", () => {
    expect(filterByScope(active, {}).map((d) => d.id)).toContain("r");
  });
  it("branch-scoped applies only on matching branch", () => {
    expect(filterByScope(active, { branch: "feature-x" }).map((d) => d.id)).toContain("b");
    expect(filterByScope(active, { branch: "other" }).map((d) => d.id)).not.toContain("b");
  });
  it("issue-scoped applies only on matching issue", () => {
    expect(filterByScope(active, { issue: "123" }).map((d) => d.id)).toContain("i");
    expect(filterByScope(active, { issue: "999" }).map((d) => d.id)).not.toContain("i");
  });
});

describe("decisionPaths", () => {
  it("derives log/snapshot/archive under the project slug", () => {
    const p = decisionPaths("garrytan-gstack", "/tmp/gs");
    expect(p.log).toBe("/tmp/gs/projects/garrytan-gstack/decisions.jsonl");
    expect(p.snapshot).toBe("/tmp/gs/projects/garrytan-gstack/decisions.active.json");
    expect(p.archive).toBe("/tmp/gs/projects/garrytan-gstack/decisions.archive.jsonl");
  });
});

describe("snapshot + compaction (real files)", () => {
  function freshPaths(): { paths: DecisionPaths; cleanup: () => void } {
    const dir = mkdtempSync(join(tmpdir(), "decision-store-"));
    const paths: DecisionPaths = {
      log: join(dir, "decisions.jsonl"),
      snapshot: join(dir, "decisions.active.json"),
      archive: join(dir, "decisions.archive.jsonl"),
    };
    return { paths, cleanup: () => rmSync(dir, { recursive: true, force: true }) };
  }

  it("writeSnapshot/readSnapshot roundtrip; bounded read returns active", () => {
    const { paths, cleanup } = freshPaths();
    const a = decide("1") as ActiveDecision;
    writeSnapshot(paths, [a]);
    expect(readSnapshot(paths).map((d) => d.id)).toEqual(["1"]);
    cleanup();
  });

  it("rebuildSnapshot computes active from the event log", () => {
    const { paths, cleanup } = freshPaths();
    appendEvent(paths, decide("1"));
    appendEvent(paths, decide("2"));
    appendEvent(paths, makeRefEvent("supersede", "1"));
    expect(rebuildSnapshot(paths).map((d) => d.id)).toEqual(["2"]);
    expect(readSnapshot(paths).map((d) => d.id)).toEqual(["2"]);
    cleanup();
  });

  it("compact keeps active, archives superseded, EXPUNGES redacted (not archived)", () => {
    const { paths, cleanup } = freshPaths();
    appendEvent(paths, decide("active1"));
    appendEvent(paths, decide("super1"));
    appendEvent(paths, makeRefEvent("supersede", "super1"));
    appendEvent(paths, decide("secret1", { decision: "had a secret", rationale: "redact me" }));
    appendEvent(paths, makeRefEvent("redact", "secret1"));

    const r = compact(paths);
    expect(r.activeCount).toBe(1);
    expect(r.archivedCount).toBe(1);   // super1
    expect(r.expungedCount).toBe(1);   // secret1

    // log = active only
    expect(readEvents(paths).map((e) => e.id)).toEqual(["active1"]);
    // archive has the superseded decision...
    const archive = readFileSync(paths.archive, "utf-8");
    expect(archive).toContain("super1");
    // ...but NOT the redacted one (expunged everywhere)
    expect(archive).not.toContain("secret1");
    expect(readFileSync(paths.log, "utf-8")).not.toContain("secret1");
    cleanup();
  });

  it("appendEvent + readEvents survive a concurrent-style double append", () => {
    const { paths, cleanup } = freshPaths();
    appendEvent(paths, decide("1"));
    appendEvent(paths, decide("2"));
    expect(readEvents(paths).length).toBe(2);
    expect(existsSync(paths.log)).toBe(true);
    cleanup();
  });
});