Files
gstack/test/fixtures/design-gap-z-calls.json
T
Garry TanandOpenAI Codex 9f81911136 v1.86.0.0 feat: route outside reviews by harness (#2850)
* feat: add a restricted and supervised Claude Code runner

Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment.

* feat: route outside reviews by harness and migrate wrapper installs

Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage.

* test: recognize CEO mode labels without terminal spacing

The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions.

* test: isolate plan-count fixtures before starting review workflows

Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations.

* test: stabilize review fixtures and Claude eval startup

Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: classify collapsed review modes and isolate seeded findings

Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: isolate browser daemon state across free shards

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: stabilize native review counting and interactive navigation

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* chore: prepare v1.82.0.0 release

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: eliminate browser and process-cleanup test flakes

Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing
reused live sockets. Add an isolated GC/listener regression that fails on
Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime.

Check renderer cleanup against the render's own staging directory so
concurrent renders cannot invalidate the assertion. Make the no-pgrep
process-tree walk tolerate disappearing /proc entries, and synchronize
its test fixture through child readiness and pipe EOF instead of sleeps.

Validation: 9,157 passed, 31 skipped, zero failures across 556 files with
retries disabled. Build, all-host generation freshness, and skill checks
passed. All three races have failing-before/passing-after regressions.

* fix: count completed native review questions in evals

* fix: drive review navigation from confirmed native choices

* fix: require complete section-loading eval reports

* test: isolate telemetry HTTP transport from local assertions

* fix: keep review input on the active native question

* test: let tunnel revocation daemon choose an available port

* test: allocate available ports for pairing and watchdog fixtures

* fix: stabilize planning eval navigation and phase reporting

* test: isolate installed runtime paths in planning evals

* test: stabilize review evidence and concurrent refresh fixtures

* fix: resolve design findings before editing the plan

* fix: honor and persist disabled outside plan reviews

* fix: preserve planning decisions and terminal evidence

Load installed host reviews at autoplan phase entry and wait for completed
reviewers and saved artifacts. Reuse approved remedies while preserving
individual finding decisions.

Drive interactive evals from the current terminal viewport, bind native
questions across scrolling, and require complete native report evidence.
Cover captured stale menus, permission lifecycles, setup classification,
and disabled-review tool availability with deterministic regressions.

Advance release metadata and the upgrade migration to the unclaimed
1.83.0.0 slot.

* fix: drive native review questions and preserve current plans

Use the native single-choice keyboard protocol and current terminal viewport,
with per-question navigation inside packets and completed-call coverage.
Keep permissions, multi-select menus, and Submit controls distinct.

Send Autoplan reviewers the amended implementation plan, keep its review record
separate, and supply retained application contracts in the chain fixture.
Clarify individual DevEx decisions and complete CEO fix options; use one active
plan destination for the section-loading report.

* fix: preserve complete plan-review decisions

* fix: recognize native plan dialogs and reviewer controls

* fix: preserve review decisions and phase completion

* fix: recognize completed reviews without losing findings

* fix: preserve review continuity and native eval completion

* test: fix native review completion and eval retry isolation

* test: handle native review menus and complete eval fixtures

* test: fix native review setup, completion, and isolation failures

* test: limit native skill discovery to runtime assets

* fix: bind Autoplan reviews to full ordered phase inputs

* test: fix planning eval routing, counting, and timeout handling

* chore: advance queued release to v1.84.0.0

* fix: preserve complete review inputs and planning decisions

* fix: reconcile review approvals and preserve phase obligations

* fix: preserve review obligations and unblock eval permissions

Carry recorded Autoplan requirements into blind phase inputs, require Eng
review approvals before exit, and exercise combined asynchronous flows in
CEO reviews. Correct native finding and handoff classification and unblock
repeated report edits using scoped request identities.

* fix: retain plan requirements and complete native review dialogs

* fix: complete native review prompts and retain plan references

* fix: preserve review inputs and classify native eval evidence

* fix: check competing completion orders in CEO reviews

* fix: recognize review decisions and require phase methodology

Require the current phase methodology before Autoplan snapshots. Correct
substantive decision, closed handoff, and cache-finding classification, and
honor the recommended implementation approach in native review dialogs.

Add captured-transcript regressions without changing review thresholds,
provider models, retries, or deadlines.

* test: bind native review decisions and close completed handoffs

* fix: complete review dialogs and verify methodology delivery

* fix: preserve review evidence and unblock native eval prompts

* fix: handle native review question completions

* fix: recognize native review narration and controls

* fix: count native review decisions and isolate eval fixtures

* test: verify seeded review coverage and current artifact permissions

* test: isolate model and brain-aware skill renders

* fix: repair native workflow evaluation and clarify review steps

* fix: stabilize workflow eval evidence and review guidance

* test: repair native workflow observation and fixture isolation

* fix: recognize completed workflow evidence and owned skill reads

* test: repair seeded workflow delivery and completion evidence

* test: recognize current review evidence across native forms

* test: handle native review variants and permission redraws

* fix: honor review preferences and recognize native eval evidence

* test: recognize completed review decisions and queued permissions

* test: match current review contracts and partial-line edits

* test: recognize completed workflow evidence and bounded human waits

* fix: preserve review entry gates and native eval interactions

* fix: recognize native workflow evidence and preserve review gates

* test: recognize current review evidence and preconfigure workflow fixtures

* test: recognize completed review findings and scoped artifact permissions

* fix: stabilize native workflow review and permission evidence

* fix: recognize current review evidence and scoped edit confirmations

Clarify Design and engineering review entry instructions and Design scoring.
Recognize required legacy coverage and public Autoplan completion recaps.
Bind the pending Edit confirmation to its exact file, ordered digest, and
one-request approval when a preceding command display remains visible.
Keep reviews within their existing size limits and preserve scope gates
when extracting workflow fixtures from either supported preamble header.

Keep failure outcomes, review thresholds, provider choices, and eval budgets.

* fix: recover review workflow progress and eval evidence

* fix: recognize valid review evidence and scope selection

* test: fix review evidence parsing and repeated artifact prompts

* test: recognize valid review decisions and pending native cards

* fix(plan-eng-review): keep final navigation consistent with approved tasks

* test: recognize valid review evidence and bind legacy diff requests

* fix: stabilize review eval evidence and harness repair guidance

* docs: update project documentation for v1.85.0.0

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: fix Windows CI fixtures and credential scan

Rebase captured JSON values and filesystem evidence using the appropriate
path convention. Compile native fake CLIs on Windows and synchronize pipe
holder readiness, with cleanup retained when assertions fail.

Assemble synthetic credential fixtures at runtime so the added-line scan
keeps enforcing the same gate without flagging its own rejection controls.

Discover generated skills directly for the empty-find regression check,
avoiding a recursive scan through saved evaluation artifacts and dependencies.

* fix: preserve source renders on Windows

Compare canonical generator paths using native separators so an output
sidecar pointing at the source cannot overwrite its skill or metadata.
Keep the regression fixture isolated from the real checkout and expose
freshness diagnostics before asserting subprocess status.

Detach Windows drain-test pipe holders from the fake provider's automatic
child cleanup while preserving the enclosing runner job and its assertions.

* fix: clarify outside review fallback and CEO decisions

Render one applicable own-harness fallback path and retain native review,
disabled policy, and missing-coverage semantics. Align report field names
and mode labels, and make the existing per-cut scope approval explicit.

Regenerate skill outputs and keep the workflow judge's model, thresholds,
and retry policy unchanged.

* chore: move release to free version slot (v1.86.0.0)

PR #2852 now claims v1.85.0.0. Align the release metadata and
rename migration so upgrades from that version still receive it.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: include engineering review prerequisites and restore branch context

* fix: recognize coverage diagrams and clarify design review instructions

* fix: preserve file identities and join Windows test processes

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>
2026-09-14 14:32:45 -07:00

237 lines
11 KiB
JSON

{
"calls": [
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_01N4SZ3Q3XtSxJn6UnBvskFb",
"questions": [
{
"question": "Gap 1 of 8 \u2014 Save button visual hierarchy: apply DESIGN.md primary button style?",
"header": "Gap 1: Button",
"multiSelect": false,
"options": [
{
"label": "Apply DESIGN.md fix (recommended)",
"description": "Add to plan: Save gets #1d4ed8 filled + white text (primary); Reset, Cancel, Export get neutral ghost style. Closes the visual hierarchy gap exactly as DESIGN.md specifies. Implementation task T1 becomes committed."
},
{
"label": "Defer to implementation",
"description": "Leave the gap named but unresolved. Engineer decides the button styles at implementation time without a spec. Risk: inconsistency with the design system or re-work after review."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 1 of 8 \u2014 Save button visual hierarchy: apply DESIGN.md primary button style?": "Apply DESIGN.md fix (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:16:44.618Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_017zBFd8ifxP7MFxNBAC2TpV",
"questions": [
{
"question": "Gap 2 of 8 \u2014 Spacing: standardize to DESIGN.md 8px-base scale?",
"header": "Gap 2: Spacing",
"multiSelect": false,
"options": [
{
"label": "Apply DESIGN.md fix (recommended)",
"description": "Add to plan: sections 32px apart, field groups 24px, label-to-input 8px. Removes the 16px outlier and gives implementation a single source of truth. Implementation task T2 becomes committed."
},
{
"label": "Defer to implementation",
"description": "Leave the inconsistency noted. Engineer picks spacing values during build. Risk: the 16px outlier persists and the form feels uneven at different scroll positions."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 2 of 8 \u2014 Spacing: standardize to DESIGN.md 8px-base scale?": "Apply DESIGN.md fix (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:17:07.703Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_018S3TMnN9HV9S75z8svkcUN",
"questions": [
{
"question": "Gap 3 of 8 \u2014 Error color contrast: apply DESIGN.md #991b1b on #fef2f2 tokens?",
"header": "Gap 3: Color",
"multiSelect": false,
"options": [
{
"label": "Apply DESIGN.md fix (recommended)",
"description": "Add to plan: error text uses #991b1b on #fef2f2 surface with an icon. Brings error states to WCAG AA contrast (from the current ~3:1). Implementation task T3 becomes committed."
},
{
"label": "Defer to implementation",
"description": "Leave the contrast gap noted. Engineer resolves the color at build time. Risk: a shipped accessibility violation, since the current ~3:1 is below WCAG AA minimum of 4.5:1."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 3 of 8 \u2014 Error color contrast: apply DESIGN.md #991b1b on #fef2f2 tokens?": "Apply DESIGN.md fix (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:17:24.757Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_011rznHG5hrLyBFvZ4gCmt5s",
"questions": [
{
"question": "Gap 4 of 8 \u2014 Typography: consolidate to two sizes per DESIGN.md (16px + 20px)?",
"header": "Gap 4: Type",
"multiSelect": false,
"options": [
{
"label": "Apply DESIGN.md fix (recommended)",
"description": "Add to plan: all body text, form labels, and helper text use 16px; section headings (h2) use 20px. The rogue 14px and 18px sizes are removed. Creates stronger two-level hierarchy. Task T4 committed."
},
{
"label": "Defer to implementation",
"description": "Leave the three-size inconsistency noted. Engineer picks which sizes to use at build time. Risk: the 14px text may persist and fail WCAG AA body-text contrast at small size."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 4 of 8 \u2014 Typography: consolidate to two sizes per DESIGN.md (16px + 20px)?": "Apply DESIGN.md fix (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:17:34.295Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_01BWGpyri31dDYV7Qn1ntbrq",
"questions": [
{
"question": "Gap 5 of 8 \u2014 Motion: add DESIGN.md spinner pattern for Save pending state?",
"header": "Gap 5: Motion",
"multiSelect": false,
"options": [
{
"label": "Apply DESIGN.md fix (recommended)",
"description": "Add to plan: on Save click, disable the button, show an inline spinner beside 'Saving\u2026', set aria-busy=true. With reduced-motion: no spinner, text only. Success clears to 'Saved at HH:mm'. Task T5 committed."
},
{
"label": "Defer to implementation",
"description": "Leave the frozen-page gap noted. Engineer designs the loading state at build time. Risk: inconsistency with the established spinner pattern and a 2-5s blank page on every save."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 5 of 8 \u2014 Motion: add DESIGN.md spinner pattern for Save pending state?": "Apply DESIGN.md fix (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:17:43.823Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_01LngzQi1Ukw4EmxesxaSfDc",
"questions": [
{
"question": "Gap 6 of 8 \u2014 Export-while-dirty: specify that Export reads saved values only?",
"header": "Gap 6: Export",
"multiSelect": false,
"options": [
{
"label": "Export reads last-saved values (recommended)",
"description": "Add to plan: Export downloads the last-saved preferences, ignoring unsaved edits. No implicit save triggered. Unsaved-changes status persists. Matches the atomic-save philosophy already in the plan."
},
{
"label": "Export reads current (unsaved) field values",
"description": "Add to plan: Export includes whatever is currently in the form fields, whether saved or not. The download reflects the user's in-progress state. Simpler to implement but may surprise users who export before saving."
},
{
"label": "Defer to implementation",
"description": "Leave this scenario unspecified. Engineer decides at build time. Risk: inconsistent behavior between implementations or user confusion when exported JSON differs from what they see in the form."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 6 of 8 \u2014 Export-while-dirty: specify that Export reads saved values only?": "Export reads last-saved values (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:17:59.395Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_01G1HXr6nAGLxkd2ntnqGpk7",
"questions": [
{
"question": "Gap 7 of 8 \u2014 Ghost button spec: reference existing component or add explicit values?",
"header": "Gap 7: Ghost btn",
"multiSelect": false,
"options": [
{
"label": "Reference existing Button component ghost variant (recommended)",
"description": "Add to plan: 'Reset, Cancel, Export use the existing Button component ghost variant. No new CSS values are introduced.' Clean, DRY, ties to the component system."
},
{
"label": "State explicit CSS values in the plan",
"description": "Add to plan: ghost buttons have transparent background, 1px border #d1d5db, text #374151, hover background #f9fafb. Useful if the Button component doesn't yet have a ghost variant or its values are unclear."
},
{
"label": "Defer \u2014 leave ghost style unspecified",
"description": "Let the engineer look up or invent ghost button values at build time. Risk: visual inconsistency with other ghost buttons in the app."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 7 of 8 \u2014 Ghost button spec: reference existing component or add explicit values?": "Reference existing Button component ghost variant (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:18:20.487Z"
},
{
"sessionId": "775fbf0c-b6aa-4363-9927-31d7fc15f6d4",
"toolUseId": "toolu_01L28TR9p37GzvWFrLsMPZbH",
"questions": [
{
"question": "Gap 8 of 8 \u2014 InlineStatus during validation: specify it reads 'Unsaved changes'?",
"header": "Gap 8: LiveRegion",
"multiSelect": false,
"options": [
{
"label": "Specify 'Unsaved changes' during validation (recommended)",
"description": "Add to plan: when validation errors fire, InlineStatus text is 'Unsaved changes' (the normal dirty state). The live region announces once; field errors and ErrorSummary announce separately via focus. No simultaneous conflicting announcements."
},
{
"label": "Defer \u2014 leave live region coordination unspecified",
"description": "Let the engineer decide what InlineStatus reads during validation. Risk: screen reader announces conflicting states simultaneously if the live region and error summary fire at the same moment."
}
]
}
],
"answered": true,
"failed": false,
"answers": {
"Gap 8 of 8 \u2014 InlineStatus during validation: specify it reads 'Unsaved changes'?": "Specify 'Unsaved changes' during validation (recommended)"
},
"unansweredQuestionIndices": [],
"answeredAt": "2026-09-09T12:18:41.580Z"
}
]
}