Garry Tanandcapy-ai[bot]
a7968dc77d
* Keep deferred review findings on the PR instead of filing issues Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Repin the ship review section after the deferred-findings lead edit Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Keep the deferred record's severity as the plain label The reviewer's stated severity and Blocks text now sit in their own field, so a review-log row built from a deferred record keeps a severity the ledger can rank. The PR body renders the same line as before. Review-Finding: p1/adversarial-native#2 reader=adversarial-native Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Say deferred findings stay on the PR in the unattended docs Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
3.3 KiB
READY block
Sent by the lane: first the block exactly as gstack-ship-queue ready --pr <n> --no-screen|--screen
prints it, then the lane's own lines. The controller validates every field before the pin
enters train build. A missing or wrong field goes back to the lane, never into a train.
The tool's lines (shapes as printed; screen: is inserted as the second line under a train policy):
READY #<n> <sha40> STAMP_VERSION=unstamped
screen: <screen|no-screen> policy=<selection> nonce=<nonce> run=<run id or ->
pr: <PR url>
head: <sha40>
version: unstamped
base: origin/<BASE>@<base sha40>
ci: green at <sha12> (passed=<k> failed=0 pending=0 skipped=<s>)
PREGATE: pass tree=<tree12> head=<sha12> checks=<c>
gate: command=<"…"|none> full_e2e=<yes|no> gate-ahead=<…>
SHIP_RECEIPT: pr=<n> head=<sha12> version=- base=<BASE> tree=<tree> session_kind=unattended …
PLAN: approved <run id> row=<a-…> (…) | exempt <reason> | warn … (<CODE>)
READY_RECEIPT: <path the tool wrote> (<local and notes-ref detail>)
A wave PR (docs/ship-policy.md#wave-prs) adds two lines after READY, and the controller checks
that every constituent named is one the wave was planned for:
WAVE: <nonce> area=<area> branch=wave/<nonce> constituents=<k> integrator_commits=<i>
CONSTITUENTS: #<n>@<sha12>,#<n>@<sha12>,... (heads frozen; fixes go on the wave branch)
Under changelog_fragments (docs/ship-policy.md#changelog-fragments) the PR's entry is a
fragment, changelog.d/<slug>.md, never an [Unreleased] section or a version, and the
controller merges with train land or land, so no slot call follows this block.
The lane's own lines, after the block:
pin: <sha40> # the full head SHA, restated
screen choice: <--no-screen: cases <ids> ran focused and passed | --screen: <reason>>
flaky: <none | case, both run ids, logged in the ledger on <date>>
review passes: <n> (deferred: <findings kept on the PR, or none>)
Unverified: <none | each claim the lane did not check itself, and why>
Head frozen from now on; a push drops this PR from any train and I will READY again.
Unverified: is required. It lists every claim in the READY that the lane did not check
itself: a local test that timed out, a paid run skipped, a number a model reported, a claim
inherited from another thread, and a review finding set aside on an assumption nobody
tested. none means the lane looked for each of these and found none. A missing line is
asked for as a follow-up message: it never holds a PR out of a train, does not stale
READYs sent before the line existed, and needs no new ready or /ship run.
Optional lines a crew's rules file may require:
gate_run: <run id> tree=<tree12> # when lanes gate on their own machines
closes: #<issue>
image: <URL of the key before/after image>
Refuse (send back) when: the SHA is short or a fork head; SHIP_RECEIPT reads none or
invalid, or its head is not the pin; ci: is not green at the pin; PREGATE: is not
pass for the pin's tree; PLAN: is missing, says warn, or names another plan than the
brief's Plan: line; --no-screen names no cases; a flaky case is not in the ledger;
the PR page is "green" but no block was sent; the evidence offered is a cheap tier.
After the slot call the lane answers with the stamped head:
READY #<n> <stamped sha40> STAMP_VERSION=<X>